⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 18, 2006:

11:23 PM Changeset in webkit [16442] by hyatt
  • 2 edits in trunk/WebCore

Fix for 9805, <hr> not positioned properly following a previous empty sibling
that had clear:both set on it. Update self-collapsing block clearance
behavior to match what is specified in the latest draft of CSS2.1.

Reviewed by Eric

Added fast/block/margin-collapse/empty-clear-blocks.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::handleBottomOfBlock):
7:47 PM Changeset in webkit [22185] by beidson
  • 4 edits in branches/WindowsMerge/WebCore

YABF and merged an open source change

7:36 PM Changeset in webkit [16441] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Brady, landed by Brady

Send receivedResponse callback to ResourceLoaderClient when loading
file URLs.

See ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10845

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::fileLoadTimer):
7:21 PM Changeset in webkit [16440] by beidson
  • 16 edits in trunk

WebCore:

Reviewed by Anders

<rdar://problem/3028061> - WebKit never updates favicon
The WebKit enforced expiration date for icons has worked for some time, but the
move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
functionality. This patch fixes that up, along with some other architectural improvements,
the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.

  • bridge/mac/FrameMac.h: Added isLoadTypeReload()
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
  • bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
  • bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
  • dom/Document.h: Added m_iconURL (WebCore::Document::iconURL): Added (WebCore::Document::setIconURL): Ditto
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
  • page/Frame.cpp: (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
  • page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
  • page/FramePrivate.h: Nuked IconURL
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::isLoadTypeReload):

WebKit:

Reviewed by Anders

Implement a bridge method so WebCore can find the reload type of a frame load

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge isLoadTypeReload]):
7:10 PM Changeset in webkit [22184] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKit.vcproj

Fix more build bustage. Remove CoreGraphics.lib from the set of linked against libraries.

6:55 PM Changeset in webkit [22183] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage caused by removal of ColorCG.cpp I guess?

5:53 PM Changeset in webkit [22182] by seangies
  • 2 edits in branches/WindowsMerge/WebCore

Support bold & italics text with CG on Windows

4:44 PM Changeset in webkit [22181] by seangies
  • 7 edits in branches/WindowsMerge

Last few CoreGraphics integration compile fixes

4:15 PM Changeset in webkit [16439] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Tim H.

  • Re-add private method [DOMRGBColor _color] to DOMPrivate.h as it is it turns out that AppKit uses it.
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor _color]):
2:40 PM Changeset in webkit [16438] by weinig
  • 18 edits
    6 adds
    1 delete in trunk

WebCore:

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch

  • Whitespace cleanup for IDLParser.pm
  • Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException and DOMAbstractView into their own files.
  • Remove private method [DOMRGBColor _color] from DOMPrivate.h as it is not used and a public method is available now.
  • Remove internal method [DOMDocument _ownerElement] from DOMInternal.h as it not used.
  • Auto-generate method isContentEditable for DOMNode.
  • General cleanup of bindings code including removing unneeded #imports and whitespace cleanup
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (addElementClass): (elementClass): (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode WebCore::]): (-[DOMNode KJS::Bindings::]): (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (-[DOMNode dispatchEvent:]): (-[DOMElement image]): (-[DOMElement _font]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMElement _getURLAttribute:]): (-[DOMElement _NPObject]): (-[DOMElement isFocused]): (-[DOMRange dealloc]): (-[DOMRange finalize]): (-[DOMRange description]): (-[DOMRange startContainer]): (-[DOMRange startOffset]): (-[DOMRange endContainer]): (-[DOMRange endOffset]): (-[DOMRange collapsed]): (-[DOMRange commonAncestorContainer]): (-[DOMRange setStart::]): (-[DOMRange setEnd::]): (-[DOMRange setStartBefore:]): (-[DOMRange setStartAfter:]): (-[DOMRange setEndBefore:]): (-[DOMRange setEndAfter:]): (-[DOMRange collapse:]): (-[DOMRange selectNode:]): (-[DOMRange selectNodeContents:]): (-[DOMRange compareBoundaryPoints::]): (-[DOMRange deleteContents]): (-[DOMRange extractContents]): (-[DOMRange cloneContents]): (-[DOMRange insertNode:]): (-[DOMRange surroundContents:]): (-[DOMRange cloneRange]): (-[DOMRange toString]): (-[DOMRange detach]): (-[DOMRange _initWithRange:WebCore::]): (+[DOMRange _rangeWith:WebCore::]): (-[DOMRange WebCore::]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMNodeFilter WebCore::]): (-[DOMNodeFilter dealloc]): (-[DOMNodeFilter finalize]): (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]): (-[DOMNodeIterator WebCore::]): (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]): (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]): (-[DOMTreeWalker WebCore::]): (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]): (ObjCNodeFilterCondition::acceptNode): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]): (ObjCEventListener::find): (ObjCEventListener::create): (ObjCEventListener::handleEvent):
  • bindings/objc/DOMAbstractView.h: Added.
  • bindings/objc/DOMAbstractView.mm: Added. (-[DOMAbstractView document]): (-[DOMAbstractView WebCore::]): (-[DOMAbstractView _initWithAbstractView:WebCore::]): (+[DOMAbstractView _abstractViewWith:WebCore::]):
  • bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]): (-[DOMCSSRule _initWithRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]): (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEventException.h: Added.
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMException.h: Added.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (viewForElement): (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): (-[DOMHTMLInputElement _selectedRange]): (-[DOMHTMLInputElement _setAutofilled:]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMObject.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRange.h:
  • bindings/objc/DOMRangeException.h: Added.
  • bindings/objc/DOMViews.h:
  • bindings/objc/DOMViews.mm: Removed.
  • bindings/objc/DOMXPath.h:
  • bindings/objc/DOMXPathException.h: Added.
  • bindings/scripts/IDLParser.pm:
  • dom/Node.idl:

WebKit:

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch

  • MigrateHeaders.make:
2:37 PM Changeset in webkit [16437] by harrison
  • 5 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4494340> REGRESSION: Making the font size bigger/smaller in an HTML message doesn't affect the body until you reopen it

Problem was the public API -[WebView setTextSizeMultiplier] did not notify anyone that the value changed.


  • WebView/WebDocumentInternal.h: Add _textSizeMultiplierChanged to the _WebDocumentTextSizing protocol.


  • WebView/WebHTMLView.m: (-[WebHTMLView _textSizeMultiplierChanged]): Send [self _updateTextSizeMultiplier].


  • WebView/WebPDFView.m: (-[WebPDFView _textSizeMultiplierChanged]): ASSERT_NOT_REACHED() because WebPDFView does not track the common multiplier.


  • WebView/WebView.m: (-[WebView setTextSizeMultiplier:]): Send [self _notifyTextSizeMultiplierChanged];


(-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
Alter the _textSizeMultiplier directly so that notification is not sent.
Minor formatting.


(-[WebView _notifyTextSizeMultiplierChanged]):
New. Send _textSizeMultiplierChanged to all document views that track the common multiplier.

1:50 PM Changeset in webkit [22180] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix (release).

  • WebHistory.cpp: (_WebCoreHistoryProvider::containsItemForURLLatin1): Remove unused HRESULT. (_WebCoreHistoryProvider::containsItemForURLUnicode): Ditto.
1:42 PM Changeset in webkit [16436] by beidson
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

ACTUAL Windows build fix

1:32 PM Changeset in webkit [16435] by beidson
  • 2 edits in trunk/WebCore

Windows build fix

  • platform/win/TemporaryLinkStubs.cpp: (IconDatabase::setIconURLForPageURL):
12:56 PM Changeset in webkit [22179] by andersca
  • 7 adds in branches/WindowsMerge/WebKitTools

2006-09-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

Fork DumpRenderTree from OpenSource repository (r16433).


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added. (loadResourceIntoArray): (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
12:20 PM Changeset in webkit [16434] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/float

Add layout test for float bug.

12:12 PM Changeset in webkit [16433] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 3969, hr width doesn't update when it clears a float. This
was also a problem with tables and overflow sections.

Reviewed by Eric

Added fast/block/float/width-update-after-clear.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded):
12:07 PM Changeset in webkit [16432] by hyatt
  • 171 edits in trunk/LayoutTests/tables

Update table layout test results.

12:06 PM Changeset in webkit [16431] by hyatt
  • 140 edits in trunk/LayoutTests/tables/mozilla_expected_failures/marvin

Update table layout test results.

12:05 PM Changeset in webkit [16430] by hyatt
  • 114 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

Update table layout test results.

12:00 PM Changeset in webkit [16429] by hyatt
  • 568 edits in trunk/LayoutTests/tables/mozilla/marvin

Update table layout test results.

11:55 AM Changeset in webkit [16428] by hyatt
  • 469 edits in trunk/LayoutTests/tables/mozilla/bugs

Update table layout test results.

11:51 AM Changeset in webkit [22178] by beidson
  • 3 edits in branches/WindowsMerge/WebCore

Build Fix

11:45 AM Changeset in webkit [22177] by seangies
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

Forked FontCacheWin.cpp from OpenSource tree r16421

11:19 AM Changeset in webkit [16427] by thatcher
  • 2 edits in tags/WebKit-521.26.1/WebKit

Build fix and versioning.

11:16 AM Changeset in webkit [16426] by thatcher
  • 1 copy in tags/WebKit-521.26.1/WebKit

New tag part 2

11:15 AM Changeset in webkit [16425] by brmorris
  • 1 copy in S60/branches/3.1m

Creating new branch.

11:14 AM Changeset in webkit [16424] by thatcher
  • 1 add in tags/WebKit-521.26.1

New tag part 1.

11:13 AM Changeset in webkit [16423] by beidson
  • 7 edits in trunk/WebCore

Reviewed by John

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly

  • bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
  • bridge/win/FrameWin.h: Added originalRequestURL()
  • loader/icon/IconLoader.cpp: (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
  • page/Frame.cpp: (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url. (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
  • page/Frame.h: Added pure virtual originalRequestURL()
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::originalRequestURL): Added
11:11 AM Changeset in webkit [16422] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix, NSIntMapValueCallBacks is deprecated infavor of the new name NSIntegerMapValueCallBacks. Just make a new NSMapTableValueCallBacks of {NULL, NULL, NULL} to make it build on new or older systems.

2:25 AM Changeset in webkit [16421] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg

Make sure the paint method is not exited without popping
context and transparency layer.

2:16 AM Changeset in webkit [16420] by bdash
  • 2 edits in trunk/WebCore

2006-09-18 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Eric.



  • bindings/scripts/CodeGeneratorObjC.pm: For each file generated add a #ifdef <something>_SUPPORT / #endif pair if the idl file has a Conditional extended attribute

Sep 17, 2006:

11:45 PM Changeset in webkit [16419] by eseidel
  • 2 edits in trunk/WebCore

2006-09-17 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.


REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10813

  • bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
11:14 PM Changeset in webkit [16418] by eseidel
  • 2 edits in trunk/LayoutTests

2006-09-17 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.

  • fast/js/window-properties.html: make work in Firefox (hangs IE)
10:03 PM Changeset in webkit [16417] by ap
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
REGRESSION: Animated GIF ignores frame intervals and loops infinitely

No test possible.

  • platform/Image.cpp: (WebCore::Image::shouldAnimate): Don't check that there is more than one frame, maybe the rest just hasn't been loaded yet. (WebCore::Image::startAnimation): Move the frame count check here - there is no need to start animating before we get at least two frames.
9:46 PM Changeset in webkit [16416] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

2006-09-17 Eric Seidel <​eric@eseidel.com>

Add a textual dump of the window object property tree.

Reviewed by Sarge.

  • fast/js/window-properties-expected.txt: Added.
  • fast/js/window-properties.html: Added.
5:48 PM Changeset in webkit [16415] by hyatt
  • 6 edits in trunk/LayoutTests/tables/mozilla/bugs

Land updated tests for font changes.

5:46 PM Changeset in webkit [16414] by hyatt
  • 3 edits in trunk/LayoutTests/css2.1

Land updated tests for font changes.

5:45 PM Changeset in webkit [16413] by hyatt
  • 6 edits in trunk/LayoutTests/css1/font_properties

Land updated tests for font changes.

4:17 PM Changeset in webkit [16412] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Sarge

IconLoader now gracefully handles the condition where there's no document in the frame
(ie. PDFs)

  • loader/icon/IconLoader.cpp: (IconLoader::startLoading):
4:06 PM Changeset in webkit [16411] by hyatt
  • 5 edits in trunk/WebCore

Fix for bug 10899, rework how CSS keywords work to be smarter about
using the correct size when generic families change (e.g., monospace to
serif and vice versa).

Reviewed by aroben

Added fast/text/basic/generic-family-changes.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::fontSizeForKeyword):
  • css/cssstyleselector.h:
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::keywordSize): (WebCore::FontDescription::setKeywordSize): (WebCore::FontDescription::operator==):
4:04 PM Changeset in webkit [16410] by hyatt
  • 1 edit
    4 adds in trunk/LayoutTests

Adding layout test for bug 10899.

  • fast/text/basic/generic-family-changes-expected.checksum: Added.
  • fast/text/basic/generic-family-changes-expected.png: Added.
  • fast/text/basic/generic-family-changes-expected.txt: Added.
  • fast/text/basic/generic-family-changes.html: Added.
2:39 PM Changeset in webkit [16409] by aroben
  • 4 edits in trunk/WebKitTools

Reviewed by hyatt, sfalken.

Get DumpRenderTree compiling and limping along on Windows.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (loadResourceIntoArray): Added this function that WebCore::ImageWin needs from WebKit (main): Add NULL argument to Page constructor.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove incorrect "wininet.dll" argument to CC, fix JavaScriptCore.lib path, add *_SECURE_NO_DEPRECATE #defines
  • Scripts/webkitdirs.pm: Fix JavaScriptCore.lib path
1:18 PM Changeset in webkit [16408] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Brady.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
REGRESSION: Reproducible crash in XMLHttpRequest::abort()

Test: http/tests/xmlhttprequest/xhr-onunload.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
  • loader/icon/IconLoader.cpp: (IconLoader::startLoading): Fix a similar latent bug here.
12:37 PM Changeset in webkit [16407] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • loader/icon/IconDatabase.cpp:
12:29 PM Changeset in webkit [22176] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebView.cpp: (WebView::keyPress): Add new "userTriggered" argument to calls to SelectionController::modify
12:24 PM Changeset in webkit [16406] by hyatt
  • 1 edit in trunk/LayoutTests/fast/text/whitespace/013-expected.txt

Land updated results from font fix yesterday.

11:36 AM Changeset in webkit [16405] by andersca
  • 29 edits in trunk/WebCore

2006-09-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Brady.

Add simplifyWhiteSpace and stripWhiteSpace to the String class.
Change the XSLT Parameter Map to use Strings instead of StringImpls.
General cleanup.

  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • css/MediaList.cpp: (WebCore::MediaList::setMediaText):
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init):
  • html/HTMLDocument.cpp: (WebCore::parseDocTypeDeclaration):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::setComplete): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::recalcStyle): (WebCore::HTMLObjectElement::childrenChanged): (WebCore::HTMLObjectElement::isImageType):
  • html/HTMLObjectElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::value):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::appendFormData):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
  • ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::description):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::stripWhiteSpace): (WebCore::String::simplifyWhiteSpace):
  • platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace): (WebCore::StringImpl::toInt):
  • platform/StringImpl.h:
  • platform/mac/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunNormalizeSpace::doEvaluate):
  • xml/XPathGrammar.y:
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): (WebCore::XSLStyleSheet::locateStylesheetSubResource):
  • xml/XSLTProcessor.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::XSLTProcessor::setParameter): (WebCore::XSLTProcessor::getParameter): (WebCore::XSLTProcessor::removeParameter):
  • xml/XSLTProcessor.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getStatusText):
8:28 AM Changeset in webkit [16404] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Add fieldset layout test.

8:27 AM Changeset in webkit [16403] by hyatt
  • 7 edits in trunk/WebCore

Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
are declared right before the fieldsets. It turns out fieldsets in other
browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
adding that behavior to fieldset fixes the bug.

Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
and fieldsets all subclass.

Reviewed by anders

Added fast/forms/float-before-fieldset.html

  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::avoidsFloats):
  • rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::avoidsFloats):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::avoidsFloats):
  • rendering/RenderObject.h:
  • rendering/RenderTable.h: (WebCore::RenderTable::avoidsFloats):
7:35 AM Changeset in webkit [16402] by hyatt
  • 1 edit in trunk/LayoutTests/tables/mozilla/bugs/bug24200.html

Update buggy table test to not have a degenrate column structure.

7:35 AM Changeset in webkit [16401] by hyatt
  • 1 edit in trunk/LayoutTests/tables/mozilla_expected_failures/core/table_rules.html

Update buggy table test to say rules=groups and not rules=group

1:00 AM Changeset in webkit [16400] by hyatt
  • 4 adds in trunk/LayoutTests/fast/table

Add frame/rules layout test.

12:57 AM Changeset in webkit [16399] by hyatt
  • 9 edits in trunk/WebCore

Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
"rules" attributes on tables.

Reviewed by bradee-oh

Well-covered by existing layout tests.

  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::~HTMLTableElement): (WebCore::HTMLTableElement::setCaption): (WebCore::HTMLTableElement::setTHead): (WebCore::HTMLTableElement::setTFoot): (WebCore::HTMLTableElement::setTBody): (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::deleteTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::deleteTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::deleteCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::deleteRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::childrenChanged): (WebCore::HTMLTableElement::mapToEntry): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecl): (WebCore::HTMLTableElement::getSharedCellDecl): (WebCore::HTMLTableElement::getSharedGroupDecl): (WebCore::HTMLTableElement::attach):
  • html/HTMLTableElement.h: (WebCore::HTMLTableElement::caption): (WebCore::HTMLTableElement::tHead): (WebCore::HTMLTableElement::tFoot): (WebCore::HTMLTableElement::):
  • html/HTMLTableRowElement.h:
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
  • html/HTMLTableSectionElement.h:
12:43 AM Changeset in webkit [16398] by hyatt
  • 4 adds in trunk/LayoutTests/fast/text/basic

Add layout test for bug 4192.

12:39 AM Changeset in webkit [16397] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog

Fix for bugzilla bug 4192, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:39 AM Changeset in webkit [16396] by hyatt
  • 2 edits in trunk/WebCore

Fix for bugzilla bug 4129, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:29 AM Changeset in webkit [16395] by beidson
  • 18 edits
    2 deletes in trunk

WebCore:

Reviewed by Hyatt

Pruning code relating to WebKit's icon loader

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm:
  • loader/icon/IconDatabase.h:
  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to its new home

WebKit:

Reviewed by Hyatt

WebIconLoader is dead, long live WebCore::IconLoader
(code prune)

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader commitProvisionalLoad]):
  • Loader/WebIconLoader.h: Removed.
  • Loader/WebIconLoader.m: Removed.
  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.m:
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]):
  • WebCoreSupport/WebIconDatabaseBridge.h:
  • WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge _init]): (-[WebIconDatabaseBridge _setIconData:forIconURL:]): (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]):
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setPrimaryLoadComplete:]):
  • WebView/WebDataSourceInternal.h:
Note: See TracTimeline for information about the timeline view.