Context Navigation

← Previous Period
Next Period →

Timeline

Sep 19, 2006:

10:37 PM Changeset in webkit [16462] by eseidel

30 edits in trunk

2006-09-19 Eric Seidel <eric@eseidel.com>

Reviewed by adele.

Improve test output for filters with bounding-box relative sizes.
http://bugzilla.opendarwin.org/show_bug.cgi?id=8585

Many test results updated.

kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation):

10:26 PM Changeset in webkit [16461] by eseidel

6 edits
4 adds in trunk

2006-09-19 Eric Seidel <eric@eseidel.com>

Reviewed by adele.

Markers should clip to their viewport.
http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

Test: svg/custom/marker-overflow-clip.svg

kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::KCanvasMarker): (WebCore::KCanvasMarker::setMarker): (WebCore::KCanvasMarker::draw):
kcanvas/KCanvasResources.h: (WebCore::KCanvasMasker::mask):
ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::canvasResource): (WebCore::SVGMarkerElement::createRenderer):

8:57 PM Changeset in webkit [16460] by beidson

1 edit in trunk/WebCore/ChangeLog

Checking the mail post-commit hook on the new server

8:46 PM Changeset in webkit [16459] by beidson

1 edit in trunk/WebCore/ChangeLog

Checkin test on the new hardware!

6:57 PM Changeset in webkit [16458] by justing

3 edits
1 add
1 delete in trunk

LayoutTests:

Reviewed by eseidel

Disabling this test temporarily.

editing/selection/editable-links.html: Removed.
editing/selection/editable-links.html-disabled: Added.

WebCore:

Reviewed by eseidel

Backing out my recent change.

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):

5:53 PM Changeset in webkit [16457] by beidson

2 edits in trunk/WebCore

Reviewed by Kevin McCullough

http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
Opening a PDF in a new tab/window creates a documentless-frame
and we deref the document without checking its validity

page/Frame.cpp: (WebCore::Frame::iconURL):

4:36 PM Changeset in webkit [16456] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

editing/selection/editable-links-expected.checksum: Added.
editing/selection/editable-links-expected.png: Added.
editing/selection/editable-links-expected.txt: Added.
editing/selection/editable-links.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4735272>
Can not click into link in programmatically editable content

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using userModify to implement document wide editability.

4:25 PM Changeset in webkit [16455] by beidson

1 edit in trunk/WebCore/ChangeLog

I totally LIED in the Changelog

4:24 PM Changeset in webkit [16454] by beidson

2 edits in trunk/WebCore

Reviewed and landed by Brady

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
Build broken when SVG is not enabled.

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):

3:44 PM Changeset in webkit [16453] by beidson

1 edit
1 add in trunk/WebKitSite

http://bugzilla.opendarwin.org/show_bug.cgi?id=8220
Add the favicon.ico to the site.
Notice, users of shipping Safari won't see the updated favicon
unless they clear their icon cache - ToT users can manually reload
the site and force the refresh ;)

favicon.ico: Added.

3:01 PM Changeset in webkit [16452] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

editing/pasteboard/pasting-tabs-expected.checksum: Added.
editing/pasteboard/pasting-tabs-expected.png: Added.
editing/pasteboard/pasting-tabs-expected.txt: Added.
editing/pasteboard/pasting-tabs.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces

Pasting plain text results in a match style paste, and the insertion
position is whitespace normal, which clobbers the whitespace:pre on
tab spans. Skip changes to the whitespace mode when computing a style
change for tab spans or the text nodes inside tab spans.

editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Don't change the whitespace mode inside tab spans.

2:31 PM Changeset in webkit [16451] by hyatt

3 edits in trunk/WebCore

Fix for bug 5298, shape=default not supported for image maps. Implement
support for it.

Reviewed by timo

html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::getRegion):
html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent):

11:04 AM Changeset in webkit [16450] by ap

2 edits in trunk/WebKit

Reviewed by Tim O.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10661
REGRESSION: CFM plug-ins (Shockwave, SVG) are not loaded

Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): On 32-bit PowerPC, don't bail out if the bundle is nil - it can be a CFM plugin.

10:25 AM Changeset in webkit [16449] by aroben

5 edits in trunk/LayoutTests

Reviewed by Adele.

Update tests for the new file upload control.

fast/forms/file-input-disabled-expected.txt:
fast/forms/form-element-geometry-expected.txt:
fast/forms/input-appearance-height-expected.txt:
fast/forms/input-value-expected.txt:

10:23 AM Changeset in webkit [16448] by aroben

3 edits in trunk/WebCore

Reviewed by Adele.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
"no file selected" placeholder text missing from file upload control

WebCore.xcodeproj/project.pbxproj:
rendering/RenderFileUploadControl.cpp: Remove class RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to defaultWidthNumChars (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call RenderBlock constructor instead of RenderFlexibleBox, (WebCore::RenderFileUploadControl::setStyle): Remove references to m_fileBox. (WebCore::RenderFileUploadControl::valueChanged): Call repaint() instead of updateIconAndFileName() (which has been removed) (WebCore::RenderFileUploadControl::updateFromElement): Remove references to m_fileBox, don't call updateIconAndFilename() (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width without using m_fileBox (WebCore::RenderFileUploadControl::createButtonStyle): Remove now-unnecessary display:box rule. (WebCore::RenderFileUploadControl::paintObject): Remove redundant call to paintingDisabled() now that Icon::paint() does it, and add code to paint the filename directly. (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a subclass of RenderBlock instead of RenderFlexibleBox, remove updateIconAndFilename() method, remove m_fileBox instance variable.

5:17 AM Changeset in webkit [22186] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-09-19 Anders Carlsson <acarlsson@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/4734743> Crash accessing YouTube.

config.h: Enable some more of the JSC bindings code on Windows.

2:48 AM Changeset in webkit [16447] by eseidel

2 edits in trunk/WebCore

2006-09-19 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.

Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
http://bugzilla.opendarwin.org/show_bug.cgi?id=10846

No automated test case possible until http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs):

2:39 AM Changeset in webkit [16446] by eseidel

2 edits in trunk/WebKitTools

2006-09-19 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by eseidel. Landed by eseidel.

Detect that close button was pressed and exit cleanly.

GdkLauncher/main.cpp: (handle_event): (main):

2:37 AM Changeset in webkit [16445] by eseidel

4 edits in trunk/WebCore

2006-09-19 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by eseidel. Landed by eseidel.

Build fix only, no tests affected.

platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
platform/gdk/FrameGdk.h:
platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::isLoadTypeReload): (FrameGdk::originalRequestURL): (IconDatabase::setIconURLForPageURL):

2:10 AM Changeset in webkit [16444] by hyatt

2 edits in trunk/WebCore

Refine the fix for 9805 to really get all the complex cases right.

Reviewed by Eric

rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::handleBottomOfBlock):

2:08 AM Changeset in webkit [16443] by hyatt

4 adds
4 deletes in trunk/LayoutTests/fast/block/margin-collapse

Land changes for margin collapsing fixes. Yank bad layout test.

Sep 18, 2006:

11:23 PM Changeset in webkit [16442] by hyatt

2 edits in trunk/WebCore

Fix for 9805, <hr> not positioned properly following a previous empty sibling
that had clear:both set on it. Update self-collapsing block clearance
behavior to match what is specified in the latest draft of CSS2.1.

Reviewed by Eric

Added fast/block/margin-collapse/empty-clear-blocks.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::handleBottomOfBlock):

7:47 PM Changeset in webkit [22185] by beidson

4 edits in branches/WindowsMerge/WebCore

YABF and merged an open source change

7:36 PM Changeset in webkit [16441] by beidson

2 edits in trunk/WebCore

Reviewed by Brady, landed by Brady

Send receivedResponse callback to ResourceLoaderClient when loading
file URLs.

See http://bugzilla.opendarwin.org/show_bug.cgi?id=10845

platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::fileLoadTimer):

7:21 PM Changeset in webkit [16440] by beidson

16 edits in trunk

WebCore:

Reviewed by Anders

<rdar://problem/3028061> - WebKit never updates favicon
The WebKit enforced expiration date for icons has worked for some time, but the
move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
functionality. This patch fixes that up, along with some other architectural improvements,
the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.

bridge/mac/FrameMac.h: Added isLoadTypeReload()
bridge/mac/FrameMac.mm: (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
dom/Document.h: Added m_iconURL (WebCore::Document::iconURL): Added (WebCore::Document::setIconURL): Ditto
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
page/Frame.cpp: (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
page/FramePrivate.h: Nuked IconURL
platform/win/TemporaryLinkStubs.cpp: (FrameWin::isLoadTypeReload):

WebKit:

Reviewed by Anders

Implement a bridge method so WebCore can find the reload type of a frame load

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge isLoadTypeReload]):

7:10 PM Changeset in webkit [22184] by hyatt

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKit.vcproj

Fix more build bustage. Remove CoreGraphics.lib from the set of linked against libraries.

6:55 PM Changeset in webkit [22183] by hyatt

1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage caused by removal of ColorCG.cpp I guess?

5:53 PM Changeset in webkit [22182] by seangies

2 edits in branches/WindowsMerge/WebCore

Support bold & italics text with CG on Windows

4:44 PM Changeset in webkit [22181] by seangies

7 edits in branches/WindowsMerge

Last few CoreGraphics integration compile fixes

4:15 PM Changeset in webkit [16439] by weinig

3 edits in trunk/WebCore

Reviewed by Tim H.

Re-add private method [DOMRGBColor _color] to DOMPrivate.h as it is it turns out that AppKit uses it.

bindings/objc/DOMPrivate.h:
bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor _color]):

2:40 PM Changeset in webkit [16438] by weinig

18 edits
6 adds
1 delete in trunk

WebCore:

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch

Whitespace cleanup for IDLParser.pm

Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException and DOMAbstractView into their own files.

Remove private method [DOMRGBColor _color] from DOMPrivate.h as it is not used and a public method is available now.

Remove internal method [DOMDocument _ownerElement] from DOMInternal.h as it not used.

Auto-generate method isContentEditable for DOMNode.

General cleanup of bindings code including removing unneeded #imports and whitespace cleanup

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (addElementClass): (elementClass): (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode WebCore::]): (-[DOMNode KJS::Bindings::]): (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (-[DOMNode dispatchEvent:]): (-[DOMElement image]): (-[DOMElement _font]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMElement _getURLAttribute:]): (-[DOMElement _NPObject]): (-[DOMElement isFocused]): (-[DOMRange dealloc]): (-[DOMRange finalize]): (-[DOMRange description]): (-[DOMRange startContainer]): (-[DOMRange startOffset]): (-[DOMRange endContainer]): (-[DOMRange endOffset]): (-[DOMRange collapsed]): (-[DOMRange commonAncestorContainer]): (-[DOMRange setStart::]): (-[DOMRange setEnd::]): (-[DOMRange setStartBefore:]): (-[DOMRange setStartAfter:]): (-[DOMRange setEndBefore:]): (-[DOMRange setEndAfter:]): (-[DOMRange collapse:]): (-[DOMRange selectNode:]): (-[DOMRange selectNodeContents:]): (-[DOMRange compareBoundaryPoints::]): (-[DOMRange deleteContents]): (-[DOMRange extractContents]): (-[DOMRange cloneContents]): (-[DOMRange insertNode:]): (-[DOMRange surroundContents:]): (-[DOMRange cloneRange]): (-[DOMRange toString]): (-[DOMRange detach]): (-[DOMRange _initWithRange:WebCore::]): (+[DOMRange _rangeWith:WebCore::]): (-[DOMRange WebCore::]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMNodeFilter WebCore::]): (-[DOMNodeFilter dealloc]): (-[DOMNodeFilter finalize]): (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]): (-[DOMNodeIterator WebCore::]): (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]): (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]): (-[DOMTreeWalker WebCore::]): (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]): (ObjCNodeFilterCondition::acceptNode): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]): (ObjCEventListener::find): (ObjCEventListener::create): (ObjCEventListener::handleEvent):
bindings/objc/DOMAbstractView.h: Added.
bindings/objc/DOMAbstractView.mm: Added. (-[DOMAbstractView document]): (-[DOMAbstractView WebCore::]): (-[DOMAbstractView _initWithAbstractView:WebCore::]): (+[DOMAbstractView _abstractViewWith:WebCore::]):
bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]): (-[DOMCSSRule _initWithRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]): (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
bindings/objc/DOMCore.h:
bindings/objc/DOMEventException.h: Added.
bindings/objc/DOMEvents.h:
bindings/objc/DOMEvents.mm:
bindings/objc/DOMException.h: Added.
bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (viewForElement): (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): (-[DOMHTMLInputElement _selectedRange]): (-[DOMHTMLInputElement _setAutofilled:]):
bindings/objc/DOMInternal.h:
bindings/objc/DOMObject.h:
bindings/objc/DOMPrivate.h:
bindings/objc/DOMRange.h:
bindings/objc/DOMRangeException.h: Added.
bindings/objc/DOMViews.h:
bindings/objc/DOMViews.mm: Removed.
bindings/objc/DOMXPath.h:
bindings/objc/DOMXPathException.h: Added.
bindings/scripts/IDLParser.pm:
dom/Node.idl:

WebKit:

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch

MigrateHeaders.make:

2:37 PM Changeset in webkit [16437] by harrison

5 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4494340> REGRESSION: Making the font size bigger/smaller in an HTML message doesn't affect the body until you reopen it

Problem was the public API -[WebView setTextSizeMultiplier] did not notify anyone that the value changed.

WebView/WebDocumentInternal.h: Add _textSizeMultiplierChanged to the _WebDocumentTextSizing protocol.

WebView/WebHTMLView.m: (-[WebHTMLView _textSizeMultiplierChanged]): Send [self _updateTextSizeMultiplier].

WebView/WebPDFView.m: (-[WebPDFView _textSizeMultiplierChanged]): ASSERT_NOT_REACHED() because WebPDFView does not track the common multiplier.

WebView/WebView.m: (-[WebView setTextSizeMultiplier:]): Send [self _notifyTextSizeMultiplierChanged];

(-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
Alter the _textSizeMultiplier directly so that notification is not sent.
Minor formatting.

(-[WebView _notifyTextSizeMultiplierChanged]):
New. Send _textSizeMultiplierChanged to all document views that track the common multiplier.

1:50 PM Changeset in webkit [22180] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Build fix (release).

WebHistory.cpp: (_WebCoreHistoryProvider::containsItemForURLLatin1): Remove unused HRESULT. (_WebCoreHistoryProvider::containsItemForURLUnicode): Ditto.

1:42 PM Changeset in webkit [16436] by beidson

1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

ACTUAL Windows build fix

1:32 PM Changeset in webkit [16435] by beidson

2 edits in trunk/WebCore

Windows build fix

platform/win/TemporaryLinkStubs.cpp: (IconDatabase::setIconURLForPageURL):

12:56 PM Changeset in webkit [22179] by andersca

7 adds in branches/WindowsMerge/WebKitTools

2006-09-18 Anders Carlsson <acarlsson@apple.com>

Reviewed by John.

Fork DumpRenderTree from OpenSource repository (r16433).

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added. (loadResourceIntoArray): (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.

12:20 PM Changeset in webkit [16434] by hyatt

4 adds in trunk/LayoutTests/fast/block/float

Add layout test for float bug.

12:12 PM Changeset in webkit [16433] by hyatt

2 edits in trunk/WebCore

Fix for bug 3969, hr width doesn't update when it clears a float. This
was also a problem with tables and overflow sections.

Reviewed by Eric

Added fast/block/float/width-update-after-clear.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded):

12:07 PM Changeset in webkit [16432] by hyatt

171 edits in trunk/LayoutTests/tables