⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 20, 2006:

11:27 PM Changeset in webkit [16492] by bdash
  • 22 edits in trunk/WebKitSite

2006-09-21 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by TimH.

Updates to make static pages validate as HTML 4.01 Strict.

  • building/build.html:
  • coding/coding-style.html:
  • header.inc:
  • index.html: Move <style> tag into the document head.
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html: Remove note about <label> not being implemented correctly.
  • projects/html/index.html:
  • projects/javascript/index.html:
  • projects/performance/index.html:
  • projects/portability/index.html: Change mention of Windows port to note that it is in progress rather than non-existant.
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/xslt/index.html:
  • quality/bugwriting.html: Update WebKit version numbers to be accurate. Move JS away from using innerHTML as W3C validator doesn't like it.
  • quality/reduction.html:
  • quality/reporting.html: Rename element IDs that start with numbers. Update WebKit and Mac OS X version numbers to be accurate.
  • quality/testing.html:
8:45 PM Changeset in webkit [16491] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Bug 10917: REGRESSION (r16027): iFrame transparency broken
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10917

Don't paint the base background color if we transparent.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
6:28 PM Changeset in webkit [22191] by sfalken
  • 12 edits in branches/WindowsMerge/WebKitWin

2006-09-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada Chan.


<rdar://4601547> Character encoding menu/switching


Encoding menu and prefs pop-up are now hooked up and working.


List of encodings is identical to the Mac version, with encodings
not supported by icu removed. Localized names of these encodings
and IANA names are retrieved via MLANG from code pages. It
would have been nice to use ICU for this, but the call to get
a displayable encoding name from an IANA name doesn't return
user readable names. CF couldn't be used, since the open source
CF doesn't have encoding support that it would normally get via TEC.


There's currently a problem where the encoding doesn't get
picked up out of the incoming HTML document out of <meta>, so
the text encoding menu comes in especially handy at the moment.

6:15 PM Changeset in webkit [22190] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Hook up the WebIconDatabase enabled preference

5:54 PM Changeset in webkit [16490] by aroben
  • 2 edits in trunk/WebCore

Reviewed by andersca.

  • platform/FileChooser.h: Remove no-longer-necessary namespace std
4:52 PM Changeset in webkit [16489] by seangies
  • 1 edit in trunk/WebCore/platform/FontData.h

Fix up conditional.

4:52 PM Changeset in webkit [22189] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Runtime fix - removed an obsolete, overzealous ASSERTion

4:38 PM Changeset in webkit [22188] by seangies
  • 2 edits
    2 adds in branches/WindowsMerge/WebCore

Add platform/cg/ColorCG.cpp

4:37 PM Changeset in webkit [16488] by eseidel
  • 44 edits in trunk/WebCore

2006-09-20 Eric Seidel <​eric@eseidel.com>

Reviewed by beth.

Cleanup style in KCanvas.
Remove extra white-space, unneeded arguments, etc.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: (WebCore::operator<<): (WebCore::KCanvasClipper::externalRepresentation):
  • kcanvas/KCanvasClipper.h:
  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation): (WebCore::operator<<): (WebCore::KCanvasFilterEffect::externalRepresentation): (WebCore::KCPointLightSource::externalRepresentation): (WebCore::KCSpotLightSource::externalRepresentation): (WebCore::KCDistantLightSource::externalRepresentation): (WebCore::KCanvasFEBlend::externalRepresentation): (WebCore::KCanvasFEColorMatrix::externalRepresentation): (WebCore::KCanvasFEComponentTransfer::externalRepresentation): (WebCore::KCanvasFEComposite::externalRepresentation): (WebCore::KCanvasFEConvolveMatrix::externalRepresentation): (WebCore::KCanvasFEDiffuseLighting::externalRepresentation): (WebCore::KCanvasFEDisplacementMap::externalRepresentation): (WebCore::KCanvasFEFlood::externalRepresentation): (WebCore::KCanvasFEGaussianBlur::externalRepresentation): (WebCore::KCanvasFEImage::externalRepresentation): (WebCore::KCanvasFEMerge::externalRepresentation): (WebCore::KCanvasFEMorphology::externalRepresentation): (WebCore::KCanvasFEOffset::externalRepresentation): (WebCore::KCanvasFESpecularLighting::externalRepresentation): (WebCore::KCanvasFETile::externalRepresentation): (WebCore::KCanvasFETurbulence::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEDiffuseLighting::lightSource): (WebCore::KCanvasFESpecularLighting::lightSource):
  • kcanvas/KCanvasImage.h:
  • kcanvas/KCanvasMarker.cpp: (WebCore::KCanvasMarker::externalRepresentation):
  • kcanvas/KCanvasMarker.h:
  • kcanvas/KCanvasResource.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasResource.h:
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<): (WebCore::writeIndent): (WebCore::writeStyle): (WebCore::write): (WebCore::writeRenderResources):
  • kcanvas/KCanvasTreeDebug.h: (WebCore::operator<<):
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::drawStartAndMidMarkers):
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/device/KRenderingDevice.cpp: (WebCore::KRenderingDevice::currentContext): (WebCore::KRenderingDevice::popContext): (WebCore::KRenderingDevice::pushContext):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): (WebCore::KRenderingPaintServer::activeClient): (WebCore::KRenderingPaintServer::setActiveClient):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::operator<<): (WebCore::KRenderingPaintServerGradient::externalRepresentation): (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation): (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener): (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener): (WebCore::KRenderingPaintServerPattern::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.cpp: (WebCore::KRenderingPaintServerSolid::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/KRenderingStrokePainter.cpp: (WebCore::KRenderingStrokePainter::strokeMiterLimit): (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter):
  • kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (WebCore::KCanvasImageQuartz::init):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::quartzContext): (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource): (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::CGShadingRefForLinearGradient): (WebCore::CGShadingRefForRadialGradient): (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerQuartzHelper::strokePath): (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath): (WebCore::KRenderingPaintServerQuartzHelper::fillPath): (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath): (WebCore::KRenderingPaintServerSolidQuartz::draw): (WebCore::KRenderingPaintServerSolidQuartz::setup): (WebCore::KRenderingPaintServerSolidQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::setup): (WebCore::KRenderingPaintServerPatternQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::teardown):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext):
3:45 PM Changeset in webkit [16487] by andersca
  • 4 edits in trunk

JavaScriptCore:

2006-09-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

  • wtf/MathExtras.h: Get rid of lrint.

WebCore:

2006-09-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Use lroundf instead of lround since deltas are floats.
3:38 PM Changeset in webkit [16486] by eseidel
  • 3 edits
    4 adds in trunk

2006-09-20 Julien Palmas <​julien.palmas@gmail.com>

Reviewed by eseidel. Landed by eseidel.

Test: svg/custom/pattern-y-offset.svg

  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerPatternQuartz::setup):
3:37 PM Changeset in webkit [16485] by hyatt
  • 3 edits in trunk/WebCore

Add a new wheelEvent method to ScrollView. Platforms that wish
to handle the wheel event for the scroll view themselves can then
do so there. (Mac lets the underlying NSScrollView do it for now.)

  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/ScrollView.h: (WebCore::ScrollView::wheelEvent):
3:22 PM Changeset in webkit [22187] by seangies
  • 2 edits in branches/WindowsMerge/WebCore

Fixed font-spacing issue with CG

2:59 PM Changeset in webkit [16484] by seangies
  • 2 edits in trunk/JavaScriptCore

Send debug messages to debugger console.

2:44 PM Changeset in webkit [16483] by thatcher
  • 2 edits in trunk/WebKit/Misc

Fix copyright year.

2:32 PM Changeset in webkit [16482] by beidson
  • 5 edits in trunk

WebCore:

Reviewed by Tim Omernick

Part of fixing a crash Tim O showed me that I missed in a release build.
WebKit should be able to call through the bridge to WebCore no matter what -
Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge isOpen]): (-[WebCoreIconDatabaseBridge removeAllIcons]): (-[WebCoreIconDatabaseBridge _isEmpty]): (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]): (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): (-[WebCoreIconDatabaseBridge _setEnabled:]): (-[WebCoreIconDatabaseBridge _isEnabled]):

WebKit:

Reviewed by Tim Omernick

Fixing part of a crash Tim O showed me. [WebIconDatabase init] should finish
gracefully even if we can't open the database

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]):
2:12 PM Changeset in webkit [16481] by hyatt
  • 2 edits in trunk/JavaScriptCore

Add an implementation of lrint for Win32.

Reviewed by anders

  • wtf/MathExtras.h: (lrint):
2:06 PM Changeset in webkit [16480] by zbujtas
  • 2 edits in S60/trunk/WebKit

2006-09-20 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas.
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10952
Changing the encoding in setting does not affect the browser behavior.

  • BrowserView/inc/CharsetData.h:
2:04 PM Changeset in webkit [16479] by andersca
  • 13 edits in trunk/WebCore

2006-09-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Add String::split which returns a Vector of Strings and use it instead of
DeprecatedStringList.


  • bindings/js/kjs_events.cpp: (KJS::Clipboard::getValueProperty):
  • bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures):
  • css/MediaList.cpp: (WebCore::MediaList::setMediaText):
  • dom/Clipboard.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::split):
  • platform/StringImpl.cpp:
  • platform/StringImpl.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::types):
1:43 PM Changeset in webkit [16478] by thatcher
  • 2 edits
    2 adds in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4741392> Develop a system to find what version of WebKit an app was linked with

  • Misc/WebKitVersionChecks.h: Added.
  • Misc/WebKitVersionChecks.m: Added. (WebKitLinkedOnOrAfter): Added. (WebKitLinkTimeVersion): Added. (WebKitRunTimeVersion): Added.
  • WebKit.xcodeproj/project.pbxproj:
1:31 PM Changeset in webkit [16477] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Fixed a typo.
12:20 PM Changeset in webkit [16476] by justing
  • 3 edits
    1 add
    1 delete in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/editable-links.html: Added.
  • editing/selection/editable-links.html-disabled: Removed.

WebCore:

Reviewed by harrison

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call HTMLElement::isContentEditable just to check the Frame's editability, since it calls updateRenderering, which can get us into infinite recursion.
12:16 PM Changeset in webkit [16475] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2006-09-19 spadma <​Sachin.Padma@nokia.com>

Reviewed by Sriram.
DESC: Fix key event handling in Auto Form Fill listbox
​http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserCore/Formcontrols/inc/FControlSelectWidget.h:
  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::OfferKeyEventL): (CControlSelectWidget::InputCapabilities):
12:12 PM Changeset in webkit [16474] by beidson
  • 4 edits in trunk

WebCore:

Reviewed by Darin

Cleaned up my last patch alot, and made the WebCore icon database disabled by default

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Disabled by default (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed) (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto (WebCore::IconDatabase::iconForPageURL): Ditto (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto (WebCore::IconDatabase::iconURLForPageURL): Ditto (WebCore::IconDatabase::retainIconForPageURL): Ditto (WebCore::IconDatabase::releaseIconForPageURL): Ditto (WebCore::IconDatabase::setIconDataForIconURL): Ditto (WebCore::IconDatabase::setIconURLForPageURL): Ditto (WebCore::IconDatabase::hasEntryForIconURL): Ditto (WebCore::IconDatabase::setEnabled): Fixed a big bug here!

WebKit:

Reviewed by Darin

Preparing to make the WebIconDatabase disabled by default - this patch tells the bridge whether its enabled or not

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]):
11:33 AM Changeset in webkit [16473] by aroben
  • 3 edits in trunk/LayoutTests

Reviewed by timothy.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10953
Test results for fast/js/window-properties.html should include
children of window.document.body.firstChild

  • fast/js/window-properties-expected.txt: Regenerate results which now include window.document.body.firstChild.*
  • fast/js/window-properties.html: Print out 'null' for null objects instead of 'object' for more clarity
10:42 AM Changeset in webkit [16472] by aroben
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Adele.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
REGRESSION: file upload control with direction:rtl or text-align:right
draws button on top of filename/icon

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::setStyle): Force text-align to match direction (WebCore::RenderFileUploadControl::paintObject): Fix positioning of the filename and icon in RTL

LayoutTests:

Reviewed by Adele.

Adding test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
REGRESSION: file upload control with direction:rtl or text-align:right
draws button on top of filename/icon

  • fast/forms/file-input-direction-expected.checksum: Added.
  • fast/forms/file-input-direction-expected.png: Added.
  • fast/forms/file-input-direction-expected.txt: Added.
  • fast/forms/file-input-direction.html: Added.
10:30 AM Changeset in webkit [16471] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

fixed windows build

  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): changed lrint to lround
9:20 AM Changeset in webkit [16470] by spadma
  • 3 edits in S60/trunk/WebKit

2006-09-19 spadma <​Sachin.Padma@nokia.com>

Reviewed by Sriram.
DESC: Fix key event handling in Auto Form Fill listbox
​http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserCore/Formcontrols/inc/FControlSelectWidget.h:
  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::OfferKeyEventL): (CControlSelectWidget::InputCapabilities):
7:36 AM Changeset in webkit [16469] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-09-20 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.
DESC: SmartLink Handler needs phonebook view
dll resource loader.

  • BrowserView/inc/SmartLinkHandler.h: new include.
7:23 AM Changeset in webkit [16468] by weinig
  • 3 edits in trunk/WebCore

Build Fix. Adds isHorizontal attribute back to WheelEvent
for the Objective-C bindings. If it is found that isHorizontal
is not used, we should remove it again but also remove it's
declaration from PublicDOMInterfaces.h

  • dom/WheelEvent.h: (WebCore::WheelEvent::isHorizontal):
  • dom/WheelEvent.idl:
2:52 AM Changeset in webkit [16467] by hyatt
  • 8 edits in trunk/WebCore

Fix for 10945, WheelEvent should support two dimensions at once, since
MacBooks allow for diagonal scrolling. Also enhance the PlatformWheelEvent
to allow for diagonal scrolling.

Reviewed by Eric

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWheelEvent):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): (WebCore::WheelEvent::initWheelEvent):
  • dom/WheelEvent.h: (WebCore::WheelEvent::wheelDelta): (WebCore::WheelEvent::wheelDeltaX): (WebCore::WheelEvent::wheelDeltaY):
  • dom/WheelEvent.idl:
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::deltaX): (WebCore::PlatformWheelEvent::deltaY): (WebCore::PlatformWheelEvent::normalize):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2:38 AM Changeset in webkit [16466] by eseidel
  • 7 edits in trunk/LayoutTests

2006-09-20 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.


Commit two test updates I forgot to commit with:
Markers should clip to their viewport.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
2:20 AM Changeset in webkit [16465] by eseidel
  • 25 edits
    6 copies
    2 moves in trunk/WebCore

2006-09-19 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.

Split KCanvasResources.* into multiple files (and some other minor spacing changes).


No tests were harmed in the making of this patch.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: Added. (WebCore::operator<<):
  • kcanvas/KCanvasClipper.h: Added.
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h:
  • kcanvas/KCanvasMarker.cpp: Added.
  • kcanvas/KCanvasMarker.h: Added.
  • kcanvas/KCanvasMasker.cpp: Added. (WebCore::KCanvasMasker::KCanvasMasker): (WebCore::KCanvasMasker::setMask): (WebCore::KCanvasMasker::externalRepresentation): (WebCore::getMaskerById):
  • kcanvas/KCanvasMasker.h: Added.
  • kcanvas/KCanvasResource.cpp: Added. (WebCore::KCanvasResource::invalidate): (WebCore::KCanvasResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById):
  • kcanvas/KCanvasResource.h: Added.
  • kcanvas/KCanvasResources.cpp: Removed.
  • kcanvas/KCanvasResources.h: Removed.
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderSVGContainer.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/RenderSVGText.cpp:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
12:16 AM Changeset in webkit [16464] by beidson
  • 9 edits in trunk

WebCore:

Reviewed by Sarge Decker

<rdar://problem/4739892> and <rdar://problem/4729797>

  • WebCore::IconDatabase needs to have and respect an enabled() flag
  • Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge _setEnabled:]): Added (-[WebCoreIconDatabaseBridge _isEnabled]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): Don't open if disabled (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::releaseIconURL): (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed (WebCore::IconDatabase::setEnabled): Added
  • loader/icon/IconDatabase.h: (WebCore::IconDatabase::enabled): Added
  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
  • platform/mac/ResourceLoaderMac.mm: Removed extraneous #include

WebKit:

Reviewed by Sarge Decker

<rdar://problem/4739892> and <rdar://problem/4729797>

  • WebCore::IconDatabase needs to have and respect an enabled() flag
  • Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): If preference says icons are disabled, tell the bridge (-[WebIconDatabase _isEnabled]): Ask the bridge if the database is enabled
12:06 AM Changeset in webkit [16463] by hyatt
  • 7 edits in trunk/WebCore

Massage mouse wheel handling so that it is more cross-platform. Make
all the work happen in handleWheelEvent on the FrameView.

Reviewed by bradee-oh

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::wheelEvent):
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::platformDelta): (WebCore::PlatformWheelEvent::delta):
  • platform/mac/WheelEventMac.mm: (WebCore::platformDeltaForEvent): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scroll):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::scroll):

Sep 19, 2006:

10:37 PM Changeset in webkit [16462] by eseidel
  • 30 edits in trunk

2006-09-19 Eric Seidel <​eric@eseidel.com>

Reviewed by adele.

Improve test output for filters with bounding-box relative sizes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8585

Many test results updated.

  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation):
10:26 PM Changeset in webkit [16461] by eseidel
  • 6 edits
    4 adds in trunk

2006-09-19 Eric Seidel <​eric@eseidel.com>

Reviewed by adele.


Markers should clip to their viewport.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

Test: svg/custom/marker-overflow-clip.svg

  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::KCanvasMarker): (WebCore::KCanvasMarker::setMarker): (WebCore::KCanvasMarker::draw):
  • kcanvas/KCanvasResources.h: (WebCore::KCanvasMasker::mask):
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::canvasResource): (WebCore::SVGMarkerElement::createRenderer):
8:57 PM Changeset in webkit [16460] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Checking the mail post-commit hook on the new server

8:46 PM Changeset in webkit [16459] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Checkin test on the new hardware!

6:57 PM Changeset in webkit [16458] by justing
  • 3 edits
    1 add
    1 delete in trunk

LayoutTests:

Reviewed by eseidel


Disabling this test temporarily.

  • editing/selection/editable-links.html: Removed.
  • editing/selection/editable-links.html-disabled: Added.

WebCore:

Reviewed by eseidel

Backing out my recent change.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
5:53 PM Changeset in webkit [16457] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Kevin McCullough

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10940
Opening a PDF in a new tab/window creates a documentless-frame
and we deref the document without checking its validity

  • page/Frame.cpp: (WebCore::Frame::iconURL):
4:36 PM Changeset in webkit [16456] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/editable-links-expected.checksum: Added.
  • editing/selection/editable-links-expected.png: Added.
  • editing/selection/editable-links-expected.txt: Added.
  • editing/selection/editable-links.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4735272>
Can not click into link in programmatically editable content

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using userModify to implement document wide editability.
4:25 PM Changeset in webkit [16455] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

I totally LIED in the Changelog

4:24 PM Changeset in webkit [16454] by beidson
  • 2 edits in trunk/WebCore

Reviewed and landed by Brady

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10939
Build broken when SVG is not enabled.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
3:44 PM Changeset in webkit [16453] by beidson
  • 1 edit
    1 add in trunk/WebKitSite

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8220
Add the favicon.ico to the site.
Notice, users of shipping Safari won't see the updated favicon
unless they clear their icon cache - ToT users can manually reload
the site and force the refresh ;)

  • favicon.ico: Added.
3:01 PM Changeset in webkit [16452] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/pasteboard/pasting-tabs-expected.checksum: Added.
  • editing/pasteboard/pasting-tabs-expected.png: Added.
  • editing/pasteboard/pasting-tabs-expected.txt: Added.
  • editing/pasteboard/pasting-tabs.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces

Pasting plain text results in a match style paste, and the insertion
position is whitespace normal, which clobbers the whitespace:pre on
tab spans. Skip changes to the whitespace mode when computing a style
change for tab spans or the text nodes inside tab spans.

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): Don't change the whitespace mode inside tab spans.
2:31 PM Changeset in webkit [16451] by hyatt
  • 3 edits in trunk/WebCore

Fix for bug 5298, shape=default not supported for image maps. Implement
support for it.

Reviewed by timo

  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::getRegion):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent):
11:04 AM Changeset in webkit [16450] by ap
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10661
REGRESSION: CFM plug-ins (Shockwave, SVG) are not loaded

  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): On 32-bit PowerPC, don't bail out if the bundle is nil - it can be a CFM plugin.
10:25 AM Changeset in webkit [16449] by aroben
  • 5 edits in trunk/LayoutTests

Reviewed by Adele.

Update tests for the new file upload control.

  • fast/forms/file-input-disabled-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/input-appearance-height-expected.txt:
  • fast/forms/input-value-expected.txt:
10:23 AM Changeset in webkit [16448] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Adele.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10824
"no file selected" placeholder text missing from file upload control

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderFileUploadControl.cpp: Remove class RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to defaultWidthNumChars (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call RenderBlock constructor instead of RenderFlexibleBox, (WebCore::RenderFileUploadControl::setStyle): Remove references to m_fileBox. (WebCore::RenderFileUploadControl::valueChanged): Call repaint() instead of updateIconAndFileName() (which has been removed) (WebCore::RenderFileUploadControl::updateFromElement): Remove references to m_fileBox, don't call updateIconAndFilename() (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width without using m_fileBox (WebCore::RenderFileUploadControl::createButtonStyle): Remove now-unnecessary display:box rule. (WebCore::RenderFileUploadControl::paintObject): Remove redundant call to paintingDisabled() now that Icon::paint() does it, and add code to paint the filename directly. (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
  • rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a subclass of RenderBlock instead of RenderFlexibleBox, remove updateIconAndFilename() method, remove m_fileBox instance variable.
5:17 AM Changeset in webkit [22186] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.


<rdar://problem/4734743> Crash accessing YouTube.


  • config.h: Enable some more of the JSC bindings code on Windows.
2:48 AM Changeset in webkit [16447] by eseidel
  • 2 edits in trunk/WebCore

2006-09-19 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.

Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10846


No automated test case possible until ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10905 is resolved.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs):
2:39 AM Changeset in webkit [16446] by eseidel
  • 2 edits in trunk/WebKitTools

2006-09-19 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by eseidel. Landed by eseidel.


Detect that close button was pressed and exit cleanly.

  • GdkLauncher/main.cpp: (handle_event): (main):
2:37 AM Changeset in webkit [16445] by eseidel
  • 4 edits in trunk/WebCore

2006-09-19 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by eseidel. Landed by eseidel.


Build fix only, no tests affected.

  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::isLoadTypeReload): (FrameGdk::originalRequestURL): (IconDatabase::setIconURLForPageURL):
2:10 AM Changeset in webkit [16444] by hyatt
  • 2 edits in trunk/WebCore

Refine the fix for 9805 to really get all the complex cases right.

Reviewed by Eric

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::handleBottomOfBlock):
2:08 AM Changeset in webkit [16443] by hyatt
  • 4 adds
    4 deletes in trunk/LayoutTests/fast/block/margin-collapse

Land changes for margin collapsing fixes. Yank bad layout test.

Note: See TracTimeline for information about the timeline view.