⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 21, 2006:

9:31 PM Changeset in webkit [16517] by sfalken
  • 2 edits in trunk/WebCore

2006-09-21 Steve Falkenburg <​sfalken@apple.com>

Tweak includes.

  • platform/ResourceLoaderInternal.h:
6:29 PM Changeset in webkit [16516] by ggaren
  • 3 edits in trunk/WebCore

build fixed. band happy.


  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::translate):
  • platform/mac/WidgetMac.mm:
6:04 PM Changeset in webkit [22205] by aliceli1
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

windows build fix

  • platform/win/GraphicsContextWin.cpp: wrapped a CG #include in #if PLATFORM(CG)
5:55 PM Changeset in webkit [22204] by ggaren
  • 21 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Maciej, Hyatt, Steve.


frames!


Prep work:

  • moved ScrollViewWin into OpenSourceWin
  • set eol-style:native on some files and corrected line endings
  • updated the WebCore project so that you don't need cygwin in your Windows path to build correctly.

Real work:

On Windows, Widgets are no longer interfaces to Windows UI tookit objects. They're
just positioned objects.


Widgets position themselves relative to their parents. The top-level widget technically
has a position relative to the WebView, but that's academic, since it's always (0, 0).
All widgets draw inside a common containing window (the WebView window). ScrollView
handles transformation, clipping, and dirty rect management.


I've filed a bunch of bugs on remaining frames work. Most notably, closing a page with
a frame in it causes a crash because WebCore depends on WebKit to manage frame lifetime.
I'm going to fix that by integrating frame ownership into the DOM.

WebKitWin:

Reviewed by Maciej, Hyatt, Steve.

frames!


Prep work:

  • fixed WebFrame/WebView circular reference leak: ownership now looks like this (same as Mac):
    • WebView -> WebCore::Page -> WebCore::Frame

-> WebFrame
-> WebCore::FrameTree -> WebCore::Frame...

  • fixed notification center circular reference leak: The notification center no longer retains its clients; clients must take care to remove themselves upon destruction.

Real work:

  • The WebView's onSize handler now updates the frame geometry of the main frame. This used to happen implicitly, since the WebView window and the main frame were synonymous.


  • Changed WebFrame painting code to use WebCore's FrameView painting code instead of rolling its own.


  • Removed WebFrame::initWithName from the public COM API and replaced it with the private initializer, WebFrame::initWithWebFrameView. We intend to deprecate initWithName on Mac because it's meaningless -- only WebCore should create frames.
5:50 PM Changeset in webkit [16515] by ggaren
  • 24 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated to include the right path.
  • wtf/FastMalloc.h: #include Platform.h, since we use Platform macros.

WebCore:

Reviewed by Maciej.


Some Widget refactoring.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/mac/FrameMac.mm:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): (WebCore::FrameWin::runJavaScriptConfirm):
  • bridge/win/PageWin.cpp: (WebCore::Page::Page): (WebCore::rootWindowForFrame):
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::translate):
  • page/FrameView.cpp: (WebCore::FrameView::isFrameView):
  • page/Page.h: (WebCore::Page::setInstanceHandle): (WebCore::Page::instanceHandle):
  • platform/GraphicsContext.h:
  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::clearFocus):
  • platform/win/ResourceLoaderWin.cpp: (WebCore::initializeOffScreenResourceLoaderWindow):
  • platform/win/ScreenWin.cpp: (WebCore::monitorInfo):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::updateScrollBars):
  • platform/win/SharedTimerWin.cpp: (WebCore::initializeOffScreenTimerWindow):
  • platform/win/TemporaryLinkStubs.cpp: (FrameView::updateBorder): (ScrollView::paint): (GraphicsContext::clip):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::parentWindow): (WebCore::Widget::setParentWindow): (WebCore::Widget::frameGeometry): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry):
5:22 PM Changeset in webkit [22203] by sfalken
  • 7 edits in branches/WindowsMerge

2006-09-21 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.


<rdar://4516072>
<rdar://4601320>


Implemented JavaScript alert/confirm/prompt inside app.
This is done via IWebUIDelegate.

5:05 PM Changeset in webkit [22202] by seangies
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

Unfork GraphicsContextCG.cpp

4:55 PM Changeset in webkit [16514] by andersca
  • 2 edits in trunk/WebCore

2006-09-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim H.

  • platform/TextEncoding.cpp: (WebCore::TextEncoding::backslashAsCurrencySymbol): Add comment clarifying why backslashAsCurrencySymbol is needed.
4:06 PM Changeset in webkit [22201] by wallis
  • 2 edits in branches/WindowsMerge/WebCore

Example code for enabling PLATFORM(CG)

3:44 PM Changeset in webkit [22200] by wallis
  • 2 edits in branches/WindowsMerge/WebCore

Fixed build

3:36 PM Changeset in webkit [16513] by bdash
  • 6 edits in trunk/WebKitSite

2006-09-21 Matt Lilek <​pewtermoose@gmail.com>

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10975
Update the blog template to valid HTML 4.01 Strict.

  • blog/wp-content/themes/webkit/comments-popup.php:
  • blog/wp-content/themes/webkit/comments.php:
  • blog/wp-content/themes/webkit/footer.php:
  • blog/wp-content/themes/webkit/header.php:
  • blog/wp-content/themes/webkit/style.css: Add missing semi-colon that the validator complained about.
3:29 PM Changeset in webkit [22199] by seangies
  • 5 edits in branches/WindowsMerge

Draw form controls and fix redraw issues with CG.

3:05 PM Changeset in webkit [16512] by thatcher
  • 4 edits in trunk/LayoutTests

Adding more calls to layoutTestController.dumpChildFrameScrollPositions()
for tests that need to report child frame scroll positions.

  • http/tests/navigation/anchor-frames.html:
  • http/tests/navigation/anchor-subframeload.html:
  • http/tests/navigation/relativeanchor-frames.html:
3:00 PM Changeset in webkit [22198] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

2006-09-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

Support getting the plugin element as an NPObject.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
2:58 PM Changeset in webkit [16511] by seangies
  • 4 edits in trunk/WebCore

Factored out get/release of HDC from cairo GraphicsContext.

2:42 PM Changeset in webkit [16510] by justing
  • 2 edits in trunk/WebCore

Reviewed by anders


<rdar://problem/4426622>
Plain text paste slow. Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)

  • editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we aren't producing complicated sequences here. Use multiple UChar -> UChar replaces instead for speed. Got rid of uses of DepricatedString.
2:29 PM Changeset in webkit [22197] by seangies
  • 2 edits
    2 adds in branches/WindowsMerge/WebCore

Forked GraphicsContextCG.cpp and GraphicsContextPlatformPrivate.h

2:22 PM Changeset in webkit [16509] by rwlbuis
  • 2 edits in trunk/WebCore/kcanvas/device/qt

Hmm, forgot to commit kcanvas/ changes as part of linux build fixes.

2:18 PM Changeset in webkit [16508] by rwlbuis
  • 1 edit in trunk/WebCore/page/Frame.cpp

Too tired too do it right :}

2:14 PM Changeset in webkit [16507] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by eseidel.

Don't crash if no IconDatabase is available (ie. on Qt/Gdk)

2:11 PM Changeset in webkit [16506] by rwlbuis
  • 7 edits in trunk/WebCore

Reviewed by eseidel.

Fix Qt/Linux build.

2:02 PM Changeset in webkit [16505] by thatcher
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

Set dumpChildFrameScrollPositions to NO before each test run.

1:50 PM Changeset in webkit [16504] by zbujtas
  • 8 edits in S60/trunk

2006-09-21 sareen <​shyam.sareen@nokia.com>

Reviewed by Zalan Bujtas.
Directory include hierarchy change

for S60 code base in webcore/Javascriptcore engine

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10970

WARNING: NO TEST CASES ADDED OR CHANGED

  • group/KHTML.mmp:
  • group/KWQ.mmp:
  • group/WebCore.mmp:
1:43 PM Changeset in webkit [16503] by thatcher
  • 5 edits in trunk

LayoutTests:

Reviewed by Adam.

Bug 10923: Frame scroll layout test failures on the buildbot
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10923

Made this test call layoutTestController.dumpChildFrameScrollPositions().

  • fast/overflow/scrollRevealButton-expected.txt:
  • fast/overflow/scrollRevealButton.html:

WebKitTools:

Reviewed by Adam.

Bug 10923: Frame scroll layout test failures on the buildbot
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10923


Added a new method that will toggle on the recursive dump of
child frame scroll positions.


  • DumpRenderTree/DumpRenderTree.m: (dumpFrameScrollPosition): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpChildFrameScrollPositions]):
12:56 PM Changeset in webkit [16502] by thatcher
  • 1 edit in trunk/WebCore/platform/mac/FontMac.mm

Build fix.

12:32 PM Changeset in webkit [16501] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-09-20 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas.
DESC: merge of r16480 onto 3.1m branch.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10952
Changing the encoding in setting does not affect the browser behavior.

  • BrowserView/inc/CharsetData.h:
12:31 PM Changeset in webkit [16500] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

  • editing/pasteboard/subframe-dragndrop-1-expected.checksum: Added.
  • editing/pasteboard/subframe-dragndrop-1-expected.png: Added.
  • editing/pasteboard/subframe-dragndrop-1-expected.txt: Added.
  • editing/pasteboard/subframe-dragndrop-1.html: Added.

WebCore:

Reviewed by john


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe

  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document to the position-to-move-to's document, not the fragment's document. The fragment's document is the document used to create the fragment and is irrelavant.

WebKit:

Reviewed by john


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7165>
TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe


The top level WebHTMLView is responsible for performing dragging operations, but
the inner view, the view that holds the drag caret, should be consulted to determine
if the drag is a move drag.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't set initatedDrag here, because it's only the top level WebHTMLView that performs this operation. (-[WebHTMLView _setInitiatedDrag:]): Added. (-[WebHTMLView _initiatedDrag]): Ditto. (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Ask the innerView if it initiated the drag, not the top level view. (-[WebHTMLView _isMoveDrag]): The top level view asks the innerView if it should perform a move drag, so don't ASSERT _isTopHTMLView. (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ask the innerView if _isMoveDrag. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto.
  • WebView/WebHTMLViewInternal.h: Added two private SPI so that the top level WebHTMLView can set and get the initiatedDrag BOOL.
12:01 PM Changeset in webkit [16499] by beidson
  • 2 edits in trunk/WebCore

Eliminate a crash for all platforms without IconDatabase hooked up

12:00 PM Changeset in webkit [22196] by seangies
  • 2 edits in branches/WindowsMerge/WebKitWin

Link to CoreGraphics

11:48 AM Changeset in webkit [22195] by seangies
  • 6 edits in branches/WindowsMerge/WebCore

Support synthetic bold/oblique.

11:07 AM Changeset in webkit [22194] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders

Fixed one definite bug and did alot of cleanup to make it resemble the unforked version of the file
in preparation for merging it back out

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): (WebCore::transferJobStatusCallback): Fixed a bug here! :) (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
10:39 AM Changeset in webkit [16498] by brmorris
  • 4 edits
    3 copies in S60/branches/3.1m/S60Tools

2006-09-21 brmorris <​bradley.morrison@nokia.com>

Merge of r16496 onto 3.1m branch.

  • BuildSDK.xml: Added new build deliverables to build artifacts
  • S60Platform.ini: Added.
  • S60WebKitPlatformBuild.pl: Added.
  • svn2ccm.ini: Added.
  • svn2ccm.pl: Misc updates.
  • test/net/S60/cruisecontrol/Webkit/S60WebKitTest.java: (S60WebKitTest.testConstructor): Temporarily Removed call to runATF
10:18 AM Changeset in webkit [16497] by beidson
  • 2 edits in trunk/WebCore

YABF

9:36 AM Changeset in webkit [16496] by brmorris
  • 4 edits
    3 adds in S60/trunk/S60Tools

2006-09-21 brmorris <​bradley.morrison@nokia.com>

Reviewed by Alan.
DESC: Various integration tool updates

  • BuildSDK.xml: Added new build deliverables to build artifacts
  • S60Platform.ini: Added.
  • S60WebKitPlatformBuild.pl: Added.
  • svn2ccm.ini: Added.
  • svn2ccm.pl: Misc updates.
  • test/net/S60/cruisecontrol/Webkit/S60WebKitTest.java: (S60WebKitTest.testConstructor): Temporarily Removed call to runATF
2:39 AM Changeset in webkit [16495] by bdash
  • 15 edits in trunk/WebKitSite

2006-09-21 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10966
Bug 10966: Updates to website

Resolves a few remaining validation issues, makes Bugzilla links consistent, and removes unneeded references to OpenDarwin.

  • coding/coding-style.html:
  • coding/lgpl-license.html:
  • contact.html:
  • index.html:
  • projects/css/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/index.html:
  • projects/javascript/index.html:
  • projects/svg/index.html:
  • projects/xslt/index.html:
  • webdevelopers/webkit_version.html:
  • webdevelopers/webkit_version_xl.html:
1:03 AM Changeset in webkit [22193] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/WheelEventWin.cpp

Remove executable prop from WheelEventWin.cpp

12:29 AM Changeset in webkit [16494] by rwlbuis
  • 6 edits in trunk

Reviewed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10946
new marker code draws end-marker in wrong place

Keep track of the start of the subpath so we can handle
closeTo/moveTo correctly.

12:21 AM Changeset in webkit [22192] by hyatt
  • 5 edits
    2 adds in branches/WindowsMerge

Implement mouse wheel scrolling on win32.

12:18 AM Changeset in webkit [16493] by hyatt
  • 6 edits in trunk/WebCore

Wheel scrolling prep for win32.

Sep 20, 2006:

11:27 PM Changeset in webkit [16492] by bdash
  • 22 edits in trunk/WebKitSite

2006-09-21 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by TimH.

Updates to make static pages validate as HTML 4.01 Strict.

  • building/build.html:
  • coding/coding-style.html:
  • header.inc:
  • index.html: Move <style> tag into the document head.
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html: Remove note about <label> not being implemented correctly.
  • projects/html/index.html:
  • projects/javascript/index.html:
  • projects/performance/index.html:
  • projects/portability/index.html: Change mention of Windows port to note that it is in progress rather than non-existant.
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/xslt/index.html:
  • quality/bugwriting.html: Update WebKit version numbers to be accurate. Move JS away from using innerHTML as W3C validator doesn't like it.
  • quality/reduction.html:
  • quality/reporting.html: Rename element IDs that start with numbers. Update WebKit and Mac OS X version numbers to be accurate.
  • quality/testing.html:
8:45 PM Changeset in webkit [16491] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Bug 10917: REGRESSION (r16027): iFrame transparency broken
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10917

Don't paint the base background color if we transparent.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
6:28 PM Changeset in webkit [22191] by sfalken
  • 12 edits in branches/WindowsMerge/WebKitWin

2006-09-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada Chan.


<rdar://4601547> Character encoding menu/switching


Encoding menu and prefs pop-up are now hooked up and working.


List of encodings is identical to the Mac version, with encodings
not supported by icu removed. Localized names of these encodings
and IANA names are retrieved via MLANG from code pages. It
would have been nice to use ICU for this, but the call to get
a displayable encoding name from an IANA name doesn't return
user readable names. CF couldn't be used, since the open source
CF doesn't have encoding support that it would normally get via TEC.


There's currently a problem where the encoding doesn't get
picked up out of the incoming HTML document out of <meta>, so
the text encoding menu comes in especially handy at the moment.

6:15 PM Changeset in webkit [22190] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Hook up the WebIconDatabase enabled preference

5:54 PM Changeset in webkit [16490] by aroben
  • 2 edits in trunk/WebCore

Reviewed by andersca.

  • platform/FileChooser.h: Remove no-longer-necessary namespace std
4:52 PM Changeset in webkit [16489] by seangies
  • 1 edit in trunk/WebCore/platform/FontData.h

Fix up conditional.

4:52 PM Changeset in webkit [22189] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Runtime fix - removed an obsolete, overzealous ASSERTion

4:38 PM Changeset in webkit [22188] by seangies
  • 2 edits
    2 adds in branches/WindowsMerge/WebCore

Add platform/cg/ColorCG.cpp

4:37 PM Changeset in webkit [16488] by eseidel
  • 44 edits in trunk/WebCore

2006-09-20 Eric Seidel <​eric@eseidel.com>

Reviewed by beth.

Cleanup style in KCanvas.
Remove extra white-space, unneeded arguments, etc.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: (WebCore::operator<<): (WebCore::KCanvasClipper::externalRepresentation):
  • kcanvas/KCanvasClipper.h:
  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation): (WebCore::operator<<): (WebCore::KCanvasFilterEffect::externalRepresentation): (WebCore::KCPointLightSource::externalRepresentation): (WebCore::KCSpotLightSource::externalRepresentation): (WebCore::KCDistantLightSource::externalRepresentation): (WebCore::KCanvasFEBlend::externalRepresentation): (WebCore::KCanvasFEColorMatrix::externalRepresentation): (WebCore::KCanvasFEComponentTransfer::externalRepresentation): (WebCore::KCanvasFEComposite::externalRepresentation): (WebCore::KCanvasFEConvolveMatrix::externalRepresentation): (WebCore::KCanvasFEDiffuseLighting::externalRepresentation): (WebCore::KCanvasFEDisplacementMap::externalRepresentation): (WebCore::KCanvasFEFlood::externalRepresentation): (WebCore::KCanvasFEGaussianBlur::externalRepresentation): (WebCore::KCanvasFEImage::externalRepresentation): (WebCore::KCanvasFEMerge::externalRepresentation): (WebCore::KCanvasFEMorphology::externalRepresentation): (WebCore::KCanvasFEOffset::externalRepresentation): (WebCore::KCanvasFESpecularLighting::externalRepresentation): (WebCore::KCanvasFETile::externalRepresentation): (WebCore::KCanvasFETurbulence::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEDiffuseLighting::lightSource): (WebCore::KCanvasFESpecularLighting::lightSource):
  • kcanvas/KCanvasImage.h:
  • kcanvas/KCanvasMarker.cpp: (WebCore::KCanvasMarker::externalRepresentation):
  • kcanvas/KCanvasMarker.h:
  • kcanvas/KCanvasResource.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasResource.h:
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<): (WebCore::writeIndent): (WebCore::writeStyle): (WebCore::write): (WebCore::writeRenderResources):
  • kcanvas/KCanvasTreeDebug.h: (WebCore::operator<<):
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::drawStartAndMidMarkers):
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/device/KRenderingDevice.cpp: (WebCore::KRenderingDevice::currentContext): (WebCore::KRenderingDevice::popContext): (WebCore::KRenderingDevice::pushContext):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): (WebCore::KRenderingPaintServer::activeClient): (WebCore::KRenderingPaintServer::setActiveClient):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::operator<<): (WebCore::KRenderingPaintServerGradient::externalRepresentation): (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation): (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener): (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener): (WebCore::KRenderingPaintServerPattern::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.cpp: (WebCore::KRenderingPaintServerSolid::externalRepresentation):
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/KRenderingStrokePainter.cpp: (WebCore::KRenderingStrokePainter::strokeMiterLimit): (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter):
  • kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (WebCore::KCanvasImageQuartz::init):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::quartzContext): (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource): (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::CGShadingRefForLinearGradient): (WebCore::CGShadingRefForRadialGradient): (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerQuartzHelper::strokePath): (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath): (WebCore::KRenderingPaintServerQuartzHelper::fillPath): (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath): (WebCore::KRenderingPaintServerSolidQuartz::draw): (WebCore::KRenderingPaintServerSolidQuartz::setup): (WebCore::KRenderingPaintServerSolidQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::setup): (WebCore::KRenderingPaintServerPatternQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::teardown):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext):
3:45 PM Changeset in webkit [16487] by andersca
  • 4 edits in trunk

JavaScriptCore:

2006-09-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

  • wtf/MathExtras.h: Get rid of lrint.

WebCore:

2006-09-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Use lroundf instead of lround since deltas are floats.
3:38 PM Changeset in webkit [16486] by eseidel
  • 3 edits
    4 adds in trunk

2006-09-20 Julien Palmas <​julien.palmas@gmail.com>

Reviewed by eseidel. Landed by eseidel.

Test: svg/custom/pattern-y-offset.svg

  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerPatternQuartz::setup):
3:37 PM Changeset in webkit [16485] by hyatt
  • 3 edits in trunk/WebCore

Add a new wheelEvent method to ScrollView. Platforms that wish
to handle the wheel event for the scroll view themselves can then
do so there. (Mac lets the underlying NSScrollView do it for now.)

  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/ScrollView.h: (WebCore::ScrollView::wheelEvent):
3:22 PM Changeset in webkit [22187] by seangies
  • 2 edits in branches/WindowsMerge/WebCore

Fixed font-spacing issue with CG

2:59 PM Changeset in webkit [16484] by seangies
  • 2 edits in trunk/JavaScriptCore

Send debug messages to debugger console.

2:44 PM Changeset in webkit [16483] by thatcher
  • 2 edits in trunk/WebKit/Misc

Fix copyright year.

2:32 PM Changeset in webkit [16482] by beidson
  • 5 edits in trunk

WebCore:

Reviewed by Tim Omernick

Part of fixing a crash Tim O showed me that I missed in a release build.
WebKit should be able to call through the bridge to WebCore no matter what -
Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge isOpen]): (-[WebCoreIconDatabaseBridge removeAllIcons]): (-[WebCoreIconDatabaseBridge _isEmpty]): (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]): (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]): (-[WebCoreIconDatabaseBridge _setEnabled:]): (-[WebCoreIconDatabaseBridge _isEnabled]):

WebKit:

Reviewed by Tim Omernick

Fixing part of a crash Tim O showed me. [WebIconDatabase init] should finish
gracefully even if we can't open the database

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]):
2:12 PM Changeset in webkit [16481] by hyatt
  • 2 edits in trunk/JavaScriptCore

Add an implementation of lrint for Win32.

Reviewed by anders

  • wtf/MathExtras.h: (lrint):
2:06 PM Changeset in webkit [16480] by zbujtas
  • 2 edits in S60/trunk/WebKit

2006-09-20 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas.
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10952
Changing the encoding in setting does not affect the browser behavior.

  • BrowserView/inc/CharsetData.h:
2:04 PM Changeset in webkit [16479] by andersca
  • 13 edits in trunk/WebCore

2006-09-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Add String::split which returns a Vector of Strings and use it instead of
DeprecatedStringList.


  • bindings/js/kjs_events.cpp: (KJS::Clipboard::getValueProperty):
  • bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures):
  • css/MediaList.cpp: (WebCore::MediaList::setMediaText):
  • dom/Clipboard.h:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::split):
  • platform/StringImpl.cpp:
  • platform/StringImpl.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::types):
1:43 PM Changeset in webkit [16478] by thatcher
  • 2 edits
    2 adds in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4741392> Develop a system to find what version of WebKit an app was linked with

  • Misc/WebKitVersionChecks.h: Added.
  • Misc/WebKitVersionChecks.m: Added. (WebKitLinkedOnOrAfter): Added. (WebKitLinkTimeVersion): Added. (WebKitRunTimeVersion): Added.
  • WebKit.xcodeproj/project.pbxproj:
1:31 PM Changeset in webkit [16477] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Fixed a typo.
12:20 PM Changeset in webkit [16476] by justing
  • 3 edits
    1 add
    1 delete in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/editable-links.html: Added.
  • editing/selection/editable-links.html-disabled: Removed.

WebCore:

Reviewed by harrison

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call HTMLElement::isContentEditable just to check the Frame's editability, since it calls updateRenderering, which can get us into infinite recursion.
12:16 PM Changeset in webkit [16475] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2006-09-19 spadma <​Sachin.Padma@nokia.com>

Reviewed by Sriram.
DESC: Fix key event handling in Auto Form Fill listbox
​http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserCore/Formcontrols/inc/FControlSelectWidget.h:
  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::OfferKeyEventL): (CControlSelectWidget::InputCapabilities):
12:12 PM Changeset in webkit [16474] by beidson
  • 4 edits in trunk

WebCore:

Reviewed by Darin

Cleaned up my last patch alot, and made the WebCore icon database disabled by default

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Disabled by default (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed) (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto (WebCore::IconDatabase::iconForPageURL): Ditto (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto (WebCore::IconDatabase::iconURLForPageURL): Ditto (WebCore::IconDatabase::retainIconForPageURL): Ditto (WebCore::IconDatabase::releaseIconForPageURL): Ditto (WebCore::IconDatabase::setIconDataForIconURL): Ditto (WebCore::IconDatabase::setIconURLForPageURL): Ditto (WebCore::IconDatabase::hasEntryForIconURL): Ditto (WebCore::IconDatabase::setEnabled): Fixed a big bug here!

WebKit:

Reviewed by Darin

Preparing to make the WebIconDatabase disabled by default - this patch tells the bridge whether its enabled or not

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]):
11:33 AM Changeset in webkit [16473] by aroben
  • 3 edits in trunk/LayoutTests

Reviewed by timothy.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10953
Test results for fast/js/window-properties.html should include
children of window.document.body.firstChild

  • fast/js/window-properties-expected.txt: Regenerate results which now include window.document.body.firstChild.*
  • fast/js/window-properties.html: Print out 'null' for null objects instead of 'object' for more clarity
10:42 AM Changeset in webkit [16472] by aroben
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Adele.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
REGRESSION: file upload control with direction:rtl or text-align:right
draws button on top of filename/icon

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::setStyle): Force text-align to match direction (WebCore::RenderFileUploadControl::paintObject): Fix positioning of the filename and icon in RTL

LayoutTests:

Reviewed by Adele.

Adding test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10935
REGRESSION: file upload control with direction:rtl or text-align:right
draws button on top of filename/icon

  • fast/forms/file-input-direction-expected.checksum: Added.
  • fast/forms/file-input-direction-expected.png: Added.
  • fast/forms/file-input-direction-expected.txt: Added.
  • fast/forms/file-input-direction.html: Added.
10:30 AM Changeset in webkit [16471] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

fixed windows build

  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): changed lrint to lround
9:20 AM Changeset in webkit [16470] by spadma
  • 3 edits in S60/trunk/WebKit

2006-09-19 spadma <​Sachin.Padma@nokia.com>

Reviewed by Sriram.
DESC: Fix key event handling in Auto Form Fill listbox
​http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserCore/Formcontrols/inc/FControlSelectWidget.h:
  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::OfferKeyEventL): (CControlSelectWidget::InputCapabilities):
7:36 AM Changeset in webkit [16469] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-09-20 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.
DESC: SmartLink Handler needs phonebook view
dll resource loader.

  • BrowserView/inc/SmartLinkHandler.h: new include.
7:23 AM Changeset in webkit [16468] by weinig
  • 3 edits in trunk/WebCore

Build Fix. Adds isHorizontal attribute back to WheelEvent
for the Objective-C bindings. If it is found that isHorizontal
is not used, we should remove it again but also remove it's
declaration from PublicDOMInterfaces.h

  • dom/WheelEvent.h: (WebCore::WheelEvent::isHorizontal):
  • dom/WheelEvent.idl:
2:52 AM Changeset in webkit [16467] by hyatt
  • 8 edits in trunk/WebCore

Fix for 10945, WheelEvent should support two dimensions at once, since
MacBooks allow for diagonal scrolling. Also enhance the PlatformWheelEvent
to allow for diagonal scrolling.

Reviewed by Eric

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWheelEvent):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): (WebCore::WheelEvent::initWheelEvent):
  • dom/WheelEvent.h: (WebCore::WheelEvent::wheelDelta): (WebCore::WheelEvent::wheelDeltaX): (WebCore::WheelEvent::wheelDeltaY):
  • dom/WheelEvent.idl:
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::deltaX): (WebCore::PlatformWheelEvent::deltaY): (WebCore::PlatformWheelEvent::normalize):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2:38 AM Changeset in webkit [16466] by eseidel
  • 7 edits in trunk/LayoutTests

2006-09-20 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.


Commit two test updates I forgot to commit with:
Markers should clip to their viewport.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5967

  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
2:20 AM Changeset in webkit [16465] by eseidel
  • 25 edits
    6 copies
    2 moves in trunk/WebCore

2006-09-19 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.

Split KCanvasResources.* into multiple files (and some other minor spacing changes).


No tests were harmed in the making of this patch.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: Added. (WebCore::operator<<):
  • kcanvas/KCanvasClipper.h: Added.
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h:
  • kcanvas/KCanvasMarker.cpp: Added.
  • kcanvas/KCanvasMarker.h: Added.
  • kcanvas/KCanvasMasker.cpp: Added. (WebCore::KCanvasMasker::KCanvasMasker): (WebCore::KCanvasMasker::setMask): (WebCore::KCanvasMasker::externalRepresentation): (WebCore::getMaskerById):
  • kcanvas/KCanvasMasker.h: Added.
  • kcanvas/KCanvasResource.cpp: Added. (WebCore::KCanvasResource::invalidate): (WebCore::KCanvasResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById):
  • kcanvas/KCanvasResource.h: Added.
  • kcanvas/KCanvasResources.cpp: Removed.
  • kcanvas/KCanvasResources.h: Removed.
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderSVGContainer.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/RenderSVGText.cpp:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
12:16 AM Changeset in webkit [16464] by beidson
  • 9 edits in trunk

WebCore:

Reviewed by Sarge Decker

<rdar://problem/4739892> and <rdar://problem/4729797>

  • WebCore::IconDatabase needs to have and respect an enabled() flag
  • Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge _setEnabled:]): Added (-[WebCoreIconDatabaseBridge _isEnabled]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): Don't open if disabled (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::releaseIconURL): (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed (WebCore::IconDatabase::setEnabled): Added
  • loader/icon/IconDatabase.h: (WebCore::IconDatabase::enabled): Added
  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
  • platform/mac/ResourceLoaderMac.mm: Removed extraneous #include

WebKit:

Reviewed by Sarge Decker

<rdar://problem/4739892> and <rdar://problem/4729797>

  • WebCore::IconDatabase needs to have and respect an enabled() flag
  • Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): If preference says icons are disabled, tell the bridge (-[WebIconDatabase _isEnabled]): Ask the bridge if the database is enabled
12:06 AM Changeset in webkit [16463] by hyatt
  • 7 edits in trunk/WebCore

Massage mouse wheel handling so that it is more cross-platform. Make
all the work happen in handleWheelEvent on the FrameView.

Reviewed by bradee-oh

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::wheelEvent):
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::platformDelta): (WebCore::PlatformWheelEvent::delta):
  • platform/mac/WheelEventMac.mm: (WebCore::platformDeltaForEvent): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scroll):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::scroll):
Note: See TracTimeline for information about the timeline view.