⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 23, 2006:

12:03 PM Changeset in webkit [16544] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

Build Fix.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController enableDOMUIEventLogging:]):
11:44 AM Changeset in webkit [16543] by ap
  • 11 edits
    6 adds in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4872
XMLHttpRequest fails to throw an exception when there is a security violation
(mismatching domains)

Raise an exception if there is a security violation, and also in cases required by
the current draft of XHR specification.

WebCore:

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one. (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method reports one, and also if there were too few arguments passed.
  • bindings/js/kjs_binding.cpp: (KJS::setDOMException): Added support for custom XHR exceptions.
  • xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an exception code range for XHR exceptions.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed. (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedData):

LayoutTests:

  • http/tests/xmlhttprequest/exceptions-expected.txt: Added.
  • http/tests/xmlhttprequest/exceptions.html: Added.
  • http/tests/xmlhttprequest/extra-parameters-expected.txt: Added.
  • http/tests/xmlhttprequest/extra-parameters.html: Added.
  • http/tests/xmlhttprequest/resources/post-echo.cgi: Added. Test that passing too many parameters is OK (Firefox behavior; WinIE raises an exception).
  • fast/dom/xmlhttprequest-get-expected.txt: Updated results.
  • http/tests/xmlhttprequest/zero-length-response-expected.txt:
  • http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
  • http/tests/xmlhttprequest/zero-length-response-sync.html:
  • http/tests/xmlhttprequest/zero-length-response.html: Updated results and changed state names to match the current spec.
  • http/tests/xmlhttprequest/resources/zero-length.xml: Added.
11:08 AM Changeset in webkit [16542] by ap
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10183
REGRESSION: obfuscated JS decoding breaks because of soft hyphen removal
(Fanfiction.net author pages not listing stories)

Rolled out the fix for bug 4139.

  • kjs/lexer.cpp: (Lexer::setCode): (Lexer::shift):
  • tests/mozilla/ecma/Array/15.4.5.1-1.js:
  • tests/mozilla/expected.html:

2006-09-22 Steve Falkenburg <​sfalken@apple.com>

Sep 22, 2006:

7:21 PM Changeset in webkit [22218] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-22 Steve Falkenburg <​sfalken@apple.com>

Fix release build some more.

  • WebCore.vcproj/WebCore.vcproj:
6:58 PM Changeset in webkit [16541] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-09-22 Steve Falkenburg <​sfalken@apple.com>

Build fix.

6:42 PM Changeset in webkit [22217] by beidson
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/ResourceLoaderWin.cpp

Backed out the earlier open source merge - not worth the headache right now

6:12 PM Changeset in webkit [22216] by sfalken
  • 4 edits
    1 add in branches/WindowsMerge/WebKitWin

2006-09-22 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


Added IWebUIDelegatePrivate::webViewResizerSize so the engine can
leave space for the vertical scroll bar.

  • Interfaces/IWebUIDelegatePrivate.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:
6:03 PM Changeset in webkit [22215] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Urgent fix to resourceloader

5:56 PM Changeset in webkit [16540] by thatcher
  • 4 edits in trunk/LayoutTests

Changed the tests to be if(window.layoutTestController)

5:44 PM Changeset in webkit [16539] by sfalken
  • 2 edits in trunk/WebCore

2006-09-22 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Jeff Jenkins.

Tweak CF types.

  • platform/cf/ResourceLoaderCFNet.cpp: (WebCore::willCacheResponse):
5:14 PM Changeset in webkit [16538] by justing
  • 24 edits in trunk

WebCore:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8029>
Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf

  • dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded):
  • dom/Element.cpp: (WebCore::Element::contains):
  • dom/Node.cpp: (WebCore::Node::traverseNextNode): (WebCore::Node::traverseNextSibling): (WebCore::Node::traversePreviousNodePostOrder): (WebCore::Node::checkAddChild): (WebCore::Node::isDescendantOf):
  • dom/Node.h:
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::notifyBeforeNodeRemoval):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyle): (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::mergeIdenticalElements): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
  • editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply):
  • editing/IndentOutdentCommand.cpp: (WebCore::enclosingListOrBlockquote):
  • editing/Selection.cpp: (WebCore::Selection::validate):
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved):
  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::advance):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::canonicalPosition): (WebCore::isFirstVisiblePositionInNode): (WebCore::isLastVisiblePositionInNode):
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::enclosingNodeWithTag): (WebCore::enclosingList): (WebCore::enclosingListChild):
  • editing/markup.cpp: (WebCore::createMarkup):

WebKitTools:

Reviewed by darin

  • Scripts/do-webcore-rename:
5:12 PM Changeset in webkit [16537] by thatcher
  • 1 edit
    19 copies in tags/Safari-521.27

New tag.

5:02 PM Changeset in webkit [16536] by thatcher
  • 6 edits in /

Versioning

4:34 PM Changeset in webkit [16535] by thatcher
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

  • Added @property syntax to non-generated headers inside #ifndef BUILDING_ON_TIGER.
  • Changed the DOMEventTarget protocol to have have new versions of addEventListener and removeEventListener with named parameters. These old style methods can be removed once Mail changes to use the new methods <rdar://problem/4746649>.
  • WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
  • bindings/objc/DOM.mm: (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode addEventListener:::]): call the new method (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:::]): call the new method
  • bindings/objc/DOMAbstractView.h:
  • bindings/objc/DOMEventTarget.h:
  • bindings/objc/DOMHTMLAppletElement.h:
  • bindings/objc/DOMHTMLEmbedElement.h:
  • bindings/objc/DOMHTMLOptionElement.h:
  • bindings/objc/DOMObject.h:
  • bindings/objc/DOMRGBColor.h:

WebKit:

Reviewed by Darin.

Pass all headers through unifdef to filter out BUILDING_ON_TIGER blocks
if MACOSX_DEPLOYMENT_TARGET is 10.4.

  • MigrateHeaders.make:
4:18 PM Changeset in webkit [22214] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Forgot some lines we needed to keep for the internal build in my last checkin

  • platform/win/ResourceLoaderWin.cpp:
4:09 PM Changeset in webkit [16534] by weinig
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Eric.

Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.

  • platform/qt/FrameQt.cpp:
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-) (WebCore::GraphicsContext::origin):
  • platform/qt/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
  • platform/qt/WidgetQt.cpp: (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):
3:45 PM Changeset in webkit [22213] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Landed from open source - splits code into more managable methods

3:02 PM Changeset in webkit [16533] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Alice.

  • wtf/Vector.h: Add an append that takes a pointer and length. Generalize the existing Vector append to work on vectors with any value for inlineCapacity. Change the append algorithm so it doesn't check capacity each time through the loop.
2:59 PM Changeset in webkit [22212] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Implement system fonts on Win32.

2:56 PM Changeset in webkit [16532] by hyatt
  • 2 edits in trunk/WebCore

Minor tweaks to RenderThemeMac's systemFont function.

2:50 PM Changeset in webkit [16531] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-09-22 Steve Falkenburg <​sfalken@apple.com>

Fix release build.

1:44 PM Changeset in webkit [16530] by spadma
  • 14 edits in S60/trunk

2006-09-21 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin.
DESC: Directory include hierarchy change

for S60 code base in webkit

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10969

1:33 PM Changeset in webkit [16529] by rwlbuis
  • 1 edit in trunk/WebCore/page/Frame.cpp

I did not pay enough attention at the time of landing WildFox' crash fix.
beidson already fixed the problem in r16499. Reverting the test now.

12:27 PM Changeset in webkit [16528] by beidson
  • 2 edits in trunk/WebCore

Merged my previous checkin with what I was *supposed* to checkin that had been reviewed by Maciej
Added bug numbers to the ChangeLog

11:41 AM Changeset in webkit [16527] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Brady.

Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
take floats. There was already an implicit conversion to float/double
when calling CGContextTranslateCTM or cairo_translate.

  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::translate):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::translate):
11:22 AM Changeset in webkit [16526] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Sfalken

Add redirect and other cleanup to ResourceLoaderWin.cpp

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ResourceLoader.h:
  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): (WebCore::initializeOffScreenResourceLoaderWindow): (WebCore::ResourceLoader::onHandleCreated): (WebCore::ResourceLoader::onRequestRedirected): (WebCore::ResourceLoader::onRequestComplete): (WebCore::transferJobStatusCallback):
11:18 AM Changeset in webkit [16525] by ap
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10803
REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing

  • page/FrameView.cpp: (WebCore::FrameView::hoverTimerFired): Use the current event.
10:26 AM Changeset in webkit [22211] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin
7:13 AM Changeset in webkit [16524] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fix (last) svg memory leak.

6:01 AM Changeset in webkit [16523] by eseidel
  • 1 edit
    1 delete in trunk/WebCore

2006-09-22 Eric Seidel <​eric@eseidel.com>

No review necessary, just removing a dead file.

Remove unused file (added previously by mistake) to make room for real implementation.

  • platform/mac/BitmapImageMac.mm: Removed.
1:51 AM Changeset in webkit [16522] by hyatt
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Mac side of scrollbar move

1:48 AM Changeset in webkit [22210] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Move PlatformScrollBar.h down into platform-specific subdirs.

1:47 AM Changeset in webkit [22209] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Move PlatformScrollBar.h down into platform-specific subdirs.

1:46 AM Changeset in webkit [16521] by hyatt
  • 1 edit
    1 copy
    1 move in trunk/WebCore

Move PlatformScrollBar.h down into platform-specific subdirs.

1:36 AM Changeset in webkit [22208] by hyatt
  • 1 add in branches/WindowsMerge/WebCore/platform/win/PlatformScrollBar.h

Add fork of platformscrollbar.h

1:27 AM Changeset in webkit [22207] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Scrollbar prep work.

1:24 AM Changeset in webkit [16520] by hyatt
  • 4 edits in trunk/WebCore

Add invalidation methods to widget.

1:23 AM Changeset in webkit [16519] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10901
Merge build fixes from unity

1:07 AM Changeset in webkit [16518] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10977
SVGDocument does not expose 'rootElement' property

Enable 'rootElement' property.

12:26 AM Changeset in webkit [22206] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Build was broken for at least some, and I think my checkin that messed with
#include orders was to blame (and it was messy, broken or not) - this cleans that up

  • platform/win/ResourceLoaderWin.cpp:
Note: See TracTimeline for information about the timeline view.