Context Navigation

← Previous Period
Next Period →

Timeline

Sep 25, 2006:

6:14 PM Changeset in webkit [16567] by harrison

3 edits in trunk/WebCore

Reviewed by Tim Omernick and Tim Hatcher.

<rdar://problem/4717965> Text Field text parameterized attributes should work
<rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.

(-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
Cleaned up. Added text field and text area parameterzed attributes.

(-[WebCoreAXObject doAXLineForTextMarker:]):
Fixed to be zero-based and to deal with the first position properly.

(-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
Minor formatting.

(-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
(-[WebCoreAXObject indexForTextMarker:]):
(-[WebCoreAXObject textMarkerRangeForRange:]):
(-[WebCoreAXObject rangeForTextMarkerRange:]):
New utility methods.

(-[WebCoreAXObject doAXLineForIndex:]):
(-[WebCoreAXObject doAXRangeForLine:]):
(-[WebCoreAXObject doAXStringForRange:]):
(-[WebCoreAXObject doAXRangeForPosition:]):
(-[WebCoreAXObject doAXRangeForIndex:]):
(-[WebCoreAXObject doAXBoundsForRange:]):
(-[WebCoreAXObject doAXAttributedStringForRange:]):
(-[WebCoreAXObject doAXRTFForRange:]):
(-[WebCoreAXObject doAXStyleRangeForIndex:]):
Implement text field and text area parameterized attributes.

(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
Added text field and text area parameterzed attributes.

rendering/RenderTextControl.h: Made indexForVisiblePosition() and visiblePositionForIndex() public.

6:10 PM Changeset in webkit [22229] by aroben

30 edits in branches/WindowsMerge

Setting svn:eol-style to native on all Windows-only files.

6:05 PM Changeset in webkit [22228] by aroben

11 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

Set svn:eol-style to native and cleanup line endings on plugins files.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::receivedData): (WebCore::PluginStreamWin::receivedAllData):

5:58 PM Changeset in webkit [22227] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fixes <rdar://problem/4749494>
Crash/ASSERT in plugins at Fark.com

platform/win/ResourceLoaderWin.cpp: Store whether a particular job has received a response within the ResourceLoader object itself, since it's possible that we will enter the InternetReadFileExA while loop twice for the same job. (WebCore::ResourceLoaderWndProc): Ask the job whether it has received a response instead of assuming it hasn't. (WebCore::ResourceLoader::setHasReceivedResponse): Added. (WebCore::ResourceLoader::hasReceivedResponse): Added.

5:57 PM Changeset in webkit [16566] by aroben

7 edits in trunk/WebCore

Reviewed by Brady.

Build fixes.

WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
platform/ResourceLoader.h: Store whether a particular job has received a response within the ResourceLoader object itself, since it's possible that we will enter the InternetReadFileExA while loop twice for the same job.
platform/ResourceLoaderInternal.h: Add private instance variable to store whether we've received a response. (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
platform/win/GraphicsContextWin.cpp: Fix order of preprocessor directives.
platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader whether it has received a response instead of assuming it hasn't. (WebCore::ResourceLoader::setHasReceivedResponse): Added. (WebCore::ResourceLoader::hasReceivedResponse): Added.
platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to setProportion (ScrollBar::setProportion):

5:42 PM Changeset in webkit [22226] by aroben

2 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

Continuing the removal of unnecessary notImplemented() calls.

platform/win/TemporaryLinkStubs.cpp: (PlatformMouseEvent::PlatformMouseEvent): (FrameWin::passWheelEventToChildWidget):

5:33 PM Changeset in webkit [16565] by beidson

2 edits in trunk/WebCore

Requested by ggaren

Disabled IconDatabase logging by default

platform/Logging.cpp: (WebCore::):

4:43 PM Changeset in webkit [16564] by sfalken

2 edits in trunk/WebCore

2006-09-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Jeff Jenkins.

Tweak CF types.

platform/cf/ResourceLoaderCFNet.cpp: (WebCore::willCacheResponse):

3:30 PM Changeset in webkit [22225] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2006-09-25 Steve Falkenburg <sfalken@apple.com>

Add missing parameters to CG paint case.

WebFrame.cpp: (WebFrame::paint):

2:59 PM Changeset in webkit [16563] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by john

editing/execCommand/indent-empty-root-expected.checksum: Added.
editing/execCommand/indent-empty-root-expected.png: Added.
editing/execCommand/indent-empty-root-expected.txt: Added.
editing/execCommand/indent-empty-root.html: Added.

WebCore:

Reviewed by john

<http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message

editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Special case an empty root editable element.

2:57 PM Changeset in webkit [22224] by aroben

2 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

More notImplemented()-ectomy.

platform/win/TemporaryLinkStubs.cpp: (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel):

2:45 PM Changeset in webkit [22223] by aroben

2 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

Remove calls to notImplemented() from functions that can fail safely.

platform/win/TemporaryLinkStubs.cpp: (FrameWin::originalRequestURL): (FrameWin::isLoadTypeReload): (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):

2:40 PM Changeset in webkit [16562] by beidson

2 edits in trunk/WebCore

Math error in SystemTimeWin

2:31 PM Changeset in webkit [16561] by thatcher

3 edits in trunk/WebCore/bindings/objc

Build fix to avoid property name conflict warning.

2:30 PM Changeset in webkit [22222] by aroben

2 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

Make notImplemented() crash even when not linked against the debug CRT.

platform/win/TemporaryLinkStubs.cpp: (notImplemented): Change _CrtDbgBreak() to ASSERT(0)

1:41 PM Changeset in webkit [16560] by ap

5 edits in trunk/WebCore

Reviewed by Eric.

Whitespace cleanup; rename *job variables to *loader.

bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp): (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct): (KJS::JSXMLHttpRequestConstructorImp::construct): (KJS::JSXMLHttpRequest::getOwnPropertySlot): (KJS::JSXMLHttpRequest::getValueProperty): (KJS::JSXMLHttpRequest::put): (KJS::JSXMLHttpRequest::putValueProperty): (KJS::JSXMLHttpRequest::mark): (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::toBoolean):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedData):
xml/xmlhttprequest.h: (WebCore::):

12:04 PM Changeset in webkit [16559] by thatcher

13 edits in trunk

WebCore:

Reviewed by Brady.

Deprecate the rest of the old-style methods that are not generated.
Add @property syntax to DOMRange.

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (-[DOMRange setStart:offset:]): (-[DOMRange setEnd:offset:]): (-[DOMRange compareBoundaryPoints:sourceRange:]): (-[DOMRange setStart::]): (-[DOMRange setEnd::]): (-[DOMRange compareBoundaryPoints::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]):
bindings/objc/DOMCSS.h:
bindings/objc/DOMCSS.mm: (-[DOMDocument getComputedStyle:pseudoElement:]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.h:
bindings/objc/DOMRange.h:
bindings/objc/DOMTraversal.h:

WebKit:

Reviewed by Brady.

Use the non-deprecated method names for getComputedStyle, setEnd and setStart.

WebInspector/WebInspector.m: (-_highlightNode:):
WebView/WebHTMLView.m: (unionDOMRanges): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebTextCompleteController doCompletion]):
WebView/WebView.m: (-[WebView computedStyleForElement:pseudoElement:]):

10:37 AM Changeset in webkit [16558] by thatcher

4 edits in trunk/WebCore/bindings/objc

Build fix.

2:52 AM Changeset in webkit [16557] by eseidel

53 edits
4 adds in trunk

2006-09-25 Eric Seidel <eric@eseidel.com>

Reviewed by mjs.

Outermost <svg> element should clip to viewport
http://bugzilla.opendarwin.org/show_bug.cgi?id=11007

Test: svg/custom/viewport-clip.svg

css/svg.css: change svg:root overflow: from 'visible' to 'hidden'

1:08 AM Changeset in webkit [16556] by andersca

21 edits in trunk/WebCore

2006-09-25 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

css/MediaList.cpp: Remove unused header.

dom/Document.cpp: (WebCore::Document::clear): Use clear instead of iterating through the list of event listeners, removing each one. (Doing that causes a crash when running the layout tests with GuardMalloc turned on)

html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::appendFormData): Update due to changes in the SSL key generator.

ksvg2/svg/SVGAngle.cpp: Remove unused header.

ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute): Rename methods and pass Strings instead of DeprecatedStrings to parseSeparatedList.

ksvg2/svg/SVGFEColorMatrixElement.cpp:
ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
ksvg2/svg/SVGFEDisplacementMapElement.cpp:
ksvg2/svg/SVGFEMergeElement.cpp:
ksvg2/svg/SVGFEOffsetElement.cpp: Remove unused headers.

ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::parseSeparatedList):
ksvg2/svg/SVGHelper.h: Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.

ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::parse):
ksvg2/svg/SVGLengthList.h: Use Vector<String> instead of DeprecatedStringList.

loader/Cache.cpp: (WebCore::Cache::requestImage): (WebCore::Cache::requestStyleSheet): (WebCore::Cache::requestScript): (WebCore::Cache::requestXSLStyleSheet): (WebCore::Cache::requestXBLDocument): (WebCore::Cache::remove): (WebCore::Cache::get): Use a String as the key in the cache set instead of a RefPtr<StringImpl>.

loader/DocLoader.cpp: (WebCore::DocLoader::needReload):
loader/DocLoader.h: Use a HashSet instead of DeprecatedStringList.

page/FrameView.h: Remove declarations that have no functions.

platform/SSLKeyGenerator.h:
platform/mac/SSLKeyGeneratorMac.mm: (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): Convert to use Vector<String> instead of DeprecatedStringList, and String instead of DeprecatedString.

1:07 AM Changeset in webkit [22221] by hyatt

4 edits in branches/WindowsMerge/WebCore

Fix win32 cursor build bustage. Fix my own build bustage from the shifting around of the cairo/win get/ReleaseWindowsContext calls.

1:06 AM Changeset in webkit [16555] by hyatt

2 edits in trunk/WebCore

Fix win32 cursor build bustage.

12:39 AM Changeset in webkit [16554] by hyatt

4 edits
1 add in trunk/WebCore

Cleanup in RenderThemeWin and GraphicsContextCairo/Win

Sep 24, 2006:

11:35 PM Changeset in webkit [22220] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

7:35 PM Changeset in webkit [16553] by eseidel

1 edit
4 adds in trunk/LayoutTests

2006-09-24 Eric Seidel <eric@eseidel.com>

Reviewed by beth.

Browsers disagree on behavior for an invalid fill
http://bugzilla.opendarwin.org/show_bug.cgi?id=11017

svg/custom/invalid-fill-expected.checksum: Added.
svg/custom/invalid-fill-expected.png: Added.
svg/custom/invalid-fill-expected.txt: Added.
svg/custom/invalid-fill.svg: Added.

6:30 PM Changeset in webkit [16552] by eseidel

3 edits
4 adds in trunk

2006-09-24 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.

<svg:a> cannot be styled with a:hover
http://bugzilla.opendarwin.org/show_bug.cgi?id=11005

Test: svg/hixie/cascade/002.xml

css/cssstyleselector.cpp: (WebCore::checkPseudoState):

3:36 PM Changeset in webkit [16551] by weinig

12 edits
1 add in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10882
SVG needs Obj-C DOM bindings

Auto-generate the first 8 Objective-C SVG DOM bindings. The auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList, DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and DOMSVGTransformList.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMInternal.h:
bindings/objc/DOMSVG.h: Added.
ksvg2/svg/SVGAngle.idl:
ksvg2/svg/SVGLength.idl:
ksvg2/svg/SVGLengthList.idl:
ksvg2/svg/SVGMatrix.idl:
ksvg2/svg/SVGPathSeg.idl:
ksvg2/svg/SVGPathSegList.idl:
ksvg2/svg/SVGTransform.idl:
ksvg2/svg/SVGTransformList.idl:

1:30 PM Changeset in webkit [16550] by rwlbuis

2 edits in trunk/WebCore

Hopefully this unbreaks the build, should fix linux build too.
Thanks to WildFox and buildbot for the notification.

12:43 PM Changeset in webkit [16549] by rwlbuis

12 edits
5 adds in trunk/WebCore

Reviewed by eseidel.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6001
WebKit does not handle fallback custom cursors
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6002
WebKit does not properly handle SVG <cursor> element

Add support for svg cursor images. Also make sure hotspot
settings are handled correctly. Add tests for handling of css3
cursor syntax with hotspots in strict and quirks mode. Finally
implement fallback.

12:34 PM Changeset in webkit [16548] by weinig

10 edits in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11009
Auto-generate the internal methods interfaces for the Objective-C bindings

Auto-generate the internal method declarations into their own files named in the form DOMFooBarInternal.h for class DOMFooBar.

Remove all use of DOM_cast from code.

Assorted cleanups.

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (-[DOMNode _initWithNode:WebCore::]): (-[DOMNode WebCore::]): (-[DOMRange dealloc]): (-[DOMRange finalize]): (-[DOMRange _initWithRange:WebCore::]): (-[DOMRange WebCore::]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (-[DOMNodeFilter WebCore::]): (-[DOMNodeFilter dealloc]): (-[DOMNodeFilter finalize]): (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]): (-[DOMNodeIterator WebCore::]): (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]): (-[DOMTreeWalker WebCore::]):
bindings/objc/DOMAbstractView.mm: (-[DOMAbstractView _initWithAbstractView:WebCore::]):
bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (-[DOMCSSRule _initWithRule:WebCore::]): (-[DOMCSSValue _initWithValue:WebCore::]):
bindings/objc/DOMEvents.mm: (-[DOMEvent _initWithEvent:WebCore::]):
bindings/objc/DOMHTMLAppletElement.mm: (-[DOMHTMLAppletElement align]): (-[DOMHTMLAppletElement setAlign:]): (-[DOMHTMLAppletElement alt]): (-[DOMHTMLAppletElement setAlt:]): (-[DOMHTMLAppletElement archive]): (-[DOMHTMLAppletElement setArchive:]): (-[DOMHTMLAppletElement code]): (-[DOMHTMLAppletElement setCode:]): (-[DOMHTMLAppletElement codeBase]): (-[DOMHTMLAppletElement setCodeBase:]): (-[DOMHTMLAppletElement height]): (-[DOMHTMLAppletElement setHeight:]): (-[DOMHTMLAppletElement hspace]): (-[DOMHTMLAppletElement setHspace:]): (-[DOMHTMLAppletElement name]): (-[DOMHTMLAppletElement setName:]): (-[DOMHTMLAppletElement object]): (-[DOMHTMLAppletElement setObject:]): (-[DOMHTMLAppletElement vspace]): (-[DOMHTMLAppletElement setVspace:]): (-[DOMHTMLAppletElement width]): (-[DOMHTMLAppletElement setWidth:]):
bindings/objc/DOMInternal.h: (getDOMWrapper): (addDOMWrapper): (raiseOnDOMError):
bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
bindings/scripts/CodeGeneratorObjC.pm:

7:32 AM Changeset in webkit [16547] by rwlbuis