⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 26, 2006:

11:55 PM Changeset in webkit [22241] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-26 Steve Falkenburg <​sfalken@apple.com>

Build fix for clean release build.

  • WebKit.vcproj/WebKitGUID.vcproj:
10:27 PM Changeset in webkit [22240] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by sfalken.

Fixes <rdar://problem/4751600>
Hang on Amazon.com involving Flash

  • plugins/win/PluginStreamWin.cpp: Rename m_streamStarted to m_isTerminated to match Mac code (m_isTerminated is the negation of m_streamStarted) (WebCore::PluginStreamWin::PluginStreamWin): Initialize m_isTerminated to false to match Mac code. (WebCore::PluginStreamWin::~PluginStreamWin): Rename and negate. (WebCore::PluginStreamWin::stop): Remove assignment of m_streamStarted to match Mac code. (WebCore::PluginStreamWin::startStream): Rename and negate. Remove now-unnecessary assignment of m_streamStarted to true because we set m_isTerminated to false in the constructor. (WebCore::PluginStreamWin::destroyStream): Rename and negate.
  • plugins/win/PluginStreamWin.h: Rename m_streamStarted to m_isTerminated.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Send the correct response URL to the plugin.
5:56 PM Changeset in webkit [16594] by darin
  • 4 edits in trunk/WebCore

Reviewed by Steve.

  • clean up options for font code path
  • platform/Font.h:
  • platform/Font.cpp: (WebCore::Font::setCodePath): Added. Replaces boolean version. (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
5:47 PM Changeset in webkit [22239] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Disabled icondatabase for now

5:45 PM Changeset in webkit [22238] by sfalken
  • 5 edits
    2 adds in branches/WindowsMerge

Build tweaks

4:44 PM Changeset in webkit [16593] by sullivan
  • 10 edits in trunk

WebCore:

Reviewed by Darin

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]): Added limit parameter, passed down to Frame


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): Added limit parameter. Stop the search if it hits limit.

WebKit:

Reviewed by Darin

  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Added limit parameter, passed over the bridge. Stop the search if it hits limit.
  • WebView/WebViewPrivate.h:
  • WebView/WebView.m: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Added limit parameter, passed to WebHTMLView.
4:28 PM Changeset in webkit [22237] by seangies
  • 4 edits in branches/WindowsMerge

Handle tiled images correctly.

4:26 PM Changeset in webkit [16592] by seangies
  • 2 edits in trunk/WebCore

Removed #if's.

3:15 PM Changeset in webkit [22236] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-09-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Fixed encoding menu.
Set mime type in request.

  • WebFrame.cpp: (WebFrame::receivedResponse):
  • WebView.cpp: (WebView::setCustomTextEncodingName):
2:54 PM Changeset in webkit [16591] by yongjzha
  • 21 edits in S60/trunk

2006-09-26 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Sachin
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11048

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/inc/WebKitSurface.h: (CWebKitSurface::OffscreenBitmap): (CWebKitSurface::CurrentView): (CWebKitSurface::SetCurrentView): (CWebKitSurface::DisplayMode):
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::AutoScroll):
  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::SurfaceL): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::OpenPageViewL): (CWebKitControl::ClosePageView): (CWebKitControl::CancelPageView):
  • BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ScrollTo):
  • BrowserView/src/WebKitSurface.cpp: (CWebKitSurface::NewL): (CWebKitSurface::~CWebKitSurface): (CWebKitSurface::CWebKitSurface): (CWebKitSurface::ConstructL): (CWebKitSurface::Flip):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ConstructL): (CWebKitView::SetViewVisible): (CWebKitView::SizeChanged): (CWebKitView::ImageDecodeEvent): (CWebKitView::ProgressAndImageDecodeComplete):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LayoutChanged):
2:44 PM Changeset in webkit [22235] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Nuked another NotImplemented()

2:04 PM Changeset in webkit [22234] by seangies
  • 5 edits in branches/WindowsMerge

Link to debug libraries & C-runtime in debug config.

2:01 PM Changeset in webkit [22233] by lamadio
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-26 Lou Amadio <​lamadio@apple.com>

Reviewed by ggaren
Uninitialized variable caused a memory corruption on cnn.com

12:58 PM Changeset in webkit [16590] by thatcher
  • 1 delete in tags/WebKit-521.27.1/WebCore

Removing bad tag.

12:58 PM Changeset in webkit [16589] by thatcher
  • 5 edits in tags/WebCore-521.27.1/WebCore

Build fix and versioning.

12:56 PM Changeset in webkit [16588] by thatcher
  • 1 copy in tags/WebCore-521.27.1/WebCore

New tag part 2.

12:56 PM Changeset in webkit [16587] by justing
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4747695>
Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent

  • editing/deleting/list-item-1-expected.checksum: Added.
  • editing/deleting/list-item-1-expected.png: Added.
  • editing/deleting/list-item-1-expected.txt: Added.
  • editing/deleting/list-item-1.html: Added.
  • editing/execCommand/remove-list-item-1-expected.checksum: Added.
  • editing/execCommand/remove-list-item-1-expected.png: Added.
  • editing/execCommand/remove-list-item-1-expected.txt: Added.
  • editing/execCommand/remove-list-item-1.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4747695>
Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding to select special elements that are fully selected after expansion moves to positions that are visually distinct from the originals.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): If the content of the list item will be moved into another list, put it in a list item.
12:19 PM Changeset in webkit [16586] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John and TimH.


<rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty

  • editing/pasteboard/emacs-cntl-y-001-expected.checksum: Added.
  • editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
  • editing/pasteboard/emacs-cntl-y-001-expected.txt: Added.
  • editing/pasteboard/emacs-cntl-y-001.html: Added.

WebKit:

Reviewed by John and TimH.

<rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty

Use deleteBackward: when the killring string is empty. Was always using insertText:,
but that ends up early-returning if the string to insert is empty.


  • WebView/WebHTMLView.m: (-[NSArray yank:]): (-[NSArray yankAndSelect:]):
12:14 PM Changeset in webkit [22232] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.


Don't add subframes to global history or back/forward.

  • WebFrame.cpp: (WebFrame::receivedAllData): (WebFrame::createFrame):
10:12 AM Changeset in webkit [16585] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.


Temporary work-around for frame lifetime issue.

  • page/Frame.cpp: (WebCore::Frame::clear): (WebCore::Frame::disconnectOwnerElement):
9:58 AM Changeset in webkit [16584] by thatcher
  • 1 edit in tags/WebKit-521.27.1/WebCore/Info.plist

Versioning

9:57 AM Changeset in webkit [16583] by thatcher
  • 4 edits in tags/WebKit-521.27.1/WebCore/bindings/objc

Build fix.

9:56 AM Changeset in webkit [16582] by thatcher
  • 1 copy in tags/WebKit-521.27.1/WebCore

New tag part 2.

9:55 AM Changeset in webkit [16581] by thatcher
  • 1 add in tags/WebCore-521.27.1

New tag part 1.

9:54 AM Changeset in webkit [16580] by thatcher
  • 1 copy in tags/WebKit-521.27.1/WebKit

New tag part 2.

9:54 AM Changeset in webkit [16579] by thatcher
  • 1 add in tags/WebKit-521.27.1

New tag part 1.

6:44 AM Changeset in webkit [16578] by weinig
  • 11 edits
    2 adds in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
Auto-generate DOMSVGElement for the Objective-C bindings

  • Auto-generates DOMSVGElement.
  • Make SVGExceptions work like all the other ExceptionCode extensions (Range, XPath, etc.) by adding SVGExceptionOffset and SVGExceptionMax.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::): (KJS::setDOMException):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm: (raiseDOMException):
  • bindings/objc/DOMSVG.h:
  • bindings/objc/DOMSVGExecption.h: Added.
  • ksvg2/ksvg.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::setId): (WebCore::SVGElement::setXmlbase):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElement.idl:
  • ksvg2/svg/SVGException.h: Added. (WebCore::):
6:26 AM Changeset in webkit [16577] by eseidel
  • 2 edits in trunk/WebKitSite

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by anders.

  • projects/svg/status.xml: update status to reflect current state of SVG development
6:08 AM Changeset in webkit [16576] by eseidel
  • 4 edits
    5 adds in trunk

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by Tim H.


viewbox parser does not allow <tab> as a delimiter
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11014

Test: svg/hixie/viewbox/003.xml

  • ksvg2/svg/svgpathparser.cpp: (WebCore::isWhitespace): new function (WebCore::skipOptionalSpaces): (WebCore::skipOptionalSpacesOrComma):
5:56 AM Changeset in webkit [16575] by eseidel
  • 4 edits
    4 adds in trunk

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by Tim H.

SVGDocument::createElement does not create elements in the SVG namespace
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10932


Test: svg/custom/createelement.svg

  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::createElement):
  • ksvg2/svg/SVGDocument.h:
5:50 AM Changeset in webkit [16574] by eseidel
  • 5 edits
    2 adds in trunk

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by Tim H.


RenderPath::nodeAtPoint does not respect stroke width
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10829

Test: svg/custom/stroke-width-click.svg

  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeContains):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm:
5:41 AM Changeset in webkit [16573] by eseidel
  • 1 delete in trunk/WebCore/LayoutTests

Remove stray LayoutTests directory.

5:33 AM Changeset in webkit [16572] by eseidel
  • 12 edits in trunk/WebCore

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

Bring animation back to life
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11021


Register/unregister SVGSVGElements as time containers on insertion/removal.
Replace uses of DeprecatedString with String in SVGAnimationElement
Various whitespace clean-up.

  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations): (WebCore::SVGDocumentExtensions::pauseAnimations): (WebCore::SVGDocumentExtensions::unpauseAnimations):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::parseClockValue): (WebCore::SVGAnimationElement::targetAttribute): (WebCore::SVGAnimationElement::setTargetAttribute): (WebCore::SVGAnimationElement::attributeName):
  • ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::rendererIsNeeded):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::createRenderer): (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this) (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::handleTimerEvent):
  • ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • ksvg2/svg/SVGURIReference.h:
4:27 AM Changeset in webkit [16571] by bdash
  • 5 edits in trunk/WebCore

2006-09-26 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by mitzpettel.


Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/qt/GraphicsContextQt.cpp:
4:11 AM Changeset in webkit [16570] by hyatt
  • 1 edit in trunk/WebCore/platform/StringImpl.cpp

Fix win32 build bustage with StringImpl's toDouble method.

4:09 AM Changeset in webkit [22231] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Scrollbar cleanup. Fix up invalidation and rect handling.

1:51 AM Changeset in webkit [22230] by hyatt
  • 7 edits in branches/WindowsMerge

Implement scrollbar painting and theme changing support.

1:30 AM Changeset in webkit [16569] by hyatt
  • 2 edits in trunk/WebCore

Land groundwork for handling theme changes.

12:36 AM Changeset in webkit [16568] by andersca
  • 20 edits in trunk/WebCore

2006-09-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()


(Originally written by Eric Seidel).


  • bindings/js/kjs_window.cpp: (KJS::floatFeature):
  • ksvg2/svg/SVGAngle.cpp: (SVGAngle::setValueAsString):
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute):
  • ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::parseMappedAttribute):
  • ksvg2/svg/SVGFELightElement.cpp: (SVGFELightElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::parseMappedAttribute):
  • ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::parseMappedAttribute):
  • ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
  • ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
  • platform/AtomicString.h: (WebCore::AtomicString::toDouble):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toDouble):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toDouble):
  • platform/StringImpl.h:
  • rendering/DeprecatedSlider.cpp: (WebCore::DeprecatedSlider::updateFromElement):
  • xml/XPathGrammar.y:

Sep 25, 2006:

6:14 PM Changeset in webkit [16567] by harrison
  • 3 edits in trunk/WebCore

Reviewed by Tim Omernick and Tim Hatcher.

<rdar://problem/4717965> Text Field text parameterized attributes should work
<rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.


(-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
Cleaned up. Added text field and text area parameterzed attributes.


(-[WebCoreAXObject doAXLineForTextMarker:]):
Fixed to be zero-based and to deal with the first position properly.


(-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
Minor formatting.


(-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
(-[WebCoreAXObject indexForTextMarker:]):
(-[WebCoreAXObject textMarkerRangeForRange:]):
(-[WebCoreAXObject rangeForTextMarkerRange:]):
New utility methods.


(-[WebCoreAXObject doAXLineForIndex:]):
(-[WebCoreAXObject doAXRangeForLine:]):
(-[WebCoreAXObject doAXStringForRange:]):
(-[WebCoreAXObject doAXRangeForPosition:]):
(-[WebCoreAXObject doAXRangeForIndex:]):
(-[WebCoreAXObject doAXBoundsForRange:]):
(-[WebCoreAXObject doAXAttributedStringForRange:]):
(-[WebCoreAXObject doAXRTFForRange:]):
(-[WebCoreAXObject doAXStyleRangeForIndex:]):
Implement text field and text area parameterized attributes.


(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
Added text field and text area parameterzed attributes.

  • rendering/RenderTextControl.h: Made indexForVisiblePosition() and visiblePositionForIndex() public.
6:10 PM Changeset in webkit [22229] by aroben
  • 30 edits in branches/WindowsMerge

Setting svn:eol-style to native on all Windows-only files.

6:05 PM Changeset in webkit [22228] by aroben
  • 11 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

Set svn:eol-style to native and cleanup line endings on plugins files.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::receivedData): (WebCore::PluginStreamWin::receivedAllData):
5:58 PM Changeset in webkit [22227] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fixes <rdar://problem/4749494>
Crash/ASSERT in plugins at Fark.com

  • platform/win/ResourceLoaderWin.cpp: Store whether a particular job has received a response within the ResourceLoader object itself, since it's possible that we will enter the InternetReadFileExA while loop twice for the same job. (WebCore::ResourceLoaderWndProc): Ask the job whether it has received a response instead of assuming it hasn't. (WebCore::ResourceLoader::setHasReceivedResponse): Added. (WebCore::ResourceLoader::hasReceivedResponse): Added.
5:57 PM Changeset in webkit [16566] by aroben
  • 7 edits in trunk/WebCore

Reviewed by Brady.

Build fixes.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
  • platform/ResourceLoader.h: Store whether a particular job has received a response within the ResourceLoader object itself, since it's possible that we will enter the InternetReadFileExA while loop twice for the same job.
  • platform/ResourceLoaderInternal.h: Add private instance variable to store whether we've received a response. (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/win/GraphicsContextWin.cpp: Fix order of preprocessor directives.
  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader whether it has received a response instead of assuming it hasn't. (WebCore::ResourceLoader::setHasReceivedResponse): Added. (WebCore::ResourceLoader::hasReceivedResponse): Added.
  • platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to setProportion (ScrollBar::setProportion):
5:42 PM Changeset in webkit [22226] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

Continuing the removal of unnecessary notImplemented() calls.

  • platform/win/TemporaryLinkStubs.cpp: (PlatformMouseEvent::PlatformMouseEvent): (FrameWin::passWheelEventToChildWidget):
5:33 PM Changeset in webkit [16565] by beidson
  • 2 edits in trunk/WebCore

Requested by ggaren

Disabled IconDatabase logging by default

  • platform/Logging.cpp: (WebCore::):
4:43 PM Changeset in webkit [16564] by sfalken
  • 2 edits in trunk/WebCore

2006-09-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Jeff Jenkins.

Tweak CF types.

  • platform/cf/ResourceLoaderCFNet.cpp: (WebCore::willCacheResponse):
3:30 PM Changeset in webkit [22225] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-25 Steve Falkenburg <​sfalken@apple.com>

Add missing parameters to CG paint case.

  • WebFrame.cpp: (WebFrame::paint):
2:59 PM Changeset in webkit [16563] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

  • editing/execCommand/indent-empty-root-expected.checksum: Added.
  • editing/execCommand/indent-empty-root-expected.png: Added.
  • editing/execCommand/indent-empty-root-expected.txt: Added.
  • editing/execCommand/indent-empty-root.html: Added.

WebCore:

Reviewed by john


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message


  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Special case an empty root editable element.
2:57 PM Changeset in webkit [22224] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

More notImplemented()-ectomy.

  • platform/win/TemporaryLinkStubs.cpp: (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel):
2:45 PM Changeset in webkit [22223] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

Remove calls to notImplemented() from functions that can fail safely.

  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::originalRequestURL): (FrameWin::isLoadTypeReload): (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):
2:40 PM Changeset in webkit [16562] by beidson
  • 2 edits in trunk/WebCore

Math error in SystemTimeWin

2:31 PM Changeset in webkit [16561] by thatcher
  • 3 edits in trunk/WebCore/bindings/objc

Build fix to avoid property name conflict warning.

2:30 PM Changeset in webkit [22222] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by sfalken.

Make notImplemented() crash even when not linked against the debug CRT.

  • platform/win/TemporaryLinkStubs.cpp: (notImplemented): Change _CrtDbgBreak() to ASSERT(0)
1:41 PM Changeset in webkit [16560] by ap
  • 5 edits in trunk/WebCore

Reviewed by Eric.

Whitespace cleanup; rename *job variables to *loader.

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp): (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct): (KJS::JSXMLHttpRequestConstructorImp::construct): (KJS::JSXMLHttpRequest::getOwnPropertySlot): (KJS::JSXMLHttpRequest::getValueProperty): (KJS::JSXMLHttpRequest::put): (KJS::JSXMLHttpRequest::putValueProperty): (KJS::JSXMLHttpRequest::mark): (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
  • bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::toBoolean):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedData):
  • xml/xmlhttprequest.h: (WebCore::):
12:04 PM Changeset in webkit [16559] by thatcher
  • 13 edits in trunk

WebCore:

Reviewed by Brady.

  • Deprecate the rest of the old-style methods that are not generated.
  • Add @property syntax to DOMRange.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMRange setStart:offset:]): (-[DOMRange setEnd:offset:]): (-[DOMRange compareBoundaryPoints:sourceRange:]): (-[DOMRange setStart::]): (-[DOMRange setEnd::]): (-[DOMRange compareBoundaryPoints::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]):
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm: (-[DOMDocument getComputedStyle:pseudoElement:]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMRange.h:
  • bindings/objc/DOMTraversal.h:

WebKit:

Reviewed by Brady.

Use the non-deprecated method names for getComputedStyle, setEnd and setStart.

  • WebInspector/WebInspector.m: (-_highlightNode:):
  • WebView/WebHTMLView.m: (unionDOMRanges): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebTextCompleteController doCompletion]):
  • WebView/WebView.m: (-[WebView computedStyleForElement:pseudoElement:]):
10:37 AM Changeset in webkit [16558] by thatcher
  • 4 edits in trunk/WebCore/bindings/objc

Build fix.

2:52 AM Changeset in webkit [16557] by eseidel
  • 53 edits
    4 adds in trunk

2006-09-25 Eric Seidel <​eric@eseidel.com>

Reviewed by mjs.


Outermost <svg> element should clip to viewport
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11007

Test: svg/custom/viewport-clip.svg

  • css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
1:08 AM Changeset in webkit [16556] by andersca
  • 21 edits in trunk/WebCore

2006-09-25 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • css/MediaList.cpp: Remove unused header.


  • dom/Document.cpp: (WebCore::Document::clear): Use clear instead of iterating through the list of event listeners, removing each one. (Doing that causes a crash when running the layout tests with GuardMalloc turned on)


  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::appendFormData): Update due to changes in the SSL key generator.


  • ksvg2/svg/SVGAngle.cpp: Remove unused header.


  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute): Rename methods and pass Strings instead of DeprecatedStrings to parseSeparatedList.


  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp: Remove unused headers.


  • ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::parseSeparatedList):
  • ksvg2/svg/SVGHelper.h: Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.


  • ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::parse):
  • ksvg2/svg/SVGLengthList.h: Use Vector<String> instead of DeprecatedStringList.


  • loader/Cache.cpp: (WebCore::Cache::requestImage): (WebCore::Cache::requestStyleSheet): (WebCore::Cache::requestScript): (WebCore::Cache::requestXSLStyleSheet): (WebCore::Cache::requestXBLDocument): (WebCore::Cache::remove): (WebCore::Cache::get): Use a String as the key in the cache set instead of a RefPtr<StringImpl>.


  • loader/DocLoader.cpp: (WebCore::DocLoader::needReload):
  • loader/DocLoader.h: Use a HashSet instead of DeprecatedStringList.


  • page/FrameView.h: Remove declarations that have no functions.


  • platform/SSLKeyGenerator.h:
  • platform/mac/SSLKeyGeneratorMac.mm: (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): Convert to use Vector<String> instead of DeprecatedStringList, and String instead of DeprecatedString.
1:07 AM Changeset in webkit [22221] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix win32 cursor build bustage. Fix my own build bustage from the shifting around of the cairo/win get/ReleaseWindowsContext calls.

1:06 AM Changeset in webkit [16555] by hyatt
  • 2 edits in trunk/WebCore

Fix win32 cursor build bustage.

12:39 AM Changeset in webkit [16554] by hyatt
  • 4 edits
    1 add in trunk/WebCore

Cleanup in RenderThemeWin and GraphicsContextCairo/Win

Note: See TracTimeline for information about the timeline view.