⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 27, 2006:

11:46 PM Changeset in webkit [16611] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas. Make sure
selectCursor checks for whether or not a scrollbar was hit. Also stub out a mouseMoved method for
scrollbars to provide hover feedback if needed.

Reviewed by Eric

  • page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent):
  • platform/ScrollBar.h: (WebCore::ScrollBar::mouseMoved):
11:32 PM Changeset in webkit [16610] by sfalken
  • 2 edits
    1 delete in trunk/JavaScriptCore

2006-09-27 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej.


More build tweaks

11:29 PM Changeset in webkit [22253] by sfalken
  • 6 edits
    2 deletes in branches/WindowsMerge
9:56 PM Changeset in webkit [16609] by aroben
  • 2 edits in trunk/WebCore

2006-09-27 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej and Adam, landed by Adam

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=11072
Windows build is busted

  • platform/win/TemporaryLinkStubs.cpp: (ScrollView::paint): (ScrollView::themeChanged):
9:35 PM Changeset in webkit [16608] by sullivan
  • 2 edits in trunk/JavaScriptCore
  • kjs/function.cpp: (KJS::FunctionImp::getParameterName): removed assertion that displeased gcc 4.0.1 (build 5420): ASSERT(static_cast<size_t>(index) == index);
7:00 PM Changeset in webkit [16607] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by GGaren.

Cleanup of previous fix which was to address Radar: 4752492

  • kjs/function.cpp: (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
  • kjs/function.h:
5:58 PM Changeset in webkit [16606] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adele.

Fixes a GC stack overflow crash.
The change is to move from a linked list implementation of Parameters to a Vector.
The problem with the linked list is that each one creates it's own stack frame when being destroyed and in extreme cases this caused the stack to overflow.

  • kjs/function.cpp: (KJS::Parameter::Parameter): (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
  • kjs/function.h:
5:54 PM Changeset in webkit [16605] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-09-27 Steve Falkenburg <​sfalken@apple.com>

Fix last path fix.

5:50 PM Changeset in webkit [22252] by sfalken
  • 4 edits in branches/WindowsMerge/WebCore

2006-09-27 Steve Falkenburg <​sfalken@apple.com>

B&I build fixes

  • WebCore.vcproj/WebCore.make:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/build-generated-files.sh:
4:55 PM Changeset in webkit [22251] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by sfalken.

Don't die when plugins try to open a new window.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Remove call to DebugBreak()
4:48 PM Changeset in webkit [16604] by eseidel
  • 7 edits
    4 adds in trunk

2006-09-27 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

paths with no fill specified default to black but do not recieve paint-related mouse events
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11069
The default fill was being applied at the wrong place in the rendering chain, causing this problem.

Test: svg/custom/hover-default-fill.svg

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
  • ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::isFilled): remove null check (WebCore::KSVGPainterFactory::fillPaintServer): remove null check (WebCore::KSVGPainterFactory::isStroked): remove null check (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
  • ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill): added. (WebCore::SVGPaint::defaultStroke): added.
  • ksvg2/svg/SVGPaint.h:
3:57 PM Changeset in webkit [22250] by sfalken
  • 1 add in branches/WindowsMerge/JavaScriptCore/ChangeLog

Add missing change log

3:56 PM Changeset in webkit [22249] by sfalken
  • 4 edits in branches/WindowsMerge

2006-09-27 Steve Falkenburg <​sfalken@apple.com>

B&I build script tweaks.

3:54 PM Changeset in webkit [16603] by justing
  • 3 edits in trunk/WebKit

Reviewed by thatcher


<rdar://problem/4044271>
Writing Direction menu doesn't reflect the current writing direction (9773)

  • English.lproj/Localizable.strings: Added "Right to Left" and "Left to Right"
  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): Validate menu items that perform toggleBaseWritingDirection and changeBaseWritingDirection. Disable the menu item that changes the writing direction to NSWritingDirectionNautral because NSWritingDirectionNatural's behavior can't be implemented with CSS. Take control of the title of the menu item that performs toggleBaseWritingDirection: instead of checking/unchecking it, otherwise we wouldn't know what a check means. (-[NSArray changeBaseWritingDirection:]): ASSERT that the requested writing direction is not NSWritingDirectionNatural, since we've disabled the menu item that performs it.
3:03 PM Changeset in webkit [22248] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-27 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Hyatt.

Turn on CG

  • config.h:
3:02 PM Changeset in webkit [22247] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Lou.

Fix crash in plugins due to Flash on nytimes.com

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): memset m_stream to 0
3:00 PM Changeset in webkit [16602] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-09-27 Steve Falkenburg <​sfalken@apple.com>

Set path before build.

2:53 PM Changeset in webkit [22246] by sfalken
  • 3 adds in branches/WindowsMerge/JavaScriptCore

2006-09-27 Steve Falkenburg <​sfalken@apple.com>

B&I build script.

1:29 PM Changeset in webkit [16601] by rwlbuis
  • 8 edits
    8 adds in trunk

Reviewed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
SVG handles em units incorrectly

Calculate viewport coordinates at layout time, since
at this point the font size is known and lengths depending
on font sizes can be calculated correctly.

12:51 PM Changeset in webkit [16600] by seangies
  • 3 edits in trunk/JavaScriptCore

Debug configs should link to debug runtime.

12:29 PM Changeset in webkit [16599] by eseidel
  • 8 edits in trunk

2006-09-27 Eric Seidel <​eric@eseidel.com>

Reviewed by darin.

Change our invalid-fill error behavior to match Opera (and soon Firefox)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11017

  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::isFilled): (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::isStroked): (WebCore::KSVGPainterFactory::strokePaintServer):
12:07 PM Changeset in webkit [16598] by beidson
  • 2 edits in trunk/WebCore

Build fix

  • loader/icon/IconDatabase.cpp: (WebCore::readySQLStatement):
11:59 AM Changeset in webkit [22245] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by sfalken.

Scroll plugins (at least in some cases).

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollBy): Pass SW_SCROLLCHILDREN to ScrollWindowEx()
11:47 AM Changeset in webkit [22244] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin
11:46 AM Changeset in webkit [16597] by gramps
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

Changed line ending from DOS to UNIX format so it doesn't die running
on my machine. ;)

11:20 AM Changeset in webkit [16596] by beidson
  • 6 edits in trunk

WebKit:

Reviewed by Maciej, landed by Brady

Update URL request associated with provisional data source on redirect.
Notify IWebFrameLoadDelegate of redirects for the provisional load.
Notify IWebFrameLoadDelegate of a provisional load being commited.

  • COM/WebDataSource.cpp: (WebDataSource::replaceRequest):
  • COM/WebDataSource.h:
  • COM/WebFrame.cpp: (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData):

WebKitTools:

Reviewed by Maciej, landed by Brady

Fix URL bar updating.

  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didStartProvisionalLoadForFrame): (SpinneretWebHost::didCommitLoadForFrame): (SpinneretWebHost::didFinishLoadForFrame):
11:03 AM Changeset in webkit [22243] by sfalken
  • 5 edits in branches/WindowsMerge

2006-09-27 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Fix <rdar://problem/4753220>.
Hang using bugreporter in Boomer.


Force text into simple code path in all cases.

  • WebFrame.cpp: (FormValuesPropertyBag::GetPropertyInfo):
  • WebPreferences.cpp: (WebPreferences::initialize):
10:59 AM Changeset in webkit [16595] by beidson
  • 4 edits in trunk/WebCore

WebCore:

Reviewed by Adam

In very specific circumstances, prepared SQLStatements can become invalid without
any warning. This checks for that state and re-prepares the statement and also
adds more aggressive error-checking everywhere these statements are used.

  • loader/icon/IconDatabase.cpp: (WebCore::readySQLStatement): Check if the statement is expired - reprepare it (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto (WebCore::IconDatabase::forgetPageURLQuery): Ditto (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto (WebCore::IconDatabase::addIconForIconURLQuery): Ditto (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
  • loader/icon/SQLStatement.h:


8:58 AM Changeset in webkit [22242] by seangies
  • 2 edits
    2 adds in branches/WindowsMerge/WebCore

Add WebCoreSystemInterface.h/cpp to platform/win

Sep 26, 2006:

11:55 PM Changeset in webkit [22241] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-26 Steve Falkenburg <​sfalken@apple.com>

Build fix for clean release build.

  • WebKit.vcproj/WebKitGUID.vcproj:
10:27 PM Changeset in webkit [22240] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by sfalken.

Fixes <rdar://problem/4751600>
Hang on Amazon.com involving Flash

  • plugins/win/PluginStreamWin.cpp: Rename m_streamStarted to m_isTerminated to match Mac code (m_isTerminated is the negation of m_streamStarted) (WebCore::PluginStreamWin::PluginStreamWin): Initialize m_isTerminated to false to match Mac code. (WebCore::PluginStreamWin::~PluginStreamWin): Rename and negate. (WebCore::PluginStreamWin::stop): Remove assignment of m_streamStarted to match Mac code. (WebCore::PluginStreamWin::startStream): Rename and negate. Remove now-unnecessary assignment of m_streamStarted to true because we set m_isTerminated to false in the constructor. (WebCore::PluginStreamWin::destroyStream): Rename and negate.
  • plugins/win/PluginStreamWin.h: Rename m_streamStarted to m_isTerminated.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Send the correct response URL to the plugin.
5:56 PM Changeset in webkit [16594] by darin
  • 4 edits in trunk/WebCore

Reviewed by Steve.

  • clean up options for font code path
  • platform/Font.h:
  • platform/Font.cpp: (WebCore::Font::setCodePath): Added. Replaces boolean version. (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
5:47 PM Changeset in webkit [22239] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Disabled icondatabase for now

5:45 PM Changeset in webkit [22238] by sfalken
  • 5 edits
    2 adds in branches/WindowsMerge

Build tweaks

4:44 PM Changeset in webkit [16593] by sullivan
  • 10 edits in trunk

WebCore:

Reviewed by Darin

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]): Added limit parameter, passed down to Frame


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): Added limit parameter. Stop the search if it hits limit.

WebKit:

Reviewed by Darin

  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Added limit parameter, passed over the bridge. Stop the search if it hits limit.
  • WebView/WebViewPrivate.h:
  • WebView/WebView.m: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Added limit parameter, passed to WebHTMLView.
4:28 PM Changeset in webkit [22237] by seangies
  • 4 edits in branches/WindowsMerge

Handle tiled images correctly.

4:26 PM Changeset in webkit [16592] by seangies
  • 2 edits in trunk/WebCore

Removed #if's.

3:15 PM Changeset in webkit [22236] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-09-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam Roben.

Fixed encoding menu.
Set mime type in request.

  • WebFrame.cpp: (WebFrame::receivedResponse):
  • WebView.cpp: (WebView::setCustomTextEncodingName):
2:54 PM Changeset in webkit [16591] by yongjzha
  • 21 edits in S60/trunk

2006-09-26 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Sachin
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11048

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/inc/WebKitSurface.h: (CWebKitSurface::OffscreenBitmap): (CWebKitSurface::CurrentView): (CWebKitSurface::SetCurrentView): (CWebKitSurface::DisplayMode):
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::AutoScroll):
  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::SurfaceL): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::OpenPageViewL): (CWebKitControl::ClosePageView): (CWebKitControl::CancelPageView):
  • BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ScrollTo):
  • BrowserView/src/WebKitSurface.cpp: (CWebKitSurface::NewL): (CWebKitSurface::~CWebKitSurface): (CWebKitSurface::CWebKitSurface): (CWebKitSurface::ConstructL): (CWebKitSurface::Flip):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ConstructL): (CWebKitView::SetViewVisible): (CWebKitView::SizeChanged): (CWebKitView::ImageDecodeEvent): (CWebKitView::ProgressAndImageDecodeComplete):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LayoutChanged):
2:44 PM Changeset in webkit [22235] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Nuked another NotImplemented()

2:04 PM Changeset in webkit [22234] by seangies
  • 5 edits in branches/WindowsMerge

Link to debug libraries & C-runtime in debug config.

2:01 PM Changeset in webkit [22233] by lamadio
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-26 Lou Amadio <​lamadio@apple.com>

Reviewed by ggaren
Uninitialized variable caused a memory corruption on cnn.com

12:58 PM Changeset in webkit [16590] by thatcher
  • 1 delete in tags/WebKit-521.27.1/WebCore

Removing bad tag.

12:58 PM Changeset in webkit [16589] by thatcher
  • 5 edits in tags/WebCore-521.27.1/WebCore

Build fix and versioning.

12:56 PM Changeset in webkit [16588] by thatcher
  • 1 copy in tags/WebCore-521.27.1/WebCore

New tag part 2.

12:56 PM Changeset in webkit [16587] by justing
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4747695>
Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent

  • editing/deleting/list-item-1-expected.checksum: Added.
  • editing/deleting/list-item-1-expected.png: Added.
  • editing/deleting/list-item-1-expected.txt: Added.
  • editing/deleting/list-item-1.html: Added.
  • editing/execCommand/remove-list-item-1-expected.checksum: Added.
  • editing/execCommand/remove-list-item-1-expected.png: Added.
  • editing/execCommand/remove-list-item-1-expected.txt: Added.
  • editing/execCommand/remove-list-item-1.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4747695>
Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding to select special elements that are fully selected after expansion moves to positions that are visually distinct from the originals.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): If the content of the list item will be moved into another list, put it in a list item.
12:19 PM Changeset in webkit [16586] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John and TimH.


<rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty

  • editing/pasteboard/emacs-cntl-y-001-expected.checksum: Added.
  • editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
  • editing/pasteboard/emacs-cntl-y-001-expected.txt: Added.
  • editing/pasteboard/emacs-cntl-y-001.html: Added.

WebKit:

Reviewed by John and TimH.

<rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty

Use deleteBackward: when the killring string is empty. Was always using insertText:,
but that ends up early-returning if the string to insert is empty.


  • WebView/WebHTMLView.m: (-[NSArray yank:]): (-[NSArray yankAndSelect:]):
12:14 PM Changeset in webkit [22232] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.


Don't add subframes to global history or back/forward.

  • WebFrame.cpp: (WebFrame::receivedAllData): (WebFrame::createFrame):
10:12 AM Changeset in webkit [16585] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.


Temporary work-around for frame lifetime issue.

  • page/Frame.cpp: (WebCore::Frame::clear): (WebCore::Frame::disconnectOwnerElement):
9:58 AM Changeset in webkit [16584] by thatcher
  • 1 edit in tags/WebKit-521.27.1/WebCore/Info.plist

Versioning

9:57 AM Changeset in webkit [16583] by thatcher
  • 4 edits in tags/WebKit-521.27.1/WebCore/bindings/objc

Build fix.

9:56 AM Changeset in webkit [16582] by thatcher
  • 1 copy in tags/WebKit-521.27.1/WebCore

New tag part 2.

9:55 AM Changeset in webkit [16581] by thatcher
  • 1 add in tags/WebCore-521.27.1

New tag part 1.

9:54 AM Changeset in webkit [16580] by thatcher
  • 1 copy in tags/WebKit-521.27.1/WebKit

New tag part 2.

9:54 AM Changeset in webkit [16579] by thatcher
  • 1 add in tags/WebKit-521.27.1

New tag part 1.

6:44 AM Changeset in webkit [16578] by weinig
  • 11 edits
    2 adds in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
Auto-generate DOMSVGElement for the Objective-C bindings

  • Auto-generates DOMSVGElement.
  • Make SVGExceptions work like all the other ExceptionCode extensions (Range, XPath, etc.) by adding SVGExceptionOffset and SVGExceptionMax.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::): (KJS::setDOMException):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm: (raiseDOMException):
  • bindings/objc/DOMSVG.h:
  • bindings/objc/DOMSVGExecption.h: Added.
  • ksvg2/ksvg.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::setId): (WebCore::SVGElement::setXmlbase):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElement.idl:
  • ksvg2/svg/SVGException.h: Added. (WebCore::):
6:26 AM Changeset in webkit [16577] by eseidel
  • 2 edits in trunk/WebKitSite

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by anders.

  • projects/svg/status.xml: update status to reflect current state of SVG development
6:08 AM Changeset in webkit [16576] by eseidel
  • 4 edits
    5 adds in trunk

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by Tim H.


viewbox parser does not allow <tab> as a delimiter
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11014

Test: svg/hixie/viewbox/003.xml

  • ksvg2/svg/svgpathparser.cpp: (WebCore::isWhitespace): new function (WebCore::skipOptionalSpaces): (WebCore::skipOptionalSpacesOrComma):
5:56 AM Changeset in webkit [16575] by eseidel
  • 4 edits
    4 adds in trunk

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by Tim H.

SVGDocument::createElement does not create elements in the SVG namespace
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10932


Test: svg/custom/createelement.svg

  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::createElement):
  • ksvg2/svg/SVGDocument.h:
5:50 AM Changeset in webkit [16574] by eseidel
  • 5 edits
    2 adds in trunk

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by Tim H.


RenderPath::nodeAtPoint does not respect stroke width
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10829

Test: svg/custom/stroke-width-click.svg

  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeContains):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm:
5:41 AM Changeset in webkit [16573] by eseidel
  • 1 delete in trunk/WebCore/LayoutTests

Remove stray LayoutTests directory.

5:33 AM Changeset in webkit [16572] by eseidel
  • 12 edits in trunk/WebCore

2006-09-26 Eric Seidel <​eric@eseidel.com>

Reviewed by mitz.

Bring animation back to life
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11021


Register/unregister SVGSVGElements as time containers on insertion/removal.
Replace uses of DeprecatedString with String in SVGAnimationElement
Various whitespace clean-up.

  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations): (WebCore::SVGDocumentExtensions::pauseAnimations): (WebCore::SVGDocumentExtensions::unpauseAnimations):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::parseClockValue): (WebCore::SVGAnimationElement::targetAttribute): (WebCore::SVGAnimationElement::setTargetAttribute): (WebCore::SVGAnimationElement::attributeName):
  • ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::rendererIsNeeded):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::createRenderer): (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this) (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::handleTimerEvent):
  • ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • ksvg2/svg/SVGURIReference.h:
4:27 AM Changeset in webkit [16571] by bdash
  • 5 edits in trunk/WebCore

2006-09-26 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by mitzpettel.


Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/qt/GraphicsContextQt.cpp:
4:11 AM Changeset in webkit [16570] by hyatt
  • 1 edit in trunk/WebCore/platform/StringImpl.cpp

Fix win32 build bustage with StringImpl's toDouble method.

4:09 AM Changeset in webkit [22231] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Scrollbar cleanup. Fix up invalidation and rect handling.

1:51 AM Changeset in webkit [22230] by hyatt
  • 7 edits in branches/WindowsMerge

Implement scrollbar painting and theme changing support.

1:30 AM Changeset in webkit [16569] by hyatt
  • 2 edits in trunk/WebCore

Land groundwork for handling theme changes.

12:36 AM Changeset in webkit [16568] by andersca
  • 20 edits in trunk/WebCore

2006-09-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()


(Originally written by Eric Seidel).


  • bindings/js/kjs_window.cpp: (KJS::floatFeature):
  • ksvg2/svg/SVGAngle.cpp: (SVGAngle::setValueAsString):
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute):
  • ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::parseMappedAttribute):
  • ksvg2/svg/SVGFELightElement.cpp: (SVGFELightElement::parseMappedAttribute):
  • ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::parseMappedAttribute):
  • ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::parseMappedAttribute):
  • ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
  • ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
  • platform/AtomicString.h: (WebCore::AtomicString::toDouble):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toDouble):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toDouble):
  • platform/StringImpl.h:
  • rendering/DeprecatedSlider.cpp: (WebCore::DeprecatedSlider::updateFromElement):
  • xml/XPathGrammar.y:
Note: See TracTimeline for information about the timeline view.