Timeline
Sep 28, 2006:
- 11:30 PM Changeset in webkit [22265] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Make setValue work on win32 scrollbars. Fix buggy math.
- 11:16 PM Changeset in webkit [22264] by
-
- 2 edits in branches/WindowsMerge/WebCore
Make scrollbars on win32 give proper hover feedback.
- 7:10 PM Changeset in webkit [22263] by
-
- 10 edits5 adds in branches/WindowsMerge
2006-09-28 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej.
Use $(ConfigSuffix) set via vsprops files to add _debug
to end of debug filenames.
- 7:07 PM Changeset in webkit [16632] by
-
- 4 edits2 adds in trunk/JavaScriptCore
2006-09-28 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej.
Use $(ConfigSuffix) set via vsprops files to add _debug
to end of debug filenames.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/debug.vsprops: Added.
- JavaScriptCore.vcproj/dftables/dftables.vcproj:
- JavaScriptCore.vcproj/release.vsprops: Added.
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
- 5:56 PM Changeset in webkit [22262] by
-
- 2 edits in branches/WindowsMerge/WebCore/platform/win
Forgot these in the last checkin (d'oh!)
- 5:55 PM Changeset in webkit [22261] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Reviewed by Hyatt.
Avoid creating LOGFONTs for bitmap fonts under CG, since we don't
support them anyway.
- platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData): Set lfOutPrecision to OUT_TT_ONLY_PRECIS to avoid bitmap fonts.
- platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Change the LOG_ERROR back to an ASSERT since we should never reach this condition now.
- 5:39 PM Changeset in webkit [16631] by
-
- 3 edits in trunk/WebCore
Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::shouldDragAutoNode): (WebCore::FrameMac::sendContextMenuEvent):
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]):
- 5:21 PM Changeset in webkit [22260] by
-
- 3 edits in branches/WindowsMerge/WebCore
Eliminate viewportToContents and contentsToViewport
- 5:17 PM Changeset in webkit [16630] by
-
- 11 edits in trunk/WebCore
Eliminate viewportToContents and contentsToViewport
- 4:32 PM Changeset in webkit [16629] by
-
- 2 edits in trunk/WebCore
Build fix by adding missing files for CommandByName
- WebCore.xcodeproj/project.pbxproj:
- 3:47 PM Changeset in webkit [16628] by
-
- 2 edits in trunk/WebCore
Adding CommandByName files to the vcproj
- WebCore.vcproj/WebCore/WebCore.vcproj:
- 3:23 PM Changeset in webkit [16627] by
-
- 2 edits in trunk/WebKit
fixing the windows build
- COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick):
- 3:06 PM Changeset in webkit [22259] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Anders.
Fail without crashing and log an error when CG encounters a bitmap
font.
- platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Trade LOG_ERROR for ASSERT_WITH_MESSAGE
- 2:41 PM Changeset in webkit [22258] by
-
- 7 edits1 add in branches/WindowsMerge
- 2:39 PM Changeset in webkit [16626] by
-
- 8 edits2 adds in trunk/WebCore
- 2:38 PM Changeset in webkit [16625] by
-
- 2 edits in S60/trunk/WebCore
2006-09-28 brmorris <bradley.morrison@nokia.com>
Reviewed by Zalan.
DESC: Include color attribute value in stringified info
http://bugzilla.opendarwin.org/show_bug.cgi?id=EBUGZILLADOWN
- khtml/rendering/render_object.cpp: (RenderObject::information): Now includes Style()->color
- 2:33 PM Changeset in webkit [16624] by
-
- 5 edits2 deletes in trunk/WebCore
Reviewed by Adele.
Remove no-longer-used PopUpButton.
- WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
- WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h, PopUpButtonMac.mm
- platform/PopUpButton.h: Removed.
- platform/mac/PopUpButtonMac.mm: Removed.
- platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
- rendering/DeprecatedRenderSelect.cpp: Change #include of PopUpButton.h to ListBox.h
- 2:31 PM Changeset in webkit [22257] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by Adele.
Remove never-to-be-used PopUpButton
- WebCore.vcproj/WebCore.vcproj: Remove PopUpButton.h
- platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
- 2:28 PM Changeset in webkit [16623] by
-
- 2 edits in trunk/WebKitTools
Suggested by Darin.
Moved an extern declaration from inside a method to the top of the file.
- DumpRenderTree/EventSendingController.m: (-[EventSendingController clearKillRing]):
- 2:07 PM Changeset in webkit [16622] by
-
- 11 edits in trunk
Reviewed by Alice.
- support for change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows 10% perf. regression (copying strings while decoding)
- wtf/Vector.h: Changed VectorBuffer so that the general case contains an instance of the 0 case, since deriving from it was violating the Liskov Substitution Principle. (WTF::VectorBuffer::releaseBuffer): Added. Releases the buffer so it can be adopted by another data structure that uses the FastMalloc.h allocator. Returns 0 if the internal buffer was being used. (WTF::Vector::releaseBuffer): Added. Releases the buffer as above or creates a new one in the case where the internal buffer was being used.
WebCore:
Reviewed by Alice.
- change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows 10% perf. regression (copying strings while decoding)
Use Vector<UChar> instead of String when building up the decoded string in
the ICU and Mac decoders. Using String leads to O(n2) behavior because
String grows the buffer every single time that append is called. Using
Vector::append instead of String::append also avoids constructing a string
each time just to append and a questionable copy that is done inside the
String::append function which also contributed to the slowness.
- platform/PlatformString.h:
- platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a Vector<UChar>, adopting the buffer from the vector to avoid copying and memory allocation.
- platform/StringImpl.h:
- platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
- platform/StreamingTextDecoder.h:
- platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM): Change to use a Vector<UChar> instead of a String, since vectors have better resizing performance (they store a separate capacity).
- platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
- platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode): Change to use Vector<UChar> instead of String and then create a string at the end of the process using the new adopt function.
- 2:05 PM Changeset in webkit [16621] by
-
- 4 edits in trunk
Explicitly specify stabs for Debug and Production.
- 1:25 PM Changeset in webkit [16620] by
-
- 4 edits in trunk
LayoutTests:
Reviewed by Justin.
Call clearKillRing() so we are guaranteed to start with empty kill ring.
- editing/pasteboard/emacs-cntl-y-001.html:
WebKitTools:
Reviewed by Justin.
Add clearKillRing so we can test emacs support with empty kill ring.
- DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController clearKillRing]):
- 1:12 PM Changeset in webkit [16619] by
-
- 1 edit3 adds in S60/trunk/LayoutTests
2006-09-28 brmorris <bradley.morrison@nokia.com>
Reviewed by myself :)
DESC: Added tests for tabbed navigation via:
<meta name="navigation" content="tabbed"/>
- manual/10222_tabbed_navigation-mobile-expected.txt: Added.
- manual/10222_tabbed_navigation.html: Added.
- 1:07 PM Changeset in webkit [22256] by
-
- 5 edits1 add in branches/WindowsMerge/WebCore
Reviewed by Alice.
Replace notImplemented() with LOG_NOIMPL() and STOP_NOIMPL() macros
which generate debug output. STOP_NOIMPL() also generates a debug
break. Replace calls to notImplemented() with
LOG_NOIMPL()/STOP_NOIMPL() as appropriate. This should stop some unnecessary
crashes where notImplemented() was called from a method that can fail
safely.
- WebCore.vcproj/WebCore.vcproj: Added NotImplemented.h
- platform/win/FontWin.cpp: Use LOG_NOIMPL() instead of notImplemented(). (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- platform/win/NotImplemented.h: Added. Contains new LOG_NOIMPL() and STOP_NOIMPL() macros.
- platform/win/TemporaryLinkStubs.cpp: Use LOG_NOIMPL() and STOP_NOIMPL() instead of notImplemented() or nothing. (PopUpButton::focusPolicy): (PopUpButton::populate): (Widget::enableFlushDrawing): (Widget::focusPolicy): (Widget::disableFlushDrawing): (Widget::lockDrawingFocus): (Widget::unlockDrawingFocus): (JavaAppletWidget::JavaAppletWidget): (TextField::selectAll): (TextField::addSearchResult): (TextField::selectionStart): (TextField::hasSelectedText): (TextField::selectedText): (TextField::setAutoSaveName): (TextField::checksDescendantsForFocus): (TextField::setSelection): (TextField::setMaxResults): (TextField::edited): (Slider::Slider): (Slider::sizeHint): (Slider::setValue): (Slider::setMaxValue): (Slider::setMinValue): (Slider::~Slider): (Slider::setFont): (Slider::value): (ListBox::sizeForNumberOfLines): (ListBox::isSelected): (ListBox::checksDescendantsForFocus): (Slider::focusPolicy): (ListBox::focusPolicy): (TextField::focusPolicy): (Cursor::Cursor): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::searchableIndexIntroduction): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::ServeSynchronousRequest): (FrameWin::focusWindow): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::registerCommandForRedo): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::getAppletInstanceForWidget): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::canPaste): (FrameWin::canGoBackOrForward): (FrameWin::shouldInterruptJavaScript): (FrameWin::openURL): (FrameWin::print): (FrameWin::passMouseDownEventToWidget): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::issuePasteCommand): (FrameWin::issueUndoCommand): (FrameWin::issueRedoCommand): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::issueTransposeCommand): (FrameWin::passWheelEventToChildWidget): (FrameWin::mimeTypeForFileName): (FrameWin::scheduleClose): (FrameWin::markMisspellings): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::originalRequestURL): (FrameWin::isLoadTypeReload): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::historyURL): (GraphicsContext::addRoundedRectClip): (GraphicsContext::addInnerRoundedRectClip): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::moveCursor): (WebCore::inputElementAltText): (WebCore::findWordBoundary): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (FrameView::updateBorder): (FrameWin::restoreDocumentState): (FrameWin::partClearedInBegin): (FrameWin::createEmptyDocument): (FrameWin::overrideMediaType): (FrameWin::markedTextRange): (FrameWin::addMessageToConsole): (FrameWin::shouldChangeSelection): (FrameWin::respondToChangedSelection): (FrameWin::saveDocumentState): (FrameWin::registerCommandForUndo): (FrameWin::clearUndoRedoOperations): (FrameWin::incomingReferrer): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::respondToChangedContents): (BrowserExtensionWin::BrowserExtensionWin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::setIconURL): (BrowserExtensionWin::getHistoryLength): (WebCore::CheckIfReloading): (WebCore::CheckCacheObjectStatus): (Widget::setIsSelected): (ScrollView::inWindow): (ScrollView::scrollPointRecursively): (GraphicsContext::setShadow): (GraphicsContext::clearShadow): (GraphicsContext::beginTransparencyLayer): (GraphicsContext::endTransparencyLayer): (GraphicsContext::clearRect): (GraphicsContext::strokeRect): (GraphicsContext::setLineWidth): (GraphicsContext::setLineCap): (GraphicsContext::setLineJoin): (GraphicsContext::setMiterLimit): (GraphicsContext::setAlpha): (GraphicsContext::clip): (GraphicsContext::rotate): (GraphicsContext::scale): (Path::Path): (Path::~Path): (Path::contains): (Path::translate): (Path::boundingRect): (Path::operator=): (Path::clear): (Path::moveTo): (Path::addLineTo): (Path::addQuadCurveTo): (Path::addBezierCurveTo): (Path::addArcTo): (Path::closeSubpath): (Path::addArc): (Path::addRect): (Path::addEllipse): (GraphicsContext::drawFocusRing): (GraphicsContext::drawLineForMisspelling): (GraphicsContext::setCompositeOperation): (TextField::TextField): (TextField::~TextField): (TextField::setFont): (TextField::setAlignment): (TextField::setWritingDirection): (TextField::maxLength): (TextField::setMaxLength): (TextField::text): (TextField::setText): (TextField::cursorPosition): (TextField::setCursorPosition): (TextField::setEdited): (TextField::setReadOnly): (TextField::setPlaceholderString): (TextField::setColors): (TextField::sizeForCharacterWidth): (TextField::baselinePosition): (TextField::setLiveSearch): (PopUpButton::PopUpButton): (PopUpButton::~PopUpButton): (PopUpButton::setFont): (PopUpButton::baselinePosition): (PopUpButton::setWritingDirection): (PopUpButton::clear): (PopUpButton::appendItem): (PopUpButton::setCurrentItem): (PopUpButton::sizeHint): (PopUpButton::frameGeometry): (PopUpButton::setFrameGeometry): (ListBox::ListBox): (ListBox::~ListBox): (ListBox::setSelectionMode): (ListBox::setFont): (ListBox::setWritingDirection): (ListBox::clear): (ListBox::doneAppendingItems): (ListBox::setEnabled): (ListBox::appendItem): (ListBox::setSelected): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (Frame::setNeedsReapplyStyles): (Image::drawTiled): (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel): (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setValue):
- 12:39 PM Changeset in webkit [16618] by
-
- 1 copy in S60/branches/s60-RnD-06wk39
New branch.
- 11:44 AM Changeset in webkit [16617] by
-
- 2 edits in S60/trunk/S60Tools
2006-09-28 brmorris <bradley.morrison@nokia.com>
Reviewed by Alan.
DESC: parse the description from the commit message
http://bugzilla.opendarwin.org/show_bug.cgi?id=11050
- svn2ccm.pl: Smarter task synopsis.
- 11:33 AM Changeset in webkit [16616] by
-
- 31 edits in trunk/WebCore
Reviewed by Tim H.
Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11057
Auto-generate more SVG Objective-C bindings
- Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength, DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString, DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired, DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement, DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, and DOMSVGTransformable.
- Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple parent interfaces and the SVG animated classes.
- Corrects CodeGenerator.pm to only skip the first parent for the main interface.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOMInternal.h:
- bindings/objc/DOMSVG.h:
- bindings/scripts/CodeGenerator.pm:
- bindings/scripts/CodeGeneratorObjC.pm:
- ksvg2/svg/SVGAnimatedAngle.idl:
- ksvg2/svg/SVGAnimatedBoolean.idl:
- ksvg2/svg/SVGAnimatedEnumeration.idl:
- ksvg2/svg/SVGAnimatedInteger.idl:
- ksvg2/svg/SVGAnimatedLength.idl:
- ksvg2/svg/SVGAnimatedLengthList.idl:
- ksvg2/svg/SVGAnimatedNumber.idl:
- ksvg2/svg/SVGAnimatedPathData.idl:
- ksvg2/svg/SVGAnimatedString.idl:
- ksvg2/svg/SVGAnimatedTransformList.idl:
- ksvg2/svg/SVGExternalResourcesRequired.idl:
- ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
- ksvg2/svg/SVGFitToViewBox.idl:
- ksvg2/svg/SVGLangSpace.idl:
- ksvg2/svg/SVGLocatable.idl:
- ksvg2/svg/SVGMetadataElement.idl:
- ksvg2/svg/SVGStringList.idl:
- ksvg2/svg/SVGStylable.idl:
- ksvg2/svg/SVGStyleElement.idl:
- ksvg2/svg/SVGTests.idl:
- ksvg2/svg/SVGTransformable.idl:
- ksvg2/svg/SVGURIReference.idl:
- ksvg2/svg/SVGUnitTypes.idl:
- ksvg2/svg/SVGZoomAndPan.idl:
- 11:24 AM Changeset in webkit [16615] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz Pettel!!!
Change the error code check for common functions from SQLResultOk to SQLResultDone
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::forgetPageURLQuery): (WebCore::IconDatabase::setIconIDForPageURLQuery): (WebCore::IconDatabase::addIconForIconURLQuery):
- 9:56 AM Changeset in webkit [22255] by
-
- 2 edits in branches/WindowsMerge/WebCore
Rubberstamped by sfalken.
Remove calls to DebugBreak() from plugin code.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue): (WebCore::PluginViewWin::setValue):
- 2:13 AM Changeset in webkit [16614] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff.
- change garbage collection to happen at increments proportional to number of live objects, not always every 1000 allocations
- kjs/collector.cpp: (KJS::Collector::allocate):
- 2:11 AM Changeset in webkit [16613] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Mitz.
- fixed REGRESSION (r16606): javascriptCore Crash on website load
Plus style fixes.
- fixed some possible off-by-one bugs
- use indexing, not iterators, for Vectors
- store Vector by pointer instead of by value to avoid blowing out FunctionImp size
- kjs/function.cpp: (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
- kjs/function.h:
- 1:53 AM Changeset in webkit [22254] by
-
- 4 edits in branches/WindowsMerge/WebCore
Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.
- 1:49 AM Changeset in webkit [16612] by
-
- 3 edits in trunk/WebCore
Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.
Sep 27, 2006:
- 11:46 PM Changeset in webkit [16611] by
-
- 4 edits in trunk/WebCore
Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas. Make sure
selectCursor checks for whether or not a scrollbar was hit. Also stub out a mouseMoved method for
scrollbars to provide hover feedback if needed.
Reviewed by Eric
- page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent):
- platform/ScrollBar.h: (WebCore::ScrollBar::mouseMoved):
- 11:32 PM Changeset in webkit [16610] by
-
- 2 edits1 delete in trunk/JavaScriptCore
2006-09-27 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej.
More build tweaks
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/dstroot-to-sdk.cmd: Removed.
- 11:29 PM Changeset in webkit [22253] by
-
- 6 edits2 deletes in branches/WindowsMerge
- 9:56 PM Changeset in webkit [16609] by
-
- 2 edits in trunk/WebCore
2006-09-27 MorganL <morganl.webkit@yahoo.com>
Reviewed by Maciej and Adam, landed by Adam
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=11072
Windows build is busted
- platform/win/TemporaryLinkStubs.cpp: (ScrollView::paint): (ScrollView::themeChanged):
- 9:35 PM Changeset in webkit [16608] by
-
- 2 edits in trunk/JavaScriptCore
- kjs/function.cpp: (KJS::FunctionImp::getParameterName): removed assertion that displeased gcc 4.0.1 (build 5420): ASSERT(static_cast<size_t>(index) == index);
- 7:00 PM Changeset in webkit [16607] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by GGaren.
Cleanup of previous fix which was to address Radar: 4752492
- kjs/function.cpp: (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
- kjs/function.h:
- 5:58 PM Changeset in webkit [16606] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Adele.
Fixes a GC stack overflow crash.
The change is to move from a linked list implementation of Parameters to a Vector.
The problem with the linked list is that each one creates it's own stack frame when being destroyed and in extreme cases this caused the stack to overflow.
- kjs/function.cpp: (KJS::Parameter::Parameter): (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
- kjs/function.h:
- 5:54 PM Changeset in webkit [16605] by
-
- 2 edits in trunk/JavaScriptCore
2006-09-27 Steve Falkenburg <sfalken@apple.com>
Fix last path fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 5:50 PM Changeset in webkit [22252] by
-
- 4 edits in branches/WindowsMerge/WebCore
2006-09-27 Steve Falkenburg <sfalken@apple.com>
B&I build fixes
- WebCore.vcproj/WebCore.make:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/build-generated-files.sh:
- 4:55 PM Changeset in webkit [22251] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by sfalken.
Don't die when plugins try to open a new window.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Remove call to DebugBreak()
- 4:48 PM Changeset in webkit [16604] by
-
- 7 edits4 adds in trunk
2006-09-27 Eric Seidel <eric@eseidel.com>
Reviewed by mitz.
paths with no fill specified default to black but do not recieve paint-related mouse events
http://bugzilla.opendarwin.org/show_bug.cgi?id=11069
The default fill was being applied at the wrong place in the rendering chain, causing this problem.
Test: svg/custom/hover-default-fill.svg
- kcanvas/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
- ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
- ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::isFilled): remove null check (WebCore::KSVGPainterFactory::fillPaintServer): remove null check (WebCore::KSVGPainterFactory::isStroked): remove null check (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
- ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill): added. (WebCore::SVGPaint::defaultStroke): added.
- ksvg2/svg/SVGPaint.h:
- 3:57 PM Changeset in webkit [22250] by
-
- 1 add in branches/WindowsMerge/JavaScriptCore/ChangeLog
Add missing change log
- 3:56 PM Changeset in webkit [22249] by
-
- 4 edits in branches/WindowsMerge
2006-09-27 Steve Falkenburg <sfalken@apple.com>
B&I build script tweaks.
- 3:54 PM Changeset in webkit [16603] by
-
- 3 edits in trunk/WebKit
Reviewed by thatcher
<rdar://problem/4044271>
Writing Direction menu doesn't reflect the current writing direction (9773)
- English.lproj/Localizable.strings: Added "Right to Left" and "Left to Right"
- WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): Validate menu items that perform toggleBaseWritingDirection and changeBaseWritingDirection. Disable the menu item that changes the writing direction to NSWritingDirectionNautral because NSWritingDirectionNatural's behavior can't be implemented with CSS. Take control of the title of the menu item that performs toggleBaseWritingDirection: instead of checking/unchecking it, otherwise we wouldn't know what a check means. (-[NSArray changeBaseWritingDirection:]): ASSERT that the requested writing direction is not NSWritingDirectionNatural, since we've disabled the menu item that performs it.
- 3:03 PM Changeset in webkit [22248] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-09-27 Steve Falkenburg <sfalken@apple.com>
Reviewed by Hyatt.
Turn on CG
- config.h:
- 3:02 PM Changeset in webkit [22247] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Lou.
Fix crash in plugins due to Flash on nytimes.com
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): memset m_stream to 0
- 3:00 PM Changeset in webkit [16602] by
-
- 2 edits in trunk/JavaScriptCore
2006-09-27 Steve Falkenburg <sfalken@apple.com>
Set path before build.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 2:53 PM Changeset in webkit [22246] by
-
- 3 adds in branches/WindowsMerge/JavaScriptCore
2006-09-27 Steve Falkenburg <sfalken@apple.com>
B&I build script.
- JavaScriptCore.vcproj/JavaScriptCore.make: Added.
- 1:29 PM Changeset in webkit [16601] by
-
- 8 edits8 adds in trunk
Reviewed by eseidel.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
SVG handles em units incorrectly
Calculate viewport coordinates at layout time, since
at this point the font size is known and lengths depending
on font sizes can be calculated correctly.
- 12:51 PM Changeset in webkit [16600] by
-
- 3 edits in trunk/JavaScriptCore
Debug configs should link to debug runtime.
- 12:29 PM Changeset in webkit [16599] by
-
- 8 edits in trunk
2006-09-27 Eric Seidel <eric@eseidel.com>
Reviewed by darin.
Change our invalid-fill error behavior to match Opera (and soon Firefox)
http://bugzilla.opendarwin.org/show_bug.cgi?id=11017
- ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::isFilled): (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::isStroked): (WebCore::KSVGPainterFactory::strokePaintServer):
- 12:07 PM Changeset in webkit [16598] by
-
- 2 edits in trunk/WebCore
Build fix
- loader/icon/IconDatabase.cpp: (WebCore::readySQLStatement):
- 11:59 AM Changeset in webkit [22245] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by sfalken.
Scroll plugins (at least in some cases).
- platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollBy): Pass SW_SCROLLCHILDREN to ScrollWindowEx()
- 11:47 AM Changeset in webkit [22244] by
-
- 6 edits in branches/WindowsMerge/WebKitWin
- 11:46 AM Changeset in webkit [16597] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Adam Roben.
Changed line ending from DOS to UNIX format so it doesn't die running
on my machine. ;)
- JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
- 11:20 AM Changeset in webkit [16596] by
-
- 6 edits in trunk
WebKit:
Reviewed by Maciej, landed by Brady
Update URL request associated with provisional data source on redirect.
Notify IWebFrameLoadDelegate of redirects for the provisional load.
Notify IWebFrameLoadDelegate of a provisional load being commited.
- COM/WebDataSource.cpp: (WebDataSource::replaceRequest):
- COM/WebDataSource.h:
- COM/WebFrame.cpp: (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData):
WebKitTools:
Reviewed by Maciej, landed by Brady
Fix URL bar updating.
- Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didStartProvisionalLoadForFrame): (SpinneretWebHost::didCommitLoadForFrame): (SpinneretWebHost::didFinishLoadForFrame):
- 11:03 AM Changeset in webkit [22243] by
-
- 5 edits in branches/WindowsMerge
2006-09-27 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Fix <rdar://problem/4753220>.
Hang using bugreporter in Boomer.
Force text into simple code path in all cases.
- WebFrame.cpp: (FormValuesPropertyBag::GetPropertyInfo):
- WebPreferences.cpp: (WebPreferences::initialize):
- 10:59 AM Changeset in webkit [16595] by
-
- 4 edits in trunk/WebCore
WebCore:
Reviewed by Adam
In very specific circumstances, prepared SQLStatements can become invalid without
any warning. This checks for that state and re-prepares the statement and also
adds more aggressive error-checking everywhere these statements are used.
- loader/icon/IconDatabase.cpp: (WebCore::readySQLStatement): Check if the statement is expired - reprepare it (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto (WebCore::IconDatabase::forgetPageURLQuery): Ditto (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto (WebCore::IconDatabase::addIconForIconURLQuery): Ditto (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
- loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
- loader/icon/SQLStatement.h:
- 8:58 AM Changeset in webkit [22242] by
-
- 2 edits2 adds in branches/WindowsMerge/WebCore
Add WebCoreSystemInterface.h/cpp to platform/win