⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 30, 2006:

5:41 PM Changeset in webkit [22278] by hyatt
  • 2 edits in branches/WindowsMerge/WebKitWin

Use BitBlt instead of SetDIBBitsToDevice

4:33 PM Changeset in webkit [16691] by weinig
  • 26 edits in trunk/WebCore

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
Add more SVG Objective-C DOM bindings

  • Auto-generate Objective-C DOM bindings for DOMSVGAElement, DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement, DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio, DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor, DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMSVG.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • ksvg2/svg/SVGAElement.idl:
  • ksvg2/svg/SVGAnimateColorElement.idl:
  • ksvg2/svg/SVGAnimateElement.idl:
  • ksvg2/svg/SVGAnimateTransformElement.idl:
  • ksvg2/svg/SVGAnimatedPathData.idl:
  • ksvg2/svg/SVGAnimatedPoints.idl:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
  • ksvg2/svg/SVGAnimationElement.idl:
  • ksvg2/svg/SVGCircleElement.idl:
  • ksvg2/svg/SVGClipPathElement.idl:
  • ksvg2/svg/SVGColor.idl:
  • ksvg2/svg/SVGCursorElement.idl:
  • ksvg2/svg/SVGDefsElement.idl:
  • ksvg2/svg/SVGDescElement.idl:
  • ksvg2/svg/SVGDocument.idl:
  • ksvg2/svg/SVGEllipseElement.idl:
  • ksvg2/svg/SVGPointList.idl:
  • ksvg2/svg/SVGPreserveAspectRatio.idl:
  • ksvg2/svg/SVGRect.idl:
  • ksvg2/svg/SVGSVGElement.idl:
4:18 PM Changeset in webkit [16690] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Adele.

  • fix build
  • platform/FloatRect.h: (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment but more appropriate for path-type stuff.
  • platform/cg/PathCG.cpp: (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
2:14 PM Changeset in webkit [16689] by ap
  • 29 edits
    5 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11011
External CSS is parsed as iso-8859-1 even though the main document is utf-8

Test: fast/encoding/css-charset-default.xhtml

  • loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setCSSStyleSheet): (WebCore::CachedResourceClient::setXSLStyleSheet): Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
  • css/CSSImportRule.h:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
  • css/CSSStyleSheet.h: Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit member. Changed some String parameters to const String&.
  • css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet):
  • css/StyleSheet.h: Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
  • css/StyleSheetList.cpp: (WebCore::StyleSheetList::length): (WebCore::StyleSheetList::item):
  • css/StyleSheetList.h: Special-casing implicit stylesheets seemed to be dead code, removed.
  • dom/Document.cpp: (WebCore::Document::setCSSStyleSheet): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h: Renamed setStyleSheet() to setCSSStyleSheet().
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet(). (WebCore::ProcessingInstruction::setCSSStyleSheet): (WebCore::ProcessingInstruction::setXSLStyleSheet): (WebCore::ProcessingInstruction::parseStyleSheet):
  • dom/ProcessingInstruction.h:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute is not specified. (WebCore::HTMLLinkElement::setCSSStyleSheet):
  • html/HTMLLinkElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged): Inherit URL and charset from the document.
  • loader/Cache.cpp: (WebCore::Cache::requestCSSStyleSheet):
  • loader/Cache.h: Adjust for setStyleSheet() renaming.
  • loader/CachedCSSStyleSheet.h: Removed an unused constructor.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref): (WebCore::CachedCSSStyleSheet::deref): (WebCore::CachedCSSStyleSheet::checkNotify): Pass the encoding to setCSSStyleSheet().
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::ref): (WebCore::CachedXSLStyleSheet::checkNotify):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet):
  • loader/DocLoader.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
  • xml/XSLImportRule.cpp: (WebCore::XSLImportRule::setXSLStyleSheet): (WebCore::XSLImportRule::loadSheet):
  • xml/XSLImportRule.h: Adjust for setStyleSheet() renaming.
10:08 AM Changeset in webkit [16688] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by eseidel.

http://bugs.webkit.org/show_bug.cgi?id=11096
Hit testing for polylines fails

Fix Path::contains so it handles filled, non-closed paths too.

3:11 AM Changeset in webkit [16687] by hyatt
  • 1 edit in trunk/WebCore/platform/win/PlatformScrollBar.h

Fix win32.

2:49 AM Changeset in webkit [16686] by hyatt
  • 1 edit in trunk/WebKit/WebView/WebPreferences.m

Revert minimum font size pref back to 1.

2:48 AM Changeset in webkit [16685] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage caused by a typo.

2:46 AM Changeset in webkit [16684] by hyatt
  • 3 edits in trunk/WebCore

Fix mac bustage in FrameMac.mm and FrameViewMac.mm

2:37 AM Changeset in webkit [22277] by hyatt
  • 2 edits in branches/WindowsMerge/WebKitWin

Revert minimum font size pref back to 1.

2:34 AM Changeset in webkit [22276] by hyatt
  • 8 edits
    1 add in branches/WindowsMerge/WebCore

Make mouse events work in iframes.

2:30 AM Changeset in webkit [16683] by hyatt
  • 12 edits in trunk/WebCore

Event refactoring.

Sep 29, 2006:

10:42 PM Changeset in webkit [16682] by adele
  • 3 edits in trunk/WebCore

Reviewed by Adele.

Fixes windows bustage:
http://bugs.webkit.org/show_bug.cgi?id=11093

  • platform/win/PlatformScrollBar.h:
  • platform/win/TemporaryLinkStubs.cpp: (PlatformScrollBar::PlatformScrollBar): (ScrollBar::ScrollBar):
9:41 PM Changeset in webkit [22275] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebPreferences.cpp

Change minimum font size value to 0 on win32 as well.

8:25 PM Changeset in webkit [16681] by thatcher
  • 2 edits in trunk/LayoutTests

Bug 11041: fast/dom/isindex-001 needs new results
http://bugs.webkit.org/show_bug.cgi?id=11041

  • fast/dom/isindex-001-expected.txt:
8:15 PM Changeset in webkit [22274] by sfalken
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

2006-09-29 Steve Falkenburg <sfalken@apple.com>

Fix the build.

  • platform/win/PlatformScrollBarWin.cpp:
7:08 PM Changeset in webkit [16680] by thatcher
  • 2 edits in tags/Safari-521.28

Versioning

6:57 PM Changeset in webkit [16679] by hyatt
  • 2 edits in trunk/WebKit

Change the default minimum font size pref to 0 in order to allow
font-size:0 to work.

  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
6:55 PM Changeset in webkit [16678] by hyatt
  • 15 edits in trunk/WebCore

Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
in RenderObject::NodeInfo (and then propagating that Widget to
MouseEventWithHitTestResults).

This allows RenderListBox and RenderBlock to do the same thing when the
mouse is over the scrollbar.

Also land fix to support font-size: 0.

Reviewed by mjs (scrollbar), eric (font-size)

  • dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
  • page/Frame.cpp: (WebCore::Frame::passWidgetMouseDownEventToWidget):
  • page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::dispatchMouseEvent):
  • page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
  • page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::scrollbar):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::getHiddenBehavior):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::isPointInScrollbar):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::NodeInfo::NodeInfo): (WebCore::RenderObject::NodeInfo::scrollbar): (WebCore::RenderObject::NodeInfo::setScrollbar):
6:50 PM Changeset in webkit [16677] by adele
  • 3 edits in trunk/WebCore

Reviewed by Adele.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::convertToContainingWindow): (WebCore::ScrollView::convertFromContainingWindow):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):
6:44 PM Changeset in webkit [16676] by adele
  • 2 edits in trunk/WebCore

Updated with new argument for PlatformScrollBar.

  • platform/win/TemporaryLinkStubs.cpp: (PlatformScrollBar::PlatformScrollBar):
6:03 PM Changeset in webkit [16675] by thatcher
  • 3 edits
    2 copies in tags/Safari-521.28

Merging a fix to the tag.

6:00 PM Changeset in webkit [16674] by thatcher
  • 16 edits in tags/Safari-521.28

Merging a fix to the tag.

5:44 PM Changeset in webkit [16673] by thatcher
  • 13 edits in tags

Merging fix to tag.

5:42 PM Changeset in webkit [16672] by thatcher
  • 3 edits
    2 copies in tags

LayoutTests:

Reviewed by John Sullivan.

<rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
<rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

  • fast/text/attributed-substring-from-range-001-expected.txt: Added.
  • fast/text/attributed-substring-from-range-001.html: Added.


Check attributed string results when starting or ending at a br element.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
<rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

Test added

  • fast/text/attributed-substring-from-range-001.html
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case. Also, add validation of the range.
5:39 PM Changeset in webkit [16671] by thatcher
  • 2 copies in tags/Safari-521.28

New tag.

5:34 PM Changeset in webkit [16670] by thatcher
  • 1 delete in tags/Safari-521.28

Bad tag.

5:29 PM Changeset in webkit [16669] by thatcher
  • 3 copies in tags/Safari-521.28

New tag.

5:11 PM Changeset in webkit [22273] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Geoff.


Allow WebKit to query for the rect
of the resizer rather than just its size.


Fix <rdar://4753220>
Correct more/fewer button toggling in bug report sheet.

2006-09-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Geoff.

Allow WebKit to query for the rect
of the resizer rather than just its size.

  • Interfaces/IWebUIDelegatePrivate.idl:
5:06 PM Changeset in webkit [16668] by thatcher
  • 1 edit in trunk/WebCore/html/HTMLSelectElement.cpp

Build fix.

4:59 PM Changeset in webkit [16667] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fixing build bustage with cast to int.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
4:45 PM Changeset in webkit [16666] by adele
  • 2 edits in trunk/WebCore

Fixing accidental include.

  • rendering/RenderListBox.cpp:
4:41 PM Changeset in webkit [16665] by adele
  • 2 edits in trunk/WebCore

Adding RenderListBox files.

4:40 PM Changeset in webkit [22272] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Adding RenderListBox files

4:15 PM Changeset in webkit [16664] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

Fixing typo. No problem in the ned. Just the end.

4:15 PM Changeset in webkit [22271] by adele
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Adding reviewer to ChangeLog

4:15 PM Changeset in webkit [22270] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

Updated constructor for PlatformScrollBar to include controlSize argument.

  • platform/win/PlatformScrollBar.h:
  • platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollBar::PlatformScrollBar):
4:14 PM Changeset in webkit [22269] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam, Geoff.


Fix <rdar://4757392>
Plug-ins flash to white while scrolling.


Set WS_CLIPCHILDREN on browser windows to clip out plug-in HWNDs
when drawing.

  • WebView.cpp: (WebView::initWithFrame):
4:13 PM Changeset in webkit [16663] by adele
  • 26 edits
    2 adds in trunk/WebCore

Reviewed by Adam.

Initial implementation of engine-based list box control.

  • WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
  • bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
  • bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown):
  • page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select. (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto. (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
  • page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::currentMousePosition): (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
  • page/FrameView.h:
  • platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument. The list box will use a smaller scroll bar size.
  • platform/ScrollBar.h: (WebCore::): (WebCore::ScrollBar::controlSize):
  • platform/mac/PlatformScrollBar.h:
  • platform/mac/PlatformScrollBarMac.mm: (NSControlSizeForScrollBarControlSize): (-[WebCoreScrollBar initWithPlatformScrollBar:]): (WebCore::PlatformScrollBar::PlatformScrollBar):
  • rendering/RenderBlock.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): (WebCore::RenderObject::autoscroll):
  • rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
  • css/html4.css: Added properties for new list boxes.
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled. (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
  • html/HTMLOptionElement.h: Added disabled method.
  • html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation. (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::lastSelectedListIndex): (WebCore::HTMLSelectElement::deselectItems): (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::recalcListItems): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys. (WebCore::HTMLSelectElement::nextSelectableListIndex): (WebCore::HTMLSelectElement::previousSelectableListIndex):
  • html/HTMLSelectElement.h:
  • rendering/RenderTheme.cpp: Added support for ListBoxAppearance (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::supportsFocusRing):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
  • rendering/RenderListBox.cpp: Added. (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::setStyle): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcMinMaxWidth): (WebCore::RenderListBox::size): (WebCore::RenderListBox::numItems): (WebCore::RenderListBox::calcHeight): (WebCore::RenderListBox::baselinePosition): (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::scrollBarTarget): (WebCore::RenderListBox::isPointInScrollbar): (WebCore::RenderListBox::optionAtPoint): (WebCore::RenderListBox::autoscroll): (WebCore::RenderListBox::scrollToRevealElementAtListIndex): (WebCore::RenderListBox::scroll): (WebCore::RenderListBox::valueChanged):
  • rendering/RenderListBox.h: Added. (WebCore::RenderListBox::isListBox): (WebCore::RenderListBox::selectionChanged): (WebCore::RenderListBox::setSelectionChanged): (WebCore::RenderListBox::canHaveChildren): (WebCore::RenderListBox::renderName): (WebCore::RenderListBox::setOptionsChanged): (WebCore::RenderListBox::shouldAutoscroll): (WebCore::RenderListBox::listIndexIsVisible):
4:10 PM Changeset in webkit [16662] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

We had a bug where html4.css was ignoring Media Queries. In the ned
the problem was that we were trying to send a char* to the
MediaQueryEvaluator constructor that expects a String, but the
char* got interpreted as a bool, the wrong constructor was called,
and the media type was never set.

No test case possible since this only affects html4.css

  • css/MediaQueryEvaluator.cpp: New constructor that expects takes a char* (WebCore::MediaQueryEvaluator):
  • css/MediaQueryEvaluator.h: Same.
3:57 PM Changeset in webkit [16661] by ggaren
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by John, Maciej.


Added test for whether a frame element reports its src attribute as a
complete, rather than relative, URL.

  • fast/frames/frame-src-attribute-expected.txt: Added.
  • fast/frames/frame-src-attribute.html: Added.
  • fast/frames/resources/frame-src-attribute-subframe.html: Added.

WebCore:

Reviewed by John, Maciej.


Integrated some frame and iframe code. I'm trying to fix up frame ownership
and loading. Reducing the number of different code paths involved
seemed like a good first step.


As a side effect, I fixed a bug where FRAME elements would report their
src attributes as relative, rather than compelete, URLs. (IFRAME elements
had the correct complete URL behavior.)

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo (WebCore::HTMLFrameElement::openURL):

(1) Removed checks that requestFrame does for us
(2) Added isURLAllowed check, to have one clear bottleneck for it
(3) Added viewsource check, to have one clear bottleneck for it

(WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
method, instead of finding our content frame in our own unique way.
(WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
since openURL does this for us now.
(WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
This is what FF does, and it made no sense to have different behaviors
for FRAME and IFRAME elements.

  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init code.
  • html/HTMLIFrameElement.h: Removed src() and openURL() methods, since HTMLFrameElement now does everything we need.
3:33 PM Changeset in webkit [16660] by rwlbuis
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

Fix Qt/Linux build.

3:28 PM Changeset in webkit [16659] by brmorris
  • 2 edits in S60/trunk/S60Tools

Reviewed by Brad.
DESC: Update bugzilla url

  • prepare-ChangeLog.bat:
3:24 PM Changeset in webkit [16658] by thatcher
  • 1 edit in trunk/LayoutTests/ChangeLog

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:24 PM Changeset in webkit [16657] by brmorris
  • 10 edits in S60/trunk

Update Bugzilla url to bugs.webkit.org in ChangeLogs

3:22 PM Changeset in webkit [16656] by thatcher
  • 1 edit in trunk/WebKitQt/ChangeLog

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:21 PM Changeset in webkit [16655] by thatcher
  • 1 edit in trunk/WebKitLibraries/ChangeLog

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:21 PM Changeset in webkit [16654] by thatcher
  • 1 edit in trunk/WebKitSite/ChangeLog

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:20 PM Changeset in webkit [16653] by thatcher
  • 1 edit in trunk/WebKitTools/ChangeLog

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:17 PM Changeset in webkit [16652] by thatcher
  • 1 edit in trunk/JavaScriptGlue/ChangeLog

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:16 PM Changeset in webkit [16651] by thatcher
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:14 PM Changeset in webkit [16650] by thatcher
  • 2 edits in trunk/WebKit

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:12 PM Changeset in webkit [16649] by thatcher
  • 3 edits in trunk/WebCore

Replace bugzilla.opendarwin.org with bugs.webkit.org.

3:08 PM Changeset in webkit [16648] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Replace bugzilla.opendarwin.org with bugs.webkit.org.

2:56 PM Changeset in webkit [16647] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2006-09-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Joseph Ligman.
DESC: Fix resolvecomplete issues with BufferTransaction
http://bugzilla.opendarwin.org/show_bug.cgi?id=10497

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BufferTransaction.h:
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::SendDataCB): (CBufferTransaction::ConstructL): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::HandleResolveComplete):
2:49 PM Changeset in webkit [16646] by spadma
  • 4 edits in S60/trunk/WebKit

2006-09-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Joseph Ligman.
DESC: Fix resolvecomplete issues with BufferTransaction
http://bugzilla.opendarwin.org/show_bug.cgi?id=10497

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BufferTransaction.h:
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::SendDataCB): (CBufferTransaction::ConstructL): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::HandleResolveComplete):
1:29 PM Changeset in webkit [16645] by weinig
  • 26 edits in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11082
Simplify Internal methods for the auto-generated Objective-C DOM code

  • Auto-generate the internal methods for more Objective-C classes.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm: (-[DOMStyleSheet WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (-[DOMCSSRule WebCore::]): (-[DOMCSSRule _initWithCSSRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue WebCore::]): (-[DOMCSSValue _initWithCSSValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]):
  • bindings/objc/DOMHTMLAppletElement.mm: (-[DOMHTMLAppletElement WebCore::]): (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
  • bindings/objc/DOMHTMLEmbedElement.mm: (-[DOMHTMLEmbedElement WebCore::]): (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSUnknownRule.idl:
  • css/CSSValueList.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NodeIterator.idl:
  • dom/OverflowEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
10:58 AM Changeset in webkit [16644] by spadma
  • 9 edits in S60/branches/3.1m

2006-09-29 bujtas <zbujtas@gmail.com>

Reviewed by Sachin Padma.
DESC: fix intrapage navigation vs. load issue
http://bugzilla.opendarwin.org/show_bug.cgi?id=10974

  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LoadUrlL):
  • ResourceLoader/inc/LoaderUtils.h:
  • ResourceLoader/src/LoaderUtils.cpp: (TLoaderUtils::IsIntraPageNavigation):

2006-09-29 sareen <shyam.sareen@nokia.com>

Reviewed by spadma <Sachin.Padma@nokia.com>.
DESC: Avoid passing NULL URL to webcore.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11056

  • ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::CreateHeaderResponseLC):

2006-09-29 zhalu <zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC:If the web page is loaded from cache, favicon is only loaded from cache,
not trying to load it from network even if cache does not have it.


http://bugzilla.opendarwin.org/show_bug.cgi?id=10355

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadFavicon):

2006-09-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Cancel the active object before deleting it.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11087

  • Src/StopScheduler.cpp: (CStopScheduler::~CStopScheduler):
10:40 AM Changeset in webkit [16643] by spadma
  • 2 edits in S60/trunk/MemoryManager

2006-09-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Cancel the active object before deleting it.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11087

  • Src/StopScheduler.cpp: (CStopScheduler::~CStopScheduler):
9:57 AM Changeset in webkit [16642] by harrison
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

<rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
<rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

  • fast/text/attributed-substring-from-range-001-expected.txt: Added.
  • fast/text/attributed-substring-from-range-001.html: Added.


Check attributed string results when starting or ending at a br element.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
<rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

Test added

  • fast/text/attributed-substring-from-range-001.html
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case. Also, add validation of the range.
9:10 AM Changeset in webkit [16641] by thatcher
  • 5 edits
    5 adds
    8 deletes in trunk/WebKit

Reviewed by Maciej.

Switch the inspector over to use border-image with styled buttons and selects.

9:08 AM Changeset in webkit [16640] by zbujtas
  • 5 edits in S60/trunk

2006-09-25 zhalu <zhaosong.lu@nokia.com>

Reviewed by Zalan Bujtas.
DESC: For QColor object, there is a 'valid' flag indicating if the color is valid. The information for the valid flag is lost during the convertion of KWQPalette to WebCorePalette because the WebCorePalette uses only RGB values of color. This causes problem such as described in the bug report. The changes add the valid flag to the WebCorePalette class.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10174


Merged from \s60\branches\3.1m r16635
WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCorePalette.h: (TWebCorePalette::TWebCorePalette): (TWebCorePalette::SetBackGroundValid): (TWebCorePalette::SetForeGroundValid): (TWebCorePalette::IsBackGroundValid): (TWebCorePalette::IsForeGroundValid):
  • kwq/KWQWidget.cpp: (QWidget::setPalette):
9:03 AM Changeset in webkit [16639] by spadma
  • 4 edits in S60/trunk/WebKit

2006-09-29 bujtas <zbujtas@gmail.com>

Reviewed by Sachin Padma.
DESC: fix intrapage navigation vs. load issue
http://bugzilla.opendarwin.org/show_bug.cgi?id=10974

  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LoadUrlL):
  • ResourceLoader/inc/LoaderUtils.h:
  • ResourceLoader/src/LoaderUtils.cpp: (TLoaderUtils::IsIntraPageNavigation):
8:59 AM Changeset in webkit [16638] by spadma
  • 4 edits in S60/trunk/WebKit

2006-09-29 sareen <shyam.sareen@nokia.com>

Reviewed by spadma <Sachin.Padma@nokia.com>.
DESC: Avoid passing NULL URL to webcore.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11056

  • ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::CreateHeaderResponseLC):

2006-09-29 zhalu <zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC:If the web page is loaded from cache, favicon is only loaded from cache,
not trying to load it from network even if cache does not have it.


http://bugzilla.opendarwin.org/show_bug.cgi?id=10355

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadFavicon):
8:27 AM Changeset in webkit [16637] by rwlbuis
  • 1 edit in trunk/LayoutTests/fast/dom/css-insert-import-rule-expected.txt

I commited old expected results, this one is correct.

8:23 AM Changeset in webkit [16636] by brmorris
  • 2 edits in S60/trunk/S60Tools

Reviewed by Alan.
DESC: Add mk to list of makefile extenstions.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10918

  • svn-create-patch.bat: *.mk permitted to have tabs
8:18 AM Changeset in webkit [16635] by zbujtas
  • 5 edits in S60/branches/3.1m

2006-09-25 zhalu <zhaosong.lu@nokia.com>

Reviewed by Zalan Bujtas.
DESC: For QColor object, there is a 'valid' flag indicating if the color is valid. The information for the valid flag is lost during the convertion of KWQPalette to WebCorePalette because the WebCorePalette uses only RGB values of color. This causes problem such as described in the bug report. The changes add the valid flag to the WebCorePalette class.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10174

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCorePalette.h: (TWebCorePalette::TWebCorePalette): (TWebCorePalette::SetBackGroundValid): (TWebCorePalette::SetForeGroundValid): (TWebCorePalette::IsBackGroundValid): (TWebCorePalette::IsForeGroundValid):
  • kwq/KWQWidget.cpp: (QWidget::setPalette):
2:52 AM Changeset in webkit [22268] by hyatt
  • 3 edits in branches/WindowsMerge/WebKitWin

Fix mouse event propagation from WebKit to WebCore on Win32.

2:39 AM Changeset in webkit [22267] by aroben
  • 6 edits
    1 add in branches/WindowsMerge/WebCore

Reviewed by hyatt.

Add error logging to plugin code.

  • WebCore.vcproj/WebCore.vcproj: Added PluginDebug.h
  • platform/win/NotImplemented.h: Add surrounding #ifndef/#endif
  • plugins/win/PluginDebug.h: Added.
  • plugins/win/PluginPackageWin.cpp: Add error logging (WebCore::PluginPackageWin::load):
  • plugins/win/PluginStreamWin.cpp: Ditto. (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedAllData):
  • plugins/win/PluginViewWin.cpp: Ditto. (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::newStream): (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::destroyStream):
1:40 AM Changeset in webkit [16634] by hyatt
  • 1 edit in trunk/WebCore/platform/PlatformMouseEvent.h

Add the ability to set the click count after the fact on a mouse event.

1:39 AM Changeset in webkit [22266] by hyatt
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

Fork mouse event.cpp

1:30 AM Changeset in webkit [16633] by rwlbuis
  • 3 edits
    3 adds in trunk

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements

Allow @import as part of a css rule.

Note: See TracTimeline for information about the timeline view.