Context Navigation

kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
platform/mac/ColorMac.mm: (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance

6:20 PM Changeset in webkit [16704] by bdash

5 edits in trunk/WebKitTools

2006-10-01 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Maciej.

Add QT build slave to Buildbot.

BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Add QT build slave, fix existing errors.
BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Add QT build factory.
BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Disable forcing of builds via web interface to prevent spamming. Use the IRC bot in #webkit-build instead.
BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Add CMake build step.

6:02 PM Changeset in webkit [16703] by ggaren

7 edits
2 adds in trunk

LayoutTests:

Added test for the viewource attribute, which applies to <frame> and
<iframe> elements.

fast/frames/viewsource-attribute-expected.txt: Added.
fast/frames/viewsource-attribute.html: Added.

fast/frames/frameElement-widthheight.html: Removed stray character.

WebCore:

Reviewed by Maciej.

More frame/iframe merging.

Removed needWidgetUpdate and related code. needWidgetUpdate is always false, so this was dead code.
Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather than attach(), is the correct place for setInViewSourceMode, because openURL() is the function that creates our frame.
Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME code that did the same thing in other places.
Made FRAME's attach() method suffuciently generic so that IFRAME could call up to it, rather than skipping its superclass and calling up directly to ELEMENT.
Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
Replaced ad hoc frame loading code in FRAME::attach() with call to openURL(), the designated frame loading function.

Layout tests pass. I added a layout test for viewsource mode, since I
broke it in the course of writing this patch.

5:04 PM Changeset in webkit [16702] by eseidel

1 edit
1 add in trunk

2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel.

CMakeLists.txt: add option to disable colored output when building on the buildbot

1:45 PM Changeset in webkit [16701] by andersca

11 edits in trunk/WebCore

2006-10-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

dom/Document.cpp: (WebCore::Document::recalcStyleSelector):
dom/Document.h: Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.

dom/Node.h: Remove DeprecatedStringList class forward declaration.

editing/markup.cpp: Include DeprecatedStringList.h here since it's not included by Document.h anymore.

kcanvas/KCanvasTreeDebug.cpp:
kcanvas/KCanvasTreeDebug.h: Remove unused functions.

loader/loader.cpp:
page/Frame.cpp:
page/Frame.h:
page/FrameView.h: Fixup DeprecatedStringList.h includes.

9:06 AM Changeset in webkit [16700] by harrison

3 edits
4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

<rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point

fast/text/international/wrap-CJK-001-expected.checksum: Added.
fast/text/international/wrap-CJK-001-expected.png: Added.
fast/text/international/wrap-CJK-001-expected.txt: Added.
fast/text/international/wrap-CJK-001.html: Added.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point

Problem was that the decision to trim was based only on whether the character
is a soft hyphen, which caused pretty much any Japanese character to go.
Changed to decide based on whether the character is ignorable whitespace.

Test:

fast/text/international/wrap-CJK-001.html

rendering/bidi.cpp: (WebCore::isTrimmableChar): New. Checks whether character is whitespace that can be ignored according to the text node's style. trimmed from the end of wrapped line. (WebCore::checkMidpoints): Call isTrimmable() rather than checking for char != SOFT_HYPHEN.

8:40 AM Changeset in webkit [16699] by andersca

14 edits in trunk/WebCore

2006-10-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Mitz Pettel.

Convert the SVG code to use Vector<String> instead of DeprecatedStringList.

ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
ksvg2/svg/SVGLengthList.cpp:
ksvg2/svg/SVGNumberList.cpp: (SVGNumberList::parse):
ksvg2/svg/SVGNumberList.h:
ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
ksvg2/svg/SVGStringList.cpp: (WebCore::SVGStringList::reset):
ksvg2/svg/SVGStringList.h:
ksvg2/svg/SVGTransformable.cpp: (SVGTransformable::parseTransformAttribute):

3:51 AM Changeset in webkit [22281] by hyatt

2 edits in branches/WindowsMerge/WebCore

Finish the win32 scrollbar.

3:05 AM Changeset in webkit [16698] by ap

5 edits in trunk/WebCore

2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Eric, tweaked and landed by ap.

Fix Qt/Linux build.

CMakeLists.txt:
platform/qt/PlatformScrollBar.h:
platform/qt/TemporaryLinkStubs.cpp: (WebCore::ScrollBar::ScrollBar): (WebCore::PlatformScrollBar::PlatformScrollBar): (FrameView::passMousePressEventToSubframe): (FrameView::passMouseMoveEventToSubframe): (FrameView::passMouseReleaseEventToSubframe): (FrameView::passWheelEventToSubframe): (FrameView::passMousePressEventToScrollbar):
ksvg2/svg/SVGDocument.h:

2:11 AM Changeset in webkit [16697] by ap

3 edits in trunk

2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading

No test case added (probably requires new DumpRenderTree functionality)

rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): Added early return if the document is being destroyed.

2:06 AM Changeset in webkit [16696] by ap

3 edits
4 adds in trunk

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
REGRESSION (r15418): contenteditable div truncates rightmost Japanese character

Make sure we only break after a space (and not any other valid line-break) if
the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
twice in quick succession.

Test: fast/text/line-breaks-after-white-space.html

rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

1:42 AM Changeset in webkit [22280] by hyatt

4 edits in branches/WindowsMerge/WebCore

Make scrollbar thumb dragging work.

1:37 AM Changeset in webkit [16695] by ap

2 edits in trunk

Fixed Bugzilla references in ChangeLogs for my previous commit.

1:35 AM Changeset in webkit [16694] by ap

3 edits
2 adds in trunk

Reviewed by Maciej and Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=4372
JavaScript document.write page form does not submit in Safari

Test: fast/forms/document-write.html

page/Frame.cpp: (WebCore::Frame::submitForm): Don't check for parsing().

1:13 AM Changeset in webkit [16693] by ap

2 edits in trunk/WebCore

Build fix.

bridge/mac/FrameViewMac.mm: Add missing #imports.

12:32 AM Changeset in webkit [22279] by hyatt

4 edits in branches/WindowsMerge/WebCore

Hook up the pressed state of scrollbars.

12:26 AM Changeset in webkit [16692] by hyatt

6 edits in trunk/WebCore

Refactor the code that sends the mouse down to scrollbars.

Sep 30, 2006:

5:41 PM Changeset in webkit [22278] by hyatt

2 edits in branches/WindowsMerge/WebKitWin

Use BitBlt instead of SetDIBBitsToDevice

4:33 PM Changeset in webkit [16691] by weinig

26 edits in trunk/WebCore

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
Add more SVG Objective-C DOM bindings

Auto-generate Objective-C DOM bindings for DOMSVGAElement, DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement, DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio, DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor, DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument, DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMInternal.h:
bindings/objc/DOMSVG.h:
bindings/scripts/CodeGeneratorObjC.pm:
ksvg2/svg/SVGAElement.idl:
ksvg2/svg/SVGAnimateColorElement.idl:
ksvg2/svg/SVGAnimateElement.idl:
ksvg2/svg/SVGAnimateTransformElement.idl:
ksvg2/svg/SVGAnimatedPathData.idl:
ksvg2/svg/SVGAnimatedPoints.idl:
ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
ksvg2/svg/SVGAnimationElement.idl:
ksvg2/svg/SVGCircleElement.idl:
ksvg2/svg/SVGClipPathElement.idl:
ksvg2/svg/SVGColor.idl:
ksvg2/svg/SVGCursorElement.idl:
ksvg2/svg/SVGDefsElement.idl:
ksvg2/svg/SVGDescElement.idl:
ksvg2/svg/SVGDocument.idl:
ksvg2/svg/SVGEllipseElement.idl:
ksvg2/svg/SVGPointList.idl:
ksvg2/svg/SVGPreserveAspectRatio.idl:
ksvg2/svg/SVGRect.idl:
ksvg2/svg/SVGSVGElement.idl:

4:18 PM Changeset in webkit [16690] by mjs

3 edits in trunk/WebCore

Reviewed by Adele.

fix build

platform/FloatRect.h: (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment but more appropriate for path-type stuff.
platform/cg/PathCG.cpp: (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.

2:14 PM Changeset in webkit [16689] by ap

29 edits
5 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11011
External CSS is parsed as iso-8859-1 even though the main document is utf-8

Test: fast/encoding/css-charset-default.xhtml

loader/CachedResourceClient.h: (WebCore::CachedResourceClient::setCSSStyleSheet): (WebCore::CachedResourceClient::setXSLStyleSheet): Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former takes an additional charset parameter, to be passed to CSSStyleSheet constructor.

css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet): (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
css/CSSImportRule.h:

css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
css/CSSStyleSheet.h: Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit member. Changed some String parameters to const String&.

css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet):
css/StyleSheet.h: Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.

css/StyleSheetList.cpp: (WebCore::StyleSheetList::length): (WebCore::StyleSheetList::item):
css/StyleSheetList.h: Special-casing implicit stylesheets seemed to be dead code, removed.

dom/Document.cpp: (WebCore::Document::setCSSStyleSheet): (WebCore::Document::recalcStyleSelector):
dom/Document.h: Renamed setStyleSheet() to setCSSStyleSheet().

dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet(). (WebCore::ProcessingInstruction::setCSSStyleSheet): (WebCore::ProcessingInstruction::setXSLStyleSheet): (WebCore::ProcessingInstruction::parseStyleSheet):
dom/ProcessingInstruction.h:

html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute is not specified. (WebCore::HTMLLinkElement::setCSSStyleSheet):
html/HTMLLinkElement.h:

html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged): Inherit URL and charset from the document.

loader/Cache.cpp: (WebCore::Cache::requestCSSStyleSheet):
loader/Cache.h: Adjust for setStyleSheet() renaming.

loader/CachedCSSStyleSheet.h: Removed an unused constructor.
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref): (WebCore::CachedCSSStyleSheet::deref): (WebCore::CachedCSSStyleSheet::checkNotify): Pass the encoding to setCSSStyleSheet().

loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::ref): (WebCore::CachedXSLStyleSheet::checkNotify):
loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet):
loader/DocLoader.h:
page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
xml/XSLImportRule.cpp: (WebCore::XSLImportRule::setXSLStyleSheet): (WebCore::XSLImportRule::loadSheet):
xml/XSLImportRule.h: Adjust for setStyleSheet() renaming.

10:08 AM Changeset in webkit [16688] by rwlbuis