⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 3, 2006:

9:50 PM Changeset in webkit [22293] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/WidgetWin.cpp

Move function into WidgetWin.cpp, since I made it windows only but had left it in Widget.cpp (breaking mac)

9:45 PM Changeset in webkit [16766] by hyatt
  • 1 edit in trunk/WebCore/platform/Widget.cpp

Fix mac build bustage.

9:34 PM Changeset in webkit [16765] by ap
  • 5 edits in trunk

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=11130
Convert "undefined" to AE missing value

WebCore:

  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): return missing value for UndefinedType.

LayoutTests:

  • fast/AppleScript/001-expected.txt:
  • fast/AppleScript/array-expected.txt: Updated the results.
9:26 PM Changeset in webkit [22292] by hyatt
  • 7 edits in branches/WindowsMerge/WebCore

Land the new scrollview.

9:26 PM Changeset in webkit [22291] by hyatt
  • 4 edits in branches/WindowsMerge/WebKitWin

Improve painting to not always use the unioned invalidation rect.

9:22 PM Changeset in webkit [16764] by hyatt
  • 18 edits in trunk/WebCore

Scrolling work.

8:36 PM Changeset in webkit [16763] by bdash
  • 2 edits in trunk/WebKit

2006-10-04 Mark Rowe <​bdash@webkit.org>

Reviewed by NOBODY (build fix).

  • WebView/WebView.m: (-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.
7:51 PM Changeset in webkit [16762] by bdash
  • 2 edits in trunk

Update bug URLs in the two patches that I just landed.

7:46 PM Changeset in webkit [16761] by bdash
  • 6 edits in trunk

2006-09-26 David Smith <​catfish.man@gmail.com>

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:

No automated tests are possible as this code path isn't reachable from JavaScript.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):

2006-09-26 David Smith <​catfish.man@gmail.com>

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:

  • WebView/WebView.m: (-[WebView scrollDOMRangeToVisible:]):
  • WebView/WebViewPrivate.h:
7:31 PM Changeset in webkit [16760] by bdash
  • 13 edits in trunk

2006-10-03 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Timothy.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand


Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:

  • AlwaysLive: Safari 2.0 behaviour
  • OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
  • LiveWhenNotFocused: Editable links are live only when their editable block is not

focused, or when the shift key is pressed

  • DefaultBehavior: This is the same as OnlyLiveWithShiftKey.


No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.

  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]): (-[WebCoreSettings editableLinkBehavior]):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive):
  • html/HTMLAnchorElement.h:
  • manual-tests/contenteditable-link.html:
  • page/FrameView.cpp: (WebCore::nodeIsNotBeingEdited): (WebCore::selectCursor):
  • page/Settings.h: (WebCore::Settings::): (WebCore::Settings::Settings): (WebCore::Settings::editableLinkBehavior): (WebCore::Settings::setEditableLinkBehavior):

2006-10-03 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Timothy.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand


Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:

  • AlwaysLive: Safari 2.0 behaviour
  • OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
  • LiveWhenNotFocused: Editable links are live only when their editable block is not

focused, or when the shift key is pressed

  • DefaultBehavior: This is the same as OnlyLiveWithShiftKey.


No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences editableLinkBehavior]): (-[WebPreferences setEditableLinkBehavior:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):
6:28 PM Changeset in webkit [22290] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Improvements to error handling in PluginStreamWin.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::deliverData): Fail quietly if called after termination (due to bad error handling in ResourceLoaderWin), ASSERT if called before stream has been started. (WebCore::PluginStreamWin::receivedData): Ditto. (WebCore::PluginStreamWin::receivedAllData): Ditto.
6:12 PM Changeset in webkit [16759] by bdakin
  • 3 edits in trunk/WebCore

Reviewed Darin.

No test cases needed.

Implemented a version of StringImpl::append that takes a UChar* and
a length.

  • platform/StringImpl.cpp: (WebCore::StringImpl::append): (WebCore::StringImpl::insert): Call new append instead of making a new StringImpl.
  • platform/StringImpl.h:
6:10 PM Changeset in webkit [16758] by andersca
  • 2 edits in trunk/WebKitTools

2006-10-03 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam and Brady.

  • DumpRenderTree/DumpRenderTree.m: (main): Update URL to Ahem.ttf
6:09 PM Changeset in webkit [16757] by bdash
  • 2 edits in trunk/WebCore

2006-10-03 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11099
HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onHandleCreated):
5:42 PM Changeset in webkit [22289] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fixes <rdar://problem/4760963>
Failed ASSERT in PluginStreamWin::~PluginStreamWin at espn.com

We now store the state of a stream as a tri-state enum in
m_streamState. This allows us to differentiate between before and after the
stream has been started.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): Initialize members of m_stream struct individually. (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): Return early if the stream isn't started. (WebCore::PluginStreamWin::receivedData): Ditto. (WebCore::PluginStreamWin::receivedAllData): Ditto.
  • plugins/win/PluginStreamWin.h: (WebCore::): Add PluginStreamState enum.
4:50 PM Changeset in webkit [16756] by thatcher
  • 5 edits in tags/WebCore-521.28.1/WebCore

Merging a fix for bug 4671286 (r16737).

4:48 PM Changeset in webkit [16755] by thatcher
  • 2 edits in tags/WebCore-521.28.1/WebCore

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
REGRESSION (r15418): contenteditable div truncates rightmost Japanese character


Make sure we only break after a space (and not any other valid line-break) if
the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
twice in quick succession.

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
4:46 PM Changeset in webkit [16754] by thatcher
  • 3 edits in tags/WebCore-521.28.1/WebCore

Merging a fix for 4717965 and 4712111 (r16567).

4:28 PM Changeset in webkit [16753] by thatcher
  • 1 edit in tags/WebCore-521.28.1/WebCore/Info.plist

Versioning

4:28 PM Changeset in webkit [16752] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/execCommand/paste-1-expected.checksum: Added.
  • editing/execCommand/paste-1-expected.png: Added.
  • editing/execCommand/paste-1-expected.txt: Added.
  • editing/execCommand/paste-1.html: Added.
  • editing/execCommand/paste-2-expected.checksum: Added.
  • editing/execCommand/paste-2-expected.png: Added.
  • editing/execCommand/paste-2-expected.txt: Added.
  • editing/execCommand/paste-2.html: Added.

WebKit:

Reviewed by harrison


execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView. (-[WebFrameBridge issueCopyCommand]): Ditto. (-[WebFrameBridge issuePasteCommand]): Ditto. (-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto. (-[WebFrameBridge issueTransposeCommand]): Fixed formatting. (-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
  • WebView/WebHTMLView.m: (-[WebHTMLView copy:]): Moved to WebInternal (-[WebHTMLView cut:]): Ditto. (-[WebHTMLView paste:]): Ditto. (-[WebHTMLView pasteAsPlainText:]): Ditto.
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.m: Removed the now unused _canPaste.
  • WebView/WebViewInternal.h: Ditto.
4:25 PM Changeset in webkit [16751] by thatcher
  • 1 copy in tags/WebCore-521.28.1/WebCore

New tag part 2.

4:24 PM Changeset in webkit [16750] by thatcher
  • 1 add in tags/WebCore-521.28.1

New tag.

4:24 PM Changeset in webkit [16749] by thatcher
  • 1 delete in WebCore-521.28.1

Bad tag.

4:23 PM Changeset in webkit [16748] by thatcher
  • 1 add in WebCore-521.28.1

New tag.

4:19 PM Changeset in webkit [16747] by bdakin
  • 9 edits in trunk/LayoutTests

Reviewed by Geoff.

Changing these two counters tests so they pass on the BuildBot.

  • fast/css/counters/counter04-expected.checksum:
  • fast/css/counters/counter04-expected.png:
  • fast/css/counters/counter04-expected.txt:
  • fast/css/counters/counter04.html:
  • fast/css/counters/counters04-expected.checksum:
  • fast/css/counters/counters04-expected.png:
  • fast/css/counters/counters04-expected.txt:
  • fast/css/counters/counters04.html:
4:00 PM Changeset in webkit [16746] by justing
  • 4 edits in trunk/LayoutTests

Reviewed by geoff


Fixed a typo, updating expected results.

  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
4:00 PM Changeset in webkit [16745] by ggaren
  • 6 edits in trunk/WebCore

Feared, loathed, reviewed by Darin.

More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
into FRAME, plus other cleanup.


No new behavior, so no new test. Layout tests pass. Basic browsing and
Mail editing seem to work.


  • dom/Node.cpp: (WebCore::Node::detach): Removed random commented-out code.
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::isURLAllowed): (1) Removed reference to FrameView, to dissociate frame loading from rendering. (2) Renamed newURL to completeURL because the difference between newURL and URLString is that newURL is a KURL that is the complete version of URLString, not that it is new. (WebCore::HTMLFrameElement::willRemove): (1) Removed close() call and moved close() code into willRemove(), also removing close() call from detach(), since willRemove is the well-defined place from DOM tear-down, not detach(). (2) Removed manual renderer detach code because the DOM is not responsible for managing the render tree. I confirmed that this change not regress <rdar://problem/4132581>. (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements lost their content frames after being removed from the DOM. That's our current behavior, but it's going to change in future rounds of refactoring. This also fixes <rdar://problem/4750835>. (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to attach/detach, because the render tree should not be in charge of deciding when to load.
  • html/HTMLFrameElement.h:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject, because the renderer is a renderPartObject, not a renderPart.
  • html/HTMLIFrameElement.h:
3:46 PM Changeset in webkit [16744] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/commit-log-editor: Added missing "close" call. Oops!
3:14 PM Changeset in webkit [16743] by bdash
  • 2 edits in trunk/WebCore

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11137
Bug 11137: GdkLauncher dies with "pure virtual method called" if
window is closed while page still loading

  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual methods to be called before the FrameGdk portion of "this" is torn down.
2:53 PM Changeset in webkit [16742] by justing
  • 2 edits in trunk/WebKit

Reviewed by geoff


<rdar://problem/4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load

  • Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Enable multipart/x-mixed-replace support on the request. This line was accidently removed during some loader refactoring.
2:10 PM Changeset in webkit [22288] by aroben
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Fixes <rdar://problem/4603342>
Keyboard navigability

Implement tabbing between form elements (in the single-frame case).

  • bridge/win/FrameWin.cpp: Add methods to determine tabbing preferences. (WebCore::FrameWin::tabsToLinks): (WebCore::FrameWin::tabsToAllControls):
  • bridge/win/FrameWin.h: Add tabsToLinks() to FrameWinClient
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollPointRecursively): Implemented for single-frame case.
  • platform/win/TemporaryLinkStubs.cpp: Remove stub for now-implemented ScrollView::scrollPointsRecursively

WebKitWin:

Reviewed by Darin.

Part of fix for <rdar://problem/4603342>
Keyboard navigability

Implement methods to determine tabbing preferences.

  • WebFrame.cpp: (WebFrame::tabsToLinks):
  • WebFrame.h:
2:09 PM Changeset in webkit [16741] by aroben
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Handle tab key presses in the DOM.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
  • page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Rename and reimplement focusNextPrevNode. Now we just call Element::focus().
  • page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make it public.
12:01 PM Changeset in webkit [16740] by justing
  • 2 edits in trunk/WebCore

Reviewed by mjs


<rdar://problem/4760612>
TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints


No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.


  • dom/Range.cpp: (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming positions are non-null since most of it's callers would be in a bad state if the positions were null. boundaryPointsValid, which calls compareBoundaryPoints, is an exception. Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it from entering compareBoundaryPoints and hitting the assert.
11:55 AM Changeset in webkit [16739] by adele
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler):
11:18 AM Changeset in webkit [16738] by darin
  • 2 edits in trunk/WebCore

2006-10-04 Darin Adler <Darin Adler>

Reviewed by Geoff.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Remove unnecessary call to clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this. (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout to false so we can get the old caret repaint rect. Later we need to change the design so getting the rect doesn't have a side effect of causing a layout without invalidation.
11:16 AM Changeset in webkit [22287] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-04 Darin Adler <Darin Adler>

Reviewed by Adam.

  • WebView.cpp: (WebView::handleMouseEvent): Pass message when creating a PlatformMouseEvent.
7:44 AM Changeset in webkit [16737] by harrison
  • 10 edits in trunk

LayoutTests:

Reviewed by Maciej.


<rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

Updated test so that it actually shows the caret rect for the caret position.
Before, it was showing the caret rect for the 9th character of the test description.


  • fast/text/justified-text-rect-expected.checksum:
  • fast/text/justified-text-rect-expected.png:
  • fast/text/justified-text-rect-expected.txt:
  • fast/text/justified-text-rect.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

Updated test:

  • fast/text/justified-text-rect.html
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): Make the selection's root editable element (or the document itself) be the basis for NSRange conversions. This supports "shadow DOM" like that for text fields and text areas.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Pass the document element as the scope.


  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Make the first parameter the scope.


  • editing/TextIterator.h: Make the first parameter of rangeFromLocationAndLength() the scope.
5:14 AM Changeset in webkit [16736] by eseidel
  • 4 edits in trunk/WebKitTools

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Offer a way for BuildBot to not colorize the cmake output, when building
with the 'build-webkit' script. Add "--color" / "--no-color" option pair.

Default is colorize output, though only Qt platform handles this for now.

  • Scripts/build-dumprendertree:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
3:49 AM Changeset in webkit [16735] by eseidel
  • 5 edits in trunk/WebKitTools

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Make all important scripts work with Qt/Linux.

You can safely use this now:
set-configuration-release --debug && build-webkit && run-javascriptcore-tests && run-webkit-tests

  • Scripts/build-dumprendertree:
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
2:46 AM Changeset in webkit [16734] by bdash
  • 4 edits in trunk

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric.

build-webkit tweak: Use WebKitBuild/$config as output dir (Release/Debug).

  • Scripts/webkitdirs.pm:

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric.

Fix Qt/Linux build.

  • CMakeLists.txt: Add counter related files.
2:42 AM Changeset in webkit [16733] by bdash
  • 9 edits
    1 add in trunk

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

Stop Bakefile-generated Makefile from running `pkg-config' multiple times per file.

  • presets.bkl: Make use of "options" and Python commands to run pkg-config etc up front.

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=10981
Linux/GDK build fixes

Based on a patch by Krzysztof Kowalczyk.

  • WebCoreSources.bkl:
  • platform/gdk/FrameGdk.cpp: (WebCore::doScroll): (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
  • platform/gdk/ScrollViewGdk.cpp:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (FrameView::passMousePressEventToSubframe): (FrameView::passMouseReleaseEventToSubframe): (FrameView::passMouseMoveEventToSubframe): (FrameView::passWheelEventToSubframe): (Cursor::Cursor): (Widget::invalidate): (Widget::invalidateRect): (ScrollView::wheelEvent): (ScrollView::convertToContainingWindow): (ScrollView::convertFromContainingWindow): (GraphicsContext::clip): (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::updateThumbPosition): (PlatformScrollBar::updateThumbProportion): (ScrollBar::ScrollBar): (ScrollBar::setProportion): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
  • platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):

Oct 2, 2006:

9:38 PM Changeset in webkit [16732] by aroben
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

(Forgot this in previous checkin)

Add message paramter to WebView::mouse* methods to pass down to
PlatformMouseEvent.

  • COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick): (WebViewWndProc):
  • COM/WebView.h:
9:35 PM Changeset in webkit [22286] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin
  • WebKit.vcproj/WebKit.vcproj:
9:29 PM Changeset in webkit [22285] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fixes <rdar://problem/4743497>
Can't check checkboxes

Let Windows determine which mouse button is pressed.

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message parameter to determine which mouse button is pressed.
9:26 PM Changeset in webkit [16731] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Let Windows determine which mouse button is pressed.

  • platform/PlatformMouseEvent.h: Add message parameter to constructor.
  • platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message parameter to determine which mouse button is pressed.
7:00 PM Changeset in webkit [16730] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Alice.


  • take away direct knowledge of WebFrame from WebDataSource
  • Loader/WebDocumentLoadState.h:
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setFrameLoader:]): (-[WebDocumentLoadState detachFromFrameLoader]):
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _setDocumentLoadState:]): (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
  • WebView/WebDataSource.m:
  • WebView/WebDataSourceInternal.h:
  • WebView/WebDocumentLoadStateMac.m: (-[WebDocumentLoadStateMac detachFromFrameLoader]):
  • WebView/WebFrame.m: (-[WebFrame _loadDataSource:withLoadType:formState:]):
6:38 PM Changeset in webkit [16729] by justing
  • 3 edits in trunk/WebCore

Reviewed by anders


Build fix


  • editing/SelectionController.cpp: (WebCore::SelectionController::empty):
  • editing/SelectionController.h:
6:08 PM Changeset in webkit [16728] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

  • editing/execCommand/create-list-with-hr-expected.checksum: Added.
  • editing/execCommand/create-list-with-hr-expected.png: Added.
  • editing/execCommand/create-list-with-hr-expected.txt: Added.
  • editing/execCommand/create-list-with-hr.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4755287>
Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element

  • editing/markup.cpp: (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced elements). Don't skip blocks that aren't containers (like horizontal rules).
6:06 PM Changeset in webkit [16727] by darin
  • 5 edits in trunk/WebCore

2006-10-03 Darin Adler <Darin Adler>

Reviewed by Justin Garcia.

  • correct mistaken code that would restart blinking every time "invalidateSelection" is called even if the caret has not moved
  • editing/SelectionController.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Update for name change. (WebCore::SelectionController::recomputeCaretRect): New function. Computes caret rect and does any necessary invalidation if the rect changes. (WebCore::SelectionController::invalidateCaretRect): Renamed from needsCaretRepaint. Invalidates the caret rect unconditionally. Also calls recomputeCaretRect as a side effect.
  • page/Frame.cpp: (WebCore::Frame::invalidateSelection): Remove unneeded call to clearCaretRectIfNeeded. (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change. (WebCore::Frame::selectionLayoutChanged): Restructured to use the new recomputeCaretRect function and not restart blinking if caret has not changed position. (WebCore::Frame::caretBlinkTimerFired): Removed some checks that are not needed since selectionLayoutChanged already checks these.
  • page/FramePrivate.h: Removed unused m_blinkCaret.
6:05 PM Changeset in webkit [16726] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Build fix. Add counters to vcproj.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
5:51 PM Changeset in webkit [22284] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage on win32 caused by counters checkin.

5:38 PM Changeset in webkit [22283] by sfalken
  • 5 edits in branches/WindowsMerge

2006-10-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff, Hyatt.


<rdar://4757389> Browser locks up while navigating to a new page
<rdar://4757407> Images fail to load at ​https://webmail.apple.com

  • WebFrame.cpp: Preserve old document until new doc has started loading. (WebFrame::loadDataSource): Don't destroy old document when a new load kicks off. (WebFrame::receivedResponse): Destroy old document when first data is received for new doc.
  • WebView.cpp: Fix painting suppression code. (WebViewWndProc): Suppress painting, mouse events until first layout instead of while loading.

2006-10-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Hyatt.

<rdar://4757387> (partial fix) Unable to sign on to my.yahoo.com
<rdar://4757405> (partial fix) Unable to log onto secure site (www.schwab.com)
<rdar://4757411> (partial fix) Unable to log onto any AppleConnect site (but using back and resubmiting works)

WinInet fixes.
Don't post data using HTTP when HTTPS should be used.
Fix redirect from POST to GET case.


There is a remaining bug with the way that we queue WinInet callbacks
still to be addressed.

  • platform/win/ResourceLoaderWin.cpp: (WebCore::addToOutstandingJobs): Skip dwContext of 0 (rollover case). (WebCore::ResourceLoaderWndProc): Call default wndproc properly.

Pass INTERNET_FLAG_SECURE when necessary for HTTPS.
Fix redirect code.
Initialize buffers struct.
Pass proper context in InternetReadFileExA

(WebCore::initializeOffScreenResourceLoaderWindow): Init a struct to {0} instead of using memset.
(WebCore::transferJobStatusCallback): Prevent future bugs by making an else a bit more explicit.
(WebCore::ResourceLoader::start): Pass proper port for HTTP vs. HTTPS.
(WebCore::ResourceLoader::cancel): Zero out handle when closing.

4:54 PM Changeset in webkit [16725] by mjs
  • 12 edits in trunk/WebKit

Reviewed by Darin.


  • move a big slice of data and logic from WebDataSource to WebDocumentLoadState


  • Loader/WebDocumentLoadState.h:
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState initWithRequest:]): (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState originalRequestCopy]): (-[WebDocumentLoadState request]): (-[WebDocumentLoadState replaceRequestURLForAnchorScrollWithURL:]): (-[WebDocumentLoadState setRequest:]): (-[WebDocumentLoadState setResponse:]): (-[WebDocumentLoadState isStopping]): (-[WebDocumentLoadState bridge]): (-[WebDocumentLoadState setMainDocumentError:]): (-[WebDocumentLoadState mainDocumentError]): (-[WebDocumentLoadState clearErrors]): (-[WebDocumentLoadState mainReceivedError:complete:]): (-[WebDocumentLoadState stopLoading]): (-[WebDocumentLoadState setupForReplace]): (-[WebDocumentLoadState commitIfReady]): (-[WebDocumentLoadState finishedLoading]): (-[WebDocumentLoadState setCommitted:]): (-[WebDocumentLoadState isCommitted]): (-[WebDocumentLoadState setLoading:]): (-[WebDocumentLoadState isLoading]): (-[WebDocumentLoadState commitLoadWithData:]): (-[WebDocumentLoadState doesProgressiveLoadWithMIMEType:]): (-[WebDocumentLoadState receivedData:]): (-[WebDocumentLoadState setupForReplaceByMIMEType:]): (-[WebDocumentLoadState updateLoading]): (-[WebDocumentLoadState response]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader activeDocumentLoadState]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader _archivedSubresourceForURL:]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader documentLoadState]): (-[WebFrameLoader provisionalDocumentLoadState]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader bridge]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrameLoader finishedLoadingDocumentLoadState:]): (-[WebFrameLoader commitProvisitionalLoad]): (-[WebFrameLoader committedLoadWithDocumentLoadState:data:]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader revertToProvisionalWithDocumentLoadState:]): (-[WebFrameLoader documentLoadState:setMainDocumentError:]): (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoadState:]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _finishedLoading]): (-[WebDataSource _receivedData:]): (-[WebDataSource _setMainDocumentError:]): (-[WebDataSource _clearUnarchivingState]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _startLoading]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _setTitle:]): (-[WebDataSource _initWithDocumentLoadState:]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource isLoading]): (-[WebDataSource webArchive]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebDocumentLoadStateMac.m: (-[WebDocumentLoadStateMac initWithRequest:]):
  • WebView/WebFrame.m: (-[WebFrame _createItem:]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _didReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
4:51 PM Changeset in webkit [16724] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele

If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
icon data out because we don't correctly check SQL error conditions.

  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase):
4:36 PM Changeset in webkit [16723] by sfalken
  • 3 edits in trunk/WebCore

2006-10-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Hyatt.

Added method to find out whether a layout has occurred.

  • page/FrameView.cpp: (WebCore::FrameView::didFirstLayout):
  • page/FrameView.h:
4:25 PM Changeset in webkit [16722] by bdakin
  • 1 edit
    153 adds in trunk/LayoutTests

Minor harassment followed by abject surrender provided by ggggaren.

Tests for counters.

  • fast/css/counters/contentNone-expected.checksum: Added.
  • fast/css/counters/contentNone-expected.png: Added.
  • fast/css/counters/contentNone-expected.txt: Added.
  • fast/css/counters/contentNone.html: Added.
  • fast/css/counters/counter00-expected.checksum: Added.
  • fast/css/counters/counter00-expected.png: Added.
  • fast/css/counters/counter00-expected.txt: Added.
  • fast/css/counters/counter00.html: Added.
  • fast/css/counters/counter01-expected.checksum: Added.
  • fast/css/counters/counter01-expected.png: Added.
  • fast/css/counters/counter01-expected.txt: Added.
  • fast/css/counters/counter01.html: Added.
  • fast/css/counters/counter02-expected.checksum: Added.
  • fast/css/counters/counter02-expected.png: Added.
  • fast/css/counters/counter02-expected.txt: Added.
  • fast/css/counters/counter02.html: Added.
  • fast/css/counters/counter03-expected.checksum: Added.
  • fast/css/counters/counter03-expected.png: Added.
  • fast/css/counters/counter03-expected.txt: Added.
  • fast/css/counters/counter03.html: Added.
  • fast/css/counters/counter04-expected.checksum: Added.
  • fast/css/counters/counter04-expected.png: Added.
  • fast/css/counters/counter04-expected.txt: Added.
  • fast/css/counters/counter04.html: Added.
  • fast/css/counters/counter05-expected.checksum: Added.
  • fast/css/counters/counter05-expected.png: Added.
  • fast/css/counters/counter05-expected.txt: Added.
  • fast/css/counters/counter05.html: Added.
  • fast/css/counters/counter06-expected.checksum: Added.
  • fast/css/counters/counter06-expected.png: Added.
  • fast/css/counters/counter06-expected.txt: Added.
  • fast/css/counters/counter06.html: Added.
  • fast/css/counters/counter07-expected.checksum: Added.
  • fast/css/counters/counter07-expected.png: Added.
  • fast/css/counters/counter07-expected.txt: Added.
  • fast/css/counters/counter07.html: Added.
  • fast/css/counters/counter08-expected.checksum: Added.
  • fast/css/counters/counter08-expected.png: Added.
  • fast/css/counters/counter08-expected.txt: Added.
  • fast/css/counters/counter08.html: Added.
  • fast/css/counters/counter09-expected.checksum: Added.
  • fast/css/counters/counter09-expected.png: Added.
  • fast/css/counters/counter09-expected.txt: Added.
  • fast/css/counters/counter09.html: Added.
  • fast/css/counters/counter10-expected.checksum: Added.
  • fast/css/counters/counter10-expected.png: Added.
  • fast/css/counters/counter10-expected.txt: Added.
  • fast/css/counters/counter10.html: Added.
  • fast/css/counters/counter11-expected.checksum: Added.
  • fast/css/counters/counter11-expected.png: Added.
  • fast/css/counters/counter11-expected.txt: Added.
  • fast/css/counters/counter11.html: Added.
  • fast/css/counters/counter12-expected.checksum: Added.
  • fast/css/counters/counter12-expected.png: Added.
  • fast/css/counters/counter12-expected.txt: Added.
  • fast/css/counters/counter12.html: Added.
  • fast/css/counters/counter13-expected.checksum: Added.
  • fast/css/counters/counter13-expected.png: Added.
  • fast/css/counters/counter13-expected.txt: Added.
  • fast/css/counters/counter13.html: Added.
  • fast/css/counters/counter14-expected.checksum: Added.
  • fast/css/counters/counter14-expected.png: Added.
  • fast/css/counters/counter14-expected.txt: Added.
  • fast/css/counters/counter14.html: Added.
  • fast/css/counters/counter15-expected.checksum: Added.
  • fast/css/counters/counter15-expected.png: Added.
  • fast/css/counters/counter15-expected.txt: Added.
  • fast/css/counters/counter15.html: Added.
  • fast/css/counters/counter16-expected.checksum: Added.
  • fast/css/counters/counter16-expected.png: Added.
  • fast/css/counters/counter16-expected.txt: Added.
  • fast/css/counters/counter16.html: Added.
  • fast/css/counters/counters00-expected.checksum: Added.
  • fast/css/counters/counters00-expected.png: Added.
  • fast/css/counters/counters00-expected.txt: Added.
  • fast/css/counters/counters00.html: Added.
  • fast/css/counters/counters01-expected.checksum: Added.
  • fast/css/counters/counters01-expected.png: Added.
  • fast/css/counters/counters01-expected.txt: Added.
  • fast/css/counters/counters01.html: Added.
  • fast/css/counters/counters02-expected.checksum: Added.
  • fast/css/counters/counters02-expected.png: Added.
  • fast/css/counters/counters02-expected.txt: Added.
  • fast/css/counters/counters02.html: Added.
  • fast/css/counters/counters03-expected.checksum: Added.
  • fast/css/counters/counters03-expected.png: Added.
  • fast/css/counters/counters03-expected.txt: Added.
  • fast/css/counters/counters03.html: Added.
  • fast/css/counters/counters04-expected.checksum: Added.
  • fast/css/counters/counters04-expected.png: Added.
  • fast/css/counters/counters04-expected.txt: Added.
  • fast/css/counters/counters04.html: Added.
  • fast/css/counters/counters05-expected.checksum: Added.
  • fast/css/counters/counters05-expected.png: Added.
  • fast/css/counters/counters05-expected.txt: Added.
  • fast/css/counters/counters05.html: Added.
  • fast/css/counters/counters06-expected.checksum: Added.
  • fast/css/counters/counters06-expected.png: Added.
  • fast/css/counters/counters06-expected.txt: Added.
  • fast/css/counters/counters06.html: Added.
  • fast/css/counters/counters07-expected.checksum: Added.
  • fast/css/counters/counters07-expected.png: Added.
  • fast/css/counters/counters07-expected.txt: Added.
  • fast/css/counters/counters07.html: Added.
  • fast/css/counters/counters08-expected.checksum: Added.
  • fast/css/counters/counters08-expected.png: Added.
  • fast/css/counters/counters08-expected.txt: Added.
  • fast/css/counters/counters08.html: Added.
  • fast/css/counters/counters09-expected.checksum: Added.
  • fast/css/counters/counters09-expected.png: Added.
  • fast/css/counters/counters09-expected.txt: Added.
  • fast/css/counters/counters09.html: Added.
  • fast/css/counters/counters10-expected.checksum: Added.
  • fast/css/counters/counters10-expected.png: Added.
  • fast/css/counters/counters10-expected.txt: Added.
  • fast/css/counters/counters10.html: Added.
  • fast/css/counters/counters11-expected.checksum: Added.
  • fast/css/counters/counters11-expected.png: Added.
  • fast/css/counters/counters11-expected.txt: Added.
  • fast/css/counters/counters11.html: Added.
  • fast/css/counters/counters12-expected.checksum: Added.
  • fast/css/counters/counters12-expected.png: Added.
  • fast/css/counters/counters12-expected.txt: Added.
  • fast/css/counters/counters12.html: Added.
  • fast/css/counters/counters13-expected.checksum: Added.
  • fast/css/counters/counters13-expected.png: Added.
  • fast/css/counters/counters13-expected.txt: Added.
  • fast/css/counters/counters13.html: Added.
  • fast/css/counters/counters14-expected.checksum: Added.
  • fast/css/counters/counters14-expected.png: Added.
  • fast/css/counters/counters14-expected.txt: Added.
  • fast/css/counters/counters14.html: Added.
  • fast/css/counters/counters15-expected.checksum: Added.
  • fast/css/counters/counters15-expected.png: Added.
  • fast/css/counters/counters15-expected.txt: Added.
  • fast/css/counters/counters15.html: Added.
  • fast/css/counters/counters18-expected.checksum: Added.
  • fast/css/counters/counters18-expected.png: Added.
  • fast/css/counters/counters18-expected.txt: Added.
  • fast/css/counters/counters18.html: Added.
  • fast/css/counters/implied00-expected.checksum: Added.
  • fast/css/counters/implied00-expected.png: Added.
  • fast/css/counters/implied00-expected.txt: Added.
  • fast/css/counters/implied00.html: Added.
  • fast/css/counters/root-expected.checksum: Added.
  • fast/css/counters/root-expected.png: Added.
  • fast/css/counters/root-expected.txt: Added.
  • fast/css/counters/root.html: Added.
  • fast/css/counters/visibilityNone-expected.checksum: Added.
  • fast/css/counters/visibilityNone-expected.png: Added.
  • fast/css/counters/visibilityNone-expected.txt: Added.
  • fast/css/counters/visibilityNone.html: Added.
4:15 PM Changeset in webkit [16721] by bdakin
  • 17 edits
    7 adds in trunk/WebCore

Reviewed by Darin.

Initial implementation of CSS2 counters. See ​http://
bugs.webkit.org/show_bug.cgi?id=4980 for more details.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return the increment/reset list now that this is implemented.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
  • css/Counter.h: (WebCore::Counter::Counter): (WebCore::Counter::~Counter): (WebCore::Counter::identifier): (WebCore::Counter::listStyle): (WebCore::Counter::separator): (WebCore::Counter::listStyleNumber): (WebCore::Counter::setIdentifier): (WebCore::Counter::setListStyle): (WebCore::Counter::setSeparator):
  • css/cssparser.cpp: (WebCore::CSSParser::addProperty): Take care of reset/increment (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseContent): content can now take counters (WebCore::CSSParser::parseCounterContent): Parse counter() and counters() (WebCore::CSSParser::parseCounter): Parse counter-reset and counter-increment
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchUARules): (WebCore::CSSStyleSelector::applyProperty):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::insert): Implemented a version of insert that accepts a UChar* and a length.
  • platform/StringImpl.cpp: (WebCore::StringImpl::insert): Same as above.
  • platform/StringImpl.h:
  • rendering/CounterListItem.h: Added.
  • rendering/CounterNode.cpp: Added. (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::insertAfter): (WebCore::CounterNode::removeChild): (WebCore::CounterNode::remove): (WebCore::CounterNode::setUsesSeparator): (WebCore::CounterNode::recountAndGetNext): (WebCore::CounterNode::recountTree): (WebCore::CounterNode::setSelfDirty): (WebCore::CounterNode::setParentDirty):
  • rendering/CounterNode.h: Added. (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::parent): (WebCore::CounterNode::previousSibling): (WebCore::CounterNode::nextSibling): (WebCore::CounterNode::firstChild): (WebCore::CounterNode::lastChild): (WebCore::CounterNode::value): (WebCore::CounterNode::setValue): (WebCore::CounterNode::count): (WebCore::CounterNode::setCount): (WebCore::CounterNode::setHasSeparator): (WebCore::CounterNode::isReset): (WebCore::CounterNode::hasSeparator): (WebCore::CounterNode::willNeedLayout): (WebCore::CounterNode::setWillNeedLayout): (WebCore::CounterNode::isRoot): (WebCore::CounterNode::setRenderer): (WebCore::CounterNode::renderer):
  • rendering/CounterResetNode.cpp: Added. (WebCore::CounterResetNode::CounterResetNode): (WebCore::CounterResetNode::insertAfter): (WebCore::CounterResetNode::removeChild): (WebCore::CounterResetNode::recountAndGetNext): (WebCore::CounterResetNode::setParentDirty): (WebCore::CounterResetNode::updateTotal):
  • rendering/CounterResetNode.h: Added. (WebCore::CounterResetNode::firstChild): (WebCore::CounterResetNode::lastChild): (WebCore::CounterResetNode::isReset): (WebCore::CounterResetNode::total):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updatePseudoChildForObject): Account for counter content.
  • rendering/RenderCounter.cpp: Added. (WebCore::RenderCounter::RenderCounter): (WebCore::RenderCounter::layout): (WebCore::toRoman): (WebCore::toLetterString): (WebCore::toHebrew): (WebCore::RenderCounter::convertValueToType): (WebCore::RenderCounter::calcMinMaxWidth):
  • rendering/RenderCounter.h: Added. (WebCore::RenderCounter::renderName): (WebCore::RenderCounter::isCounter):
  • rendering/RenderObject.cpp: (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to maps of CounterNodes (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::destroy): Destroy the maps. (WebCore::RenderObject::findCounter): Finds/creates counters.
  • rendering/RenderObject.h: (WebCore::RenderObject::isCounter):
  • rendering/RenderStyle.cpp: (WebCore::StyleVisualData::StyleVisualData): (WebCore::RenderStyle::arenaDelete): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setContent): (WebCore::ContentData::clearContent): (WebCore::RenderStyle::counterDataEquivalent): (WebCore::hasCounter): (WebCore::RenderStyle::hasCounterReset): (WebCore::RenderStyle::hasCounterIncrement): (WebCore::readCounter): (WebCore::RenderStyle::counterReset): (WebCore::RenderStyle::counterIncrement):
  • rendering/RenderStyle.h: (WebCore::StyleVisualData::operator==): (WebCore::CounterData::CounterData): (WebCore::CounterData::identifier): (WebCore::CounterData::listStyle): (WebCore::CounterData::separator): (WebCore::ContentData::contentCounter): (WebCore::ContentData::): (WebCore::RenderStyle::counterIncrement): (WebCore::RenderStyle::counterReset): (WebCore::RenderStyle::setCounterIncrement): (WebCore::RenderStyle::setCounterReset): (WebCore::RenderStyle::setCounterResetList): (WebCore::RenderStyle::setCounterIncrementList): (WebCore::RenderStyle::counterResetValueList): (WebCore::RenderStyle::counterIncrementValueList):
2:03 PM Changeset in webkit [16720] by aroben
  • 3 edits in trunk/LayoutTests

Reviewed by Tim H.

This change fixes a couple of problems with the window-properties
test. window-properties' output changes depending on the presence or
non-presence of session history (see
​http://bugs.webkit.org/show_bug.cgi?id=10965 for details). For this
reason, the test must always be run as part of a run of ALL layout
tests. The test results checked in were generated from an individual
run of this test, so the buildbots were always failing since they run
all the tests at once.

This change regenerates the results for the test using a full run of
layout tests. The test now also prints out object class names, and
will print an error message when the test is run by itself.

  • fast/js/window-properties-expected.txt:
  • fast/js/window-properties.html:
1:44 PM Changeset in webkit [16719] by justing
  • 2 edits in trunk/WebKit

Reviewed by john


<rdar://problem/4757583>
REGRESSION: tabbing into page focuses wrong control on 2nd pass
<rdar://problem/4757594>
REGRESSION: Form field is left with secondary selection after tabbing out of WebView

  • WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Replace code that I removed in error in the patch for 9642. Only leave inactive editable selections in the WebHTMLView if the nextResponder is in the same WebView.
1:30 PM Changeset in webkit [16718] by adele
  • 18 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adam.

  • Updated results for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
  • fast/forms/HTMLOptionElement_label05-expected.checksum:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/HTMLOptionElement_label05-expected.txt:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/option-strip-whitespace-expected.txt:
  • fast/forms/password-doubleclick-selection-expected.txt: Added.
  • fast/forms/password-doubleclick-selection.html: Added.
  • fast/forms/select-change-popup-to-listbox-expected.checksum:
  • fast/forms/select-change-popup-to-listbox-expected.png:
  • fast/forms/select-change-popup-to-listbox-expected.txt:
  • fast/text/updateNewFont-expected.checksum:
  • fast/text/updateNewFont-expected.png:
  • fast/text/updateNewFont-expected.txt:

WebCore:

Reviewed by Adam.

  • Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

There are a few outstanding issues, so I've left the old code in for now. So you can use the old-style listboxes
by using "-webkit-appearance:none".

  • css/html4.css:
11:48 AM Changeset in webkit [22282] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix: Don't copy WebKit(_debug).dll into $WebKitSDKDir

  • WebKit.vcproj/WebKit.vcproj: Remove xcopy call
9:46 AM Changeset in webkit [16717] by aroben
  • 2 edits in trunk/WebKitTools/DumpRenderTree

Backing out these accidental commits.

9:33 AM Changeset in webkit [16716] by aroben
  • 7 edits in trunk

2006-10-02 Nikolas Zimmermann <​zimmermann@kde.org>

JavaScriptCore:

Reviewed/landed by Adam.

Build testkjs on Qt/Linux.

  • CMakeLists.txt:

WebKitTools:

Reviewed/landed by Adam.

Proper build-webkit support for Qt/Linux.

Compilation process is similar to OSX now, aka.
the build directory is RootCheckoutDir/WebKitBuild now.

  • Scripts/build-webkit: Recognize Qt.
  • Scripts/webkitdirs.pm: Add buildCMakeProject() logic.
8:32 AM Changeset in webkit [16715] by harrison
  • 2 edits in trunk/WebCore

Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
addressed at a deeper level by r16696, the patch for <​http://bugs.webkit.org/show_bug.cgi?id=10842>.
Left the layout test.


  • rendering/bidi.cpp: (WebCore::checkMidpoints):
8:24 AM Changeset in webkit [16714] by zbujtas
  • 3 edits in S60/trunk/WebKit

2006-10-02 sareen <​shyam.sareen@nokia.com>

Reviewed by Zalan Bujtas.
DESC: Include correct path for inc directory for S60 only.
​http://bugs.webkit.org/show_bug.cgi?id=11122

  • group/BrowserView.mmp:
  • group/webkit.mmp:
3:57 AM Changeset in webkit [16713] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-10-02 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix win32 build, which has no inttypes.h

  • wtf/Assertions.h:
3:30 AM Changeset in webkit [16712] by eseidel
  • 4 edits in trunk

2006-10-02 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix Qt/Linux build.

  • platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/ (WebCore::supportedKeySizes):
3:26 AM Changeset in webkit [16711] by eseidel
  • 7 edits in trunk

2006-10-02 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel & mjs. Landed by eseidel.

Fix Qt/Linux build with older gcc 3.3.4.
​http://bugs.webkit.org/show_bug.cgi?id=11116

As discussed with Maciej, the GCC_ROOT_NS_HACK
can be completely removed, as well as the friendship
between cacheGlobalObject & the JS* objects.

  • bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
  • platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3. (png_read_filter_row_mmx_avg):
  • platform/image-decoders/png/pngvcrd.c: Ditto. (png_mmx_support): (png_read_filter_row_mmx_avg):
12:46 AM Changeset in webkit [16710] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Anders.


  • remove webFrame field from WebDataSourcePrivate, it can get it from WebDocumentLoadState now
  • Loader/WebDocumentLoadState.h:
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState frameLoader]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource _updateLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoading]): (-[WebDataSource _webView]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource dealloc]): (-[WebDataSource webFrame]): (-[WebDataSource isLoading]):
12:39 AM Changeset in webkit [16709] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Anders.


  • fix crash on back/forward - reattach WebDocumentLoadState to data source when needed
  • WebView/WebDataSource.m: (-[WebDataSource _setWebFrame:]): (-[WebDataSource _initWithDocumentLoadState:]):
  • WebView/WebDataSourceInternal.h:
12:16 AM Changeset in webkit [16708] by mjs
  • 1 edit
    2 adds in trunk/WebKit

Build fix, not reviewed.


  • Added missing files to fix build.
  • WebView/WebDocumentLoadStateMac.h: Added.
  • WebView/WebDocumentLoadStateMac.m: Added. (-[WebDocumentLoadStateMac initWithRequest:]): (-[WebDocumentLoadStateMac dealloc]): (-[WebDocumentLoadStateMac setDataSource:]): (-[WebDocumentLoadStateMac dataSource]): (-[WebDocumentLoadStateMac setFrameLoader:]):
12:00 AM Changeset in webkit [16707] by mjs
  • 10 edits in trunk/WebKit

Reviewed by Brady and Oliver.


  • move things around so that WebDataSource and WebDocumentLoadState know about each other in the right way. This lines things up to move nearly all functionality down to WebDocumentLoadState.
  • Loader/WebDocumentLoadState.h:
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState initWithRequest:]): (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState originalRequest]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader _setDocumentLoadState:]): (-[WebFrameLoader policyDataSource]): (-[WebFrameLoader _setPolicyDocumentLoadState:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader _setProvisionalDocumentLoadState:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader activeDocumentLoadState]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _documentLoadState]): (-[WebDataSource _initWithDocumentLoadState:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource initialRequest]): (-[WebDataSource unreachableURL]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame _policyDataSource]): (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrame _dataSourceForDocumentLoadState:]): (-[WebFrame _createDocumentLoadStateWithRequest:]):
  • WebView/WebFrameInternal.h:
Note: See TracTimeline for information about the timeline view.