⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 4, 2006:

9:58 PM Changeset in webkit [16800] by andersca
  • 2 edits in trunk/LayoutTests

2006-10-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

  • fast/frames/frame-src-attribute-expected.txt: Update test result.
8:08 PM Changeset in webkit [16799] by aroben
  • 4 edits in trunk/WebCore

Reviewed by Maciej and Tim H.

Copy some WebKit frame lifetime logic into WebCore -- just a step
along the path to frame lifetime being handled completely in WebCore.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView): Move platform-independent parts of this method into Frame.
  • page/Frame.cpp: (WebCore::Frame::setView): Adding platform-independent parts of FrameMac::setView (WebCore::Frame::detachChildren): New method to accomplish what -[WebFrameBridge _detachChildren] currently does. (WebCore::Frame::clear): Call detachChildren
  • page/Frame.h: Add declaration for detachChildren
8:06 PM Changeset in webkit [22300] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej and Tim H.

Fixes <rdar://problem/4760991>
Flash content doesn't go away when navigating to a new page

Actually destroy subframes when detaching.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::frameDetached):
  • bridge/win/FrameWin.h:
7:02 PM Changeset in webkit [22299] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.


<rdar://problem/4762998>
REGRESSION: dragging to select text does not work


  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Set the correct button for WM_MOUSEMOVE events.
6:42 PM Changeset in webkit [16798] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Removed an unnecessary assert that was stopping many pages. tm_gmtoff was not set for UTC time in mozilla but is always set for us.
  • kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::msToTM):
  • kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime):
6:07 PM Changeset in webkit [16797] by ggaren
  • 2 edits in trunk/JavaScriptCore

Patch by Darin and me, reviewed by Maciej.

Fixed <rdar://problem/4518397> REGRESSION(?): Oft-seen but unrepro crash

in JavaScript garbage collection (KJS::Collector::collect())

<rdar://problem/4752492> Crash in KJS::collect


The issue here was allocating one garbage-collected object in the midst
of allocating a second garbage-collected object. In such a case, the
zeroIfFree word lies.

  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::collect):
5:21 PM Changeset in webkit [16796] by bdash
  • 4 edits in trunk/WebKitTools

2006-10-04 Mark Rowe <​bdash@webkit.org>

Reviewed by Stephanie.

Switch the Qt buildbot to the standard set of build steps.
Have JavaScriptCoreTest check the output of run-javascriptcore-tests to
see if any regressions were spotted, and fail the test if so.

  • BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
5:19 PM Changeset in webkit [16795] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Layout test fix
  • kjs/DateMath.cpp: (KJS::dateToDayInYear): accept and correctly handle negative months
4:30 PM Changeset in webkit [22298] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

rdar://problem/4757081
Crashes/hangs when using Flash 8 plugin (Flash 9 works MUCH better)


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Encode javascript URLs before passing them to the plugin.
4:16 PM Changeset in webkit [16794] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::setRequestHeader): removed exception set when the request is not open yet
3:57 PM Changeset in webkit [16793] by kmccullo
  • 2 edits in trunk/JavaScriptCore

build fix

  • kjs/DateMath.cpp: (KJS::dateToDayInYear):
3:27 PM Changeset in webkit [16792] by brmorris
  • 24 edits
    10 adds in S60/branches/scriptable_plugins/JavaScriptCore

Landing initial version of scriptable plugins support (part 2 of 2).

3:26 PM Changeset in webkit [16791] by brmorris
  • 24 edits
    5 adds in S60/branches/scriptable_plugins

Landing scriptable plugins support (part 1 of 2).

3:25 PM Changeset in webkit [16790] by bdash
  • 2 edits in trunk/JavaScriptCore

2006-10-05 Mark Rowe <​bdash@webkit.org>

Reviewed by maculloch.

Gdk build fix.

  • JavaScriptCoreSources.bkl: Add DateMath.cpp to file list.
3:17 PM Changeset in webkit [16789] by brmorris
  • 1 copy in S60/branches/scriptable_plugins

New feature branch created from r16325.

3:14 PM Changeset in webkit [22297] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • Fix for <rdar://problem/4762933> When typing past the end of a text field, the field doesn't auto-scroll to display the active caret

Reveal the selection after inserting text.


  • WebView.cpp: (WebViewWndProc):
3:13 PM WikiRestructuredText edited by trac
(diff)
3:13 PM TracTicketsCustomFields edited by trac
(diff)
3:13 PM TracNotification edited by trac
(diff)
3:13 PM TracRepositoryAdmin created by trac
3:13 PM TracFastCgi edited by trac
(diff)
3:13 PM TracIni edited by trac
(diff)
3:13 PM TracPermissions edited by trac
(diff)
3:13 PM TracTickets edited by trac
(diff)
3:13 PM TracUpgrade edited by trac
(diff)
3:13 PM TracWiki edited by trac
(diff)
3:13 PM TracImport edited by trac
(diff)
3:13 PM TracRoadmap edited by trac
(diff)
3:13 PM SandBox edited by trac
(diff)
3:13 PM TracReports edited by trac
(diff)
3:13 PM WikiMacros edited by trac
(diff)
3:13 PM TracInterfaceCustomization edited by trac
(diff)
3:13 PM TracModPython edited by trac
(diff)
3:13 PM TracFineGrainedPermissions edited by trac
(diff)
3:13 PM TracSyntaxColoring edited by trac
(diff)
3:13 PM TracSupport edited by trac
(diff)
3:13 PM TracUnicode edited by trac
(diff)
3:13 PM TracSearch edited by trac
(diff)
3:13 PM TracTimeline edited by trac
(diff)
3:13 PM InterTrac edited by trac
(diff)
3:13 PM TracQuery edited by trac
(diff)
3:13 PM TracLogging edited by trac
(diff)
3:13 PM TracBrowser edited by trac
(diff)
3:13 PM PageTemplates edited by trac
(diff)
3:13 PM WikiProcessors edited by trac
(diff)
3:13 PM TracLinks edited by trac
(diff)
3:13 PM TracEnvironment edited by trac
(diff)
3:13 PM TracStandalone edited by trac
(diff)
3:13 PM TracModWSGI created by trac
3:13 PM WikiDeletePage edited by trac
(diff)
3:13 PM WikiHtml edited by trac
(diff)
3:13 PM TracInstall edited by trac
(diff)
3:13 PM TracCgi edited by trac
(diff)
3:13 PM TracPlugins edited by trac
(diff)
3:13 PM TracRevisionLog edited by trac
(diff)
3:13 PM TracChangeset edited by trac
(diff)
3:13 PM WikiFormatting edited by trac
(diff)
3:13 PM TracWorkflow edited by trac
(diff)
3:13 PM TracAdmin edited by trac
(diff)
3:13 PM TracNavigation edited by trac
(diff)
3:13 PM TracGuide edited by trac
(diff)
3:13 PM InterWiki edited by trac
(diff)
3:13 PM TracBackup edited by trac
(diff)
3:13 PM CamelCase edited by trac
(diff)
3:13 PM WikiPageNames edited by trac
(diff)
3:13 PM TracRss edited by trac
(diff)
3:13 PM WikiRestructuredTextLinks edited by trac
(diff)
3:13 PM TracAccessibility edited by trac
(diff)
2:27 PM Changeset in webkit [16788] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by aroben

  • build fix
2:11 PM Changeset in webkit [16787] by bdash
  • 2 edits in trunk/JavaScriptCore

2006-10-04 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Mitz.

Fix Qt/Linux build by adding DateMath.cpp to compilation.

  • CMakeLists.txt: Also replace tabs with spaces.
2:08 PM Changeset in webkit [16786] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by DethBakin.

  • Apparently the build bot uses an older version of XCode which warns about conversions and the newest version does not. I hope this fixes the build but I cann't be sure on my system.
  • kjs/DateMath.cpp: (KJS::msToYear): (KJS::dayInYear): (KJS::dateToDayInYear):
1:44 PM Changeset in webkit [16785] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Mitz Pettel!

Bug 10708: [Drosera] Make the console input plaintext-only
​http://bugs.webkit.org/show_bug.cgi?id=10708

Change the console input -webkit-user-modify property to
read-write-plaintext-only.

  • Drosera/console.css:
1:40 PM Changeset in webkit [22296] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • platform/win/NotImplemented.h: Changed implementation to use Assertions.h. Also fixed both macros to be single-statement macros.
1:37 PM Changeset in webkit [16784] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 10473: [Drosera] Overlapping text in JavaScript Console
​http://bugs.webkit.org/show_bug.cgi?id=10473

Using min-height instead of height to avoid overlapping text.

  • ChangeLog:
  • Drosera/console.css:
1:35 PM Changeset in webkit [16783] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • wtf/Assertions.cpp: Changed assertion formatting to omit the "======" lines so you can see more assertions in less space. Also improved format of file/line information so it works with more development environments.
1:34 PM Changeset in webkit [16782] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • wtf/Assertions.cpp: Changed assertion formatting to omit the "======" lines so you can see more assertions in less space. Also improved format of file/line information so it works with more development environments.
11:37 AM Changeset in webkit [16781] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Added a bash-style command history.

  • Drosera/console.js:
11:36 AM Changeset in webkit [16780] by kmccullo
  • 6 edits
    2 adds in trunk/JavaScriptCore

Reviewed by GGaren

  • This is a big makeover for our Date implemenetation. This solves many platform specific issues, specifically dates before 1970, and simplifies some ugly code. The purpose of this was to get us to pass many of the JavaScriptCore tests on windows.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/DateMath.cpp: Added. (KJS::): (KJS::daysInYear): (KJS::daysFrom1970ToYear): (KJS::msFrom1970ToYear): (KJS::msToDays): (KJS::msToYear): (KJS::isLeapYear): (KJS::isInLeapYear): (KJS::dayInYear): (KJS::msToMilliseconds): (KJS::msToWeekDay): (KJS::msToSeconds): (KJS::msToMinutes): (KJS::msToHours): (KJS::msToMonth): (KJS::msToDayInMonth): (KJS::monthToDayInYear): (KJS::timeToMseconds): (KJS::dateToDayInYear): (KJS::equivalentYearForDST): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::localTimeToUTC): (KJS::UTCToLocalTime): (KJS::dateToMseconds): (KJS::msToTM): (KJS::isDST):
  • kjs/DateMath.h: Added. (KJS::):
  • kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
  • kjs/testkjs.cpp:
  • os-win32/stdint.h:
11:34 AM Changeset in webkit [22295] by darin
  • 7 edits
    2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

  • fix <rdar://problem/4764253> frame targeting not implemented.
  • bridge/win/FrameWin.h: Added new window boolean to openURL. Also changed type from DeprecatedString to String.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Added logic to do frame targeting.
  • platform/win/BString.h: Added. Convenience for working with BSTR and handling allocation/free.
  • platform/win/BString.cpp: Added.
  • WebCore.vcproj/WebCore.vcproj: Added new files.

WebKitWin:

Reviewed by Adam.

  • fix <rdar://problem/4764253> frame targeting not implemented.
  • WebFrame.h: Added newWindow parameter to openURL and changed the URL parameter to a String.
  • WebFrame.cpp: (WebFrame::openURL): Changed code to use BString to convert the String to a BSTR. Also respect the newWindow parameter and changed the new window code slightly, adding a FIXME.
11:04 AM Changeset in webkit [16779] by andersca
  • 2 edits in trunk/WebCore

2006-10-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4654328>
Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
1:43 AM Changeset in webkit [16778] by hyatt
  • 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:39 AM Changeset in webkit [16777] by hyatt
  • 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:26 AM Changeset in webkit [16776] by hyatt
  • 2 edits in trunk/WebCore/platform

Fix more win32 and qt bustage.

1:21 AM Changeset in webkit [16775] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix more win32 bustage.

1:19 AM Changeset in webkit [16774] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix more win32 bustage.

1:11 AM Changeset in webkit [16773] by hyatt
  • 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:10 AM Changeset in webkit [16772] by hyatt
  • 1 edit in trunk/WebCore/platform/qt/TemporaryLinkStubs.cpp

Fix Qt bustage.

1:09 AM Changeset in webkit [16771] by hyatt
  • 1 edit in trunk/WebCore/platform/gdk/WidgetGdk.cpp

Fix Gdk bustage.

1:06 AM Changeset in webkit [16770] by hyatt
  • 2 edits in trunk/WebCore/platform/qt

Fix Qt bustage.

1:05 AM Changeset in webkit [16769] by hyatt
  • 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

12:53 AM Changeset in webkit [16768] by hyatt
  • 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

12:52 AM Changeset in webkit [16767] by hyatt
  • 2 edits in trunk/WebCore/platform/win

Fix Win32 bustage.

12:22 AM Changeset in webkit [22294] by hyatt
  • 4 edits in branches/WindowsMerge/WebKitWin

Fix the textfield caret by not doing layouts every time we paint.

Oct 3, 2006:

9:50 PM Changeset in webkit [22293] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/WidgetWin.cpp

Move function into WidgetWin.cpp, since I made it windows only but had left it in Widget.cpp (breaking mac)

9:45 PM Changeset in webkit [16766] by hyatt
  • 1 edit in trunk/WebCore/platform/Widget.cpp

Fix mac build bustage.

9:34 PM Changeset in webkit [16765] by ap
  • 5 edits in trunk

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=11130
Convert "undefined" to AE missing value

WebCore:

  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): return missing value for UndefinedType.

LayoutTests:

  • fast/AppleScript/001-expected.txt:
  • fast/AppleScript/array-expected.txt: Updated the results.
9:26 PM Changeset in webkit [22292] by hyatt
  • 7 edits in branches/WindowsMerge/WebCore

Land the new scrollview.

9:26 PM Changeset in webkit [22291] by hyatt
  • 4 edits in branches/WindowsMerge/WebKitWin

Improve painting to not always use the unioned invalidation rect.

9:22 PM Changeset in webkit [16764] by hyatt
  • 18 edits in trunk/WebCore

Scrolling work.

8:36 PM Changeset in webkit [16763] by bdash
  • 2 edits in trunk/WebKit

2006-10-04 Mark Rowe <​bdash@webkit.org>

Reviewed by NOBODY (build fix).

  • WebView/WebView.m: (-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.
7:51 PM Changeset in webkit [16762] by bdash
  • 2 edits in trunk

Update bug URLs in the two patches that I just landed.

7:46 PM Changeset in webkit [16761] by bdash
  • 6 edits in trunk

2006-09-26 David Smith <​catfish.man@gmail.com>

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:

No automated tests are possible as this code path isn't reachable from JavaScript.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):

2006-09-26 David Smith <​catfish.man@gmail.com>

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:

  • WebView/WebView.m: (-[WebView scrollDOMRangeToVisible:]):
  • WebView/WebViewPrivate.h:
7:31 PM Changeset in webkit [16760] by bdash
  • 13 edits in trunk

2006-10-03 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Timothy.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand


Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:

  • AlwaysLive: Safari 2.0 behaviour
  • OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
  • LiveWhenNotFocused: Editable links are live only when their editable block is not

focused, or when the shift key is pressed

  • DefaultBehavior: This is the same as OnlyLiveWithShiftKey.


No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.

  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]): (-[WebCoreSettings editableLinkBehavior]):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive):
  • html/HTMLAnchorElement.h:
  • manual-tests/contenteditable-link.html:
  • page/FrameView.cpp: (WebCore::nodeIsNotBeingEdited): (WebCore::selectCursor):
  • page/Settings.h: (WebCore::Settings::): (WebCore::Settings::Settings): (WebCore::Settings::editableLinkBehavior): (WebCore::Settings::setEditableLinkBehavior):

2006-10-03 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Timothy.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand


Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:

  • AlwaysLive: Safari 2.0 behaviour
  • OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
  • LiveWhenNotFocused: Editable links are live only when their editable block is not

focused, or when the shift key is pressed

  • DefaultBehavior: This is the same as OnlyLiveWithShiftKey.


No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences editableLinkBehavior]): (-[WebPreferences setEditableLinkBehavior:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):
6:28 PM Changeset in webkit [22290] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Improvements to error handling in PluginStreamWin.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::deliverData): Fail quietly if called after termination (due to bad error handling in ResourceLoaderWin), ASSERT if called before stream has been started. (WebCore::PluginStreamWin::receivedData): Ditto. (WebCore::PluginStreamWin::receivedAllData): Ditto.
6:12 PM Changeset in webkit [16759] by bdakin
  • 3 edits in trunk/WebCore

Reviewed Darin.

No test cases needed.

Implemented a version of StringImpl::append that takes a UChar* and
a length.

  • platform/StringImpl.cpp: (WebCore::StringImpl::append): (WebCore::StringImpl::insert): Call new append instead of making a new StringImpl.
  • platform/StringImpl.h:
6:10 PM Changeset in webkit [16758] by andersca
  • 2 edits in trunk/WebKitTools

2006-10-03 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam and Brady.

  • DumpRenderTree/DumpRenderTree.m: (main): Update URL to Ahem.ttf
6:09 PM Changeset in webkit [16757] by bdash
  • 2 edits in trunk/WebCore

2006-10-03 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11099
HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onHandleCreated):
5:42 PM Changeset in webkit [22289] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fixes <rdar://problem/4760963>
Failed ASSERT in PluginStreamWin::~PluginStreamWin at espn.com

We now store the state of a stream as a tri-state enum in
m_streamState. This allows us to differentiate between before and after the
stream has been started.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): Initialize members of m_stream struct individually. (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): Return early if the stream isn't started. (WebCore::PluginStreamWin::receivedData): Ditto. (WebCore::PluginStreamWin::receivedAllData): Ditto.
  • plugins/win/PluginStreamWin.h: (WebCore::): Add PluginStreamState enum.
4:50 PM Changeset in webkit [16756] by thatcher
  • 5 edits in tags/WebCore-521.28.1/WebCore

Merging a fix for bug 4671286 (r16737).

4:48 PM Changeset in webkit [16755] by thatcher
  • 2 edits in tags/WebCore-521.28.1/WebCore

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
REGRESSION (r15418): contenteditable div truncates rightmost Japanese character


Make sure we only break after a space (and not any other valid line-break) if
the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
twice in quick succession.

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):
4:46 PM Changeset in webkit [16754] by thatcher
  • 3 edits in tags/WebCore-521.28.1/WebCore

Merging a fix for 4717965 and 4712111 (r16567).

4:28 PM Changeset in webkit [16753] by thatcher
  • 1 edit in tags/WebCore-521.28.1/WebCore/Info.plist

Versioning

4:28 PM Changeset in webkit [16752] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/execCommand/paste-1-expected.checksum: Added.
  • editing/execCommand/paste-1-expected.png: Added.
  • editing/execCommand/paste-1-expected.txt: Added.
  • editing/execCommand/paste-1.html: Added.
  • editing/execCommand/paste-2-expected.checksum: Added.
  • editing/execCommand/paste-2-expected.png: Added.
  • editing/execCommand/paste-2-expected.txt: Added.
  • editing/execCommand/paste-2.html: Added.

WebKit:

Reviewed by harrison


execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView. (-[WebFrameBridge issueCopyCommand]): Ditto. (-[WebFrameBridge issuePasteCommand]): Ditto. (-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto. (-[WebFrameBridge issueTransposeCommand]): Fixed formatting. (-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
  • WebView/WebHTMLView.m: (-[WebHTMLView copy:]): Moved to WebInternal (-[WebHTMLView cut:]): Ditto. (-[WebHTMLView paste:]): Ditto. (-[WebHTMLView pasteAsPlainText:]): Ditto.
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.m: Removed the now unused _canPaste.
  • WebView/WebViewInternal.h: Ditto.
4:25 PM Changeset in webkit [16751] by thatcher
  • 1 copy in tags/WebCore-521.28.1/WebCore

New tag part 2.

4:24 PM Changeset in webkit [16750] by thatcher
  • 1 add in tags/WebCore-521.28.1

New tag.

4:24 PM Changeset in webkit [16749] by thatcher
  • 1 delete in WebCore-521.28.1

Bad tag.

4:23 PM Changeset in webkit [16748] by thatcher
  • 1 add in WebCore-521.28.1

New tag.

4:19 PM Changeset in webkit [16747] by bdakin
  • 9 edits in trunk/LayoutTests

Reviewed by Geoff.

Changing these two counters tests so they pass on the BuildBot.

  • fast/css/counters/counter04-expected.checksum:
  • fast/css/counters/counter04-expected.png:
  • fast/css/counters/counter04-expected.txt:
  • fast/css/counters/counter04.html:
  • fast/css/counters/counters04-expected.checksum:
  • fast/css/counters/counters04-expected.png:
  • fast/css/counters/counters04-expected.txt:
  • fast/css/counters/counters04.html:
4:00 PM Changeset in webkit [16746] by justing
  • 4 edits in trunk/LayoutTests

Reviewed by geoff


Fixed a typo, updating expected results.

  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
4:00 PM Changeset in webkit [16745] by ggaren
  • 6 edits in trunk/WebCore

Feared, loathed, reviewed by Darin.

More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
into FRAME, plus other cleanup.


No new behavior, so no new test. Layout tests pass. Basic browsing and
Mail editing seem to work.


  • dom/Node.cpp: (WebCore::Node::detach): Removed random commented-out code.
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::isURLAllowed): (1) Removed reference to FrameView, to dissociate frame loading from rendering. (2) Renamed newURL to completeURL because the difference between newURL and URLString is that newURL is a KURL that is the complete version of URLString, not that it is new. (WebCore::HTMLFrameElement::willRemove): (1) Removed close() call and moved close() code into willRemove(), also removing close() call from detach(), since willRemove is the well-defined place from DOM tear-down, not detach(). (2) Removed manual renderer detach code because the DOM is not responsible for managing the render tree. I confirmed that this change not regress <rdar://problem/4132581>. (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements lost their content frames after being removed from the DOM. That's our current behavior, but it's going to change in future rounds of refactoring. This also fixes <rdar://problem/4750835>. (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to attach/detach, because the render tree should not be in charge of deciding when to load.
  • html/HTMLFrameElement.h:
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject, because the renderer is a renderPartObject, not a renderPart.
  • html/HTMLIFrameElement.h:
3:46 PM Changeset in webkit [16744] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/commit-log-editor: Added missing "close" call. Oops!
3:14 PM Changeset in webkit [16743] by bdash
  • 2 edits in trunk/WebCore

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11137
Bug 11137: GdkLauncher dies with "pure virtual method called" if
window is closed while page still loading

  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual methods to be called before the FrameGdk portion of "this" is torn down.
2:53 PM Changeset in webkit [16742] by justing
  • 2 edits in trunk/WebKit

Reviewed by geoff


<rdar://problem/4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load

  • Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Enable multipart/x-mixed-replace support on the request. This line was accidently removed during some loader refactoring.
2:10 PM Changeset in webkit [22288] by aroben
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Fixes <rdar://problem/4603342>
Keyboard navigability

Implement tabbing between form elements (in the single-frame case).

  • bridge/win/FrameWin.cpp: Add methods to determine tabbing preferences. (WebCore::FrameWin::tabsToLinks): (WebCore::FrameWin::tabsToAllControls):
  • bridge/win/FrameWin.h: Add tabsToLinks() to FrameWinClient
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollPointRecursively): Implemented for single-frame case.
  • platform/win/TemporaryLinkStubs.cpp: Remove stub for now-implemented ScrollView::scrollPointsRecursively

WebKitWin:

Reviewed by Darin.

Part of fix for <rdar://problem/4603342>
Keyboard navigability

Implement methods to determine tabbing preferences.

  • WebFrame.cpp: (WebFrame::tabsToLinks):
  • WebFrame.h:
2:09 PM Changeset in webkit [16741] by aroben
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Handle tab key presses in the DOM.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
  • page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Rename and reimplement focusNextPrevNode. Now we just call Element::focus().
  • page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make it public.
12:01 PM Changeset in webkit [16740] by justing
  • 2 edits in trunk/WebCore

Reviewed by mjs


<rdar://problem/4760612>
TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints


No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.


  • dom/Range.cpp: (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming positions are non-null since most of it's callers would be in a bad state if the positions were null. boundaryPointsValid, which calls compareBoundaryPoints, is an exception. Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it from entering compareBoundaryPoints and hitting the assert.
11:55 AM Changeset in webkit [16739] by adele
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler):
11:18 AM Changeset in webkit [16738] by darin
  • 2 edits in trunk/WebCore

2006-10-04 Darin Adler <Darin Adler>

Reviewed by Geoff.

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Remove unnecessary call to clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this. (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout to false so we can get the old caret repaint rect. Later we need to change the design so getting the rect doesn't have a side effect of causing a layout without invalidation.
11:16 AM Changeset in webkit [22287] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-04 Darin Adler <Darin Adler>

Reviewed by Adam.

  • WebView.cpp: (WebView::handleMouseEvent): Pass message when creating a PlatformMouseEvent.
7:44 AM Changeset in webkit [16737] by harrison
  • 10 edits in trunk

LayoutTests:

Reviewed by Maciej.


<rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

Updated test so that it actually shows the caret rect for the caret position.
Before, it was showing the caret rect for the 9th character of the test description.


  • fast/text/justified-text-rect-expected.checksum:
  • fast/text/justified-text-rect-expected.png:
  • fast/text/justified-text-rect-expected.txt:
  • fast/text/justified-text-rect.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

Updated test:

  • fast/text/justified-text-rect.html
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): Make the selection's root editable element (or the document itself) be the basis for NSRange conversions. This supports "shadow DOM" like that for text fields and text areas.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Pass the document element as the scope.


  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Make the first parameter the scope.


  • editing/TextIterator.h: Make the first parameter of rangeFromLocationAndLength() the scope.
5:14 AM Changeset in webkit [16736] by eseidel
  • 4 edits in trunk/WebKitTools

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Offer a way for BuildBot to not colorize the cmake output, when building
with the 'build-webkit' script. Add "--color" / "--no-color" option pair.

Default is colorize output, though only Qt platform handles this for now.

  • Scripts/build-dumprendertree:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
3:49 AM Changeset in webkit [16735] by eseidel
  • 5 edits in trunk/WebKitTools

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Make all important scripts work with Qt/Linux.

You can safely use this now:
set-configuration-release --debug && build-webkit && run-javascriptcore-tests && run-webkit-tests

  • Scripts/build-dumprendertree:
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
2:46 AM Changeset in webkit [16734] by bdash
  • 4 edits in trunk

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric.

build-webkit tweak: Use WebKitBuild/$config as output dir (Release/Debug).

  • Scripts/webkitdirs.pm:

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric.

Fix Qt/Linux build.

  • CMakeLists.txt: Add counter related files.
2:42 AM Changeset in webkit [16733] by bdash
  • 9 edits
    1 add in trunk

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

Stop Bakefile-generated Makefile from running `pkg-config' multiple times per file.

  • presets.bkl: Make use of "options" and Python commands to run pkg-config etc up front.

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=10981
Linux/GDK build fixes

Based on a patch by Krzysztof Kowalczyk.

  • WebCoreSources.bkl:
  • platform/gdk/FrameGdk.cpp: (WebCore::doScroll): (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
  • platform/gdk/ScrollViewGdk.cpp:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (FrameView::passMousePressEventToSubframe): (FrameView::passMouseReleaseEventToSubframe): (FrameView::passMouseMoveEventToSubframe): (FrameView::passWheelEventToSubframe): (Cursor::Cursor): (Widget::invalidate): (Widget::invalidateRect): (ScrollView::wheelEvent): (ScrollView::convertToContainingWindow): (ScrollView::convertFromContainingWindow): (GraphicsContext::clip): (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::updateThumbPosition): (PlatformScrollBar::updateThumbProportion): (ScrollBar::ScrollBar): (ScrollBar::setProportion): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
  • platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):
Note: See TracTimeline for information about the timeline view.