⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 5, 2006:

11:19 PM Changeset in webkit [22315] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix scrollview resizing to do updatescrollbars even for iframes. Matches Mac better and makes iframes stop showing scrollbars when they shouldn't.

11:14 PM Changeset in webkit [16838] by hyatt
  • 2 edits in trunk/WebCore

Stub out setFrameGeometry.

10:53 PM Changeset in webkit [22314] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/GraphicsContextWin.cpp

Implement proper clipping and transforms for themed form controls.

10:45 PM Changeset in webkit [22313] by hyatt
  • 6 edits in branches/WindowsMerge

Implement proper clipping and transforms for themed form controls.

10:30 PM Changeset in webkit [16837] by hyatt
  • 1 edit in trunk/WebCore/platform/cg/GraphicsContextCG.cpp

Temporary hack.

10:18 PM Changeset in webkit [16836] by adele
  • 5 edits in trunk/WebCore

Reverting autoscroll fix. I need to rework this a little.

  • page/Frame.cpp: (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::stopAutoscrollTimer):
  • page/Frame.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox):
9:48 PM Changeset in webkit [16835] by andersca
  • 2 edits in trunk/WebKitTools

2006-10-05 Oliver Hunt <ohunt@apple.com>

Reviewed by Anders.

  • Scripts/run-webkit-tests: Fix pixel tests.
8:57 PM Changeset in webkit [16834] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://problem/4731778>

  • editing/CommandByName.cpp: (WebCore::Frame::Command::): was calling the wrong enabledFn for arrow selection and navigation
8:34 PM Changeset in webkit [16833] by adele
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

  • Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text"> and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
  • page/Frame.cpp: Added getter and setter for the renderer being autoscrolled. (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::autoscrollRenderer): (WebCore::Frame::setAutoscrollRenderer): (WebCore::Frame::stopAutoscrollTimer):
  • page/Frame.h:
7:48 PM Changeset in webkit [16832] by bdash
  • 7 edits in trunk/WebCore

2006-10-05 Don Gibson <dgibson77@gmail.com>

Reviewed by Eric.

Fix win32 build bustage after ggaren's Scrollbar renaming changes.
Properly include PlatformScrollBar.h in WbCore.vcproj.
Clean up WidgetWin.cpp a bit.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/Widget.h:
  • platform/win/PlatformScrollBar.h:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars):
  • platform/win/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion):
  • platform/win/WidgetWin.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::setContainingWindow): (WebCore::Widget::containingWindow):
6:23 PM Changeset in webkit [16831] by adele
  • 5 edits in trunk/WebKit

Reviewed by the letter 'B'.

More build fixes.

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDynamicScrollBarsView.h:
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): (-[WebDynamicScrollBarsView allowsVerticalScrolling]): (-[WebDynamicScrollBarsView horizontalScrollingMode]): (-[WebDynamicScrollBarsView verticalScrollingMode]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]):
  • WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]):
6:03 PM Changeset in webkit [22312] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

build fix.


  • platform/win/WidgetWin.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::removeFromParent):
6:01 PM Changeset in webkit [16830] by ggaren
  • 14 edits in trunk/WebCore

build fix.


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame):
  • bridge/mac/FrameViewMac.mm: (WebCore::FrameView::passMousePressEventToScrollbar):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge installInFrame:]):
  • bridge/mac/WebCoreFrameView.h:
  • platform/ScrollBar.cpp:
  • platform/Widget.h:
  • platform/mac/PlatformScrollBar.h:
  • platform/mac/PlatformScrollBarMac.mm: (NSControlSizeForScrollBarControlSize): (-[WebCoreScrollBar initWithPlatformScrollbar:]): (-[WebCoreScrollBar detachPlatformScrollbar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::scrollbarHit): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::scrollbarUnderMouse):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::removeFromParent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar):
5:02 PM Changeset in webkit [16829] by eseidel
  • 2 edits in trunk/WebKitSite

2006-10-05 Eric Seidel <eric@eseidel.com>

Reviewed by Tim H.

  • coding/coding-style.html: use css styles, add example for whitespace, add example for c++ constructors
4:16 PM Changeset in webkit [22311] by lamadio
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKitGUID.vcproj

Correct a build break when the build directory is outside the source tree.

3:58 PM Changeset in webkit [16828] by brmorris
  • 1 edit in S60/trunk/S60Internals/S60DynamicLibs.zip

Fix runtime break introduced in r16809: added RecentUrlStore.dll

3:38 PM Changeset in webkit [22310] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Fix addClip->clip renaming bustage.

3:26 PM Changeset in webkit [16827] by bdash
  • 1 edit
    4 adds in trunk/WebCore

2006-10-06 Mitz Pettel <mitz@webkit.org>

http://bugs.webkit.org/show_bug.cgi?id=8276
Fix broken manual test added back in r13990.

Add resource forks for test resources.

  • manual-tests/resources/plain-text-paste/._1.textClipping: Added.
  • manual-tests/resources/plain-text-paste/._2.textClipping: Added.
  • manual-tests/resources/plain-text-paste/._4.txt: Added.
  • manual-tests/resources/plain-text-paste/._5.webloc: Added.
3:21 PM Changeset in webkit [22309] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Stub out GraphicsContextPlatformPrivate methods so that the HDC can
be updated when clips/transforms are applied.

Reviewed by darin

  • platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
3:19 PM Changeset in webkit [22308] by aroben
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Build fix.

  • WebKit.vcproj/WebKitGUID.vcproj: Fix patch to IWebFramePrivate_i.c
3:16 PM Changeset in webkit [22307] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::BrowserExtensionWin): Change Frame* to FrameWin*
3:14 PM Changeset in webkit [16826] by hyatt
  • 18 edits in trunk/WebCore

Rename addClip to clip.

Reviewed by darin

  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM):
  • platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addRoundedRectClip):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::setClip):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3:11 PM Changeset in webkit [22306] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix. Remove RenderImageButton.{h,cpp}.

  • WebCore.vcproj/WebCore.vcproj:
3:03 PM Changeset in webkit [16825] by bdash
  • 4 edits
    2 deletes in trunk/WebCore

2006-10-05 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • CMakeLists.txt:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCoreSources.bkl:
  • rendering/RenderImageButton.cpp: Removed.
  • rendering/RenderImageButton.h: Removed.
2:56 PM Changeset in webkit [16824] by bdash
  • 2 edits in trunk/WebCore

2006-10-05 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by Darin.

  • manual-tests/scrollbar-hittest2.html:
2:53 PM Changeset in webkit [16823] by bdash
  • 3 edits in trunk/WebKit

2006-10-05 Vladimir Olexa <vladimir.olexa@gmail.com>

Reviewed by Timothy.

Bug: http://bugs.webkit.org/show_bug.cgi?id=9887
Continuous spell checking now remembers user's setting. The change is applied globally,
meaning, both TextArea and TextField are affected when either of them enables/disables
spell checking.

  • WebView/WebPreferenceKeysPrivate.h: added a define for WebContinuousSpellCheckingEnabled
  • WebView/WebView.m: (-[WebViewPrivate init]): reads WebContinuousSpellCheckingEnabled from NSUserDefaults (-[WebView setContinuousSpellCheckingEnabled:]): (-[WebView isContinuousSpellCheckingEnabled]):
2:43 PM Changeset in webkit [16822] by bdash
  • 2 edits in trunk/WebKit

2006-10-05 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11162

  • COM/WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedResponse):
2:40 PM Changeset in webkit [16821] by bdash
  • 3 edits in trunk/WebCore

2006-10-05 David Carson <dacarson@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11152
Adjust the tokenizer chunk size to be smaller for
mobile devices, and also decrease the yield timer
for the tokenizer so that it can resume earlier.

  • html/HTMLTokenizer.cpp:
  • config.h:
2:38 PM Changeset in webkit [16820] by aroben
  • 2 edits in trunk/WebCore

Removing accidentally-checked-in do-nothing code.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
2:35 PM Changeset in webkit [16819] by bdash
  • 2 edits in trunk/WebCore

2006-10-05 David Carson <dacarson@gmail.com>

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11158
Initialize class variables

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):
2:33 PM Changeset in webkit [22305] by andersca
  • 9 edits
    1 add in branches/WindowsMerge/WebKitWin

2006-10-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

A couple of changes needed for the new DumpRenderTree.


  • DOMCoreClasses.cpp: (DOMDocument::documentElement): Implement.


  • DOMHTMLClasses.cpp: (DOMHTMLElement::innerHTML): (DOMHTMLElement::setInnerHTML): (DOMHTMLElement::innerText): (DOMHTMLElement::setInnerText):
  • DOMHTMLClasses.h: (DOMHTMLFormElement::innerHTML): (DOMHTMLFormElement::setInnerHTML): (DOMHTMLFormElement::innerText): (DOMHTMLFormElement::setInnerText): (DOMHTMLSelectElement::innerHTML): (DOMHTMLSelectElement::setInnerHTML): (DOMHTMLSelectElement::innerText): (DOMHTMLSelectElement::setInnerText): (DOMHTMLOptionElement::innerHTML): (DOMHTMLOptionElement::setInnerHTML): (DOMHTMLOptionElement::innerText): (DOMHTMLOptionElement::setInnerText): (DOMHTMLInputElement::innerHTML): (DOMHTMLInputElement::setInnerHTML): (DOMHTMLInputElement::innerText): (DOMHTMLInputElement::setInnerText): (DOMHTMLTextAreaElement::innerHTML): (DOMHTMLTextAreaElement::setInnerHTML): (DOMHTMLTextAreaElement::innerText): (DOMHTMLTextAreaElement::setInnerText):
  • Interfaces/DOMHTML.idl: Implement innerText and add stubs for innerHTML, setInnerHTML and setInnerText.


  • Interfaces/IWebFramePrivate.idl: Added.
  • WebFrame.cpp: (WebFrame::QueryInterface): (WebFrame::renderTreeAsExternalRepresentation): (WebFrame::receivedAllData): Call Frame::end() before calling the frame load delegate methods. This matches the mac behavior.


(WebFrame::didFirstLayout):
(WebFrame::handledOnloadEvents):
Add null checks for frameLoadDelegatePriv, all clients might not use it.


  • WebFrame.h:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj: Add new interface, IWebFramePrivate, which supports getting the render tree as text.
1:27 PM Changeset in webkit [16818] by aroben
  • 7 edits in trunk

2006-10-05 Don Gibson <dgibson77@gmail.com>

WebCore:

Reviewed by Darin, landed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::start):

WebKit:

Reviewed by Darin, landed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.

  • COM/WebFrame.cpp: (WebFrame::loadDataSource):
1:22 PM Changeset in webkit [16817] by ap
  • 10 edits
    1 add in trunk

2006-10-05 Marvin Decker <marv.decker@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=10989
Provide a way for embedders to implement BrowserExtensionWin

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.cpp: Added. (BrowserExtensionWin::BrowserExtensionWin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::setIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::historyURL):
  • bridge/win/BrowserExtensionWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow):
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp:

WebKit:

  • COM/Interfaces/IWebUIDelegate.idl:
  • COM/WebFrame.cpp: (WebFrame::createNewWindow):
  • COM/WebFrame.h:
1:17 PM Changeset in webkit [16816] by brmorris
  • 1 edit in S60/trunk/S60Internals/S60DynamicLibs.zip

More break fixes: updating Toolbar.* in S60/S60Internals/S60DynamicLibs.zip

1:01 PM Changeset in webkit [22304] by ggaren
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.


Fixed <rdar://problem/4766987>


  • renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names.


  • fixed RenderLayer to properly tear down scrollbars, removing them from their parents.
  • bridge/win/FrameViewWin.cpp: (WebCore::FrameView::passMousePressEventToScrollbar):
  • platform/win/PlatformScrollBar.h: (WebCore::):
  • platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::invalidateTrack): (WebCore::PlatformScrollbar::invalidatePart): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::backButtonRect): (WebCore::PlatformScrollbar::forwardButtonRect): (WebCore::PlatformScrollbar::trackRect): (WebCore::PlatformScrollbar::thumbRect): (WebCore::PlatformScrollbar::gripperRect): (WebCore::PlatformScrollbar::splitTrack): (WebCore::PlatformScrollbar::thumbPosition): (WebCore::PlatformScrollbar::thumbLength): (WebCore::PlatformScrollbar::trackLength): (WebCore::PlatformScrollbar::paintButton): (WebCore::PlatformScrollbar::paintTrack): (WebCore::PlatformScrollbar::paintThumb): (WebCore::PlatformScrollbar::paintGripper): (WebCore::PlatformScrollbar::hitTest): (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent): (WebCore::PlatformScrollbar::startTimerIfNeeded): (WebCore::PlatformScrollbar::stopTimerIfNeeded): (WebCore::PlatformScrollbar::autoscrollPressedPart): (WebCore::PlatformScrollbar::autoscrollTimerFired): (WebCore::PlatformScrollbar::pressedPartScrollDirection): (WebCore::PlatformScrollbar::pressedPartScrollGranularity): (WebCore::PlatformScrollbar::thumbUnderMouse): (WebCore::PlatformScrollbar::themeChanged): (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint): (WebCore::ScrollView::themeChanged):
12:59 PM Changeset in webkit [16815] by ggaren
  • 21 edits in trunk/WebCore

Reviewed by Darin.


Fixed <rdar://problem/4766987>


  • renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names.


  • fixed RenderLayer to properly tear down scrollbars, removing them from their parents.
  • bindings/js/kjs_window.cpp: (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures):
  • bridge/BrowserExtension.h:
  • dom/Document.cpp: (WebCore::Document::setInPageCache):
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::scrollingMode):
  • page/Frame.cpp: (WebCore::Frame::finishedParsing): (WebCore::Frame::scrollbarsVisible):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::clear): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): (WebCore::FrameView::handleMousePressEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::setScrollbarsMode): (WebCore::FrameView::setVScrollbarMode): (WebCore::FrameView::setHScrollbarMode): (WebCore::FrameView::restoreScrollbar): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::scrollbarMoved):
  • page/FrameView.h:
  • page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
  • page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::scrollbar):
  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll):
  • platform/ScrollBar.h: (WebCore::): (WebCore::ScrollbarClient::~ScrollbarClient): (WebCore::Scrollbar::~Scrollbar): (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::controlSize): (WebCore::Scrollbar::hasPlatformScrollbars): (WebCore::Scrollbar::client):
  • platform/ScrollBarMode.h: (WebCore::):
  • platform/ScrollView.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::horizontaScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::verticalScrollbarWidth): (WebCore::RenderLayer::horizontalScrollbarHeight): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::calcMinMaxWidth): (WebCore::RenderListBox::isPointInScrollbar): (WebCore::RenderListBox::optionAtPoint): (WebCore::RenderListBox::valueChanged):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::NodeInfo::scrollbar): (WebCore::RenderObject::NodeInfo::setScrollbar):
12:58 PM Changeset in webkit [16814] by andersca
  • 2 edits in trunk/WebKitTools

2006-10-04 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

  • Scripts/run-webkit-tests: Add an environment variable, WebKitExpectedTestResultsDirectory, which controls where expected test results should be.
12:38 PM Changeset in webkit [16813] by ap
  • 2 edits in trunk/WebKitTools

2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by ap.

Cmake: make it possible to install the libraries after having built using 'build-webkit'.
Just set the "WebKitInstallationPrefix" environment variable to your desired prefix.

  • Scripts/webkitdirs.pm:
11:27 AM Changeset in webkit [16812] by brmorris
  • 2 edits in S60/trunk/S60Internals

Fix build break introduced in r16809 by updating toolbar.h in S60Headers.zip

10:57 AM Changeset in webkit [16811] by ap
  • 2 edits in trunk/WebCore

2006-10-05 Don Gibson <dgibson77@gmail.com>

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=11138
Incorrect mouse event generation on Windows

  • platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): (1) Set mouse button even for non-click-related messages. (2) Track clicks correctly for all buttons, not just the left button.
10:48 AM Changeset in webkit [16810] by ap
  • 8 edits in trunk/WebCore

2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by ap.

Fix Qt/Linux build, adapt to Eric's Quartz changes and to Maciej's ResourceLoader changes.

  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::renderPath): (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp: (WebCore::KRenderingPaintServerPatternQt::renderPath):
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties):
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup): (WebCore::KRenderingPaintServerSolidQt::renderPath):
  • kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke):
10:37 AM Changeset in webkit [16809] by yongjzha
  • 5 edits in S60/trunk/WebKit

2006-10-05 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Zhang Yongjun.
DESC: Enable touch ui on browser toolbar
http://bugs.webkit.org/show_bug.cgi?id=11156

  • BrowserView/inc/PointerEventHandler.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::LaunchToolBarL): (CWebKitView::NodeUnderPointer):
10:20 AM Changeset in webkit [16808] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

  • wtf/Assertions.cpp: Fix build when _DEBUG is not defined.
9:44 AM Changeset in webkit [16807] by ap
  • 3 edits
    23 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11054
REGRESSION: Traditional Chinese encoding in login authentication

  1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
  2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding for encoding GB_2312-80 and several others. So, we need to override this behavior, too.

WebCore:

  • platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):

LayoutTests:

Each of these tests is passed by Firefox 1.5 and/or WinIE 6.

  • fast/encoding/GBK/EUC-CN-expected.txt: Added.
  • fast/encoding/GBK/EUC-CN.html: Added.
  • fast/encoding/GBK/chinese-expected.txt: Added.
  • fast/encoding/GBK/chinese.html: Added.
  • fast/encoding/GBK/cn-gb-expected.txt: Added.
  • fast/encoding/GBK/cn-gb.html: Added.
  • fast/encoding/GBK/csgb2312-expected.txt: Added.
  • fast/encoding/GBK/csgb2312.html: Added.
  • fast/encoding/GBK/csgb231280-expected.txt: Added.
  • fast/encoding/GBK/csgb231280.html: Added.
  • fast/encoding/GBK/gb2312-expected.txt: Added.
  • fast/encoding/GBK/gb2312.html: Added.
  • fast/encoding/GBK/gb_2312-80-expected.txt: Added.
  • fast/encoding/GBK/gb_2312-80.html: Added.
  • fast/encoding/GBK/gbk-expected.txt: Added.
  • fast/encoding/GBK/gbk.html: Added.
  • fast/encoding/GBK/iso-ir-58-expected.txt: Added.
  • fast/encoding/GBK/iso-ir-58.html: Added.
  • fast/encoding/GBK/x-euc-cn-expected.txt: Added.
  • fast/encoding/GBK/x-euc-cn.html: Added.
  • fast/encoding/GBK/x-gbk-expected.txt: Added.
  • fast/encoding/GBK/x-gbk.html: Added.
6:59 AM Changeset in webkit [16806] by eseidel
  • 2 edits
    1 delete in trunk/WebCore

2006-10-05 Eric Seidel <eric@eseidel.com>

Reviewed by mjs.

Removed dead code.
Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/ecma/GlobalObject.cpp: Removed.
  • ksvg2/ecma/GlobalObject.h: Removed.
6:56 AM Changeset in webkit [22303] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fixes <rdar://problem/4757387>
Unable to sign on to my.yahoo.com

This patch fixes a number of bugs that all resulted in not being able
to log on to many websites. The problems were that we weren't allowing
redirects between HTTP and HTTPS sites and weren't correctly handling
redirects from POST requests to GET requests.

  • platform/win/ResourceLoaderWin.cpp: (WebCore::globalInternetHandle): Move internetHandle and callbackHandle into file scope, and add this function to initialize them. (WebCore::logLastError): Add this debug logging function to give more readable WinInet error messages. (WebCore::ResourceLoaderWndProc): The most substantial change here is to allow redirects from POST to GET to function correctly. To do this we have to create a new HINTERNET for the GET. We also have to be sure not to try to read from our now-invalid handles after the redirect. (WebCore::transferJobStatusCallback): Rename timerId to jobId, since that's what it is. (WebCore::ResourceLoader::start): Call new static initializer, and pass flags to allow HTTP<->HTTPS redirects. Also change a few delete calls to kill().
6:54 AM Changeset in webkit [16805] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Small ResourceLoaderInternal tweak.

  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
6:52 AM Changeset in webkit [16804] by eseidel
  • 26 edits in trunk/WebCore

2006-10-05 Eric Seidel <eric@eseidel.com>

Reviewed by mjs.

More incremental KCanvas cleanup and optimization.
Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
Optimized dash array usage to not malloc.
Also removed un-needed KSVGRenderingStyle includes.

  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerSolidQuartz::setup): (WebCore::KRenderingPaintServerSolidQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::setup): (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext):
  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):
  • ksvg2/misc/KCanvasRenderingStyle.h:
6:15 AM Changeset in webkit [16803] by mjs
  • 13 edits in trunk/WebCore

Reviewed by Adam.

  • changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

  • bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • loader/icon/IconLoader.cpp: (IconLoader::IconLoader): (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • platform/ResourceLoader.cpp: (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::kill):
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
  • xml/xmlhttprequest.h:
5:59 AM Changeset in webkit [16802] by eseidel
  • 5 edits in trunk/WebCore

2006-10-05 Eric Seidel <eric@eseidel.com>

Reviewed by mjs.

Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
http://bugs.webkit.org/show_bug.cgi?id=11163


No SVG performance tests yet.

  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
5:51 AM Changeset in webkit [22302] by mjs
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

  • changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

In addition, keep it ref'd across all of ResourceLoaderWndProc
to avoid sending messages to jobs that get deleted partway.

This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::start):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop):
  • plugins/win/PluginStreamWin.h:

WebKitWin:

Reviewed by Adam.

  • changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

In addition, keep it ref'd across all of ResourceLoaderWndProc
to avoid sending messages to jobs that get deleted partway.

This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com

  • WebFrame.cpp: (WebFrame::loadDataSource):
2:03 AM Changeset in webkit [22301] by hyatt
  • 7 edits in branches/WindowsMerge

Make key events get delivered properly to iframes and frames.

1:58 AM Changeset in webkit [16801] by hyatt
  • 4 edits in trunk/WebCore

Widget focusability work.

Oct 4, 2006:

9:58 PM Changeset in webkit [16800] by andersca
  • 2 edits in trunk/LayoutTests

2006-10-04 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

  • fast/frames/frame-src-attribute-expected.txt: Update test result.
8:08 PM Changeset in webkit [16799] by aroben
  • 4 edits in trunk/WebCore

Reviewed by Maciej and Tim H.

Copy some WebKit frame lifetime logic into WebCore -- just a step
along the path to frame lifetime being handled completely in WebCore.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView): Move platform-independent parts of this method into Frame.
  • page/Frame.cpp: (WebCore::Frame::setView): Adding platform-independent parts of FrameMac::setView (WebCore::Frame::detachChildren): New method to accomplish what -[WebFrameBridge _detachChildren] currently does. (WebCore::Frame::clear): Call detachChildren
  • page/Frame.h: Add declaration for detachChildren
8:06 PM Changeset in webkit [22300] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej and Tim H.

Fixes <rdar://problem/4760991>
Flash content doesn't go away when navigating to a new page

Actually destroy subframes when detaching.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::frameDetached):
  • bridge/win/FrameWin.h:
7:02 PM Changeset in webkit [22299] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.


<rdar://problem/4762998>
REGRESSION: dragging to select text does not work


  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Set the correct button for WM_MOUSEMOVE events.
6:42 PM Changeset in webkit [16798] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Removed an unnecessary assert that was stopping many pages. tm_gmtoff was not set for UTC time in mozilla but is always set for us.
  • kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::msToTM):
  • kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime):
6:07 PM Changeset in webkit [16797] by ggaren
  • 2 edits in trunk/JavaScriptCore

Patch by Darin and me, reviewed by Maciej.

Fixed <rdar://problem/4518397> REGRESSION(?): Oft-seen but unrepro crash

in JavaScript garbage collection (KJS::Collector::collect())

<rdar://problem/4752492> Crash in KJS::collect


The issue here was allocating one garbage-collected object in the midst
of allocating a second garbage-collected object. In such a case, the
zeroIfFree word lies.

  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::collect):
5:21 PM Changeset in webkit [16796] by bdash
  • 4 edits in trunk/WebKitTools

2006-10-04 Mark Rowe <bdash@webkit.org>

Reviewed by Stephanie.

Switch the Qt buildbot to the standard set of build steps.
Have JavaScriptCoreTest check the output of run-javascriptcore-tests to
see if any regressions were spotted, and fail the test if so.

  • BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
5:19 PM Changeset in webkit [16795] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Layout test fix
  • kjs/DateMath.cpp: (KJS::dateToDayInYear): accept and correctly handle negative months
4:30 PM Changeset in webkit [22298] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

rdar://problem/4757081
Crashes/hangs when using Flash 8 plugin (Flash 9 works MUCH better)


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Encode javascript URLs before passing them to the plugin.
4:16 PM Changeset in webkit [16794] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::setRequestHeader): removed exception set when the request is not open yet
3:57 PM Changeset in webkit [16793] by kmccullo
  • 2 edits in trunk/JavaScriptCore

build fix

  • kjs/DateMath.cpp: (KJS::dateToDayInYear):
3:27 PM Changeset in webkit [16792] by brmorris
  • 24 edits
    10 adds in S60/branches/scriptable_plugins/JavaScriptCore

Landing initial version of scriptable plugins support (part 2 of 2).

3:26 PM Changeset in webkit [16791] by brmorris
  • 24 edits
    5 adds in S60/branches/scriptable_plugins

Landing scriptable plugins support (part 1 of 2).

3:25 PM Changeset in webkit [16790] by bdash
  • 2 edits in trunk/JavaScriptCore

2006-10-05 Mark Rowe <bdash@webkit.org>

Reviewed by maculloch.

Gdk build fix.

  • JavaScriptCoreSources.bkl: Add DateMath.cpp to file list.
3:17 PM Changeset in webkit [16789] by brmorris
  • 1 copy in S60/branches/scriptable_plugins

New feature branch created from r16325.

3:14 PM Changeset in webkit [22297] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • Fix for <rdar://problem/4762933> When typing past the end of a text field, the field doesn't auto-scroll to display the active caret

Reveal the selection after inserting text.


  • WebView.cpp: (WebViewWndProc):
3:13 PM WikiRestructuredText edited by trac
(diff)
3:13 PM TracTicketsCustomFields edited by trac
(diff)
3:13 PM TracNotification edited by trac
(diff)
3:13 PM TracRepositoryAdmin created by trac
3:13 PM TracFastCgi edited by trac
(diff)
3:13 PM TracIni edited by trac
(diff)
3:13 PM TracPermissions edited by trac
(diff)
3:13 PM TracTickets edited by trac
(diff)
3:13 PM TracUpgrade edited by trac
(diff)
3:13 PM TracWiki edited by trac
(diff)
3:13 PM TracImport edited by trac
(diff)
3:13 PM TracRoadmap edited by trac
(diff)
3:13 PM SandBox edited by trac
(diff)
3:13 PM TracReports edited by trac
(diff)
3:13 PM WikiMacros edited by trac
(diff)
3:13 PM TracInterfaceCustomization edited by trac
(diff)
3:13 PM TracModPython edited by trac
(diff)
3:13 PM TracFineGrainedPermissions edited by trac
(diff)
3:13 PM TracSyntaxColoring edited by trac
(diff)
3:13 PM TracSupport edited by trac
(diff)
3:13 PM TracUnicode edited by trac
(diff)
3:13 PM TracSearch edited by trac
(diff)
3:13 PM TracTimeline edited by trac
(diff)
3:13 PM InterTrac edited by trac
(diff)
3:13 PM TracQuery edited by trac
(diff)
3:13 PM TracLogging edited by trac
(diff)
3:13 PM TracBrowser edited by trac
(diff)
3:13 PM PageTemplates edited by trac
(diff)
3:13 PM WikiProcessors edited by trac
(diff)
3:13 PM TracLinks edited by trac
(diff)
3:13 PM TracEnvironment edited by trac
(diff)
3:13 PM TracStandalone edited by trac
(diff)
3:13 PM TracModWSGI created by trac
3:13 PM WikiDeletePage edited by trac
(diff)
3:13 PM WikiHtml edited by trac
(diff)
3:13 PM TracInstall edited by trac
(diff)
3:13 PM TracCgi edited by trac
(diff)
3:13 PM TracPlugins edited by trac
(diff)
3:13 PM TracRevisionLog edited by trac
(diff)
3:13 PM TracChangeset edited by trac
(diff)
3:13 PM WikiFormatting edited by trac
(diff)
3:13 PM TracWorkflow edited by trac
(diff)
3:13 PM TracAdmin edited by trac
(diff)
3:13 PM TracNavigation edited by trac
(diff)
3:13 PM TracGuide edited by trac
(diff)
3:13 PM InterWiki edited by trac
(diff)
3:13 PM TracBackup edited by trac
(diff)
3:13 PM CamelCase edited by trac
(diff)
3:13 PM WikiPageNames edited by trac
(diff)
3:13 PM TracRss edited by trac
(diff)
3:13 PM WikiRestructuredTextLinks edited by trac
(diff)
3:13 PM TracAccessibility edited by trac
(diff)
2:27 PM Changeset in webkit [16788] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by aroben

  • build fix
2:11 PM Changeset in webkit [16787] by bdash
  • 2 edits in trunk/JavaScriptCore

2006-10-04 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Mitz.

Fix Qt/Linux build by adding DateMath.cpp to compilation.

  • CMakeLists.txt: Also replace tabs with spaces.
2:08 PM Changeset in webkit [16786] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by DethBakin.

  • Apparently the build bot uses an older version of XCode which warns about conversions and the newest version does not. I hope this fixes the build but I cann't be sure on my system.
  • kjs/DateMath.cpp: (KJS::msToYear): (KJS::dayInYear): (KJS::dateToDayInYear):
1:44 PM Changeset in webkit [16785] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Mitz Pettel!

Bug 10708: [Drosera] Make the console input plaintext-only
http://bugs.webkit.org/show_bug.cgi?id=10708

Change the console input -webkit-user-modify property to
read-write-plaintext-only.

  • Drosera/console.css:
1:40 PM Changeset in webkit [22296] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • platform/win/NotImplemented.h: Changed implementation to use Assertions.h. Also fixed both macros to be single-statement macros.
1:37 PM Changeset in webkit [16784] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 10473: [Drosera] Overlapping text in JavaScript Console
http://bugs.webkit.org/show_bug.cgi?id=10473

Using min-height instead of height to avoid overlapping text.

  • ChangeLog:
  • Drosera/console.css:
1:35 PM Changeset in webkit [16783] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • wtf/Assertions.cpp: Changed assertion formatting to omit the "======" lines so you can see more assertions in less space. Also improved format of file/line information so it works with more development environments.
1:34 PM Changeset in webkit [16782] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • wtf/Assertions.cpp: Changed assertion formatting to omit the "======" lines so you can see more assertions in less space. Also improved format of file/line information so it works with more development environments.
11:37 AM Changeset in webkit [16781] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Added a bash-style command history.

  • Drosera/console.js:
11:36 AM Changeset in webkit [16780] by kmccullo
  • 6 edits
    2 adds in trunk/JavaScriptCore

Reviewed by GGaren

  • This is a big makeover for our Date implemenetation. This solves many platform specific issues, specifically dates before 1970, and simplifies some ugly code. The purpose of this was to get us to pass many of the JavaScriptCore tests on windows.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/DateMath.cpp: Added. (KJS::): (KJS::daysInYear): (KJS::daysFrom1970ToYear): (KJS::msFrom1970ToYear): (KJS::msToDays): (KJS::msToYear): (KJS::isLeapYear): (KJS::isInLeapYear): (KJS::dayInYear): (KJS::msToMilliseconds): (KJS::msToWeekDay): (KJS::msToSeconds): (KJS::msToMinutes): (KJS::msToHours): (KJS::msToMonth): (KJS::msToDayInMonth): (KJS::monthToDayInYear): (KJS::timeToMseconds): (KJS::dateToDayInYear): (KJS::equivalentYearForDST): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::localTimeToUTC): (KJS::UTCToLocalTime): (KJS::dateToMseconds): (KJS::msToTM): (KJS::isDST):
  • kjs/DateMath.h: Added. (KJS::):
  • kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
  • kjs/testkjs.cpp:
  • os-win32/stdint.h:
11:34 AM Changeset in webkit [22295] by darin
  • 7 edits
    2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

  • fix <rdar://problem/4764253> frame targeting not implemented.
  • bridge/win/FrameWin.h: Added new window boolean to openURL. Also changed type from DeprecatedString to String.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Added logic to do frame targeting.
  • platform/win/BString.h: Added. Convenience for working with BSTR and handling allocation/free.
  • platform/win/BString.cpp: Added.
  • WebCore.vcproj/WebCore.vcproj: Added new files.

WebKitWin:

Reviewed by Adam.

  • fix <rdar://problem/4764253> frame targeting not implemented.
  • WebFrame.h: Added newWindow parameter to openURL and changed the URL parameter to a String.
  • WebFrame.cpp: (WebFrame::openURL): Changed code to use BString to convert the String to a BSTR. Also respect the newWindow parameter and changed the new window code slightly, adding a FIXME.
11:04 AM Changeset in webkit [16779] by andersca
  • 2 edits in trunk/WebCore

2006-10-04 Anders Carlsson <acarlsson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4654328>
Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
1:43 AM Changeset in webkit [16778] by hyatt
  • 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:39 AM Changeset in webkit [16777] by hyatt
  • 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:26 AM Changeset in webkit [16776] by hyatt
  • 2 edits in trunk/WebCore/platform

Fix more win32 and qt bustage.

1:21 AM Changeset in webkit [16775] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix more win32 bustage.

1:19 AM Changeset in webkit [16774] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix more win32 bustage.

1:11 AM Changeset in webkit [16773] by hyatt
  • 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:10 AM Changeset in webkit [16772] by hyatt
  • 1 edit in trunk/WebCore/platform/qt/TemporaryLinkStubs.cpp

Fix Qt bustage.

1:09 AM Changeset in webkit [16771] by hyatt
  • 1 edit in trunk/WebCore/platform/gdk/WidgetGdk.cpp

Fix Gdk bustage.

1:06 AM Changeset in webkit [16770] by hyatt
  • 2 edits in trunk/WebCore/platform/qt

Fix Qt bustage.

1:05 AM Changeset in webkit [16769] by hyatt
  • 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

12:53 AM Changeset in webkit [16768] by hyatt
  • 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

12:52 AM Changeset in webkit [16767] by hyatt
  • 2 edits in trunk/WebCore/platform/win

Fix Win32 bustage.

12:22 AM Changeset in webkit [22294] by hyatt
  • 4 edits in branches/WindowsMerge/WebKitWin

Fix the textfield caret by not doing layouts every time we paint.

Note: See TracTimeline for information about the timeline view.