⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 7, 2006:

11:15 PM Changeset in webkit [22337] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Add code to paint the Windows Classic/2000 look for scrollbars.

6:08 PM Changeset in webkit [16886] by andersca
  • 2 edits in trunk/WebCore

2006-10-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.

  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
5:44 PM Changeset in webkit [16885] by andersca
  • 18 edits in trunk/WebCore

2006-10-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Convert a bunch of RefPtr<StringImpl> to String.


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::didTellBridgeAboutLoad): (WebCore::FrameMac::haveToldBridgeAboutLoad):
  • dom/BeforeUnloadEvent.cpp: (WebCore::BeforeUnloadEvent::storeResult):
  • dom/BeforeUnloadEvent.h: (WebCore::BeforeUnloadEvent::result):
  • dom/Document.cpp: (WebCore::Document::createEntityReference):
  • dom/Entity.cpp: (WebCore::Entity::Entity): (WebCore::Entity::nodeName): (WebCore::Entity::toString):
  • dom/Entity.h: (WebCore::Entity::publicId): (WebCore::Entity::systemId): (WebCore::Entity::notationName):
  • dom/EntityReference.cpp: (WebCore::EntityReference::EntityReference): (WebCore::EntityReference::nodeName): (WebCore::EntityReference::cloneNode): (WebCore::EntityReference::toString):
  • dom/EntityReference.h:
  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::KeyboardEvent): (WebCore::KeyboardEvent::initKeyboardEvent):
  • dom/KeyboardEvent.h: (WebCore::KeyboardEvent::keyIdentifier):
  • dom/MutationEvent.cpp: (WebCore::MutationEvent::MutationEvent): (WebCore::MutationEvent::initMutationEvent):
  • dom/MutationEvent.h: (WebCore::MutationEvent::prevValue): (WebCore::MutationEvent::newValue): (WebCore::MutationEvent::attrName):
  • dom/Notation.cpp: (WebCore::Notation::Notation): (WebCore::Notation::nodeName):
  • dom/Notation.h: (WebCore::Notation::publicId): (WebCore::Notation::systemId):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::setData): (WebCore::ProcessingInstruction::nodeName): (WebCore::ProcessingInstruction::nodeValue): (WebCore::ProcessingInstruction::cloneNode): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::toString):
  • dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::target): (WebCore::ProcessingInstruction::data): (WebCore::ProcessingInstruction::localHref):
3:49 PM Changeset in webkit [22336] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Make sure frames honor scrolling modes and margins.

12:22 PM Changeset in webkit [22335] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Merge of OpenSource r16884
​http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.

  • WebFrame.cpp: (WebFrame::receivedResponse): (WebFrame::receivedAllData):
11:53 AM Changeset in webkit [16884] by aroben
  • 2 edits in trunk/WebKit

Reviewed/landed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.

  • COM/WebFrame.cpp: (WebFrame::receivedResponse): (WebFrame::receivedAllData):
11:42 AM Changeset in webkit [22334] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix for failed ASSERT on iBench.

  • WebFrame.cpp: (WebFrame::receivedAllData): Be a bit more lenient about what ResourceLoader has called WebFrame::receivedAllData
10:24 AM Changeset in webkit [16883] by weinig
  • 24 edits in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11206
10 more SVG Objective-C auto-generated bindings

  • Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement, DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
  • Auto-generate the text method for DOMRange.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRGBColor.mm:
  • bindings/objc/DOMSVG.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Range.idl:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterElement.idl:
  • ksvg2/svg/SVGForeignObjectElement.idl:
  • ksvg2/svg/SVGGElement.idl:
  • ksvg2/svg/SVGGradientElement.idl:
  • ksvg2/svg/SVGImageElement.idl:
  • ksvg2/svg/SVGLineElement.idl:
  • ksvg2/svg/SVGLinearGradientElement.idl:
  • ksvg2/svg/SVGMarkerElement.idl:
  • ksvg2/svg/SVGMaskElement.idl:
  • ksvg2/svg/SVGPaint.idl:
5:58 AM Changeset in webkit [16882] by weinig
  • 14 edits
    1 move
    1 add
    3 deletes in trunk

WebCore:

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces

  • Fully auto-generate DOMAbstractView and DOMRange.
  • Auto-generate just the interface for DOMRGBColor.
  • Add DOMRanges.h as the new top level file for Ranges module.
  • Add DOMRanges.h and DOMXPath.h to DOM.mm
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.h:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMAbstractView.h: Removed.
  • bindings/objc/DOMAbstractView.mm: Removed.
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRGBColor.h: Removed.
  • bindings/objc/DOMRGBColor.mm:
  • bindings/objc/DOMRange.h: Removed.
  • bindings/objc/DOMRanges.h: Added.
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/RGBColor.idl:
  • dom/Range.idl:
  • page/AbstractView.idl: Added.

WebKit:

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces

  • MigrateHeaders.make:
5:39 AM Changeset in webkit [16881] by bdash
  • 3 edits
    4 adds in trunk

2006-10-07 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Eric.

Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10837

Return null when there is no frame. This matches Firefox.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty):

2006-10-07 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Eric.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit

  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum: Added.
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png: Added.
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt: Added.
  • fast/dom/HTMLDocument/frameless-location-bugzilla10837.html: Added.
5:04 AM Changeset in webkit [16880] by hyatt
  • 2 edits in trunk/WebCore/platform

Fix win32 and qt bustage.

4:41 AM Changeset in webkit [16879] by hyatt
  • 5 edits in trunk/WebCore

Implement scroll corner painting (a white rect fill) for overflow areas to cover up
scrollbar joins properly.

Refactor painting of scrollbars and resizers into common functions. Eliminate the
extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.

Reviewed by mitz

  • page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent):
  • platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayer.h:
3:42 AM Changeset in webkit [16878] by bdash
  • 2 edits in trunk/WebKit

2006-10-07 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Fix memory leak from -[WebDocumentLoadState setTitle:].

  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]): Ensure 'trimmed' is released even when length is zero, and untangle the confusing logic around this case.
2:32 AM Changeset in webkit [16877] by bdash
  • 6 edits in trunk/WebCore

2006-10-07 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
matching recent ResourceLoader changes.

  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/PlatformScrollBar.h:
  • platform/gdk/ResourceLoaderCurl.cpp: (WebCore::ResourceLoader::start):
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::addChild): (ScrollView::updateScrollbars): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion):
1:20 AM Changeset in webkit [22333] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Fix build bustage from earlier checkin.

1:18 AM Changeset in webkit [22332] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix resizer coordinate space error.

Oct 6, 2006:

11:57 PM Changeset in webkit [22331] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Better fix for scrollbars coming and going affecting plugin clip.

11:32 PM Changeset in webkit [22330] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Update plugin clipping when scrollbars come/go.

11:06 PM Changeset in webkit [16876] by hyatt
  • 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

11:04 PM Changeset in webkit [16875] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

11:03 PM Changeset in webkit [16874] by hyatt
  • 1 edit in trunk/WebCore/platform/mac/ScrollViewMac.mm

Remove x/y from the log message on debug Mac builds.

10:56 PM Changeset in webkit [22329] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Improve performance of plugin clipping when scrolling.

10:55 PM Changeset in webkit [16873] by beidson
  • 16 edits in trunk/WebKit

Reviewed by Darin

Refactored a whole bunch of WebFramePrivate.h SPI to WebFrameInternal

  • DefaultDelegates/WebDefaultContextMenuDelegate.m:
  • History/WebHistoryItem.m:
  • Loader/WebFrameLoader.h:
  • Misc/WebCoreStatistics.m:
  • Misc/WebElementDictionary.m:
  • Plugins/WebNetscapePluginEmbeddedView.m:
  • Plugins/WebPluginController.m:
  • WebCoreSupport/WebViewFactory.m:
  • WebView/WebArchiver.m:
  • WebView/WebDataSource.m:
  • WebView/WebFrame.m: (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame _isFrameSet]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebHTMLRepresentation.m:
  • WebView/WebScriptDebugDelegate.m:
10:43 PM Changeset in webkit [22328] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Implement clipping of plugins on Win32.

10:32 PM Changeset in webkit [16872] by hyatt
  • 10 edits in trunk/WebCore

Add a new method for obtaining accurate window-level clip rectangles. Can be used even by windowed plugins to clip properly.

8:31 PM Changeset in webkit [16871] by bdash
  • 3 edits
    3 adds in trunk/WebKitTools

2006-10-06 David Smith <​catfish.man@gmail.com>

Reviewed by Timothy.

Bug 9665: [Drosera] Conditional breakpoints. ​http://bugs.webkit.org/show_bug.cgi?id=9665

  • Drosera/Drosera.xcodeproj/project.pbxproj: Added new files
  • Drosera/breakpointEditor.css: Added.
  • Drosera/breakpointEditor.html: Added.
  • Drosera/breakpointEditor.js: Added.
  • Drosera/debugger.js: Added conditional breakpoint support, and the ability to open the breakpoint editor window on option-clicking a breakpoint.
6:57 PM Changeset in webkit [22327] by ggaren
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL


The issue was a resource loader making a callback to a
frame after the frame had been destroyed. This doesn't happen on Mac
because Mac WebKit cancels all loads before tearing down frames.


The solution is to add a callback to Win WebKit to allow a frame
to cancel its main resource load. This is a temporary work-around.
It is temporary because it doesn't address pending subresource loads.
The long-term solution we anticipate is to have a legitimate loader
inside WebCore.

  • ChangeLog:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
  • bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Adam Roben, esq.


Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL


The issue was a resource loader making a callback to a
frame after the frame had been destroyed. This doesn't happen on Mac
because Mac WebKit cancels all loads before tearing down frames.


The solution is to add a callback to Win WebKit to allow a frame
to cancel its main resource load. This is a temporary work-around.
It is temporary because it doesn't address pending subresource loads.
The long-term solution we anticipate is to have a legitimate loader
inside WebCore.

  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::stopMainResourceLoad): (WebFrame::receivedAllData):
  • WebFrame.h:
5:42 PM Changeset in webkit [16870] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Darin.


  • Move all delegate dispatching code out of WebDataSource.
  • Loader/WebFrameLoader.m: (-[WebFrameLoader startLoading]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
  • WebView/WebDataSource.m: (-[WebDataSource _setLoadingFromPageCache:]): (-[WebDataSource _stopLoadingWithError:]):
  • WebView/WebDataSourceInternal.h:
5:36 PM Changeset in webkit [16869] by darin
  • 6 edits in trunk/WebKit

Reviewed by Maciej.

  • moved firstLayoutDone BOOL from WebFrame to WebFrameLoader
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader firstLayoutDone]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didFirstLayout]):
  • WebView/WebFrame.m: (-[WebFrame _firstLayoutDone]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]):
  • WebView/WebFrameInternal.h:
5:19 PM Changeset in webkit [16868] by darin
  • 8 edits in trunk/WebKit

Reviewed by Maciej.

  • moved more data and the corresponding code from WebFrame to WebFrameLoader
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader cannotShowMIMETypeForURL:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader _continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]): (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrameLoader delegateIsHandlingProvisionalLoadError]): (-[WebFrameLoader setDelegateIsHandlingProvisionalLoadError:]):
  • Loader/WebFrameLoaderClient.h:
  • WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFramePrivate dealloc]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _loadRequest:inFrameNamed:]): (-[WebFrame stopLoading]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _quickRedirectComing]): (-[WebFrame _provisionalItemIsTarget]): (-[WebFrame _loadProvisionalItemFromPageCache]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebKit.xcodeproj/project.pbxproj:
4:00 PM Changeset in webkit [22326] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Use a better versioning scheme.


Out version #s for Boomer are the same as the last Mac
submission + the addition of "b".


This first versioned submission is 521.28b

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Use a better versioning scheme.


Out version #s for Boomer are the same as the last Mac
submission + the addition of "b".


This first versioned submission is 521.28b

  • WebKit.vcproj/WebKit.rc:
3:49 PM Changeset in webkit [16867] by mjs
  • 2 edits in trunk/WebKit

Rubber stamped by Darin.


  • removed includes of unused headers.
  • WebView/WebDataSource.m:
3:42 PM Changeset in webkit [16866] by mjs
  • 3 edits in trunk/WebKit

Not reviewed.


  • fix build breakage
  • Loader/WebFrameLoader.m: (-[WebFrameLoader willChangeTitleForDocumentLoadState:]): (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
3:38 PM Changeset in webkit [16865] by mjs
  • 11 edits in trunk/WebKit

Reviewed by Darin.


  • move remaining movable WebDataSource fields to WebDocumentLoadState
  • Loader/WebDocumentLoadState.h:
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState isLoadingInAPISense]): (-[WebDocumentLoadState addResponse:]): (-[WebDocumentLoadState stopRecordingResponses]): (-[WebDocumentLoadState title]): (-[WebDocumentLoadState setLastCheckedRequest:]): (-[WebDocumentLoadState lastCheckedRequest]): (-[WebDocumentLoadState triggeringAction]): (-[WebDocumentLoadState setTriggeringAction:]): (-[WebDocumentLoadState responses]): (-[WebDocumentLoadState setOverrideEncoding:]): (-[WebDocumentLoadState overrideEncoding]): (-[WebDocumentLoadState setTitle:]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader willChangeTitleForDocumentLoadState:]): (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]):
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource textEncodingName]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _addChild:]): (-[WebFrame _loadDataSource:withLoadType:formState:]):
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
  • WebView/WebView.m: (-[WebView _mainFrameOverrideEncoding]):
3:32 PM Changeset in webkit [16864] by thatcher
  • 1 copy in tags/Safari-521.28b

New tag.

3:20 PM Changeset in webkit [22325] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Bump version number.

  • WebKit.vcproj/WebKit.rc:

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Bump version number.

2:52 PM Changeset in webkit [16863] by darin
  • 6 edits in trunk/WebKit

Reviewed by Maciej.

  • moved loadType into WebFrameLoader
  • WebView/WebFramePrivate.h: Removed _setLoadType, but not _loadType because it's currently used by Safari.
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader loadType]): (-[WebFrameLoader setLoadType:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge isLoadTypeReload]):
  • WebView/WebFrame.m: (-[WebFrame _loadType]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _didFirstLayout]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame loadRequest:]):
2:34 PM Changeset in webkit [22324] by sfalken
  • 7 edits in branches/WindowsMerge

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam, Lou.

<rdar://4754295> Corrupt history.plist = crash on startup


Fix improper CF usage that likely led to retain/release imbalances.

Resizer fixes.
We now properly invalidate and draw overlapping contents or opaque.
Fix capture state after resize by posting a mouse up to balance the one that gets eaten (Thanks, Lou!)

2:25 PM Changeset in webkit [16862] by sfalken
  • 3 edits in trunk/WebCore

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Add another method we'll need for scrollbar dodging

  • platform/ScrollView.h:
  • platform/win/TemporaryLinkStubs.cpp: (ScrollView::resizerOverlapsContent):
2:25 PM Changeset in webkit [16861] by darin
  • 6 edits
    1 add in trunk/WebKit

Reviewed by Maciej.

  • added WebFrameLoaderClient protocol -- to be used to make WebFrameLoader forget all about WebFrame
  • Loader/WebDocumentLoadState.h: Added comment about Maciej's planned renaming here.
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: Renamed webFrame to client and added the new protocol. Eventually we'll be removing the dependency on WebFrame entirely.
  • WebView/WebFrame.m: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Update to call the method by its new name.
  • Loader/WebFrameLoaderClient.h: Added.
  • WebKit.xcodeproj/project.pbxproj: Updated for new file, sorted things.
2:13 PM Changeset in webkit [16860] by weinig
  • 14 edits
    9 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11191
Auto-generate the interfaces even for Objective-C DOM
bindings that need custom implementations

  • Fully auto-generate DOMEventTarget, DOMNodeFilter and DOMHTMLOptionElement.
  • Auto-generate just the interface for DOMHTMLAppletElement, DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect using the new IDL property ObjCCustomImplementation.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMEventTarget.h: Removed.
  • bindings/objc/DOMHTMLAppletElement.h: Removed.
  • bindings/objc/DOMHTMLEmbedElement.h: Removed.
  • bindings/objc/DOMHTMLOptionElement.h: Removed.
  • bindings/objc/DOMHTMLOptionElement.mm: Removed.
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMNodeFilter.h: Removed.
  • bindings/objc/DOMSVGNumber.h: Removed.
  • bindings/objc/DOMSVGPoint.h: Removed.
  • bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint matrixTransform:]):
  • bindings/objc/DOMSVGRect.h: Removed.
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/EventTarget.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLOptionElement.idl:
  • ksvg2/svg/SVGNumber.idl:
  • ksvg2/svg/SVGPoint.idl:
  • ksvg2/svg/SVGRect.idl:
2:11 PM Changeset in webkit [16859] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.


  • segregate WebFrame methods into ones that should be moved into WebFrameLoader and ones that don't need to


Also removed useless WebFrameLoader part

  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]):
2:04 PM Changeset in webkit [22323] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add (commented out) WMP plugin check.
1:53 PM Changeset in webkit [22322] by andersca
  • 2 edits
    5 adds in branches/WindowsMerge/WebKitTools

2006-10-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Land new version of DumpRenderTree that uses the WebKit APIs.


1:48 PM Changeset in webkit [16858] by thatcher
  • 4 edits in trunk

WebCore:

Reviewed by Tim H.

Make Qt/Linux compile again completly.

  • platform/qt/WidgetQt.cpp: (WebCore::Widget::removeFromParent):

WebKitTools:

Reviewed by Tim H.

Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ changes.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
1:42 PM Changeset in webkit [16857] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Anders.


  • moved more data from WebDataSource to WebDocumentLoadState
  • Loader/WebDocumentLoadState.h:
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState commitLoadWithData:]): (-[WebDocumentLoadState prepareForLoadStart]): (-[WebDocumentLoadState loadingStartedTime]): (-[WebDocumentLoadState setIsClientRedirect:]): (-[WebDocumentLoadState isClientRedirect]): (-[WebDocumentLoadState setPrimaryLoadComplete:]): (-[WebDocumentLoadState isLoadingInAPISense]):
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader subframeIsLoading]):
  • WebView/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): (-[WebDataSource _startLoading]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource isLoading]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _opened]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
1:36 PM Changeset in webkit [16856] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Tim H.

Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.

  • platform/qt/PlatformScrollBar.h:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::scrollbarUnderMouse):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (FrameView::passMousePressEventToScrollbar):
11:26 AM Changeset in webkit [22321] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Brady and Geoff.

<rdar://problems/4769023>
Crash on cnettv.com - PluginStreamWin::receivedResponse


  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): If the Content-Type header is missing, try to figure o ut the content type from the file extension. Failing that, just use "application/octet-stream".
11:16 AM Changeset in webkit [16855] by kmccullo
  • 4 edits in trunk/JavaScriptCore

Reviewed by Brady.

DST and TimeZones were wrong in some cases, specifically on some of the dates where DST changes.

  • kjs/DateMath.cpp: (KJS::equivalentYearForDST): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::dateToMseconds): (KJS::msToTM):
  • kjs/DateMath.h:
  • kjs/date_object.cpp: (KJS::gmtoffset):
11:03 AM Changeset in webkit [16854] by brmorris
  • 4 deletes in S60/branches/scriptable_plugins/WebCore

Remove some tmp files from revision control.

10:55 AM Changeset in webkit [16853] by ap
  • 2 edits in trunk/WebKit

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11183
REGRESSION: Safari loads error pages unstyled

  • WebView/WebFrame.m: (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Use utf-8 encoding instead of the string's "fastest" encoding.
7:52 AM Changeset in webkit [16852] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-10-06 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun Zhang
DESC: Match page overview touch behavior to UI spec
​http://bugs.webkit.org/show_bug.cgi?id=11179

  • BrowserView/inc/PointerEventHandler.h:
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL): (CPointerEventHandler::AutoScroll):
5:28 AM Changeset in webkit [16851] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2006-10-05 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: Prevent multiple form submission
​http://bugs.webkit.org/show_bug.cgi?id=11170


merged from trunk r16849


WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm): (KWQKHTMLPart::KeyEvent): (KWQKHTMLPart::MouseDown): (KWQKHTMLPart::prepareForUserAction):
  • kwq/KWQKHTMLPart.h:
5:25 AM Changeset in webkit [16850] by weinig
  • 36 edits
    6 adds in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11177
Another round of Objective-C SVG DOM bindings auto-generation

  • Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement, DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, DOMSVGFETileElement, DOMSVGFETurbulenceElement, DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.
  • Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint and DOMSVGRect.
  • IDL clean up.
  • Make numOctaves in SVGFETurbulenceElement use a long instead of an int in it's macro declaration and definition.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMSVG.h:
  • bindings/objc/DOMSVGNumber.h: Added.
  • bindings/objc/DOMSVGNumber.mm: Added. (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]):
  • bindings/objc/DOMSVGPoint.h: Added.
  • bindings/objc/DOMSVGPoint.mm: Added. (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]):
  • bindings/objc/DOMSVGRect.h: Added.
  • bindings/objc/DOMSVGRect.mm: Added. (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • ksvg2/svg/SVGAnimatedNumberList.idl:
  • ksvg2/svg/SVGAnimatedRect.idl:
  • ksvg2/svg/SVGComponentTransferFunctionElement.idl:
  • ksvg2/svg/SVGCursorElement.idl:
  • ksvg2/svg/SVGFEBlendElement.idl:
  • ksvg2/svg/SVGFEColorMatrixElement.idl:
  • ksvg2/svg/SVGFEComponentTransferElement.idl:
  • ksvg2/svg/SVGFECompositeElement.idl:
  • ksvg2/svg/SVGFEDiffuseLightingElement.idl:
  • ksvg2/svg/SVGFEDisplacementMapElement.idl:
  • ksvg2/svg/SVGFEDistantLightElement.idl:
  • ksvg2/svg/SVGFEFloodElement.idl:
  • ksvg2/svg/SVGFEFuncAElement.idl:
  • ksvg2/svg/SVGFEFuncBElement.idl:
  • ksvg2/svg/SVGFEFuncGElement.idl:
  • ksvg2/svg/SVGFEFuncRElement.idl:
  • ksvg2/svg/SVGFEGaussianBlurElement.idl:
  • ksvg2/svg/SVGFEImageElement.idl:
  • ksvg2/svg/SVGFEMergeElement.idl:
  • ksvg2/svg/SVGFEMergeNodeElement.idl:
  • ksvg2/svg/SVGFEOffsetElement.idl:
  • ksvg2/svg/SVGFEPointLightElement.idl:
  • ksvg2/svg/SVGFESpecularLightingElement.idl:
  • ksvg2/svg/SVGFESpotLightElement.idl:
  • ksvg2/svg/SVGFETileElement.idl:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.idl:
  • ksvg2/svg/SVGNumberList.idl:
5:21 AM Changeset in webkit [16849] by zbujtas
  • 3 edits in S60/trunk/WebCore

2006-10-05 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: Prevent multiple form submission
​http://bugs.webkit.org/show_bug.cgi?id=11170

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm): (KWQKHTMLPart::KeyEvent): (KWQKHTMLPart::MouseDown): (KWQKHTMLPart::prepareForUserAction):
  • kwq/KWQKHTMLPart.h:
4:18 AM Changeset in webkit [16848] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Adam.


  • fixed the following bugs:


​http://bugs.webkit.org/show_bug.cgi?id=11136
"REGRESSION: Safari snippet editor doesn't work"
​http://bugs.webkit.org/show_bug.cgi?id=11140
"REGRESSION: view source window blank"
​http://bugs.webkit.org/show_bug.cgi?id=11146
"REGRESSION: Instead of showing the error page, Safari opens its Resources folder in the Finder"


Possibly more.

  • Loader/WebDocumentLoadState.h:
  • Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState actualRequest]): New method.
  • WebView/WebDataSource.m: (-[WebDataSource _startLoading]): We need to make sure not to start loading the main resource with the fake external request for an applewebdata: request.
3:30 AM Changeset in webkit [16847] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

3:28 AM Changeset in webkit [16846] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

3:22 AM Changeset in webkit [16845] by hyatt
  • 5 edits in trunk/WebCore

Fix build bustage on many platforms by making sure the includes of ScrollBar stay the way they were.

3:18 AM Changeset in webkit [16844] by aroben
  • 3 edits in trunk/WebCore

Backing out my previous change.

  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize):
3:18 AM Changeset in webkit [22320] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix open source build bustage by moving windowResizerRect into ScrollViewWin.

3:17 AM Changeset in webkit [16843] by hyatt
  • 3 edits in trunk/WebCore

Fix build bustage like... everywhere.

3:06 AM Changeset in webkit [16842] by aroben
  • 3 edits in trunk/WebCore

Build fix.

  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp: (WebCore::FrameView::windowResizerRect):
3:01 AM Changeset in webkit [16841] by hyatt
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

2:48 AM Changeset in webkit [22319] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Some loader improvements, courtesy of Steve.

Functionally, the improvements are these:

  1. Support HTTP Authentication
  2. Respect WinInet errors better

There are also some general code cleanups, like extracting the creation
of an HTTP request into its own method.

  • platform/win/ResourceLoaderWin.cpp: Add dwError field to JobLoadStatus to store WinInet error codes. Also removed the globalInternetHandle() function as the global HINTERNET is now only needed within startHTTPRequest. (WebCore::ResourceLoaderWndProc): Respect error codes and add HTTP Authentication support. Also, process HTTP status codes as ints instead of strings. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): Cleanup m_formData (WebCore::transferJobStatusCallback): Cleanup the code, and set dwError. (WebCore::ResourceLoader::startHTTPRequest): New method to start a new HTTP request. (WebCore::ResourceLoader::start): Restructure code.
2:43 AM Changeset in webkit [16840] by aroben
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

More loader tweaks.

  • platform/ResourceLoader.h:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::newHTTPRequest):
2:16 AM Changeset in webkit [22318] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix cnn.com plugins. Fix a crash from not unparenting scrollbars of a scrollview in its destructor.

1:23 AM Changeset in webkit [22317] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix plugins being mispositioned on osnews.com

12:50 AM Changeset in webkit [22316] by sfalken
  • 12 edits in branches/WindowsMerge

2006-10-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Allow window to be resized via the gripper (bottom right rect adjacent to scrollbars).
Add a method to reset the candidate URLs when a page load completes.
Add implementations for resizer related UI delegate callbacks.
Move gripper drawing into DrawingUtilities.


2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Scrollbars now dodge resizing gripper.
Resizing gripper now paints via web ui delegate.
Debug vcproj fixes.
Fix redirects to search.com.
Add support for painting and cursor tracking of resizer.

  • Interfaces/IWebUIDelegatePrivate.idl: added webViewDrawResizer.
  • WebFrame.cpp: (WebFrame::paint): added gripper drawing code. (WebFrame::receivedResponse): tell the app when we commit a page load. (WebFrame::windowResizerRect): added. (WebFrame::paintGripper): added.
  • WebFrame.h: added windowResizerRect, paintGripper.
  • WebKit.vcproj/WebKit.vcproj: Link against debug libs, debug MSVC library in debug build.
  • WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebView::inResizer): (WebViewWndProc): (WebView::setUIDelegate):
  • WebView.h:

2006-10-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Scrollbars now dodge resizing gripper.

  • bridge/win/FrameViewWin.cpp: (WebCore::FrameView::windowResizerRect): added.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::windowResizerRect): added.
  • bridge/win/FrameWin.h:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): Scrollbars now dodge resizing gripper.
12:44 AM Changeset in webkit [16839] by sfalken
  • 7 edits in trunk/WebCore

2006-10-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Stub out some methods that we'll be able to use to dodge a window resizer.

  • bridge/win/FrameWin.h:
  • page/Frame.h: (WebCore::Frame::windowResizerRect):
  • page/FrameView.h:
  • platform/ScrollView.h: (WebCore::ScrollView::windowResizerRect):
  • platform/Widget.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameView::windowResizerRect): (Widget::setParent): (Widget::parent): (FrameWin::windowResizerRect):
Note: See TracTimeline for information about the timeline view.