Timeline

Oct 9, 2006:

11:51 PM Changeset in webkit [16961] by mjs

• 4 edits in trunk/WebKit

Reviewed by Anders.

• sever final WebFrame dependencies

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader checkLoadComplete]):

11:12 PM Changeset in webkit [16960] by mjs

• 6 edits in trunk/WebKit

Reviewed by Brady.

• convert more WebFrameLoader stuff to be independent of WebFrame

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader isHostedByObjectElement]): (-[WebFrameLoader isLoadingMainFrame]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader client]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebDataSource.m: (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
• WebView/WebFrame.m: (-[WebFrame _dispatchCreateWebViewWithRequest:]):

10:14 PM Changeset in webkit [16959] by mjs

• 6 edits in trunk/WebKit

Reviewed by Anders and Oliver.

• move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader loadRequest:]): (-[WebFrameLoader loadRequest:inFrameNamed:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _hasFrameView]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _didFinishLoad]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _provisionalLoadStarted]):
• WebView/WebFrameInternal.h:

9:04 PM Changeset in webkit [22345] by beidson

• 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve

<rdar://4721579> - WebPreferences for IconDatabase hooked up
This completes the above task by implementing the icon database location preference

• WebIconDatabase.cpp: (WebIconDatabase::init): Get the location from the prefs, fallback to the default via shell call
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::iconDatabaseLocation): (WebPreferences::setIconDatabaseLocation):

8:16 PM Changeset in webkit [16958] by mjs

• 1 edit
  2 adds in trunk/WebKit

Not reviewed, build fix.

• added forgotten files

• Loader/WebPolicyDecider.h: Added.
• Loader/WebPolicyDecider.m: Added. (-[WebPolicyDecider invalidate]):

7:41 PM Changeset in webkit [16957] by mjs

• 6 edits
  2 adds in trunk/WebKit

Reviewed by Brady.

• add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader cancelContentPolicy]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
• Loader/WebFrameLoaderClient.h:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebFrame.m: (-[WebFrame _createPolicyDeciderWithTarget:action:]): (decisionListener): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
• WebView/WebPolicyDeciderMac.h: Added.
• WebView/WebPolicyDeciderMac.m: Added. (-[WebPolicyDeciderMac initWithTarget:action:]): (-[WebPolicyDeciderMac dealloc]): (-[WebPolicyDeciderMac decisionListener]): (-[WebPolicyDeciderMac invalidate]):

7:10 PM Changeset in webkit [16956] by beidson

• 5 edits
  1 add in trunk/WebKit

Reviewed by John

​http://bugs.webkit.org/show_bug.cgi?id=11195
Added the WebIconDatabaseDelegate. This allows the ability to allow customization of
IconDatabase behavior in the future, starting now with the ability to override the
default icon fairly flexibly

• Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
• Misc/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase delegate]):
• Misc/WebIconDatabaseDelegate.h: Added.
• Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
• WebKit.xcodeproj/project.pbxproj:

6:52 PM Changeset in webkit [16955] by aroben

• 2 edits in trunk/WebCore

Backing out accidental commit.

• page/Frame.cpp: (WebCore::Frame::finishedParsing):

6:49 PM Changeset in webkit [16954] by aroben

• 11 edits in trunk/WebCore

Reviewed by Darin.

Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
this could cause recursive calls to the destructor. RefPtr now also
inherits from Noncopyable.

• dom/NodeFilter.h:
• dom/Traversal.h:
• page/DOMWindow.h:
• page/Frame.cpp: (WebCore::Frame::finishedParsing):
• page/Frame.h:
• page/Plugin.h:
• platform/FontFallbackList.h:
• platform/Icon.h:
• platform/Shared.h: (WebCore::Shared::Shared): (WebCore::Shared::ref): (WebCore::Shared::deref): (WebCore::Shared::hasOneRef): (WebCore::Shared::refCount):
• platform/StringImpl.h:

6:30 PM Changeset in webkit [16953] by darin

• 7 edits in trunk/WebKit

Reviewed by Maciej.

• eliminated uses of WebResource and WebView from WebFrameLoader

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]): (-[WebFrameLoader _canShowMIMEType:]): (-[WebFrameLoader _representationExistsForURLScheme:]): (-[WebFrameLoader _generatedMIMETypeForURLScheme:]): (-[WebFrameLoader loadDocumentLoader:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
• Loader/WebFrameLoaderClient.h:
• Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader loadWithRequestNow:]):
• WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame _canUseResourceForRequest:]): (-[WebFrame _canUseResourceWithResponse:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _setDefersCallbacks:]): (-[WebFrame _canHandleRequest:]): (-[WebFrame _canShowMIMEType:]): (-[WebFrame _representationExistsForURLScheme:]): (-[WebFrame _generatedMIMETypeForURLScheme:]): (-[WebFrame _elementForEvent:]):

6:09 PM Changeset in webkit [16952] by oliver

• 10 edits in trunk/WebCore

2006-10-09 Oliver Hunt <​ohunt@apple.com>

Reviewed by Anders.

Correcting ifdef's

• html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop):
• html/CanvasGradient.h:
• html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): (WebCore::CanvasPattern::~CanvasPattern):
• html/CanvasPattern.h:
• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
• html/CanvasRenderingContext2D.h:
• html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
• html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext):
• html/HTMLCanvasElement.h:

6:04 PM Changeset in webkit [16951] by mjs

• 3 edits in trunk/WebKit

Reviewed by Darin.

• do all the stuff that setting the referrer should

• Loader/WebFrameLoader.m: (setHTTPReferrer): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
• WebKit.xcodeproj/project.pbxproj:

5:53 PM Changeset in webkit [16950] by mjs

• 1 edit
  3 adds in trunk/LayoutTests

Reviewed by Darin.

• test case that ensures Referer[sic] header is sent

• http/tests/misc/referrer-expected.txt: Added.
• http/tests/misc/referrer.html: Added.
• http/tests/misc/resources/referrer-result.php: Added.

5:38 PM Changeset in webkit [22344] by andersca

• 8 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Fix <rdar://problem/4756255>
PDF/Acrobat Reader plugin don't work

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): Implement these, getting the instance from the plugin view.

• platform/win/TemporaryLinkStubs.cpp: Remove functions that are now implemented.

• plugins/win/PlugInInfoStoreWin.cpp: (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): Implement this, returning whether we a plugin exists for a given mime type.

• plugins/win/PluginDatabaseWin.cpp: (WebCore::parseVersionString): (WebCore::compareVersions): New functions for handling versions.

(WebCore::addMozillaPluginPaths):
(WebCore::addWindowsMediaPlayerPluginPath):
(WebCore::addQuickTimePluginPath):
(WebCore::addJavaPluginPath):
(WebCore::addAdobeAcrobatPluginPath):
(WebCore::PluginDatabaseWin::defaultPluginPaths):
Factor out checks into separate functions, add checks for Java and Adobe Acrobat.

(WebCore::PluginDatabaseWin::isMIMETypeRegistered):
Handle null MIME types.

• plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Add some missing functions. Unload the library if the load failed.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue): Uncomment code for getting the element object.

(WebCore::PluginViewWin::bindingInstance):

• plugins/win/PluginViewWin.h: New function which fetches the plugin NPObject and wraps it in an instance.

5:05 PM Changeset in webkit [16949] by aroben

• 2 edits in tags/Safari-521.28b/WebCore

Reviewed by Steve.

Merge r16948 to tag.

4:57 PM Changeset in webkit [16948] by aroben

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix a possible recursive destructor call.

• page/Frame.cpp: (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor. (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if we're already being destroyed.

4:49 PM Changeset in webkit [16947] by weinig

• 42 edits
  2 adds in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11234
Assorted Objective-C bindings changes

• Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.

• Auto-generate absoluteImageURL method for DOMHTMLInputElement and DOMHTMLObjectElement.

• Auto-generate the internal methods for classes with ivars (notably DOMNodeIterator and DOMTreeWalker)

• Put more methods in the WebCore namespace and factor out the displayString method into DOMInternal.h as done by Darin in his patch for ​http://bugs.webkit.org/show_bug.cgi?id=11219.

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOM.mm: (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMNode dispatchEvent:]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
• bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (-[DOMCSSRule _initWithCSSRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithCSSValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]):
• bindings/objc/DOMEvents.mm: (-[DOMEvent _initWithEvent:WebCore::]): (+[DOMEvent _eventWith:WebCore::]):
• bindings/objc/DOMExtensions.h:
• bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
• bindings/objc/DOMInternal.h: (-[DOMNodeFilter WebCore::]):
• bindings/objc/DOMInternal.mm: (-[WebScriptObject _init]): (-[WebScriptObject _initializeScriptDOMNodeImp]): (WebCore::displayString):
• bindings/objc/DOMObject.mm: (-[DOMObject dealloc]): (-[DOMObject finalize]):
• bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
• bindings/objc/DOMSVG.h:
• bindings/objc/DOMSVGPathSegInternal.h: Added.
• bindings/objc/DOMSVGPathSegInternal.mm: Added. (-[DOMSVGPathSeg WebCore::]): (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]): (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
• bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
• bindings/objc/PublicDOMInterfaces.h:
• bindings/scripts/CodeGeneratorObjC.pm:
• dom/NodeIterator.idl:
• dom/TreeWalker.idl:
• html/HTMLInputElement.idl:
• html/HTMLObjectElement.idl:
• ksvg2/svg/SVGDocument.idl:
• ksvg2/svg/SVGElement.idl:
• ksvg2/svg/SVGPathSeg.idl:
• ksvg2/svg/SVGPathSegArcAbs.idl:
• ksvg2/svg/SVGPathSegArcRel.idl:
• ksvg2/svg/SVGPathSegClosePath.idl:
• ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
• ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
• ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
• ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
• ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
• ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
• ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
• ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
• ksvg2/svg/SVGPathSegLinetoAbs.idl:
• ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
• ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
• ksvg2/svg/SVGPathSegLinetoRel.idl:
• ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
• ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
• ksvg2/svg/SVGPathSegMovetoAbs.idl:
• ksvg2/svg/SVGPathSegMovetoRel.idl:

4:28 PM Changeset in webkit [16946] by bdash

• 2 edits in trunk/WebCore

2006-10-09 Don Gibson <​dgibson77@gmail.com>

Unreviewed build fix.

Fix windows build bustage.

• platform/win/TemporaryLinkStubs.cpp:

4:08 PM Changeset in webkit [16945] by bdash

• 15 edits in trunk

2006-10-09 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Geoff.

Improve gdk build compiler flags (show warning, no rtti and exceptions).

• jscore.bkl:

2006-10-09 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Geoff.

Improve gdk build compiler options.

• Bakefiles.bkgen:
• presets.bkl:

2006-10-09 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Geoff.

Fix memory leaks discovered via valgrind. Gdk build fixes.

• Projects/gdk/webcore-gdk.bkl:
• make-generated-sources.sh:
• platform/cairo/ImageCairo.cpp: (WebCore::Image::draw):
• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
• platform/gdk/FrameGdk.h:
• platform/gdk/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):

2006-10-09 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Geoff.

Add -exit-after-loading option to make gdklauncher quit after fully loading and rendering
a page. This allows automatic testing via e.g. valgrind.

• GdkLauncher/gdklauncher.bkl:
• GdkLauncher/main.cpp: (LauncherFrameGdk::LauncherFrameGdk): (LauncherFrameGdk::setExitAfterLoading): (LauncherFrameGdk::handledOnloadEvents): (handle_event): (main):

3:36 PM Changeset in webkit [16944] by bdash

• 2 edits in trunk/WebCore

2006-10-09 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Beth.

Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.

• platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly (WebCore::GlyphMap::fillPage):

3:34 PM Changeset in webkit [16943] by bdash

• 2 edits in trunk/LayoutTests

2006-10-09 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Oliver.

Use log() instead of alert() just like in all other tests.

• editing/selection/move-begin-end.html:

3:30 PM Changeset in webkit [16942] by bdash

• 4 edits in trunk/WebCore

2006-10-09 Nikolas Zimmermann <​zimmermann@kde.org>

Unreviewed build fix.

Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.

• platform/qt/FrameQt.cpp: (WebCore::FrameQt::createJavaAppletWidget):
• platform/qt/FrameQt.h:
• platform/qt/TemporaryLinkStubs.cpp:

3:24 PM Changeset in webkit [16941] by beidson

• 6 edits in trunk

WebCore:

Reviewed by Maciej

Tiny changes to help reorganize WebFrameLoader code in WebKit

• bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
• bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side

WebKit:

Reviewed by Maciej

Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader

• Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):
• WebCoreSupport/WebIconDatabaseBridge.m: (+[WebIconDatabaseBridge createInstance]):

2:44 PM Changeset in webkit [16940] by mjs

• 2 edits in trunk/WebKit

Reviewed by Darin.

(Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)

• avoid a needless use of WebFrame

• Loader/WebFrameLoader.m: (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):

2:36 PM Changeset in webkit [16939] by yongjzha

• 3 edits in S60/trunk/WebKit

2006-10-09 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun Zhang
DESC: Fix issues with touch support

• Activate an element only if it received both down and up pointer events
• Fix coordinates calculation in frames while zooming
• Update cursor in each touch event, to give user the correct feedback

​http://bugs.webkit.org/show_bug.cgi?id=11229

• BrowserView/inc/PointerEventHandler.h:
• BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL):

1:27 PM Changeset in webkit [16938] by beidson

• 2 edits in trunk/WebKit

A *real* fake fix for the layouttest problem until the real fix

• Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):

1:15 PM Changeset in webkit [16937] by beidson

• 2 edits in trunk/WebKit

Quick layouttest fix until I make the real fix

• Loader/WebFrameLoader.m:

1:06 PM Changeset in webkit [16936] by mjs

• 7 edits in trunk/WebKit

Reviewed by Darin.

• wean WebFrameLoader from WebDataSource private stuff

(actually just tweaks tot he above to make merging my future
patches easier since Darin did a lot of the same stuff)

• Loader/WebDocumentLoader.h:
• Loader/WebDocumentLoader.m: (-[WebDocumentLoader URLForHistory]):
• Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebDataSource.m: (-[WebDataSource _URLForHistory]):
• WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]):

12:31 PM Changeset in webkit [16935] by darin

• 7 edits in trunk/WebKit

Reviewed by Brady.

• eliminated WebFrameLoader dependency on WebDataSourceInternal.h, WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with most but not all references to WebView

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader handleUnimplementablePolicyWithError:]): (-[WebFrameLoader cannotShowMIMETypeWithResponse:]): (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader checkLoadComplete]):
• Loader/WebFrameLoaderClient.h:
• Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
• WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _formDelegate]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _revertToProvisionalWithDocumentLoader:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _URLForHistoryForDocumentLoader:]): (-[WebFrame _cancelledErrorWithRequest:]): (-[WebFrame _cannotShowURLErrorWithRequest:]): (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]): (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]): (-[WebFrame _fileDoesNotExistErrorWithResponse:]): (-[WebFrame _shouldFallBackForError:]): (-[WebFrame _hasWebView]): (-[WebFrame _mainFrameURL]):
• WebView/WebFrameInternal.h:

11:50 AM Changeset in webkit [22343] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Steve.

Fix <rdar://problem/4773320>
Safari didn't pick up quicktime that was already installed

• plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths):

11:43 AM Changeset in webkit [16934] by aroben

• 2 edits in tags/Safari-521.28b/WebCore

Reviewed by Steve.

Merging r16932 to tag.

11:41 AM Changeset in webkit [16933] by thatcher

• 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix.

11:30 AM Changeset in webkit [22342] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fixes <rdar://problem/4773142>
Crash in Settings::mediumFontSize() on ebay.com

Call cancelAndClear() from ~FrameWin (just like Mac does) so we don't
end up calling the Frame::saveDocumentState, which is pure virtual.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):

11:29 AM Changeset in webkit [16932] by aroben

• 2 edits in trunk/WebCore

Reviewed by Adele.

Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
already called frome ~FrameMac.

• page/Frame.cpp: (WebCore::Frame::~Frame):

11:29 AM Changeset in webkit [16931] by darin

• 7 edits in trunk/WebKit

Reviewed, landed, tweaked a bit by Darin.

• removed most uses of WebFrameBridge from WebFrameLoader (WebCoreFrameBridge use is OK)

• Loader/WebDocumentLoader.m: (-[WebDocumentLoader bridge]):
• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader bridge]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
• WebView/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]):
• WebView/WebFrameInternal.h:

11:28 AM Changeset in webkit [22341] by andersca

• 3 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <​acarlsson@apple.com>

• WebCore.vcproj/WebCore.vcproj:
• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Fix build.

11:04 AM Changeset in webkit [16930] by darin

• 6 edits in trunk/WebKit

Reviewed by Brady.

• removed almost all direct use of WebView from WebFrameLoader

• Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
• Loader/WebFrameLoaderClient.h:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebFrame.m: (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _hasBackForwardList]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]): (-[WebFrame _progressStarted]): (-[WebFrame _progressCompleted]): (-[WebFrame _incrementProgressForIdentifier:response:]): (-[WebFrame _incrementProgressForIdentifier:data:]): (-[WebFrame _completeProgressForIdentifier:]): (-[WebFrame _setMainFrameDocumentReady:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _startDownloadWithRequest:]):

10:47 AM Changeset in webkit [16929] by andersca

• 2 edits in trunk/WebCore

2006-10-09 Anders Carlsson <​acarlsson@apple.com>

• bridge/win/FrameWin.h: Add function declaration.

10:35 AM Changeset in webkit [16928] by andersca

• 2 edits in trunk/WebCore

2006-10-09 Anders Carlsson <​acarlsson@apple.com>

• platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Try fixing the Win32 build.

10:21 AM Changeset in webkit [16927] by andersca

• 6 edits
  2 deletes in trunk/WebCore

2006-10-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Move applet widget creation to Frame and get rid of JavaAppletWidget.

• WebCore.xcodeproj/project.pbxproj:
• bridge/JavaAppletWidget.h: Removed.
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::createJavaAppletWidget):
• bridge/mac/JavaAppletWidget.mm: Removed.
• page/Frame.h:
• rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):

2:53 AM Changeset in webkit [16926] by mjs

• 7 edits
  2 adds in trunk/WebKit

Reviewed by Alice.

• moved WebFormState into Loader directory and tweaked to void WebKit dependencies

• Loader/WebDocumentLoader.h:
• Loader/WebFormState.h: Added.
• Loader/WebFormState.m: Added. (-[WebFormState initWithForm:values:sourceFrame:]): (-[WebFormState dealloc]): (-[WebFormState form]): (-[WebFormState values]): (-[WebFormState sourceFrame]):
• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebFrame.m:
• WebView/WebFrameInternal.h:

2:29 AM Changeset in webkit [16925] by bdash

• 2 edits
  1 add
  1 delete in trunk/WebCore

2006-10-09 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• ​http://bugs.webkit.org/show_bug.cgi?id=11220 Fix manual test for ​http://bugs.webkit.org/show_bug.cgi?id=8276

Subversion does not support resource forks and HFS metadata, so
the resources for this test need to be on a disk image.

• manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
• manual-tests/resources/plain-text-paste.dmg: Added.
• manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
• manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
• manual-tests/resources/plain-text-paste/._4.txt: Removed.
• manual-tests/resources/plain-text-paste/._5.webloc: Removed.
• manual-tests/resources/plain-text-paste/1.textClipping: Removed.
• manual-tests/resources/plain-text-paste/2.textClipping: Removed.
• manual-tests/resources/plain-text-paste/3.gif: Removed.
• manual-tests/resources/plain-text-paste/4.txt: Removed.
• manual-tests/resources/plain-text-paste/5.webloc: Removed.

2:09 AM Changeset in webkit [16924] by mjs

• 3 edits in trunk/WebKit

Reviewed by Oliver.

• remove dependency on WebNSURLRequestExtras.h

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):

1:59 AM Changeset in webkit [16923] by mjs

• 2 edits in trunk/WebKit

Reviewed by Oliver.

• removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency

• Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):

1:44 AM Changeset in webkit [16922] by mjs

• 10 edits in trunk/WebKit

Reviewed by Oliver.

• remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)

• Loader/WebDocumentLoader.h:
• Loader/WebDocumentLoader.m: (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader initialRequest]): (-[WebDocumentLoader URL]): (-[WebDocumentLoader unreachableURL]):
• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader initialRequest]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader _URL]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader safeLoadURL:]):
• Loader/WebFrameLoaderClient.h:
• Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge originalRequestURL]):
• WebView/WebDataSource.m: (-[WebDataSource _URL]): (-[WebDataSource dealloc]): (-[WebDataSource initialRequest]): (-[WebDataSource unreachableURL]):
• WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _forceLayoutForNonHTML]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]): (-[WebFrame _makeRepresentationForDocumentLoader:]):

12:40 AM Changeset in webkit [16921] by rwlbuis

• 31 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in filter classes.

12:36 AM Changeset in webkit [16920] by rwlbuis

• 24 edits in trunk/WebCore

Reviewed by olliej.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in SVGPath* classes.

12:32 AM Changeset in webkit [16919] by mjs

• 4 edits in trunk/WebKit

Reviewed by Darin.

• removed need for WebFrameLoader to now about WebDocumentLoaderMac

• Loader/WebFrameLoader.m: (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
• WebView/WebDocumentLoaderMac.h:
• WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac setFrameLoader:]): (-[WebDocumentLoaderMac detachFromFrameLoader]):

12:27 AM Changeset in webkit [16918] by rwlbuis

• 15 edits in trunk/WebCore

Reviewed by aroben.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg shape classes.

12:23 AM Changeset in webkit [16917] by darin

• 4 edits in trunk/WebKit

Reviewed by Maciej.

• passed calls that require WebScriptDebugServer across the client interface

• Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):

12:03 AM Changeset in webkit [16916] by darin

• 5 edits in trunk/WebKit

Reviewed by Maciej.

• passed calls that require WebHTMLView or WebFrameView calls across the client interface

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader opened]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader reload]): (-[WebFrameLoader transitionToCommitted:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[WebFrame _forceLayout]): (-[WebFrame _setDocumentViewFromPageCache:]): (-[WebFrame _setCopiesOnScroll]):

Oct 8, 2006:

11:46 PM Changeset in webkit [16915] by mjs

• 4 edits in trunk/WebKit

Reviewed by Darin.

• pass remaining delegate methods across client interface

• Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[WebFrame _dispatchDidFirstLayoutInFrame]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchShow]): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]): (-[WebFrame _dispatchUnableToImplementPolicyWithError:]):

11:30 PM Changeset in webkit [16914] by darin

• 16 edits in trunk

WebCore:

Reviewed by Maciej.

• added a bit more WebCoreSystemInterface

wkGetNSURLResponseCalculatedExpiration
wkGetNSURLResponseLastModifiedDate
wkGetNSURLResponseMustRevalidate

• WebCore.exp: Added the new symbols.
• platform/mac/WebCoreSystemInterface.h: Ditto.
• platform/mac/WebCoreSystemInterface.mm: Ditto.

• quiet down the code generation script

• bindings/scripts/CodeGenerator.pm:

WebKit:

Reviewed by Maciej.

• use WebCoreSystemInterface instead of WebSystemInterface in Loader directory

• Loader/WebFrameLoader.m: Update includes. (-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK. (-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.

• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Added the three new symbols, and resorted the list.

• Loader/WebDataProtocol.m:
• Loader/WebLoader.m:
• Loader/WebMainResourceLoader.h:
• Loader/WebMainResourceLoader.m:
• Loader/WebNetscapePlugInStreamLoader.h:
• Loader/WebNetscapePlugInStreamLoader.m:
• Loader/WebSubresourceLoader.h:
• Loader/WebSubresourceLoader.m: Changed import statements to consistently use the "" format.

11:19 PM Changeset in webkit [16913] by mjs

• 2 edits in trunk/WebKit

Not reviewed.

• fix accidental build break due to editing while committing

• Loader/WebFrameLoader.m:

11:17 PM Changeset in webkit [16912] by mjs

• 4 edits in trunk/WebKit

Reviewed by Darin.

• move all WebFrameLoadDelegate methods across client interface

• Loader/WebFrameLoader.m: (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[WebFrame _dispatchDidCancelClientRedirectForFrame]): (-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]): (-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]): (-[WebFrame _dispatchWillCloseFrame]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidReceiveTitle:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]):

10:44 PM Changeset in webkit [16911] by darin

• 6 edits in trunk/WebKit

Reviewed by Maciej.

• removed some of the WebKit dependencies in WebFrameLoader

• Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader reload]): (-[WebFrameLoader didChangeTitleForDocument:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
• WebView/WebFrameInternal.h:

• some other tweaks

• Misc/WebNSURLRequestExtras.m: (-[NSMutableURLRequest _web_setHTTPReferrer:]): (-[NSMutableURLRequest _web_setHTTPUserAgent:]):

10:42 PM Changeset in webkit [16910] by mjs

• 4 edits in trunk/WebKit

Reviewed by Darin.

• pass all WebResourceLoadDelegate methods across client, removing need to include related headers

• Loader/WebFrameLoader.m: (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]): (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]): (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]): (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]): (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):

10:23 PM Changeset in webkit [16909] by mjs

• 6 edits in trunk/WebKit

Reviewed by Darin.

• started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch

• Loader/WebFrameLoader.m: (-[WebFrameLoader startLoading]): (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
• Loader/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge handledOnloadEvents]):
• WebView/WebFrame.m: (dataSource): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]): (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
• WebView/WebFrameInternal.h:

9:30 PM Changeset in webkit [16908] by darin

• 11 edits in trunk/WebKit

Reviewed by Maciej.

• moved more methods to WebFrameLoader from WebFrame

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader reload]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader checkLoadComplete]):
• Loader/WebFrameLoaderClient.h:
• Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge close]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]):
• WebView/WebDataSourceInternal.h:
• WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _detachedFromParent1]): (-[WebFrame _detachedFromParent2]): (-[WebFrame _detachedFromParent3]): (-[WebFrame _detachedFromParent4]): (-[WebFrame _updateHistoryAfterClientRedirect]): (-[WebFrame _loadedFromPageCache]):
• WebView/WebFrameInternal.h:
• WebView/WebPDFView.m: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
• WebView/WebView.m: (-[WebView _close]): (-[WebView setDefersCallbacks:]):

8:56 PM Changeset in webkit [16907] by mjs

• 10 edits in trunk

WebCore:

Reviewed by Darin.

• more code laundering - add wkSupportsMultipartXMixedReplace

• WebCore.exp:
• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Darin.

• avoid need for WebKitSystemInterface in loader code, via WebCore cover for wkSupportsMultipartXMixedReplace

• Loader/WebDocumentLoader.m: (-[WebDocumentLoader initWithRequest:]):
• Loader/WebMainResourceLoader.m:
• Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
• WebView/WebDataSource.m: (-[WebDataSource _initWithDocumentLoader:]):

8:23 PM Changeset in webkit [16906] by bdash

• 1 edit in trunk/WebKit/WebView/WebFrame.m

Release build fix: silence warning about unused variable.

7:43 PM Changeset in webkit [16905] by darin

• 2 edits in trunk/WebKit

• build fix (also a fix for a crasher I forgot to commit before)

• Loader/WebFrameLoader.m: Added some missing includes. (-[WebFrameLoader checkLoadCompleteForThisFrame]): Added a needed retain/release.

7:35 PM Changeset in webkit [16904] by darin

• 2 edits in trunk/WebKit

Reviewed by Anders.

• quick fix to loader problem causing layout test failures

• Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): Use a local variable for the bridge that we retain/release. (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Same here.

7:17 PM Changeset in webkit [22340] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Port of OpenSource r16526, r16528

Break up ResourceLoaderWndProc into callback functions.

• platform/win/ResourceLoaderWin.cpp: Fix up #includes (WebCore::): Remove loadStatusMessage, struct JobLoadStatus, add messageHandlers array. (WebCore::ResourceLoaderWndProc): Split handling of different messages into callbacks. (WebCore::ResourceLoader::onHandleCreated): New callback. (WebCore::ResourceLoader::onRequestRedirected): New callback. (WebCore::ResourceLoader::onRequestComplete): New callback. (WebCore::initializeOffScreenResourceLoaderWindow): No need to register loadStatusMessage anymore. (WebCore::transferJobStatusCallback): Change how information is passed into ResourceLoaderWndProc.

7:09 PM Changeset in webkit [16903] by mjs

• 4 edits in trunk/WebKit

Reviewed by Adam.

• removed a few includes from WebFrameLoader, fixed up as appropriate
• segregated header includes into ones that need to go away to move the code and ones that don't

• Loader/WebFrameLoader.m: (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[WebFrame _privateBrowsingEnabled]):

6:48 PM Changeset in webkit [16902] by darin

• 9 edits in trunk/WebKit

Reviewed by Maciej.

• moved a few methods from WebFrame to WebFrameLoader

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _finishedLoading]): (isBackForwardLoadType): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
• Loader/WebFrameLoaderClient.h:
• Plugins/WebPluginController.m: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
• WebCoreSupport/WebFrameBridge.h:
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge frameLoader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
• WebView/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _checkLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _updateBackground]): (-[WebFrame _frameLoader]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForCommit]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForBackForwardNavigation]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _tokenForLoadErrorReset]): (-[WebFrame _resetAfterLoadError:]): (-[WebFrame _doNotResetAfterLoadError:]):
• WebView/WebFrameInternal.h:

5:44 PM Changeset in webkit [16901] by bdash

• 2 edits in trunk/WebKit

2006-10-09 Mark Rowe <​bdash@webkit.org>

Rubber-stamped by Darin.

• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge imageTitleForFilename:size:]): Revert accidental change to a UI_STRING that is triggering an assertion failure.

5:33 PM Changeset in webkit [16900] by bdash

• 2 edits in trunk/WebCore

2006-10-08 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Darin and Oliver.

Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.

• platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage. (WebCore::GraphicsContext::drawConvexPolygon):

4:52 PM Changeset in webkit [16899] by mjs

• 8 edits in trunk/WebKit

Reviewed by Darin.

• remove unneeded non-Loader header includes from WebFrameLoader.h (split WebFrameLoadType into two coincidentally matching enums)

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader commitProvisionalLoad:]): (isBackForwardLoadType): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader loadType]): (-[WebFrameLoader setLoadType:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]): (-[WebFrameLoader didFirstLayout]):
• WebCoreSupport/WebFrameBridge.m:
• WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _loadType]): (-[WebFrame loadRequest:]):
• WebView/WebFrameInternal.h:
• WebView/WebView.m:

4:33 PM Changeset in webkit [16898] by andersca

• 2 edits in trunk/WebCore

2006-10-08 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

• page/Frame.cpp: (WebCore::Frame::submitForm): No need to use latin1() here.

3:47 PM Changeset in webkit [16897] by darin

• 6 edits in trunk/WebKit

Reviewed by Maciej.

• move WebFrameLoader creation and ownership from WebFrame to WebFrameBridge

• Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader closeOldDataSources]):
• WebCoreSupport/WebFrameBridge.h:
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge loader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge imageTitleForFilename:size:]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
• WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFramePrivate dealloc]): (-[WebFramePrivate setWebFrameView:]): (-[WebFramePrivate setProvisionalItem:]): (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): (-[WebFrame _createItem:]): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _setTitle:]): (-[WebFrame _defersCallbacksChanged]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForSavingDocState]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _loadRequest:inFrameNamed:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _frameLoader]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]): (-[WebFrame frameView]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame stopLoading]): (-[WebFrame reload]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _provisionalItemIsTarget]): (-[WebFrame _loadProvisionalItemFromPageCache]):
• WebView/WebFrameInternal.h:

3:45 PM Changeset in webkit [16896] by bdash

• 2 edits in trunk/WebCore

2006-10-08 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Darin.

Kill warnings when generating IDL files on Qt/Linux, as the
SOURCE_ROOT environment variable is not defined (and not needed) for us.

• bindings/scripts/CodeGenerator.pm:

3:24 PM Changeset in webkit [16895] by mjs

• 3 edits in trunk/WebCore

Reviewed by Darin.

• split didNotOpenURL: into general and page-cache-specific parts

• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge didNotOpenURL:]): (-[WebCoreFrameBridge invalidatePageCache:]):

3:10 PM Changeset in webkit [16894] by mjs

• 10 edits in trunk/WebKit

Reviewed by Darin.

• move remaining movable data fields from WebFrameLoader to WebFrame

• Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState commitIfReady]):
• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader isQuickRedirectComing]):
• Loader/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameBridge.h:
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge frameLoader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
• WebView/WebDataSource.m: (-[WebDataSource _loadFromPageCache:]):
• WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _didFinishLoad]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame stopLoading]): (-[WebFrame _invalidateCurrentItemPageCache]):
• WebView/WebFrameInternal.h:

2:40 PM Changeset in webkit [16893] by andersca

• 3 edits in trunk/WebCore

2006-10-08 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

• loader/loader.cpp: Remove DeprecatedStringList.h include.

• page/Frame.cpp: (WebCore::Frame::submitForm): Don't remove "attach" from mailto URLs, we don't do it anywhere else.

2:28 PM Changeset in webkit [16892] by darin

• 12 edits
  4 moves in trunk/WebKit

Rubber stamped by Maciej.

• changed "document load state" to "document loader"

• Loader/WebDocumentLoadState.h: Removed.
• Loader/WebDocumentLoadState.m: Removed.
• Loader/WebDocumentLoader.h: Added.
• Loader/WebDocumentLoader.m: Added. (-[WebDocumentLoader setMainDocumentError:]): (-[WebDocumentLoader mainReceivedError:complete:]): (-[WebDocumentLoader finishedLoading]): (-[WebDocumentLoader commitLoadWithData:]): (-[WebDocumentLoader setupForReplaceByMIMEType:]): (-[WebDocumentLoader updateLoading]): (-[WebDocumentLoader setTitle:]):
• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader activeDocumentLoader]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader setDocumentLoader:]): (-[WebFrameLoader documentLoader]): (-[WebFrameLoader policyDataSource]): (-[WebFrameLoader setPolicyDocumentLoader:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader provisionalDocumentLoader]): (-[WebFrameLoader setProvisionalDocumentLoader:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
• Plugins/WebPluginController.m: (-[WebPluginController pluginView:receivedResponse:]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]):
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _webView]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _documentLoader]): (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource data]): (-[WebDataSource webFrame]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource textEncodingName]): (-[WebDataSource isLoading]): (-[WebDataSource unreachableURL]): (-[WebDataSource webArchive]):
• WebView/WebDataSourceInternal.h:
• WebView/WebDocumentLoadStateMac.h: Removed.
• WebView/WebDocumentLoadStateMac.m: Removed.
• WebView/WebDocumentLoaderMac.h: Added.
• WebView/WebDocumentLoaderMac.m: Added.
• WebView/WebFrame.m: (-[WebFrame _createItem:]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _addChild:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _createDocumentLoaderWithRequest:]):
• WebView/WebFrameInternal.h:
• WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
• WebView/WebView.m: (-[WebView _mainFrameOverrideEncoding]):

1:44 PM Changeset in webkit [16891] by darin

• 1 edit in trunk/WebKit/ChangeLog

More change log tweaking -- it's well worth it!

1:42 PM Changeset in webkit [16890] by darin

• 1 edit in trunk/WebKit/ChangeLog

Fixed grammar mistake in change log entry.

1:42 PM Changeset in webkit [16889] by darin

• 2 edits in trunk/WebKit

Reviewed by Mitz.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11218 REGRESSION: Assertion failure in WebFrameLoader when going back from a file: or data: URL

Also added a helper function in WebFrameLoader so code that checks for back/forward load types
is easier to read.

• Loader/WebFrameLoader.m: (-[WebFrameLoader _setPolicyDocumentLoadState:]): Fixed line of code that was setting the load state to nil instead of the passed-in object. (isBackForwardLoadType): Added. (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Use isBackForwardLoadType. (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): Ditto. (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): Ditto.

12:19 PM Changeset in webkit [16888] by weinig

• 27 edits
  2 deletes in trunk/WebCore

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11215
Yet another round of Objective-C SVG DOM bindings auto-generation

• Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent, DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, DOMSVGZoomAndPan and DOMSVGZoomEvent.

• Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement using the new [ConvertFromString] property.

• Add forward declarations for NS* types to auto-generated classes.

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOMHTMLAppletElement.mm: Removed.
• bindings/objc/DOMHTMLEmbedElement.mm: Removed.
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMSVG.h:
• bindings/scripts/CodeGeneratorObjC.pm:
• html/HTMLAppletElement.idl:
• html/HTMLEmbedElement.idl:
• ksvg2/svg/SVGPatternElement.idl:
• ksvg2/svg/SVGPolygonElement.idl:
• ksvg2/svg/SVGPolylineElement.idl:
• ksvg2/svg/SVGRadialGradientElement.idl:
• ksvg2/svg/SVGRenderingIntent.idl:
• ksvg2/svg/SVGScriptElement.idl:
• ksvg2/svg/SVGSetElement.idl:
• ksvg2/svg/SVGStopElement.idl:
• ksvg2/svg/SVGSwitchElement.idl:
• ksvg2/svg/SVGSymbolElement.idl:
• ksvg2/svg/SVGTRefElement.idl:
• ksvg2/svg/SVGTSpanElement.idl:
• ksvg2/svg/SVGTextContentElement.idl:
• ksvg2/svg/SVGTextElement.idl:
• ksvg2/svg/SVGTextPositioningElement.idl:
• ksvg2/svg/SVGTitleElement.idl:
• ksvg2/svg/SVGUseElement.idl:
• ksvg2/svg/SVGViewElement.idl:
• ksvg2/svg/SVGZoomEvent.idl:

6:53 AM Changeset in webkit [16887] by darin

• 4 edits in trunk/WebKit

Reviewed by Maciej.

• fix two recently introduced leaks: one of an NSString, the other of a WebDataSource

• Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]): Rearranged code to avoid storage leak in case of identical title.

• Loader/WebFrameLoader.h: Removed _setPolicyDocumentLoadState: method from the header.
• Loader/WebFrameLoader.m: (-[WebFrameLoader _setPolicyDocumentLoadState:]): Added logic to call detachFromFrameLoader as needed if this load state is going away rather than moving on to become the provisional load state. (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Tweaked formatting. (-[WebFrameLoader _loadRequest:archive:]): Added an assertion. (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): Added an assertion. (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): Added an assertion. (-[WebFrameLoader reload]): Added an assertion. (-[WebFrameLoader loadDataSource:withLoadType:formState:]): Added a local variable to avoid calling _documentLoadState over and over again.

1:02 AM Changeset in webkit [22339] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Add win2k/classic support for all controls.

12:47 AM Changeset in webkit [22338] by sfalken

• 2 edits in branches/WindowsMerge/WebCore

2006-10-07 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Fix <rdar://4772205> Regression (r10623): WinInet loader doesn't ever write to the cache.

• platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): Apply POST related flags only for posts. (WebCore::ResourceLoader::startHTTPRequest): Don't add no-cache-write flag to non-post transactions.