⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 11, 2006:

6:44 PM Changeset in webkit [17001] by zbujtas
  • 3 edits in S60/trunk/WebKit

2006-10-11 brmorris <​thisisbradley@gmail.com>

Reviewed by zalan
DESC: send reindeer UA String
​http://bugs.webkit.org/show_bug.cgi?id=9189

  • BrowserView/inc/WebKitLoader.h: Update static ua string to 3.1
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL): Return static ua string if BROWSER_SDK
5:54 PM Changeset in webkit [17000] by darin
  • 11 edits in trunk/WebKit

Reviewed by Adele.

  • preparations for making more code C++
  • WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff that non-C++ files get.
  • Misc/WebKitLogging.h:
  • Misc/WebKitSystemBits.h:
  • Misc/WebLocalizableStrings.h:
  • WebCoreSupport/WebSystemInterface.h: Added extern "C".
  • Misc/WebNSViewExtras.h:
  • WebView/WebDataSource.m: (addTypesFromClass):
  • WebView/WebFrameView.m: (addTypesFromClass): Eliminated use of the identifier "class".
  • WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.
  • Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.
5:40 PM Changeset in webkit [16999] by darin
  • 14 edits in trunk/WebCore

Reviewed by John.

  • some changes to prepare for converting more code to C++
  • bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is self-sufficient.
  • bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class. Needed since the class is used in this header (for some work I have not landed yet).
  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/WebFormDataStream.h: Added extern "C" so this code can be used from C++.
  • loader/mac/LoaderNSURLExtras.m:
  • loader/mac/WebDataProtocol.mm:
  • loader/mac/WebDocumentLoader.mm:
  • loader/mac/WebFormDataStream.m:
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebPolicyDecider.mm:
  • loader/mac/WebSubresourceLoader.mm: Added missing includes of config.h.
4:18 PM Changeset in webkit [16998] by darin
  • 2 edits in trunk/WebKitLibraries

Reviewed by John Sullivan.

  • WebKitSystemInterface.h: Updated to a C++-compatible version.
4:15 PM Changeset in webkit [16997] by sullivan
  • 4 edits in trunk/WebCore

Darin wrote this code; we tested it; I give it the thumbs up.


  • fixed regression from svn revision 16982 that was generating the wrong Obj-C classes

The hash table to look up an element class given a QualifiedName was
not working at all.

  • dom/QualifiedName.h: (WebCore::QualifiedName::impl): Added. This new accessor method for impl is needed if we want to use a QualifiedName as a hash table key without doing the kind of specialization we do for String. Maybe later we can do the String thing.
  • bindings/objc/DOM.mm: (WebCore::addElementClass): Use QualifiedName.impl instead of the QualifiedName pointer itself. The QualifiedName pointer is *not* unique so almost nothing would be found in this hash table! (WebCore::elementClass): ditto
2:09 PM Changeset in webkit [16996] by aroben
  • 3 edits in trunk/WebCore

Rubberstamped by Anders.

Clean up FileChooser::create and Icon::newIconForFile.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
  • platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile):
1:39 PM Changeset in webkit [16995] by kmccullo
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin.

These test DST behavior on the cusp of a change (i.e. spring forward, fall back)

  • fast/js/date-DST-time-cusps-expected.txt: Added.
  • fast/js/date-DST-time-cusps.html: Added.
  • fast/js/resources/date-DST-time-cusps.js: Added.
11:45 AM Changeset in webkit [16994] by oliver
  • 3 edits in trunk/LayoutTests

2006-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

Fix svg text related layout tests

  • svg/custom/getsvgdocument-expected.txt:
  • svg/hixie/viewbox/003-expected.txt:
11:27 AM Changeset in webkit [16993] by oliver
  • 3 edits
    4 adds in trunk

2006-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11251
Corrects canvas tag to not throw JS exception when drawing
zero sized rects, arcs, etc

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):

Reviewed by Geoff.

Test case for ​http://bugs.webkit.org/show_bug.cgi?id=11251

  • fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • fast/canvas/zero-size-fill-rect-expected.png: Added.
  • fast/canvas/zero-size-fill-rect-expected.txt: Added.
  • fast/canvas/zero-size-fill-rect.html: Added.
11:26 AM Changeset in webkit [16992] by brmorris
  • 1 edit
    7 adds in S60/trunk/S60Internals

Reviewed by Bradley Morrison.
DESC: some support files for GCCE and RVCT compilations
​http://bugs.webkit.org/show_bug.cgi?id=9435

  • target/GCCE/SDKGCCEPatch.zip: Added.
  • target/RVCT/S60LibsRVCT.zip: Added.
  • target/RVCT/S60RVCTPatch.zip: Added.
  • target/RVCT/rvct2_2.h: Added. (std::):
11:19 AM Changeset in webkit [16991] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11221
REGRESSION: iExploder crash due to style="cursor: url()"

Take better care of empty cursor lists.

Test: fast/css/invalid-cursor-property-crash.html

10:56 AM Changeset in webkit [16990] by aroben
  • 2 edits in trunk/WebCore

Fixing Windows for real this time.

  • platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):
10:30 AM Changeset in webkit [16989] by aroben
  • 2 edits in trunk/WebCore

Fix Windows build.

  • platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):
10:14 AM Changeset in webkit [22353] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Brady.

Clean up logic in Icon::newIconForFile.

  • platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Error case should return early.
10:08 AM Changeset in webkit [22352] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fixes <rdar://problem/4777719>
Icons don't paint with CG

  • platform/win/IconWin.cpp: (WebCore::Icon::paint): Remove Cairo-specific code now that we have GraphicsContextWin.
9:54 AM Changeset in webkit [22351] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

Clean up FileChooser::create, Icon::create.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::create): Just return a FileChooser* and let the implicit cast happen.
  • platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Ditto for Icon*.
8:04 AM Changeset in webkit [16988] by antti
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=4377

  • fast/layers/layer-visibility-expected.checksum: Added.
  • fast/layers/layer-visibility-expected.png: Added.
  • fast/layers/layer-visibility-expected.txt: Added.
  • fast/layers/layer-visibility.html: Added.

WebCore:

Reviewed by Hyatt.


​http://bugs.webkit.org/show_bug.cgi?id=4377


Respect css visibility semantics for layers too

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::dirtyVisibleContentStatus): (WebCore::RenderLayer::childVisibilityChanged): (WebCore::RenderLayer::dirtyVisibleDescendantStatus): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleContent):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
12:15 AM Changeset in webkit [16987] by mjs
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Oliver.

  • added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
  • WebCore.xcodeproj/project.pbxproj:
  • platform/cf/RetainPtr.h: Added. (WTF::): (WTF::RetainPtr::RetainPtr): (WTF::RetainPtr::~RetainPtr): (WTF::RetainPtr::get): (WTF::RetainPtr::operator*): (WTF::RetainPtr::operator->): (WTF::RetainPtr::operator!): (WTF::RetainPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):


  • use it in WidgetMac so it gets tested in at least one place


  • platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setCursor): (WebCore::Widget::getView): (WebCore::Widget::setView): (WebCore::Widget::getOuterView):

Oct 10, 2006:

11:35 PM Changeset in webkit [16986] by beidson
  • 8 edits in trunk

WebCore:

Reviewed by Maciej.

Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (-[WebFrameLoader initWithFrameBridge:]): (-[WebFrameLoader setFrameLoaderClient:]):

WebKit:

Reviewed by Maciej.

Moved WebFrameLoader into WebCoreFrameBridge

  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge close]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
9:39 PM Changeset in webkit [16985] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 11246: Minor Drosera code cleanup
​http://bugs.webkit.org/show_bug.cgi?id=11246

  • Drosera/debugger.js: Change [has, add, remove]StyleClass to be a function on Element rather than taking an Element as an argument.
9:35 PM Changeset in webkit [16984] by thatcher
  • 7 edits
    5 adds in trunk/WebKitTools

Reviewed by Tim H.

Bug 9778: ​http://bugs.webkit.org/show_bug.cgi?id=9778

  • ChangeLog:
  • Drosera/Drosera.xcodeproj/project.pbxproj: Added files
  • Drosera/English.lproj/Debugger.nib/info.nib: Resized the main window and WebView
  • Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Resized the main window and WebView
  • Drosera/Images/SourceArrowOpen.png: Added.
  • Drosera/Images/fileIcon.jpg: Added.
  • Drosera/Images/siteCollapsed.tif: Added.
  • Drosera/Images/siteExpanded.tif: Added.
  • Drosera/Images/siteIcon.tif: Added.
  • Drosera/debugger.css: Added File Browser styles
  • Drosera/debugger.html: Added File Browser UI
  • Drosera/debugger.js: Added File Browser functionality
9:35 PM Changeset in webkit [22350] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixes <rdar://problem/4731316>
Crash when <input type="file"> element removed while file chooser is open

  • platform/win/FileChooserWin.cpp: Make FileChooser ref-counted. (WebCore::FileChooser::create): (WebCore::FileChooser::openFileChooser): Add a protector RefPtr around the call to GetOpenFileName so we don't get deleted while the file chooser window is open.
9:33 PM Changeset in webkit [16983] by aroben
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

Make FileChooser ref-counted.

  • platform/FileChooser.h:
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
  • rendering/RenderFileUploadControl.h:
8:46 PM Changeset in webkit [16982] by weinig
  • 22 edits
    1 delete in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11248
Even More auto-generated Objective-C DOM bindings changes

  • Auto-generate DOMSVGPathElement.
  • Auto-generate the internal interfaces even for classes that have custom internal implementations. Change IDL property from ObjCNoInternal to ObjCCustomInternalImpl to indicate the change.
  • Add SVG classes to DOMNode and DOMEvent internal interfaces.
  • Add isSVGZoomEvent() method to Event class to match other Event subclasses and make DOM binding possible.
  • Assorted cleanups.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (WebCore::addElementClass): (WebCore::createElementClassMap): (WebCore::elementClass): (-[DOMNode description]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMElement _NPObject]): (WebCore::ObjCEventListener::handleEvent):
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor WebCore::]):
  • bindings/objc/DOMSVGPathSegInternal.h: Removed.
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSRule.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/Event.cpp: (WebCore::Event::isSVGZoomEvent):
  • dom/Event.h:
  • dom/Event.idl:
  • dom/Node.idl:
  • ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::isSVGZoomEvent):
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/svg/SVGAnimatedAngle.idl:
  • ksvg2/svg/SVGCircleElement.idl:
  • ksvg2/svg/SVGClipPathElement.idl:
  • ksvg2/svg/SVGPathElement.idl:
  • ksvg2/svg/SVGPathSeg.idl:
8:41 PM Changeset in webkit [22349] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fixes <rdar://problem/4772428>
<select> popup menus positioned incorrectly within frames

  • rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::setPositionAndSize): Use contentsToWindow() instead of scrollOffset() to correct menu location.
7:29 PM Changeset in webkit [22348] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-10 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


<rdar://4775676>
Crash in CoreFoundation parsing a "corrupt" plist


Prevent crash when we encounter a corrupt history plist by using
structured exception handling to catch the crash and return
an empty history list.

  • WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL):
7:22 PM Changeset in webkit [16981] by oliver
  • 2 edits in trunk/WebCore

2006-10-10 Oliver Hunt <​oliver@apple.com>

rubber stamped by Anders.

More buildbot bustage

  • kcanvas/SVGInlineFlowBox.cpp: (WebCore::placeBoxesVerticallyWithAbsBaseline):
7:12 PM Changeset in webkit [16980] by oliver
  • 4 edits in trunk/WebCore

2006-10-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders

Unbreak build bots

  • dom/Text.cpp:
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • kcanvas/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline):
6:28 PM Changeset in webkit [16979] by oliver
  • 9 edits
    10 adds in trunk/WebCore

2006-10-10 Oliver Hunt <set EMAIL_ADDRESS environment variable>

Reviewed by hyatt.

Fixes bugs #6423, #6559, #10380 and #10839

  • WebCore.xcodeproj/project.pbxproj:
  • css/svg.css:
  • dom/Text.cpp: (WebCore::Text::createRenderer):
  • kcanvas/RenderSVGInline.cpp: Added. (WebCore::RenderSVGInline::RenderSVGInline): (WebCore::RenderSVGInline::createInlineBox):
  • kcanvas/RenderSVGInline.h: Added. (WebCore::RenderSVGInline::renderName): (WebCore::RenderSVGInline::requiresLayer):
  • kcanvas/RenderSVGInlineText.cpp: Added. (WebCore::RenderSVGInlineText::RenderSVGInlineText): (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::selectionRect):
  • kcanvas/RenderSVGInlineText.h: Added. (WebCore::RenderSVGInlineText::renderName): (WebCore::RenderSVGInlineText::requiresLayer):
  • kcanvas/RenderSVGTSpan.cpp: Added. (WebCore::RenderSVGTSpan::RenderSVGTSpan): (WebCore::RenderSVGTSpan::absoluteRects):
  • kcanvas/RenderSVGTSpan.h: Added. (WebCore::RenderSVGTSpan::renderName):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::computeAbsoluteRepaintRect): (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::createInlineBox): (WebCore::RenderSVGText::nodeAtPoint): (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::relativeBBox):
  • kcanvas/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
  • kcanvas/SVGInlineFlowBox.cpp: Added. (WebCore::SVGInlineFlowBox::paint): (WebCore::SVGInlineFlowBox::placeBoxesHorizontally): (WebCore::SVGInlineFlowBox::verticallyAlignBoxes): (WebCore::paintSVGInlineFlow): (WebCore::translateBox): (WebCore::placePositionedBoxesHorizontally): (WebCore::placeSVGFlowHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): (WebCore::placeSVGFlowVertically):
  • kcanvas/SVGInlineFlowBox.h: Added. (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
  • kcanvas/SVGRootInlineBox.cpp: Added. (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::placeBoxesHorizontally): (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
  • kcanvas/SVGRootInlineBox.h: Added. (WebCore::SVGRootInlineBox::SVGRootInlineBox):
  • ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::createRenderer):
  • ksvg2/svg/SVGTSpanElement.cpp: (SVGTSpanElement::createRenderer):
  • rendering/InlineFlowBox.h:
6:26 PM Changeset in webkit [16978] by oliver
  • 271 edits in trunk/LayoutTests

2006-10-10 Oliver Hunt <​ohunt@apple.com>

Rubber stamped by Anders.

Updated to deal with new svg text renderers, and
updated result.

custom/text-clip testcase was incorrect, and has been fixed

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/custom/baseval-animval-equality-expected.checksum:
  • svg/custom/baseval-animval-equality-expected.png:
  • svg/custom/coords-relative-units-transforms-expected.checksum:
  • svg/custom/coords-relative-units-transforms-expected.png:
  • svg/custom/coords-relative-units-transforms-expected.txt:
  • svg/custom/createelement-expected.txt:
  • svg/custom/feComponentTransfer-Discrete-expected.txt:
  • svg/custom/feComponentTransfer-Gamma-expected.txt:
  • svg/custom/feComponentTransfer-Linear-expected.txt:
  • svg/custom/feComponentTransfer-Table-expected.txt:
  • svg/custom/foreign-object-skew-expected.txt:
  • svg/custom/gradient-stroke-width-expected.txt:
  • svg/custom/image-with-transform-clip-filter-expected.txt:
  • svg/custom/invalid-css-expected.txt:
  • svg/custom/invalid-fill-expected.txt:
  • svg/custom/invalid-viewbox1-expected.txt:
  • svg/custom/invalid-viewbox2-expected.txt:
  • svg/custom/junk-data-expected.txt:
  • svg/custom/marker-overflow-clip-expected.txt:
  • svg/custom/missing-xlink-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-path-expected.txt:
  • svg/custom/svg-overflow-types-expected.txt:

text-clip was an incorrect test, rather than an incorrect result

  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-clip.svg:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-gradient-no-content-expected.txt:
  • svg/custom/text-hit-test-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/tref-update-expected.txt:
3:04 PM Changeset in webkit [22347] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fixes <rdar://problem/4763246>
Using arrow keys in <select> popup fires onChange event

Also updates text shown in <select> element on page when using arrow
keys to change selection within the popup menu, and makes onChange fire
in the same cases as Firefox/IE.

  • rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::down): Update text of the <select> control. Change call to valueChanged() so that onChange doesn't fire. (WebCore::RenderPopupMenuWin::up): Ditto. (WebCore::PopupWndProc): Don't fire onChange anytime selection changes. Fire onChange when pressing Enter
2:57 PM Changeset in webkit [16977] by aroben
  • 5 edits in trunk/WebCore

Reviewed by Adele.

Improve popup menu behavior.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Cache m_lastOnChangeIndex so we know when to fire onChange. (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to specify whether we should fire onChange. (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire onChange when using the Enter key to change the selection.
  • html/HTMLSelectElement.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Extract setText logic into its own method. (WebCore::RenderMenuList::setTextFromOption): New method. (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call onChange instead of calling it directly here.
  • rendering/RenderMenuList.h:
2:28 PM Changeset in webkit [16976] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-10-10 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: On ActivateEvent, clear the "don't submit form twice" data member.
​http://bugs.webkit.org/show_bug.cgi?id=11242

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):
2:18 PM Changeset in webkit [16975] by adele
  • 15 edits in trunk

WebCore:

Reviewed by Beth.

  • Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text> and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea

Moved autoscroll code to the Frame class

  • bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
  • bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags. Moved autoscroll code to Frame::handleMouseMoveEvent. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown):
  • bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us. Now we scroll our views in WebCore.
  • page/Frame.cpp: (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag. (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate. Moved from FrameMac. (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too. (WebCore::Frame::mouseDownMayStartAutoscroll): Added. (WebCore::Frame::setMouseDownMayStartAutoscroll): Added. (WebCore::Frame::mouseDownMayStartDrag): Added. (WebCore::Frame::setMouseDownMayStartDrag): Added. (WebCore::Frame::autoscrollRenderer): Added (WebCore::Frame::setAutoscrollRenderer): Added. (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto.
  • page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags. Moved from FrameMac.
  • page/FrameView.cpp: Store the current mouse position in window coordinates. The callers can convert to their own coordinate space. (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection). We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too) (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.

WebKit:

Reviewed by Beth.

Removed handleAutoscrollForMouseDragged. Except for autoscroll caused by drag and drop, all other
autoscrolling should be done in WebCore instead of in AppKit.

  • WebCoreSupport/WebFrameBridge.m:
  • WebView/WebHTMLView.m:
  • WebView/WebHTMLViewPrivate.h:
2:02 PM Changeset in webkit [16974] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-10-10 bujtas <​zbujtas@gmail.com>

Reviewed by NOBODY.
DESC: changing capital includes to non-capital
​http://bugs.webkit.org/show_bug.cgi?id=11247

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLNamespace::m_ref): (khtml::): (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::startElement): (khtml::XMLTokenizer::endElement): (khtml::XMLTokenizer::characters): (khtml::XMLTokenizer::exitText): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts): (khtml::XMLTokenizer::setTransformSource): (khtml::attributesStartElementHandler): (khtml::XMLAttributes::operator=): (khtml::XMLAttributes::split):
2:00 PM Changeset in webkit [16973] by darin
  • 2 edits
    9 moves in trunk/WebCore

Rubber stamped by Maciej.

  • convert many of the loader source files to Objective-C++ to prepare to convert some of them to C++
  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/WebDataProtocol.m: Removed.
  • loader/mac/WebDocumentLoader.m: Removed.
  • loader/mac/WebFormState.m: Removed.
  • loader/mac/WebFrameLoader.m: Removed.
  • loader/mac/WebLoader.m: Removed.
  • loader/mac/WebMainResourceLoader.m: Removed.
  • loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
  • loader/mac/WebPolicyDecider.m: Removed.
  • loader/mac/WebSubresourceLoader.m: Removed.
  • loader/mac/WebDataProtocol.mm: Added.
  • loader/mac/WebDocumentLoader.mm: Added.
  • loader/mac/WebFormState.mm: Added.
  • loader/mac/WebFrameLoader.mm: Added.
  • loader/mac/WebLoader.mm: Added.
  • loader/mac/WebMainResourceLoader.mm: Added.
  • loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
  • loader/mac/WebPolicyDecider.mm: Added.
  • loader/mac/WebSubresourceLoader.mm: Added.
2:00 PM Changeset in webkit [16972] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/do-file-rename: Added.
1:10 PM Changeset in webkit [16971] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.


  • loader/mac/WebFrameLoader.m: (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Add back a mistakenly removed retain.
12:17 PM Changeset in webkit [22346] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Beth.

  • fix problem where you can't type in subframes
  • WebView.cpp: (WebViewWndProc): Use WebView's focusedTargetFrame() function instead of sending everything to the main frame.
10:01 AM Changeset in webkit [16970] by darin
  • 2 edits in trunk/WebKit
  • corrected an archive regression caused by loader refactoring (pointed out by Graham Dennis)
  • WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]): Fix selector name.
9:19 AM Changeset in webkit [16969] by brmorris
  • 33 edits
    18 adds in S60/trunk

2006-10-04 sareen <​shyam.sareen@nokia.com>

Reviewed by Zalan, yongjun.
DESC: Change the dll names BROWSER_SDK and add stub for HistoryProvider
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11148
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11149
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11150

4:03 AM Changeset in webkit [16968] by mjs
  • 2 edits in trunk/WebCore

Not reviewed, build fix.

  • fixed release build
  • WebCore.xcodeproj/project.pbxproj:
3:48 AM Changeset in webkit [16967] by mjs
  • 20 edits
    24 moves in trunk

WebCore:

Rubber stamped by Eric.

  • moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/LoaderNSURLExtras.m: Added.
  • loader/mac/WebDataProtocol.m: Added.
  • loader/mac/WebDocumentLoader.m: Added.
  • loader/mac/WebFormDataStream.m: Added.
  • loader/mac/WebFrameLoader.m: Added.
  • loader/mac/WebLoader.m: Added. (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
  • loader/mac/WebMainResourceLoader.m: Added. (-[WebMainResourceLoader didReceiveResponse:]):
  • loader/mac/WebPolicyDecider.m: Added.
  • loader/mac/WebSubresourceLoader.h: Added.
  • loader/mac/WebSubresourceLoader.m: Added.

WebKit:

Rubber stamped by Eric.


  • moved a whole bunch of stuff over to WebCore - updated includes appropriately
  • Loader/LoaderNSURLExtras.h: Removed.
  • Loader/LoaderNSURLExtras.m: Removed.
  • Loader/WebDataProtocol.h: Removed.
  • Loader/WebDataProtocol.m: Removed.
  • Loader/WebDocumentLoader.h: Removed.
  • Loader/WebDocumentLoader.m: Removed.
  • Loader/WebFormDataStream.h: Removed.
  • Loader/WebFormDataStream.m: Removed.
  • Loader/WebFormState.h: Removed.
  • Loader/WebFormState.m: Removed.
  • Loader/WebFrameLoader.h: Removed.
  • Loader/WebFrameLoader.m: Removed.
  • Loader/WebFrameLoaderClient.h: Removed.
  • Loader/WebLoader.h: Removed.
  • Loader/WebLoader.m: Removed.
  • Loader/WebMainResourceLoader.h: Removed.
  • Loader/WebMainResourceLoader.m: Removed.
  • Loader/WebNetscapePlugInStreamLoader.h: Removed.
  • Loader/WebNetscapePlugInStreamLoader.m: Removed.
  • Loader/WebPlugInStreamLoaderDelegate.h: Removed.
  • Loader/WebPolicyDecider.h: Removed.
  • Loader/WebPolicyDecider.m: Removed.
  • Loader/WebSubresourceLoader.h: Removed.
  • Loader/WebSubresourceLoader.m: Removed.
  • Misc/WebNSURLExtras.m:
  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginView.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebPluginContainerCheck.m:
  • Plugins/WebPluginController.m:
  • WebCoreSupport/WebFrameBridge.m:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m:
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebFrame.m:
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m:
  • WebView/WebPolicyDeciderMac.h:
  • WebView/WebPolicyDelegate.m:
  • WebView/WebView.m:
3:38 AM Changeset in webkit [16966] by bdash
  • 2 edits in trunk/WebKit

2006-10-10 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

Fix crash on launch in nightly builds after r16965.

Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView. If this happens,
InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
pointer.

  • Misc/WebNSURLExtras.m: (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.
2:49 AM Changeset in webkit [16965] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Oliver (sort of?)

  • WebCore part of moving down NSURL extras
  • WebCore.exp:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
2:44 AM Changeset in webkit [16964] by mjs
  • 5 edits
    2 adds in trunk/WebKit

Reviewed by Oliver.


  • split out some NSURL extras to be moved to WebCore
  • Loader/LoaderNSURLExtras.h: Added.
  • Loader/LoaderNSURLExtras.m: Added. (urlByRemovingComponent): (urlByRemovingFragment): (urlOriginalDataAsString): (urlOriginalData): (urlWithData): (WebCFAutorelease): (urlWithDataRelativeToURL): (urlByRemovingResourceSpecifier): (urlIsFileURL): (stringIsFileURL): (urlIsEmpty): (canonicalURL):
  • Loader/WebFrameLoader.m: (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (setHTTPReferrer): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader safeLoadURL:]):
  • Misc/WebNSURLExtras.m: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebKit.xcodeproj/project.pbxproj:
1:42 AM Changeset in webkit [16963] by rwlbuis
  • 12 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg animation classes.

1:06 AM Changeset in webkit [16962] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

  • added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isMainFrame]):
Note: See TracTimeline for information about the timeline view.