⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 12, 2006:

11:33 PM Changeset in webkit [17026] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Anders.

  • fast/forms/listbox-width-change-expected.txt: Added.
  • fast/forms/listbox-width-change-expected.png: Added.
  • fast/forms/listbox-width-change-expected.checksum: Added.
  • fast/forms/listbox-width-change.html: Added.

WebCore:

Reviewed by Anders.


Test: fast/forms/listbox-width-change.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc.
10:52 PM Changeset in webkit [22361] by hyatt
  • 10 edits
    2 deletes in branches/WindowsMerge/WebCore

Vote Cairo off the island.

10:49 PM Changeset in webkit [22360] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp

Remove Cairo files from WebFrame.cpp now that the Cairo paint method is gone.

10:22 PM Changeset in webkit [17025] by mjs
  • 10 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver.

  • moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/LoaderNSURLRequestExtras.h: Added.
  • loader/mac/LoaderNSURLRequestExtras.m: Added. (isConditionalRequest): (setHTTPReferrer):
  • loader/mac/WebFrameLoader.mm:
  • loader/mac/WebSubresourceLoader.mm:

WebKit:

Reviewed by Oliver.


  • liberate more WebKit code down to WebCore
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m:
8:53 PM Changeset in webkit [22359] by hyatt
  • 2 edits in branches/WindowsMerge/WebKitWin

Add code that will delete the backing store if our window gets hidden. (We are dependent on the app to make sure we get the message.)

7:29 PM Changeset in webkit [22358] by adele
  • 2 edits in branches/WindowsMerge/WebCore

RS by Geoff.

Renamed uploadControlDetaching to disconnectUploadControl.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::disconnectUploadControl):
7:28 PM Changeset in webkit [17024] by adele
  • 7 edits in trunk/WebCore

RS by Geoff.

Renamed menuListIsDetaching to disconnectMenuList,
uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.
These names match similar methods in WebCore a little better.

  • platform/FileChooser.h:
  • platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
  • platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]): (WebCore::FileChooser::disconnectUploadControl):
  • platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
7:13 PM Changeset in webkit [17023] by adele
  • 9 edits in trunk

WebCore:

Reviewed by Maciej.

WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML

Added private delegate method for clients that want access to a PopupMenu's NSMenu.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
  • bridge/mac/WebCoreFrameBridge.h:
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.

WebKit:

Reviewed by Maciej.

WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML

Added private delegate method for clients that want access to a PopupMenu's NSMenu.

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
  • WebView/WebUIDelegatePrivate.h:
6:39 PM Changeset in webkit [17022] by adele
  • 4 edits in trunk/WebCore

Reviewed by Alice.

  • Fix for <rdar://problem/4707372> After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
  • platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up, in case the RenderMenuList goes away. Also, checks the pointer to the menu list immediately afterwards.
6:33 PM Changeset in webkit [17021] by bdash
  • 3 edits in trunk/WebKitTools

2006-10-12 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Maciej.

Exclude some tests which crash or hang from Qt/Linux DRT.
These are known to fail, and will be fixed at some point :-)

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::readSkipFile): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt: Added.
6:31 PM Changeset in webkit [17020] by bdash
  • 3 edits in trunk/WebCore

2006-10-12 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Maciej.

Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
document.open(); document.write(..); and NO document.close(). On the Qt platform this
leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.

Hmpf, this took me nine hours to debug today.
Result: Couldn't find the real fix, going for a workaround for now.


540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.

  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
6:27 PM Changeset in webkit [22357] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

Fixed a small oversight from the last checkin. The populate method was calling itself,
instead of the newly renamed addItems method.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::populate):
4:04 PM Changeset in webkit [22356] by aroben
  • 3 edits
    1 move
    1 delete in branches/WindowsMerge/WebCore

Reviewed by Adele.

Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.

  • WebCore.vcproj/WebCore.vcproj: Move files within project.
  • platform/win/PopupMenuWin.cpp: Moved from rendering/RenderPopupMenuWin.cpp. Rename RenderPopupMenuWin to PopupMenu. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::setPositionAndSize): (WebCore::PopupMenu::addOption): (WebCore::PopupMenu::focusedIndex): New method to get the index of the element that is currently highlighted. This won't always be the same as the selectedIndex because of mouse hot-tracking. (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::registerPopup): (WebCore::PopupWndProc): Use focusedIndex() instead of sending messages to the popup window.
  • platform/win/TemporaryLinkStubs.cpp: Rename RenderPopupMenuWin to PopupMenu. (PopupMenu::addSeparator): (PopupMenu::addGroupLabel):
  • rendering/RenderPopupMenuWin.cpp: Removed.
  • rendering/RenderPopupMenuWin.h: Removed.
  • rendering/RenderThemeWin.cpp: Get rid of createPopupMenu() method.
  • rendering/RenderThemeWin.h: Ditto.
4:02 PM Changeset in webkit [17019] by aroben
  • 13 edits
    3 moves
    2 deletes in trunk/WebCore

Reviewed by Adele.

Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLSelectElement.cpp: Remove unnecessary #include.
  • platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp. Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate from RenderMenuList::showPopup/hidePopup. (WebCore::PopupMenu::create): New static creation method to hand back a PassRefPtr<PopupMenu>. (WebCore::PopupMenu::addItems): This platform-independent method should be called by PopupMenu::populate when the platform-specific implementation is ready to receive the menu items. Fixed an ASSERT while I was at it.
  • platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more need for virtual methods. (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::popupHandle):
  • platform/mac/PopupMenuMac.mm: Moved from rendering/RenderPopupMenuMac.mm. Much renaming ensues. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): Since we don't have our own RenderStyle anymore, just pick up the style from our RenderMenuList. (WebCore::PopupMenu::addOption): Ditto.
  • platform/win/TemporaryLinkStubs.cpp: Rename-fest. (PopupMenu::PopupMenu): (PopupMenu::~PopupMenu): (PopupMenu::clear): (PopupMenu::populate): (PopupMenu::show): (PopupMenu::hide): (PopupMenu::addSeparator): (PopupMenu::addGroupLabel): (PopupMenu::addOption):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): Use nice new simple PopupMenu::create to make the popup. (WebCore::RenderMenuList::hidePopup):
  • rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a RenderPopupMenu*. (WebCore::RenderMenuList::popup):
  • rendering/RenderPopupMenu.cpp: Removed.
  • rendering/RenderPopupMenu.h: Removed.
  • rendering/RenderPopupMenuMac.h: Removed.
  • rendering/RenderPopupMenuMac.mm: Removed.
  • rendering/RenderPopupMenuWin.h: Removed.
  • rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
  • rendering/RenderTheme.h: Ditto.
  • rendering/RenderThemeMac.h: Ditto.
  • rendering/RenderThemeMac.mm: Ditto.
  • rendering/RenderThemeWin.cpp: Ditto.
  • rendering/RenderThemeWin.h: Ditto.
2:44 PM Changeset in webkit [17018] by adele
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields.
1:42 PM Changeset in webkit [17017] by ggaren
  • 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.


Removed JSObjectMakeWithPrototype, clarified some comments. We really
don't want people to manage their own prototypes, so we don't want an
extra function in the API devoted to just that. People can still manage
their own prototypes if they really want by using JSObjectSetPrototype.

  • API/JSClassRef.cpp: (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
  • API/JSClassRef.h:
  • API/JSObjectRef.cpp: (JSClassCreate): (JSObjectMake):
  • API/JSObjectRef.h:
  • API/testapi.c: (main):
  • JavaScriptCore.exp:
1:29 PM Changeset in webkit [17016] by rwlbuis
  • 9 edits in trunk/WebCore

Reviewed by MacDome.

Finally found a way to remove our begin() trickery in FrameQt.
The (probably misnamed) Frame::setEncoding() function automatically
calls Frame::receivedFirstData() which calls being on the working
url, which has been passed to didOpenUrl(). Took me some hours
to figure out that the missing charset logic, forced us to do hacks.

1:19 PM Changeset in webkit [17015] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

Build breakage fix

  • kjs/DateMath.cpp: (KJS::msToTM):
  • kjs/date_object.cpp: (KJS::gmtoffset):
12:49 PM Changeset in webkit [17014] by brmorris
  • 2 edits in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Bradley.
DESC: Replace winscw MemMan.dll with MemMan_sdk.dll if ! -e MemMan.dll

12:22 PM Changeset in webkit [17013] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Bandaid-ing a null-dereference crash until a real fix is made.

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
11:46 AM Changeset in webkit [17012] by brmorris
  • 4 edits in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Generate/check only the correct WebKit icons depending on build flavour
​http://bugs.webkit.org/show_bug.cgi?id=11266

  • group/icons.mk: Work off BROWSER_SDK evar to check/create correct icons.
11:34 AM Changeset in webkit [17011] by aroben
  • 2 edits in trunk/WebKit

2006-10-12 MorganL <​morganl.webkit@yahoo.com>

Reviewed/landed by Adam.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11264
Windows build busted

  • COM/WebFrame.cpp: (WebFrame::receivedResponse):
10:58 AM Changeset in webkit [17010] by kmccullo
  • 5 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Added our own tm struct to have a consistent set of fields, which lets us display the DST offset and timezone strings correctly. Also there is some code cleanup.

  • kjs/DateMath.cpp: (KJS::timeToMS): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::dateToMS): (KJS::msToTM): (KJS::tmToKJStm): (KJS::KJStmToTm):
  • kjs/DateMath.h:
  • kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
  • kjs/date_object.h:
10:10 AM Changeset in webkit [22355] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix (broken by OpenSource r17006)

  • WebFrame.cpp: (WebFrame::receivedResponse):
10:04 AM Changeset in webkit [17009] by brmorris
  • 9 edits
    3 adds in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Fixes for GCCE compilation.
​http://bugs.webkit.org/show_bug.cgi?id=9435

8:07 AM Changeset in webkit [17008] by rwlbuis
  • 11 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg text classes.

5:44 AM Changeset in webkit [17007] by rwlbuis
  • 7 edits in trunk

WebCore:

Reviewed by Maciej.

Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

WebKitTools:

Reviewed by Maciej.

Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

4:50 AM Changeset in webkit [17006] by mjs
  • 9 edits in trunk/WebCore

Reviewed by Eric.

  • move m_responseMIMEType out of ResourceRequest, where it doesn't belong
  • page/FramePrivate.h: Add m_responseMIMEType
  • page/ResourceRequest.h: Remove m_responseMIMEType
  • page/Frame.cpp: (WebCore::Frame::setResponseMIMEType): added (WebCore::Frame::responseMIMEType): added (WebCore::Frame::begin): get MIME type from the right place (WebCore::Frame::write): ditto
  • page/Frame.h:
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): updated to use new Frame methods (KJS::WindowFunc::callAsFunction): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): ditto
3:36 AM Changeset in webkit [17005] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.


<rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image

We really need some way to test loadHTMLString since it keeps breaking!


  • loader/mac/WebFrameLoader.mm: (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
3:22 AM Changeset in webkit [17004] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Fix Qt/Linux build.

2:36 AM Changeset in webkit [17003] by bdash
  • 6 edits in trunk

2006-10-12 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Update Gdk\Linux build for recent changes, based on Qt code

  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::setFrame): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::receivedData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::createJavaAppletWidget): (FileChooser::create):

2006-10-12 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Also regenerate GdkLauncher makefiles, since not doing that might
lead to mismatch between WebCore and GdkLauncher compiler settings.

  • Scripts/regenerate-makefiles:
2:03 AM Changeset in webkit [22354] by hyatt
  • 12 edits in branches/WindowsMerge

Implement full-blown double buffering.

2:01 AM Changeset in webkit [17002] by hyatt
  • 13 edits in trunk/WebCore

Add more clipping retrieval functionality for widgets.

Oct 11, 2006:

6:44 PM Changeset in webkit [17001] by zbujtas
  • 3 edits in S60/trunk/WebKit

2006-10-11 brmorris <​thisisbradley@gmail.com>

Reviewed by zalan
DESC: send reindeer UA String
​http://bugs.webkit.org/show_bug.cgi?id=9189

  • BrowserView/inc/WebKitLoader.h: Update static ua string to 3.1
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL): Return static ua string if BROWSER_SDK
5:54 PM Changeset in webkit [17000] by darin
  • 11 edits in trunk/WebKit

Reviewed by Adele.

  • preparations for making more code C++
  • WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff that non-C++ files get.
  • Misc/WebKitLogging.h:
  • Misc/WebKitSystemBits.h:
  • Misc/WebLocalizableStrings.h:
  • WebCoreSupport/WebSystemInterface.h: Added extern "C".
  • Misc/WebNSViewExtras.h:
  • WebView/WebDataSource.m: (addTypesFromClass):
  • WebView/WebFrameView.m: (addTypesFromClass): Eliminated use of the identifier "class".
  • WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.
  • Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.
5:40 PM Changeset in webkit [16999] by darin
  • 14 edits in trunk/WebCore

Reviewed by John.

  • some changes to prepare for converting more code to C++
  • bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is self-sufficient.
  • bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class. Needed since the class is used in this header (for some work I have not landed yet).
  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/WebFormDataStream.h: Added extern "C" so this code can be used from C++.
  • loader/mac/LoaderNSURLExtras.m:
  • loader/mac/WebDataProtocol.mm:
  • loader/mac/WebDocumentLoader.mm:
  • loader/mac/WebFormDataStream.m:
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebPolicyDecider.mm:
  • loader/mac/WebSubresourceLoader.mm: Added missing includes of config.h.
4:18 PM Changeset in webkit [16998] by darin
  • 2 edits in trunk/WebKitLibraries

Reviewed by John Sullivan.

  • WebKitSystemInterface.h: Updated to a C++-compatible version.
4:15 PM Changeset in webkit [16997] by sullivan
  • 4 edits in trunk/WebCore

Darin wrote this code; we tested it; I give it the thumbs up.


  • fixed regression from svn revision 16982 that was generating the wrong Obj-C classes

The hash table to look up an element class given a QualifiedName was
not working at all.

  • dom/QualifiedName.h: (WebCore::QualifiedName::impl): Added. This new accessor method for impl is needed if we want to use a QualifiedName as a hash table key without doing the kind of specialization we do for String. Maybe later we can do the String thing.
  • bindings/objc/DOM.mm: (WebCore::addElementClass): Use QualifiedName.impl instead of the QualifiedName pointer itself. The QualifiedName pointer is *not* unique so almost nothing would be found in this hash table! (WebCore::elementClass): ditto
2:09 PM Changeset in webkit [16996] by aroben
  • 3 edits in trunk/WebCore

Rubberstamped by Anders.

Clean up FileChooser::create and Icon::newIconForFile.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
  • platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile):
1:39 PM Changeset in webkit [16995] by kmccullo
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin.

These test DST behavior on the cusp of a change (i.e. spring forward, fall back)

  • fast/js/date-DST-time-cusps-expected.txt: Added.
  • fast/js/date-DST-time-cusps.html: Added.
  • fast/js/resources/date-DST-time-cusps.js: Added.
11:45 AM Changeset in webkit [16994] by oliver
  • 3 edits in trunk/LayoutTests

2006-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

Fix svg text related layout tests

  • svg/custom/getsvgdocument-expected.txt:
  • svg/hixie/viewbox/003-expected.txt:
11:27 AM Changeset in webkit [16993] by oliver
  • 3 edits
    4 adds in trunk

2006-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11251
Corrects canvas tag to not throw JS exception when drawing
zero sized rects, arcs, etc

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):

Reviewed by Geoff.

Test case for ​http://bugs.webkit.org/show_bug.cgi?id=11251

  • fast/canvas/zero-size-fill-rect-expected.checksum: Added.
  • fast/canvas/zero-size-fill-rect-expected.png: Added.
  • fast/canvas/zero-size-fill-rect-expected.txt: Added.
  • fast/canvas/zero-size-fill-rect.html: Added.
11:26 AM Changeset in webkit [16992] by brmorris
  • 1 edit
    7 adds in S60/trunk/S60Internals

Reviewed by Bradley Morrison.
DESC: some support files for GCCE and RVCT compilations
​http://bugs.webkit.org/show_bug.cgi?id=9435

  • target/GCCE/SDKGCCEPatch.zip: Added.
  • target/RVCT/S60LibsRVCT.zip: Added.
  • target/RVCT/S60RVCTPatch.zip: Added.
  • target/RVCT/rvct2_2.h: Added. (std::):
11:19 AM Changeset in webkit [16991] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11221
REGRESSION: iExploder crash due to style="cursor: url()"

Take better care of empty cursor lists.

Test: fast/css/invalid-cursor-property-crash.html

10:56 AM Changeset in webkit [16990] by aroben
  • 2 edits in trunk/WebCore

Fixing Windows for real this time.

  • platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):
10:30 AM Changeset in webkit [16989] by aroben
  • 2 edits in trunk/WebCore

Fix Windows build.

  • platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):
10:14 AM Changeset in webkit [22353] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Brady.

Clean up logic in Icon::newIconForFile.

  • platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Error case should return early.
10:08 AM Changeset in webkit [22352] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fixes <rdar://problem/4777719>
Icons don't paint with CG

  • platform/win/IconWin.cpp: (WebCore::Icon::paint): Remove Cairo-specific code now that we have GraphicsContextWin.
9:54 AM Changeset in webkit [22351] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

Clean up FileChooser::create, Icon::create.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::create): Just return a FileChooser* and let the implicit cast happen.
  • platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Ditto for Icon*.
8:04 AM Changeset in webkit [16988] by antti
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=4377

  • fast/layers/layer-visibility-expected.checksum: Added.
  • fast/layers/layer-visibility-expected.png: Added.
  • fast/layers/layer-visibility-expected.txt: Added.
  • fast/layers/layer-visibility.html: Added.

WebCore:

Reviewed by Hyatt.


​http://bugs.webkit.org/show_bug.cgi?id=4377


Respect css visibility semantics for layers too

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::dirtyVisibleContentStatus): (WebCore::RenderLayer::childVisibilityChanged): (WebCore::RenderLayer::dirtyVisibleDescendantStatus): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleContent):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
12:15 AM Changeset in webkit [16987] by mjs
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Oliver.

  • added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
  • WebCore.xcodeproj/project.pbxproj:
  • platform/cf/RetainPtr.h: Added. (WTF::): (WTF::RetainPtr::RetainPtr): (WTF::RetainPtr::~RetainPtr): (WTF::RetainPtr::get): (WTF::RetainPtr::operator*): (WTF::RetainPtr::operator->): (WTF::RetainPtr::operator!): (WTF::RetainPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):


  • use it in WidgetMac so it gets tested in at least one place


  • platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setCursor): (WebCore::Widget::getView): (WebCore::Widget::setView): (WebCore::Widget::getOuterView):
Note: See TracTimeline for information about the timeline view.