Timeline
Oct 15, 2006:
- 7:00 PM Changeset in webkit [17066] by
-
- 7 edits in S60/trunk/WebCore
2006-10-13 sareen <shyam.sareen@nokia.com>
Reviewed by bujtas <zbujtas@gmail.com>
DESC: New Enum need to add for finding the whether the plugin
is interactive or not.
WARNING: NO TEST CASES ADDED OR CHANGED
- bridge/WebCoreWidget.h:
- khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::isFocusable):
- khtml/rendering/render_frames.cpp:
- khtml/rendering/render_frames.h:
- kwq/KWQObjectWidget.cpp:
- kwq/KWQObjectWidget.h:
- 6:33 PM Changeset in webkit [17065] by
-
- 16 edits in trunk
2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Anders.
Remove junk (as gcc calls it) after #else clause.
- wtf/FastMalloc.cpp: (WTF::do_free):
2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Anders.
Misc Gdk/Linux build fixes.
- platform/gdk/BrowserExtensionGdk.h:
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
- platform/gdk/FrameGdk.h:
- platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
- platform/gdk/RenderPopupMenuGdk.h:
- platform/gdk/RenderThemeGdk.cpp:
- platform/gdk/RenderThemeGdk.h: (WebCore::RenderThemeGdk::RenderThemeGdk):
- platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow): (BrowserExtensionGdk::BrowserExtensionGdk): (BrowserExtensionGdk::setTypedIconURL): (BrowserExtensionGdk::setIconURL): (BrowserExtensionGdk::getHistoryLength): (WebCore::CheckIfReloading): (WebCore::CacheObjectExpiresTime): (WebCore::ResponseURL): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): (FileChooser::disconnectUploadControl):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Anders.
Make compiler not complain about unused gk. SpinneretWebHost was not setting
initial refcount upon creation, so it is completely bogus.
- GdkLauncher/main.cpp: (main):
- Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::SpinneretWebHost):
- 3:22 PM Changeset in webkit [17064] by
-
- 7 edits in trunk/WebCore
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
Add getModifierState method to KeyboardEvent
- bindings/objc/DOMEvents.h:
- bindings/objc/DOMEvents.mm:
- bindings/objc/PublicDOMInterfaces.h:
- dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::getModifierState):
- dom/KeyboardEvent.h:
- dom/KeyboardEvent.idl:
- 2:44 PM Changeset in webkit [22366] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Geoff, Anders.
Fix crash on startup.
We were crashing somewhere inside Frame::setResourceRequest. I'm not
sure what change made this start crashing.
- WebFrame.cpp: (WebFrame::receivedResponse): Remove useless calls to Frame::resourceRequest and Frame::setResourceRequest.
- 1:52 PM Changeset in webkit [22365] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
Merge OpenSource r17056 to TemporaryLinkStubs.cpp.
- platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- 12:20 PM Changeset in webkit [17063] by
-
- 14 edits1 add in trunk/WebCore
2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by ap.
Changed PlatformResponse handling for Qt. Don't just store
a QString object containing the data but a new PlatformResponseQt struct
containing data and url, and store it as pointer. This is compatible
to the OS X handling and removes the Qt plaform specific hacks from
CachedCSSStyleSheet, CachedResource & loader.
Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
all methods from TemporaryLinkStubs related to loading in there, and implement
some like ServeSynchronousRequest (yay for xslt handling!).
- CMakeLists.txt:
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
- loader/loader.cpp: (WebCore::Loader::receivedResponse):
- platform/ResourceLoaderClient.h:
- platform/ResourceLoaderInternal.h:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::createEmptyDocument):
- platform/qt/FrameQt.h: (WebCore::QtFrame):
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::loadFinished): (WebCore::FrameQtClientDefault::receivedAllData):
- platform/qt/FrameQtClient.h:
- platform/qt/LoaderFunctionsQt.cpp: Added. (WebCore::ServeSynchronousRequest): (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckIfReloading): (WebCore::CheckCacheObjectStatus): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::remove):
- platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::receivedResponse):
- platform/qt/TemporaryLinkStubs.cpp:
- 3:00 AM Changeset in webkit [17062] by
-
- 31 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style
Cleanup coding style in svg basic datastructure classes.
Oct 14, 2006:
- 5:31 PM Changeset in webkit [17061] by
-
- 10 edits in trunk/WebCore
2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Implement some functions in FrameQt / ScrollViewQt.
Added comments what needs to be done in quite some places,
marked some functions as no-ops.
- CMakeLists.txt:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::runJavaScriptConfirm): (WebCore::FrameQt::locationbarVisible): (WebCore::FrameQt::createFrame): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::menubarVisible): (WebCore::FrameQt::personalbarVisible): (WebCore::FrameQt::statusbarVisible): (WebCore::FrameQt::toolbarVisible): (WebCore::FrameQt::markedTextRange): (WebCore::FrameQt::lastEventIsMouseUp): (WebCore::FrameQt::openURLRequest): (WebCore::FrameQt::scheduleClose): (WebCore::FrameQt::unfocusWindow): (WebCore::FrameQt::focusWindow): (WebCore::FrameQt::overrideMediaType): (WebCore::FrameQt::runJavaScriptPrompt): (WebCore::FrameQt::bindingRootObject): (WebCore::FrameQt::addPluginRootObject): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::respondToChangedSelection): (WebCore::FrameQt::respondToChangedContents): (WebCore::FrameQt::shouldChangeSelection): (WebCore::FrameQt::canGoBackOrForward): (WebCore::FrameQt::canPaste): (WebCore::FrameQt::canRedo): (WebCore::FrameQt::canUndo):
- platform/qt/FrameQt.h:
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt): (WebCore::FrameQtClientDefault::menubarVisible): (WebCore::FrameQtClientDefault::toolbarVisible): (WebCore::FrameQtClientDefault::statusbarVisible): (WebCore::FrameQtClientDefault::personalbarVisible): (WebCore::FrameQtClientDefault::locationbarVisible):
- platform/qt/FrameQtClient.h:
- platform/qt/ImageSourceQt.cpp:
- platform/qt/RenderThemeQt.cpp:
- platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollPointRecursively):
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- 5:04 PM Changeset in webkit [17060] by
-
- 2 edits in trunk/WebKitTools
2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add another hanging test, to the "to be skipped" list.
- DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
- 10:38 AM Changeset in webkit [17059] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
<rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
<rdar://problem/4783926> REGRESSION: Typing tab key enters no text
The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
of whether frame->view()->advanceFocus() actually changed the focus.
Trivial fix is to preventDefault() only if advanceFocus() returns true.
- No test is possible because DumpRenderTree sets the WebView preference to tab to links, and that preference cannot be changed dynamically after the webview is initialized. Also, the "tab from last link" is not testable because DumpRenderTree uses the WebView for the whole window, so tabs can't shift focus out of the WebView regardless.
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
- 10:21 AM Changeset in webkit [17058] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Anders.
Some fixes to get the Qt BuildSlave to run the LayoutTests.
- Scripts/build-dumprendertree: No need to call cmake again.
- Scripts/run-webkit-tests: Expose LD_LIBRARY_PATH.
- 5:53 AM Changeset in webkit [17057] by
-
- 10 edits in trunk/WebCore
Reviewed by Mitz.
Fix Qt/Linux build & some little fixes:
- Adapt to Maciej's FrameLoadRequest changes.
- Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
- Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
- Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
- loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse):
- platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow):
- platform/qt/BrowserExtensionQt.h:
- platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::openURLRequest):
- platform/qt/FrameQt.h:
- platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setURLForRect):
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- 2:42 AM Changeset in webkit [17056] by
-
- 10 edits in trunk/WebCore
2006-10-14 David Carson <dacarson@gmail.com>
Reviewed by Maciej.
Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
Removed Mac platform dependance, changed WebCore functions to
use PlatformResponse/PlatformData rather than NSURLResponse/
NSData.
- loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
- loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
- loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
- loader/CachedResource.h: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::response): (WebCore::CachedResource::allData):
- loader/LoaderFunctions.h:
- loader/loader.cpp: (WebCore::Loader::receivedResponse):
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
- 2:39 AM Changeset in webkit [17055] by
-
- 7 edits in trunk
2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Define KXMLCORE_USE_CURL for platforms that wish to use CURL as
networking, and set it for GDK build
- wtf/Platform.h:
2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
Reviewed by Maciej.
Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
Pure virtual classes require non-pure destructor, who knew.
Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
so that other platforms can also use CURL, if they wish.
Silence compiler warning about unused variable in SharedTimerLinux.cpp
- platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/gdk/FrameGdk.h: (WebCore::FrameGdkClient::~FrameGdkClient):
- platform/gdk/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::downloadTimerCallback):
- platform/gdk/SharedTimerLinux.cpp: (WebCore::stopSharedTimer):
