⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 16, 2006:

5:51 PM Changeset in webkit [22371] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin.

Fix: <rdar://problem/4758923> <select> menu text doesn't draw right
aligned on right-to-left sites

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Pass appropriate styles to CreateWindowEx so that we get a left-aligned scrollbar in RTL popups. (WebCore::PopupMenu::drawItem): Set text to be right-aligned and draw RTL when direction:rtl is set. (WebCore::PopupWndProc): Add 1px of vertical height to each menu item to match RenderListBox.
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Draw the dropdown button on the left when in RTL. (WebCore::RenderThemeWin::adjustMenuListStyle): Set padding to allow for the dropdown button being on the left in RTL.
5:48 PM Changeset in webkit [17074] by justing
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

  • editing/execCommand/nsresponder-indent-expected.checksum: Added.
  • editing/execCommand/nsresponder-indent-expected.png: Added.
  • editing/execCommand/nsresponder-indent-expected.txt: Added.
  • editing/execCommand/nsresponder-indent.html: Added.
  • editing/execCommand/nsresponder-outdent-expected.checksum: Added.
  • editing/execCommand/nsresponder-outdent-expected.png: Added.
  • editing/execCommand/nsresponder-outdent-expected.txt: Added.
  • editing/execCommand/nsresponder-outdent.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

Added Frame and bridge methods.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge indent]): (-[WebCoreFrameBridge outdent]):
  • page/Frame.cpp: (WebCore::Frame::indent): (WebCore::Frame::outdent):
  • page/Frame.h:

WebKit:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in richly editable areas. (-[NSArray indent:]): (-[NSArray outdent:]):
5:35 PM Changeset in webkit [17073] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geof.

Removed unecessary global specifiers.

  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
5:10 PM Changeset in webkit [22370] by lamadio
  • 2 edits in branches/WindowsMerge/WebKitWin
4:12 PM Changeset in webkit [17072] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

Fixes a compile order issue for testkjs on win.

2:57 PM Changeset in webkit [22369] by aroben
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Added forgotten <rdar://problem/4710456> reference to old entry.

2:54 PM Changeset in webkit [22368] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Forgot to save these changes John suggested before checking in.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::drawItem):
2:52 PM Changeset in webkit [22367] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Fix: <rdar://problem/4709480> Implement option groups
Fix: <rdar://problem/4785693> Use CG to draw popup menu items
Fix: <rdar://problem/4709487> Implement separators in <select> popups
Fix: <rdar://problem/4709358> Move CreateWindowEx calls out of PopupMenu constructor

  • platform/win/PopupMenuWin.cpp: Added some now-required #includes, moved some constants into the WebCore namespace. (WebCore::PopupMenu::PopupMenu): Moved CreateWindowEx calls into PopupMenu::show(). (WebCore::PopupMenu::show): Pass LBS_OWNERDRAWFIXED to CreateWindowEx to assume responsibility for drawing menu itesm. Removed call to set the font on the popup menu, as CG will take care of this. (WebCore::addString): Added to help with the PopupMenu::add* methods. (WebCore::PopupMenu::addOption): Use addString. (WebCore::PopupMenu::addGroupLabel): Ditto, and moved from TemporaryLinkStubs.cpp. (WebCore::PopupMenu::addSeparator): Ditto. (WebCore::PopupMenu::down): Skip items that are not enabled <option> elements, and tell the popup menu to set the selection to the element we end up on. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::drawItem): Added. This is the method that is called to draw each item in the menu. (WebCore::PopupWndProc): Add cases for WM_MEASUREITEM and WM_DRAWITEM messages (required now that we're drawing the menu items ourselves). In the cases for arrow key presses, return -2 to signify that we're handling all aspects of changing the selection.
  • platform/win/TemporaryLinkStubs.cpp: Removed PopupMenu::addSeparator and PopupMenu::addGroupLabel.
2:44 PM Changeset in webkit [17071] by aroben
  • 4 edits in trunk/WebCore

Reviewed by John.

More menulist cleanup/tweaking.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index' parameter to 'optionIndex' for clarity. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over items that are not enabled <option> elements when using arrow keys, and make sure we pass an option index to setSelectedIndex.
  • platform/PopupMenu.h: (WebCore::PopupMenu::setWasClicked): Specify default argument.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from option text before setting the control text so that options within <optgroup>s don't appear indented in the actual control.
1:52 PM Changeset in webkit [17070] by weinig
  • 9 edits in trunk/WebCore

Reviewed by Adam.

Win32 build fix.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
  • bridge/win/FrameWin.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse):
  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURLRequest): (WebCore::ServeSynchronousRequest): (WebCore::CheckIfReloading): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (CachedResource::setResponse): (CachedResource::setAllData):
  • rendering/RenderThemeWin.cpp: (WebCore::doneDrawing): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):
11:17 AM Changeset in webkit [17069] by brmorris
  • 2 edits in S60/trunk/WebCore

2006-10-16 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Fix build break in render_frames.cpp caused by r17066


  • kwq/KWQWidget.h: (QWidget::focusable): Is available when not RD_32_BROWSER
1:29 AM Changeset in webkit [17068] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 9347, positioned elements have the wrong containing block. This is a change from CSS2 to
CSS2.1. In the absence of any other enclosing positioned elements, the containing block for a positioned
element is the initial containing block (our RenderView).

Reviewed by mjs

Test cases added to fast/block/positioning for quirks and strict modes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteVertical):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
1:27 AM Changeset in webkit [17067] by hyatt
  • 8 adds in trunk/LayoutTests/fast/block/positioning

Add test cases for bug 9347.

Oct 15, 2006:

7:00 PM Changeset in webkit [17066] by zbujtas
  • 7 edits in S60/trunk/WebCore

2006-10-13 sareen <​shyam.sareen@nokia.com>

Reviewed by bujtas <​zbujtas@gmail.com>
DESC: New Enum need to add for finding the whether the plugin

is interactive or not.

​http://bugs.webkit.org/show_bug.cgi?id=11281

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreWidget.h:
  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::isFocusable):
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_frames.h:
  • kwq/KWQObjectWidget.cpp:
  • kwq/KWQObjectWidget.h:
6:33 PM Changeset in webkit [17065] by bdash
  • 16 edits in trunk

2006-10-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Anders.

Remove junk (as gcc calls it) after #else clause.

  • wtf/FastMalloc.cpp: (WTF::do_free):

2006-10-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Anders.

Misc Gdk/Linux build fixes.

  • platform/gdk/BrowserExtensionGdk.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
  • platform/gdk/RenderPopupMenuGdk.h:
  • platform/gdk/RenderThemeGdk.cpp:
  • platform/gdk/RenderThemeGdk.h: (WebCore::RenderThemeGdk::RenderThemeGdk):
  • platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow): (BrowserExtensionGdk::BrowserExtensionGdk): (BrowserExtensionGdk::setTypedIconURL): (BrowserExtensionGdk::setIconURL): (BrowserExtensionGdk::getHistoryLength): (WebCore::CheckIfReloading): (WebCore::CacheObjectExpiresTime): (WebCore::ResponseURL): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): (FileChooser::disconnectUploadControl):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:

2006-10-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Anders.

Make compiler not complain about unused gk. SpinneretWebHost was not setting
initial refcount upon creation, so it is completely bogus.

  • GdkLauncher/main.cpp: (main):
  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::SpinneretWebHost):
3:22 PM Changeset in webkit [17064] by weinig
  • 7 edits in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11294
Add getModifierState method to KeyboardEvent

  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/PublicDOMInterfaces.h:
  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::getModifierState):
  • dom/KeyboardEvent.h:
  • dom/KeyboardEvent.idl:
2:44 PM Changeset in webkit [22366] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Geoff, Anders.

Fix crash on startup.

We were crashing somewhere inside Frame::setResourceRequest. I'm not
sure what change made this start crashing.

  • WebFrame.cpp: (WebFrame::receivedResponse): Remove useless calls to Frame::resourceRequest and Frame::setResourceRequest.
1:52 PM Changeset in webkit [22365] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

Merge OpenSource r17056 to TemporaryLinkStubs.cpp.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
12:20 PM Changeset in webkit [17063] by ap
  • 14 edits
    1 add in trunk/WebCore

2006-10-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Changed PlatformResponse handling for Qt. Don't just store
a QString object containing the data but a new PlatformResponseQt struct
containing data and url, and store it as pointer. This is compatible
to the OS X handling and removes the Qt plaform specific hacks from
CachedCSSStyleSheet, CachedResource & loader.

Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
all methods from TemporaryLinkStubs related to loading in there, and implement
some like ServeSynchronousRequest (yay for xslt handling!).

  • CMakeLists.txt:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
  • loader/loader.cpp: (WebCore::Loader::receivedResponse):
  • platform/ResourceLoaderClient.h:
  • platform/ResourceLoaderInternal.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::createEmptyDocument):
  • platform/qt/FrameQt.h: (WebCore::QtFrame):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::loadFinished): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/FrameQtClient.h:
  • platform/qt/LoaderFunctionsQt.cpp: Added. (WebCore::ServeSynchronousRequest): (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckIfReloading): (WebCore::CheckCacheObjectStatus): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::remove):
  • platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/TemporaryLinkStubs.cpp:
3:00 AM Changeset in webkit [17062] by rwlbuis
  • 31 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg basic datastructure classes.

Note: See TracTimeline for information about the timeline view.