⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 17, 2006:

11:04 PM Changeset in webkit [17104] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Anders.


Factored common scaling code into a helper function.

  • platform/mac/ScreenMac.mm: (WebCore::scale): (WebCore::scaleScreenRectToPageCoordinates): (WebCore::scalePageRectToScreenCoordinates):
10:52 PM Changeset in webkit [22379] by sfalken
  • 11 edits in branches/WindowsMerge

2006-10-17 Steve Falkenburg <​sfalken@apple.com>

Reviewed by ggaren.

<rdar://4781999> History menu gets borked if you visit a page with no title.
<rdar://4782002> The History menu is frequently utterly corrupted, with incorrect favicons next to mismatched titles.
<rdar://4780252> Page titles in History menu are incorrect
<rdar://4760334> Pages without title show an old title instead of a default title


2006-10-17 Steve Falkenburg <​sfalken@apple.com>

Reviewed by ggaren.

<rdar://4781999> History menu gets borked if you visit a page with no title.
<rdar://4782002> The History menu is frequently utterly corrupted, with incorrect favicons next to mismatched titles.
<rdar://4780252> Page titles in History menu are incorrect
<rdar://4760334> Pages without title show an old title instead of a default title

  • Interfaces/IWebHistoryItemPrivate.idl: added setTitle to set title for a page after we receive it
  • WebFrame.cpp: Removed unnecessary WebFramePrivate::title (WebFrame::goToItem): Get back/forward list via frame-aware getter (WebFrame::receivedRedirect): Use BString (WebFrame::receivedResponse): Use BString. Get back/forward list, history via frame-aware getters. (WebFrame::createFrame): Use BString (WebFrame::submitForm): Clean up up BSTR usage (WebFrame::setTitle): Set title in back/forward, history when received (WebFrame::backForwardList): Frame-aware getter for back/forward (WebFrame::webHistory): Frame-aware getter for history
  • WebFrame.h: Added frame-aware getters for history, back/forward
  • WebHistory.cpp: Reorder includes. (WebHistory::QueryInterface): Support QI to WebHistory via CLSID (avoids yucky static cast in other places)
  • WebHistoryItem.cpp: (WebHistoryItem::setTitle): Added
  • WebHistoryItem.h: Added setTitle
  • WebView.cpp: (WebView::QueryInterface): Support QI to WebView via CLSID

2006-10-17 Steve Falkenburg <​sfalken@apple.com>

Build fix

  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow):
10:46 PM Changeset in webkit [17103] by sfalken
  • 9 edits in trunk/WebCore

2006-10-17 Steve Falkenburg <​sfalken@apple.com>

Build fixes

  • bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow):
  • bridge/win/BrowserExtensionWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow):
  • bridge/win/FrameWin.h:
  • platform/gdk/BrowserExtensionGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow):
  • platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow):
  • platform/qt/BrowserExtensionQt.h:
10:16 PM Changeset in webkit [22378] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.


Added WindowFeatures.h to the project.

  • WebCore.vcproj/WebCore.vcproj:
10:13 PM Changeset in webkit [17102] by ggaren
  • 7 edits
    1 copy in trunk/WebCore

Reviewed by Anders.


Renamed WindowArgs to WindowFeatures, and moved it into its own header.
("Features" is the term of art in IE documentation. "Args" is pirate
talk.)

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
  • bridge/BrowserExtension.h:
  • bridge/WindowFeatures.h: Added.
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
9:16 PM Changeset in webkit [22377] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKit.vcproj
9:15 PM Changeset in webkit [22376] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-17 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej.

Turn off a very noisy warning (unknown pragma) caused by an Interfacer include

  • WebCore.vcproj/WebCore.vcproj:
9:09 PM Changeset in webkit [17101] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-10-17 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej.


Adjust include paths

8:04 PM Changeset in webkit [17100] by weinig
  • 18 edits
    8 copies
    1 move
    1 delete in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11268
Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint

  • Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
  • Moves the contents of ksvg/bindings/js/ to bindings/js/.
  • Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
  • Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching the other CSSValue classing, and allowing the bindings to allocate appropriately.
  • Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing generation for Objective-C.
  • Assorted style cleanups.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
  • bindings/objc/DOMSVG.h:
  • bindings/objc/DOMSVGNumber.mm: (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]):
  • bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]):
  • bindings/objc/DOMSVGRect.mm: (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/StyleBase.h: (WebCore::StyleBase::isSVGColor): (WebCore::StyleBase::isSVGPaint):
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
  • ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
  • ksvg2/bindings/js/JSSVGNumber.h: Removed.
  • ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
  • ksvg2/bindings/js/JSSVGPoint.h: Removed.
  • ksvg2/bindings/js/JSSVGRect.cpp: Removed.
  • ksvg2/bindings/js/JSSVGRect.h: Removed.
  • ksvg2/svg/SVGColor.h: (WebCore::SVGColor::isSVGColor):
  • ksvg2/svg/SVGFECompositeElement.idl:
  • ksvg2/svg/SVGFEFloodElement.idl:
  • ksvg2/svg/SVGLocatable.idl:
  • ksvg2/svg/SVGMarkerElement.idl:
  • ksvg2/svg/SVGPaint.h: (WebCore::SVGPaint::isSVGPaint):
  • ksvg2/svg/SVGRectElement.idl:
  • ksvg2/svg/SVGZoomEvent.idl: Removed.
7:12 PM Changeset in webkit [17099] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog

Fix changelog file list. It wasn't right.

7:10 PM Changeset in webkit [17098] by hyatt
  • 5 edits in trunk/WebCore

Prepare for the elimination of the RenderLayer for <html> elements. The layer is still present,
but this patch makes everything work without a root layer being around.

Reviewed by beth

  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.cpp: Removed.
  • platform/KURL.h: Removed.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderLayer.cpp: (WebCore::frameVisibleRect): (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::intersectsDamageRect):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setInnerNode):
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
6:56 PM Changeset in webkit [17097] by hyatt
  • 15 edits in trunk/WebCore

Back out my previous patch to the WebCore memory cache.

  • loader/Cache.cpp: (WebCore::Cache::flush): (WebCore::Cache::setSize): (WebCore::Cache::getLRUListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::deref):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::deref):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::setRequest): (WebCore::CachedResource::deref):
  • loader/CachedResource.h: (WebCore::CachedResource::allowInLRUList):
  • loader/CachedScript.cpp: (WebCore::CachedScript::deref):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::deref):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::deref):
  • loader/CachedXSLStyleSheet.h:
6:31 PM Changeset in webkit [17096] by oliver
  • 2 edits in trunk/WebCore

2006-10-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.

Make north and east resize cursors use correct image

  • platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor):


5:39 PM Changeset in webkit [22375] by oliver
  • 6 edits in branches/WindowsMerge

2006-10-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

Fixed alpha in favicons, added composite operation conversion
for cg


rdar://problem/4758934

  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::setCompositeOperation):
  • platform/win/ImageWin.cpp: (WebCore::Image::getHBITMAP):
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForMisspelling):


Fix flickering cursor

  • WebView.cpp: (registerWebViewWindowClass):
5:30 PM Changeset in webkit [17095] by oliver
  • 5 edits in trunk/WebCore

2006-10-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady

Various cursor fixes

  • page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::pointerCursor):
  • platform/win/CursorWin.cpp: (WebCore::supportsAlphaCursors): (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::pointerCursor):
5:28 PM Changeset in webkit [17094] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4776665>
REGRESSION: In Mail, caret is visible when the message body isn't focused

  • editing/selection/4776665-expected.checksum: Added.
  • editing/selection/4776665-expected.png: Added.
  • editing/selection/4776665-expected.txt: Added.
  • editing/selection/4776665.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4776665>
REGRESSION: In Mail, caret is visible when the message body isn't focused

  • page/Frame.cpp: (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error (like when the frame that contains the caret isn't focused) then we don't want to paint the caret. We should eventually move to using a single bool for caret painting.
4:52 PM Changeset in webkit [17093] by justing
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4774354>
REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body

  • fast/repaint/4774354-expected.checksum: Added.
  • fast/repaint/4774354-expected.png: Added.
  • fast/repaint/4774354-expected.txt: Added.
  • fast/repaint/4774354.html: Added.
  • fast/repaint/resources/contenteditable-iframe-src.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4774354>
REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body

Functions call recomputCaretRect to see if the caret rect has changed,
and, if it has, they invalidate (repaint) it. recomputeCaretRect was
returning false if the caret turned into a range selection or was blown
away.

  • editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): Don't early return if !isCaret(). Obtain the FrameView* using the m_frame pointer, because m_sel may now be null.
4:37 PM Changeset in webkit [17092] by ggaren
  • 10 edits in trunk/WebCore

Reviewed by Brady.

BrowserExtension cleanup.


  • Removed unnecessary #include of BrowserExtension in Frame.h, added #includes to compensate in other files.


  • Removed unused versions of createNewWindow.


  • bindings/js/kjs_window.cpp:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/WebCoreFrameBridge.mm:
  • html/HTMLFormElement.cpp:
  • loader/mac/LoaderFunctionsMac.mm:
  • page/Frame.h:
  • page/FramePrivate.h:
2:46 PM Changeset in webkit [17091] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Brady.

Fixes a JavaScriptCore math issue on win.

  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
  • wtf/MathExtras.h: (wtf_atan2):
2:20 PM Changeset in webkit [22374] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Added HTMLFrameElementBase to the project.


  • WebCore.vcproj/WebCore.vcproj:
2:17 PM Changeset in webkit [17090] by ggaren
  • 9 edits
    2 copies in trunk/WebCore

Reviewed by Adam.


  • Fixed "FIXME: Violates Liskov Substitution principle."


IFRAME was never a true subclass of FRAME, since they disagreed on a
number of behaviors, which, confusingly, IFRAME just overrode and contradicted.

The fix here is to factor out things common to IFRAME and FRAME into a
common base class, HTMLFrameElementBase.


I also changed some " *" to "* " and added #includes in files that implicitly
assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.

12:47 PM Changeset in webkit [17089] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by sullivan


<rdar://problem/4776765>
REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)

  • fast/repaint/4776765-expected.checksum: Added.
  • fast/repaint/4776765-expected.png: Added.
  • fast/repaint/4776765-expected.txt: Added.
  • fast/repaint/4776765.html: Added.

WebCore:

Reviewed by sullivan


<rdar://problem/4776765>
REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)

We set m_needsLayout to false and call caretRect() in the hopes that it will give us
the old caret rect. It in fact corrects the caret rect for an offset that it
believes is due to scrolling but which is actually due to a change in selection
without an accompanying layout. So it returns the new caret rect regardless of
what m_needsLayout is set to.


  • editing/SelectionController.cpp: (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that adds a one pixel slop to this new function. (WebCore::SelectionController::caretRepaintRect): Moved this code to repaintRectForCaret. (WebCore::SelectionController::recomputeCaretRect): Compare the old caret rect to the new one that's computed with a fresh layout. If they are different, invalidate both repaint rects.
12:11 PM Changeset in webkit [17088] by thatcher
  • 1 copy in tags/WebKit-312.8.1/WebKit

Tag for WebKit 312.8.1 (part 2 of 2.)

12:11 PM Changeset in webkit [17087] by thatcher
  • 1 add in tags/WebKit-312.8.1

Tag for WebKit 312.8.1 (part 1 of 2.)

12:11 PM Changeset in webkit [17086] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning to 312.8.1

12:08 PM Changeset in webkit [17085] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebKit

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-09-07 Beth Dakin <Beth Dakin>

Reviewed by Darin sort of and Maciej definitely.

Fix for <rdar://problem/4719149> Crash caused by malformed frame
setup. This is the same bug as 3853672, which has been fixed on TOT
for a while. We feel like this fix is much safer for the branch
though.

  • WebKit.xcodeproj/project.pbxproj: Version wars.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[NSURLProtocol releaseResources]): Added comment for assertion that will be hit. (-[NSURLProtocol didFailWithError:]): Added comment for assertion that will be hit.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): Retain and release all of the pieces involved with sending the error.
12:06 PM Changeset in webkit [17084] by aliceli1
  • 4 edits in trunk/LayoutTests

Reviewed by Tim Hatcher.

When nodes are removed, selections are cleared, and when ​http://bugs.webkit.org/show_bug.cgi?id=6498 was fixed, we started sending didChangeSelection notifications. Updating the test results fixes some of the tests mentioned in ​http://bugs.webkit.org/show_bug.cgi?id=10924

  • fast/dynamic/move-node-with-selection-expected.txt:
  • fast/events/dblclick-addEventListener-expected.txt:
  • fast/events/updateLayoutForHitTest-expected.txt:
11:58 AM Changeset in webkit [22373] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

A couple of cleanups that Geoff suggested after my last checkin.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setPositionAndSize):
11:47 AM Changeset in webkit [22372] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fix: <rdar://problem/4772506> <select> popup menu should not clip items
when width: is set.

Popups are now sized and positioned as follows:

  1. Popups are at least as wide as the <select> control on the page.
  2. Popups for LTR <select>s are right-aligned with the <select>, popups for RTL <select>s are left-aligned. This means the scrollbar in the popup will always line up with the dropdown button in the <select>.
  3. Popups try to be wide enough to fit their widest item, but will shrink to ensure they don't extend off the screen.
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setPositionAndSize):
11:07 AM Changeset in webkit [17083] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4770453> VO not honoring secure edit fields in web pages

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isPasswordField]): New. Checks for input with inputType() of PASSWORD.


(-[WebCoreAXObject subrole]):
Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].


(-[WebCoreAXObject roleDescription]):
Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.


(-[WebCoreAXObject value]):
Return nil if [self isPasswordField].


(-[WebCoreAXObject accessibilityAttributeNames]):
Return generic attributes if [self isPasswordField].

(-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
Return empty array if [self isPasswordField].

9:51 AM Changeset in webkit [17082] by thatcher
  • 1 copy in tags/WebKit-418.9.1/WebKit

Tag for WebKit 418.9.1 (part 2 of 2.)

9:50 AM Changeset in webkit [17081] by thatcher
  • 1 add in tags/WebKit-418.9.1

Tag for WebKit 418.9.1 (part 1 of 2.)

9:49 AM Changeset in webkit [17080] by aliceli1
  • 3 edits in trunk/LayoutTests

Reviewed by aroben.

updating test results after r17068 - ​http://bugs.webkit.org/show_bug.cgi?id=11320

  • fast/block/float/013-expected.checksum:
  • fast/block/float/013-expected.txt:
9:42 AM Changeset in webkit [17079] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning to 418.9.1

9:36 AM Changeset in webkit [17078] by aroben
  • 3 edits in trunk/LayoutTests

Reviewed by Adele.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11214
http/tests/xmlhttprequest/exceptions.html needs new results

Updating results after r16794.

  • http/tests/xmlhttprequest/exceptions-expected.txt:
  • http/tests/xmlhttprequest/exceptions.html: Add comments about why we don't follow the XHR spec.
7:59 AM Changeset in webkit [17077] by brmorris
  • 2 edits in S60/trunk/S60Internals

2006-10-13 brmorris <​thisisbradley@gmail.com>

Reviewed by me.
DESC: Updated RVCT supporting libs.
​http://bugs.webkit.org/show_bug.cgi?id=9435

  • target/RVCT/S60LibsRVCT.zip: Toolbar.dll & recentstore.dll
1:52 AM Changeset in webkit [17076] by hyatt
  • 2 edits in trunk/WebCore

Fix "flash to white' problem on yahoo.com as it finishes loading. Refine the FOUC suppression
code so that it will only run if the body still has no renderer.

  • dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets):
12:32 AM Changeset in webkit [17075] by hyatt
  • 15 edits in trunk/WebCore

Fix a bug where the WebCore memory cache could grow without bound during extended browsing
sessions.

Reviewed by mjs

  • loader/Cache.cpp: (WebCore::Cache::flush): (WebCore::Cache::setSize): (WebCore::Cache::getLRUListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp:
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::setRequest): (WebCore::CachedResource::deref):
  • loader/CachedResource.h: (WebCore::CachedResource::allowInLRUList):
  • loader/CachedScript.cpp:
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:

Oct 16, 2006:

5:51 PM Changeset in webkit [22371] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin.

Fix: <rdar://problem/4758923> <select> menu text doesn't draw right
aligned on right-to-left sites

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Pass appropriate styles to CreateWindowEx so that we get a left-aligned scrollbar in RTL popups. (WebCore::PopupMenu::drawItem): Set text to be right-aligned and draw RTL when direction:rtl is set. (WebCore::PopupWndProc): Add 1px of vertical height to each menu item to match RenderListBox.
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Draw the dropdown button on the left when in RTL. (WebCore::RenderThemeWin::adjustMenuListStyle): Set padding to allow for the dropdown button being on the left in RTL.
5:48 PM Changeset in webkit [17074] by justing
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

  • editing/execCommand/nsresponder-indent-expected.checksum: Added.
  • editing/execCommand/nsresponder-indent-expected.png: Added.
  • editing/execCommand/nsresponder-indent-expected.txt: Added.
  • editing/execCommand/nsresponder-indent.html: Added.
  • editing/execCommand/nsresponder-outdent-expected.checksum: Added.
  • editing/execCommand/nsresponder-outdent-expected.png: Added.
  • editing/execCommand/nsresponder-outdent-expected.txt: Added.
  • editing/execCommand/nsresponder-outdent.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

Added Frame and bridge methods.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge indent]): (-[WebCoreFrameBridge outdent]):
  • page/Frame.cpp: (WebCore::Frame::indent): (WebCore::Frame::outdent):
  • page/Frame.h:

WebKit:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in richly editable areas. (-[NSArray indent:]): (-[NSArray outdent:]):
5:35 PM Changeset in webkit [17073] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geof.

Removed unecessary global specifiers.

  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
5:10 PM Changeset in webkit [22370] by lamadio
  • 2 edits in branches/WindowsMerge/WebKitWin
4:12 PM Changeset in webkit [17072] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

Fixes a compile order issue for testkjs on win.

2:57 PM Changeset in webkit [22369] by aroben
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Added forgotten <rdar://problem/4710456> reference to old entry.

2:54 PM Changeset in webkit [22368] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Forgot to save these changes John suggested before checking in.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::drawItem):
2:52 PM Changeset in webkit [22367] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Fix: <rdar://problem/4709480> Implement option groups
Fix: <rdar://problem/4785693> Use CG to draw popup menu items
Fix: <rdar://problem/4709487> Implement separators in <select> popups
Fix: <rdar://problem/4709358> Move CreateWindowEx calls out of PopupMenu constructor

  • platform/win/PopupMenuWin.cpp: Added some now-required #includes, moved some constants into the WebCore namespace. (WebCore::PopupMenu::PopupMenu): Moved CreateWindowEx calls into PopupMenu::show(). (WebCore::PopupMenu::show): Pass LBS_OWNERDRAWFIXED to CreateWindowEx to assume responsibility for drawing menu itesm. Removed call to set the font on the popup menu, as CG will take care of this. (WebCore::addString): Added to help with the PopupMenu::add* methods. (WebCore::PopupMenu::addOption): Use addString. (WebCore::PopupMenu::addGroupLabel): Ditto, and moved from TemporaryLinkStubs.cpp. (WebCore::PopupMenu::addSeparator): Ditto. (WebCore::PopupMenu::down): Skip items that are not enabled <option> elements, and tell the popup menu to set the selection to the element we end up on. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::drawItem): Added. This is the method that is called to draw each item in the menu. (WebCore::PopupWndProc): Add cases for WM_MEASUREITEM and WM_DRAWITEM messages (required now that we're drawing the menu items ourselves). In the cases for arrow key presses, return -2 to signify that we're handling all aspects of changing the selection.
  • platform/win/TemporaryLinkStubs.cpp: Removed PopupMenu::addSeparator and PopupMenu::addGroupLabel.
2:44 PM Changeset in webkit [17071] by aroben
  • 4 edits in trunk/WebCore

Reviewed by John.

More menulist cleanup/tweaking.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index' parameter to 'optionIndex' for clarity. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over items that are not enabled <option> elements when using arrow keys, and make sure we pass an option index to setSelectedIndex.
  • platform/PopupMenu.h: (WebCore::PopupMenu::setWasClicked): Specify default argument.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from option text before setting the control text so that options within <optgroup>s don't appear indented in the actual control.
1:52 PM Changeset in webkit [17070] by weinig
  • 9 edits in trunk/WebCore

Reviewed by Adam.

Win32 build fix.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
  • bridge/win/FrameWin.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse):
  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURLRequest): (WebCore::ServeSynchronousRequest): (WebCore::CheckIfReloading): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (CachedResource::setResponse): (CachedResource::setAllData):
  • rendering/RenderThemeWin.cpp: (WebCore::doneDrawing): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):
11:17 AM Changeset in webkit [17069] by brmorris
  • 2 edits in S60/trunk/WebCore

2006-10-16 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Fix build break in render_frames.cpp caused by r17066


  • kwq/KWQWidget.h: (QWidget::focusable): Is available when not RD_32_BROWSER
1:29 AM Changeset in webkit [17068] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 9347, positioned elements have the wrong containing block. This is a change from CSS2 to
CSS2.1. In the absence of any other enclosing positioned elements, the containing block for a positioned
element is the initial containing block (our RenderView).

Reviewed by mjs

Test cases added to fast/block/positioning for quirks and strict modes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteVertical):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
1:27 AM Changeset in webkit [17067] by hyatt
  • 8 adds in trunk/LayoutTests/fast/block/positioning

Add test cases for bug 9347.

Note: See TracTimeline for information about the timeline view.