⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 21, 2006:

11:51 PM Changeset in webkit [17207] by darin
  • 4 edits in trunk/WebCore
  • fix the Qt build
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldShowDeleteInterface):
  • platform/qt/EditorClientQt.h:
  • platform/qt/FrameQt.cpp:
11:39 PM Changeset in webkit [17206] by darin
  • 21 edits in trunk

WebCore:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)

Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
there's currently another class with that name).
Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.

Converted the classes to C++ and added Objective-C delegates to forward from
API that still requires Objective-C.

Did not yet rename the source files.

  • WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes.
  • WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
  • platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
  • loader/mac/WebLoader.h:
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.h:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: Translate to C++.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
  • loader/mac/WebFrameLoaderClient.h: Call the new C++ API.

WebKit:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream finalize]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge canRunModalNow]):
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFramePrivate finalize]): (frame): Changed from uppercase to lowercase so that it won't conflict with the WebCore class named Frame. (-[WebFrame _firstChildFrame]): (-[WebFrame _lastChildFrame]): (-[WebFrame _previousSiblingFrame]): (-[WebFrame _nextSiblingFrame]): (-[WebFrame _traverseNextFrameStayWithin:]): (-[WebFrame _immediateChildFrameNamed:]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]):
8:22 PM Changeset in webkit [22404] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fix: <rdar://problem/4794151> Popup should scroll to reveal selected
item, not just one line at a time
Fix: <rdar://problem/4794229> Popup hot-tracking should not change text
in <select> control

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Cleaned up code by translating into screen coordinates right away. (WebCore::PopupMenu::setFocusedIndex): Added parameter to specify whether the text in the <select> control should be updated. (WebCore::PopupMenu::scrollTo): Extracted scrolling code from PopupWndProc to here. (WebCore::PopupMenu::scrollToRevealSelection): New method. (WebCore::PopupWndProc): Use scrollToRevealSelection() instead of manually scrolling one line at a time. Fixed a bug in detecting a mouse drag. Pass in HDC from ::BeginPaint to PopupMenu::paint.
8:19 PM Changeset in webkit [17205] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Popup tweaks.

  • platform/PopupMenu.h:
8:10 PM Changeset in webkit [17204] by darin
  • 2 edits in trunk/WebCore
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable): Oops, edited this before landing it and introduced a null-deref! This fixes it.
7:59 PM Changeset in webkit [17203] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/commit-log-editor: Use baseProductDir() to find the base product directory. This was still using "symroots" so it almost never worked!
7:58 PM Changeset in webkit [17202] by darin
  • 12 edits in trunk/WebCore

Reviewed by Anders.

I cleaned up the relationship between the Frame, Editor, EditorClient, and
DeleteButtonController a bit while also making the simple change to fix the
assertion failure.

  • bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
  • page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
  • page/Frame.cpp: (WebCore::Frame::Frame): Ditto. (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents function, and moved it to Editor rather than right on the DeleteButtonController. (WebCore::Frame::unappliedEditing): Ditto. (WebCore::Frame::reappliedEditing): Ditto.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
  • editing/DeleteButtonController.h:
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*. The general pattern is that we always use the Frame* as the frame identifier. See FrameTree, for example. (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection function. Includes an additional check for whether the container is contentEditable, which was missing from the old version. This prevents the assertion failure. Also added a check that the table itself is editable. (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper. (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary selection parameter. No need to pass in the state of the frame since we can get it if we need it. (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
  • editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be formatted on multiple lines as usual. (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller. (WebCore::Editor::respondToChangedContents): Ditto. (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
  • editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being defined inline to decouple so that we don't have to include DeleteButtonController.h. That way changes to DeleteButtonController.h cause very little to recompile.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Updated to call the editor instead of the delete button controller for the selection change.
7:38 PM Changeset in webkit [17201] by andersca
  • 3 edits in trunk/WebCore

2006-10-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't leak the header dictionary.
7:09 PM Changeset in webkit [22403] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add new DeleteButton* files to project.
6:55 PM Changeset in webkit [17200] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • wtf/Vector.h: (WTF::VectorBuffer::swap): Added. (WTF::Vector::swap): Added. (WTF::swap): Added overload that takes two Vector objects.
6:52 PM Changeset in webkit [17199] by darin
  • 3 edits in trunk/WebKit

Reviewed by Anders.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Don't retain the web view. (WebEditorClient::~WebEditorClient): Don't release the web view. (WebEditorClient::setWebView): Ditto.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both init methods below. (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method. Also added comment pointing out design flaw -- we attach the client to the web view here, but we need to be sure to detach in case the web view is deallocated first. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
6:24 PM Changeset in webkit [17198] by darin
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Adam.

  • JavaScriptCore.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

WebCore:

Reviewed by Adam.

  • WebCore.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

WebKit:

Reviewed by Adam.

  • WebKit.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.
6:15 PM Changeset in webkit [17197] by darin
  • 3 edits
    1 copy in trunk/WebKitTools
  • Makefile: Build DumpRenderTree too.
  • Scripts/do-webcore-rename: Removed bogus comment.
11:46 AM Changeset in webkit [22402] by thatcher
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Stub out the new shouldShowDeleteInterface method.

  • WebEditorClient.cpp: (WebEditorClient::shouldShowDeleteInterface):
  • WebEditorClient.h:
11:40 AM Changeset in webkit [17196] by thatcher
  • 18 edits
    7 adds in trunk

WebCore:

Reviewed by Geoff.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Initial implementaltion of table deletion user interface:

  • Interface shows up on the nearest table containing the entire selection.
  • Shows a Dashboard style close button in the top left corner.
  • Shows a 60% opaque black outline around the table.
  • Adds a new EditorClient function shouldShowDeleteInterface.

Also adds a new constructor CachedImage and setter functions on
HTMLImageElement and HTMLImageLoader allowing an Image object to be set
and image element in the page. This change also paves the way to allow an
NSImage setter on DOMHTMLImageElement.

  • Resources/deleteButton.tiff: Added.
  • Resources/deleteButtonPressed.tiff: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h:
  • editing/DeleteButton.cpp: Added. (WebCore::DeleteButton::DeleteButton): (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
  • editing/DeleteButton.h: Added.
  • editing/DeleteButtonController.cpp: Added. (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size (WebCore::DeleteButtonController::show): shows the interface on a new element (WebCore::DeleteButtonController::hide): hides the existing interface (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
  • editing/DeleteButtonController.h: Added. (WebCore::DeleteButtonController::target): getter for the current target
  • editing/Editor.cpp: (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
  • editing/Editor.h: (WebCore::Editor::frame): new getter (WebCore::Editor::deleteButtonController): ditto
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): ditto
  • html/HTMLImageLoader.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): new constructor that takes an Image
  • loader/CachedImage.h: ditto
  • page/Frame.cpp: (WebCore::Frame::selectionController): cleanup coding style (WebCore::Frame::editor): ditto (WebCore::Frame::command): ditto (WebCore::Frame::appliedEditing): tell the delete button outline to update (WebCore::Frame::unappliedEditing): ditto (WebCore::Frame::reappliedEditing): ditto
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed

WebKit:

Reviewed by Geoff.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Initial implementaltion of table deletion user interface:

  • Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
  • The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
  • DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebEditingDelegatePrivate.h: Added.
11:37 AM Changeset in webkit [17195] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Tim H.

Cleanup bindings generation a little through re-factoring
and general style cleanup.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
8:41 AM Changeset in webkit [17194] by weinig
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Mitz.

Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.

  • CMakeLists.txt:
  • platform/qt/EditorClientQt.cpp: Added. (WebCore::EditorClientQt::shouldDeleteRange):
  • platform/qt/EditorClientQt.h: Added. (WebCore::EditorClientQt::~EditorClientQt):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
  • platform/qt/FrameQt.h:
6:34 AM Changeset in webkit [17193] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11372
Auto-generate a few more Objective-C DOM methods.

  • Auto-generate getMatchedCSSRules and getComputedStyle methods.
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Document.idl:
  • page/DOMWindow.idl:
3:15 AM Changeset in webkit [17192] by aliceli1
  • 3 edits
    1 add in trunk/WebCore

2006-10-21 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by aliu, landed by aliu.

Fix Qt/Linux build.

  • CMakeLists.txt:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
  • platform/qt/SoundQt.cpp: Added. (WebCore::systemBeep):
3:01 AM Changeset in webkit [17191] by aliceli1
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

fix leaks.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView): only change webview if its different
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): actually use the client allocated in the line above instead of allocation again, duh.
2:12 AM Changeset in webkit [17190] by ap
  • 2 edits in trunk/WebCore

2006-10-21 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Mitz, landed by ap.

Fix obscure crashes in RenderTableSection on Rob's musicdb file.
The problem was a missing layout() call on the frame view.
Thanks go to Mitz Pettel for the initial hint!

  • platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::paintEvent):
1:45 AM Changeset in webkit [17189] by aliceli1
  • 3 edits in trunk/WebKit

Build fix.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView):

Oct 20, 2006:

11:43 PM Changeset in webkit [17188] by aliceli1
  • 4 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Fixed a problem where the webview passed to the EditorClient wasn't valid yet.

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::setWebView): added webview setter
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): add default constructor
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): use [page webView] since _webview isn't valid yet (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): use webview setter on editorclient
11:37 PM Changeset in webkit [22401] by hyatt
  • 2 edits in branches/WindowsMerge/WebKitWin

Fix build bustage and horrible memory leak.

11:20 PM Changeset in webkit [17187] by sfalken
  • 2 edits in trunk/WebCore

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.

Send User-Agent on requests.
Send custom request headers properly.

  • platform/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers
11:05 PM Changeset in webkit [22400] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Hyatt.


Make the auto-version script work with paths that contain spaces

9:57 PM Changeset in webkit [17186] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix some bad formatting.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
9:48 PM Changeset in webkit [22399] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp

Match the change I made on Mac in the public tree.

9:45 PM Changeset in webkit [22398] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • WebView.cpp: (webKitVersion):
9:45 PM Changeset in webkit [17185] by hyatt
  • 2 edits in trunk/WebKit

Tweak cache sizes so that they are back to the way they were,
except for < 512, which will stay doubled.

Reviewed by Tim H.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge getObjectCacheSize]):
9:42 PM Changeset in webkit [17184] by thatcher
  • 7 edits
    4 adds in trunk/WebKitTools

Reviewed by Tim H.

Bug 11367: Inline Breakpoint Editor Improvements: Act III
​http://bugs.webkit.org/show_bug.cgi?id=11367

Major breakpoint editor changes:

  • Breakpoints can now either pause or log to console
  • Code cleanup through use of XPath and converting breakpoints to objects
  • Breakpoints now track how many times they've been reached
  • UI tweaks
  • The breakpoint editor now saves changes as they're entered
  • Because changes are auto-saved now, the save button has been converted to a close button (images from PSMTabBarControl, BSD licensed)
  • If an expression with no return is entered as a condition, it will be wrapped transparently with a return statement.
  • Drosera/DebuggerDocument.m: (-[WebScriptObject breakpointEditorHTML]): A way of loading this from an external file, as it was getting too complex to include inline.
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/Images/close.tif: Added.
  • Drosera/Images/close_active.tif: Added.
  • Drosera/Images/close_hover.tif: Added.
  • Drosera/breakpointEditor.html: Added.
  • Drosera/console.js: Added a way to append messages from outside the console window.
  • Drosera/debugger.js:
  • Drosera/viewer.css:
  • Drosera/viewer.html:
8:57 PM Changeset in webkit [22397] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.

Turn on CFNetwork

  • config.h:
8:55 PM Changeset in webkit [22396] by sfalken
  • 12 edits
    3 adds
    1 delete in branches/WindowsMerge

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


<rdar://4778502> Boomer userAgent string needs to support pulling in proper build #, plus customization


Useragent/versioning changes


Stamp auto-generated version number into DLL and into user agent.
Generate a real user agent string instead of hardcoding one.
Support client supplying an application name for the user agent.
Support client overriding the useragent (for debug menu).
Support per-URL user agents (not used at least for now).

Also fixed a bug I recently introduced that broke form submit.

7:02 PM Changeset in webkit [17183] by ggaren
  • 1 edit
    13 adds
    15 deletes in trunk/LayoutTests

RS by Beth "pants on fire" Dakin.


Put some layout tests in their place.

  • fast/dom/Window/window-object-cross-frame-calls-expected.txt: Added.
  • fast/dom/Window/window-object-cross-frame-calls.html: Added.
  • fast/dom/Window/window-onFocus-expected.checksum: Added.
  • fast/dom/Window/window-onFocus-expected.png: Added.
  • fast/dom/Window/window-onFocus-expected.txt: Added.
  • fast/dom/Window/window-onFocus.html: Added.
  • fast/dom/Window/window-xy-properties-expected.txt: Added.
  • fast/dom/Window/window-xy-properties.html: Added.
  • fast/dom/window-object-cross-frame-calls-expected.txt: Removed.
  • fast/dom/window-object-cross-frame-calls.html: Removed.
  • fast/dom/window-onFocus-expected.checksum: Removed.
  • fast/dom/window-onFocus-expected.png: Removed.
  • fast/dom/window-onFocus-expected.txt: Removed.
  • fast/dom/window-onFocus.html: Removed.
  • fast/dom/window-xy-properties-expected.txt: Removed.
  • fast/dom/window-xy-properties.html: Removed.
  • fast/html/xhtml-serialize-expected.txt: Added.
  • fast/html/xhtml-serialize.html: Added.
  • fast/js/resources/xhtml-serialize.js: Removed.
  • fast/js/resources/xslt-fragment-in-empty-doc.js: Removed.
  • fast/js/xhtml-serialize-expected.txt: Removed.
  • fast/js/xhtml-serialize.html: Removed.
  • fast/js/xslt-fragment-in-empty-doc-expected.txt: Removed.
  • fast/js/xslt-fragment-in-empty-doc.html: Removed.
  • fast/xsl/xslt-fragment-in-empty-doc-expected.txt: Added.
  • fast/xsl/xslt-fragment-in-empty-doc.html: Added.
  • fast/dom/resources/child.html: Removed.
  • fast/dom/Window/resources/child.html: Added.
6:34 PM Changeset in webkit [17182] by bdakin
  • 9 edits in trunk/LayoutTests

Reviewed by Geoff.

Changing these counters tests because they fail on some people's
machines. They fail for people who have the Armenian glyphs the
tests were looking for in the "expected" line. There is no point in
testing that anyway, since we do not currently support Armenian in
counters or in list markers.

  • fast/css/counters/counter10-expected.checksum:
  • fast/css/counters/counter10-expected.png:
  • fast/css/counters/counter10-expected.txt:
  • fast/css/counters/counter10.html:
  • fast/css/counters/counters10-expected.checksum:
  • fast/css/counters/counters10-expected.png:
  • fast/css/counters/counters10-expected.txt:
  • fast/css/counters/counters10.html:
6:07 PM Changeset in webkit [17181] by ggaren
  • 1 edit
    2 adds
    4 deletes in trunk/LayoutTests

Reviewed by Anders.


Removed old window property tests because they didn't quite work and they
were looking at me funny. Replaced with new, comprehensive test.

  • fast/dom/Window/window-properties-expected.txt: Added.
  • fast/dom/Window/window-properties.html: Added.
  • fast/js/window-properties-expected.txt: Removed.
  • fast/js/window-properties.html: Removed.
  • fast/js/window-properties2-expected.txt: Removed.
  • fast/js/window-properties2.html: Removed.
5:43 PM Changeset in webkit [17180] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4795716> REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings
  • loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key" as the key, not the dictionary itself.
4:57 PM Changeset in webkit [17179] by aliceli1
  • 13 edits
    7 adds in trunk

WebCore:

Reviewed by Maciej.

This is the initial foundation for the EditingController class and
everything else it needs to work. The idea is that the Frame has an
EditingController object that it calls to handle editing commands, the
most simple examples being copy/paste. This controller will handle
these editing commands in WebCore, and only hand off to WebKit to call
editing delegates (to the let the app intercept editing actions if it
wants to). Thus we need a platform-specific client to which the
EditingController hands off the delegate calls,
WebCoreEditingControllerClient. On the WebCore side this is an
abstract base class, and on the WebKit(Mac) side this is an ObjC++
subclass, WebEditingControllerClient. How does the EditingController
get a handle to its platform-specific client? In WebKit, the creator
of a platform-specific Frame creates the client (which is ref-counted)
and passes it down the chain of constructors until it gets back to the
EditingController, which then refs it in its constructor and derefs in
its destructor.


No Layout tests needed.


  • WebCore.xcodeproj/project.pbxproj: Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile
  • bridge/EditorClient.h: Added. (WebCore::EditorClient::~EditorClient):
  • bridge/mac/FrameMac.h: Added an EditingClient to the constructor, to pass down to Frame constructor
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Passed client down to Frame constructor


  • bridge/mac/WebCoreFrameBridge.h: Added an EditingClient to the constructor, to pass down to FrameMac constructor


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Passed client down to FrameMac constructor


  • editing/Editor.cpp: Added. Mostly stuf implementations of the following functions, except for a couple. These are all needed by cut, copy, paste, delete. (WebCore::generalPasteboard): (WebCore::Editor::canCopy): (WebCore::Editor::canCut): (WebCore::Editor::canDelete): (WebCore::Editor::canDeleteRange): (WebCore::Editor::canPaste): (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::deleteSelection): (WebCore::Editor::deleteSelectionWithSmartDelete): (WebCore::Editor::isSelectionRichlyEditable): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::selectedRange): (WebCore::Editor::shouldDeleteRange): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): (WebCore::Editor::tryDHTMLPaste): (WebCore::Editor::writeSelectionToPasteboard): (WebCore::Editor::Editor): (WebCore::Editor::~Editor): (WebCore::Editor::cut): (WebCore::Editor::copy): (WebCore::Editor::paste): (WebCore::Editor::performDelete):


  • editing/Editor.h: Added.


  • page/Frame.h: Added an EditingClient to the constructor, to pass down to Editor constructor
  • page/Frame.cpp: (WebCore::Frame::Frame): Passed down to Editor constructor (WebCore::Frame::editor): Accessfor for Editor stored in FramePrivate


  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added an Editor object to the FramePrivate data


  • platform/Sound.h: Added. Made a platform-independent accessor to a beep function


  • platform/mac/SoundMac.mm: Added. (WebCore::systemBeep): calls mac system beep

WebKit:

Reviewed by Maciej.

Adding knowledge of EditorClient to WebKit

  • WebCoreSupport/WebEditorClient.h: Added.
  • WebCoreSupport/WebEditorClient.mm: Added. (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (WebEditorClient::shouldDeleteRange): Implementation of mac EditorClient
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): create an editor client to pass down the chain of constructors
  • WebKit.xcodeproj/project.pbxproj: Added related EditorClient files
  • WebKitPrefix.h: Added tiger build flag in order to make certain private headers from webcore compile successfully
4:56 PM Changeset in webkit [22395] by aliceli1
  • 8 edits
    3 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Steve.

Adding knowledge of the Editor and EditorClient to Windows WebCore

No layout tests needed


  • WebCore.vcproj/WebCore.vcproj: added Sound.h, SoundWin.cpp, EditorClient.h, Editor.h&.cpp
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): added client to constructor params
  • bridge/win/FrameWin.h: added client to constructor params
  • platform/win/SoundWin.cpp: Added. (WebCore::systemBeep): Calls windows system beep

WebKitWin:

Reviewed by Steve and Maciej.

Adding knowledge of the Editor and EditorClient to Windows WebKit

  • Interfaces/IWebEditingDelegate.idl: needs IWebView.idl


  • WebEditorClient.cpp: Added (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldBeginEditingInRange): (WebEditorClient::shouldEndEditingInRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldChangeTypingStyle): (WebEditorClient::webViewDidBeginEditing): (WebEditorClient::webViewDidChange): (WebEditorClient::webViewDidEndEditing): (WebEditorClient::webViewDidChangeTypingStyle): (WebEditorClient::webViewDidChangeSelection):


  • WebEditorClient.h: Added.


  • WebFrame.cpp: (WebFrame::initWithWebFrameView): created an editor client


  • WebKit.vcproj/WebKit.vcproj: added WebEditorClient files
4:32 PM Changeset in webkit [17178] by hyatt
  • 2 adds in trunk/LayoutTests/fast/forms

Add encoding layout test for forms.

4:13 PM Changeset in webkit [17177] by hyatt
  • 3 edits in trunk/WebCore

Make sure to support the "encoding" property on form elements for
legacy compatibility.

Reviewed by darin/john

No test cases added. Not sure how to do a form submission of
various encodings as a layout test.

  • html/HTMLFormElement.h: (WebCore::HTMLFormElement::encoding): (WebCore::HTMLFormElement::setEncoding):
  • html/HTMLFormElement.idl:
3:55 PM Changeset in webkit [17176] by andersca
  • 3 edits in trunk/WebCore

2006-10-20 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and by Anders.

Fix warnings in JS generation by killing the whole isRefPtr logic,
and just using WTF::getPtr as Sam Weinig suggested. Also kill some
places using get() where getPtr() is cleaner - not for m_impl.get().

  • CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs.
  • bindings/scripts/CodeGeneratorJS.pm:
3:21 PM Changeset in webkit [17175] by darin
  • 21 edits in trunk

WebCore:

  • rolled out my loader change; caused world leak and possibly a plug-in crash

WebKit:

  • rolled out my loader change; caused world leak and possibly a plug-in crash
3:21 PM Changeset in webkit [17174] by andersca
  • 2 edits in trunk/WebCore

2006-10-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim H

  • loader/mac/LoaderFunctionsMac.mm: Autorelease the header NSDictionary.
2:53 PM Changeset in webkit [17173] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-10-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • bindings/js/kjs_window.cpp: (KJS::Window::timerFired): Check if the timeout id is still in the table before trying to access it. If it isn't in the table it has been deleted inside of the execute method.

LayoutTests:

2006-10-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Goeff.

Add test case for timer crash.

  • fast/dom/timer-clear-interval-in-handler-expected.txt: Added.
  • fast/dom/timer-clear-interval-in-handler.html: Added.
2:05 PM Changeset in webkit [17172] by andersca
  • 2 edits in trunk/WebCore

2006-10-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin and Geoff.

Remove debugging output.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
1:55 PM Changeset in webkit [17171] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4792755> REGRESSON: Drag selecting is erratic

No test because it would require autoscrolling, which is not available to layout tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Use hitTest() to find the correct node.


(WebCore::RenderLayer::hitTest):
Trivial source formatting.

1:07 PM Changeset in webkit [17170] by andersca
  • 2 edits in trunk/WebCore

2006-10-20 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fix regression introduced during the ResourceLoader transition (Maciej's rewrite).

  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::add):
1:05 PM Changeset in webkit [17169] by darin
  • 21 edits in trunk

WebCore:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++

Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
there's currently another class with that name).
Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.

Converted the classes to C++ and added Objective-C delegates to forward from
API that still requires Objective-C.

Did not yet rename the source files.

  • WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes.
  • WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
  • platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
  • loader/mac/WebLoader.h:
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.h:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: Translate to C++.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
  • loader/mac/WebFrameLoaderClient.h: Call the new C++ API.

WebKit:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream finalize]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge canRunModalNow]):
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFramePrivate finalize]): (frame): Changed from uppercase to lowercase so that it won't conflict with the WebCore class named Frame. (-[WebFrame _firstChildFrame]): (-[WebFrame _lastChildFrame]): (-[WebFrame _previousSiblingFrame]): (-[WebFrame _nextSiblingFrame]): (-[WebFrame _traverseNextFrameStayWithin:]): (-[WebFrame _immediateChildFrameNamed:]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]):
1:03 PM Changeset in webkit [17168] by andersca
  • 2 adds in trunk/WebKitQt/WebKitPart

Forgot to add these.

12:14 PM Changeset in webkit [17167] by andersca
  • 7 edits in trunk/WebKitQt

2006-10-20 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Adapt to FrameQtClient changes, and provide some kind of status
information to the KPart wheter we're loading or not (started/completed signaling).

  • WebKitPart/CMakeLists.txt:
  • WebKitPart/WebKitPart.cpp: (WebKitPart::WebKitPart): (WebKitPart::~WebKitPart): (WebKitPart::openUrl): (WebKitPart::initView):
  • WebKitPart/WebKitPart.h:
  • WebKitPart/WebKitPartBrowserExtension.cpp: Added. (WebKitPartBrowserExtension::WebKitPartBrowserExtension): (WebKitPartBrowserExtension::~WebKitPartBrowserExtension):
  • WebKitPart/WebKitPartBrowserExtension.h: Added.
  • WebKitPart/WebKitPartClient.cpp: (WebKitPartClient::WebKitPartClient): (WebKitPartClient::loadFinished):
  • WebKitPart/WebKitPartClient.h:
  • WebKitPart/WebKitPartInterface.h:
12:14 PM Changeset in webkit [17166] by ggaren
  • 3 edits in trunk/LayoutTests

Reviewed by Beth, approved in principle by Adele, who couldn't be troubled
for an actual review.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11345
1 fewer shouldChangeSelection delegate call for fast/forms/focus-control-to-page


I updated this test to use <input type="search"> because that's the only
remaining AppKit control, and the test's intention is verify tabbing
between AppKit and non-AppKit controls.


I updated the results because the behavior change is good.


Here's why the test regressed:


Our editing code is cra-zay. When AppKit calls nextKeyView, we not only
calculate the next key element in the page, we also focus it as a side-effect.
As a result, we used to fire a focus delegate twice, because AppKit happened
to call nextKeyView twice.


This test first regressed when Adele changed listboxes to be non-AppKit
controls (r16718). That change took AppKit out of test.


The regression redoubled itself when Adam moved TAB handling into the DOM
(r16741), taking AppKit out of TABing completely.

  • fast/forms/focus-control-to-page-expected.txt:
  • fast/forms/focus-control-to-page.html:
12:14 PM Changeset in webkit [17165] by andersca
  • 11 edits in trunk/WebCore

2006-10-20 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Offer a way for WebKitPart to be able to detect when
the webpage has been completly loaded (including subresources).

Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt
and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp.

  • CMakeLists.txt:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::client):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::checkLoaded): (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/FrameQtClient.h:
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::CheckCacheObjectStatus):
  • platform/qt/PopupMenuQt.cpp:
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::slotResult): (WebCore::ResourceLoaderManager::add):
  • platform/qt/ResourceLoaderManager.h:
  • platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::start):
12:04 PM Changeset in webkit [17164] by sfalken
  • 2 edits in trunk/WebCore

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.

Fix compiler warnings

  • platform/ResourceLoaderClient.h:
11:27 AM Changeset in webkit [17163] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geof.

Changed test to make us pass Georgian case changing for Unicode 4.0 and 5.0. This incorporates changes from the 1.4 revision of the same mozilla test.
On Tiger we are still using Unicode 4.0 but on win and Leopard we are using Unicode 5.0, so this test currently allows for either answer.

  • tests/mozilla/ecma/String/15.5.4.11-2.js:
10:58 AM Changeset in webkit [17162] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


  • fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout, taking ~1% on the PLT test
  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here because this is called too often.


  • WebView/WebView.m: (-[WebView viewWillMoveToWindow:]): Do call them here, because this is guaranteed to be called at least once for each window containing a webview, but isn't called too often. Also restructured this method a little.
10:44 AM Changeset in webkit [17161] by yongjzha
  • 2 edits in S60/trunk/MemoryManager

2006-10-20 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Sachin
DESC: WebKit Lite edition memory saving adjustment
​http://bugs.webkit.org/show_bug.cgi?id=11369

  • Src/fast_malloc.cpp:
9:51 AM Changeset in webkit [22394] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Implement (barely) more of DOMWindow.idl.

  • Interfaces/DOMWindow.idl:
9:42 AM Changeset in webkit [22393] by aroben
  • 1 edit
    1 add in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Build fix.
Stubbing out DOMWindow.idl, which was forgotten in the last checkin.

  • Interfaces/DOMWindow.idl: Added.
8:48 AM Changeset in webkit [17160] by weinig
  • 5 edits in trunk/WebCore

Reviewed by Mitz.

Win32 build fix and cleanup.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::submitForm):
  • page/ResourceRequest.h: (WebCore::ResourceRequest::addHTTPHeaderField):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Slider::~Slider): (WebCore::Slider::setMinValue): (WebCore::searchableIndexIntroduction): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): (WebCore::FrameWin::runJavaScriptPrompt): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::createEmptyDocument): (WebCore::FrameWin::overrideMediaType): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::createFrame): (WebCore::FrameWin::saveDocumentState): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::incomingReferrer): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::FrameWin::handledOnloadEvents): (WebCore::FrameWin::createPlugin): (WebCore::FrameWin::objectContentType): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::historyContains): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::defaultLanguage): (WebCore::findWordBoundary): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::startHTTPRequest): (WebCore::TextField::TextField): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::hide):
8:44 AM Changeset in webkit [17159] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11303
Path::transform() should be implemented on Qt build

Use QPainterPath API to implement Path::transform.
This fixes svg/custom/clip-path-with-transform.svg on
the qt build.

3:29 AM Changeset in webkit [17158] by rwlbuis
  • 9 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg clipping and painting classes.

2:48 AM Changeset in webkit [17157] by hyatt
  • 3 edits in trunk/WebCore

Make sure to do the code that checks the repeatInterval before the timer has been
deleted. (Duh.)

Reviewed by andersca

  • bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::setNestingLevel): (KJS::Window::timerFired): (KJS::DOMWindowTimer::fired):
  • platform/Timer.h:
12:32 AM Changeset in webkit [22392] by sfalken
  • 11 edits
    3 adds in branches/WindowsMerge

2006-10-19 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

<rdar://4771958> Holding down Ctrl when a redirect happens opens the redirected page in a new tab


Send triggering event to url selection.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
  • bridge/win/FrameWin.h: Add triggeringEvent parameter
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Call GetKeyState instead of GetAsyncKeyState
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Call GetKeyState instead of GetAsyncKeyState

2006-10-19 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

<rdar://4771958>
Holding down Ctrl when a redirect happens opens the redirected page in a new tab

Also added a bunch of DOM bindings for events.

  • DOMEventsClasses.cpp: Added.
  • DOMEventsClasses.h: Added.
  • Interfaces/DOMEvents.idl: Added.
  • WebFrame.cpp: (WebFrame::loadData): Implemented (WebFrame::openURL): Added triggeringEvent parameter
  • WebFrame.h: Added triggeringEvent parameter
  • WebKit.vcproj/Interfaces.vcproj: Added DOMEvents.idl, DOMWindow.idl
  • WebKit.vcproj/WebKit.vcproj: Added DOMEventsClasses.cpp, DOMEventsClasses.h
  • WebKit.vcproj/WebKitGUID.vcproj: Added DOMEvents_i.c
12:25 AM Changeset in webkit [17156] by hyatt
  • 3 edits in trunk/WebCore

Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached.
At that point clamp to 10ms to prevent excessive CPU usage.

Reviewed by anders

  • bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::DOMWindowTimer::nestingLevel): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::DOMWindowTimer::fired):
  • platform/Timer.h: (WebCore::TimerBase::startRepeating): (WebCore::TimerBase::startOneShot): (WebCore::TimerBase::repeatInterval): (WebCore::TimerBase::augmentRepeatInterval): (WebCore::TimerBase::inHeap): (WebCore::Timer::Timer): (WebCore::Timer::fired):
12:10 AM Changeset in webkit [17155] by sfalken
  • 2 edits in trunk/WebCore

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Build fix

  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
12:01 AM Changeset in webkit [17154] by sfalken
  • 10 edits in trunk/WebCore

2006-10-19 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Use GetKeyState rather than GetAsyncKeyState since we're
calling in these cases in direct response to an event, and want the
key state associated with that event.


Pass triggering event to url selection method.


  • bridge/mac/FrameMac.h: Add triggeringEvent parameter
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
  • bridge/win/FrameWin.h: Add triggeringEvent parameter
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
  • page/Frame.cpp: (WebCore::Frame::changeLocation): Add 0 as triggeringEvent (WebCore::Frame::urlSelected): Pass through triggeringEvent
  • page/Frame.h: Add triggeringEvent parameter to urlSelected methods
  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
  • platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState (WebCore::PlatformMouseEvent::PlatformMouseEvent):
Note: See TracTimeline for information about the timeline view.