⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 22, 2006:

5:44 PM Changeset in webkit [22406] by mjs
  • 2 edits
    2 moves
    2 adds in branches/WindowsMerge/WebCore

Reviewed by Anders.

  • updated for new ResourceLoader file locations.
  • WebCore.vcproj/WebCore.vcproj: Updated file paths.
  • platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win
  • platform/win/ResourceLoaderWin.h: ditto
5:20 PM Changeset in webkit [17210] by mjs
  • 6 edits
    15 moves
    6 adds in trunk/WebCore

Reviewed by Anders.

  • moved ResourceLoader and related files to platform/network in preparation for building out this API.

I tried to update all the build systems but I'm not sure they are
all fixed properly

  • page/ResourceRequest.h: Moved to platform/network.
  • platform/ResourceLoader.cpp: Moved to platform/network.
  • platform/ResourceLoader.h: Moved to platform/network.
  • platform/ResourceLoaderClient.h: Moved to platform/network.
  • platform/ResourceLoaderInternal.h: Moved to platform/network.
  • platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf.
  • platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk.
  • platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk.
  • platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk.
  • platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac.
  • platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt.
  • platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt.
  • platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt.
  • platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win.
  • platform/win/ResourceLoaderWin.h: Moved to platform/network/win.
  • webcore-base.bkl: Updated for new paths.
  • CMakeLists.txt: ditto
  • Projects/gdk/webcore-gdk.bkl: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • WebCoreSources.bkl: ditto
12:59 PM Changeset in webkit [22405] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fix some crashes caused by the <select> element being detached while
the popup is open.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
11:01 AM Changeset in webkit [17209] by weinig
  • 5 edits in trunk

WebCore:

Reviewed by Tim H.

  • Add DOMHTMLFormElementPrivate.h to the project.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:

WebKit:

Reviewed by Tim H.

  • Add DOMHTMLFormElementPrivate.h to the project.
  • MigrateHeaders.make:
12:31 AM Changeset in webkit [17208] by darin
  • 4 edits in trunk/WebCore
  • another try at fixing Qt
  • CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp.
  • and fix a couple warnings while I'm at it
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA): Don't do unsigned *= float.
  • rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable inside #if so it's consistent.

Oct 21, 2006:

11:51 PM Changeset in webkit [17207] by darin
  • 4 edits in trunk/WebCore
  • fix the Qt build
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldShowDeleteInterface):
  • platform/qt/EditorClientQt.h:
  • platform/qt/FrameQt.cpp:
11:39 PM Changeset in webkit [17206] by darin
  • 21 edits in trunk

WebCore:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)

Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
there's currently another class with that name).
Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.

Converted the classes to C++ and added Objective-C delegates to forward from
API that still requires Objective-C.

Did not yet rename the source files.

  • WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes.
  • WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
  • platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
  • loader/mac/WebLoader.h:
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.h:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: Translate to C++.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
  • loader/mac/WebFrameLoaderClient.h: Call the new C++ API.

WebKit:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream finalize]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge canRunModalNow]):
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFramePrivate finalize]): (frame): Changed from uppercase to lowercase so that it won't conflict with the WebCore class named Frame. (-[WebFrame _firstChildFrame]): (-[WebFrame _lastChildFrame]): (-[WebFrame _previousSiblingFrame]): (-[WebFrame _nextSiblingFrame]): (-[WebFrame _traverseNextFrameStayWithin:]): (-[WebFrame _immediateChildFrameNamed:]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]):
8:22 PM Changeset in webkit [22404] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fix: <rdar://problem/4794151> Popup should scroll to reveal selected
item, not just one line at a time
Fix: <rdar://problem/4794229> Popup hot-tracking should not change text
in <select> control

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Cleaned up code by translating into screen coordinates right away. (WebCore::PopupMenu::setFocusedIndex): Added parameter to specify whether the text in the <select> control should be updated. (WebCore::PopupMenu::scrollTo): Extracted scrolling code from PopupWndProc to here. (WebCore::PopupMenu::scrollToRevealSelection): New method. (WebCore::PopupWndProc): Use scrollToRevealSelection() instead of manually scrolling one line at a time. Fixed a bug in detecting a mouse drag. Pass in HDC from ::BeginPaint to PopupMenu::paint.
8:19 PM Changeset in webkit [17205] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Popup tweaks.

  • platform/PopupMenu.h:
8:10 PM Changeset in webkit [17204] by darin
  • 2 edits in trunk/WebCore
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable): Oops, edited this before landing it and introduced a null-deref! This fixes it.
7:59 PM Changeset in webkit [17203] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/commit-log-editor: Use baseProductDir() to find the base product directory. This was still using "symroots" so it almost never worked!
7:58 PM Changeset in webkit [17202] by darin
  • 12 edits in trunk/WebCore

Reviewed by Anders.

I cleaned up the relationship between the Frame, Editor, EditorClient, and
DeleteButtonController a bit while also making the simple change to fix the
assertion failure.

  • bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
  • page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
  • page/Frame.cpp: (WebCore::Frame::Frame): Ditto. (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents function, and moved it to Editor rather than right on the DeleteButtonController. (WebCore::Frame::unappliedEditing): Ditto. (WebCore::Frame::reappliedEditing): Ditto.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
  • editing/DeleteButtonController.h:
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*. The general pattern is that we always use the Frame* as the frame identifier. See FrameTree, for example. (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection function. Includes an additional check for whether the container is contentEditable, which was missing from the old version. This prevents the assertion failure. Also added a check that the table itself is editable. (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper. (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary selection parameter. No need to pass in the state of the frame since we can get it if we need it. (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
  • editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be formatted on multiple lines as usual. (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller. (WebCore::Editor::respondToChangedContents): Ditto. (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
  • editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being defined inline to decouple so that we don't have to include DeleteButtonController.h. That way changes to DeleteButtonController.h cause very little to recompile.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Updated to call the editor instead of the delete button controller for the selection change.
7:38 PM Changeset in webkit [17201] by andersca
  • 3 edits in trunk/WebCore

2006-10-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't leak the header dictionary.
7:09 PM Changeset in webkit [22403] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add new DeleteButton* files to project.
6:55 PM Changeset in webkit [17200] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • wtf/Vector.h: (WTF::VectorBuffer::swap): Added. (WTF::Vector::swap): Added. (WTF::swap): Added overload that takes two Vector objects.
6:52 PM Changeset in webkit [17199] by darin
  • 3 edits in trunk/WebKit

Reviewed by Anders.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Don't retain the web view. (WebEditorClient::~WebEditorClient): Don't release the web view. (WebEditorClient::setWebView): Ditto.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both init methods below. (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method. Also added comment pointing out design flaw -- we attach the client to the web view here, but we need to be sure to detach in case the web view is deallocated first. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
6:24 PM Changeset in webkit [17198] by darin
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Adam.

  • JavaScriptCore.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

WebCore:

Reviewed by Adam.

  • WebCore.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

WebKit:

Reviewed by Adam.

  • WebKit.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.
6:15 PM Changeset in webkit [17197] by darin
  • 3 edits
    1 copy in trunk/WebKitTools
  • Makefile: Build DumpRenderTree too.
  • Scripts/do-webcore-rename: Removed bogus comment.
11:46 AM Changeset in webkit [22402] by thatcher
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Stub out the new shouldShowDeleteInterface method.

  • WebEditorClient.cpp: (WebEditorClient::shouldShowDeleteInterface):
  • WebEditorClient.h:
11:40 AM Changeset in webkit [17196] by thatcher
  • 18 edits
    7 adds in trunk

WebCore:

Reviewed by Geoff.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Initial implementaltion of table deletion user interface:

  • Interface shows up on the nearest table containing the entire selection.
  • Shows a Dashboard style close button in the top left corner.
  • Shows a 60% opaque black outline around the table.
  • Adds a new EditorClient function shouldShowDeleteInterface.

Also adds a new constructor CachedImage and setter functions on
HTMLImageElement and HTMLImageLoader allowing an Image object to be set
and image element in the page. This change also paves the way to allow an
NSImage setter on DOMHTMLImageElement.

  • Resources/deleteButton.tiff: Added.
  • Resources/deleteButtonPressed.tiff: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h:
  • editing/DeleteButton.cpp: Added. (WebCore::DeleteButton::DeleteButton): (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
  • editing/DeleteButton.h: Added.
  • editing/DeleteButtonController.cpp: Added. (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size (WebCore::DeleteButtonController::show): shows the interface on a new element (WebCore::DeleteButtonController::hide): hides the existing interface (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
  • editing/DeleteButtonController.h: Added. (WebCore::DeleteButtonController::target): getter for the current target
  • editing/Editor.cpp: (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
  • editing/Editor.h: (WebCore::Editor::frame): new getter (WebCore::Editor::deleteButtonController): ditto
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): ditto
  • html/HTMLImageLoader.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): new constructor that takes an Image
  • loader/CachedImage.h: ditto
  • page/Frame.cpp: (WebCore::Frame::selectionController): cleanup coding style (WebCore::Frame::editor): ditto (WebCore::Frame::command): ditto (WebCore::Frame::appliedEditing): tell the delete button outline to update (WebCore::Frame::unappliedEditing): ditto (WebCore::Frame::reappliedEditing): ditto
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed

WebKit:

Reviewed by Geoff.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Initial implementaltion of table deletion user interface:

  • Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
  • The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
  • DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebEditingDelegatePrivate.h: Added.
11:37 AM Changeset in webkit [17195] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Tim H.

Cleanup bindings generation a little through re-factoring
and general style cleanup.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
8:41 AM Changeset in webkit [17194] by weinig
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Mitz.

Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.

  • CMakeLists.txt:
  • platform/qt/EditorClientQt.cpp: Added. (WebCore::EditorClientQt::shouldDeleteRange):
  • platform/qt/EditorClientQt.h: Added. (WebCore::EditorClientQt::~EditorClientQt):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
  • platform/qt/FrameQt.h:
6:34 AM Changeset in webkit [17193] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11372
Auto-generate a few more Objective-C DOM methods.

  • Auto-generate getMatchedCSSRules and getComputedStyle methods.
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Document.idl:
  • page/DOMWindow.idl:
3:15 AM Changeset in webkit [17192] by aliceli1
  • 3 edits
    1 add in trunk/WebCore

2006-10-21 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by aliu, landed by aliu.

Fix Qt/Linux build.

  • CMakeLists.txt:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
  • platform/qt/SoundQt.cpp: Added. (WebCore::systemBeep):
3:01 AM Changeset in webkit [17191] by aliceli1
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

fix leaks.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView): only change webview if its different
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): actually use the client allocated in the line above instead of allocation again, duh.
2:12 AM Changeset in webkit [17190] by ap
  • 2 edits in trunk/WebCore

2006-10-21 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Mitz, landed by ap.

Fix obscure crashes in RenderTableSection on Rob's musicdb file.
The problem was a missing layout() call on the frame view.
Thanks go to Mitz Pettel for the initial hint!

  • platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::paintEvent):
1:45 AM Changeset in webkit [17189] by aliceli1
  • 3 edits in trunk/WebKit

Build fix.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView):
Note: See TracTimeline for information about the timeline view.