Context Navigation

← Previous Period
Next Period →

Timeline

Oct 23, 2006:

11:19 PM Changeset in webkit [17245] by darin

19 edits in trunk

WebCore:

Reviewed by Geoff.

converted WebDocumentLoader to C++

WebCore.exp:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge mainResourceURLResponse]):
loader/mac/WebDocumentLoader.h:
loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::setMainResourceData): (WebCore::DocumentLoader::mainResourceData): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::bridge): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::addResponse): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
loader/mac/WebFrameLoader.h:
loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::detachFromParent):
loader/mac/WebFrameLoaderClient.h:

WebKit:

Reviewed by Geoff.

converted WebDocumentLoader to C++

Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _URL]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _documentLoader]): (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource webFrame]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource textEncodingName]): (-[WebDataSource isLoading]): (-[WebDataSource unreachableURL]): (-[WebDataSource webArchive]):
WebView/WebDataSourceInternal.h:
WebView/WebDocumentLoaderMac.h:
WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::dataSource): (WebDocumentLoaderMac::attachToFrame): (WebDocumentLoaderMac::detachFromFrame):
WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addChild:]): (dataSource): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame loadArchive:]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]): (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]): (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]): (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]): (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _makeRepresentationForDocumentLoader:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _provisionalLoadStarted]):
WebView/WebFrameInternal.h:
WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]):

11:18 PM Changeset in webkit [22415] by adachan

2 edits in branches/WindowsMerge/WebKitWin

2006-10-23 Ada Chan <adachan@apple.com>

Reviewed by sfalken.

We forgot to add a reference in WebNotificationCenter::addObserver.

10:13 PM Changeset in webkit [17244] by ggaren

2 edits
2 moves in trunk/WebKit

RS by Maciej.

Gave ObjC++ files .mm extension instead of .m.

WebCoreSupport/WebPageBridge.m: Removed.
WebKit.xcodeproj/project.pbxproj:
WebView/WebDocumentLoaderMac.m: Removed.

9:59 PM Changeset in webkit [17243] by beidson

6 edits in trunk/WebCore

Lovingly reviewed by Maciej

Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself

bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest

bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here

bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
bridge/mac/WebCoreFrameBridge.mm: Ditto
loader/mac/WebFrameLoader.mm: (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest

9:45 PM Changeset in webkit [17242] by ggaren

5 edits in trunk/WebCore

RS by Maciej.

Inside Frame, moved the plethora of load() and stopLoading() functions next
to each other to facilitate merging and crying.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::openURLFromPageCache): (WebCore::FrameMac::createFrame):
page/Frame.cpp: (WebCore::Frame::openURL): (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::loadSubframe): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::stop): (WebCore::Frame::closeURL): (WebCore::Frame::cancelRedirection): (WebCore::Frame::iconURL): (WebCore::Frame::didOpenURL): (WebCore::Frame::didExplicitOpen):
page/Frame.h:

9:12 PM Changeset in webkit [17241] by ggaren

3 edits in trunk/WebCore

RS by Maciej.

Moved our plethora of load() and stopLoading() functions next to each other
to facilitate merging and laughter.

loader/mac/WebFrameLoader.h:
loader/mac/WebFrameLoader.mm: (WebCore::cancelAll): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::releaseMainResourceLoader):

8:55 PM Changeset in webkit [17240] by kmccullo

3 edits in trunk/JavaScriptCore

Reviewed by

Build fix

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/grammar.y:

8:44 PM Changeset in webkit [17239] by kmccullo

4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Makes the toTM function an operator. Was going to piggy back on a patch but the patch needs more work.

kjs/DateMath.cpp: (KJS::equivalentYearForDST):
kjs/DateMath.h: (KJS::GregorianDateTime::operator tm):
kjs/date_object.cpp: (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction):

8:28 PM Changeset in webkit [17238] by darin

32 edits in trunk

WebCore:

Reviewed by Maciej.

converted WebFrameLoader to C++

WebCore.exp: Added many new entry points for WebKit.
WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge clearFrame]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
loader/mac/WebDocumentLoader.h:
loader/mac/WebDocumentLoader.mm: (-[WebDocumentLoader frameLoader]): (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader mainResourceData]): (-[WebDocumentLoader setRequest:]): (-[WebDocumentLoader bridge]): (-[WebDocumentLoader setMainDocumentError:]): (-[WebDocumentLoader mainReceivedError:complete:]): (-[WebDocumentLoader stopLoading]): (-[WebDocumentLoader setupForReplace]): (-[WebDocumentLoader commitIfReady]): (-[WebDocumentLoader finishedLoading]): (-[WebDocumentLoader commitLoadWithData:]): (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]): (-[WebDocumentLoader setupForReplaceByMIMEType:]): (-[WebDocumentLoader updateLoading]): (-[WebDocumentLoader setFrame:]): (-[WebDocumentLoader attachToFrame]): (-[WebDocumentLoader detachFromFrame]): (-[WebDocumentLoader prepareForLoadStart]): (-[WebDocumentLoader setPrimaryLoadComplete:]): (-[WebDocumentLoader isLoadingInAPISense]): (-[WebDocumentLoader setTitle:]):
loader/mac/WebFrameLoader.h: (WebCore::FrameLoader::frame):
loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::defersCallbacks): (WebCore::setAllDefersCallbacks): (WebCore::FrameLoader::setDefersCallbacks): (WebCore::cancelAll): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::isLoadingSubresources): (WebCore::FrameLoader::isLoadingPlugIns): (WebCore::FrameLoader::isLoading): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::releaseMainResourceLoader): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::timeOfLastCompletedLoad): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::load): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::download): (WebCore::FrameLoader::bridge): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::isHostedByObjectElement): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::isReplacing): (WebCore::FrameLoader::setReplacing): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::loadType): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::firstLayoutDone): (WebCore::FrameLoader::isQuickRedirectComing): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::actionInformation): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::setFrameLoaderClient): (WebCore::FrameLoader::client): (WebCore::FrameLoader::asDelegate): (-[WebCoreFrameLoaderAsDelegate initWithLoader:]): (-[WebCoreFrameLoaderAsDelegate detachFromLoader]): (-[WebCoreFrameLoaderAsDelegate continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]): (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
loader/mac/WebLoader.h: (WebCore::WebResourceLoader::identifier): (WebCore::WebResourceLoader::reachedTerminalState): (WebCore::WebResourceLoader::cancelled):
loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::releaseResources): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::frameLoader): (WebCore::WebResourceLoader::willSendRequest): (WebCore::WebResourceLoader::didReceiveAuthenticationChallenge): (WebCore::WebResourceLoader::didCancelAuthenticationChallenge): (WebCore::WebResourceLoader::didReceiveResponse): (WebCore::WebResourceLoader::didReceiveData): (WebCore::WebResourceLoader::didFinishLoading): (WebCore::WebResourceLoader::didFinishLoadingOnePart): (WebCore::WebResourceLoader::didFail): (WebCore::WebResourceLoader::willCacheResponse): (WebCore::WebResourceLoader::didCancel): (WebCore::WebResourceLoader::cancel): (WebCore::WebResourceLoader::cancelledError): (WebCore::WebResourceLoader::delegate):
loader/mac/WebMainResourceLoader.h:
loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::create): (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::policyDelegate):
loader/mac/WebNetscapePlugInStreamLoader.h:
loader/mac/WebNetscapePlugInStreamLoader.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::create): (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
loader/mac/WebSubresourceLoader.h:
loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):

WebKit:

Reviewed by Maciej.

converted WebFrameLoader to C++

History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]):
Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController pluginView:receivedResponse:]):
WebCoreSupport/WebFrameBridge.h:
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.mm: (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
WebView/WebDocumentLoaderMac.h:
WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac dealloc]): (-[WebDocumentLoaderMac attachToFrame]): (-[WebDocumentLoaderMac detachFromFrame]):
WebView/WebFrame.mm: (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _frameLoader]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame stopLoading]): (-[WebFrame reload]): (-[WebFrame _updateHistoryForCommit]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
WebView/WebFrameInternal.h:
WebView/WebHTMLView.m: (-[WebHTMLView _clearLastHitViewIfSelf]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray removeMouseMovedObserverUnconditionally]): (-[NSArray removeMouseMovedObserver]): (-[NSArray viewWillMoveToWindow:]): (-[NSArray viewDidMoveToWindow]): (-[WebHTMLView _canMakeTextSmaller]): (-[WebHTMLView _canMakeTextLarger]): (-[WebHTMLView _canMakeTextStandardSize]):
WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
WebView/WebView.mm: (-[WebView _close]): (-[WebView setDefersCallbacks:]): (-[WebView setCustomTextEncodingName:]):

8:23 PM Changeset in webkit [22414] by ggaren

3 edits in branches/WindowsMerge/WebCore

Reviewed by Bradee.

Removed methods from BrowserExtension.

bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::canPaste): (FrameWin::canGoBackOrForward): (FrameWin::goBackOrForward): (FrameWin::getHistoryLength): (FrameWin::historyURL): (Page::canRunModal): (Page::canRunModalNow): (Page::runModal): (BrowserExtensionWin::BrowserExtensionWin):

8:18 PM Changeset in webkit [17237] by kmccullo

3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fixes two regressions on win. Both are stack overflows. For one the number of regressions is capped at 100, and for the other, nested parenthesis pairs are not evaluated (since they would evaluate to whatever is in them anyway).

kjs/grammar.y:
kjs/object.cpp:

8:18 PM Changeset in webkit [17236] by ggaren

17 edits in trunk

WebCore:

Reviewed by Bradee.

Shrunk BrowserExtension in preparation for its imminent death, moving page-
level operations to Page and frame-level operations to Frame.

Removed bizarre Mac(this) syntax inside virtual FrameMac member functions,
because 'this' is guaranteed by the compiler to be a FrameMac*.

bindings/js/kjs_window.cpp: Added NULL checks for m_frame in places where it can be NULL.
bindings/js/kjs_window.cpp: (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
bridge/BrowserExtension.h: (WebCore::BrowserExtension::~BrowserExtension):
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::unfocusWindow): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::documentViewForNode): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameMac::customHighlightLineRect): (WebCore::FrameMac::paintCustomHighlight): (WebCore::FrameMac::getHistoryLength): (WebCore::FrameMac::goBackOrForward): (WebCore::FrameMac::historyURL):
bridge/mac/PageMac.mm: (WebCore::Page::canRunModal): (WebCore::Page::canRunModalNow): (WebCore::Page::runModal):
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCorePageBridge.h:
bridge/win/BrowserExtensionWin.h:
page/Frame.cpp: (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired):
page/Frame.h:
page/Page.h:

WebKit:

Reviewed by Bradee.

Moved some page-level operations from WebFrameBridge to WebPageBridge.

WebCoreSupport/WebFrameBridge.m:
WebCoreSupport/WebPageBridge.m: (-[WebPageBridge createModalDialogWithURL:referrer:]): (-[WebPageBridge canRunModal]): (-[WebPageBridge canRunModalNow]): (-[WebPageBridge runModal]):
WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support WebCore #includes.

7:36 PM Changeset in webkit [17235] by justing

2 adds in trunk/LayoutTests/editing/execCommand

7:35 PM Changeset in webkit [17234] by justing

7 edits in trunk

LayoutTests:

Reviewed by mjs

<http://bugs.webkit.org/show_bug.cgi?id=11334>
Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons

editing/execCommand/queryCommandState-01-expected.txt: Added.
editing/execCommand/queryCommandState-01.html: Added.

WebCore:

Reviewed by mjs

<http://bugs.webkit.org/show_bug.cgi?id=11334>
Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons

WebCore.xcodeproj/project.pbxproj:
editing/Editor.cpp: (WebCore::Editor::selectionUnorderedListState): Added. (WebCore::Editor::selectionOrderedListState): Added.
editing/Editor.h:
editing/JSEditor.cpp:
page/Frame.cpp:
page/Frame.h:

4:57 PM Changeset in webkit [17233] by sullivan

2 edits in trunk/WebKit

WebKitPrefix.h: Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had already been added between the last time I updated in this tree and when I needed it locally.

4:10 PM Changeset in webkit [17232] by sullivan

1 edit in trunk/WebKit/WebKitPrefix.h

Checked in this file that I mentioned in the previous ChangeLog entry but forgot to check in.

4:03 PM Changeset in webkit [17231] by sullivan

2 edits in trunk/WebKit

Reviewed by Ander

WebKit.xcodeproj/project.pbxproj: Move WebKitPrefix.h from Misc group to top level, to match WebCore

WebKitPrefix.h: defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API

3:56 PM Changeset in webkit [17230] by sullivan

2 edits in trunk/WebCore

Reviewed by Tim H

WebCore.xcodeproj/project.pbxproj: Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit

3:40 PM Changeset in webkit [17229] by thatcher

4 edits
10 moves in trunk/WebKit

Reviewed by Darin.

Rename the now ObjC++ files to be .mm and remove the explicit file types.

DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
English.lproj/StringsNotToBeLocalized.txt:
Plugins/WebBaseNetscapePluginView.m: Removed.
Plugins/WebNetscapePluginStream.m: Removed.
Plugins/WebPluginController.m: Removed.
WebCoreSupport/WebFrameBridge.m: Removed.
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: Removed.
WebView/WebFrame.m: Removed.
WebView/WebFrameView.m: Removed.
WebView/WebPDFView.m: Removed.
WebView/WebPolicyDelegate.m: Removed.
WebView/WebView.m: Removed.

3:27 PM Changeset in webkit [17228] by thatcher

5 edits
2 adds in trunk/WebKit

Reviewed by Darin.

Move the undef try/catch to WebKitPrfix.h and include algorithm so we get
exception_defines.h and so the undef of try/catch works.

Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
framework to complain about C++ exceptions being disabled.

Misc/WebGraphicsExtras.c: Added. (WebConvertBGRAToARGB):
Misc/WebGraphicsExtras.h: Added.
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
WebKit.xcodeproj/project.pbxproj:
WebKitPrefix.h:
WebView/WebView.m:

3:22 PM Changeset in webkit [17227] by weinig

3 edits
16 adds
16 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11291
PNG as cursor image format instead of TIFF

Original patch by Lars Naesbye Christensen (larsnaesbye@stud.ku.dk)

Convert cursor images from TIFF to PNG.

Resources/eastResizeCursor.png: Added.
Resources/eastResizeCursor.tiff: Removed.
Resources/eastWestResizeCursor.png: Added.
Resources/eastWestResizeCursor.tiff: Removed.
Resources/helpCursor.png: Added.
Resources/helpCursor.tiff: Removed.
Resources/linkCursor.png: Added.
Resources/linkCursor.tiff: Removed.
Resources/moveCursor.png: Added.
Resources/moveCursor.tiff: Removed.
Resources/northEastResizeCursor.png: Added.
Resources/northEastResizeCursor.tiff: Removed.
Resources/northEastSouthWestResizeCursor.png: Added.
Resources/northEastSouthWestResizeCursor.tiff: Removed.
Resources/northResizeCursor.png: Added.
Resources/northResizeCursor.tiff: Removed.
Resources/northSouthResizeCursor.png: Added.
Resources/northSouthResizeCursor.tiff: Removed.
Resources/northWestResizeCursor.png: Added.
Resources/northWestResizeCursor.tiff: Removed.
Resources/northWestSouthEastResizeCursor.png: Added.
Resources/northWestSouthEastResizeCursor.tiff: Removed.
Resources/southEastResizeCursor.png: Added.
Resources/southEastResizeCursor.tiff: Removed.
Resources/southResizeCursor.png: Added.
Resources/southResizeCursor.tiff: Removed.
Resources/southWestResizeCursor.png: Added.
Resources/southWestResizeCursor.tiff: Removed.
Resources/waitCursor.png: Added.
Resources/waitCursor.tiff: Removed.
Resources/westResizeCursor.png: Added.
Resources/westResizeCursor.tiff: Removed.
WebCore.xcodeproj/project.pbxproj:
platform/mac/CursorMac.mm: (WebCore::leakNamedCursor):

3:15 PM Changeset in webkit [17226] by mjs

3 edits in trunk/WebCore

Not reviewed.

fixed build from last change.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::openURL):

3:03 PM Changeset in webkit [22413] by aroben

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adele.

Fix: <rdar://problem/4796994> Styled <select>s should still use Windows
theme

The fix is to do most of our drawing for menulists in
RenderThemeWin::paintMenuListButton (which is called for styled
<select>s), and then do any extra drawing for unstyled <select>s in
RenderThemeWin::paintMenuList.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::getThemeData): Case for MenulistButtonAppearance should be the same as MenulistAppearance. (WebCore::RenderThemeWin::paintMenuList): Draw the border, then defer to paintMenuListButton to handle the rest of painting. (WebCore::RenderThemeWin::adjustMenuListStyle): Reset the border so we can draw our own, then defer to adjustMenuListStyle. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Code moved from adjustMenuListStyle, less the call to resetBorder(). (WebCore::RenderThemeWin::paintMenuListButton): Code moved from paintMenuList, less the border-drawing code.
rendering/RenderThemeWin.h:

3:00 PM Changeset in webkit [17225] by aroben

3 edits in trunk/WebCore

Reviewed by Adele.

Move border-radius rule for <select>s into RenderThemeMac, as this is
really a platform-specific look.

css/html4.css:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListButtonStyle):

2:53 PM Changeset in webkit [22412] by sfalken

8 edits in branches/WindowsMerge/WebKitWin

2006-10-23 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou.

MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToCFStringRef): Fix leak in BSTRToCFStringRef
WebEditorClient.cpp: (WebEditorClient::WebEditorClient): Break dependency cycle by not holding a COM ref to the WebView (WebEditorClient::~WebEditorClient): Break dependency cycle by not holding a COM ref to the WebView
WebFrame.cpp: (WebFrame::initWithWebFrameView): (WebFrame::windowResizerRect): Fix reference leaks
WebHistory.cpp: (createUserInfoFromArray): Fixed leak of key CFStringRef. (WebHistory::setOptionalSharedHistory): Made this callable with a 0 to release shared history (_WebCoreHistoryProvider::_WebCoreHistoryProvider): Don't hold a ref to the WebHistory (_WebCoreHistoryProvider::~_WebCoreHistoryProvider): Don't hold a ref to the WebHistory (_WebCoreHistoryProvider::containsItemForURLLatin1): Don't hold a ref to the WebHistoryPrivate
WebHistoryItem.cpp: (WebHistoryItem::WebHistoryItem): Don't hold a reference to the WebIconDatabase
WebIconDatabase.cpp: (WebIconDatabase::~WebIconDatabase): Delete core icon db on delete
WebNotificationCenter.cpp: (ObserverKey::ObserverKey): Init data to 0 before calling assignment op (ObserverKey::operator=): Free old string, release old ref if needed before copy

2:44 PM Changeset in webkit [17224] by mjs

3 edits in trunk/WebCore

Reviewed by Brady.

moved things around so loadURL:... is only called from one place

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):

2:29 PM Changeset in webkit [17223] by justing

7 edits
20 adds in trunk

LayoutTests:

Reviewed by john

<http://bugs.webkit.org/show_bug.cgi?id=11333>
Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document

editing/inserting/insert-br-009-expected.checksum: Added.
editing/inserting/insert-br-009-expected.png: Added.
editing/inserting/insert-br-009-expected.txt: Added.
editing/inserting/insert-br-009.html: Added.
editing/inserting/insert-paragraph-01-expected.checksum: Added.
editing/inserting/insert-paragraph-01-expected.png: Added.
editing/inserting/insert-paragraph-01-expected.txt: Added.
editing/inserting/insert-paragraph-01.html: Added.
editing/inserting/insert-paragraph-02-expected.checksum: Added.
editing/inserting/insert-paragraph-02-expected.png: Added.
editing/inserting/insert-paragraph-02-expected.txt: Added.
editing/inserting/insert-paragraph-02.html: Added.
editing/inserting/insert-paragraph-03-expected.checksum: Added.
editing/inserting/insert-paragraph-03-expected.png: Added.
editing/inserting/insert-paragraph-03-expected.txt: Added.
editing/inserting/insert-paragraph-03.html: Added.
editing/inserting/insert-paragraph-04-expected.checksum: Added.
editing/inserting/insert-paragraph-04-expected.png: Added.
editing/inserting/insert-paragraph-04-expected.txt: Added.
editing/inserting/insert-paragraph-04.html: Added.

WebCore:

Reviewed by john

<http://bugs.webkit.org/show_bug.cgi?id=11333>
Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document

Added special cases in InsertLineBreakCommand for inserting before
and after tables and horizontal rules. Also, perform InsertLineBreak
instead of InsertParagraphSeparator at these positions.

editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Use the canonical form of the caret position when we check for the new special cases because we know that we canonicalize VisiblePositions to those positions. Added code to handle inserting before/after tables and horizontal rules. Fixed a bug when inserting at the end of a block (it checked for a collapse of the inserted br by looking for the absence of a br, but the line break might have been a '\n' in white-space:pre text). Removed unused LOGs.
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an InsertLineBreakCommand when before/after a table or a horizontal rule so that we don't have to maintain two pieces of special case code. Migrated to enclosingBlock.
editing/htmlediting.cpp: Added a FIXME.
editing/visible_units.cpp: (WebCore::startOfParagraph): Added a workaround for 8622.

1:59 PM Changeset in webkit [17222] by sfalken

2 edits in trunk/JavaScriptCore

2006-10-21 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Add minimal compatibility with MSVCRT leak checker

wtf/FastMalloc.h:

1:37 PM Changeset in webkit [22411] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fix: <rdar://problem/4786759> PageUp/PageDown/Home/End don't work in
<select> menus

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setFocusedIndex): Only call ::UpdateWindow if we didn't scroll, because scrolling will do the update for us. (WebCore::PopupMenu::focusFirst): New method. (WebCore::PopupMenu::focusLast): New method. (WebCore::PopupMenu::down): Add a parameter to specify how far we should try to move the selection. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::invalidateItem): Cleanup code by using IntRect instead of RECT. (WebCore::PopupMenu::scrollTo): Return a boolean to say whether scrolling actually happened. (WebCore::PopupMenu::scrollToRevealSelection): Ditto. (WebCore::PopupWndProc): Handle PageUp/PageDown/Home/End.

1:34 PM Changeset in webkit [17221] by aroben

2 edits in trunk/WebCore

Reviewed by Adele.

Make popups a little more flexible.

platform/PopupMenu.h:

12:45 PM Changeset in webkit [17220] by weinig

2 edits in trunk/WebCore

Reviewed by Tim H.

Cleanup CodeGeneratorJS.pm

bindings/scripts/CodeGeneratorJS.pm:

12:21 PM Changeset in webkit [17219] by thatcher

2 edits in trunk/WebCore/Resources

Reverting two images that got commited as empty files after being compressed.

12:03 PM Changeset in webkit [17218] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by Geof.

Sets the lowercase range correctly in the test and consolidates a variable to make the test more readable.

tests/mozilla/ecma/String/15.5.4.11-2.js:

11:58 AM Changeset in webkit [17217] by thatcher

2 edits in trunk/WebKit

Build fix.

11:35 AM Changeset in webkit [17216] by thatcher

2 edits in trunk

Build fix. We can't make the internal DOM headers private since they are not generated at the time installhdrs is called, this break B&I builds.

11:24 AM Changeset in webkit [22410] by aroben

9 edits in branches/WindowsMerge

WebCoreWin:

Build fix.

WebCore.vcproj/WebCore.vcproj: Copy headers from new platform/network directory and subdirectories.

WebKitWin:

Build fix.

WebFrame.cpp: Change header paths to point to new platform/network directory and subdirectories.
WebFrame.h: Ditto.
WebURLResponse.cpp: Ditto.
WebURLResponse.h: Ditto.
WebView.cpp: Ditto.
WebKit.vcproj/WebKit.vcproj: Add platform/network and subdirectories to AdditionalIncludeDirectories.

11:23 AM Changeset in webkit [17215] by thatcher

4 edits in trunk/WebCore/Resources

Compressing TIFFs to fix verification error.

10:02 AM Changeset in webkit [22409] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

plugins/win/PluginStreamWin.h: Rename methods to match Maciej's changes.

9:50 AM Changeset in webkit [17214] by aroben

2 edits in trunk/WebCore

Rubberstamped by Brady.

loader/icon/IconLoader.h: Changed angle-brackets to quotes for #include of ResourceLoader.h, since it's a WebCore header.

9:50 AM Changeset in webkit [22408] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj: Copied AdditionalIncludeDirectories from Release to All Configurations.

8:47 AM Changeset in webkit [17213] by darin

2 edits in trunk/WebCore

fixed mistake that was preventing any loading from happening

platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): Changed parameter back to int. Perhaps we want to move to "long long" consistently, but I'll leave that up to Maciej.

3:01 AM Changeset in webkit [22407] by mjs

7 edits in branches/WindowsMerge

WebCoreWin:

Rubber-stamped by Anders.

fixed for ResourceLoader refactoring.

platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

WebKitWin:

Rubber-stamped by Anders.

fixed for ResourceLoader refactoring.

WebFrame.cpp: (WebFrame::didReceiveData): (WebFrame::didFinishLoading):
WebFrame.h:

2:07 AM Changeset in webkit [17212] by mjs

17 edits in trunk/WebCore

Reviewed by Anders.

start converting ResourceLoaderClient to new API

Did the bits I could do without introducing new types:

renamed receivedData to didReceiveData
renamed version of receivedAllData that doesn't pass any data to didFinishLoading

bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
loader/icon/IconLoader.cpp: (IconLoader::didReceiveData): (IconLoader::didFinishLoading):
loader/icon/IconLoader.h:
loader/loader.cpp: (WebCore::Loader::didReceiveData):
loader/loader.h:
platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::didReceiveData):
platform/gdk/FrameGdk.h:
platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): (WebCore::ResourceLoaderClient::didFinishLoading): (WebCore::ResourceLoaderClient::receivedResponse):
platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceLoader::cancel):
platform/network/gdk/ResourceLoaderManager.cpp: (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove):
platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::remove):
platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::didReceiveData):
platform/qt/FrameQtClient.h:
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
xml/xmlhttprequest.h:

1:00 AM Changeset in webkit [17211] by mjs