⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 25, 2006:

10:04 PM Changeset in webkit [17299] by darin
  • 40 edits in trunk

WebCore:

Reviewed by Anders.

  • removed 55 methods from WebCoreFrameBridge
  • changed callers to use Frame directly instead
  • put FrameLoaderTypes.h types into the WebCore namespace
  • first steps to get FrameLoader.h ready for cross-platform duty
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::startRedirectionTimer): (WebCore::FrameMac::stopRedirectionTimer): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::FrameMac::handledOnloadEvents): (WebCore::FrameMac::isLoadTypeReload):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge executionContextForView:]): (updateRenderingForBindings): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebCoreFrameBridge installInFrame:]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • loader/FrameLoaderTypes.h:
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense):
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy): (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • platform/mac/ListBoxMac.mm: (-[WebCoreTableView keyDown:]): (-[WebCoreTableView keyUp:]):
  • platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]):

WebKit:

Reviewed by Anders.

  • removed 55 methods from WebCoreFrameBridge
  • changed callers to use Frame directly instead
  • put FrameLoaderTypes.h types into the WebCore namespace
  • first steps to get FrameLoader.h ready for cross-platform duty
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView getVariable:value:]):
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _continueWithPolicy:]): (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge webView]): (-[WebFrameBridge finishInitializingWithFrameName:view:]): (-[WebFrameBridge createWindowWithURL:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge createModalDialogWithURL:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchWillSubmitForm):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithImageResource:]): (-[WebDataSource _imageElementWithImageResource:]):
  • WebView/WebEditingDelegatePrivate.h:
  • WebView/WebFrame.mm: (core): (kit): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _childFramesMatchItem:]): (-[WebFrame _URLsMatchItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _viewWillMoveToHostWindow:]): (-[WebFrame _viewDidMoveToHostWindow]): (-[WebFrame _addChild:]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _numPendingOrLoadingRequests:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): (-[WebFrame _initWithWebFrameView:webView:coreFrame:]): (-[WebFrame _documentViews]): (-[WebFrame _updateBackground]): (-[WebFrame _unmarkAllMisspellings]): (-[WebFrame _hasSelection]): (-[WebFrame _atMostOneFrameHasSelection]): (-[WebFrame _findFrameWithSelection]): (-[WebFrame _frameLoader]): (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:webView:]): (-[WebFrame dealloc]): (-[WebFrame finalize]): (-[WebFrame name]): (-[WebFrame webView]): (-[WebFrame DOMDocument]): (-[WebFrame frameElement]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame childFrames]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]): (-[WebHTMLRepresentation attributedText]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): (-[WebHTMLView _selectedRange]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _isSelectionInPasswordField]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView _selectionDraggingImage]): (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _updateActiveState]): (-[NSArray readSelectionFromPasteboard:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray maintainsInactiveSelection]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray centerSelectionInVisibleArea:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray _emptyStyle]): (-[NSArray performKeyEquivalent:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView selectionRect]): (-[WebHTMLView selectionImageForcingWhiteText:]): (-[WebHTMLView selectionImageRect]): (-[WebHTMLView attributedString]): (-[WebHTMLView _isMoveDrag]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebPolicyDelegate.mm: (-[WebPolicyDecisionListener _usePolicy:]): (-[WebPolicyDecisionListener use]): (-[WebPolicyDecisionListener ignore]): (-[WebPolicyDecisionListener download]): (-[WebPolicyDecisionListener continue]):
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]): (-[WebScriptCallFrame globalObject]):
  • WebView/WebView.mm: (-[WebView _attachScriptDebuggerToAllFrames]): (-[WebView _detachScriptDebuggerFromAllFrames]): (-[WebView windowScriptObject]): (incrementFrame): (-[WebView searchFor:direction:caseSensitive:wrap:]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView removeDragCaret]): (-[WebView setScriptDebugDelegate:]): (-[WebView scriptDebugDelegate]): (-[WebView shouldClose]): (-[WebView selectedDOMRange]): (-[WebView styleDeclarationWithText:]):
7:43 PM Changeset in webkit [17298] by bdash
  • 2 edits in trunk/WebKitSite

2006-10-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

  • coding/coding-style.html:
5:48 PM Changeset in webkit [22428] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.


Checked in Luke's CG printing code

  • WebView.cpp: (WebView::print): added (WebViewWndProc): call print from WM_PRINTCLIENT
  • WebView.h: added print, m_pages, rearranged includes
5:48 PM Changeset in webkit [22427] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Checked in Luke's CG printing code

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::setupRootForPrinting): Added (WebCore::FrameWin::computePageRects): Added
  • bridge/win/FrameWin.h: Added setupRootForPrinting, computePageRects
5:43 PM Changeset in webkit [17297] by sfalken
  • 3 edits in trunk/WebCore

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Printing fixes

  • page/Frame.cpp: (WebCore::Frame::adjustPageHeight):
  • page/Frame.h: (WebCore::Frame::setupRootForPrinting): (WebCore::Frame::computePageRects):
5:29 PM Changeset in webkit [17296] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Steve (rubber stamp).

  • Link against your local build of JavaScriptCore.lib first, this fixes some errors on release builds of testkjs.
5:27 PM Changeset in webkit [17295] by thatcher
  • 2 edits in trunk/WebKitLibraries

Reverting my change, broke the Tiger build.

5:12 PM Changeset in webkit [17294] by andersca
  • 3 edits in trunk/WebCore

2006-10-25 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

<rdar://problem/4799088>
REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.

  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]): Set the HTTP method before the HTTP body.
4:42 PM Changeset in webkit [17293] by thatcher
  • 2 edits in trunk/WebKitLibraries

Reviewed by Kevin Decker.

  • libWebKitSystemInterface.a: updated to be 64-bit universal
2:15 PM Changeset in webkit [17292] by brmorris
  • 1 copy in S60/branches/s60-RnD-06wk43

New release branch.

1:51 PM Changeset in webkit [17291] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Lou.


Removed duplicate symbol declaration.

1:49 PM Changeset in webkit [17290] by ggaren
  • 20 edits
    2 moves in trunk

WebCore:

Reviewed by Adam.

Renamed WebFrameLoader to FrameLoader, to match class name.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/mac/FrameLoader.mm: Added.
  • loader/mac/IconLoaderMac.mm:
  • loader/mac/WebDocumentLoader.mm:
  • loader/mac/WebFrameLoader.h: Removed.
  • loader/mac/WebFrameLoader.mm: Removed.
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebSubresourceLoader.mm:

WebKit:

Reviewed by Adam.

Renamed WebFrameLoader to FrameLoader, to match class name.

  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginController.mm:
  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebDataSource.mm:
  • WebView/WebFrame.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebPolicyDelegate.mm:
  • WebView/WebView.mm:
12:29 PM Changeset in webkit [17289] by darin
  • 2 edits in trunk/WebCore
  • fix full builds
  • WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
5:12 AM Changeset in webkit [17288] by bdash
  • 2 edits in trunk/WebCore

2006-10-25 David Smith <​catfish.man@gmail.com>

Reviewed by Mitz.

Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
​http://bugs.webkit.org/show_bug.cgi?id=11411

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
2:57 AM Changeset in webkit [17287] by mjs
  • 2 edits
    3 moves in trunk/WebCore

Rubber stamped by Mitz.

  • moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
  • bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
  • bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
2:55 AM Changeset in webkit [17286] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Mark.

  • remove no longer existing symbol that was breaking linking
  • WebCore.exp:
1:52 AM Changeset in webkit [17285] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Mitz.


I couldn't figure out how to write a test case.

  • bindings/js/kjs_window.cpp: (KJS::Window::clear): Avoid crashing if already detached.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear): Change prototype to make this a proper overload for Frame::clear once again(!).
1:22 AM Changeset in webkit [17284] by bdash
  • 2 edits in trunk/WebKitSite

2006-10-25 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

Fix some HTML bugs in the coding style guidelines.

  • coding/coding-style.html:
12:52 AM Changeset in webkit [17283] by bdash
  • 2 edits in trunk/WebKit

2006-10-25 Mark Rowe <​bdash@webkit.org>

Reviewed by Anders.

Build fix for the Buildbot.

  • WebView/WebHTMLView.m: (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
12:30 AM Changeset in webkit [17282] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


<rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
<rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet

  • WebView/WebPolicyDeciderMac.m: (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it

Oct 24, 2006:

10:38 PM Changeset in webkit [17281] by andersca
  • 2 edits in trunk/WebKit

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • WebKitPrefix.h: Include FastMalloc.h from C++ code.
10:35 PM Changeset in webkit [17280] by darin
  • 30 edits
    2 adds in trunk

WebCore:

Reviewed by Anders.

  • converted WebFrameLoaderClient to C++
  • renamed frame->frameLoader() function to frame->loader()
  • renamed [bridge impl] to [bridge _frame]
  • removed some bridge methods
  • WebCore.exp: Added more exports.
  • WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal so it can be used in WebKit.
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame): (WebCore::FrameMac::didFirstLayout):
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge setOpener:]): (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]): (-[WebCoreFrameBridge _frame]): (-[WebCoreFrameBridge executionContextForView:]):
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setMainFrame:]):
  • dom/Position.cpp: (WebCore::Position::upstream):
  • loader/mac/IconLoaderMac.mm: (IconLoader::notifyIconChanged):
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/mac/WebFormState.mm: (WebCore::FormState::FormState):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::setDefersCallbacks): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::download): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::actionInformation): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::setClient): (WebCore::FrameLoader::client): (WebCore::FrameLoaderClient::~FrameLoaderClient):
  • loader/mac/WebFrameLoaderClient.h:
  • loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::frameLoader):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • page/Frame.cpp: (WebCore::Frame::loader):
  • page/Frame.h:
  • platform/mac/SliderMac.mm: (Slider::focusPolicy):

WebKit:

Reviewed by Anders.

  • converted WebFrameLoaderClient to C++
  • renamed frame->frameLoader() function to frame->loader()
  • renamed [bridge impl] to [bridge _frame]
  • removed some bridge methods
  • Plugins/WebNetscapePluginStream.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.h: Added. (WebFrameLoaderClient::webFrame):
  • WebCoreSupport/WebFrameLoaderClient.mm: Added. (WebFrameLoaderClient::detachFrameLoader): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.mm: (-[WebDataSource webFrame]):
  • WebView/WebFrame.mm: (frame): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame parentFrame]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray changeBaseWritingDirection:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView copy:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]):
  • WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView setProhibitsMainFrameScrolling:]): (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]): (-[WebView setEditable:]):
10:30 PM Changeset in webkit [17279] by darin
  • 2 edits in trunk/WebCore

Rubber stamped by Anders.

  • get rid of the assertion firing while running the layout tests

This does not fix the real problem, which is that we need to map offsets within
possibly-text-transformed text in the render tree to DOM tree offsets and vice
versa -- but it gets the tests running again.

  • dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
9:25 PM Changeset in webkit [17278] by mjs
  • 15 edits
    1 add in trunk

LayoutTests:

Reviewed by Oliver.

  • re-enable testing of HEAD methods, now that bugs relating to these are fixed
  • http/tests/xmlhttprequest/methods-async-expected.txt:
  • http/tests/xmlhttprequest/methods-async.html:
  • http/tests/xmlhttprequest/methods-expected.txt:
  • http/tests/xmlhttprequest/methods.html:

WebCore:

Reviewed by Oliver.

  • more ResourceLoader cleanup
    • moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
    • took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed


  • loader/LoaderFunctions.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • platform/network/HTTPHeaderMap.h: Added.
  • platform/network/ResourceLoader.cpp: (WebCore::ResourceLoader::requestHeaders):
  • platform/network/ResourceLoader.h:
  • platform/network/ResourceRequest.h:
  • platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
  • xml/xmlhttprequest.h:
9:23 PM Changeset in webkit [17277] by slewis
  • 2 edits in trunk/WebKitTools

2006-10-24 Stephanie Lewis <Stephanie Lewis>

Reviewed by Maciej.

  • Changed run-javascriptcore tests to build testkjs before running.
  • Scripts/run-javascriptcore-tests:
9:22 PM Changeset in webkit [22426] by mjs
  • 5 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

  • updated for ResourceRequest changes.
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::setRequestHeaders):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::loadURL): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h:
6:37 PM Changeset in webkit [17276] by justing
  • 13 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugs.webkit.org/show_bug.cgi?id=10993>
GMail Editor: Caret doesn't always position itself after list marker

  • editing/execCommand/create-list-1-expected.checksum: Added.
  • editing/execCommand/create-list-1-expected.png: Added.
  • editing/execCommand/create-list-1-expected.txt: Added.
  • editing/execCommand/create-list-1.html: Added.


Fixed:

  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/create-list-with-hr.html:
  • editing/execCommand/remove-list-1-expected.checksum:
  • editing/execCommand/remove-list-1-expected.png:
  • editing/execCommand/remove-list-1-expected.txt:
  • fast/text/attributed-substring-from-range-001-expected.txt:

WebCore:

Reviewed by darin

<​http://bugs.webkit.org/show_bug.cgi?id=10993>
GMail Editor: Caret doesn't always position itself after list marker


List creation uses moveParagraphs to push content into list items.
moveParagraphs uses a TextIterator to restore selections after moves.
Some characters emitted by the TextIterator had bad ranges associated
with them. rangeFromLocationAndLength would skip past the range it
should have used when asked for ranges of length 0.

  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): No longer need to initialize a removed member variable. (WebCore::TextIterator::advance): An extra newline is emitted when leaving some blocks. Use the same range for this newline as for the first newline. We should remove this code and just emit two '\n's. (WebCore::TextIterator::handleTextNode): Setup m_range. (WebCore::TextIterator::handleTextBox): Ditto. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::TextIterator::handleNonTextNode): Ditto. (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition in the block we're leaving to that VP after that one. (WebCore::TextIterator::emitCharacter): This function now takes in the start and the end of the range associated with the emited character, and sets up m_range. (WebCore::TextIterator::range): Return m_range. If it is null (we are atEnd), return the end of the range used to create the iterator, as a convenience to callers that use call range() on an iterator that is atEnd. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Same as the changes made to TextIterator's constructor. (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of a null m_positionNode to signal that we're finished. (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto. (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes made to TextIterator. (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto. (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified. (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to TextIterator::range. (WebCore::CharacterIterator::range): This function assumed that an iterator's range() was safe to modify. (WebCore::TextIterator::rangeFromLocationAndLength): If the range we're looking for starts in the current chunk, this function assumed that if the chunk started in a text node, it would end in the same text node. This is no longer the case. If the range we're looking for starts in the middle of the current chunk, I assume that the chunk is inside a text node, because those are the only chunks with length greater than one at the moment. If the range we're looking for is a zero length range that starts/ends at the end of the current chunk, we used to return the start of the next chunk, but that's wrong and is what caused this bug.
  • editing/TextIterator.h: (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null. (WebCore::SimplifiedBackwardsTextIterator::atEnd):
  • editing/visible_units.cpp: (WebCore::previousBoundary): Cleaned up by using a convenience function. (WebCore::nextBoundary): Ditto.
6:05 PM Changeset in webkit [22425] by sfalken
  • 4 edits in branches/WindowsMerge

2006-10-24 Steve Falkenburg <​sfalken@apple.com>

Build fix for official builds

5:31 PM Changeset in webkit [17275] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-10-24 Steve Falkenburg <​sfalken@apple.com>

Build config change

5:11 PM Changeset in webkit [17274] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Kevin Decker


  • fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit
  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether the spelling panel is already showing. Also, removed else's after returns, and removed braces around one-line if clauses. (-[NSArray showGuessPanel:]): post-Tiger, make this item hide the spelling panel if it's already showing
  • English.lproj/Localizable.strings: updated for this change
4:49 PM Changeset in webkit [17273] by andersca
  • 2 edits in trunk/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't retain the header dictionary.
4:11 PM Changeset in webkit [17272] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11404
REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref()
running svg/custom/svg/custom/gradient-attr-update.svg


SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.

  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
3:59 PM Changeset in webkit [22424] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-24 Steve Falkenburg <​sfalken@apple.com>

Bump version to 521.28.6

  • WebKit.vcproj/VERSION:
3:57 PM Changeset in webkit [22423] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-24 Steve Falkenburg <​sfalken@apple.com>

Fix build so it can be submitted.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/merge-opensource.sh:
  • rendering/RenderThemeWin.cpp:
3:56 PM Changeset in webkit [17271] by andersca
  • 2 edits in trunk/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Mitz.

  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Set the http method to "GET" in the constructor that takes a String.
3:48 PM Changeset in webkit [17270] by weinig
  • 3 edits
    20 moves in trunk/WebCore

Reviewed by Tim H.

Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
and rendering/SVG* respectively. Fix Xcode project and
CMakeLists.txt to account for the moves.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/RenderForeignObject.cpp: Removed.
  • kcanvas/RenderForeignObject.h: Removed.
  • kcanvas/RenderPath.cpp: Removed.
  • kcanvas/RenderPath.h: Removed.
  • kcanvas/RenderSVGContainer.cpp: Removed.
  • kcanvas/RenderSVGContainer.h: Removed.
  • kcanvas/RenderSVGImage.cpp: Removed.
  • kcanvas/RenderSVGImage.h: Removed.
  • kcanvas/RenderSVGInline.cpp: Removed.
  • kcanvas/RenderSVGInline.h: Removed.
  • kcanvas/RenderSVGInlineText.cpp: Removed.
  • kcanvas/RenderSVGInlineText.h: Removed.
  • kcanvas/RenderSVGTSpan.cpp: Removed.
  • kcanvas/RenderSVGTSpan.h: Removed.
  • kcanvas/RenderSVGText.cpp: Removed.
  • kcanvas/RenderSVGText.h: Removed.
  • kcanvas/SVGInlineFlowBox.cpp: Removed.
  • kcanvas/SVGInlineFlowBox.h: Removed.
  • kcanvas/SVGRootInlineBox.cpp: Removed.
  • kcanvas/SVGRootInlineBox.h: Removed.
3:37 PM Changeset in webkit [17269] by thatcher
  • 2 edits in trunk/WebKit/Misc

Build fix.

3:34 PM Changeset in webkit [17268] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Anders.

<rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'

  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _webView]):
3:28 PM Changeset in webkit [22422] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

Rolling back in, now fixed:


Nixed a few more redundant loading functions in Frame.

  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript): (FrameWin::lastEventIsMouseUp):
3:24 PM Changeset in webkit [17267] by ggaren
  • 11 edits in trunk/WebCore

Rolling back in, now fixed:


Nixed a few more redundant loading functions in Frame. Did my best to update
the non-Mac builds.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture always 'true', because changing it broke the world, and testing seems to indicate that the one caller that might have passed 'false' didn't need to.
  • page/Frame.cpp: (WebCore::Frame::requestFrame): (WebCore::Frame::frameLoader): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • platform/gdk/FrameGdk.cpp:
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::issueCopyCommand):
  • platform/qt/FrameQt.cpp:
  • platform/qt/FrameQt.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::shouldInterruptJavaScript): (WebCore::FrameWin::issueCopyCommand):
3:21 PM Changeset in webkit [22421] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

  • WebFrame.cpp: (WebFrame::loadDataSource): Forgot to save before committing. Call begin before trying to access the document.
3:15 PM Changeset in webkit [22420] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Fix build. (Update for changes to ResourceLoader)


  • WebFrame.cpp: (WebFrame::loadDataSource):
  • WebURLResponse.cpp: (WebURLResponse::createInstance):
3:06 PM Changeset in webkit [17266] by andersca
  • 2 edits in trunk/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Fix the build (Update for changes to ResourceLoader)


  • platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
2:58 PM Changeset in webkit [22419] by mjs
  • 5 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

  • update for ResourceLoader API changes
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::receivedAllData):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
2:57 PM Changeset in webkit [17265] by weinig
  • 7 edits in trunk/WebCore

Reviewed by Mitz.

Change #includes using <kcanvas/*.h> to use "*.h" instead
to prepare for moving the kcanvas files.

  • kcanvas/RenderSVGContainer.h:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
2:53 PM Changeset in webkit [17264] by mjs
  • 18 edits in trunk/WebCore

Reviewed by Darin.

  • More movement towards the final network API.


Changed ResourceLoader::create to take a ResurceRequest and start
the load. Removed methods relating to setting request
headers. Removed methods relating to metaData. Added some more
convenience methods to ResourceRequest.

  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • loader/LoaderFunctions.h:
  • loader/icon/IconLoader.cpp: (IconLoader::startLoading): (IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm):
  • platform/network/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::responseHTTPHeadersAsString): (WebCore::ResourceLoader::url): (WebCore::ResourceLoader::postData): (WebCore::ResourceLoader::method): (WebCore::ResourceLoader::client):
  • platform/network/ResourceLoader.h:
  • platform/network/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::httpAccept): (WebCore::ResourceRequest::setHTTPAccept): (WebCore::ResourceRequest::addHTTPHeaderFields):
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
2:26 PM Changeset in webkit [17263] by andersca
  • 3 edits in trunk/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • loader/FormData.cpp: (WebCore::FormData::FormData):
  • loader/FormData.h: (WebCore::FormData::FormData): Add new constructor that takes a void* and a size.
2:25 PM Changeset in webkit [17262] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.mm

Build fix for un-initialized var.

2:24 PM Changeset in webkit [17261] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Anders

​http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
to prevent null dereferencing.

  • WebView/WebFrame.mm: (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]):
2:17 PM Changeset in webkit [22418] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

Rolling out my last change because it broke the world.


  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURL):
2:14 PM Changeset in webkit [17260] by ggaren
  • 11 edits in trunk/WebCore

Rolling out my last change because it broke the world.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
  • page/Frame.cpp: (WebCore::Frame::openURL): (WebCore::Frame::frameLoader): (WebCore::Frame::requestFrame): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::openURL): (WebCore::FrameQt::openURLRequest):
  • platform/qt/FrameQt.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::openURL): (WebCore::FrameWin::openURLRequest):
1:50 PM Changeset in webkit [17259] by thatcher
  • 2 edits in trunk/WebCore/loader/mac

Build fixes for 64-bit.

1:46 PM Changeset in webkit [17258] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady.

  • Fixes a date formatting issue on win. Specifically strftime cannot handle some ranges of time so we shift time call strftime and then manipulate the returned string, if needed.
  • kjs/date_object.cpp: (KJS::): (KJS::formatLocaleDate): (KJS::DateProtoFunc::callAsFunction):
1:03 PM Changeset in webkit [17257] by bdash
  • 23 edits
    4 deletes in trunk/WebCore

2006-10-24 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Adam.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11396

Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
or broken.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<): (WebCore::writeStyle):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::fillContains):
  • kcanvas/device/KRenderingFillPainter.cpp:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingStrokePainter.cpp:
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup):
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties):
  • kcanvas/device/qt/KRenderingPaintServerQt.h:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup):
  • kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke): (WebCore::RenderPath::strokeBBox):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerQuartzHelper::fillPath): (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
  • kcanvas/device/quartz/QuartzSupport.h: (WebCore::CGLineCapFromKC): (WebCore::CGLineJoinFromKC):
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
12:54 PM Changeset in webkit [22417] by andersca
  • 6 edits in branches/WindowsMerge/WebCore

2006-10-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

<rdar://problem/4760429> Crash in PluginStreamWin::~PluginStreamWin when
navigating away from mcdonalds.com


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::fetchInfo): Use fastFree instead of free when memory is allocated by fastMalloc. If the plugin name or description is null, don't try to fetch info about the plugin.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::setRequestHeaders): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop):
  • plugins/win/PluginStreamWin.h: Change type of header map to ResourceRequest::HTTPHeaderMap. When a plugin is stopped, set its state to StreamStopped.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::loadURL): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h: Update for type changes to the header map.
12:20 PM Changeset in webkit [22416] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.


Nixed a few more redundant loading functions in Frame.

  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript): (FrameWin::lastEventIsMouseUp):
12:17 PM Changeset in webkit [17256] by ggaren
  • 11 edits in trunk/WebCore

Reviewed by Anders.

Nixed a few more redundant loading functions in Frame. Did my best to update
the non-Mac builds.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture to actually check for a user gesture. New callers rely on this behavior, and it seems like the previous behavior must have been a bug.
  • page/Frame.cpp: (WebCore::Frame::requestFrame): (WebCore::Frame::frameLoader): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • platform/gdk/FrameGdk.cpp:
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::issueCopyCommand):
  • platform/qt/FrameQt.cpp:
  • platform/qt/FrameQt.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::shouldInterruptJavaScript): (WebCore::FrameWin::issueCopyCommand):
12:14 PM Changeset in webkit [17255] by sullivan
  • 14 edits
    4 adds in trunk/WebKit

Reviewed by Darin


Initial plumbing for grammar checking. No actual grammar are checked at this time.

  • English.lproj/WebViewEditingContextMenu.nib/classes.nib:
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib: Added grammar-checking item, reworded to match changes in framework. This will be used post-Tiger.
  • English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
  • English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
  • English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added. Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Choose the right context menu based on BUILDING_ON_TIGER.


  • WebView/WebPreferenceKeysPrivate.h: declare grammar-related NSUserDefault value
  • WebView/WebViewPrivate.h: declare grammar-related methods
  • WebView/WebView.mm: declare static BOOL grammarCheckingEnabled (-[WebViewPrivate init]): initialize grammarCheckingEnabled to NSUserDefaults value (-[WebView validateUserInterfaceItem:]): validate toggleGrammarChecking: menu item (-[WebView isGrammarCheckingEnabled]): return value of grammarCheckingEnabled (-[WebView setGrammarCheckingEnabled:]): set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers (-[WebView toggleGrammarChecking:]): flip the value


  • WebView/WebFrameInternal.h:
  • WebView/WebFrame.mm: (-[WebFrame _unmarkAllBadGrammar]): new placeholder method, does nothing yet


  • WebView/WebHTMLViewInternal.h: declare grammar-related methods
  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): validate toggleGrammarChecking: menu item (-[WebHTMLView isGrammarCheckingEnabled]): new method, calls through to WebView (-[WebHTMLView setGrammarCheckingEnabled:]): ditto (-[WebHTMLView toggleGrammarChecking:]): ditto


  • English.lproj/StringsNotToBeLocalized.txt: Updated for these changes


  • WebKit.xcodeproj/project.pbxproj: updated for new files
8:14 AM Changeset in webkit [17254] by brmorris
  • 12 edits in S60/trunk

Reviewed by Sachin.
DESC: Automatically open download file progressively settings. If yes,

then download file will be open progressively. If no, then the user
need to open the file manually.

​http://bugs.webkit.org/show_bug.cgi?id=11392

6:10 AM Changeset in webkit [17253] by weinig
  • 10 edits
    2 deletes in trunk

WebCore:

Reviewed by Maciej.

Fix Qt/Linux build.

  • Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
  • Fix CMakeLists.txt to include platform/network.
  • CMakeLists.txt:
  • platform/qt/BrowserExtensionQt.cpp: Removed.
  • platform/qt/BrowserExtensionQt.h: Removed.
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::createNewWindow): (WebCore::FrameQt::goBackOrForward): (WebCore::FrameQt::historyURL): (WebCore::FrameQt::getHistoryLength):
  • platform/qt/FrameQt.h:
  • platform/qt/PageQt.cpp: (WebCore::Page::canRunModal): (WebCore::Page::canRunModalNow): (WebCore::Page::runModal):

WebKitQt:

Reviewed by Maciej.

Fix Qt/Linux build.

  • Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
  • Fix CMakeLists.txt to include platform/network.
  • QtLauncher/CMakeLists.txt:
  • WebKitPart/CMakeLists.txt:

WebKitTools:

Reviewed by Maciej.

Fix Qt/Linux build.

  • Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
  • Fix CMakeLists.txt to include platform/network.
  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
6:06 AM Changeset in webkit [17252] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11314
Fix build when XSLT_SUPPORT is not defined

Fix unconditional use of XSLT support.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end):
4:26 AM Changeset in webkit [17251] by bdash
  • 5 edits in trunk

2006-10-24 Simon Hausmann <​hausmann@kde.org>

Reviewed by Darin.

  • CMakeLists.txt: Added project name to kde4_automoc macro, as required by the latest KDE4 cmake module.

2006-10-24 Simon Hausmann <​hausmann@kde.org>

Reviewed by Darin.

  • QtLauncher/CMakeLists.txt, WebKitPart/CMakeLists.txt: Added project name to kde4_automoc macro, as required by the latest KDE4 cmake module.
4:19 AM Changeset in webkit [17250] by bdash
  • 2 edits in trunk/WebKitTools

2006-10-24 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Bug 11382: [Drosera] Dragging breakpoints onto each other can mess up inline editor
​http://bugs.webkit.org/show_bug.cgi?id=11382

  • Drosera/debugger.js: Breakpoint dragging now ensures that editors aren't orphaned.
4:15 AM Changeset in webkit [17249] by bdash
  • 2 edits in trunk/WebCore

2006-10-24 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim H.

  • html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid ref cycle.
1:49 AM Changeset in webkit [17248] by ggaren
  • 8 edits in trunk/WebCore

Reviewed by Darin.

Removed one of Frame's redundant urlSelected methods.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): since it's unused.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString to String because the former is deprecated and its performance is irrelevant here. Added call to completeURL because Frame no longer does it for us. Having the call here also improves clarity about the element's behavior.
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre irrelevent NULL checks on ownerDocument() because I couldn't help myself.
  • page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected):
  • page/Frame.h:
  • platform/network/ResourceRequest.h: Removed explicit keyword on constructor because we want to be able to use these constructors instead of helper functions mimicking their behavior sprinkled across different classes. (WebCore::ResourceRequest::ResourceRequest):
12:59 AM Changeset in webkit [17247] by beidson
  • 11 edits in trunk/WebCore

Reviewed by Maciej

Moved FrameLoader from WebCoreFrameBridge to Frame. Frame.h/cpp have generic accessors to the FrameLoader itself
and creation/deletion is currently managed in FrameMac.mm

Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the
frame instead of the bridge.

The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make
use of it as its days are numbered!

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Create the FrameLoader (WebCore::FrameMac::~FrameMac): Nuke it (WebCore::FrameMac::loadRequest):
  • bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::frameLoader):
  • loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::checkLoadComplete):
  • loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::frameLoader):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • page/Frame.cpp: (WebCore::Frame::frameLoader):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
12:33 AM Changeset in webkit [17246] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed two crashes in layout tests I just introduced
  • loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::load): Add null check. (WebCore::FrameLoader::setState): Ditto.
Note: See TracTimeline for information about the timeline view.