⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 26, 2006:

11:29 PM Changeset in webkit [17363] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.

Fixed layout test crash. Oops.


  • loader/mac/WebDocumentLoader.mm: (WebCore::canonicalizedTitle):
11:08 PM Changeset in webkit [17362] by thatcher
  • 1 edit in tags/WebCore-521.29.1/WebCore/Info.plist

Versioning

11:06 PM Changeset in webkit [17361] by thatcher
  • 1 edit in tags/WebCore-521.29.1/WebCore/WebCore.exp

Build fix for 64-bit.

11:04 PM Changeset in webkit [17360] by thatcher
  • 1 copy in tags/WebCore-521.29.1/WebCore

new tag (part 2).

11:01 PM Changeset in webkit [17359] by thatcher
  • 1 add in tags/WebCore-521.29.1

new tag.

11:01 PM Changeset in webkit [17358] by thatcher
  • 1 delete in tags/WebKit-521.29.1

Bad tag.

10:59 PM Changeset in webkit [17357] by thatcher
  • 1 copy in tags/WebKit-521.29.1/WebKit

new tag (part 2).

10:58 PM Changeset in webkit [17356] by thatcher
  • 1 add in tags/WebKit-521.29.1

new tag.

10:54 PM Changeset in webkit [17355] by thatcher
  • 1 edit in trunk/WebCore/WebCore.exp

Build fix for 64-bit.

10:30 PM Changeset in webkit [17354] by bdash
  • 4 edits in trunk/JavaScriptCore

2006-10-26 W. Andy Carrel <​wac@google.com>

Reviewed by Maciej.

  • kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): Looking ahead one additional character for the benefit of scanRegExp (Lexer::scanRegExp): Change code to support unicode escapes in inline regexps.
  • kjs/lexer.h: Extra lookahead added.
  • tests/mozilla/ecma_2/RegExp/properties-001.js: Changed test to look for Unicode character rather than the '\u' escaped equivalent for .source and .toString().
8:46 PM Changeset in webkit [17353] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Brady


  • fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com


This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
7:55 PM Changeset in webkit [17352] by ggaren
  • 26 edits in trunk

WebCore:

Reviewed by Darin, Maciej.

Removed many uses of NSString *.
Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing
stringByCollapsingNonPrintingCharacters with a c++ equivalent.


PLT says no performance regression.


  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge receivedData:textEncodingName:]):
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post):
  • loader/mac/WebDocumentLoader.h:
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle):
  • loader/mac/WebFrameLoaderClient.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy):

WebKit:

Reviewed by Darin, Maciej.

Removed many uses of NSString * from WebCore.


Changed a few files to ObjC++ for compatiblity with new WebCore methods
taking WebCore::Strings as arguments.


Added a static_cast to make the c++ compiler happy.

7:55 PM Changeset in webkit [22436] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4764502> PluginStreams should cancel their loader jobs on error

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::receivedAllData): Modify assertions. None of the above functions should be run after aborting the load.
6:00 PM Changeset in webkit [22435] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginPath): (WebCore::PluginDatabaseWin::defaultPluginPaths): Look for plugins in a plugins directory which is relative to the executable directory.


(WebCore::PluginDatabaseWin::createPluginView):
Use reverseFind instead of findRev here.

5:25 PM Changeset in webkit [17351] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com

The main table at nytimes.com has a fixed width of 874px, but the table ends
up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
this. The other bug was a missing top and left of 0px on the container element,
causing the deletion UI to sometimes be offset below the table.

Now check for the element's renderer at the beginning of show() and
return early if it is null.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::updateOutlineStyle): (WebCore::DeleteButtonController::show):
5:20 PM Changeset in webkit [22434] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Beth.

Fix: <rdar://problem/4799084> Text and dropdown button too close
together in <select>s
Fix: <rdar://problem/4800493> Popup menus should be positioned so that
their text is horizontally aligned with the <select> control's text

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Switch alignment of LTR vs. RTL popups, and add padding to align the text. (WebCore::PopupMenu::paint): Add padding from the <select> control to align the text with the <select> control's text.
  • rendering/RenderThemeWin.cpp: Set svn:eol-style native. (WebCore::RenderThemeWin::systemFont): Clean up line endings. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Add some extra padding between the dropdown button and text. (WebCore::RenderThemeWin::paintMenuListButton): Clean up code a bit.
4:34 PM Changeset in webkit [22433] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Forgot to make the change to Release as well in my last checkin.

  • WebCore.vcproj/WebCore.vcproj:
4:25 PM Changeset in webkit [22432] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Steve.

Add some missing '/d' flags to xcopy calls to only copy headers if
they've been modified.

  • WebCore.vcproj/WebCore.vcproj:
4:12 PM Changeset in webkit [17350] by andersca
  • 2 edits in trunk/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Build fix.

  • html/CanvasRenderingContext2D.cpp: Include MathExtras.h
4:02 PM Changeset in webkit [22431] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForMisspellingOrBadGrammar): Build fix from Oliver.
3:57 PM Changeset in webkit [17349] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Anders.

Some changes to support new grammar checking code in WebKit.

  • WebCore.exp: added mangled symbol for Document->removeMarkers() so I can call it from WebKit


  • WebCore.xcodeproj/project.pbxproj: Made Document.h and DocumentMarker.h private so I can include them from WebKit. Made HTMLCollection.h private because Document.h uses it.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: removed unmarkAllMisspellings(); WebKit now calls through to the Document directly

WebKit:

Reviewed by Anders

  • WebView/WebFrame.mm: now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h> (-[WebFrame _unmarkAllBadGrammar]): filled in guts (-[WebFrame _unmarkAllMisspellings]): rewrote to call Document directly, bypassing bridge
3:30 PM Changeset in webkit [17348] by sullivan
  • 3 edits in trunk/WebKit
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib:


Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.

3:27 PM Changeset in webkit [17347] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Geoff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11419
REGRESSION (r17299): Assertion failure in -[WebHTMLView(WebPrivate) _topHTMLView]
([view isKindOfClass:[WebHTMLView class]]) when running the layout tests

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseMoveToX:Y:]):
3:22 PM Changeset in webkit [17346] by andersca
  • 7 edits in trunk/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Brady.

Add reverseFind to String and use it instead of findRev.
Use CString instead of DeprecatedCString in one place.


  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • loader/Decoder.cpp: (WebCore::Decoder::checkForCSSCharset):
  • platform/PlatformString.h: (WebCore::String::reverseFind):
  • platform/StringImpl.cpp: (WebCore::StringImpl::reverseFind):
  • platform/StringImpl.h:
2:27 PM Changeset in webkit [17345] by sullivan
  • 6 edits in trunk/WebCore

Reviewed by Darin


More plumbing for grammar checking. Still no grammars is checked.

  • dom/DocumentMarker.h: (WebCore::DocumentMarker::): added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"


  • platform/GraphicsContext.h: renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar; now takes a bool parameter for whether it represents bad grammar or a misspelling


  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed an existing "assert" to "ASSERT".


  • rendering/InlineTextBox.h: renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents bad grammar or a misspelling (WebCore::InlineTextBox::paintAllMarkersOfType): now handles markers of type Grammar
2:19 PM Changeset in webkit [17344] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added bug number to change log entry.

2:17 PM Changeset in webkit [17343] by darin
  • 2 edits in trunk/LayoutTests

Reviewed by Adam.

  • editing/execCommand/remove-formatting-expected.txt: Roll back results. The ones just checked in showed the same kind of intermittent failure that copy-paste-bidi.html used to show -- now we consistently get these results.
1:52 PM Changeset in webkit [17342] by thatcher
  • 1 edit
    8 copies in tags/Safari-521.29

New tag.

1:42 PM Changeset in webkit [17341] by thatcher
  • 6 edits in /

Re-versioning

1:32 PM Changeset in webkit [17340] by thatcher
  • 6 edits in /

Versioning

1:29 PM Changeset in webkit [17339] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2006-10-25 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly. Merge from CCB
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
1:23 PM Changeset in webkit [17338] by weinig
  • 37 edits in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11424
Cleanup rendering code

  • Assorted code cleanup.
  • rendering/AutoTableLayout.cpp:
  • rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::totalPercent):
  • rendering/CounterListItem.h:
  • rendering/CounterNode.cpp:
  • rendering/CounterNode.h: (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::isReset):
  • rendering/CounterResetNode.cpp:
  • rendering/CounterResetNode.h:
  • rendering/DataRef.h: (WebCore::DataRef::DataRef):
  • rendering/DeprecatedRenderSelect.h:
  • rendering/DeprecatedSlider.cpp:
  • rendering/DeprecatedSlider.h:
  • rendering/EllipsisBox.cpp:
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
  • rendering/FixedTableLayout.cpp:
  • rendering/FixedTableLayout.h:
  • rendering/GapRects.h:
  • rendering/InlineBox.cpp:
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::setConstructed): (WebCore::InlineBox::clearTruncation): (WebCore::InlineBox::markDirty):
  • rendering/InlineFlowBox.cpp:
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::setConstructed): (WebCore::InlineFlowBox::setEdges): (WebCore::InlineFlowBox::setVerticalOverflowPositions): (WebCore::InlineFlowBox::setVerticalSelectionPositions):
  • rendering/InlineRunBox.h: (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations):
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::InlineTextBox): (WebCore::InlineTextBox::end): (WebCore::InlineTextBox::textObject):
  • rendering/Length.h: (WebCore::Length::Length):
  • rendering/ListMarkerBox.cpp:
  • rendering/ListMarkerBox.h:
  • rendering/RenderPartObject.h:
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.cpp:
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
  • rendering/SVGRootInlineBox.cpp:
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox):
  • rendering/TableLayout.h: (WebCore::TableLayout::TableLayout): (WebCore::TableLayout::~TableLayout):
  • rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiRun::BidiRun):
  • rendering/break_lines.h:
12:44 PM Changeset in webkit [17337] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<​http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.

  • editing/execCommand/remove-formatting-2-expected.checksum: Added.
  • editing/execCommand/remove-formatting-2-expected.png: Added.
  • editing/execCommand/remove-formatting-2-expected.txt: Added.
  • editing/execCommand/remove-formatting-2.html: Added.
  • editing/execCommand/remove-formatting-expected.txt:

WebCore:

Reviewed by john

<​http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.


  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor. Wrapped the plain text fragment in a style span with the document default style so that it will appear unstyled regardless of where it is inserted. Could have also inserted the plain text fragment and then applied the document default style to it, but there is not yet any redundant style prevention in ApplyStyleCommand, so this is cleaner.
  • editing/Editor.h:
  • editing/JSEditor.cpp:
12:24 PM Changeset in webkit [17336] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-10-25 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
​http://bugs.webkit.org/show_bug.cgi?id=11414
merged from 3.1m r17335


  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
12:06 PM Changeset in webkit [17335] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2006-10-25 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
​http://bugs.webkit.org/show_bug.cgi?id=11414


  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
11:54 AM Changeset in webkit [17334] by oliver
  • 3 edits
    4 adds in trunk

2006-10-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.
Fixes <rdar://problem/4800518> -- needed to update existing
canvas path elements when transforms are performed on the
context.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate):
11:51 AM Changeset in webkit [22430] by andersca
  • 5 edits in branches/WindowsMerge/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Use FrameLoadRequest and ResourceRequest instead of passing around
the individual components.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::destroyStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::frameLoadRequest): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h:
11:27 AM Changeset in webkit [17333] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix build with older gcc 3.3.4.

  • kjs/DateMath.cpp: Remove inline prefix. (KJS::equivalentYearForDST):
11:25 AM Changeset in webkit [17332] by weinig
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

Fix Qt/Linux build.

  • platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add):
  • platform/network/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest):

WebKitQt:

Reviewed by Darin.

Fix Qt/Linux build.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::openUrl):

WebKitTools:

Reviewed by Darin.

Fix Qt/Linux build.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
11:23 AM Changeset in webkit [22429] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fix: <rdar://problem/4794162> Implement type-ahead find for popup menus
Fix: <rdar://problem/4800486> Pressing TAB while a popup is focused
should close the popup and move selection in the page

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Don't cache the focused index. (WebCore::PopupMenu::focusedIndex): Always get the focused index from the HTMLSelectElement. (WebCore::PopupMenu::setFocusedIndex): Invalidate before calling valueChanged(), as this will change the result of focusedIndex(). (WebCore::PopupMenu::scrollToRevealSelection): (WebCore::PopupMenu::updateFromElement): New method to repaint/rescroll the popup. (WebCore::PopupWndProc): Send TAB keypresses and printable characters back to the WebView for handling. Also omove handling of Return/Escape into the WM_CHAR event, as this is recommended by MSDN.
11:19 AM Changeset in webkit [17331] by aroben
  • 8 edits in trunk/WebCore

Reviewed by Adele.

Fix: <rdar://problem/3951815> add "type-to-select" feature for list
boxes (<select> elements)

This also adds type-ahead find for closed menulists (popups).

  • WebCore.xcodeproj/project.pbxproj: Version wars.
  • html/HTMLSelectElement.h: Add new instance variables for type-ahead find.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new instance variables. (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead find on printable character presses. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove redundant check that the listIndex has changed (setSelectedIndex does this for us), and fix indentation. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if to an else-if. (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind() to strip leading whitespace (including non-breaking spaces) from a string. (WebCore::HTMLSelectElement::typeAheadFind): New method to perform type-ahead find.
  • platform/PopupMenu.h: Added new updateFromElement() method to be called from RenderMenuList::updateFromElement().
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::updateFromElement): While we are using NSPopUpButtonCell for our popups, this method can stay empty.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first selected element.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Tell the popup to update if it's visible.
11:05 AM Changeset in webkit [17330] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/WebKit

Tag for WebKit for 10.4.1 (unchanged from 10.4).

11:04 AM Changeset in webkit [17329] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/JavaScriptCore

Tag for JavaScriptCore for 10.4.1 (unchanged from 10.4).

11:02 AM Changeset in webkit [17328] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/JavaScriptCore

Tag for JavaScriptCore for 10.4 (JavaScriptCore 412).

11:01 AM Changeset in webkit [17327] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/WebKit

Tag for WebKit for 10.4 (WebKit 412).

11:00 AM Changeset in webkit [17326] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/WebCore

Tag for WebCore for 10.4 (WebCore 413).

10:59 AM Changeset in webkit [17325] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4

New release tag for 10.4.

10:57 AM Changeset in webkit [17324] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/JavaScriptCore

Tag for JavaScriptCore for 10.4.2 (JavaScriptCore 412.3).

10:56 AM Changeset in webkit [17323] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/WebKit

Tag for WebKit for 10.4.2 (WebKit 412.6).

10:55 AM Changeset in webkit [17322] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/WebCore

Tag for WebCore for 10.4.2 (WebCore 415.11).

10:54 AM Changeset in webkit [17321] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.2

New release tag for 10.4.2.

10:53 AM Changeset in webkit [17320] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/WebCore

Tag for WebCore for 10.4.1 (WebCore 415.5).

10:48 AM Changeset in webkit [17319] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.1

New release tag for 10.4.1.

10:44 AM Changeset in webkit [17318] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit

Tag for WebKit for 10.4.8 (WebKit 418.9).

10:44 AM Changeset in webkit [17317] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebCore

Tag for WebCore for 10.4.8 (WebCore 418.21).

10:44 AM Changeset in webkit [17316] by thatcher
  • 1 delete in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit

bad tag.

10:43 AM Changeset in webkit [17315] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit/WebCore

Tag for WebCore for 10.4.8 (WebCore 418.21).

10:42 AM Changeset in webkit [17314] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit

Tag for WebKit for 10.4.8 (WebKit 418.9).

10:40 AM Changeset in webkit [17313] by darin
  • 1 edit in trunk/WebCore/ChangeLog

"causing give inconsistent results" -> "causing inconsistent results"

10:40 AM Changeset in webkit [17312] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/JavaScriptGlue

Tag for JavaScriptGlue for 10.4.8 (unchanged from 10.4.7).

10:39 AM Changeset in webkit [17311] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Anders.

  • removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
  • editing/pasteboard/copy-paste-bidi-expected.txt: New results, without the anonymous block that sometimes appeared and sometimes did not.

WebCore:

Reviewed by Anders.

  • removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Use two vectors instead of a map: more efficient, deterministic. There was no reason to use a hash table.
10:39 AM Changeset in webkit [17310] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/JavaScriptCore

Tag for JavaScriptCore for 10.4.8 (unchanged from 10.4.7).

10:38 AM Changeset in webkit [17309] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.8

New release tag.

9:59 AM Changeset in webkit [17308] by darin
  • 2 edits in trunk/LayoutTests
  • oops, checked in failure results, not success
  • fast/js/string-property-iteration-expected.txt: Successful results.
9:46 AM Changeset in webkit [17307] by darin
  • 1 edit
    3 adds in trunk/LayoutTests
  • checked in some missing results (if these are wrong we could remove or disable the test)
  • svg/hixie/cascade/002-expected.checksum: Added.
  • svg/hixie/cascade/002-expected.png: Added.
  • svg/hixie/cascade/002-expected.txt: Added.
9:39 AM Changeset in webkit [17306] by darin
  • 8 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by John.

  • fix iteration of properties of string objects (found because of a warning emitted by the MSVC compiler)
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): Change code that wants to format a number as a string to use UString::from. Before it was using the UString constructor that makes a string from a character!
  • kjs/ustring.h:
  • kjs/ustring.cpp: Remove the dangerous and not all that helpful UString(char) constructor.
  • kjs/grammar.y: Change code to not depend on the UString(char) constructor. This is potentially more efficient anyway because we could overload the + operator some day to handle char* directly instead of creating a UString.
  • kjs/nodes2string.cpp: (SourceStream::operator<<): Change code to not depend on the UString(char) constructor.

LayoutTests:

Reviewed by John.

  • add a test for iteration of properties of string objects
  • fast/js/resources/string-property-iteration.js: Added.
  • fast/js/string-property-iteration-expected.txt: Added.
  • fast/js/string-property-iteration.html: Added.
9:06 AM Changeset in webkit [17305] by sullivan
  • 1 edit in trunk/WebKit/English.lproj/Localizable.strings
9:05 AM Changeset in webkit [17304] by brmorris
  • 67 edits
    17 copies in S60/branches/s60-RnD-06wk43

2006-10-25 yadavall <​sriram.yadavalli@nokia.com>

Merge of r17301 to s60-RnD-06wk43 release branch.

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
​http://bugs.webkit.org/show_bug.cgi?id=11407

9:05 AM Changeset in webkit [17303] by sullivan
  • 2 edits in trunk/WebKit

No review, just two localized string changes.


  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
  • English.lproj/Localizable.strings: updated for these changes
8:23 AM Changeset in webkit [17302] by spadma
  • 3 edits in S60/trunk/WebKit

2006-10-25 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
6:26 AM Changeset in webkit [17301] by spadma
  • 67 edits
    17 adds in S60/trunk

2006-10-25 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
​http://bugs.webkit.org/show_bug.cgi?id=11407

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL): (CBrCtl::UpdateDefaultSoftkeysL): (CBrCtl::CreateWidgetExtensionL):
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::WidgetExtension):
  • BrowserView/inc/webkitbridge.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::MakeVisible): (CWebKitView::Draw):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LayoutChanged): (CWebKitBridge::createWidgetObject):
  • Plugin/inc/PluginHandler.h:
  • Plugin/inc/PluginSkin.h: (CPluginSkin::WebKitControl): (CPluginSkin::Frame):
  • Plugin/inc/PluginWin.h:
  • Plugin/inc/npapi.h:
  • Plugin/src/NpnImplementation.cpp: (NpnGetValue):
  • Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginHandler::LoadPluginsSyncL): (CPluginHandler::LoadPluginsL): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::ReloadPluginsL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::CreatePluginWinL): (CPluginSkin::SelectViewerAndDownloadL): (CPluginSkin::PluginScriptableObject):
  • Plugin/src/PluginWin.cpp: (CPluginWin::WindowScriptNPObject): (CPluginWin::PluginScriptableObject):
  • group/BrowserView.mmp:
  • group/Plugin.mmp:
  • group/webkit.mmp:
  • rom/webkit.iby:
3:34 AM Changeset in webkit [17300] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Anders.

  • .5% speed improvement by avoiding excess CFURLRef allocation
  • loader/CachedResource.cpp: (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL here for later reuse.
  • loader/CachedResource.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.

Oct 25, 2006:

10:04 PM Changeset in webkit [17299] by darin
  • 40 edits in trunk

WebCore:

Reviewed by Anders.

  • removed 55 methods from WebCoreFrameBridge
  • changed callers to use Frame directly instead
  • put FrameLoaderTypes.h types into the WebCore namespace
  • first steps to get FrameLoader.h ready for cross-platform duty
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::startRedirectionTimer): (WebCore::FrameMac::stopRedirectionTimer): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::FrameMac::handledOnloadEvents): (WebCore::FrameMac::isLoadTypeReload):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge executionContextForView:]): (updateRenderingForBindings): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebCoreFrameBridge installInFrame:]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • loader/FrameLoaderTypes.h:
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense):
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy): (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • platform/mac/ListBoxMac.mm: (-[WebCoreTableView keyDown:]): (-[WebCoreTableView keyUp:]):
  • platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]):

WebKit:

Reviewed by Anders.

  • removed 55 methods from WebCoreFrameBridge
  • changed callers to use Frame directly instead
  • put FrameLoaderTypes.h types into the WebCore namespace
  • first steps to get FrameLoader.h ready for cross-platform duty
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView getVariable:value:]):
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _continueWithPolicy:]): (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge webView]): (-[WebFrameBridge finishInitializingWithFrameName:view:]): (-[WebFrameBridge createWindowWithURL:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge createModalDialogWithURL:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchWillSubmitForm):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithImageResource:]): (-[WebDataSource _imageElementWithImageResource:]):
  • WebView/WebEditingDelegatePrivate.h:
  • WebView/WebFrame.mm: (core): (kit): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _childFramesMatchItem:]): (-[WebFrame _URLsMatchItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _viewWillMoveToHostWindow:]): (-[WebFrame _viewDidMoveToHostWindow]): (-[WebFrame _addChild:]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _numPendingOrLoadingRequests:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): (-[WebFrame _initWithWebFrameView:webView:coreFrame:]): (-[WebFrame _documentViews]): (-[WebFrame _updateBackground]): (-[WebFrame _unmarkAllMisspellings]): (-[WebFrame _hasSelection]): (-[WebFrame _atMostOneFrameHasSelection]): (-[WebFrame _findFrameWithSelection]): (-[WebFrame _frameLoader]): (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:webView:]): (-[WebFrame dealloc]): (-[WebFrame finalize]): (-[WebFrame name]): (-[WebFrame webView]): (-[WebFrame DOMDocument]): (-[WebFrame frameElement]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame childFrames]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]): (-[WebHTMLRepresentation attributedText]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): (-[WebHTMLView _selectedRange]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _isSelectionInPasswordField]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView _selectionDraggingImage]): (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _updateActiveState]): (-[NSArray readSelectionFromPasteboard:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray maintainsInactiveSelection]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray centerSelectionInVisibleArea:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray _emptyStyle]): (-[NSArray performKeyEquivalent:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView selectionRect]): (-[WebHTMLView selectionImageForcingWhiteText:]): (-[WebHTMLView selectionImageRect]): (-[WebHTMLView attributedString]): (-[WebHTMLView _isMoveDrag]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebPolicyDelegate.mm: (-[WebPolicyDecisionListener _usePolicy:]): (-[WebPolicyDecisionListener use]): (-[WebPolicyDecisionListener ignore]): (-[WebPolicyDecisionListener download]): (-[WebPolicyDecisionListener continue]):
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]): (-[WebScriptCallFrame globalObject]):
  • WebView/WebView.mm: (-[WebView _attachScriptDebuggerToAllFrames]): (-[WebView _detachScriptDebuggerFromAllFrames]): (-[WebView windowScriptObject]): (incrementFrame): (-[WebView searchFor:direction:caseSensitive:wrap:]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView removeDragCaret]): (-[WebView setScriptDebugDelegate:]): (-[WebView scriptDebugDelegate]): (-[WebView shouldClose]): (-[WebView selectedDOMRange]): (-[WebView styleDeclarationWithText:]):
7:43 PM Changeset in webkit [17298] by bdash
  • 2 edits in trunk/WebKitSite

2006-10-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

  • coding/coding-style.html:
5:48 PM Changeset in webkit [22428] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.


Checked in Luke's CG printing code

  • WebView.cpp: (WebView::print): added (WebViewWndProc): call print from WM_PRINTCLIENT
  • WebView.h: added print, m_pages, rearranged includes
5:48 PM Changeset in webkit [22427] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Checked in Luke's CG printing code

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::setupRootForPrinting): Added (WebCore::FrameWin::computePageRects): Added
  • bridge/win/FrameWin.h: Added setupRootForPrinting, computePageRects
5:43 PM Changeset in webkit [17297] by sfalken
  • 3 edits in trunk/WebCore

2006-10-25 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Printing fixes

  • page/Frame.cpp: (WebCore::Frame::adjustPageHeight):
  • page/Frame.h: (WebCore::Frame::setupRootForPrinting): (WebCore::Frame::computePageRects):
5:29 PM Changeset in webkit [17296] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Steve (rubber stamp).

  • Link against your local build of JavaScriptCore.lib first, this fixes some errors on release builds of testkjs.
5:27 PM Changeset in webkit [17295] by thatcher
  • 2 edits in trunk/WebKitLibraries

Reverting my change, broke the Tiger build.

5:12 PM Changeset in webkit [17294] by andersca
  • 3 edits in trunk/WebCore

2006-10-25 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

<rdar://problem/4799088>
REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.

  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]): Set the HTTP method before the HTTP body.
4:42 PM Changeset in webkit [17293] by thatcher
  • 2 edits in trunk/WebKitLibraries

Reviewed by Kevin Decker.

  • libWebKitSystemInterface.a: updated to be 64-bit universal
2:15 PM Changeset in webkit [17292] by brmorris
  • 1 copy in S60/branches/s60-RnD-06wk43

New release branch.

1:51 PM Changeset in webkit [17291] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Lou.


Removed duplicate symbol declaration.

1:49 PM Changeset in webkit [17290] by ggaren
  • 20 edits
    2 moves in trunk

WebCore:

Reviewed by Adam.

Renamed WebFrameLoader to FrameLoader, to match class name.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/mac/FrameLoader.mm: Added.
  • loader/mac/IconLoaderMac.mm:
  • loader/mac/WebDocumentLoader.mm:
  • loader/mac/WebFrameLoader.h: Removed.
  • loader/mac/WebFrameLoader.mm: Removed.
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebSubresourceLoader.mm:

WebKit:

Reviewed by Adam.

Renamed WebFrameLoader to FrameLoader, to match class name.

  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginController.mm:
  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebDataSource.mm:
  • WebView/WebFrame.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebPolicyDelegate.mm:
  • WebView/WebView.mm:
12:29 PM Changeset in webkit [17289] by darin
  • 2 edits in trunk/WebCore
  • fix full builds
  • WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
5:12 AM Changeset in webkit [17288] by bdash
  • 2 edits in trunk/WebCore

2006-10-25 David Smith <​catfish.man@gmail.com>

Reviewed by Mitz.

Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
​http://bugs.webkit.org/show_bug.cgi?id=11411

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
2:57 AM Changeset in webkit [17287] by mjs
  • 2 edits
    3 moves in trunk/WebCore

Rubber stamped by Mitz.

  • moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
  • bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
  • bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
2:55 AM Changeset in webkit [17286] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Mark.

  • remove no longer existing symbol that was breaking linking
  • WebCore.exp:
1:52 AM Changeset in webkit [17285] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Mitz.


I couldn't figure out how to write a test case.

  • bindings/js/kjs_window.cpp: (KJS::Window::clear): Avoid crashing if already detached.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear): Change prototype to make this a proper overload for Frame::clear once again(!).
1:22 AM Changeset in webkit [17284] by bdash
  • 2 edits in trunk/WebKitSite

2006-10-25 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

Fix some HTML bugs in the coding style guidelines.

  • coding/coding-style.html:
12:52 AM Changeset in webkit [17283] by bdash
  • 2 edits in trunk/WebKit

2006-10-25 Mark Rowe <​bdash@webkit.org>

Reviewed by Anders.

Build fix for the Buildbot.

  • WebView/WebHTMLView.m: (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
12:30 AM Changeset in webkit [17282] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


<rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
<rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet

  • WebView/WebPolicyDeciderMac.m: (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it
Note: See TracTimeline for information about the timeline view.