⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 27, 2006:

11:18 PM Changeset in webkit [17397] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear):
10:08 PM Changeset in webkit [17396] by mjs
  • 21 edits
    2 adds in trunk

WebCore:

Reviewed by John & Adam.

  • assorted speedups to fix perf regression from fixing correctness regression
  • WebCore.exp: exported new methods.
  • WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/CachedResource.cpp: Removed now obsolete getCFURL.
  • loader/CachedResource.h:
  • loader/mac/CachedResourceMac.mm: Added. (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is now cached in the CachedObject.
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets the WebKit side do faster dispatch for clients that implement the fast path delegate.
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods, just call loadedResourceFromMemoryCache.
  • loader/mac/WebFrameLoaderClient.h:

WebKit:

Reviewed by John & Adam.


  • various performance improvements for resource delegate dispatch.


  • avoid any ObjC messaging when fetching the WebView
  • avoid ObjC calls to WebView to get resource load delegate and impl cache
  • cache actual method pointers, not just the fact that the method is present
  • added a new SPI resource load delegate method which allows clients to get just one message in case of synchronously loading from memory cache; if this is implemented you don't get the normal delegate calls in that case.
  • various other minor tweaks
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::frameLoadCompleted):
  • WebCoreSupport/WebPageBridge.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm: (frame): (core): (kit): (getWebView): (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _updateBackground]): (-[WebFrame _clearSelectionInOtherFrames]): (-[WebFrame _isMainFrame]): (-[WebFrame webView]):
  • WebView/WebResourceLoadDelegatePrivate.h: Added.
  • WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): (WebViewGetResourceLoadDelegate): (WebViewGetResourceLoadDelegateImplementations):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
9:14 PM Changeset in webkit [17395] by oliver
  • 2 edits in trunk/WebCore

2006-10-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

build fix

  • dom/Document.cpp: (WebCore::Document::referrer):
7:08 PM Changeset in webkit [17394] by beidson
  • 6 edits in trunk

top level:

Rubber stamped by Tim Hatcher

Added "make universal" to build universal binaries

  • Makefile:
  • Makefile.shared:

WebKitTools:

Rubber stamped by Tim Hatcher

Added "make universal" to build universal binaries

  • Makefile:
  • Makefile.shared:
6:22 PM Changeset in webkit [17393] by ggaren
  • 17 edits in trunk

WebCore:

Reviewed by Maciej.

Moved some WebCoreFrameBridge functions into FrameLoader.


I had to make FrameLoader.h capable of compiling in C++-only source files
by adding some forward declarations and OBJC #ifdefs.

  • WebCore.exp:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createEmptyDocument): (WebCore::FrameMac::tokenizerProcessedData):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer):
  • loader/LoaderFunctions.h:
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::numRequests): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::startLoadingResource):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckIfReloading):
  • page/Frame.h:
  • page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): (WebCore::FrameTree::traverseNext):
  • page/FrameTree.h:
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):

WebKit:

Reviewed by Maciej.


Moved some WebCoreFrameBridge functions into FrameLoader.

  • WebView/WebFrame.mm: (-[WebFrame _numPendingOrLoadingRequests:]):
5:41 PM Changeset in webkit [17392] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Expanded the Deletion UI to lists, positioned block element and block elementss with borders.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection):
4:43 PM Changeset in webkit [17391] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Kevin Decker


Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
you haven't not finished reading this.

  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be considered also. (WebCore::InlineTextBox::paintDocumentMarkers): Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground markers should be painted, instead of a marker type. This avoids walking the collection of markers multiple times back to back. Now handles grammar markers.
4:37 PM Changeset in webkit [22438] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2006-10-27 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej.


Tighten up warning levels by removing #pragma warning(push, 0), pop

  • WebBackForwardList.h:
  • WebFrame.h:
  • WebIconDatabase.h:
3:31 PM Changeset in webkit [17390] by thatcher
  • 7 edits in trunk

WebCore:

Reviewed by Beth.

Renamed Copy Files to Copy Generated Headers.
Copy 4 DOM*Internal.h headers.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Beth.

Make a DerivedSource/Webkit directory to store migrated
internal headers from WebCore.

  • MigrateHeaders.make:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
3:07 PM Changeset in webkit [17389] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Fixed the revision number in my ChangeLog entry.

2:28 PM Changeset in webkit [17388] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Anders


  • WebView/WebFrame.mm: (-[WebFrame _createItem:]): Handle nil documentLoader the way we did before ObjC->C++ changes
2:22 PM Changeset in webkit [22437] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-27 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

<rdar://problem/4730678> Plug-ins should be able to open URLs

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
1:50 PM Changeset in webkit [17387] by sullivan
  • 6 edits in trunk

WebCore:

Reviewed by Anders

  • WebCore.exp: exported symbol for FrameMac->advanceToNextSpelling()


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.

WebKit:

Reviewed by Anders

  • WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): call advanceToNextMisspelling directly on FrameMac, bypassing bridge (-[NSArray showGuessPanel:]): ditto
1:42 PM Changeset in webkit [17386] by justing
  • 14 edits
    2 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value

Changes reflect the removal of more brs that were about
to collapse:

  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-at-end-01-expected.txt:
  • editing/inserting/insert-at-end-02-expected.txt:
  • editing/inserting/insert-br-001-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:

Added to demonstrate fix:

  • fast/forms/11423-expected.txt: Added.
  • fast/forms/11423.html: Added.

WebCore:

Reviewed by harrison


<​http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value


The regression is that foo, return, bar in a textarea serializes as 'foobar'.


Before my change in r11423, return (an InsertLineBreak) would insert a '\n'
(the line break) then a br to prevent the '\n' from collapsing, since the
insertion is being done at the end of a block (the textarea's shadow div). Then,
inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
After my change in r11423, InsertLineBreak would insert a br then a '\n' (reversed
the order). Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
serialize as "foobar" because when serializing RenderTextControl intentionally asks
textContent to not convert brs to newlines. It seems to think that the only brs in
the shadow div will be placeholders or collapsed.


We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
to insert two '\n's when at the end of a block in white-space:pre text. This alone
would have fixed the bug, but introduced a new one, because foo, return, bar would
produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
'\n' is collapsed, because of 9661). So, then I changed placeholder displacement to
displace a '\n' if it's acting as a placeholder. A "placeholder" is now defined as
a br or '\n' that will collapse (become superfluous) when content is inserted just
before it.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed. Remove a br or '\n' if content inserted just before it will cause it to collapse.
  • editing/CompositeEditCommand.h:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node to prevent a collapse as was used for the line break. Fixed comments.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call the renamed function.
12:50 PM Changeset in webkit [17385] by spadma
  • 2 edits in S60/trunk/WebKit

2006-10-27 sareen <​shyam.sareen@nokia.com>

Reviewed by ​sachin.padma@nokia.com.
DESC: Change the cenrep value in the HTTPLoaderAcceptHeader.cpp.
​http://bugs.webkit.org/show_bug.cgi?id=11434

  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp: (CHttpLoaderAcceptHeader::ReadMimeTypesL):
11:54 AM Changeset in webkit [17384] by thatcher
  • 1 edit in tags/WebKit-521.29.1/WebKit/Info.plist

Versioning

11:54 AM Changeset in webkit [17383] by thatcher
  • 1 edit in tags/WebKit-521.29.1/WebKit/WebView/WebDynamicScrollBarsView.h

Build fix.

11:53 AM Changeset in webkit [17382] by thatcher
  • 1 copy in tags/WebKit-521.29.1/WebKit

New tag (part 2).

11:52 AM Changeset in webkit [17381] by thatcher
  • 1 add in tags/WebKit-521.29.1

New tag.

11:51 AM Changeset in webkit [17380] by brmorris
  • 2 edits
    2 deletes in S60/trunk/WebKit

2006-10-16 brmorris <​thisisbradley@gmail.com>

Reviewed by Sachin.
DESC: Update svg icons in CannedImages.cpp
​http://bugs.webkit.org/show_bug.cgi?id=9435

  • BrowserCore/Misc/src/CannedImages.cpp: Update mbg includes (CCannedImages::GetImage): Update BROWSERSDK bitmap IDs (CCannedImages::LoadSvg): Update BROWSERSDK bitmap IDs
  • data/Webkit_gcce.loc: Removed.
  • data/Webkit_gcce.rss: Removed.
11:47 AM Changeset in webkit [17379] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebDynamicScrollBarsView.h

Build fix.

11:29 AM Changeset in webkit [17378] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Brady.

Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
String became an empty NSString *, instead of nil. This will become important
as we start using this conversion more.


Added work-around for AppKit crash that semantic accuracy revealed.


No testcase because I don't think there's a way to reflect this change
in a webpage yet.

  • platform/PlatformString.h: (WebCore::String::operator NSString*):
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
10:50 AM Changeset in webkit [17377] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Steve.

  • kjs/grammar.y: Add definitions of YYMALLOC and YYFREE to fix a warning some people see (not sure why others don't see it).
  • JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Touch this file to force it to re-build grammar.cpp.
10:19 AM Changeset in webkit [17376] by thatcher
  • 4 edits in tags/WebCore-521.29.2/WebCore

Reviewed by Brady


  • fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com


This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
10:15 AM Changeset in webkit [17375] by thatcher
  • 1 copy in tags/WebCore-521.29.2

New tag.

9:49 AM Changeset in webkit [17374] by darin
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/testkjs/testkjs.vcproj

Oops, forgot to save one file.

9:49 AM Changeset in webkit [17373] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Maciej,

<rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange

  • bridge/mac/WebCoreAXObject.mm: (blockquoteLevel): Calculate and return the blockquote level of the element.


(AXAttributeStringSetBlockquoteLevel):
Add, if non-zero, or clear the block quote level attribute.


(AXAttributedStringAppendText):
Send AXAttributeStringSetBlockquoteLevel.

9:48 AM Changeset in webkit [17372] by darin
  • 49 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • made changes so the code compiles with the highest warning level under MSVC (disabling some warnings, making some code fixes)
  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
  • API/JSObjectRef.cpp: (JSPropertyNameArrayGetNameAtIndex):
  • API/JSStringRef.cpp: (JSStringCreateWithCharacters):
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): (KJS::Bindings::coerceValueToNPVariantStringType): (KJS::Bindings::convertValueToNPVariant):
  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime):
  • kjs/ExecState.h: (KJS::ExecState::hadException):
  • kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits):
  • kjs/Parser.h:
  • kjs/PropertyNameArray.h: (KJS::PropertyNameArray::size):
  • kjs/array_object.cpp: (ArrayObjectImp::callAsFunction):
  • kjs/bool_object.cpp: (BooleanObjectImp::callAsFunction):
  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::collect):
  • kjs/completion.h: (KJS::Completion::isValueCompletion):
  • kjs/date_object.cpp: (KJS::findMonth):
  • kjs/debugger.cpp: (Debugger::sourceParsed): (Debugger::sourceUnused): (Debugger::exception): (Debugger::atStatement): (Debugger::callEvent): (Debugger::returnEvent):
  • kjs/dtoa.cpp:
  • kjs/error_object.cpp: (ErrorObjectImp::callAsFunction): (NativeErrorImp::callAsFunction):
  • kjs/function.cpp: (KJS::FunctionImp::processVarDecls): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionPrototype::callAsFunction):
  • kjs/grammar.y:
  • kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::Identifier::add):
  • kjs/internal.h:
  • kjs/lexer.cpp: (Lexer::lex): (Lexer::isIdentStart): (Lexer::isIdentPart): (isDecimalDigit): (Lexer::isHexDigit): (Lexer::isOctalDigit): (Lexer::matchPunctuator): (Lexer::singleEscape): (Lexer::convertOctal): (Lexer::convertHex): (Lexer::convertUnicode): (Lexer::record8):
  • kjs/lexer.h:
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
  • kjs/number_object.cpp: (integer_part_noexp): (intPow10): (NumberProtoFunc::callAsFunction): (NumberObjectImp::callAsFunction):
  • kjs/object.cpp: (KJS::JSObject::deleteProperty): (KJS::JSObject::callAsFunction): (KJS::JSObject::toBoolean): (KJS::JSObject::toObject):
  • kjs/object.h: (KJS::JSObject::getPropertySlot):
  • kjs/property_map.cpp: (KJS::isValid): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::containsGettersOrSetters):
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties):
  • kjs/property_slot.h:
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): (StringObjectImp::callAsFunction): (StringObjectFuncImp::callAsFunction):
  • kjs/ustring.cpp: (KJS::UString::Rep::computeHash): (KJS::UString::UString): (KJS::UString::from): (KJS::UString::append): (KJS::UString::ascii): (KJS::UString::operator=): (KJS::UString::find): (KJS::UString::rfind):
  • kjs/ustring.h: (KJS::UChar::high): (KJS::UChar::low): (KJS::UCharReference::low): (KJS::UCharReference::high):
  • kjs/value.cpp: (KJS::JSValue::toUInt16):
  • kjs/value.h:
  • pcre/pcre_compile.c: (get_othercase_range):
  • pcre/pcre_exec.c: (match):
  • pcre/pcre_internal.h:
  • wtf/HashFunctions.h: (WTF::intHash): (WTF::PtrHash::hash):
  • wtf/MathExtras.h: (isnan): (lround): (lroundf):
  • wtf/StringExtras.h: (strncasecmp):
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isPrintableChar):
7:41 AM Changeset in webkit [17371] by darin
  • 2 edits in trunk/WebCore
  • fix one error in the Qt build
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Updated.
7:39 AM Changeset in webkit [17370] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2006-10-27 yongjzha ​yongjun.zhang@nokia.com

Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.


​http://bugs.webkit.org/show_bug.cgi?id=11432

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):


Merge from r17367 from main branch

7:33 AM Changeset in webkit [17369] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Moved the layout test part of the change log to the layout tests directory.

7:31 AM Changeset in webkit [17368] by darin
  • 3 edits in trunk/LayoutTests
  • new test results for a couple of tests
  • fast/js/kde/RegExp-expected.txt: Affected by the change to decode \u sequences in JavaScript regular expression at the lexer level.
  • http/tests/navigation/success200-reload-expected.txt: For some reason, this is consistently not dumping the "scrolled" line any more -- since the purpose of the test has nothing to do with that, landing new results.
7:28 AM Changeset in webkit [17367] by yongjzha
  • 4 edits in S60/trunk/WebKit

2006-10-27 yongjzha ​yongjun.zhang@nokia.com

Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.


​http://bugs.webkit.org/show_bug.cgi?id=11432

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):
1:08 AM Changeset in webkit [17366] by darin
  • 2 edits in trunk/WebKit
  • build fix
  • WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
12:09 AM Changeset in webkit [17365] by darin
  • 8 edits in trunk/WebKit

Reviewed by Maciej.

  • moved methods that are there just to be called by the frame loader client into the client in an attempt to get back some of the speed we lost yesterday
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (dataSource): (decisionListener): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::canUseArchivedResource): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::createPageCache):
  • WebView/WebFrame.mm: (-[NSView setWebFrame:]): (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _saveScrollPositionAndViewStateToItem:]): (-[WebFrame _hasSelection]): (-[WebFrame _clearSelection]): (-[WebFrame _setProvisionalItem:]): (-[WebFrame _setPreviousItem:]): (-[WebFrame _setCurrentItem:]): (-[WebFrame loadArchive:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]):
  • WebView/WebHTMLViewPrivate.h:
12:08 AM Changeset in webkit [17364] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • WebCore.exp: Export more symbols needed by WebKit.

Oct 26, 2006:

11:29 PM Changeset in webkit [17363] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.

Fixed layout test crash. Oops.


  • loader/mac/WebDocumentLoader.mm: (WebCore::canonicalizedTitle):
11:08 PM Changeset in webkit [17362] by thatcher
  • 1 edit in tags/WebCore-521.29.1/WebCore/Info.plist

Versioning

11:06 PM Changeset in webkit [17361] by thatcher
  • 1 edit in tags/WebCore-521.29.1/WebCore/WebCore.exp

Build fix for 64-bit.

11:04 PM Changeset in webkit [17360] by thatcher
  • 1 copy in tags/WebCore-521.29.1/WebCore

new tag (part 2).

11:01 PM Changeset in webkit [17359] by thatcher
  • 1 add in tags/WebCore-521.29.1

new tag.

11:01 PM Changeset in webkit [17358] by thatcher
  • 1 delete in tags/WebKit-521.29.1

Bad tag.

10:59 PM Changeset in webkit [17357] by thatcher
  • 1 copy in tags/WebKit-521.29.1/WebKit

new tag (part 2).

10:58 PM Changeset in webkit [17356] by thatcher
  • 1 add in tags/WebKit-521.29.1

new tag.

10:54 PM Changeset in webkit [17355] by thatcher
  • 1 edit in trunk/WebCore/WebCore.exp

Build fix for 64-bit.

10:30 PM Changeset in webkit [17354] by bdash
  • 4 edits in trunk/JavaScriptCore

2006-10-26 W. Andy Carrel <​wac@google.com>

Reviewed by Maciej.

  • kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): Looking ahead one additional character for the benefit of scanRegExp (Lexer::scanRegExp): Change code to support unicode escapes in inline regexps.
  • kjs/lexer.h: Extra lookahead added.
  • tests/mozilla/ecma_2/RegExp/properties-001.js: Changed test to look for Unicode character rather than the '\u' escaped equivalent for .source and .toString().
8:46 PM Changeset in webkit [17353] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Brady


  • fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com


This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
7:55 PM Changeset in webkit [17352] by ggaren
  • 26 edits in trunk

WebCore:

Reviewed by Darin, Maciej.

Removed many uses of NSString *.
Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing
stringByCollapsingNonPrintingCharacters with a c++ equivalent.


PLT says no performance regression.


  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge receivedData:textEncodingName:]):
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post):
  • loader/mac/WebDocumentLoader.h:
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle):
  • loader/mac/WebFrameLoaderClient.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy):

WebKit:

Reviewed by Darin, Maciej.

Removed many uses of NSString * from WebCore.


Changed a few files to ObjC++ for compatiblity with new WebCore methods
taking WebCore::Strings as arguments.


Added a static_cast to make the c++ compiler happy.

7:55 PM Changeset in webkit [22436] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4764502> PluginStreams should cancel their loader jobs on error

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::receivedAllData): Modify assertions. None of the above functions should be run after aborting the load.
6:00 PM Changeset in webkit [22435] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginPath): (WebCore::PluginDatabaseWin::defaultPluginPaths): Look for plugins in a plugins directory which is relative to the executable directory.


(WebCore::PluginDatabaseWin::createPluginView):
Use reverseFind instead of findRev here.

5:25 PM Changeset in webkit [17351] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com

The main table at nytimes.com has a fixed width of 874px, but the table ends
up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
this. The other bug was a missing top and left of 0px on the container element,
causing the deletion UI to sometimes be offset below the table.

Now check for the element's renderer at the beginning of show() and
return early if it is null.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::updateOutlineStyle): (WebCore::DeleteButtonController::show):
5:20 PM Changeset in webkit [22434] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Beth.

Fix: <rdar://problem/4799084> Text and dropdown button too close
together in <select>s
Fix: <rdar://problem/4800493> Popup menus should be positioned so that
their text is horizontally aligned with the <select> control's text

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Switch alignment of LTR vs. RTL popups, and add padding to align the text. (WebCore::PopupMenu::paint): Add padding from the <select> control to align the text with the <select> control's text.
  • rendering/RenderThemeWin.cpp: Set svn:eol-style native. (WebCore::RenderThemeWin::systemFont): Clean up line endings. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Add some extra padding between the dropdown button and text. (WebCore::RenderThemeWin::paintMenuListButton): Clean up code a bit.
4:34 PM Changeset in webkit [22433] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Forgot to make the change to Release as well in my last checkin.

  • WebCore.vcproj/WebCore.vcproj:
4:25 PM Changeset in webkit [22432] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Steve.

Add some missing '/d' flags to xcopy calls to only copy headers if
they've been modified.

  • WebCore.vcproj/WebCore.vcproj:
4:12 PM Changeset in webkit [17350] by andersca
  • 2 edits in trunk/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Build fix.

  • html/CanvasRenderingContext2D.cpp: Include MathExtras.h
4:02 PM Changeset in webkit [22431] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForMisspellingOrBadGrammar): Build fix from Oliver.
3:57 PM Changeset in webkit [17349] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Anders.

Some changes to support new grammar checking code in WebKit.

  • WebCore.exp: added mangled symbol for Document->removeMarkers() so I can call it from WebKit


  • WebCore.xcodeproj/project.pbxproj: Made Document.h and DocumentMarker.h private so I can include them from WebKit. Made HTMLCollection.h private because Document.h uses it.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: removed unmarkAllMisspellings(); WebKit now calls through to the Document directly

WebKit:

Reviewed by Anders

  • WebView/WebFrame.mm: now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h> (-[WebFrame _unmarkAllBadGrammar]): filled in guts (-[WebFrame _unmarkAllMisspellings]): rewrote to call Document directly, bypassing bridge
3:30 PM Changeset in webkit [17348] by sullivan
  • 3 edits in trunk/WebKit
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib:


Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.

3:27 PM Changeset in webkit [17347] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Geoff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11419
REGRESSION (r17299): Assertion failure in -[WebHTMLView(WebPrivate) _topHTMLView]
([view isKindOfClass:[WebHTMLView class]]) when running the layout tests

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseMoveToX:Y:]):
3:22 PM Changeset in webkit [17346] by andersca
  • 7 edits in trunk/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Brady.

Add reverseFind to String and use it instead of findRev.
Use CString instead of DeprecatedCString in one place.


  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • loader/Decoder.cpp: (WebCore::Decoder::checkForCSSCharset):
  • platform/PlatformString.h: (WebCore::String::reverseFind):
  • platform/StringImpl.cpp: (WebCore::StringImpl::reverseFind):
  • platform/StringImpl.h:
2:27 PM Changeset in webkit [17345] by sullivan
  • 6 edits in trunk/WebCore

Reviewed by Darin


More plumbing for grammar checking. Still no grammars is checked.

  • dom/DocumentMarker.h: (WebCore::DocumentMarker::): added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"


  • platform/GraphicsContext.h: renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar; now takes a bool parameter for whether it represents bad grammar or a misspelling


  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed an existing "assert" to "ASSERT".


  • rendering/InlineTextBox.h: renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents bad grammar or a misspelling (WebCore::InlineTextBox::paintAllMarkersOfType): now handles markers of type Grammar
2:19 PM Changeset in webkit [17344] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added bug number to change log entry.

2:17 PM Changeset in webkit [17343] by darin
  • 2 edits in trunk/LayoutTests

Reviewed by Adam.

  • editing/execCommand/remove-formatting-expected.txt: Roll back results. The ones just checked in showed the same kind of intermittent failure that copy-paste-bidi.html used to show -- now we consistently get these results.
1:52 PM Changeset in webkit [17342] by thatcher
  • 1 edit
    8 copies in tags/Safari-521.29

New tag.

1:42 PM Changeset in webkit [17341] by thatcher
  • 6 edits in /

Re-versioning

1:32 PM Changeset in webkit [17340] by thatcher
  • 6 edits in /

Versioning

1:29 PM Changeset in webkit [17339] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2006-10-25 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly. Merge from CCB
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
1:23 PM Changeset in webkit [17338] by weinig
  • 37 edits in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11424
Cleanup rendering code

  • Assorted code cleanup.
  • rendering/AutoTableLayout.cpp:
  • rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::totalPercent):
  • rendering/CounterListItem.h:
  • rendering/CounterNode.cpp:
  • rendering/CounterNode.h: (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::isReset):
  • rendering/CounterResetNode.cpp:
  • rendering/CounterResetNode.h:
  • rendering/DataRef.h: (WebCore::DataRef::DataRef):
  • rendering/DeprecatedRenderSelect.h:
  • rendering/DeprecatedSlider.cpp:
  • rendering/DeprecatedSlider.h:
  • rendering/EllipsisBox.cpp:
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
  • rendering/FixedTableLayout.cpp:
  • rendering/FixedTableLayout.h:
  • rendering/GapRects.h:
  • rendering/InlineBox.cpp:
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::setConstructed): (WebCore::InlineBox::clearTruncation): (WebCore::InlineBox::markDirty):
  • rendering/InlineFlowBox.cpp:
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::setConstructed): (WebCore::InlineFlowBox::setEdges): (WebCore::InlineFlowBox::setVerticalOverflowPositions): (WebCore::InlineFlowBox::setVerticalSelectionPositions):
  • rendering/InlineRunBox.h: (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations):
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::InlineTextBox): (WebCore::InlineTextBox::end): (WebCore::InlineTextBox::textObject):
  • rendering/Length.h: (WebCore::Length::Length):
  • rendering/ListMarkerBox.cpp:
  • rendering/ListMarkerBox.h:
  • rendering/RenderPartObject.h:
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.cpp:
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
  • rendering/SVGRootInlineBox.cpp:
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox):
  • rendering/TableLayout.h: (WebCore::TableLayout::TableLayout): (WebCore::TableLayout::~TableLayout):
  • rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiRun::BidiRun):
  • rendering/break_lines.h:
12:44 PM Changeset in webkit [17337] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<​http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.

  • editing/execCommand/remove-formatting-2-expected.checksum: Added.
  • editing/execCommand/remove-formatting-2-expected.png: Added.
  • editing/execCommand/remove-formatting-2-expected.txt: Added.
  • editing/execCommand/remove-formatting-2.html: Added.
  • editing/execCommand/remove-formatting-expected.txt:

WebCore:

Reviewed by john

<​http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.


  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor. Wrapped the plain text fragment in a style span with the document default style so that it will appear unstyled regardless of where it is inserted. Could have also inserted the plain text fragment and then applied the document default style to it, but there is not yet any redundant style prevention in ApplyStyleCommand, so this is cleaner.
  • editing/Editor.h:
  • editing/JSEditor.cpp:
12:24 PM Changeset in webkit [17336] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-10-25 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
​http://bugs.webkit.org/show_bug.cgi?id=11414
merged from 3.1m r17335


  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
12:06 PM Changeset in webkit [17335] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2006-10-25 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
​http://bugs.webkit.org/show_bug.cgi?id=11414


  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
11:54 AM Changeset in webkit [17334] by oliver
  • 3 edits
    4 adds in trunk

2006-10-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.
Fixes <rdar://problem/4800518> -- needed to update existing
canvas path elements when transforms are performed on the
context.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate):
11:51 AM Changeset in webkit [22430] by andersca
  • 5 edits in branches/WindowsMerge/WebCore

2006-10-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Use FrameLoadRequest and ResourceRequest instead of passing around
the individual components.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::destroyStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::frameLoadRequest): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h:
11:27 AM Changeset in webkit [17333] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix build with older gcc 3.3.4.

  • kjs/DateMath.cpp: Remove inline prefix. (KJS::equivalentYearForDST):
11:25 AM Changeset in webkit [17332] by weinig
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

Fix Qt/Linux build.

  • platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add):
  • platform/network/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest):

WebKitQt:

Reviewed by Darin.

Fix Qt/Linux build.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::openUrl):

WebKitTools:

Reviewed by Darin.

Fix Qt/Linux build.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
11:23 AM Changeset in webkit [22429] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fix: <rdar://problem/4794162> Implement type-ahead find for popup menus
Fix: <rdar://problem/4800486> Pressing TAB while a popup is focused
should close the popup and move selection in the page

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Don't cache the focused index. (WebCore::PopupMenu::focusedIndex): Always get the focused index from the HTMLSelectElement. (WebCore::PopupMenu::setFocusedIndex): Invalidate before calling valueChanged(), as this will change the result of focusedIndex(). (WebCore::PopupMenu::scrollToRevealSelection): (WebCore::PopupMenu::updateFromElement): New method to repaint/rescroll the popup. (WebCore::PopupWndProc): Send TAB keypresses and printable characters back to the WebView for handling. Also omove handling of Return/Escape into the WM_CHAR event, as this is recommended by MSDN.
11:19 AM Changeset in webkit [17331] by aroben
  • 8 edits in trunk/WebCore

Reviewed by Adele.

Fix: <rdar://problem/3951815> add "type-to-select" feature for list
boxes (<select> elements)

This also adds type-ahead find for closed menulists (popups).

  • WebCore.xcodeproj/project.pbxproj: Version wars.
  • html/HTMLSelectElement.h: Add new instance variables for type-ahead find.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new instance variables. (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead find on printable character presses. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove redundant check that the listIndex has changed (setSelectedIndex does this for us), and fix indentation. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if to an else-if. (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind() to strip leading whitespace (including non-breaking spaces) from a string. (WebCore::HTMLSelectElement::typeAheadFind): New method to perform type-ahead find.
  • platform/PopupMenu.h: Added new updateFromElement() method to be called from RenderMenuList::updateFromElement().
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::updateFromElement): While we are using NSPopUpButtonCell for our popups, this method can stay empty.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first selected element.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Tell the popup to update if it's visible.
11:05 AM Changeset in webkit [17330] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/WebKit

Tag for WebKit for 10.4.1 (unchanged from 10.4).

11:04 AM Changeset in webkit [17329] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/JavaScriptCore

Tag for JavaScriptCore for 10.4.1 (unchanged from 10.4).

11:02 AM Changeset in webkit [17328] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/JavaScriptCore

Tag for JavaScriptCore for 10.4 (JavaScriptCore 412).

11:01 AM Changeset in webkit [17327] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/WebKit

Tag for WebKit for 10.4 (WebKit 412).

11:00 AM Changeset in webkit [17326] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4/WebCore

Tag for WebCore for 10.4 (WebCore 413).

10:59 AM Changeset in webkit [17325] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4

New release tag for 10.4.

10:57 AM Changeset in webkit [17324] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/JavaScriptCore

Tag for JavaScriptCore for 10.4.2 (JavaScriptCore 412.3).

10:56 AM Changeset in webkit [17323] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/WebKit

Tag for WebKit for 10.4.2 (WebKit 412.6).

10:55 AM Changeset in webkit [17322] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.2/WebCore

Tag for WebCore for 10.4.2 (WebCore 415.11).

10:54 AM Changeset in webkit [17321] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.2

New release tag for 10.4.2.

10:53 AM Changeset in webkit [17320] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.1/WebCore

Tag for WebCore for 10.4.1 (WebCore 415.5).

10:48 AM Changeset in webkit [17319] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.1

New release tag for 10.4.1.

10:44 AM Changeset in webkit [17318] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit

Tag for WebKit for 10.4.8 (WebKit 418.9).

10:44 AM Changeset in webkit [17317] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebCore

Tag for WebCore for 10.4.8 (WebCore 418.21).

10:44 AM Changeset in webkit [17316] by thatcher
  • 1 delete in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit

bad tag.

10:43 AM Changeset in webkit [17315] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit/WebCore

Tag for WebCore for 10.4.8 (WebCore 418.21).

10:42 AM Changeset in webkit [17314] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/WebKit

Tag for WebKit for 10.4.8 (WebKit 418.9).

10:40 AM Changeset in webkit [17313] by darin
  • 1 edit in trunk/WebCore/ChangeLog

"causing give inconsistent results" -> "causing inconsistent results"

10:40 AM Changeset in webkit [17312] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/JavaScriptGlue

Tag for JavaScriptGlue for 10.4.8 (unchanged from 10.4.7).

10:39 AM Changeset in webkit [17311] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Anders.

  • removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
  • editing/pasteboard/copy-paste-bidi-expected.txt: New results, without the anonymous block that sometimes appeared and sometimes did not.

WebCore:

Reviewed by Anders.

  • removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Use two vectors instead of a map: more efficient, deterministic. There was no reason to use a hash table.
10:39 AM Changeset in webkit [17310] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.8/JavaScriptCore

Tag for JavaScriptCore for 10.4.8 (unchanged from 10.4.7).

10:38 AM Changeset in webkit [17309] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.8

New release tag.

9:59 AM Changeset in webkit [17308] by darin
  • 2 edits in trunk/LayoutTests
  • oops, checked in failure results, not success
  • fast/js/string-property-iteration-expected.txt: Successful results.
9:46 AM Changeset in webkit [17307] by darin
  • 1 edit
    3 adds in trunk/LayoutTests
  • checked in some missing results (if these are wrong we could remove or disable the test)
  • svg/hixie/cascade/002-expected.checksum: Added.
  • svg/hixie/cascade/002-expected.png: Added.
  • svg/hixie/cascade/002-expected.txt: Added.
9:39 AM Changeset in webkit [17306] by darin
  • 8 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by John.

  • fix iteration of properties of string objects (found because of a warning emitted by the MSVC compiler)
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): Change code that wants to format a number as a string to use UString::from. Before it was using the UString constructor that makes a string from a character!
  • kjs/ustring.h:
  • kjs/ustring.cpp: Remove the dangerous and not all that helpful UString(char) constructor.
  • kjs/grammar.y: Change code to not depend on the UString(char) constructor. This is potentially more efficient anyway because we could overload the + operator some day to handle char* directly instead of creating a UString.
  • kjs/nodes2string.cpp: (SourceStream::operator<<): Change code to not depend on the UString(char) constructor.

LayoutTests:

Reviewed by John.

  • add a test for iteration of properties of string objects
  • fast/js/resources/string-property-iteration.js: Added.
  • fast/js/string-property-iteration-expected.txt: Added.
  • fast/js/string-property-iteration.html: Added.
9:06 AM Changeset in webkit [17305] by sullivan
  • 1 edit in trunk/WebKit/English.lproj/Localizable.strings
9:05 AM Changeset in webkit [17304] by brmorris
  • 67 edits
    17 copies in S60/branches/s60-RnD-06wk43

2006-10-25 yadavall <​sriram.yadavalli@nokia.com>

Merge of r17301 to s60-RnD-06wk43 release branch.

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
​http://bugs.webkit.org/show_bug.cgi?id=11407

9:05 AM Changeset in webkit [17303] by sullivan
  • 2 edits in trunk/WebKit

No review, just two localized string changes.


  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
  • English.lproj/Localizable.strings: updated for these changes
8:23 AM Changeset in webkit [17302] by spadma
  • 3 edits in S60/trunk/WebKit

2006-10-25 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly
​http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
6:26 AM Changeset in webkit [17301] by spadma
  • 67 edits
    17 adds in S60/trunk

2006-10-25 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
​http://bugs.webkit.org/show_bug.cgi?id=11407

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL): (CBrCtl::UpdateDefaultSoftkeysL): (CBrCtl::CreateWidgetExtensionL):
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::WidgetExtension):
  • BrowserView/inc/webkitbridge.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::MakeVisible): (CWebKitView::Draw):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LayoutChanged): (CWebKitBridge::createWidgetObject):
  • Plugin/inc/PluginHandler.h:
  • Plugin/inc/PluginSkin.h: (CPluginSkin::WebKitControl): (CPluginSkin::Frame):
  • Plugin/inc/PluginWin.h:
  • Plugin/inc/npapi.h:
  • Plugin/src/NpnImplementation.cpp: (NpnGetValue):
  • Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginHandler::LoadPluginsSyncL): (CPluginHandler::LoadPluginsL): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::ReloadPluginsL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::CreatePluginWinL): (CPluginSkin::SelectViewerAndDownloadL): (CPluginSkin::PluginScriptableObject):
  • Plugin/src/PluginWin.cpp: (CPluginWin::WindowScriptNPObject): (CPluginWin::PluginScriptableObject):
  • group/BrowserView.mmp:
  • group/Plugin.mmp:
  • group/webkit.mmp:
  • rom/webkit.iby:
3:34 AM Changeset in webkit [17300] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Anders.

  • .5% speed improvement by avoiding excess CFURLRef allocation
  • loader/CachedResource.cpp: (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL here for later reuse.
  • loader/CachedResource.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
Note: See TracTimeline for information about the timeline view.