Timeline

Oct 28, 2006:

11:48 PM Changeset in webkit [17405] by darin

• 75 edits
  4 deletes in trunk

JavaScriptCore:

Reviewed by Maciej.

• renamed PassRefPtr::release to releaseRef to make it clearer that it's the counterpart of adoptRef, and to make it harder to confuse it with the safer-to-use RefPtr::release

• kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::UCharBufferTranslator::translate):
• kjs/ustring.cpp: (KJS::UString::Rep::create):
• wtf/PassRefPtr.h: (WTF::PassRefPtr::PassRefPtr): (WTF::PassRefPtr::~PassRefPtr): (WTF::PassRefPtr::get): (WTF::PassRefPtr::releaseRef): (WTF::PassRefPtr::operator->): (WTF::PassRefPtr::operator=): (WTF::adoptRef): (WTF::static_pointer_cast): (WTF::const_pointer_cast):
• wtf/RefPtr.h: (WTF::RefPtr::RefPtr): (WTF::RefPtr::operator=):

WebCore:

Reviewed by Maciej.

• eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDecider, WebCoreFrameLoaderAsDelegate, and WebCoreMainResourceLoaderAsPolicyDelegate

• grouped the state related to policy decisions into a PolicyCheck class to simplify the FrameLoader logic

• removed six methods from the bridge, reducing FrameLoader's use of the bridge to a single method

• changed form state to always use HashMap instead of NSDictionary

• moved the defersLoading flag from WebView to WebCore::Page and changed code to consistently call it defersLoading rather than defersCallbacks

• updated for rename of PassRefPtr::release to releaseRef
• replaced all uses of APPLE with appropriate PLATFORM defines
• cleaned up kjs_binding.h a bit
• cleaned up FrameMac.h a bit

• loader/mac/WebPolicyDecider.h: Removed.
• loader/mac/WebPolicyDecider.mm: Removed.
• WebCore.xcodeproj/project.pbxproj: Updated for removal.

• WebCore.exp:
• bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): (KJS::ScriptInterpreter::wasRunByUserGesture):
• bindings/js/kjs_binding.h: (KJS::ScriptInterpreter::setCurrentEvent): (KJS::ScriptInterpreter::setInlineCode): (KJS::ScriptInterpreter::setProcessingTimerCallback): (KJS::ScriptInterpreter::getCurrentEvent): (KJS::cacheDOMObject): (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
• bridge/AXObjectCache.h:
• bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent): (WebCore::FrameMac::passMouseDownEventToWidget): (WebCore::FrameMac::handleMouseMoveEvent):
• bridge/mac/PageMac.mm: (WebCore::Page::Page):
• bridge/mac/WebCoreEditCommand.mm:
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
• css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
• css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
• css/CSSValueList.cpp: (WebCore::CSSValueList::append):
• css/cssparser.cpp: (WebCore::CSSParser::parseValue):
• css/cssparser.h:
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateSelection): (WebCore::Document::implicitClose): (WebCore::Document::setFocusNode):
• dom/Document.h:
• editing/ReplaceSelectionCommand.h:
• html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
• loader/mac/FrameLoader.h: (WebCore::PolicyCheck::request):
• loader/mac/FrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::open): (WebCore::FrameLoader::stopLoading): (WebCore::setAllDefersLoading): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::dropRequest): (WebCore::FrameLoaderClient::~FrameLoaderClient):
• loader/mac/WebFormState.h:
• loader/mac/WebFormState.mm:
• loader/mac/WebFrameLoaderClient.h:
• loader/mac/WebLoader.h: (WebCore::WebResourceLoader::defersLoading):
• loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::setDefersLoading):
• loader/mac/WebMainResourceLoader.h:
• loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::releaseDelegate): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
• page/Frame.cpp: (WebCore::Frame::paint):
• page/FrameView.cpp: (WebCore::FrameView::layout):
• page/FrameView.h:
• page/Page.cpp: (WebCore::Page::setDefersLoading):
• page/Page.h: (WebCore::Page::defersLoading):
• platform/DeprecatedString.h:
• platform/DeprecatedStringList.h:
• platform/FontFallbackList.h:
• platform/PlatformKeyboardEvent.h:
• platform/PlatformMouseEvent.h:
• platform/PlatformWheelEvent.h:
• platform/mac/ClipboardMac.h:
• platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::dragNSImage): (WebCore::ClipboardMac::sourceOperation): (WebCore::ClipboardMac::destinationOperation):
• rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
• rendering/break_lines.cpp: (WebCore::nextBreakablePosition):

WebKit:

Reviewed by Maciej.

• eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDeciderMac

• moved the defersLoading flag from WebView to WebCore::Page

• removed unused copies of four methods that in the frame bridge; the actually-used copies are in the page bridge

• updated for rename of PassRefPtr::release to releaseRef

• WebView/WebPolicyDeciderMac.h: Removed.
• WebView/WebPolicyDeciderMac.m: Removed.
• WebKit.xcodeproj/project.pbxproj: Updated for removal.

• Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:]):
• Plugins/WebNetscapePluginStream.mm:
• WebCoreSupport/WebFrameBridge.mm:
• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::willCloseDocument): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::cancelPolicyCheck): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::setUpPolicyListener): (WebFrameLoaderClient::receivedPolicyDecison): (WebFrameLoaderClient::userAgent): (-[WebFramePolicyListener initWithWebCoreFrame:]): (-[WebFramePolicyListener invalidate]): (-[WebFramePolicyListener dealloc]): (-[WebFramePolicyListener finalize]): (-[WebFramePolicyListener receivedPolicyDecision:]): (-[WebFramePolicyListener ignore]): (-[WebFramePolicyListener download]): (-[WebFramePolicyListener use]): (-[WebFramePolicyListener continue]):
• WebCoreSupport/WebPageBridge.mm: (-[WebPageBridge runModal]):
• WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
• WebView/WebFormDelegate.h:
• WebView/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]): (-[WebFormDelegate textFieldDidEndEditing:inFrame:]): (-[WebFormDelegate textDidChangeInTextField:inFrame:]): (-[WebFormDelegate textDidChangeInTextArea:inFrame:]): (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
• WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _isFrameSet]):
• WebView/WebFrameInternal.h:
• WebView/WebFrameView.mm: (-[WebFrameView _shouldDrawBorder]):
• WebView/WebHTMLView.m: (-[NSArray knowsPageRange:]):
• WebView/WebView.mm: (-[WebView _formDelegate]):
• WebView/WebViewInternal.h:
• WebView/WebViewPrivate.h:

4:44 PM Changeset in webkit [17404] by aroben

• 1 edit in trunk/WebCore/ChangeLog

Adding forgotten Bugzilla reference.

4:41 PM Changeset in webkit [17403] by aroben

• 2 edits in trunk

Fixing ChangeLog entries: r17933 => r17399.

4:39 PM Changeset in webkit [17402] by aroben

• 13 edits in trunk

WebCore:

Reviewed by Maciej.

Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
point instead of being passed one explicitly.

• WebCore.exp: Change constructor symbol.
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and hitTest(). (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
• dom/Document.cpp: (WebCore::Document::elementFromPoint): Ditto. (WebCore::Document::prepareMouseEvent): Ditto.
• page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Ditto. (WebCore::Frame::hitTestResultAtPoint): Ditto.
• page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Ditto.
• rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Initalize m_point with the passed point.
• rendering/HitTestResult.h: Update constructor declaration.
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Update to new constructor and hitTest(). (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the HitTestResult instead of being passed one. (WebCore::RenderLayer::hitTestLayer): Ditto.
• rendering/RenderLayer.h: Update declarations.

WebKit:

Reviewed by Maciej.

Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point.

• WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to HitTestResult constructor.

2:43 PM Changeset in webkit [22439] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• WebCore.vcproj/WebCore.vcproj: Adding new HitTestResult.{cpp,h} files.

2:33 PM Changeset in webkit [17401] by weinig

• 4 edits in trunk/WebCore

Reviewed by Anders.

Fix Qt/Linux build.

• CMakeLists.txt:
• platform/qt/FrameQtClient.cpp: (WebCore::numRequests): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
• platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::updateFromElement):

11:56 AM Changeset in webkit [17400] by weinig

• 2 edits in trunk/WebCore

Tweaked by Sam. Reviewed by Brady.

Fix for: ​http://bugs.webkit.org/show_bug.cgi?id=11437
Initialize m_modifyBiasSet to false, as it sometimes gets
used before it has been initalized.

• editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):

11:28 AM Changeset in webkit [17399] by bdakin

• 75 edits
  3 adds in trunk

WebCore:

Reviewed by Darin.

This is the WebCore half of pushing elementAtPoint and the backend
of WebElementDictionary into WebCore. Most of the changes below are
to accommodate one of the following:

-NodeInfo is now a stand-alone class called HitTestResult.

Previously it was defined in RenderObject.h, but not for
any particular reason. The WebElementDictionary
functionality that was pushed into WebCore has been pushed
specifically into the this class. In fact,
WebElementDictionary now keeps a HitTestResult as a member
varibale.

-The enumeration AccessPolicy is now called

ClipboardAccessPolicy and is defined in its own header. It
was previously defined in ClipboardMac.h, but is now
defined independently to avoid including ClipboardMac.h
from within FrameMac.h since FrameMac.h is now included in
WebElementDictionary.m in WebKit.

-Element now has a virtual target() for the sake of

NodeInfo::targetFrame()

• WebCore.exp: Several WebCore functions are newly called from WebKit, so they have been added here.
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOM.mm: Must include Image.h because of adjustments to ClipboardMac.
• bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy and HitTestResult changes. (WebCore::FrameMac::eventMayStartDrag): Same. (WebCore::FrameMac::handleMouseMoveEvent): Same. (WebCore::FrameMac::dispatchCPPEvent): Same. (WebCore::FrameMac::mayDHTMLCut): Same. (WebCore::FrameMac::mayDHTMLCopy): Same. (WebCore::FrameMac::mayDHTMLPaste): Same. (WebCore::FrameMac::tryDHTMLCut): Same (WebCore::FrameMac::tryDHTMLCopy): Same. (WebCore::FrameMac::tryDHTMLPaste): Same.
• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to HitTestResult changes. (-[WebCoreAXObject accessibilityHitTest:]): Same.
• bridge/mac/WebCoreFrameBridge.h: Same.
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for ClipboardAccessPolicy changes. (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same. (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
• dom/Document.cpp: (WebCore::Document::elementFromPoint): Adjust for HitTestResult changes. (WebCore::Document::prepareMouseEvent): Same.
• dom/Element.h: (WebCore::Element::target): Now has a virtual target()
• html/HTMLAnchorElement.h: Same.
• html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult changes.
• html/HTMLAreaElement.h: Virtual target()
• html/HTMLBaseElement.h: (WebCore::HTMLBaseElement::target): Same.
• html/HTMLFormElement.h: Same.
• html/HTMLLinkElement.h: Same.
• html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult changes.
• html/HTMLMapElement.h: Same.
• page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Same. (WebCore::Frame::hitTestResultAtPoint): Same.
• page/Frame.h: Same.
• page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Same.
• platform/mac/ClipboardAccessPolicy.h: Added. (WebCore::):
• platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, include ClipboardAccessPolicy.h, and rename AccessPolicy to ClipboardAccessPolicy.
• platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy. (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::setAccessPolicy): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::setDropEffect): (WebCore::ClipboardMac::setEffectAllowed):
• rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult changes.
• rendering/EllipsisBox.h:
• rendering/HitTestResult.cpp: Added. (WebCore::HitTestResult::HitTestResult): (WebCore::HitTestResult::~HitTestResult): (WebCore::HitTestResult::operator=): (WebCore::HitTestResult::setInnerNode): (WebCore::HitTestResult::setInnerNonSharedNode): (WebCore::HitTestResult::setURLElement): (WebCore::HitTestResult::setScrollbar): (WebCore::HitTestResult::targetFrame): (WebCore::HitTestResult::boundingBox): (WebCore::HitTestResult::isSelected): (WebCore::HitTestResult::title):
• rendering/HitTestResult.h: Added. (WebCore::HitTestResult::readonly): (WebCore::HitTestResult::active): (WebCore::HitTestResult::mouseMove): (WebCore::HitTestResult::innerNode): (WebCore::HitTestResult::innerNonSharedNode): (WebCore::HitTestResult::point): (WebCore::HitTestResult::URLElement): (WebCore::HitTestResult::scrollbar): (WebCore::HitTestResult::setPoint): (WebCore::HitTestResult::setReadonly): (WebCore::HitTestResult::setActive): (WebCore::HitTestResult::setMouseMove):
• rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
• rendering/InlineBox.h: Same.
• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): Same.
• rendering/InlineFlowBox.h: Same.
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint): Same.
• rendering/InlineTextBox.h: Same.
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Same. (WebCore::RenderBlock::nodeAtPoint): Same.
• rendering/RenderBlock.h: Same.
• rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): Same.
• rendering/RenderBox.h: Same.
• rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines): Same.
• rendering/RenderFlow.h: Same.
• rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::nodeAtPoint): Same.
• rendering/RenderForeignObject.h: Same.
• rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint): Same.
• rendering/RenderFrameSet.h: Same.
• rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Same.
• rendering/RenderImage.h: Same.
• rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint): Same.
• rendering/RenderInline.h: Same.
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Same. (WebCore::RenderLayer::hitTest): Same. (WebCore::RenderLayer::hitTestLayer): Same. (WebCore::RenderLayer::updateHoverActiveState): Same.
• rendering/RenderLayer.h: Same.
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInScrollbar): Same.
• rendering/RenderListBox.h: Same.
• rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): Same. (WebCore::RenderObject::setInnerNode): Same. (WebCore::RenderObject::nodeAtPoint): Same.
• rendering/RenderObject.h: Remove NodeInfo class and forward declare HitTestResult.
• rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult changes.
• rendering/RenderPath.h: Same.
• rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): Same.
• rendering/RenderSVGImage.h: Same
• rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint): Same.
• rendering/RenderSVGText.h: Same.
• rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): Same.
• rendering/RenderTableRow.h: Same.
• rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint): Same.
• rendering/RenderTableSection.h: Same.
• rendering/RenderText.h: Same. (WebCore::RenderText::nodeAtPoint): Same.
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): Same.
• rendering/RenderTextControl.h: Same.
• rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): Same.
• rendering/RootInlineBox.h: Same.

WebKit:

Reviewed by Darin.

This is the WebKit half of pushing the guts of elementAtPoint and
WebElementDictionary into WebCore. Among other things, this patch
makes WebElementDictionary.m and WebHTMLView.m Objective-C++

• MigrateHeaders.make: Add DOMElementInternal.h to the list of headers to migrate.
• Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and NSPoint member variables with a HitTestResult member variable.
• Misc/WebElementDictionary.m: (addLookupKey): Formatting. (-[WebElementDictionary initWithHitTestResult:]): Constructor just takes a HitTestResult now and sets the member variable. (-[WebElementDictionary dealloc]): delete HitTestResult. (-[WebElementDictionary finalize]): Address HitTestResult. (-[WebElementDictionary _domNode]): Use HitTestResult and call into WebCore. (-[WebElementDictionary objectForKey:]): Same. (-[WebElementDictionary _webFrame]): Same. (-[WebElementDictionary _targetWebFrame]): Same. (-[WebElementDictionary _title]): Same. (-[WebElementDictionary _imageRect]): Same. (-[WebElementDictionary _isSelected]): Same.
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebFrame.mm: (core): Convert from DOMNode* to Node* (kit): Convert from Node* to DOMNode*
• WebView/WebFrameInternal.h: Support for the above.
• WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly into Frame.cpp to get HitTestResult.

1:19 AM Changeset in webkit [17398] by mjs

• 2 edits in trunk

WebCore:

Removed accidentally committed duplicate ChangeLog entries.

WebKit:

Removed accidentally committed duplicate ChangeLog entries.

Oct 27, 2006:

11:18 PM Changeset in webkit [17397] by mjs

• 2 edits in trunk/WebCore

Reviewed by Anders.

• reverted fix for ​http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance impact of fixing it again.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear):

10:08 PM Changeset in webkit [17396] by mjs

• 21 edits
  2 adds in trunk

WebCore:

Reviewed by John & Adam.

• assorted speedups to fix perf regression from fixing correctness regression

• WebCore.exp: exported new methods.
• WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm:
• loader/CachedResource.cpp: Removed now obsolete getCFURL.
• loader/CachedResource.h:
• loader/mac/CachedResourceMac.mm: Added. (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is now cached in the CachedObject.
• loader/mac/FrameLoader.h:
• loader/mac/FrameLoader.mm: (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets the WebKit side do faster dispatch for clients that implement the fast path delegate.
• loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods, just call loadedResourceFromMemoryCache.
• loader/mac/WebFrameLoaderClient.h:

WebKit:

Reviewed by John & Adam.

• various performance improvements for resource delegate dispatch.

• avoid any ObjC messaging when fetching the WebView
• avoid ObjC calls to WebView to get resource load delegate and impl cache
• cache actual method pointers, not just the fact that the method is present
• added a new SPI resource load delegate method which allows clients to get just one message in case of synchronously loading from memory cache; if this is implemented you don't get the normal delegate calls in that case.
• various other minor tweaks

• WebCoreSupport/WebFrameBridge.h:
• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::frameLoadCompleted):
• WebCoreSupport/WebPageBridge.h:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebFrame.mm: (frame): (core): (kit): (getWebView): (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _updateBackground]): (-[WebFrame _clearSelectionInOtherFrames]): (-[WebFrame _isMainFrame]): (-[WebFrame webView]):
• WebView/WebResourceLoadDelegatePrivate.h: Added.
• WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): (WebViewGetResourceLoadDelegate): (WebViewGetResourceLoadDelegateImplementations):
• WebView/WebViewInternal.h:
• WebView/WebViewPrivate.h:

9:14 PM Changeset in webkit [17395] by oliver

• 2 edits in trunk/WebCore

2006-10-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

build fix

• dom/Document.cpp: (WebCore::Document::referrer):

7:08 PM Changeset in webkit [17394] by beidson

• 6 edits in trunk

top level:

Rubber stamped by Tim Hatcher

Added "make universal" to build universal binaries

• Makefile:
• Makefile.shared:

WebKitTools:

Rubber stamped by Tim Hatcher

Added "make universal" to build universal binaries

• Makefile:
• Makefile.shared:

6:22 PM Changeset in webkit [17393] by ggaren

• 17 edits in trunk

WebCore:

Reviewed by Maciej.

Moved some WebCoreFrameBridge functions into FrameLoader.

I had to make FrameLoader.h capable of compiling in C++-only source files
by adding some forward declarations and OBJC #ifdefs.

• WebCore.exp:
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::createEmptyDocument): (WebCore::FrameMac::tokenizerProcessedData):
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm:
• dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer):
• loader/LoaderFunctions.h:
• loader/mac/FrameLoader.h:
• loader/mac/FrameLoader.mm: (WebCore::numRequests): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::startLoadingResource):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckIfReloading):
• page/Frame.h:
• page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): (WebCore::FrameTree::traverseNext):
• page/FrameTree.h:
• platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):

WebKit:

Reviewed by Maciej.

Moved some WebCoreFrameBridge functions into FrameLoader.

• WebView/WebFrame.mm: (-[WebFrame _numPendingOrLoadingRequests:]):

5:41 PM Changeset in webkit [17392] by thatcher

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Expanded the Deletion UI to lists, positioned block element and block elementss with borders.

• editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection):

4:43 PM Changeset in webkit [17391] by sullivan

• 3 edits in trunk/WebCore

Reviewed by Kevin Decker

Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
you haven't not finished reading this.

• rendering/InlineTextBox.h:
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be considered also. (WebCore::InlineTextBox::paintDocumentMarkers): Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground markers should be painted, instead of a marker type. This avoids walking the collection of markers multiple times back to back. Now handles grammar markers.

4:37 PM Changeset in webkit [22438] by sfalken

• 4 edits in branches/WindowsMerge/WebKitWin

2006-10-27 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Maciej.

Tighten up warning levels by removing #pragma warning(push, 0), pop

• WebBackForwardList.h:
• WebFrame.h:
• WebIconDatabase.h:

3:31 PM Changeset in webkit [17390] by thatcher

• 7 edits in trunk

WebCore:

Reviewed by Beth.

Renamed Copy Files to Copy Generated Headers.
Copy 4 DOM*Internal.h headers.

• WebCore.xcodeproj/project.pbxproj:
• bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Beth.

Make a DerivedSource/Webkit directory to store migrated
internal headers from WebCore.

• MigrateHeaders.make:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers

3:07 PM Changeset in webkit [17389] by justing

• 1 edit in trunk/WebCore/ChangeLog

Fixed the revision number in my ChangeLog entry.

2:28 PM Changeset in webkit [17388] by sullivan

• 2 edits in trunk/WebKit

Reviewed by Anders

• fixed ​http://bugs.webkit.org/show_bug.cgi?id=11439 REGRESSION: Another page loading crash

• WebView/WebFrame.mm: (-[WebFrame _createItem:]): Handle nil documentLoader the way we did before ObjC->C++ changes

2:22 PM Changeset in webkit [22437] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-10-27 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

<rdar://problem/4730678> Plug-ins should be able to open URLs

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

1:50 PM Changeset in webkit [17387] by sullivan

• 6 edits in trunk

WebCore:

Reviewed by Anders

• WebCore.exp: exported symbol for FrameMac->advanceToNextSpelling()

• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.

WebKit:

Reviewed by Anders

• WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): call advanceToNextMisspelling directly on FrameMac, bypassing bridge (-[NSArray showGuessPanel:]): ditto

1:42 PM Changeset in webkit [17386] by justing

• 14 edits
  2 adds in trunk

LayoutTests:

Reviewed by harrison

<​http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value

Changes reflect the removal of more brs that were about
to collapse:

• editing/deleting/delete-4038408-fix-expected.txt:
• editing/inserting/insert-3654864-fix-expected.txt:
• editing/inserting/insert-3659587-fix-expected.txt:
• editing/inserting/insert-3775316-fix-expected.txt:
• editing/inserting/insert-at-end-01-expected.txt:
• editing/inserting/insert-at-end-02-expected.txt:
• editing/inserting/insert-br-001-expected.txt:
• editing/inserting/insert-br-005-expected.txt:

Added to demonstrate fix:

• fast/forms/11423-expected.txt: Added.
• fast/forms/11423.html: Added.

WebCore:

Reviewed by harrison

<​http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value

The regression is that foo, return, bar in a textarea serializes as 'foobar'.

Before my change in r11423, return (an InsertLineBreak) would insert a '\n'
(the line break) then a br to prevent the '\n' from collapsing, since the
insertion is being done at the end of a block (the textarea's shadow div). Then,
inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
After my change in r11423, InsertLineBreak would insert a br then a '\n' (reversed
the order). Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
serialize as "foobar" because when serializing RenderTextControl intentionally asks
textContent to not convert brs to newlines. It seems to think that the only brs in
the shadow div will be placeholders or collapsed.

We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
to insert two '\n's when at the end of a block in white-space:pre text. This alone
would have fixed the bug, but introduced a new one, because foo, return, bar would
produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
'\n' is collapsed, because of 9661). So, then I changed placeholder displacement to
displace a '\n' if it's acting as a placeholder. A "placeholder" is now defined as
a br or '\n' that will collapse (become superfluous) when content is inserted just
before it.

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed. Remove a br or '\n' if content inserted just before it will cause it to collapse.
• editing/CompositeEditCommand.h:
• editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node to prevent a collapse as was used for the line break. Fixed comments.
• editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call the renamed function.

12:50 PM Changeset in webkit [17385] by spadma

• 2 edits in S60/trunk/WebKit

2006-10-27 sareen <​shyam.sareen@nokia.com>

Reviewed by ​sachin.padma@nokia.com.
DESC: Change the cenrep value in the HTTPLoaderAcceptHeader.cpp.
​http://bugs.webkit.org/show_bug.cgi?id=11434

• ResourceLoader/src/HttpLoaderAcceptHeader.cpp: (CHttpLoaderAcceptHeader::ReadMimeTypesL):

11:54 AM Changeset in webkit [17384] by thatcher

• 1 edit in tags/WebKit-521.29.1/WebKit/Info.plist

Versioning

11:54 AM Changeset in webkit [17383] by thatcher

• 1 edit in tags/WebKit-521.29.1/WebKit/WebView/WebDynamicScrollBarsView.h

Build fix.

11:53 AM Changeset in webkit [17382] by thatcher

• 1 copy in tags/WebKit-521.29.1/WebKit

New tag (part 2).

11:52 AM Changeset in webkit [17381] by thatcher

• 1 add in tags/WebKit-521.29.1

New tag.

11:51 AM Changeset in webkit [17380] by brmorris

• 2 edits
  2 deletes in S60/trunk/WebKit

2006-10-16 brmorris <​thisisbradley@gmail.com>

Reviewed by Sachin.
DESC: Update svg icons in CannedImages.cpp
​http://bugs.webkit.org/show_bug.cgi?id=9435

• BrowserCore/Misc/src/CannedImages.cpp: Update mbg includes (CCannedImages::GetImage): Update BROWSERSDK bitmap IDs (CCannedImages::LoadSvg): Update BROWSERSDK bitmap IDs
• data/Webkit_gcce.loc: Removed.
• data/Webkit_gcce.rss: Removed.

11:47 AM Changeset in webkit [17379] by thatcher

• 1 edit in trunk/WebKit/WebView/WebDynamicScrollBarsView.h

Build fix.

11:29 AM Changeset in webkit [17378] by ggaren

• 3 edits in trunk/WebCore

Reviewed by Brady.

Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
String became an empty NSString *, instead of nil. This will become important
as we start using this conversion more.

Added work-around for AppKit crash that semantic accuracy revealed.

No testcase because I don't think there's a way to reflect this change
in a webpage yet.

• platform/PlatformString.h: (WebCore::String::operator NSString*):
• platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):

10:50 AM Changeset in webkit [17377] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Steve.

• kjs/grammar.y: Add definitions of YYMALLOC and YYFREE to fix a warning some people see (not sure why others don't see it).

• JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Touch this file to force it to re-build grammar.cpp.

10:19 AM Changeset in webkit [17376] by thatcher

• 4 edits in tags/WebCore-521.29.2/WebCore

Reviewed by Brady

• fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com

This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac

• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame

10:15 AM Changeset in webkit [17375] by thatcher

• 1 copy in tags/WebCore-521.29.2

New tag.

9:49 AM Changeset in webkit [17374] by darin

• 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/testkjs/testkjs.vcproj

Oops, forgot to save one file.

9:49 AM Changeset in webkit [17373] by harrison

• 2 edits in trunk/WebCore

Reviewed by Maciej,

<rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange

• bridge/mac/WebCoreAXObject.mm: (blockquoteLevel): Calculate and return the blockquote level of the element.

(AXAttributeStringSetBlockquoteLevel):
Add, if non-zero, or clear the block quote level attribute.

(AXAttributedStringAppendText):
Send AXAttributeStringSetBlockquoteLevel.

9:48 AM Changeset in webkit [17372] by darin

• 49 edits in trunk/JavaScriptCore

Reviewed by Geoff.

• made changes so the code compiles with the highest warning level under MSVC (disabling some warnings, making some code fixes)

• API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
• API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
• API/JSObjectRef.cpp: (JSPropertyNameArrayGetNameAtIndex):
• API/JSStringRef.cpp: (JSStringCreateWithCharacters):
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): (KJS::Bindings::coerceValueToNPVariantStringType): (KJS::Bindings::convertValueToNPVariant):
• kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime):
• kjs/ExecState.h: (KJS::ExecState::hadException):
• kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits):
• kjs/Parser.h:
• kjs/PropertyNameArray.h: (KJS::PropertyNameArray::size):
• kjs/array_object.cpp: (ArrayObjectImp::callAsFunction):
• kjs/bool_object.cpp: (BooleanObjectImp::callAsFunction):
• kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::collect):
• kjs/completion.h: (KJS::Completion::isValueCompletion):
• kjs/date_object.cpp: (KJS::findMonth):
• kjs/debugger.cpp: (Debugger::sourceParsed): (Debugger::sourceUnused): (Debugger::exception): (Debugger::atStatement): (Debugger::callEvent): (Debugger::returnEvent):
• kjs/dtoa.cpp:
• kjs/error_object.cpp: (ErrorObjectImp::callAsFunction): (NativeErrorImp::callAsFunction):
• kjs/function.cpp: (KJS::FunctionImp::processVarDecls): (KJS::GlobalFuncImp::callAsFunction):
• kjs/function_object.cpp: (FunctionPrototype::callAsFunction):
• kjs/grammar.y:
• kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::Identifier::add):
• kjs/internal.h:
• kjs/lexer.cpp: (Lexer::lex): (Lexer::isIdentStart): (Lexer::isIdentPart): (isDecimalDigit): (Lexer::isHexDigit): (Lexer::isOctalDigit): (Lexer::matchPunctuator): (Lexer::singleEscape): (Lexer::convertOctal): (Lexer::convertHex): (Lexer::convertUnicode): (Lexer::record8):
• kjs/lexer.h:
• kjs/math_object.cpp: (MathFuncImp::callAsFunction):
• kjs/number_object.cpp: (integer_part_noexp): (intPow10): (NumberProtoFunc::callAsFunction): (NumberObjectImp::callAsFunction):
• kjs/object.cpp: (KJS::JSObject::deleteProperty): (KJS::JSObject::callAsFunction): (KJS::JSObject::toBoolean): (KJS::JSObject::toObject):
• kjs/object.h: (KJS::JSObject::getPropertySlot):
• kjs/property_map.cpp: (KJS::isValid): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::containsGettersOrSetters):
• kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties):
• kjs/property_slot.h:
• kjs/string_object.cpp: (StringInstance::getPropertyNames): (StringObjectImp::callAsFunction): (StringObjectFuncImp::callAsFunction):
• kjs/ustring.cpp: (KJS::UString::Rep::computeHash): (KJS::UString::UString): (KJS::UString::from): (KJS::UString::append): (KJS::UString::ascii): (KJS::UString::operator=): (KJS::UString::find): (KJS::UString::rfind):
• kjs/ustring.h: (KJS::UChar::high): (KJS::UChar::low): (KJS::UCharReference::low): (KJS::UCharReference::high):
• kjs/value.cpp: (KJS::JSValue::toUInt16):
• kjs/value.h:
• pcre/pcre_compile.c: (get_othercase_range):
• pcre/pcre_exec.c: (match):
• pcre/pcre_internal.h:
• wtf/HashFunctions.h: (WTF::intHash): (WTF::PtrHash::hash):
• wtf/MathExtras.h: (isnan): (lround): (lroundf):
• wtf/StringExtras.h: (strncasecmp):
• wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isPrintableChar):

7:41 AM Changeset in webkit [17371] by darin

• 2 edits in trunk/WebCore

• fix one error in the Qt build

• platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Updated.

7:39 AM Changeset in webkit [17370] by spadma

• 4 edits in S60/branches/3.1m/WebKit

2006-10-27 yongjzha ​yongjun.zhang@nokia.com

Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.

​http://bugs.webkit.org/show_bug.cgi?id=11432

• BrowserCore/Renderers/inc/StaticImageDecoder.h:
• BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
• BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):

Merge from r17367 from main branch

7:33 AM Changeset in webkit [17369] by darin

• 1 edit in trunk/JavaScriptCore/ChangeLog

Moved the layout test part of the change log to the layout tests directory.

7:31 AM Changeset in webkit [17368] by darin

• 3 edits in trunk/LayoutTests

• new test results for a couple of tests

• fast/js/kde/RegExp-expected.txt: Affected by the change to decode \u sequences in JavaScript regular expression at the lexer level.

• http/tests/navigation/success200-reload-expected.txt: For some reason, this is consistently not dumping the "scrolled" line any more -- since the purpose of the test has nothing to do with that, landing new results.

7:28 AM Changeset in webkit [17367] by yongjzha

• 4 edits in S60/trunk/WebKit

2006-10-27 yongjzha ​yongjun.zhang@nokia.com

Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.

​http://bugs.webkit.org/show_bug.cgi?id=11432

• BrowserCore/Renderers/inc/StaticImageDecoder.h:
• BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
• BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):

1:08 AM Changeset in webkit [17366] by darin

• 2 edits in trunk/WebKit

• build fix

• WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.

12:09 AM Changeset in webkit [17365] by darin

• 8 edits in trunk/WebKit

Reviewed by Maciej.

• moved methods that are there just to be called by the frame loader client into the client in an attempt to get back some of the speed we lost yesterday

• DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm: (dataSource): (decisionListener): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::canUseArchivedResource): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::createPageCache):
• WebView/WebFrame.mm: (-[NSView setWebFrame:]): (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _saveScrollPositionAndViewStateToItem:]): (-[WebFrame _hasSelection]): (-[WebFrame _clearSelection]): (-[WebFrame _setProvisionalItem:]): (-[WebFrame _setPreviousItem:]): (-[WebFrame _setCurrentItem:]): (-[WebFrame loadArchive:]):
• WebView/WebFrameInternal.h:
• WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]):
• WebView/WebHTMLViewPrivate.h:

12:08 AM Changeset in webkit [17364] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• WebCore.exp: Export more symbols needed by WebKit.