⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 30, 2006:

9:50 PM Changeset in webkit [17472] by darin
  • 2 edits in trunk/WebKitTools
  • fixed build
  • DumpRenderTree/DumpRenderTree.m: (-[LocalPasteboard setString:forType:]): Don't use CFPasteboard.
9:49 PM Changeset in webkit [22446] by darin
  • 5 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

  • remove BrowserExtension
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • platform/win/TemporaryLinkStubs.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
9:46 PM Changeset in webkit [17471] by darin
  • 17 edits
    6 deletes in trunk/WebCore

Reviewed by Anders.

  • remove BrowserExtension
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
  • bridge/BrowserExtension.h: Removed.
  • bridge/mac/BrowserExtensionMac.h: Removed.
  • bridge/mac/BrowserExtensionMac.mm: Removed.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected):
  • bridge/win/BrowserExtensionWin.cpp: Removed.
  • bridge/win/BrowserExtensionWin.h: Removed.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
  • loader/FrameLoader.h:
  • loader/icon/IconLoader.cpp:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createWindow):
  • page/Frame.cpp: (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm): (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::isEmpty): (WebCore::FrameLoadRequest::resourceRequest): (WebCore::FrameLoadRequest::frameName): (WebCore::FrameLoadRequest::setFrameName):
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • platform/gdk/BrowserExtensionGdk.h: Removed.
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::isEmpty):
9:45 PM Changeset in webkit [17470] by darin
  • 2 edits in trunk/WebKit
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Fix comment.
9:29 PM Changeset in webkit [17469] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11353

  • Drosera/debugger.js: ParsedURL() object now recognizes local files
8:48 PM Changeset in webkit [17468] by darin
  • 5 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • DumpRenderTree/DumpRenderTree.m: Changed to allocate a local pasteboard. This should make our buildbot tests no longer need a pasteboard server.
8:17 PM Changeset in webkit [17467] by oliver
  • 57 edits
    13 moves
    7 adds
    10 deletes in trunk/WebCore

2006-10-31 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Oliver.

Modified from original due to earlier reversion

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11436

Better SVG integration in WebKit, Part I.

The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).

KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • graphics/svg/SVGResource.cpp: Removed.
  • graphics/svg/SVGResourceClipper.cpp: Removed.
  • graphics/svg/SVGResourceClipper.h: Removed.
  • graphics/svg/SVGResourceImage.h: Removed.
  • graphics/svg/SVGResourceListener.h: Removed.
  • graphics/svg/SVGResourceMarker.cpp: Removed.
  • graphics/svg/SVGResourceMarker.h: Removed.
  • graphics/svg/SVGResourceMasker.cpp: Removed.
  • graphics/svg/SVGResourceMasker.h: Removed.
  • kcanvas/KCanvasClipper.cpp: Removed.
  • kcanvas/KCanvasClipper.h: Removed.
  • kcanvas/KCanvasCreator.cpp: Removed.
  • kcanvas/KCanvasCreator.h: Removed.
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Removed.
  • kcanvas/KCanvasMarker.cpp: Removed.
  • kcanvas/KCanvasMarker.h: Removed.
  • kcanvas/KCanvasMasker.cpp: Removed.
  • kcanvas/KCanvasMasker.h: Removed.
  • kcanvas/KCanvasResource.cpp: Removed.
  • kcanvas/KCanvasResource.h: Removed.
  • kcanvas/KCanvasResourceListener.h: Removed.
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
  • kcanvas/device/qt/KCanvasClipperQt.h:
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/qt/RenderPathQt.h: Removed.
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Removed.
  • platform/GraphicsContext.h: Removed.
  • platform/GraphicsTypes.cpp: Removed.
  • platform/GraphicsTypes.h: Removed.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsTypes.cpp: (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/graphics/GraphicsTypes.h: (WebCore::):
  • platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<):
  • platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener):
  • platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById):
  • platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper):
  • platform/graphics/svg/SVGResourceImage.h: Added.
  • platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById):
  • platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker):
  • platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById):
  • platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker):
  • platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask):
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size):
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
7:53 PM Changeset in webkit [17466] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Brady


  • minor cleanup to make future patches clearer
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test with "continue" to better match structure of similar code in markMisspellings; a few other style tweaks.


(WebCore::FrameMac::markMisspellings):
renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
a block just after a break and outdented accordingly.

7:23 PM Changeset in webkit [17465] by ggaren
  • 3 edits
    2 adds in trunk/WebKitTools

Reviewed by Beth.


Reorganized project file into Delegates and Controllers groups, and split
UIDelegate stuff into a UIDelegate class.


A little birdy told me that I might end up adding some UIDelegate methods
to DRT soon.

  • DumpRenderTree/DumpRenderTree.m: (main): (runTest):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
6:54 PM Changeset in webkit [17464] by sullivan
  • 5 edits in trunk

WebCore:

Reviewed by Geoff Garen


WebCore part of change to push the code that updates the spelling panel
into WebCore, in preparation for some grammar-checking stuff.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): no more return value for this method, and update the spelling panel with the misspelled word here rather than in the WebKit callers.

WebKit:

Reviewed by Geoff Garen

  • WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): removed code to update spelling panel; WebCore handles that now (-[NSArray showGuessPanel:]): ditto
6:36 PM Changeset in webkit [17463] by sullivan
  • 3 edits in trunk/WebKit
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib: Another wording change to match framework, post-Tiger: "Check Spelling" -> "Check Document Now"
6:33 PM Changeset in webkit [17462] by oliver
  • 72 edits
    2 copies
    13 adds in trunk/WebCore

liver Hunt <​oliver@apple.com>

Reviewed by Anders.

Roll out last patch

  • CMakeLists.txt:
  • ChangeLog:
  • WebCore.xcodeproj/project.pbxproj:
  • graphics/svg/SVGResource.cpp:
  • graphics/svg/SVGResourceClipper.cpp:
  • graphics/svg/SVGResourceClipper.h:
  • graphics/svg/SVGResourceImage.h:
  • graphics/svg/SVGResourceListener.h:
  • graphics/svg/SVGResourceMarker.cpp:
  • graphics/svg/SVGResourceMarker.h:
  • graphics/svg/SVGResourceMasker.cpp:
  • graphics/svg/SVGResourceMasker.h:
  • kcanvas/KCanvasClipper.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasClipper::KCanvasClipper): (WebCore::KCanvasClipper::~KCanvasClipper): (WebCore::KCanvasClipper::resetClipData): (WebCore::KCanvasClipper::addClipData): (WebCore::KCanvasClipper::clipData): (WebCore::KCanvasClipper::externalRepresentation): (WebCore::getClipperById):
  • kcanvas/KCanvasClipper.h: Added. (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::KCClipDataList): (WebCore::KCClipDataList::addPath): (WebCore::KCanvasClipper::isClipper):
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Added. (WebCore::KCanvasImage::KCanvasImage): (WebCore::KCanvasImage::~KCanvasImage):
  • kcanvas/KCanvasMarker.cpp: Added. (WebCore::KCanvasMarker::KCanvasMarker): (WebCore::KCanvasMarker::~KCanvasMarker): (WebCore::KCanvasMarker::setMarker): (WebCore::KCanvasMarker::setRef): (WebCore::KCanvasMarker::refX): (WebCore::KCanvasMarker::refY): (WebCore::KCanvasMarker::setAngle): (WebCore::KCanvasMarker::angle): (WebCore::KCanvasMarker::setAutoAngle): (WebCore::KCanvasMarker::setUseStrokeWidth): (WebCore::KCanvasMarker::useStrokeWidth): (WebCore::KCanvasMarker::draw): (WebCore::KCanvasMarker::externalRepresentation): (WebCore::getMarkerById):
  • kcanvas/KCanvasMarker.h: Added. (WebCore::KCanvasMarker::isMarker):
  • kcanvas/KCanvasMasker.cpp: Added. (WebCore::KCanvasMasker::KCanvasMasker): (WebCore::KCanvasMasker::~KCanvasMasker): (WebCore::KCanvasMasker::setMask): (WebCore::KCanvasMasker::externalRepresentation): (WebCore::getMaskerById):
  • kcanvas/KCanvasMasker.h: Added. (WebCore::KCanvasMasker::isMasker): (WebCore::KCanvasMasker::mask):
  • kcanvas/KCanvasResource.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasResource::KCanvasResource): (WebCore::KCanvasResource::~KCanvasResource): (WebCore::KCanvasResource::addClient): (WebCore::KCanvasResource::clients): (WebCore::KCanvasResource::invalidate): (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::KCanvasResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById):
  • kcanvas/KCanvasResource.h: (WebCore::): (WebCore::KCanvasResource::isPaintServer): (WebCore::KCanvasResource::isFilter): (WebCore::KCanvasResource::isClipper): (WebCore::KCanvasResource::isMarker): (WebCore::KCanvasResource::isMasker):
  • kcanvas/KCanvasResourceListener.h: Added. (KCanvasResourceListener::KCanvasResourceListener): (KCanvasResourceListener::~KCanvasResourceListener):
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: (WebCore::KCanvasClipperQt::applyClip):
  • kcanvas/device/qt/KCanvasClipperQt.h: (WebCore::KCanvasClipperQt::KCanvasClipperQt):
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz): (WebCore::KCanvasImageQuartz::KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::init): (WebCore::KCanvasImageQuartz::size):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip): (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::cgLayer): (WebCore::KCanvasImageQuartz::setCGLayer):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/GraphicsContext.h: Added.
  • platform/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/GraphicsTypes.h: Added. (WebCore::):
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/GraphicsTypes.h:
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
5:46 PM Changeset in webkit [17461] by oliver
  • 59 edits
    13 moves
    3 adds
    2 deletes in trunk/WebCore

2006-10-31 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11436

Better SVG integration in WebKit, Part I.

The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).

KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: Removed.
  • kcanvas/KCanvasClipper.h: Removed.
  • kcanvas/KCanvasCreator.cpp: Removed.
  • kcanvas/KCanvasCreator.h: Removed.
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Removed.
  • kcanvas/KCanvasMarker.cpp: Removed.
  • kcanvas/KCanvasMarker.h: Removed.
  • kcanvas/KCanvasMasker.cpp: Removed.
  • kcanvas/KCanvasMasker.h: Removed.
  • kcanvas/KCanvasResource.cpp: Removed.
  • kcanvas/KCanvasResource.h: Removed.
  • kcanvas/KCanvasResourceListener.h: Removed.
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
  • kcanvas/device/qt/KCanvasClipperQt.h: Removed.
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/qt/RenderPathQt.h: Removed.
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Removed.
  • platform/GraphicsContext.h: Removed.
  • platform/GraphicsTypes.cpp: Removed.
  • platform/GraphicsTypes.h: Removed.
  • platform/graphics/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h: Added.
  • platform/graphics/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/graphics/GraphicsTypes.h: Added. (WebCore::):
  • platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<):
  • platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener):
  • platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById):
  • platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper):
  • platform/graphics/svg/SVGResourceImage.h: Added.
  • platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById):
  • platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker):
  • platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById):
  • platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker):
  • platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask):
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size):
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
5:44 PM Changeset in webkit [17460] by oliver
  • 2 edits in trunk/WebKitTools

2006-10-31 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Oliver.

Add new platform/graphics include directory.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
5:35 PM Changeset in webkit [17459] by thatcher
  • 2 edits in trunk

Reviewed by Brady.

Make the universal build return non-zero when module make fails.

  • Makefile:
5:33 PM Changeset in webkit [17458] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Stephanie.

Add a special case for the Internal makefiles, so it can find the OepnSource.

  • Scripts/webkitdirs.pm:
5:25 PM Changeset in webkit [17457] by sullivan
  • 10 edits in trunk

WebCore:

Reviewed by Geoff Garen.


Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.

  • bridge/EditorClient.h: declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled()


  • bridge/mac/WebCoreFrameBridge.h: removed bridge equivalents
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): convert bridge-using code to editor()->client()-using code (WebCore::FrameMac::markMisspellingsInAdjacentWords): ditto (WebCore::FrameMac::markMisspellings): ditto (WebCore::FrameMac::respondToChangedSelection): ditto


  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::client): new method, returns EditorClient pointer. In an ideal world all the code that needed to access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor. But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.

WebKit:

Reviewed by Geoff Garen.


Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.

  • WebCoreSupport/WebEditorClient.h: declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled()
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::isContinuousSpellCheckingEnabled): implement by calling through to WebView (WebEditorClient::isGrammarCheckingEnabled): ditto (WebEditorClient::spellCheckerDocumentTag): ditto


  • WebCoreSupport/WebFrameBridge.mm: removed bridge equivalents of these methods
5:21 PM Changeset in webkit [17456] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Beth.


Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
but the debugger confirmed the cause).

  • WebView/WebFrame.mm: (core): Added check for NULL bridge.
5:01 PM Changeset in webkit [17455] by ggaren
  • 32 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Removed a number of editing and selection methods from the bridge.


I moved cross-platform editing and selection code into Editor and
SelectionController, respecitvely.

I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
everything + the kitchen sink.


Specific comments below for interesting things.


  • bindings/objc/DOMInternal.h: Moved exception handling helper methods into a new file so that WebKit can use them, too. Added a helper method for handling exceptions when selecting a Range.
  • bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into WebKit, since they have to do with creating an NSAttributedString for API consumption, and not much to do with general Frame functionality.
  • editing/Editor.h: Moved lastEditCommand tracking (at least the data, for now) into the Editor. Eventually, the Frame will not have to notify the Editor of what the lastEditCommand was, since the Editor will perform all EditCommands.
  • editing/SelectionController.h: The code here is just stuff moved from the bridge.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions and return them. The bridge method to select a DOM range did this implicitly, since all ObjC DOM operations handle DOM exceptions by throwing them as ObjC exceptions.
  • editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity. The two enumerations are numerically identical, but that's an implementation detail of TextAffinity that clients shouldn't be required to know about.

WebKit:

Reviewed by Darin.

Removed a number of editing and selection methods from the bridge.


I moved cross-platform editing and selection code into WebCore::Editor and
WebCore::SelectionController, respecitvely.


All of the seemingly new code here is just code grabbed from WebCore or
merged from WebCoreFrameBridge.


I changed one piece of internal API: we now pass around Ranges in places
where we used to pass around broken out components of Ranges.


I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
Since we now include WebCore headers that depend on these #defines, we need
to keep in sync with them, to avoid binary incompatibility.

4:56 PM Changeset in webkit [17454] by thatcher
  • 2 edits in tags/WebCore-521.29.3/WebCore

Versioning

4:55 PM Changeset in webkit [17453] by thatcher
  • 2 edits in tags/WebCore-521.29.3/WebCore

Merging fix.

4:55 PM Changeset in webkit [17452] by thatcher
  • 2 edits in tags/WebCore-521.29.3/WebCore

Merging fix.

4:52 PM Changeset in webkit [17451] by thatcher
  • 1 copy in tags/WebCore-521.29.3

new tag.

4:49 PM Changeset in webkit [17450] by thatcher
  • 2 edits in trunk/WebCore

Rolling out the following change because this crash:
<rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (​http://www.photoplusexpo.com/ppe/index.jsp)

And this regression:
<rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at ​http://www.apple.com/downloads/dashboard/

2006-09-06 David Harrison <​harrison@apple.com>

Reviewed and tweaked by Tim H.

<rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation

If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
to trigger a search that will include auto activation. No PLT or iBench perf impact.
No layout tests affected. Not testable in an automated way that will work on all systems.

  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
4:48 PM Changeset in webkit [22445] by sfalken
  • 5 edits in branches/WindowsMerge/WebKitWin

2006-10-29 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam, Ada.

Expose printing methods in IWebViewPrivate and removed LPARAM-based dispatching.
Call StretchDIBits instead of BitBlt.
Add a maximum DPI (currently set at 300) to speed up printing.
Add support needed for print preview.

  • Interfaces/IWebViewPrivate.idl: added startPrintJob, endPrintJob, getPrintedPageCount, printPage
  • WebView.cpp: Added MAXIMUM_DPI setting to limit the size of print jobs for performance reasons (getPrintRects): Added. Factored out of print, added maximum DPI handling. (WebView::startPrintJob): Factored out of print (WebView::endPrintJob): Factored out of print (WebView::getPrintedPageCount): Factored out of print (WebView::printPage): Factored out of print. Replaced call to BitBlt with StretchDIBits (WebViewWndProc): Re-add support for printing a window (used by bug reporter code)
  • WebView.h: added startPrintJob, endPrintJob, getPrintedPageCount, printPage
3:25 PM Changeset in webkit [17449] by justing
  • 2 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4808375>
REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)

  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Only create VisiblePositions when we're going to use them to create a range for an emitted character. We should further speed TextIterators up by avoiding creating VisiblePositions for TIs that are only used for the characters they emit (like the one that plainText uses).
2:41 PM Changeset in webkit [17448] by weinig
  • 46 edits in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11441
More rendering code cleaning

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::RenderApplet): (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/RenderApplet.h:
  • rendering/RenderArena.cpp: (WebCore::): (WebCore::RenderArena::RenderArena): (WebCore::RenderArena::allocate): (WebCore::RenderArena::free):
  • rendering/RenderArena.h:
  • rendering/RenderBR.cpp: (WebCore::RenderBR::RenderBR): (WebCore::RenderBR::baselinePosition): (WebCore::RenderBR::lineHeight): (WebCore::RenderBR::setStyle): (WebCore::RenderBR::caretMinOffset): (WebCore::RenderBR::positionForCoordinates): (WebCore::RenderBR::inlineBox):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::setHasMarkupTruncation): (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo): (WebCore::RenderBlock::BlockSelectionInfo::block): (WebCore::RenderBlock::BlockSelectionInfo::state): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::CompactInfo::clear):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::removeChild): (WebCore::RenderButton::paintObject):
  • rendering/RenderButton.h: (WebCore::RenderButton::renderName): (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::RenderContainer):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::firstChild): (WebCore::RenderContainer::lastChild): (WebCore::RenderContainer::calcMinMaxWidth):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter): (WebCore::toRoman): (WebCore::toHebrew): (WebCore::RenderCounter::calcMinMaxWidth):
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderFieldset::setStyle):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl): (WebCore::RenderFileUploadControl::setStyle): (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcMinMaxWidth):
  • rendering/RenderFileUploadControl.h: (WebCore::RenderFileUploadControl::renderName):
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::RenderForeignObject): (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): (WebCore::RenderForeignObject::layout): (WebCore::RenderForeignObject::nodeAtPoint):
  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::renderName):
  • rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::layout): (WebCore::RenderFormElement::textAlignment):
  • rendering/RenderFormElement.h:
  • rendering/RenderFrame.cpp:
  • rendering/RenderFrame.h: (WebCore::RenderFrame::element):
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderFrameSet.h: (WebCore::RenderFrameSet::element):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderHTMLCanvas.h: (WebCore::RenderHTMLCanvas::renderName):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setStyle): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText):
  • rendering/RenderImage.h: (WebCore::RenderImage::element):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::~RenderInline): (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::paint): (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::calcMinMaxWidth): (WebCore::RenderInline::requiresLayer): (WebCore::RenderInline::width): (WebCore::RenderInline::height): (WebCore::RenderInline::renderName): (WebCore::RenderInline::nodeAtPoint): (WebCore::RenderInline::positionForCoordinates):
  • rendering/RenderInline.h: (WebCore::RenderInline::layout):
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::root): (WebCore::RenderLayer::setPos): (WebCore::RenderLayer::height): (WebCore::RenderLayer::relativePositionOffset):
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderLineEdit::updateFromElement): (WebCore::RenderLineEdit::selectionStart): (WebCore::RenderLineEdit::selectionEnd): (WebCore::RenderLineEdit::setSelectionStart): (WebCore::RenderLineEdit::setSelectionEnd): (WebCore::RenderLineEdit::setSelectionRange):
  • rendering/RenderLineEdit.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h: (WebCore::RenderListBox::renderName):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::setStyle): (WebCore::getParentOfFirstLineBox): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderListMarker.h: (WebCore::RenderListMarker::renderName): (WebCore::RenderListMarker::isListMarker):
2:35 PM Changeset in webkit [17447] by slewis
  • 5 edits in trunk

Reviewed by Darin.

Change Makefiles to return non-zero when module make fails.

  • Makefile:

WebKitTools:

Change Makefiles to return non-zero when module make fails.
Fix bug where if xcode options are not set, modules can build in the
wrong directory.

  • Makefile:
  • Scripts/webkitdirs.pm:
2:29 PM Changeset in webkit [22444] by andersca
  • 9 edits
    1 add in branches/WindowsMerge

WebCoreWin:

2006-10-30 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

If there's no plug-in for a given mime type, or if the plug-in fails
to initialize, draw the "missing plug-in" icon.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): If no plug-in can be found, create a null plugin view.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): If the plugin hasn't been started, paint the missing plugin image.


(WebCore::PluginViewWin::setNPWindowSize):
Return early if the plugin hasn't been started.


(WebCore::PluginViewWin::start):
Return if the plugin couldn't be created.


(WebCore::PluginViewWin::createNullPluginView):
New function which just creates a plugin view and doesn't try to start its plugin
(because there is none).


(WebCore::PluginViewWin::PluginViewWin):
New constructor for the null plugin view.


WebKitWin:

2006-10-30 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Add "null plugin" image resource.


2:25 PM Changeset in webkit [17446] by thatcher
  • 1 edit in trunk/WebCore/editing/DeleteButtonController.cpp

Build fix.

2:19 PM Changeset in webkit [17445] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/4478625> Basic table editing and culling

Refined the criteria for deletable elements, rely on the renderer more.
Corrected the interface positioning for elements that have borders.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::DeleteButtonController::show):
1:34 PM Changeset in webkit [17444] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Fix some timezone issues and JavaScriptCore date tests. Addresses bugzilla 4930.
  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Here's the fix, to add parenthesis for order of precedence.
  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): memset not needed as GregorianDateTime initializes itself.
12:48 PM Changeset in webkit [17443] by darin
  • 2 edits in trunk/WebCore
  • fix build
  • loader/ResourceLoader.h: Added header guard.
12:08 PM Changeset in webkit [22443] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • WebCore.vcproj/WebCore.vcproj: Added new source files from the loader directory.
12:05 PM Changeset in webkit [17442] by darin
  • 15 edits in trunk/WebCore

Reviewed by Adam.

  • fix FrameLoader files so they can be built on non-Mac platforms
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader. (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
  • page/Page.h:
  • page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong the other day.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Removed code to create the frame loader. (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
  • loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC) around the PolicyCheck definition.
  • loader/FormState.cpp: Changed import to include.
  • loader/FrameLoader.cpp: Ditto.
  • loader/MainResourceLoader.h: Ditto.
  • loader/FrameLoaderTypes.h: Added a header guard.
  • loader/NetscapePlugInStreamLoader.h: Changed import to include. Added #if PLATFORM(MAC) around Mac-specific details.
  • loader/SubresourceLoader.h: Ditto.
  • page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to m_loader from m_frameLoader.
  • CMakeLists.txt: Updated.
  • WebCoreSources.bkl: Updated.
11:53 AM Changeset in webkit [17441] by andersca
  • 2 edits in trunk/WebCore

2006-10-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Patch by Zack rusin to fix:
​http://bugs.webkit.org/show_bug.cgi?id=11429

Fix startup crash.

  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
11:38 AM Changeset in webkit [17440] by andersca
  • 4 edits in trunk/WebCore

2006-10-30 Zach Rusin <​zack@kde.org>

Reviewed and landed by Anders.

  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::FrameQtClientDefault):
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest): More build fixes.

2006-10-30 Simon Hausmann <​hausmann@kde.org>

Reviewed and landed by Anders.


  • fix Qt build
  • platform/qt/FrameQtClient.cpp: ResourceLoaderClient -> ResourceHandleClient
11:32 AM Changeset in webkit [17439] by darin
  • 2 edits in trunk/LayoutTests

Requested by Maciej.

  • fast/dom/xmlhttprequest-get-expected.txt: Generated a new result. Maciej says that the new behavior of returning empty string instead of undefined is correct and matches Firefox, so the new result is better than the old.
9:20 AM Changeset in webkit [17438] by darin
  • 25 edits
    3 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle
  • moved bodyBackgroundColor function from Frame to WebFrame in WebKit
  • page/PageState.h:
  • page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
  • bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a double for the date instead of an NSDate.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and saveDocumentToPageCache methods.
  • bridge/mac/WebCorePageState.h:
  • bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into an Objective-C wrapper for PageState.
  • loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of NSDate and WebCorePageState.
  • loader/FrameLoaderClient.h: Changed NSDate to double.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache here that used to be in invalidateCurrentItemPageCache on the WebKit side. (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date. (WebCore::FrameLoader::open): Moved one of the open functions that was part of commitProvisionalLoad inside the commitProvisionalLoad function, so that it can extract the parameters from the response. Changed the open function that takes a PageState to use the new C++ PageState. (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open function; tightened up logic, removing a few cases that could never happen, as well as the unused reload boolean.
  • ForwardingHeaders/kjs/property_map.h: Added.
  • WebCore.exp: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.

WebKit:

Reviewed by John Sullivan.

  • work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle
  • moved bodyBackgroundColor function here from Frame
  • History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]): Updated for change in WebCorePageState.
  • WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
  • WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was formerly in invalidatePageCache: on the bridge here. (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the NSDate here. (WebFrameLoaderClient::createPageCache): Restructured code to create the WebCorePageState object directly instead of calling saveDocumentToPageCache on the bridge.
  • WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work directly with the DOM and renderers rather than using a function on Frame.
9:18 AM Changeset in webkit [17437] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • kjs/SavedBuiltins.h: Added needed include.
  • wtf/OwnPtr.h: (WTF::OwnPtr::set): Fixed mistake in assertion.
8:27 AM Changeset in webkit [17436] by thatcher
  • 5 edits in trunk/WebKitTools

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=10468
[Drosera] The Console toolbar button should bring the console window to the front.

The console now gets focus when its activated but already open. Command + L also
now activates/focuses the console.

  • Drosera/English.lproj/MainMenu.nib/classes.nib:
  • Drosera/English.lproj/MainMenu.nib/info.nib:
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
  • Drosera/debugger.js:
3:12 AM Changeset in webkit [22442] by mjs
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): Changed prototype to match new version.

WebKitWin:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebFrame.cpp: (WebFrame::didReceiveResponse): Updated from receivedResponse.
  • WebFrame.h:
  • WebURLResponse.cpp: (WebURLResponse::WebURLResponse): Reimplemented to work in terms of WebCore::ResourceResponse (ditto for below). Uses BString to convert strings as needed. (WebURLResponse::~WebURLResponse): (WebURLResponse::createInstance): (WebURLResponse::expectedContentLength): (WebURLResponse::initWithURL): (WebURLResponse::MIMEType): (WebURLResponse::suggestedFilename): (WebURLResponse::textEncodingName): (WebURLResponse::URL): (WebURLResponse::suggestedFileExtension):
  • WebURLResponse.h:
3:08 AM Changeset in webkit [17435] by mjs
  • 25 edits
    5 adds in trunk

WebCore:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call


  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bridge/mac/WebCoreFrameBridge.h: Removed no longer needed expiresTimeForResponse: method.
  • dom/XMLTokenizer.cpp: (WebCore::openFunc): Updated to use ResourceResponse.
  • loader/FrameLoader.h: Update loadResourceSynchronously to use ResourceResponse.
  • loader/LoaderFunctions.h:
  • loader/icon/IconLoader.cpp: (IconLoader::didReceiveResponse): Updated from receivedResponse and made cross-platform.
  • loader/icon/IconLoader.h: updated for above change
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): reduced to just saving the PlatformResponse (ideally we'd phase out use of this). (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse logic.
  • loader/loader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously): Return results as ResourceResponse.
  • loader/mac/IconLoaderMac.mm: remove receivedResponse.
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): take ResourceResponse as argument.
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h: Remove calls for broken out response pieces.
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveResponse): New delegate method.
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove storage of response bits, we're not gonna return them seprately any more.
  • platform/network/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): Freshly implemented. Same for below. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::isMultipart): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Send didReceiveResponse client method.
  • platform/network/cf/ResourceResponseCFNet.h: Added.
  • platform/network/cf/ResourceResponseCFNet.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from CFURLResponseRef.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): Don't bother cleaning up fields we no longer have. (WebCore::ResourceHandle::receivedResponse): Send didReceiveResponse client method.
  • platform/network/mac/ResourceResponseMac.h: Added.
  • platform/network/mac/ResourceResponseMac.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from an NSURLResponse*.
  • rendering/HitTestResult.cpp:
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseText): Store http response info in the form of a ResourceResponse, change all methods to account for this. (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:

WebKit:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebCoreSupport/WebFrameBridge.mm: Removed no longer needed expiresTimeForResponse: method.

Oct 29, 2006:

5:31 PM Changeset in webkit [17434] by darin
  • 4 edits in trunk/WebCore
  • fix build
  • loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
  • loader/NetscapePlugInStreamLoader.h: Ditto.
  • loader/ResourceLoader.h: Ditto.
5:16 PM Changeset in webkit [17433] by darin
  • 8 edits
    1 move
    5 adds in trunk

WebCore:

  • one last name change -- WebFormState.h to FormState.h
  • added more empty placeholder platform-independent files for currently-Mac-specific loader classes
  • loader/FormState.cpp: Updated include.
  • loader/FrameLoader.cpp: Updated include.
  • loader/mac/FrameLoaderMac.mm: Updated include.
  • loader/WebFormState.h: Removed.
  • loader/FormState.h: Added.
  • loader/DocumentLoader.cpp: Added.
  • loader/MainResourceLoader.cpp: Added.
  • loader/NetscapePlugInStreamLoader.cpp: Added.
  • loader/ResourceLoader.cpp: Added.
  • loader/SubresourceLoader.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated for changes above.

WebKit:

  • update for the WebCore rename
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebFrame.mm:
5:01 PM Changeset in webkit [17432] by darin
  • 3 edits in trunk/WebKitTools
  • Scripts/do-file-rename: Renames done, ready for the next round.
  • Scripts/do-webcore-rename: Ditto.
5:00 PM Changeset in webkit [22441] by darin
  • 4 edits in branches/WindowsMerge/WebCore
  • update for the WebCore renames
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::bindingInstance):
4:57 PM Changeset in webkit [17431] by darin
  • 71 edits
    15 moves in trunk

WebCore:

  • did the do-webcore-rename renames, including a number of changes to the names of loader files (and WebResourceLoader -> ResourceLoader), jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(), and improvements to the names of decoder classes and their source files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)

WebKit:

  • update for the WebCore renames
4:43 PM Changeset in webkit [17430] by darin
  • 2 edits
    6 moves in trunk/WebCore

Rubber stamped by Adam (kinda).

  • add Mac suffixes and correct filenames inside loader/mac
  • WebCore.xcodeproj/project.pbxproj: Updated for changes below.
  • loader/mac/FrameLoader.mm: Removed.
  • loader/mac/WebDocumentLoader.mm: Removed.
  • loader/mac/WebLoader.mm: Removed.
  • loader/mac/WebMainResourceLoader.mm: Removed.
  • loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
  • loader/mac/WebSubresourceLoader.mm: Removed.
  • loader/mac/FrameLoaderMac.mm: Added.
  • loader/mac/DocumentLoaderMac.mm: Added.
  • loader/mac/ResourceLoaderMac.mm: Added.
  • loader/mac/MainResourceLoaderMac.mm: Added.
  • loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
  • loader/mac/SubresourceLoaderMac.mm: Removed.
4:37 PM Changeset in webkit [17429] by darin
  • 12 edits
    1 move
    1 add in trunk/WebCore

Reviewed by Adam.

  • moving towards use of FrameLoader cross-platform; get FrameLoader.h and FrameLoader.cpp mostly ready
  • WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and FormState.cpp. Removed WebFormState.mm.
  • loader/FrameLoader.h: Put in lots of #if statements to see if we can get this header compiling on non-Mac.
  • loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
  • loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
  • loader/FrameLoaderClient.h: Added some ifdefs.
  • loader/WebDocumentLoader.h: Ditto.
  • loader/WebLoader.h: Ditto.
  • loader/WebMainResourceLoader.h: Ditto.
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense): Rewrote to work without bridge, partly to remove the need for ObjC bridge type in the header, and also because we're tearing down the bridge.
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): Removed unused m_contentLength and m_bytesReceived. (WebCore::MainResourceLoader::didReceiveResponse): Ditto. (WebCore::MainResourceLoader::didReceiveData): Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
  • bridge/mac/WebCoreFrameBridge.mm: Ditto.
  • loader/mac/FormState.mm: Removed.
  • loader/FormState.cpp: Added.
3:38 PM Changeset in webkit [17428] by darin
  • 2 edits
    7 moves in trunk/WebCore

Rubber stamped by Adam.

  • moving towards use of FrameLoader cross-platform; move the headers for the Mac loader from loader/mac into loader, in preparation for making them useful on non-Mac
  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/FrameLoader.h: Removed.
  • loader/mac/WebDocumentLoader.h: Removed.
  • loader/mac/WebFormState.h: Removed.
  • loader/mac/WebLoader.h: Removed.
  • loader/mac/WebMainResourceLoader.h: Removed.
  • loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
  • loader/mac/WebSubresourceLoader.h: Removed.
  • loader/FrameLoader.h: Added.
  • loader/WebDocumentLoader.h: Added.
  • loader/WebFormState.h: Added.
  • loader/WebLoader.h: Added.
  • loader/WebMainResourceLoader.h: Added.
  • loader/WebNetscapePlugInStreamLoader.h: Added.
  • loader/WebSubresourceLoader.h: Added.
3:01 PM Changeset in webkit [17427] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Finish Darin's clean up of the use of APPLE in WebCore, begun in
r17405.

  • platform/DeprecatedString.h:
2:07 PM Changeset in webkit [17426] by bdakin
  • 35 edits in trunk/WebCore

Rubber stamped by Geoff.

This is a followup to my HitTestResult checkin. Most of the
HitTestResult local variables in the code were named i or info for
when the class was named NodeInfo. This patch renames all of these
local variables to result.

12:48 PM Changeset in webkit [17425] by aroben
  • 3 edits in trunk/WebCore

More semi-fixes.

  • page/Page.cpp: Forgot to wrap the actual definition of setDefersLoading() in PLATFORM(MAC).
  • platform/PlatformWheelEvent.h: Fix up preprocessor directives.
12:32 PM Changeset in webkit [17424] by aroben
  • 3 edits in trunk/WebCore

Build semi-fix.

Move all FrameLoader-related code in Page.{cpp,h} within #if
PLATFORM(MAC), since this class currently only exists on Mac.

  • page/Page.cpp:
  • page/Page.h:
11:15 AM Changeset in webkit [17423] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-file-rename: And again.
11:06 AM Changeset in webkit [17422] by ggaren
  • 3 edits in trunk/WebCore

build fix.


  • platform/PlatformString.h: (WebCore::String::operator NSString*):
11:03 AM Changeset in webkit [17421] by ggaren
  • 2 edits in trunk/WebCore

Rolled out accidental commit.


  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator NSString*):
10:58 AM Changeset in webkit [17420] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Geoff.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11444
REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]: attempt to insert nil value)
when submitting a form with an empty uninitialized field

  • fast/forms/submit-nil-value-field-assert-expected.txt: Added.
  • fast/forms/submit-nil-value-field-assert.html: Added.
10:54 AM Changeset in webkit [17419] by ggaren
  • 4 edits in trunk/WebCore

RS by Darin.

Rolled out change to map NULL Strings to nil NSStrings because it caused
even more AppKit crashes. Maybe we should remove the NSString * operator
entirely, since its use is not straight-forward, and require callers to
specify explicitly whether they tolerate NULL.


  • platform/AtomicString.h:
  • platform/PlatformString.h: (WebCore::String::operator NSString*):
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
10:28 AM Changeset in webkit [17418] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Tweaked plans for renaming again.
10:03 AM Changeset in webkit [17417] by darin
  • 1 edit in trunk/WebKit/ChangeLog

Added a bug number to change log.

9:44 AM Changeset in webkit [17416] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • fixed storage leak showing up on the buildbot
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create): Release the NSURLRequest after passing it to load. Also clean up logic a bit.
9:12 AM Changeset in webkit [17415] by darin
  • 9 edits
    1 move in trunk

WebCore:

Rubber stamped by Adam Roben.

  • renamed WebFrameLoaderClient to match the class name inside it
  • loader/mac/WebFrameLoaderClient.h: Removed.
  • loader/FrameLoaderClient.h: Moved it here.
  • WebCore.xcodeproj/project.pbxproj: Updated project.
  • bridge/mac/FrameMac.mm: Updated includes.
  • bridge/mac/WebCoreFrameBridge.mm: Ditto.
  • loader/mac/FrameLoader.mm: Ditto.
  • loader/mac/WebLoader.h: Ditto.

WebKit:

Rubber stamped by Adam Roben.

  • renamed WebCore's WebFrameLoaderClient to match the class name inside it
  • WebCoreSupport/WebFrameBridge.mm: Update include.
  • WebCoreSupport/WebFrameLoaderClient.h: Ditto.
8:50 AM Changeset in webkit [17414] by darin
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

  • fix crash visible on buildbot and also when running the test anchor-image-scrolled-x-y.html under libgmalloc
  • loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle now that the class is named ResourceHandle.
  • loader/mac/WebSubresourceLoader.mm: Renaming, plus: (WebCore::SubresourceLoader::didFinishLoading): Get the handle into a local RefPtr before calling finishJobAndHandle, since we might get cancelled inside that function, so we should not rely on m_handle to keep the ResourceHandle alive. (WebCore::SubresourceLoader::didFail): Ditto. (WebCore::SubresourceLoader::didCancel): Ditto.
4:21 AM Changeset in webkit [17413] by bdash
  • 5 edits in trunk/LayoutTests

2006-10-30 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

Fix fast/block/basic/014.html to pass when Microsoft Office fonts are present.

  • fast/block/basic/014-expected.checksum:
  • fast/block/basic/014-expected.png:
  • fast/block/basic/014-expected.txt:
  • fast/block/basic/014.html: Always use default sans-serif font rather than preferring Microsoft Office fonts.
3:15 AM Changeset in webkit [17412] by bdash
  • 2 edits in trunk/LayoutTests

2006-10-29 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Fix failure in editing/inserting/insert-3851164-fix if Gill Sans font is present.

  • editing/inserting/insert-3851164-fix.html: Specify sans-serif to match expected results generated without Gill Sans present.
2:00 AM Changeset in webkit [17411] by mjs
  • 2 edits in trunk/WebCore

Not reviewed.

  • build fix
  • platform/network/mac/ResourceHandleMac.mm:
1:50 AM Changeset in webkit [22440] by mjs
  • 12 edits
    2 deletes in branches/WindowsMerge

WebCoreWin:

Rubber stamped by Darin.

  • renamed ResourceLoader to ResourceHandle (and same for related classes)
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
  • platform/network/win/ResourceHandleWin.cpp: Added. (WebCore::): (WebCore::addToOutstandingJobs): (WebCore::lookupResourceHandle): (WebCore::ResourceHandleWndProc): (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::onRequestComplete): (WebCore::initializeOffScreenResourceHandleWindow): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::startHTTPRequest): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
  • platform/network/win/ResourceHandleWin.h: Added.
  • platform/network/win/ResourceLoaderWin.cpp: Removed.
  • platform/network/win/ResourceLoaderWin.h: Removed.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (IconLoader::receivedResponse):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::receivedAllData):
  • plugins/win/PluginStreamWin.h:

WebKitWin:

Rubber stamped by Darin.

  • renamed ResourceLoader to ResourceHandle (and same for related classes)
  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::didReceiveData): (WebFrame::didFinishLoading):
  • WebFrame.h:
  • WebURLResponse.cpp: (WebURLResponse::createInstance):
  • WebURLResponse.h:
  • WebView.cpp:
1:44 AM Changeset in webkit [17410] by mjs
  • 31 edits
    14 moves in trunk/WebCore

Rubber stamped by Darin.

  • renamed ResourceLoader to ResourceHandle (and same for related classes)
  • CMakeLists.txt:
  • Projects/gdk/webcore-gdk.bkl:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bridge/mac/FrameMac.mm:
  • bridge/win/FrameWin.cpp:
  • dom/XMLTokenizer.cpp:
  • loader/Cache.cpp:
  • loader/CachedResource.h:
  • loader/LoaderFunctions.h:
  • loader/icon/IconLoader.cpp: (IconLoader::startLoading): (IconLoader::didReceiveData): (IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
  • loader/loader.h:
  • loader/mac/IconLoaderMac.mm: (IconLoader::receivedResponse):
  • loader/mac/LoaderFunctionsMac.mm:
  • loader/mac/WebLoader.h:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveCharset):
  • platform/network/ResourceHandle.cpp: Added. (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::isErrorPage): (WebCore::ResourceHandle::error): (WebCore::ResourceHandle::setError): (WebCore::ResourceHandle::responseEncoding): (WebCore::ResourceHandle::responseHTTPHeadersAsString): (WebCore::ResourceHandle::kill): (WebCore::ResourceHandle::requestHeaders): (WebCore::ResourceHandle::url): (WebCore::ResourceHandle::postData): (WebCore::ResourceHandle::method): (WebCore::ResourceHandle::client):
  • platform/network/ResourceHandle.h: Added. (WebCore::ResourceHandle::getInternal):
  • platform/network/ResourceHandleClient.h: Added. (WebCore::ResourceHandleClient::~ResourceHandleClient): (WebCore::ResourceHandleClient::didReceiveData): (WebCore::ResourceHandleClient::didFinishLoading): (WebCore::ResourceHandleClient::receivedRedirect): (WebCore::ResourceHandleClient::receivedResponse): (WebCore::ResourceHandleClient::receivedAllData):
  • platform/network/ResourceHandleInternal.h: Added. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/ResourceLoader.cpp: Removed.
  • platform/network/ResourceLoader.h: Removed.
  • platform/network/ResourceLoaderClient.h: Removed.
  • platform/network/ResourceLoaderInternal.h: Removed.
  • platform/network/cf/ResourceHandleCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::didReceiveChallenge): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
  • platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
  • platform/network/gdk/ResourceHandleCurl.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
  • platform/network/gdk/ResourceHandleManager.cpp: Added. (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::get): (WebCore::ResourceHandleManager::useSimpleTransfer): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • platform/network/gdk/ResourceHandleManager.h: Added.
  • platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
  • platform/network/gdk/ResourceLoaderManager.cpp: Removed.
  • platform/network/gdk/ResourceLoaderManager.h: Removed.
  • platform/network/mac/ResourceHandleMac.mm: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::redirectedToURL): (WebCore::ResourceHandle::addData): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::reportError):
  • platform/network/mac/ResourceLoaderMac.mm: Removed.
  • platform/network/qt/ResourceHandleManager.cpp: Added. (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::self): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • platform/network/qt/ResourceHandleManager.h: Added.
  • platform/network/qt/ResourceHandleQt.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::extractCharsetFromHeaders):
  • platform/network/qt/ResourceLoaderManager.cpp: Removed.
  • platform/network/qt/ResourceLoaderManager.h: Removed.
  • platform/network/qt/ResourceLoaderQt.cpp: Removed.
  • platform/network/win/ResourceHandleWin.cpp: Added. (WebCore::): (WebCore::addToOutstandingJobs): (WebCore::lookupResourceHandle): (WebCore::ResourceHandleWndProc): (WebCore::initializeOffScreenResourceHandleWindow): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setHasReceivedResponse): (WebCore::ResourceHandle::hasReceivedResponse):
  • platform/network/win/ResourceHandleWin.h: Added.
  • platform/network/win/ResourceLoaderWin.cpp: Removed.
  • platform/network/win/ResourceLoaderWin.h: Removed.
  • platform/qt/FrameQt.cpp:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::receivedResponse): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/FrameQtClient.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ServeSynchronousRequest):
  • xml/XSLTProcessor.cpp:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
1:36 AM Changeset in webkit [17409] by darin
  • 5 edits in trunk

LayoutTests:

  • fast/events/js-keyboard-event-creation-expected.txt: Update test that is affected in a minor way by the change to DumpRenderTree.

WebKitTools:

Reviewed by Mitz.

  • DumpRenderTree/DumpRenderTree.m: (-[DumpRenderTreeWindow keyDown:]): Added. Does nothing, which prevents a beep.
  • Scripts/do-webcore-rename: Tweaked plans for renaming a bit.

Oct 29, 2006:

1:47 AM Changeset in webkit [17408] by darin
  • 21 edits
    2 deletes in trunk

WebCore:

Reviewed by Maciej.

  • eliminate use of NSArray to carry form data around
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/FormDataMac.h: Removed.
  • bridge/mac/FormDataMac.mm: Removed.
  • bridge/mac/FrameMac.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
  • loader/FormData.h: (WebCore::FormData::isEmpty):
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • loader/mac/WebFormDataStream.h:
  • loader/mac/WebFormDataStream.m: (WebCore::pairRetain): (WebCore::pairRelease): (WebCore::pairEqual): (WebCore::pairHash): (WebCore::closeCurrentStream): (WebCore::scheduleWithPair): (WebCore::advanceCurrentStream): (WebCore::openNextStream): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formOpen): (WebCore::formRead): (WebCore::formCanRead): (WebCore::formClose): (WebCore::formSchedule): (WebCore::formUnschedule): (WebCore::formEventCallback): (WebCore::setHTTPBody):
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
  • platform/network/mac/ResourceLoaderMac.mm:

WebKit:

Reviewed by Maciej.

  • eliminate use of NSArray to carry form data around (the code in this framework was actually using the NSArray to hold a single

NSData anyway, so I just went back to an NSData for now)

  • History/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): (-[WebHistoryItem formData]):
  • History/WebHistoryItemPrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm):
  • WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]):
1:36 AM Changeset in webkit [17407] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • create SubresourceLoader with a ResourceRequest, not broken out request bits
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
12:30 AM Changeset in webkit [17406] by mjs
  • 12 edits
    3 deletes in trunk/WebCore

Reviewed by Darin.

  • removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly

Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm:
  • loader/mac/LoaderFunctionsMac.mm:
  • loader/mac/WebLoader.h:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceLoader.h:
  • platform/network/ResourceLoaderInternal.h:
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::receivedResponse): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::redirectedToURL): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::finishJobAndHandle): (WebCore::ResourceLoader::reportError):
  • platform/network/mac/WebCoreResourceLoader.h: Removed.
  • platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
  • platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
Note: See TracTimeline for information about the timeline view.