Context Navigation

← Previous Period
Next Period →

Timeline

Nov 1, 2006:

7:59 PM Changeset in webkit [17534] by slewis

3 edits in trunk/WebKitTools

2006-11-01 Stephanie Lewis <Stephanie Lewis>

Reviewed by Kevin.

Fixed bug where additional arguments got fed to xcode and jsdriver.pl
Since testkjs is being built before the tests are run, we don't need
to build it with webkit.

Fixes bugs
http://bugs.webkit.org/show_bug.cgi?id=11462
http://bugs.webkit.org/show_bug.cgi?id=6168

Scripts/build-webkit:
Scripts/run-javascriptcore-tests:

7:56 PM Changeset in webkit [17533] by thatcher

2 edits in tags/WebCore-521.29.4/WebCore

Versioning

7:52 PM Changeset in webkit [17532] by justing

10 edits
16 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4062865>
Copy/paste of a select element fails to include the options

Updated to reflect fix:

editing/pasteboard/4641033-expected.checksum:
editing/pasteboard/4641033-expected.png:
editing/pasteboard/4641033-expected.txt:
editing/pasteboard/4641033.html:

Added:

editing/inserting/before-after-input-element-expected.checksum: Added.
editing/inserting/before-after-input-element-expected.png: Added.
editing/inserting/before-after-input-element-expected.txt: Added.
editing/inserting/before-after-input-element.html: Added.
editing/pasteboard/input-field-1-expected.checksum: Added.
editing/pasteboard/input-field-1-expected.png: Added.
editing/pasteboard/input-field-1-expected.txt: Added.
editing/pasteboard/input-field-1.html: Added.
editing/pasteboard/select-element-1-expected.checksum: Added.
editing/pasteboard/select-element-1-expected.png: Added.
editing/pasteboard/select-element-1-expected.txt: Added.
editing/pasteboard/select-element-1.html: Added.
editing/selection/select-element-paragraph-boundary-expected.checksum: Added.
editing/selection/select-element-paragraph-boundary-expected.png: Added.
editing/selection/select-element-paragraph-boundary-expected.txt: Added.
editing/selection/select-element-paragraph-boundary.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4062865>
Copy/paste of a select element fails to include the options

editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added paragraphBoundary.
editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added checks for input elements and textareas. Insertion operations would fail when performed just before/after one of these elements b/c the content would be put inside the element. (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non editable content, and made the code to stop at an root faster (don't check isDescendantOf on every iteration). (WebCore::enclosingNodeOfType): Ditto. (WebCore::enclosingList): Ditto. (WebCore::enclosingListChild): Ditto. Added a FIXME, this function seems inappropriately named.
editing/markup.cpp: (WebCore::startMarkup): Use the text node's value instead of its rendered content for text nodes inside select elements. One might also turn off annotation when createMarkup enters a select element, but createMarkup is iterative, not recursive, so doing so would be complicated. (WebCore::createMarkup): Add markup for unrendered nodes if they are descendants of a select element.
editing/visible_units.cpp: (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock. Fixes bug where various replaced elements can't be copied when they are the only thing selected. (WebCore::endOfParagraph): Ditto.

7:36 PM Changeset in webkit [17531] by thatcher

3 edits in tags/WebCore-521.29.4/WebCore

Merging change.

7:26 PM Changeset in webkit [17530] by thatcher

1 copy in tags/WebCore-521.29.4

new tag.

6:07 PM Changeset in webkit [22459] by adachan

6 edits in branches/WindowsMerge/WebKitWin

5:46 PM Changeset in webkit [22458] by oliver

3 edits
8 adds in branches/WindowsMerge/WebCore

2006-11-01 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Adding SVG_SUPPORT to Boomer.

WebCore.vcproj/WebCore.vcproj:
WebCore.vcproj/build-generated-files.sh:
kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Added. (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): (WebCore::KCanvasFilterQuartz::prepareFilter): (WebCore::KCanvasFilterQuartz::applyFilter): (WebCore::KCanvasFilterQuartz::imageForName): (WebCore::KCanvasFilterQuartz::setImageForName): (WebCore::KCanvasFilterQuartz::setOutputImage): (WebCore::KCanvasFilterQuartz::inputImage):
platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Added. (WebCore::SVGResourceMasker::applyMask):

5:41 PM Changeset in webkit [17529] by oliver

19 edits
2 moves in trunk/WebCore

2006-11-01 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Converting more or kcanvas/quartz from Obj-C to C++
Minor SVG updates
compatibility fixes

WebCore.xcodeproj/project.pbxproj:
kcanvas/device/KRenderingPaintServer.h:
kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added. (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
kcanvas/device/quartz/QuartzSupport.h:
ksvg2/css/SVGCSSStyleSelector.cpp:
ksvg2/misc/KCanvasRenderingStyle.h:
ksvg2/scripts/cssmakeprops:
ksvg2/scripts/cssmakevalues:
ksvg2/scripts/make_names.pl:
ksvg2/svg/SVGAnimateColorElement.cpp:
ksvg2/svg/SVGAnimateTransformElement.cpp:
ksvg2/svg/SVGAnimationElement.cpp:
ksvg2/svg/SVGMaskElement.cpp:
ksvg2/svg/SVGPatternElement.cpp:
ksvg2/svg/svgpathparser.cpp:
platform/Path.cpp:
platform/graphics/svg/SVGResourceImage.h:
rendering/RenderPath.cpp:
rendering/SVGRenderAsText.cpp:

5:02 PM Changeset in webkit [17528] by kmccullo

2 edits in trunk/LayoutTests

temporarily passing a test so that it does not interfere with others testing.

fast/js/date-big-setdate-expected.txt:

4:56 PM Changeset in webkit [17527] by beidson

2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher

Added accessor to get the source directory for use in client scripts

Scripts/webkitdirs.pm:

4:43 PM Changeset in webkit [17526] by adele

2 edits in trunk/WebCore

Reviewed by Adele.

Fix a regression from r17521: painting of and crash caused by tables with collapsed borders

rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to r17521, 'paintInfo' was the local variable. Now 'info' is the local variable and 'paintInfo' is the parameter, which we were accidently modifying.

3:34 PM Changeset in webkit [17525] by adele

4 edits in trunk/LayoutTests

Fixing typo. Changed repaintTest to runRepaintTest.

fast/repaint/overflow-outline-repaint-expected.checksum:
fast/repaint/overflow-outline-repaint-expected.png:
fast/repaint/overflow-outline-repaint.html:

3:28 PM Changeset in webkit [17524] by adele

4 edits
12 adds in trunk

LayoutTests:

Reviewed by Mitz.

Tests for http://bugs.webkit.org/show_bug.cgi?id=11277
REGRESSION: Incomplete repaint of overflow areas when deleting

fast/repaint/overflow-delete-line-expected.checksum: Added.
fast/repaint/overflow-delete-line-expected.png: Added.
fast/repaint/overflow-delete-line-expected.txt: Added.
fast/repaint/overflow-delete-line.html: Added.
fast/repaint/overflow-scroll-delete-expected.checksum: Added.
fast/repaint/overflow-scroll-delete-expected.png: Added.
fast/repaint/overflow-scroll-delete-expected.txt: Added.
fast/repaint/overflow-scroll-delete.html: Added.
fast/repaint/overflow-outline-repaint-expected.checksum: Added.
fast/repaint/overflow-outline-repaint-expected.png: Added.
fast/repaint/overflow-outline-repaint-expected.txt: Added.
fast/repaint/overflow-outline-repaint.html: Added.

WebCore:

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11277 REGRESSION: Incomplete repaint of overflow areas when deleting

Restrict the repaint rect for overflow blocks after the height has been fully computed.
Also, adjust the repaint rect coordinates for the scroll offset.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

3:26 PM Changeset in webkit [22457] by bdakin

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adam.

Build fix from Sam Weinig's check-in. i.p in the PaintInfo is now
i.context

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::paintMenuListButton):

3:22 PM Changeset in webkit [17523] by sullivan

2 edits in trunk/WebKit

Reviewed by Adam Roben

fixed <rdar://problem/4801351> Crash reloading PDF file in new Safari (or closing a window containing a PDF file)

WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): Retain the PDFSubview in the code path where we just obtain it by asking the PDFPreviewView for it. We were unconditionally releasing it in dealloc, but only retaining it in one of the two code paths.

2:42 PM Changeset in webkit [17522] by spadma

2 edits in S60/trunk/WebKit

2006-11-01 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin.
DESC: Cenrep UID define change in HttpDownloadObserver.cpp.
http://bugs.webkit.org/show_bug.cgi?id=11488

ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL):

1:49 PM Changeset in webkit [17521] by weinig

51 edits in trunk/WebCore

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
Rename the "p" member variable of the PaintInfo struct to "context"

Renames the 'p' and 'r' member variables of the PaintInfo struct to 'context' and 'rect' respectively.

Assorted surrounding cleanups.

rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
rendering/EllipsisBox.h:
rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations):
rendering/InlineFlowBox.h:
rendering/InlineRunBox.h:
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
rendering/InlineTextBox.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintCaret): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintEllipsisBoxes): (WebCore::RenderBlock::paintSelection): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillInlineSelectionGaps): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
rendering/RenderBox.cpp: (WebCore::RenderBox::paint): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations):
rendering/RenderBox.h:
rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject):
rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::continuationBefore): (WebCore::RenderFlow::addChildWithContinuation): (WebCore::RenderFlow::addChild): (WebCore::RenderFlow::attachLineBox): (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::dirtyLinesFromChangedChild): (WebCore::RenderFlow::dirtyLineBoxes): (WebCore::RenderFlow::createInlineBox): (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::getAbsoluteRepaintRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::caretRect): (WebCore::RenderFlow::addFocusRingRects): (WebCore::RenderFlow::paintOutline): (WebCore::RenderFlow::paintOutlineForLine):
rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
rendering/RenderObject.cpp: (WebCore::RenderObject::paint):
rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBoxDecorations): (WebCore::RenderObject::paintingRootForChildren): (WebCore::RenderObject::shouldPaintWithinRoot): (WebCore::RenderObject::printBoxDecorations):
rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::shouldPaint):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
rendering/RenderSVGContainer.h:
rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
rendering/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations):
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
rendering/RenderTableCell.h:
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
rendering/RenderTableRow.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
rendering/RenderTableSection.h: (WebCore::RenderTableSection::getBaseline): (WebCore::RenderTableSection::setNeedCellRecalc):
rendering/RenderText.h: (WebCore::RenderText::renderName): (WebCore::RenderText::paint): (WebCore::RenderText::element):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
rendering/RenderTheme.h: (WebCore::RenderTheme::RenderTheme): (WebCore::RenderTheme::~RenderTheme): (WebCore::RenderTheme::controlSupportsTints): (WebCore::RenderTheme::adjustRepaintRect): (WebCore::RenderTheme::themeChanged): (WebCore::RenderTheme::supportsHover): (WebCore::RenderTheme::paintCheckbox): (WebCore::RenderTheme::setCheckboxSize): (WebCore::RenderTheme::paintRadio): (WebCore::RenderTheme::setRadioSize): (WebCore::RenderTheme::paintButton): (WebCore::RenderTheme::setButtonSize): (WebCore::RenderTheme::paintTextField): (WebCore::RenderTheme::paintTextArea): (WebCore::RenderTheme::paintMenuList): (WebCore::RenderTheme::paintMenuListButton):
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton):
rendering/RenderView.cpp: (WebCore::RenderView::paint): (WebCore::RenderView::paintBoxDecorations):
rendering/RenderView.h:
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
rendering/RenderWidget.h: (WebCore::RenderWidget::isWidget):
rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint): (WebCore::RootInlineBox::fillLineSelectionGap):
rendering/RootInlineBox.h:
rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):

1:31 PM Changeset in webkit [22456] by andersca

4 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::createJavaAppletWidget): Ask the plugin database to create a java applet plugin.

platform/win/TemporaryLinkStubs.cpp: Remove FrameWin::createJavaAppletWidget.

plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Don't look for the Sun Java plugin anymore.

12:34 PM Changeset in webkit [17520] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by Brady.

Fixes many JavaScriptCore tests in other timezones. The root problem is that on mac localtime() returns historically accurate information for DST, but the JavaScript spec explicitly states to not take into account historical information but rather to interpolate from valid years.

kjs/DateMath.cpp: (KJS::equivalentYearForDST): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset):

12:07 PM Changeset in webkit [22455] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <acarlsson@apple.com>

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Build fix.

12:03 PM Changeset in webkit [22454] by andersca

4 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Convert plugin code over to using ResourceResponse.

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didFinishLoading):
plugins/win/PluginStreamWin.h:
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

11:43 AM Changeset in webkit [17519] by andersca

3 edits in trunk/WebCore

2006-11-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver, Brady.

platform/network/ResourceResponse.h: (WebCore::ResourceResponse::setLastModifiedDate): (WebCore::ResourceResponse::lastModifiedDate): Add getters and setters for last modified dadte.

platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Fetch the last modified date. Add correct offset to expired date.

11:25 AM Changeset in webkit [17518] by thatcher

2 edits in trunk/WebCore

Build fix for 64-bit.

8:35 AM Changeset in webkit [17517] by yongjzha

5 edits in S60/trunk/WebKit

2006-11-01 sareen <shyam.sareen@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: add an UI option to disable flash content
http://bugs.webkit.org/show_bug.cgi?id=11473

BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
BrowserView/inc/WebKitControl.h: (CWebKitControl::DisableFlashSetting):
BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::HandleDisableFlashSetting): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
Plugin/src/PluginSkin.cpp: (CPluginSkin::NewL):

3:47 AM Changeset in webkit [17516] by ddkilzer

2 edits in trunk/WebCore

2006-11-01 David Kilzer <ddkilzer@kilzer.net>

Reviewed by Mitz.

Added missing "break;" statement in switch statement from r17493.

Bug 11442: [CSS 3] support for cursor: all-scroll
http://bugs.webkit.org/show_bug.cgi?id=11442

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Oct 31, 2006:

11:53 PM Changeset in webkit [17515] by bdash

2 edits in trunk/WebCore

2006-10-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

fix image dragging

This is covered by editing/selection/drag-to-contenteditable-iframe.html

rendering/HitTestResult.cpp: (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for HTML IMG elements. (WebCore::HitTestResult::absoluteImageURL): Ditto.

11:15 PM Changeset in webkit [17514] by bdash

2 edits in trunk/WebKit

2006-10-31 Mark Rowe <bdash@webkit.org>

Reviewed by Maciej.

Fix null pointer dereference while running editing/pasteboard/drag-drop-modifies-page.html

Misc/WebElementDictionary.m: (-[WebElementDictionary _image]): Add null check.

10:13 PM Changeset in webkit [17513] by bdash

2 edits in trunk/WebKitSite

2006-10-31 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Update WebKit blog link to prevent pointless redirects.

nav.inc:

9:45 PM Changeset in webkit [17512] by bdash

3 edits in trunk/WebKitTools

2006-11-01 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Update references to webkit.opendarwin.org to webkit.org in Spinneret and WebKit.app.

Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
WebKitLauncher/WebKitNightlyEnabler.m: (cleanUpAfterOurselves):

7:22 PM Changeset in webkit [17511] by bdakin

6 edits in trunk

WebCore:

Reviewed by Maciej.

This adds the back-end of the remaining WebElementDictionary
functions into HitTestResult.

WebCore.exp:
rendering/HitTestResult.cpp: (WebCore::HitTestResult::title): (WebCore::displayString): This is nearly identical to the displayString() defined in DOMInternal.mm except that it returns a String instead of an NSString. The old code path used the DOMInternal method, so I made a new one here for the new code path. (WebCore::HitTestResult::altDisplayString): (WebCore::HitTestResult::image): (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::titleDisplayString): (WebCore::HitTestResult::textContent):
rendering/HitTestResult.h:

WebKit:

Reviewed by Maciej.

This creates local functions for the remaining WebElementDictionary
members that calls into HitTestResult instead of doing magical
things with the Objective-C DOM classes.

ChangeLog:
Misc/WebElementDictionary.m: (addLookupKey): The values of the dictionary are now just selectors. They used to be WebElementMethods which were WebElementTargetObjects associated with selectors, but none of that is needed any more. (+[WebElementDictionary initializeLookupTable]): All selectors are now local functions, no more WebElementTargetObjects. (-[WebElementDictionary objectForKey:]): No more target objects! (-[WebElementDictionary _domNode]): Call into HitTestResult member variable. (-[WebElementDictionary _altDisplayString]): Same. (-[WebElementDictionary _image]): Same. (-[WebElementDictionary _absoluteImageURL]): Same. (-[WebElementDictionary _title]): Same. (-[WebElementDictionary _absoluteLinkURL]): Same. (-[WebElementDictionary _targetWebFrame]): Same. (-[WebElementDictionary _titleDisplayString]): Same. (-[WebElementDictionary _textContent]): Same.

7:11 PM Changeset in webkit [17510] by bdash

3 edits in trunk/WebKitTools

2006-10-31 Mark Rowe <bdash@webkit.org>

Reviewed by Stephanie.

Limit build slaves to a single build to prevent concurrent builds on a single slave from significantly increasing build time.

BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Adjust slave distribution, and make use of a SlaveLock.
BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Remove unused Qt build factory.

6:59 PM Changeset in webkit [17509] by sullivan

2 edits in trunk/WebCore

bridge/mac/FrameMac.mm: (WebCore::FrameMac::markMisspellings): Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.

6:49 PM Changeset in webkit [17508] by sullivan

6 edits in trunk/WebCore

Reviewed by Maciej

fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions

The foundation of this was in my last checkin. This checkin is all about displaying
the correct string in the toolTip.

dom/DocumentMarker.h: New description field in this struct.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): When adding a grammar marker, supply the appropriate description. Also, added a comment about the remaining work to make grammar checking return sensible answers. (WebCore::FrameMac::markMisspellings): ditto (yes, still needs some refactoring to minimize duplicated code)

dom/Document.h:
dom/Document.cpp: (WebCore::Document::addMarker): Now takes an optional description string (WebCore::Document::markerContainingPoint): New function, returns a pointer to the (first) marker of the specified type whose rect contains the specified point, or 0 if none.

rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Replaced hardwired string placeholder implementation with code that uses markerContainingPoint and gets the description from the marker.

6:33 PM Changeset in webkit [22453] by mjs

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

merged changes for:

fixed "Stop and reload don't work on the WebView" http://bugs.webkit.org/show_bug.cgi?id=11285

Most of htis was already in this tree.

WebFrame.cpp: (WebFrame::stopLoading): Implement. Added FIXME.

6:14 PM Changeset in webkit [17507] by ggaren

3 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Beth.

Fixed http://bugs.webkit.org/show_bug.cgi?id=11477
REGRESSION: GMail crashes in KJS::FunctionImp::callerGetter

kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): Removed unnecessary braces. (KJS::FunctionImp::callerGetter): More logical NULL checking.

LayoutTests:

Added test for accessing the 'caller' property from inside an event
listener.

fast/events/caller-access-from-event-listener-expected.txt: Added.
fast/events/caller-access-from-event-listener.html: Added.

5:35 PM Changeset in webkit [17506] by ggaren

3 edits in trunk/WebCore

Reviewed by Maciej.

Fixed crash resulting from Darin's last patch to remove BrowserExtension.

loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::createWindow):
manual-tests/window-open-features-parsing.html: Updated for clarity.

4:56 PM Changeset in webkit [17505] by thatcher

1 edit in trunk/WebKit/WebView/WebView.mm

Build fix for Leopard.

4:33 PM Changeset in webkit [22452] by sfalken

2 edits in branches/WindowsMerge/WebCore

2006-10-31 Steve Falkenburg <sfalken@apple.com>

Yet more B&I build fixes
Another missing .h file from the vcproj

WebCore.vcproj/WebCore.vcproj:

3:56 PM Changeset in webkit [17504] by ggaren

20 edits
2 adds in trunk

LayoutTests:

Added layout test for copying password field.

editing/pasteboard/copy-in-password-field-expected.txt: Added.
editing/pasteboard/copy-in-password-field.html: Added.

WebCore:

Reviewed by Alice.

Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
to WebCore::Editor.

Layout tests pass.

Renamed "may*" to "can*" because "can" is more accurate (these functions
aren't just about permission) and it matches WebKit.

(WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a
password field. Now that WebCore fully implements canCopy(), it doesn't just
mean "the selection is not in a password field" anymore.
(-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code.
The fact that it's not called anymore may represent a security issue, but I
don't see how commented-out code will help reveal the issue, and the
bridge is going away, anyway.

editing/SelectionController.h: Changed selection() calls to references to m_sel, to match the rest of the file.

WebKit:

Reviewed by Alice.

Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
to WebCore::Editor.

WebCoreSupport/WebFrameBridge.mm:
WebView/WebHTMLView.m: (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canCopy]): (-[WebHTMLView _canCut]): (-[WebHTMLView _canDelete]): (-[WebHTMLView _canPaste]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _isSelectionInPasswordField]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray _expandSelectionToGranularity:]):

3:37 PM Changeset in webkit [17503] by justing

13 edits in trunk

LayoutTests:

Reviewed by harrison

Updated these tests to mention the bug that they demonstrate:

editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
editing/pasteboard/nested-blocks-with-text-area-expected.png:
editing/pasteboard/nested-blocks-with-text-area-expected.txt:
editing/pasteboard/nested-blocks-with-text-area.html:
editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
editing/pasteboard/nested-blocks-with-text-field-expected.png:
editing/pasteboard/nested-blocks-with-text-field-expected.txt:
editing/pasteboard/nested-blocks-with-text-field.html:

WebCore:

Reviewed by harrison

<rdar://problem/4711063>
Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test insertion and plain text string creation unless we need the string for a BeforeTextInserted event handler or for a plain text only region. (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved code here from ReplacementFragment's constructor. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a FIXME.
editing/ReplaceSelectionCommand.h:

3:10 PM Changeset in webkit [17502] by adachan

6 edits in trunk/WebCore

2006-10-31 Ada Chan <adachan@apple.com>

Reviewed by Adam

Correct forward declarations of the HitTestRequest struct.

3:03 PM Changeset in webkit [17501] by sullivan

11 edits in trunk

WebCore:

Reviewed by Beth and Adam

Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip;
next I'll make it use a string that's relevant for a specific grammar error.

WebCore.exp: export symbol for spellingToolTip function

rendering/HitTestResult.h:
rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): new function, returns the string to be used in a tool tip that describes the questionable grammar

rendering/InlineTextBox.h:
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): now takes a style and font, needed to compute the rect representing the range containing questionable grammar. Computes the rect and associates it with the marker. (WebCore::InlineTextBox::paintDocumentMarkers): Pass in the style and font now needed by paintSpellingOrGrammarMarker

WebKit:

Reviewed by Beth and Adam

Display a tooltip when hovering over marked bad grammar.

Misc/WebElementDictionary.m: (+[WebElementDictionary initializeLookupTable]): support spelling tool tip (-[WebElementDictionary _spellingToolTip]): new method, calls through to HitTestResult

WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Check for a spelling tool tip; if found, prefer it over the other possible tool tips. Check for empty strings instead of just nil strings being, since values from WebElementDictionary are empty strings.

WebView/WebViewPrivate.h: declare new string constant WebElementSpellingToolTipKey
WebView/WebView.mm: define new string constant WebElementSpellingToolTipKey

3:01 PM Changeset in webkit [17500] by adele

2 edits in trunk/WebCore

Removed commented out variable from last checkin.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

2:51 PM Changeset in webkit [17499] by beidson

2 edits in trunk/WebCore

Build fix

2:15 PM Changeset in webkit [22451] by sfalken

2 edits in branches/WindowsMerge/WebCore

2:10 PM Changeset in webkit [17498] by adele

10 edits
4 adds in trunk

LayoutTests:

Reviewed by Adam.

Tests for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements

fast/forms/listbox-onchange-expected.txt: Added.
fast/forms/listbox-onchange.html: Added.
fast/forms/listbox-selection-expected.txt: Added.
fast/forms/listbox-selection.html: Added.

WebCore:

Reviewed by Adam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements

Tests:

LayoutTests/fast/forms/listbox-selection.html
LayoutTests/fast/forms/listbox-onchange.html

html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress. Added 2 vectors to cache selection state. One is kept so that the previous selection state can be restored as the active selection grows and shrinks. And one for onChange, that is updated after onChange is fired. Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables. (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent. (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events. (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state. (WebCore::HTMLSelectElement::setExtent): Added. (WebCore::HTMLSelectElement::updateListBoxSelection): Added. (WebCore::HTMLSelectElement::listBoxOnChange): Added.

rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible. (WebCore::RenderListBox::listIndexAtOffset): Added. Replaces optionAtPoint, which is no longer used. (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent. (WebCore::RenderListBox::stopAutoscroll): Added. Tells the select element to fire onChange. This is needed because the autoscroll can end from a mouseUp outside of the list box, and the select element won't get a mouseUp event directly. But the frame will stop the autoscroll at that point, and now we can notify the select element from here. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method. (WebCore::RenderListBox::listIndexIsVisible): Added. (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.

page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, we don't try to use the pointer to that renderer to call stopAutoscroll. This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.

2:04 PM Changeset in webkit [17497] by zbujtas

2 edits in S60/trunk/WebCore

2006-10-31 sareen <shyam.sareen@nokia.com>

Reviewed by <zbujtas@gmail.com>.
DESC:
http://bugs.webkit.org/show_bug.cgi?id=11473

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQObjectWidget.cpp: (QObjectWidget::hasResized): (QObjectWidget::focusable):

1:55 PM Changeset in webkit [17496] by bdakin

1 edit in trunk/WebCore/ChangeLog

Fixing typo in ChangeLog. This is the last one, I swear.

1:53 PM Changeset in webkit [17495] by bdakin

1 edit
1 add in trunk/WebCore

Forgot to check this in a minute ago. Oops!! Thanks Mitz!

rendering/HitTestRequest.h: Added. (WebCore::HitTestRequest::HitTestRequest):

1:48 PM Changeset in webkit [17494] by bdakin

55 edits in trunk

WebCore:

Reviewed by Maciej.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult
should be split into HitTestRequest and HitTestResult

This patch creates a new struct called HitTestRequest that holds
the three boolean values (readonly, active, and mouseMove) that
were formerly a part of HitTestRequest. all hitTest() and
nodeAtPoint() functions now take a HitTestRequest in addition to
the HitTestResult.

WebKit:

Reviewed by Maciej.

Small tweaks to WebKit because of http://bugs.webkit.org/
show_bug.cgi?id=11461 HitTestResult should be split into
HitTestRequest and HitTestResult

WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): The HitTestResult initializer now just takes a point.

1:32 PM Changeset in webkit [22450] by sfalken

2 edits in branches/WindowsMerge/WebCore

2006-10-31 Steve Falkenburg <sfalken@apple.com>

Remove extra files I accidently added

WebCore.vcproj/WebCore.vcproj:

1:03 PM Changeset in webkit [17493] by thatcher

6 edits in trunk/WebCore

Reviewed by Maciej.

Bug 11442: [CSS 3] support for cursor: all-scroll
http://bugs.webkit.org/show_bug.cgi?id=11442

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
page/FrameView.cpp: (WebCore::selectCursor):
rendering/RenderStyle.h:

12:56 PM Changeset in webkit [17492] by oliver

8 edits
5 moves in trunk/WebCore

2006-10-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.

Converting Obj-C++ to C++ in kcanvas

WebCore.xcodeproj/project.pbxproj:
kcanvas/device/quartz/KCanvasFilterQuartz.h:
kcanvas/device/quartz/KCanvasFilterQuartz.mm:
kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
kcanvas/device/quartz/KRenderingDeviceQuartz.h:
kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
kcanvas/device/quartz/QuartzSupport.cpp: Added.
kcanvas/device/quartz/QuartzSupport.h:
kcanvas/device/quartz/QuartzSupport.mm: Removed.
platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.

12:52 PM Changeset in webkit [17491] by oliver

2 edits in trunk/JavaScriptCore

2006-10-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.

Adding definition for PLATFORM(CI)

wtf/Platform.h:

12:34 PM Changeset in webkit [17490] by justing

11 edits
1 add
1 delete in trunk

LayoutTests:

Reviewed by harrison

editing/execCommand/create-list-1.html: Removed.
editing/execCommand/create-list-with-hr-expected.checksum:
editing/execCommand/create-list-with-hr-expected.png:
editing/execCommand/create-list-with-hr-expected.txt:
editing/execCommand/remove-list-1-expected.checksum:
editing/execCommand/remove-list-1-expected.png:
editing/execCommand/remove-list-1-expected.txt:
fast/text/attributed-substring-from-range-001-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/4808375>
REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}

Completely back out r17276 because of performance issues.

editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::handleReplacedElement): (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::TextIterator::emitCharacter): (WebCore::TextIterator::range): (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): (WebCore::SimplifiedBackwardsTextIterator::emitNewline): (WebCore::SimplifiedBackwardsTextIterator::range): (WebCore::CharacterIterator::range): (WebCore::TextIterator::rangeFromLocationAndLength):
editing/TextIterator.h: (WebCore::TextIterator::atEnd): (WebCore::SimplifiedBackwardsTextIterator::atEnd):

12:01 PM Changeset in webkit [17489] by thatcher

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix. Generated headers need to be added to 'Copy Generated Headers' and not 'Copy Headers'.

11:34 AM Changeset in webkit [22449] by sfalken

4 edits in branches/WindowsMerge

Fixes for Boomer submission, bumped version number.

11:31 AM Changeset in webkit [17488] by darin

14 edits
3 adds in trunk

WebCore:

Reviewed by Brady.

got "action dictionary" code out of FrameLoader, replacing with a class called NavigationAction

loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::triggeringAction): Ditto. (WebCore::DocumentLoader::setTriggeringAction): Ditto.

loader/FrameLoader.h: Changed action parameters to NavigationAction.

loader/FrameLoaderClient.h: Changed action parameters to NavigationAction. Removed elementForEvent.
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::reload): Ditto. (WebCore::FrameLoader::checkNewWindowPolicy): Ditto. (WebCore::FrameLoader::checkNavigationPolicy): Ditto. (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto. (WebCore::FrameLoader::post): Ditto.

loader/NavigationAction.h: Added.
loader/NavigationAction.cpp: Added.
loader/mac/NavigationActionMac.mm: Added.

loader/mac/MainResourceLoaderMac.mm: Fixed copyright.

WebCore.xcodeproj/project.pbxproj: Updated for new files.
WebCore.exp: Updated.

WebKit:

Reviewed by Brady.

got "action dictionary" code out of FrameLoader, replacing with a class called NavigationAction

WebCoreSupport/WebFrameLoaderClient.h: Changed parameter types to NavigationAction. Made elementForEvent non-virtual. Added actionDictionary function.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Changed parameter type, and used actionDictionary to make the action dictionary. (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto. (WebFrameLoaderClient::actionDictionary): Added. Code that was originally in WebCore that creates the action dictionary (from a NavigationAction).

WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]): Use NavigationAction instead of a dictionary for the action parameters.

11:19 AM Changeset in webkit [17487] by sfalken

2 edits in trunk/WebCore

2006-10-31 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Build fix

platform/win/CookieJarWin.cpp: (WebCore::cookies):

11:03 AM Changeset in webkit [17486] by aroben

9 edits
2 moves
2 adds
1 delete in trunk/WebCore

Reviewed by Maciej. Landed by Adam.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463

Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
as dicussed with Dave. Also kill the outdated DESIGN document.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
kcanvas/DESIGN: Removed.
kcanvas/KCanvasFilters.cpp:
kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
kcanvas/KCanvasTreeDebug.h: Ditto.
kcanvas/device/KRenderingPaintServerGradient.cpp:
kcanvas/device/KRenderingPaintServerPattern.cpp:
kcanvas/device/KRenderingPaintServerSolid.cpp:
platform/graphics/svg/SVGResourceClipper.cpp:
rendering/RenderTreeAsText.cpp:
rendering/SVGRenderTreeAsText.cpp: Added.
rendering/SVGRenderTreeAsText.h: Added. (WebCore::operator<<):

10:43 AM Changeset in webkit [17485] by ap

2 edits in trunk/WebCore

2006-10-31 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
Includes some CRLF -> LF fixups.

platform/win/CookieJarWin.cpp: (WebCore::cookies):

10:39 AM Changeset in webkit [22448] by kmccullo

2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Added basic functionality for running javascript from the address bar. Currently no return results are evaluated so use alert messages to see the results.

WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

10:23 AM Changeset in webkit [22447] by aroben

11 edits in branches/WindowsMerge

WebCoreWin:

Build fixes.

WebCore.vcproj/WebCore.vcproj: Add new platform/graphics directory to our include path, and copy headers from there for WebKit's benefit.
bridge/win/FrameWin.cpp: Update accessors of FrameLoadRequest. (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
plugins/win/PluginViewWin.cpp: Ditto. (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost):
plugins/win/PluginViewWin.h: Correct forward declaration of FrameLoadRequest.

WebKitWin:

Build fixes.

WebEditorClient.cpp: Add stubs for new methods. (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::isGrammarCheckingEnabled): (WebEditorClient::spellCheckerDocumentTag):
WebEditorClient.h: Add declarations for new methods.
WebFrame.cpp: Fix #includes to use new platform/graphics directory.
WebView.cpp: Ditto.
WebKit.vcproj/WebKit.vcproj: Add platform/graphics to include path.

10:19 AM Changeset in webkit [17484] by aroben

3 edits in trunk/WebCore

Reviewed by Steve.

Fix some incorrect forward declarations.

loader/FrameLoader.h:
page/Frame.h:

10:16 AM Changeset in webkit [17483] by ap

6 edits
3 adds in trunk

2006-10-31 Vladimir Olexa <vladimir.olexa@gmail.com>

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=4166
Function object does not support caller property

Test: fast/js/caller-property.html

kjs/function.cpp: (KJS::FunctionImp::callerGetter): added (KJS::FunctionImp::getOwnPropertySlot): added if statement to handle callerGetter()
kjs/function.h: added callerGetter() declaration
kjs/identifier.h: added caller property macro
tests/mozilla/expected.html:

9:45 AM Changeset in webkit [17482] by mjs

3 edits in trunk/WebKit

Reviewed by Maciej.

fixed "Stop and reload don't work on the WebView" http://bugs.webkit.org/show_bug.cgi?id=11285

COM/WebFrame.cpp: (WebFrame::stopLoading): Implement.
COM/WebView.cpp: (WebView::stopLoading): ditto (WebView::reload): ditto

9:20 AM Changeset in webkit [17481] by ap

2 edits in trunk/WebKitQt

2006-10-31 Simon Hausmann <hausmann@kde.org>

Reviewed by Maciej.

QtLauncher/main.cpp: (main): Declare our frame as main frame to the Page object. Fixes crashes on various web sites

8:49 AM Changeset in webkit [17480] by darin

2 edits in trunk/WebKitTools

DumpRenderTree/DumpRenderTree.m: Instead of allocating a single local pasteboard, allocate any number of local pasteboards. (main): Allocate the dictionary of pasteboards. (+[DumpRenderTreePasteboard _pasteboardWithName:]): Allocate a pasteboard, given a name. (+[LocalPasteboard alloc]): Added, so we don't have to call NSAllocateObject explicitly elsewhere. (-[LocalPasteboard addTypes:owner:]): Added a check that the owner responds to the selector rather than calling unconditionally.

8:40 AM Changeset in webkit [17479] by darin

2 edits in trunk/WebCore

WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to try to fix the build on the buildbot.

8:16 AM Changeset in webkit [17478] by darin

2 edits in trunk/WebCore

bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds. (WebCore::FrameMac::markMisspellings): Ditto.

6:26 AM Changeset in webkit [17477] by sullivan

2 edits in trunk/WebCore

bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): build fix: needed #ifndef BUILDING_ON_TIGER in one more place

6:18 AM Changeset in webkit [17476] by sullivan

6 edits in trunk/WebCore

Reviewed by Adam Roben

fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked

This patch introduces much of the guts of grammar checking, though still not enough to actually
check grammar sensibly, due to:

<rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
context passed to grammar checker

platform/Logging.h:
platform/Logging.cpp: new log channel SpellingAndGrammar

bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): initialize new log channel

bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest in the event of a tie), and do further processing with that one (select range; create marker that causes range to be visibly marked with a funky underline; update spelling panel appropriately). (WebCore::FrameMac::markMisspellings): More or less the same types of changes as in advanceToNextMisspelling The loops are structured just differently enough to make sharing code between these two functions a little tricky, so I decided to save that for a later patch.