⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 2, 2006:

10:41 PM Changeset in webkit [17562] by ggaren
  • 418 edits in trunk

LayoutTests:

Reviewed by Justin Garcia.


Used a PERL script to add calls to opt into dumping of editing callbacks
in all editing tests that didn't do so already. This is required now that
dumping of editing callbacks is opt-in.


Updated editing.js so that any test that calls runEditingTest() opt into
dumping of editing callbacks.


Updated results in all non-editing tests to remove dumping of editing callbacks.


Updated results in all editing tests to reflect minor DOM changes due to new
<script> elements.


[ many tests and results modified ]

WebKitTools:

Reviewed by Justin Garcia.


Made dumping of editing callbacks opt-in, so that editing spew doesn't
cloud non-editing tests.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController shouldDumpEditingCallbacks]): (runTest):
  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
10:02 PM Changeset in webkit [17561] by ggaren
  • 2 edits in trunk/LayoutTests

Updated results because they were incorrect when checked in. (We never
passed this test.)


  • fast/js/regexp-unicode-handling-expected.txt:
9:07 PM Nice Bugzilla queries edited by anonymous
(diff)
9:05 PM WebKit plus SVG edited by trac
(diff)
9:03 PM WebKit plus SVG edited by trac
(diff)
9:02 PM WebKit plus SVG edited by trac
(diff)
8:54 PM WebKit Team edited by trac
(diff)
8:54 PM WebKit plus SVG edited by trac
(diff)
8:48 PM Nice Bugzilla queries edited by trac
(diff)
8:42 PM WebKit plus SVG edited by trac
(diff)
8:39 PM WebKit plus SVG edited by trac
(diff)
8:39 PM WebKit Team edited by trac
(diff)
8:39 PM Applications using WebKit edited by trac
(diff)
8:39 PM Known incompatibilities between open-source WebKit and Safari edited by trac
(diff)
8:35 PM WebKit plus SVG created by trac
8:35 PM WebKit Team created by trac
8:34 PM Known incompatibilities between open-source WebKit and Safari created by trac
8:34 PM Nice Bugzilla queries created by trac
8:34 PM Nightly Builds created by trac
8:34 PM Applications using WebKit created by trac
8:29 PM Changeset in webkit [17560] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=9581
REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.

  • fast/forms/textarea-no-scroll-on-blur-expected.txt: Added.
  • fast/forms/textarea-no-scroll-on-blur.html: Added.

WebCore:

Reviewed by Anders.

Test: fast/forms/textarea-no-scroll-on-blur.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent): On blur, only scroll back to the start for text fields.
7:37 PM Changeset in webkit [17559] by andersca
  • 2 edits in trunk/WebCore

Another build fix.


  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
7:33 PM Changeset in webkit [17558] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
7:27 PM Changeset in webkit [17557] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff, landed by Anders.


Fix dependency problems caused when running move-js-headers.sh


  • move-js-headers.sh: Use cp -p instead of just cp so that the modification time of the original files are used.
7:23 PM Changeset in webkit [17556] by andersca
  • 1 edit
    6 adds in trunk/LayoutTests

2006-11-02 W. Andy Carrel <​wac@google.com>

Reviewed by Maciej, landed by Anders.


Adding tests for Unicode RegExp behavior to match IE and Firefox.

  • fast/js/regexp-unicode-handling-expected.txt: Added.
  • fast/js/regexp-unicode-handling.html: Added.
  • fast/js/resources/regexp-unicode-handling.js: Added.

2006-11-02 Alexey Proskuryakov <​ap@nypop.com>

Reviewed by Maciej, landed by Anders.

Test for bugs 7253 and 7445, based on reductions made by Parag Shah and W. Andy Carrel.

  • fast/js/gmail-re-re-expected.txt: Added.
  • fast/js/gmail-re-re.html: Added.
  • fast/js/resources/gmail-re-re.js: Added.
7:17 PM Changeset in webkit [17555] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Tim H, landed by Anders.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
REGRESSION: Shadow of file upload button is clipped

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip height to keep from clipping in the shadow
7:16 PM Changeset in webkit [17554] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej, landed by Anders.

  • platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between content and window. ScrollViewQt already receives correct content coordinates from QScrollArea. (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):
7:14 PM Changeset in webkit [17553] by andersca
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Maciej, landed by Anders.

  • CMakeLists.txt: Make KDE support optional.

WebKitQt:

Reviewed by Maciej, landed by Anders.

  • QtLauncher/CMakeLists.txt: Make linkage against kde libraries optional
  • QtLauncher/main.cpp: Make it compile without KDE. (main):
7:11 PM Changeset in webkit [17552] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Maciej, landed by Anders

  • CMakeLists.txt: Make linkage against KDE libraries conditional
  • platform/network/qt/ResourceHandleManager.cpp: Added a simple Qt base resource handler that supports only requests to the local filesystem. Used when compiling without KDE support. ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h. (WebCore::QtJob::QtJob): (WebCore::QtJob::timerEvent): (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::self): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel): (WebCore::ResourceHandleManager::deliverJobData):
  • platform/network/qt/ResourceHandleManager.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
  • platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and input dialog functions when compiling without KDE support (WebCore::ServeSynchronousRequest):
7:09 PM Changeset in webkit [17551] by andersca
  • 3 edits in trunk/WebKitTools

2006-11-02 Alexey Proskuryakov <​ap@nypop.com>

Reviewed by Maciej, landed by Anders.

  • Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
  • Scripts/install-win-extras: Make setx.exe actually run.
7:06 PM Changeset in webkit [17550] by andersca
  • 2 edits in trunk/WebCore

2006-11-02 David Carson <​dacarson@gmail.com>

Reviewed by Geoff, landed by Anders.

Fix for: ​http://bugs.webkit.org/show_bug.cgi?id=11471
Initializing variable in constructor.

  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
5:30 PM Changeset in webkit [17549] by andersca
  • 2 edits in trunk/WebCore

2006-11-02 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::addHeadersFromHashMap): Don't set all headers at once since that clears any previous headers set.


(WebCore::ResourceHandle::start):

4:27 PM Changeset in webkit [17548] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebViewPrivate.h

Build fix.

4:12 PM Changeset in webkit [17547] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Brady.

Adding outdent to the WebView responder forwarding list.
Also add outdent to WebHTMLView.h and WebViewPrivate.h.

  • WebView/WebHTMLView.h:
  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm:
3:00 PM Changeset in webkit [22462] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-11-02 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

  • WebCore.vcproj/WebCore.vcproj: Use the forked CursorWin.cpp


  • platform/win/CursorWin.cpp: (WebCore::moveCursor): Implement this.


  • platform/win/TemporaryLinkStubs.cpp: Get rid of it here.
2:24 PM Changeset in webkit [22461] by lamadio
  • 1 add in branches/WindowsMerge/WebCore/platform/network/win/CookieJarWin.cpp

mirroring CookieJar - porting to CF in next change.

2:12 PM Changeset in webkit [17546] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2006-11-02 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11473

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL):
  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp: (CHttpLoaderAcceptHeader::ReadMimeTypesL):
2:08 PM Changeset in webkit [17545] by ggaren
  • 2 edits in trunk/LayoutTests

Updated results to fix failure seen when running layout tests. Justin
Garcia says the new results look more correct.


  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
1:47 PM Changeset in webkit [17544] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-10-31 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Yongjun.
DESC: Browser defaults font family to "Nokia Sans S60" which is not supported under variant 7 build. The system has to default to another font family. If the phone language is English, the system defaults the font family to "Series 60 Hindi" which contains fonts for Greek. If the phone language is set to Greek, the system default the font to "Series 60 ZDigi" which does not contains fonts for Greek. That is why the same variant 7 build supports Greek under English and Automatic Language settings while it does not under Greek language setting. My fix is setting the font family to "Series 60 Hindi" if the phone language is set to Geek language.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=11469

  • BrowserCore/Renderers/src/TextRendererFactory.cpp: (CTextRendererFactory::DeviceDefaultFontFamilies):


Merge from ccb revision 17537

1:37 PM Changeset in webkit [17543] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz and Geoff.

Test for <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)

  • fast/forms/textarea-scrollbar-expected.checksum: Added.
  • fast/forms/textarea-scrollbar-expected.png: Added.
  • fast/forms/textarea-scrollbar-expected.txt: Added.
  • fast/forms/textarea-scrollbar.html: Added.

WebCore:

Reviewed by Mitz and Geoff.

  • Fix for: <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105) <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing) <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages

Test: fast/forms/textarea-scrollbar.html

To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock. This should make them
a lot more stable. In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.

  • rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setStyle): (WebCore::RenderTextControl::createDivStyle): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::baselinePosition): (WebCore::RenderTextControl::nodeAtPoint): (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout. (WebCore::RenderTextControl::scrollWidth): (WebCore::RenderTextControl::scrollHeight): (WebCore::RenderTextControl::scrollLeft): (WebCore::RenderTextControl::scrollTop):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
1:36 PM Changeset in webkit [22460] by andersca
  • 1 edit
    1 add in branches/WindowsMerge/WebCore

2006-11-02 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Add forked copy of CursorWin.cpp


  • platform/win/CursorWin.cpp: Added.
10:50 AM Changeset in webkit [17542] by thatcher
  • 2 edits in tags/WebKit-521.29.2/WebKit

Versioning

10:48 AM Changeset in webkit [17541] by thatcher
  • 2 edits in tags/WebKit-521.29.2/WebKit

merging fix for <rdar://problem/4801351>

10:43 AM Changeset in webkit [17540] by thatcher
  • 1 copy in tags/WebKit-521.29.2

New tag.

10:12 AM Changeset in webkit [17539] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen

  • editing/Selection.cpp: (WebCore::Selection::showTreeForThis): this debugging method now displays start offset and end offset, at Darin's suggestion
9:44 AM Changeset in webkit [17538] by kmccullo
  • 3 edits in trunk/LayoutTests

Reviewed by Maciej.

  • Changed the test to take into account the JavaScript standard's interesting take on DST. According to the standard DST should not reflect historically accurate information but should rather interpolate from a comparable year. This test used to show historically accurate information but now reflects the results of interpolating.
  • fast/js/date-big-setdate-expected.txt:
  • fast/js/resources/date-big-setdate.js:
8:38 AM Changeset in webkit [17537] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-10-31 zhalu <​zhaosong.lu@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>
DESC: Browser defaults font family changes for Greek build


​http://bugzilla.opendarwin.org/show_bug.cgi?id=11469

  • BrowserCore/Renderers/src/TextRendererFactory.cpp: (CTextRendererFactory::DeviceDefaultFontFamilies):
8:13 AM Changeset in webkit [17536] by spadma
  • 3 edits in S60/branches/3.1m/WebCore

2006-11-01 w3liu <​wei.liu@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>
DESC: Thai text rendering fails when using HTTPS.
​http://bugs.webkit.org/show_bug.cgi?id=11486
WARNING: NO TEST CASES ADDED OR CHANGED

  • ChangeLog:
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (KWQTextDecoder::~KWQTextDecoder): (QTextCodec::~QTextCodec): (QTextCodec::makeDecoder): (QTextCodec::toUnicode): (KWQTextDecoder::toUnicode): (QTextCodec::PrepareForExit):
  • kwq/KWQTextCodec.h:


Merge from r17535 from main branch

8:04 AM Changeset in webkit [17535] by yongjzha
  • 3 edits in S60/trunk/WebCore

2006-11-01 w3liu <​wei.liu@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>
DESC: handle truncated text fragments as input string
​http://bugs.webkit.org/show_bug.cgi?id=11486
Thai text rendering fails when using HTTPS

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (QTextCodec::~QTextCodec): (QTextCodec::makeDecoder): (QTextCodec::toUnicode): (KWQTextDecoder::toUnicode):
  • kwq/KWQTextCodec.h:

Nov 1, 2006:

7:59 PM Changeset in webkit [17534] by slewis
  • 3 edits in trunk/WebKitTools

2006-11-01 Stephanie Lewis <Stephanie Lewis>

Reviewed by Kevin.


Fixed bug where additional arguments got fed to xcode and jsdriver.pl
Since testkjs is being built before the tests are run, we don't need
to build it with webkit.


Fixes bugs
​http://bugs.webkit.org/show_bug.cgi?id=11462
​http://bugs.webkit.org/show_bug.cgi?id=6168

  • Scripts/build-webkit:
  • Scripts/run-javascriptcore-tests:
7:56 PM Changeset in webkit [17533] by thatcher
  • 2 edits in tags/WebCore-521.29.4/WebCore

Versioning

7:52 PM Changeset in webkit [17532] by justing
  • 10 edits
    16 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4062865>
Copy/paste of a select element fails to include the options

Updated to reflect fix:

  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/4641033.html:


Added:

  • editing/inserting/before-after-input-element-expected.checksum: Added.
  • editing/inserting/before-after-input-element-expected.png: Added.
  • editing/inserting/before-after-input-element-expected.txt: Added.
  • editing/inserting/before-after-input-element.html: Added.
  • editing/pasteboard/input-field-1-expected.checksum: Added.
  • editing/pasteboard/input-field-1-expected.png: Added.
  • editing/pasteboard/input-field-1-expected.txt: Added.
  • editing/pasteboard/input-field-1.html: Added.
  • editing/pasteboard/select-element-1-expected.checksum: Added.
  • editing/pasteboard/select-element-1-expected.png: Added.
  • editing/pasteboard/select-element-1-expected.txt: Added.
  • editing/pasteboard/select-element-1.html: Added.
  • editing/selection/select-element-paragraph-boundary-expected.checksum: Added.
  • editing/selection/select-element-paragraph-boundary-expected.png: Added.
  • editing/selection/select-element-paragraph-boundary-expected.txt: Added.
  • editing/selection/select-element-paragraph-boundary.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4062865>
Copy/paste of a select element fails to include the options


  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added paragraphBoundary.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added checks for input elements and textareas. Insertion operations would fail when performed just before/after one of these elements b/c the content would be put inside the element. (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non editable content, and made the code to stop at an root faster (don't check isDescendantOf on every iteration). (WebCore::enclosingNodeOfType): Ditto. (WebCore::enclosingList): Ditto. (WebCore::enclosingListChild): Ditto. Added a FIXME, this function seems inappropriately named.
  • editing/markup.cpp: (WebCore::startMarkup): Use the text node's value instead of its rendered content for text nodes inside select elements. One might also turn off annotation when createMarkup enters a select element, but createMarkup is iterative, not recursive, so doing so would be complicated. (WebCore::createMarkup): Add markup for unrendered nodes if they are descendants of a select element.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock. Fixes bug where various replaced elements can't be copied when they are the only thing selected. (WebCore::endOfParagraph): Ditto.
7:36 PM Changeset in webkit [17531] by thatcher
  • 3 edits in tags/WebCore-521.29.4/WebCore

Merging change.

7:26 PM Changeset in webkit [17530] by thatcher
  • 1 copy in tags/WebCore-521.29.4

new tag.

6:07 PM Changeset in webkit [22459] by adachan
  • 6 edits in branches/WindowsMerge/WebKitWin
5:46 PM Changeset in webkit [22458] by oliver
  • 3 edits
    8 adds in branches/WindowsMerge/WebCore

2006-11-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Adding SVG_SUPPORT to Boomer.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/build-generated-files.sh:
  • kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Added. (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): (WebCore::KCanvasFilterQuartz::prepareFilter): (WebCore::KCanvasFilterQuartz::applyFilter): (WebCore::KCanvasFilterQuartz::imageForName): (WebCore::KCanvasFilterQuartz::setImageForName): (WebCore::KCanvasFilterQuartz::setOutputImage): (WebCore::KCanvasFilterQuartz::inputImage):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
5:41 PM Changeset in webkit [17529] by oliver
  • 19 edits
    2 moves in trunk/WebCore

2006-11-01 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Converting more or kcanvas/quartz from Obj-C to C++
Minor SVG updates
compatibility fixes

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added. (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
  • kcanvas/device/quartz/QuartzSupport.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/scripts/cssmakeprops:
  • ksvg2/scripts/cssmakevalues:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/SVGAnimateColorElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/svgpathparser.cpp:
  • platform/Path.cpp:
  • platform/graphics/svg/SVGResourceImage.h:
  • rendering/RenderPath.cpp:
  • rendering/SVGRenderAsText.cpp:
5:02 PM Changeset in webkit [17528] by kmccullo
  • 2 edits in trunk/LayoutTests
  • temporarily passing a test so that it does not interfere with others testing.
  • fast/js/date-big-setdate-expected.txt:
4:56 PM Changeset in webkit [17527] by beidson
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher

Added accessor to get the source directory for use in client scripts

  • Scripts/webkitdirs.pm:
4:43 PM Changeset in webkit [17526] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • Fix a regression from r17521: painting of and crash caused by tables with collapsed borders
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to r17521, 'paintInfo' was the local variable. Now 'info' is the local variable and 'paintInfo' is the parameter, which we were accidently modifying.
3:34 PM Changeset in webkit [17525] by adele
  • 4 edits in trunk/LayoutTests

Fixing typo. Changed repaintTest to runRepaintTest.

  • fast/repaint/overflow-outline-repaint-expected.checksum:
  • fast/repaint/overflow-outline-repaint-expected.png:
  • fast/repaint/overflow-outline-repaint.html:
3:28 PM Changeset in webkit [17524] by adele
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by Mitz.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11277
REGRESSION: Incomplete repaint of overflow areas when deleting

  • fast/repaint/overflow-delete-line-expected.checksum: Added.
  • fast/repaint/overflow-delete-line-expected.png: Added.
  • fast/repaint/overflow-delete-line-expected.txt: Added.
  • fast/repaint/overflow-delete-line.html: Added.
  • fast/repaint/overflow-scroll-delete-expected.checksum: Added.
  • fast/repaint/overflow-scroll-delete-expected.png: Added.
  • fast/repaint/overflow-scroll-delete-expected.txt: Added.
  • fast/repaint/overflow-scroll-delete.html: Added.
  • fast/repaint/overflow-outline-repaint-expected.checksum: Added.
  • fast/repaint/overflow-outline-repaint-expected.png: Added.
  • fast/repaint/overflow-outline-repaint-expected.txt: Added.
  • fast/repaint/overflow-outline-repaint.html: Added.

WebCore:

Reviewed by Mitz.

Restrict the repaint rect for overflow blocks after the height has been fully computed.
Also, adjust the repaint rect coordinates for the scroll offset.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
3:26 PM Changeset in webkit [22457] by bdakin
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adam.

Build fix from Sam Weinig's check-in. i.p in the PaintInfo is now
i.context

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::paintMenuListButton):
3:22 PM Changeset in webkit [17523] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adam Roben


  • fixed <rdar://problem/4801351> Crash reloading PDF file in new Safari (or closing a window containing a PDF file)
  • WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): Retain the PDFSubview in the code path where we just obtain it by asking the PDFPreviewView for it. We were unconditionally releasing it in dealloc, but only retaining it in one of the two code paths.
2:42 PM Changeset in webkit [17522] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-01 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin.
DESC: Cenrep UID define change in HttpDownloadObserver.cpp.
​http://bugs.webkit.org/show_bug.cgi?id=11488

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL):
1:49 PM Changeset in webkit [17521] by weinig
  • 51 edits in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11474
Rename the "p" member variable of the PaintInfo struct to "context"

  • Renames the 'p' and 'r' member variables of the PaintInfo struct to 'context' and 'rect' respectively.
  • Assorted surrounding cleanups.
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/InlineRunBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintCaret): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintEllipsisBoxes): (WebCore::RenderBlock::paintSelection): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillInlineSelectionGaps): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::continuationBefore): (WebCore::RenderFlow::addChildWithContinuation): (WebCore::RenderFlow::addChild): (WebCore::RenderFlow::attachLineBox): (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::dirtyLinesFromChangedChild): (WebCore::RenderFlow::dirtyLineBoxes): (WebCore::RenderFlow::createInlineBox): (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::getAbsoluteRepaintRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::caretRect): (WebCore::RenderFlow::addFocusRingRects): (WebCore::RenderFlow::paintOutline): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paint):
  • rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBoxDecorations): (WebCore::RenderObject::paintingRootForChildren): (WebCore::RenderObject::shouldPaintWithinRoot): (WebCore::RenderObject::printBoxDecorations):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::shouldPaint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • rendering/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::getBaseline): (WebCore::RenderTableSection::setNeedCellRecalc):
  • rendering/RenderText.h: (WebCore::RenderText::renderName): (WebCore::RenderText::paint): (WebCore::RenderText::element):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::RenderTheme): (WebCore::RenderTheme::~RenderTheme): (WebCore::RenderTheme::controlSupportsTints): (WebCore::RenderTheme::adjustRepaintRect): (WebCore::RenderTheme::themeChanged): (WebCore::RenderTheme::supportsHover): (WebCore::RenderTheme::paintCheckbox): (WebCore::RenderTheme::setCheckboxSize): (WebCore::RenderTheme::paintRadio): (WebCore::RenderTheme::setRadioSize): (WebCore::RenderTheme::paintButton): (WebCore::RenderTheme::setButtonSize): (WebCore::RenderTheme::paintTextField): (WebCore::RenderTheme::paintTextArea): (WebCore::RenderTheme::paintMenuList): (WebCore::RenderTheme::paintMenuListButton):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton):
  • rendering/RenderView.cpp: (WebCore::RenderView::paint): (WebCore::RenderView::paintBoxDecorations):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::isWidget):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint): (WebCore::RootInlineBox::fillLineSelectionGap):
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
1:31 PM Changeset in webkit [22456] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::createJavaAppletWidget): Ask the plugin database to create a java applet plugin.
  • platform/win/TemporaryLinkStubs.cpp: Remove FrameWin::createJavaAppletWidget.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Don't look for the Sun Java plugin anymore.
12:34 PM Changeset in webkit [17520] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady.

  • Fixes many JavaScriptCore tests in other timezones. The root problem is that on mac localtime() returns historically accurate information for DST, but the JavaScript spec explicitly states to not take into account historical information but rather to interpolate from valid years.
  • kjs/DateMath.cpp: (KJS::equivalentYearForDST): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset):
12:07 PM Changeset in webkit [22455] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <​acarlsson@apple.com>

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Build fix.
12:03 PM Changeset in webkit [22454] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Convert plugin code over to using ResourceResponse.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
11:43 AM Changeset in webkit [17519] by andersca
  • 3 edits in trunk/WebCore

2006-11-01 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver, Brady.

  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::setLastModifiedDate): (WebCore::ResourceResponse::lastModifiedDate): Add getters and setters for last modified dadte.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Fetch the last modified date. Add correct offset to expired date.
11:25 AM Changeset in webkit [17518] by thatcher
  • 2 edits in trunk/WebCore

Build fix for 64-bit.

8:35 AM Changeset in webkit [17517] by yongjzha
  • 5 edits in S60/trunk/WebKit

2006-11-01 sareen <​shyam.sareen@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: add an UI option to disable flash content
​http://bugs.webkit.org/show_bug.cgi?id=11473

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::DisableFlashSetting):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::HandleDisableFlashSetting): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::NewL):
3:47 AM Changeset in webkit [17516] by ddkilzer
  • 2 edits in trunk/WebCore

2006-11-01 David Kilzer <​ddkilzer@kilzer.net>

Reviewed by Mitz.

Added missing "break;" statement in switch statement from r17493.

Bug 11442: [CSS 3] support for cursor: all-scroll
​http://bugs.webkit.org/show_bug.cgi?id=11442

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Note: See TracTimeline for information about the timeline view.