⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 4, 2006:

10:16 PM Changeset in webkit [17602] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11521
Bug 11521: [Drosera] Breakpoint editor UI behaves incorrectly when multiple editors are open

  • Drosera/debugger.js: Use . instead of so that it doesn't root the search at the document.
10:14 PM Changeset in webkit [17601] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11513
Bug 11513: [Drosera] Function popup fails to appear when clicking supposedly valid areas.

  • Drosera/debugger.css: Stick a min-width on the menu to keep it from becoming smaller than the control.
10:12 PM Changeset in webkit [17600] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11512
Bug 11512: [Drosera] Scrolling via keyboard breaks after clicking in function popup.

  • Drosera/debugger.js: blur() the function popup when we're done with it.
5:24 PM Changeset in webkit [22469] by darin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Maciej.

  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Updated for change of const Event* to Event*. (WebCore::FrameWin::submitForm): Added Event* parameter.

WebKitWin:

  • WebView.cpp: (WebView::initWithFrame): Removed setMainFrame call and deref of Frame, now handled by Frame's constructor.
5:16 PM Changeset in webkit [17599] by darin
  • 1 edit in trunk/WebCore/ChangeLog

s

5:16 PM Changeset in webkit [17598] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ander.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel. Since the subresource owns the resource handle, there's no need to cancel. This arrangement is only temporary, anyway, since Maciej will soon change things so that the subresource loader uses the resource handle and the resource handle doesn't know anything about the subresource loader.
5:06 PM Changeset in webkit [17597] by darin
  • 84 edits
    1 delete in trunk

WebCore:

Reviewed by Maciej.

  • converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones

converted most uses of NSURL to KURL and NSEvent to DOM Event in
loader classes

moved download function out of FrameLoader.h to avoid reference to
NSURLConnection

added DOM Event parameters to various functions so that the handlers
can use the DOM Event instead of the global "current NSEvent";
includes Frame::submitForm, HTMLFormElement::prepareSubmit,
HTMLFormElement::submit, FrameLoader::load

moved the setMainFrame call that hands ownership to the Page
into one of the Frame constructors, and removed it from all
the clients

removed const from Event parameter to the urlSelected function
(we rarely use const with DOM elements)

removed some redundant includes and declarations from various
header files

removed NSURL parameter from userAgent function -- if we need it we
can add it back, but converting from NSURL to KURL and back is
inefficient enough that it's best to have it out for now (since it's
been unused for years) -- if we add it back, we can choose an
appropriate parameter type that's always inexpensive to pass

did some basic cleanup in the IconLoader class, including removing
an unnecessary loop that added icon data a byte at a time

renamed safeLoad to load, since it's no different from the other
FrameLoader load functions, safety-wise

fixed some code that was trying to distinguish null frame name from
empty string frame name -- both should be handled the same, but callers
were doing it by checking for empty and turning it into null (in a way
that was causing extra round trips between NSString and WebCore::String)

corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
and got rid of case-insensitive compares of methods

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent):
  • bridge/mac/FrameViewMac.mm:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm:
  • bridge/mac/WebCoreSettings.mm:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
  • bridge/win/FrameWin.h:
  • dom/MouseRelatedEvent.cpp:
  • dom/MouseRelatedEvent.h:
  • dom/UIEvent.cpp: (WebCore::UIEvent::~UIEvent):
  • dom/UIEvent.h:
  • dom/UIEventWithKeyState.h:
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/NavigationAction.h: (WebCore::NavigationAction::event):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::create): (WebCore::IconLoader::startLoading): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::URLForHistory):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/IconLoaderMac.mm: (WebCore::IconLoader::notifyIconChanged):
  • loader/mac/LoaderFunctionsMac.mm:
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/mac/NavigationActionMac.mm: (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
  • loader/mac/ResourceLoaderMac.mm:
  • loader/mac/SubresourceLoaderMac.mm:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::urlSelected): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::endIfNotLoading): (WebCore::Frame::hitTestResultAtPoint):
  • page/Frame.h:
  • page/FramePrivate.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/FrameGdk.h:
  • platform/mac/TextFieldMac.mm:
  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceResponseMac.h:
  • platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]):
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected):
  • platform/qt/FrameQt.h:
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::returnPressed):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp:

WebKit:

Reviewed by Maciej.

  • converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones

store the computed user agent string as a WebCore::String instead
of an NSString to avoid overhead converting it every time we get it

  • COM/WebFrame.cpp: (WebFrame::initWithName):
  • ChangeLog:
  • Misc/WebElementDictionary.m: (-[WebElementDictionary _image]): (-[WebElementDictionary _targetWebFrame]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent): (WebFrameLoaderClient::actionDictionary):
  • WebCoreSupport/WebPageBridge.mm: (WebCore::if):
  • WebView/WebDataSource.mm: (-[WebDataSource _URL]): (-[WebDataSource _URLForHistory]): (-[WebDataSource unreachableURL]):
  • WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]):
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): (-[WebPDFView _path]):
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]): (-[WebView _preferencesChangedNotification:]): (-[WebView _cachedResponseForURL:]): (-[WebView setApplicationNameForUserAgent:]): (-[WebView setCustomUserAgent:]): (-[WebView customUserAgent]): (-[WebView userAgentForURL:]): (-[WebView _computeUserAgent]): (-[WebView WebCore::]):
  • WebView/WebViewInternal.h:
5:02 PM Changeset in webkit [17596] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 Mark Rowe <​bdash@webkit.org>

Reviewed by Darin.

Fix use of uninitialized value in pattern match.

  • Scripts/webkitdirs.pm:
4:23 PM Changeset in webkit [22468] by mjs
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adele.

  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebCore.vcproj/WebCore.vcproj: Added new files
  • platform/win/TemporaryLinkStubs.cpp: Removed unneeded link stubs

WebKitWin:

Reviewed by Adele.


  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebFrame.cpp: (WebFrame::willSendRequest): Rearranged from former receivedRedirect.
  • WebFrame.h:
4:15 PM Changeset in webkit [17595] by mjs
  • 24 edits
    2 copies
    4 adds in trunk/WebCore

Reviewed by Adele.

  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted for CachedResource method renames. (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): Ditto.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): simplified based on ResourceResponse
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage): adapt for ResourceResponse
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): store a ResourceResponse; platform response is now called platformResponse and expiration date is removed. (WebCore::CachedResource::~CachedResource): ditto (WebCore::CachedResource::isExpired): ditto
  • loader/CachedResource.h: (WebCore::CachedResource::platformResponse): ditto (WebCore::CachedResource::setResponse): ditto (WebCore::CachedResource::canDelete): ditto
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): Adjusted for renames. (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse in the CachedResource.
  • loader/loader.h:
  • loader/mac/FormDataStream.h:
  • loader/mac/FormDataStream.m: (WebCore::getStreamFormDatas): Rearranged things so it's possible to get a FormData back out of a form data stream. (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::httpBodyFromStream): ditto
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad): s/response/platformResponse/
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): ditto (WebCore::CachedResource::setPlatformResponse): ditto
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): send redirect to client appropriately
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): new entry point for SubresourceLoader, dispatch to client.
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::allowHTTPCookies): implemented (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): initialize expiration date(!)
  • platform/network/cf/FormDataStreamCFNet.cpp: Added. (WebCore::getStreamFormDatas): Added this, ported from NSURL version. (WebCore::openNextStream): ditto (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::formCanRead): ditto (WebCore::formEventCallback): ditto (WebCore::setHTTPBody): ditto (WebCore::httpBodyFromStream): ditto
  • platform/network/cf/FormDataStreamCFNet.h: Added.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): implemented (WebCore::ResourceHandle::start): use new ResourceRequest stuff
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): do nothing for a null response
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
  • platform/network/mac/ResourceRequestMac.h: Added.
  • platform/network/mac/ResourceRequestMac.mm: Added. (WebCore::getResourceRequest): Added way to convert an NSURLRequest to a ResourceRequest. (WebCore::nsURLRequest): Opposite of the above.
  • platform/network/cf/ResourceRequestCFNet.h: Added.
  • platform/network/cf/ResourceRequestCFNet.cpp: Added. (WebCore::getResourceRequest): Added way to convert an CFURLRequest to a ResourceRequest. (WebCore::cfURLRequest): Opposite of the above.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect, adjusted.
  • xml/xmlhttprequest.h:
9:54 AM Changeset in webkit [17594] by darin
  • 2 edits in trunk/WebCore

Change suggested by Mitz.

  • bridge/mac/WebCorePageState.mm: (-[WebCorePageState dealloc]): Add null check. (-[WebCorePageState finalize]): Ditto.
9:53 AM Changeset in webkit [17593] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/webkitdirs.pm: Don't try to use the Xcode build setting if it's project-relative.
7:51 AM Changeset in webkit [17592] by ap
  • 16 edits
    3 adds in trunk

2006-11-04 Bertrand Guiheneuf <​guiheneuf@gmail.com>

Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).

​http://bugs.webkit.org/show_bug.cgi?id=11433
Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths Created platform/graphics and platform/network filters in hierarchy Moved GraphicsContext and GraphicsTypes to their respective filters Added EditorClient.h Added FrameLoader* files in loader/ Added HitTest* files in rendering/ Added Editor.* files in editing/ Added DeleteButton.* and DeleteButtonController.* in editing/
  • bridge/win/ChromeClientWin.h: Added. (WebCore::ChromeClientWin::~ChromeClientWin):
  • bridge/win/EditorClientWin.h: Added. (WebCore::EditorClientWin::~EditorClientWin):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
  • bridge/win/FrameWin.h: Added EditorClient parameter to constructor Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest() Removed openURL() and openURLRequest from class definition
  • bridge/win/PageWin.cpp:
  • platform/AffineTransform.h:
  • platform/cairo/AffineTransformCairo.cpp: Added. (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::m11): (WebCore::AffineTransform::m12): (WebCore::AffineTransform::m21): (WebCore::AffineTransform::m22): (WebCore::AffineTransform::dx): (WebCore::AffineTransform::dy): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::det): (WebCore::AffineTransform::invert): (WebCore::AffineTransform::operator cairo_matrix_t): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator*= ): (WebCore::AffineTransform::operator* ):
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::goBackOrForward): (WebCore::FrameWin::getHistoryLength): (WebCore::FrameWin::historyURL): (WebCore::ServeSynchronousRequest): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::Path::transform): (WebCore::PopupMenu::updateFromElement): (WebCore::ResourceLoader::loadsBlocked): (WebCore::systemBeep):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::didReceiveData): (WebFrame::receivedAllData): Use resource handles now. Do not start doc loader by hand anymore. Handle didReceiveData() callback instead of receivedData() which is deprecated in implementation of ResourceHandleClient
  • COM/WebFrame.h:
  • COM/WebView.cpp: Applied ResourceLoader --> ResourceHandle renaming
  • WebKit.vcproj/WebKit.rc: Got rid of MFC dependencies (build fix for VCExpress).
  • WebKit.vcproj/WebKit.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths

Nov 3, 2006:

11:53 PM Changeset in webkit [17591] by ap
  • 5 edits
    2 adds
    2 deletes in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11448
&lang; and &rang; entities are mapped to the incorrect Unicode codepoint

WebCore:

  • html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.

LayoutTests:

  • fast/parser/entities-in-xhtml-expected.checksum: Removed.
  • fast/parser/entities-in-xhtml-expected.png: Removed. Converted to plain text, the large table in the test didn't nearly fit anyway.
  • fast/parser/entities-in-xhtml-expected.txt:
  • fast/parser/entities-in-xhtml.xhtml: Made the test self-consistent again by using actual numeric values for &lang; and &rang;.
  • fast/parser/entities-in-html-expected.txt: Added.
  • fast/parser/entities-in-html.html: Added. An HTML copy of the same test.
10:14 PM Changeset in webkit [17590] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-03 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11510
Bug 11510: [Drosera] Doubleclicking the attach table should attach to the clicked item.

  • Drosera/DebuggerApplication.m: (-[DebuggerApplication showAttachPanel:]): Set the doubleAction for the table view
10:03 PM Changeset in webkit [22467] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-03 Steve Falkenburg <​sfalken@apple.com>

Fix build

  • config.h: Touched to cause re-build w/ SVG_SUPPORT enabled
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): Added
9:33 PM Changeset in webkit [17589] by bdash
  • 3 edits in trunk/WebCore

2006-11-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Oliver.

Update Windows and Qt project files for file removals in r17585.

  • CMakeLists.txt:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
9:10 PM Changeset in webkit [17588] by bdash
  • 2 edits in trunk/WebCore

2006-11-03 Zack Rusin <​zack@kde.org>

Reviewed by Maciej.

The patch fixes text field drawing on the Qt platform.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintTextField): Use the style to correctly render the text field
8:56 PM Applications using WebKit edited by bdash@webkit.org
Cleanup of formatting (diff)
8:39 PM WikiStart edited by bdash@webkit.org
A more useful start page, copied from the wiki:WebKit page (diff)
8:38 PM WebKit plus SVG edited by bdash@webkit.org
Remove the majority of the page content as it is out of date (diff)
8:20 PM Changeset in webkit [17587] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-11-03 Steve Falkenburg <​sfalken@apple.com>

Fix build

  • kjs/JSImmediate.h:
4:41 PM Changeset in webkit [17586] by oliver
  • 2 edits in trunk/WebCore

2006-11-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Tim.

Correct incorrect call to SetCursor

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
4:37 PM Changeset in webkit [22466] by adele
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Removed DeprecatedRenderSelect and ListBox classes.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp:
4:35 PM Changeset in webkit [17585] by adele
  • 8 edits
    4 deletes in trunk/WebCore

Reviewed by Oliver.

Removed DeprecatedRenderSelect and ListBox classes.

  • WebCore.xcodeproj/project.pbxproj:
  • css/html4.css:
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): (WebCore::HTMLSelectElement::updateListBoxSelection):
  • html/HTMLSelectElement.h:
  • platform/ListBox.h: Removed.
  • platform/mac/FontCacheMac.mm:
  • platform/mac/ListBoxMac.mm: Removed.
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/DeprecatedRenderSelect.cpp: Removed.
  • rendering/DeprecatedRenderSelect.h: Removed.
4:20 PM Changeset in webkit [17584] by mjs
  • 1 edit
    2 deletes in trunk/WebCore

Not reviewed, fix for accidental commit.

  • rolled back more of the accidentall commit that I forgot.
  • platform/network/mac/ResourceRequestMac.h: Removed.
  • platform/network/mac/ResourceRequestMac.mm: Removed.
4:09 PM Changeset in webkit [17583] by thatcher
  • 4 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=9596
Bug 9596: [Drosera] add a function popup to the source pane

  • Drosera/debugger.css: Added styles for function popup
  • Drosera/debugger.html: Added function popup button and select
  • Drosera/debugger.js: Added function popup functionality
2:28 PM Changeset in webkit [17582] by mjs
  • 22 edits in trunk/WebCore

Not reviewed, fix for accidental commit.

  • roll back some network changes accidentally committed with a previous patch.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::setExpireDate): (WebCore::CachedResource::isExpired):
  • loader/CachedResource.h: (WebCore::CachedResource::response):
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceivedResponse):
  • loader/loader.h:
  • loader/mac/FormDataStream.h:
  • loader/mac/FormDataStream.m: (WebCore::formCreate): (WebCore::formFinalize):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): (WebCore::CachedResource::setResponse):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::receivedRedirect):
  • platform/network/ResourceRequest.h:
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::redirectedToURL):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedRedirect):
  • xml/xmlhttprequest.h:
2:20 PM Changeset in webkit [22465] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-03 Anders Carlsson <​acarlsson@apple.com>

Remove SVGRenderAsText files from the project.


  • WebCore.vcproj/WebCore.vcproj:
2:15 PM Changeset in webkit [17581] by andersca
  • 1 edit
    2 deletes in trunk/WebCore

2006-11-03 Anders Carlsson <​acarlsson@apple.com>

Rubber-stamped by Oliver.

Remove these, they have been merged with SVGRenderTreeAsText.


  • rendering/SVGRenderAsText.cpp: Removed.
  • rendering/SVGRenderAsText.h: Removed.
2:12 PM Changeset in webkit [17580] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11504
Fix warnings on non 32 bit platforms

  • kjs/JSImmediate.h: (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits): Rewrite in a way that moves runtime checks to compile-time.

(KJS::):
(KJS::JSImmediate::fromDouble):
(KJS::JSImmediate::toDouble):

1:55 PM Changeset in webkit [22464] by andersca
  • 4 edits in branches/WindowsMerge

WebCoreWin:

2006-11-03 Anders Carlsson <​acarlsson@apple.com>

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setPlatformResponse):

WebKitWin:

2006-11-03 Anders Carlsson <​acarlsson@apple.com>

Build fix.


  • WebChromeClient.cpp:


1:53 PM Changeset in webkit [17579] by andersca
  • 2 edits in trunk/WebCore

2006-11-03 Anders Carlsson <​acarlsson@apple.com>

Build fix.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
1:05 PM Changeset in webkit [17578] by ggaren
  • 1 edit
    2 adds in trunk/WebKit

Forgot to add these two files. Oops.

  • WebCoreSupport/WebChromeClient.h: Added.
  • WebCoreSupport/WebChromeClient.mm: Added.
12:59 PM Changeset in webkit [22463] by ggaren
  • 7 edits
    5 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin, Beth.

Updated to use ChromeClient.


  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/PageWin.cpp:
  • loader/win/ResourceLoaderWin.cpp: Added. (WebCore::ResourceLoader::loadsBlocked):
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

Reviewed by Darin, Beth.

Updated to use ChromeClient.


  • WebChromeClient.cpp: Added. (WebChromeClient::create): (WebChromeClient::WebChromeClient): (WebChromeClient::canRunModal): (WebChromeClient::runModal):
  • WebChromeClient.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::initWithFrame):
12:56 PM Changeset in webkit [17577] by ggaren
  • 15 edits
    3 adds in trunk

WebCore:

Reviewed by Darin, Beth.


First cut at factoring Page's UIDelegate-related functions into Chrome
and ChromeClient.

Layout tests pass.


  • bridge/mac/PageMac.mm: Removed platform-specific constructor, added setBridge method to replace it. (WebCore::Page::setBridge):
  • bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact that WebCorePageBridge.h doesn't need to be included by ObjC-only files, and, now that it uses PassRefPtr, can't be.


  • page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
  • page/Page.h: (WebCore::Page::dragCaretController): Made this function non-const so that m_dragCaretController doesn't have to be mutable.

WebKit:

Reviewed by Darin, Beth.

First cut at factoring Page's UIDelegate-related functions into Chrome
and ChromeClient.

Layout tests pass.


  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebPageBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:
11:02 AM Changeset in webkit [17576] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-01 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Use the EscapeUtils::EscapeDecodeL to remove escaped characters in the path.
​http://bugs.webkit.org/show_bug.cgi?id=11348


  • ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::ParseFileNameLC):
10:58 AM Changeset in webkit [17575] by ap
  • 1 edit
    1 add in trunk/WebKitTools

2006-11-03 Michael Emmel <​mike.emmel@gmail.com>

Reviewed by Maciej.


​http://bugs.webkit.org/show_bug.cgi?id=9671

  • Scripts/wkstyle: Adds astyle sed script formats according to most of the style guidelines.
10:36 AM Changeset in webkit [17574] by ap
  • 19 edits
    5 adds in trunk

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=7323
REGRESSION (10.4.4): ondrag* events don't fire on page in a frame

WebCore:

  • bridge/mac/FrameMac.h: Moved drag source information to a static variable in FrameMac.mm. There can be only one drag active at any moment, and having this information here was making sharing this information between subframes hard.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo. (WebCore::FrameMac::freeClipboard): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::handleMouseReleaseEvent): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::dragSourceMovedTo): (WebCore::FrameMac::dragSourceEndedAt): (WebCore::FrameMac::dispatchDragSrcEvent): Access drag source info via sharedDragInfo - this fixes drag source even dispatching. Also removed some old code that was forwarding mouse events to subviews to make HTML editing work in subframes.
  • page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::cancelDragAndDrop): (WebCore::FrameView::performDragAndDrop): Forward events to subframes for dispatching - this fixes drag target events.

WebKitTools:

When dragging, do not send EventSendingController's events immediately. Dragging
is supposed to be modal, so we need to perform it from within the delegate, without
returning to JS to make the next mouse movement.

When the mouse is down, mouse events are now recorded, and executed when mouseUp is sent.

  • DumpRenderTree/EventSendingController.h:
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (+[EventSendingController saveEvent:]): (+[EventSendingController replaySavedEvents]):
  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):

LayoutTests:

  • fast/events/drag-in-frames-expected.txt: Added.
  • fast/events/drag-in-frames.html: Added.
  • fast/events/resources/drag-in-frames-console.html: Added.
  • fast/events/resources/drag-in-frames-left.html: Added.
  • fast/events/resources/drag-in-frames-right.html: Added.
  • editing/selection/expanding-selections.html:
  • editing/selection/expanding-selections2.html:
  • fast/dynamic/layer-hit-test-crash.html:
  • fast/events/event-view-toString.html:
  • fast/events/resources/drag-outside-window-frame.html:
  • svg/custom/hover-default-fill.svg: Added missing calls to mouseUp().
  • svg/custom/stroke-width-click-expected.txt:
  • svg/custom/stroke-width-click.svg: Don't attempt to click outside the page, this was confusing DRT.
  • editing/selection/select-from-textfield-outwards-expected.txt:
  • editing/selection/select-from-textfield-outwards.html: Removed alerts between dragging steps - they are now useless, as the dragging events are stored and executed at once.
8:52 AM Changeset in webkit [17573] by staikos
  • 2 edits in trunk/WebCore

2006-11-03 Zack Rusin <​zack@kde.org>

Reviewed by Tim, landed by George.

Fixing compile.

  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
8:51 AM Changeset in webkit [17572] by ggaren
  • 12 edits in trunk/LayoutTests

Missed a few tests in my last check-in, and checked in old results for
others. Oops.


  • editing/inserting/before-after-input-element-expected.txt:
  • editing/inserting/before-after-input-element.html:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/input-field-1-expected.txt:
  • editing/pasteboard/input-field-1.html:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/pasteboard/select-element-1.html:
  • editing/selection/select-element-paragraph-boundary-expected.txt:
  • editing/selection/select-element-paragraph-boundary.html:
  • fast/forms/textarea-no-scroll-on-blur-expected.txt:
  • fast/forms/textarea-scrollbar-expected.txt:
8:20 AM Changeset in webkit [17571] by staikos
  • 3 edits
    1 add in trunk/WebCore

2006-11-01 Zack Rusin <​zack@kde.org>

Reviewed by Maciej, landed by George.

Moving the word/sentence seperators into a file of their own
and implementing findWordBoundary.

  • CMakeLists.txt:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/qt/TextBoundaries.cpp: Added. (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
7:34 AM Changeset in webkit [17570] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-02 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Gif image was not displayed on the page when it in body of multipart/mixed msg with wml file.
​http://bugs.webkit.org/show_bug.cgi?id=11496

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::ResponseL):


Merge from ccb r17569

7:29 AM Changeset in webkit [17569] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-02 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Gif image was not displayed on the page when it in body of multipart/mixed msg with wml file.
​http://bugs.webkit.org/show_bug.cgi?id=11496

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::ResponseL):
7:24 AM Changeset in webkit [17568] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-02 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: TSW bug# VKRR-6PH9VQ : ResolveLink function is called with wrong parameters.
Set the current url on UrlRequest when user clicks on a link.
​http://bugs.webkit.org/show_bug.cgi?id=11499

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
2:48 AM Changeset in webkit [17567] by staikos
  • 7 edits in trunk

2006-11-03 Zack Rusin <​zack@kde.org>

Reviewed by Maciej, landed by George.

Compile on both KDE and Qt platforms

  • CMakeLists.txt: add zlib explicitly
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::self): (WebCore::QtJob::QtJob): (WebCore::QtJob::timerEvent): Integrate both implementations

so that moc can parse it

(WebCore::ResourceHandleManager::deliverJobData):
(WebCore::ResourceHandleManager::remove):

  • platform/network/qt/ResourceHandleManager.h:
2:01 AM Changeset in webkit [17566] by staikos
  • 2 edits in trunk/JavaScriptCore

2006-11-02 George Staikos <​staikos@kde.org>

Reviewed by Maciej.

  • collector.cpp: Remove a deprecated pthreads call.
1:40 AM Changeset in webkit [17565] by mjs
  • 2 edits in trunk/WebCore

No review, suggested by Mitz.

  • fix a #if to be #ifdef
  • platform/graphics/svg/cg/SVGResourceImageCg.cpp:
1:33 AM Changeset in webkit [17564] by mjs
  • 3 edits in trunk/WebCore

Reviewed and landed by Maciej.


Compile on the Qt platform.

  • ksvg2/misc/KCanvasRenderingStyle.h:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
1:28 AM Changeset in webkit [17563] by mjs
  • 27 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt. Landed by Maciej.

Adding setPlatformPen/setPlatformFont/setPlatformFillColor
to graphics context to be able to set consistant state
on the platform specific painter without having to change
fill/stroke/font on every operation. This fixes color/stroke/fill
and font handling in the Qt port.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformFont):
  • platform/graphics/GraphicsContext.h:
  • platform/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::toQPenStyle): (WebCore::penToQPen): (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor):
  • platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt): (WebCore::ScrollViewCanvasQt::paintEvent): (WebCore::ScrollViewCanvasQt::handleKeyEvent):
  • platform/qt/ScrollViewCanvasQt.h:
Note: See TracTimeline for information about the timeline view.