⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 5, 2006:

11:03 PM Changeset in webkit [22473] by bdakin
  • 8 edits
    2 adds in branches/WindowsMerge

WebKit:

Reviewed by Steve and Anders. And sort of Maciej.

Here is a basic implementation of elementAtPoint for Boomer.

  • Interfaces/IWebView.idl: The definitions of the WebElementPropertyBag keys.
  • MarshallingHelpers.cpp: (MarshallingHelpers::intRectToSafeArray): New safe array creation function that creates a safe array out of an IntRect.
  • MarshallingHelpers.h:
  • WebElementPropertyBag.cpp: Added. This is the equivalent of WebElementDictionary on the Mac. (WebElementPropertyBag::WebElementPropertyBag): (WebElementPropertyBag::~WebElementPropertyBag): (WebElementPropertyBag::QueryInterface): (WebElementPropertyBag::AddRef): (WebElementPropertyBag::Release): (isEqual): (convertStringToVariant): (WebElementPropertyBag::Read): This is the bulk of the class. It compares the input key to all of the possible keys and calls the appropriate function for each. (WebElementPropertyBag::Write): Writing is not actually allowed.
  • WebElementPropertyBag.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::elementAtPoint): Call into frame to get the HitTestResult for the point and set elementDictionary to the WebElementPropertyBag for the result.

WebCore:

Reviewed by Steve and Anders.

Add client() fucntion to FrameWin to return the FrameClient.

  • bridge/win/FrameWin.h: (WebCore::FrameWin::client):
10:05 PM Changeset in webkit [17609] by darin
  • 14 edits in trunk/WebCore
  • quick attempt to fix the no-SVG build
  • platform/graphics/svg/SVGResource.cpp:
  • platform/graphics/svg/SVGResource.h:
  • platform/graphics/svg/SVGResourceClipper.cpp:
  • platform/graphics/svg/SVGResourceClipper.h:
  • platform/graphics/svg/SVGResourceImage.h:
  • platform/graphics/svg/SVGResourceMarker.cpp:
  • platform/graphics/svg/SVGResourceMarker.h:
  • platform/graphics/svg/SVGResourceMasker.cpp:
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.h:
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp:
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added #ifdef SVG_SUPPORT to these files.
7:38 PM Changeset in webkit [22472] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build

  • WebCore.vcproj/WebCore.vcproj:
7:15 PM Changeset in webkit [17608] by mjs
  • 2 edits in trunk/WebCore

Reviewed & landed by Maciej.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11265

  • platform/win/ResourceLoaderWin.cpp: (WebCore::transferJobStatusCallback): (WebCore::ResourceLoader::start):
6:55 PM Changeset in webkit [17607] by mjs
  • 8 edits
    4 moves in trunk

WebCore:

Reviewed by Oliver.

  • moved FormData and FormDataStream to platform/network directory
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/FormData.cpp: Removed.
  • loader/FormData.h: Removed.
  • loader/mac/FormDataStream.h: Removed.
  • loader/mac/FormDataStream.m: Removed.
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/SubresourceLoaderMac.mm:
  • platform/network/mac/FormDataStreamMac.h: Added.
  • platform/network/mac/FormDataStreamMac.mm: Added.
  • platform/network/mac/ResourceRequestMac.mm:

WebKit:

Reviewed by Oliver.


  • removed unneeded (and obsolete) header includes
  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebFrame.mm:
4:04 PM Changeset in webkit [22471] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

  • WebFrame.cpp:
  • WebFrame.h:
3:54 PM Changeset in webkit [22470] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

  • bridge/win/FrameWin.cpp:
  • bridge/win/PageWin.cpp:
3:52 PM Changeset in webkit [17606] by sfalken
  • 3 edits in trunk/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

  • loader/DocumentLoader.h:
  • platform/win/ScreenWin.cpp:
3:14 PM Changeset in webkit [17605] by darin
  • 3 edits in trunk/WebKit
  • WebKit part of Frame.h check-in (forgot to land it)
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]): (-[WebFrameBridge shouldInterruptJavaScript]): (-[WebFrameBridge saveDocumentState:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge valueForKey:keys:values:]): (-[WebFrameBridge getObjectCacheSize]): (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebFrameBridge mayStartDragAtEventLocation:]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge getAppletInView:]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge setIsSelected:forView:]):
2:02 PM Changeset in webkit [17604] by darin
  • 37 edits in trunk/WebCore

Reviewed by Geoff.

  • more preparation for splitting up Frame into sub-pieces
  • removed unnecessary includes from Frame.h
  • page/Frame.h: Removed unneeded includes and forward declarations. Added additional forward declarations. Removed the constant NoXPosForVerticalArrowNavigation, now moved inside SelectionController. Created sections of functions to be moved into Chrome, Editor, EventHandler, FrameLoader, SelectionController, and the Platform directory, as well as marking one function for deletion.
  • page/FramePrivate.h: Removed the definition of the constructor and destructor and removed unnecessary includes.
  • page/FrameView.h: Removed unneeded forward declarations and friend declarations. Created a section of functions and data to be moved into EventHandler.
  • bridge/mac/FrameMac.h: Removed unneeded forward declarations. Created sections of functions and data to be moved into Chrome, Editor, EventHandler, FrameLoader, and the Platform directory.
  • bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment. Removed unused methods areScrollbarsVisible, nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
  • page/Frame.cpp: (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have to include KURL.h just for the KURL default constructor. (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h. (WebCore::FramePrivate::~FramePrivate): Ditto.
  • page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf booleans, scrollbarMoved and cleared funcitons. (WebCore::FrameView::clear): Moved the code from the cleared function in here. (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated for changes to header.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::xPosForVerticalArrowNavigation): Moved NoXPosForVerticalArrowNavigation into this file.
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_window.cpp:
  • bridge/mac/WebCoreAXObject.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/cssstyleselector.cpp:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/EventTargetNode.cpp:
  • dom/MouseRelatedEvent.cpp:
  • dom/XMLTokenizer.cpp:
  • html/HTMLBaseElement.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLGenericFormElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLTokenizer.cpp:
  • loader/mac/FrameLoaderMac.mm:
  • page/PageState.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderPartObject.cpp:
  • rendering/RenderTreeAsText.cpp:
  • xml/XSLTProcessor.cpp: Added includes as needed to keep compiling, since there are fewer includes in Frame.h.
12:36 AM Changeset in webkit [17603] by ap
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

​http://bugs.webkit.org/show_bug.cgi?id=11402
REGRESSION: onChange does not work anymore for 1st item in popup

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): (WebCore::HTMLSelectElement::reset): Set m_lastOnChangeIndex to -1.

Nov 4, 2006:

10:16 PM Changeset in webkit [17602] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11521
Bug 11521: [Drosera] Breakpoint editor UI behaves incorrectly when multiple editors are open

  • Drosera/debugger.js: Use . instead of so that it doesn't root the search at the document.
10:14 PM Changeset in webkit [17601] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11513
Bug 11513: [Drosera] Function popup fails to appear when clicking supposedly valid areas.

  • Drosera/debugger.css: Stick a min-width on the menu to keep it from becoming smaller than the control.
10:12 PM Changeset in webkit [17600] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <​catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11512
Bug 11512: [Drosera] Scrolling via keyboard breaks after clicking in function popup.

  • Drosera/debugger.js: blur() the function popup when we're done with it.
5:24 PM Changeset in webkit [22469] by darin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Maciej.

  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Updated for change of const Event* to Event*. (WebCore::FrameWin::submitForm): Added Event* parameter.

WebKitWin:

  • WebView.cpp: (WebView::initWithFrame): Removed setMainFrame call and deref of Frame, now handled by Frame's constructor.
5:16 PM Changeset in webkit [17599] by darin
  • 1 edit in trunk/WebCore/ChangeLog

s

5:16 PM Changeset in webkit [17598] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ander.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel. Since the subresource owns the resource handle, there's no need to cancel. This arrangement is only temporary, anyway, since Maciej will soon change things so that the subresource loader uses the resource handle and the resource handle doesn't know anything about the subresource loader.
5:06 PM Changeset in webkit [17597] by darin
  • 84 edits
    1 delete in trunk

WebCore:

Reviewed by Maciej.

  • converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones

converted most uses of NSURL to KURL and NSEvent to DOM Event in
loader classes

moved download function out of FrameLoader.h to avoid reference to
NSURLConnection

added DOM Event parameters to various functions so that the handlers
can use the DOM Event instead of the global "current NSEvent";
includes Frame::submitForm, HTMLFormElement::prepareSubmit,
HTMLFormElement::submit, FrameLoader::load

moved the setMainFrame call that hands ownership to the Page
into one of the Frame constructors, and removed it from all
the clients

removed const from Event parameter to the urlSelected function
(we rarely use const with DOM elements)

removed some redundant includes and declarations from various
header files

removed NSURL parameter from userAgent function -- if we need it we
can add it back, but converting from NSURL to KURL and back is
inefficient enough that it's best to have it out for now (since it's
been unused for years) -- if we add it back, we can choose an
appropriate parameter type that's always inexpensive to pass

did some basic cleanup in the IconLoader class, including removing
an unnecessary loop that added icon data a byte at a time

renamed safeLoad to load, since it's no different from the other
FrameLoader load functions, safety-wise

fixed some code that was trying to distinguish null frame name from
empty string frame name -- both should be handled the same, but callers
were doing it by checking for empty and turning it into null (in a way
that was causing extra round trips between NSString and WebCore::String)

corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
and got rid of case-insensitive compares of methods

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent):
  • bridge/mac/FrameViewMac.mm:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm:
  • bridge/mac/WebCoreSettings.mm:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
  • bridge/win/FrameWin.h:
  • dom/MouseRelatedEvent.cpp:
  • dom/MouseRelatedEvent.h:
  • dom/UIEvent.cpp: (WebCore::UIEvent::~UIEvent):
  • dom/UIEvent.h:
  • dom/UIEventWithKeyState.h:
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/NavigationAction.h: (WebCore::NavigationAction::event):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::create): (WebCore::IconLoader::startLoading): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::URLForHistory):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/IconLoaderMac.mm: (WebCore::IconLoader::notifyIconChanged):
  • loader/mac/LoaderFunctionsMac.mm:
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/mac/NavigationActionMac.mm: (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
  • loader/mac/ResourceLoaderMac.mm:
  • loader/mac/SubresourceLoaderMac.mm:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::urlSelected): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::endIfNotLoading): (WebCore::Frame::hitTestResultAtPoint):
  • page/Frame.h:
  • page/FramePrivate.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/FrameGdk.h:
  • platform/mac/TextFieldMac.mm:
  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceResponseMac.h:
  • platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]):
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected):
  • platform/qt/FrameQt.h:
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::returnPressed):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp:

WebKit:

Reviewed by Maciej.

  • converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones

store the computed user agent string as a WebCore::String instead
of an NSString to avoid overhead converting it every time we get it

  • COM/WebFrame.cpp: (WebFrame::initWithName):
  • ChangeLog:
  • Misc/WebElementDictionary.m: (-[WebElementDictionary _image]): (-[WebElementDictionary _targetWebFrame]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent): (WebFrameLoaderClient::actionDictionary):
  • WebCoreSupport/WebPageBridge.mm: (WebCore::if):
  • WebView/WebDataSource.mm: (-[WebDataSource _URL]): (-[WebDataSource _URLForHistory]): (-[WebDataSource unreachableURL]):
  • WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]):
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): (-[WebPDFView _path]):
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]): (-[WebView _preferencesChangedNotification:]): (-[WebView _cachedResponseForURL:]): (-[WebView setApplicationNameForUserAgent:]): (-[WebView setCustomUserAgent:]): (-[WebView customUserAgent]): (-[WebView userAgentForURL:]): (-[WebView _computeUserAgent]): (-[WebView WebCore::]):
  • WebView/WebViewInternal.h:
5:02 PM Changeset in webkit [17596] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 Mark Rowe <​bdash@webkit.org>

Reviewed by Darin.

Fix use of uninitialized value in pattern match.

  • Scripts/webkitdirs.pm:
4:23 PM Changeset in webkit [22468] by mjs
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adele.

  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebCore.vcproj/WebCore.vcproj: Added new files
  • platform/win/TemporaryLinkStubs.cpp: Removed unneeded link stubs

WebKitWin:

Reviewed by Adele.


  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebFrame.cpp: (WebFrame::willSendRequest): Rearranged from former receivedRedirect.
  • WebFrame.h:
4:15 PM Changeset in webkit [17595] by mjs
  • 24 edits
    2 copies
    4 adds in trunk/WebCore

Reviewed by Adele.

  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted for CachedResource method renames. (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): Ditto.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): simplified based on ResourceResponse
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage): adapt for ResourceResponse
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): store a ResourceResponse; platform response is now called platformResponse and expiration date is removed. (WebCore::CachedResource::~CachedResource): ditto (WebCore::CachedResource::isExpired): ditto
  • loader/CachedResource.h: (WebCore::CachedResource::platformResponse): ditto (WebCore::CachedResource::setResponse): ditto (WebCore::CachedResource::canDelete): ditto
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): Adjusted for renames. (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse in the CachedResource.
  • loader/loader.h:
  • loader/mac/FormDataStream.h:
  • loader/mac/FormDataStream.m: (WebCore::getStreamFormDatas): Rearranged things so it's possible to get a FormData back out of a form data stream. (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::httpBodyFromStream): ditto
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad): s/response/platformResponse/
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): ditto (WebCore::CachedResource::setPlatformResponse): ditto
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): send redirect to client appropriately
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): new entry point for SubresourceLoader, dispatch to client.
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::allowHTTPCookies): implemented (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): initialize expiration date(!)
  • platform/network/cf/FormDataStreamCFNet.cpp: Added. (WebCore::getStreamFormDatas): Added this, ported from NSURL version. (WebCore::openNextStream): ditto (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::formCanRead): ditto (WebCore::formEventCallback): ditto (WebCore::setHTTPBody): ditto (WebCore::httpBodyFromStream): ditto
  • platform/network/cf/FormDataStreamCFNet.h: Added.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): implemented (WebCore::ResourceHandle::start): use new ResourceRequest stuff
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): do nothing for a null response
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
  • platform/network/mac/ResourceRequestMac.h: Added.
  • platform/network/mac/ResourceRequestMac.mm: Added. (WebCore::getResourceRequest): Added way to convert an NSURLRequest to a ResourceRequest. (WebCore::nsURLRequest): Opposite of the above.
  • platform/network/cf/ResourceRequestCFNet.h: Added.
  • platform/network/cf/ResourceRequestCFNet.cpp: Added. (WebCore::getResourceRequest): Added way to convert an CFURLRequest to a ResourceRequest. (WebCore::cfURLRequest): Opposite of the above.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect, adjusted.
  • xml/xmlhttprequest.h:
9:54 AM Changeset in webkit [17594] by darin
  • 2 edits in trunk/WebCore

Change suggested by Mitz.

  • bridge/mac/WebCorePageState.mm: (-[WebCorePageState dealloc]): Add null check. (-[WebCorePageState finalize]): Ditto.
9:53 AM Changeset in webkit [17593] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/webkitdirs.pm: Don't try to use the Xcode build setting if it's project-relative.
7:51 AM Changeset in webkit [17592] by ap
  • 16 edits
    3 adds in trunk

2006-11-04 Bertrand Guiheneuf <​guiheneuf@gmail.com>

Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).

​http://bugs.webkit.org/show_bug.cgi?id=11433
Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths Created platform/graphics and platform/network filters in hierarchy Moved GraphicsContext and GraphicsTypes to their respective filters Added EditorClient.h Added FrameLoader* files in loader/ Added HitTest* files in rendering/ Added Editor.* files in editing/ Added DeleteButton.* and DeleteButtonController.* in editing/
  • bridge/win/ChromeClientWin.h: Added. (WebCore::ChromeClientWin::~ChromeClientWin):
  • bridge/win/EditorClientWin.h: Added. (WebCore::EditorClientWin::~EditorClientWin):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
  • bridge/win/FrameWin.h: Added EditorClient parameter to constructor Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest() Removed openURL() and openURLRequest from class definition
  • bridge/win/PageWin.cpp:
  • platform/AffineTransform.h:
  • platform/cairo/AffineTransformCairo.cpp: Added. (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::m11): (WebCore::AffineTransform::m12): (WebCore::AffineTransform::m21): (WebCore::AffineTransform::m22): (WebCore::AffineTransform::dx): (WebCore::AffineTransform::dy): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::det): (WebCore::AffineTransform::invert): (WebCore::AffineTransform::operator cairo_matrix_t): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator*= ): (WebCore::AffineTransform::operator* ):
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::goBackOrForward): (WebCore::FrameWin::getHistoryLength): (WebCore::FrameWin::historyURL): (WebCore::ServeSynchronousRequest): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::Path::transform): (WebCore::PopupMenu::updateFromElement): (WebCore::ResourceLoader::loadsBlocked): (WebCore::systemBeep):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::didReceiveData): (WebFrame::receivedAllData): Use resource handles now. Do not start doc loader by hand anymore. Handle didReceiveData() callback instead of receivedData() which is deprecated in implementation of ResourceHandleClient
  • COM/WebFrame.h:
  • COM/WebView.cpp: Applied ResourceLoader --> ResourceHandle renaming
  • WebKit.vcproj/WebKit.rc: Got rid of MFC dependencies (build fix for VCExpress).
  • WebKit.vcproj/WebKit.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths
Note: See TracTimeline for information about the timeline view.