Context Navigation

← Previous Period
Next Period →

Timeline

Nov 8, 2006:

11:31 PM Changeset in webkit [22504] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Make the same change here as made in r11013.

11:13 PM Changeset in webkit [22503] by mjs

7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

added ResourceError class and didFailWithError client method

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFailLoadingWithError): (WebCore::PluginStreamWin::didFinishLoading):
plugins/win/PluginStreamWin.h:

WebKitWin:

Reviewed by Geoff.

added ResourceError class and didFailWithError client method

WebFrame.cpp: (WebFrame::didFinishLoading): (WebFrame::didFailWithError):
WebFrame.h:

10:49 PM Changeset in webkit [17682] by mjs

16 edits
3 adds in trunk

Reviewed by Geoff.

added ResourceError class and didFailWithError client method

WebCore.xcodeproj/project.pbxproj:
loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading):
loader/icon/IconLoader.h:
loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError):
loader/loader.h:
loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptCFReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adopt):
platform/network/ResourceError.cpp: Added.
platform/network/ResourceError.h: Added. (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
platform/network/ResourceHandle.cpp:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFailWithError):
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::cancel):
platform/network/mac/ResourceErrorMac.mm: Added. (-[NSError WebCore]):
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::reportError):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading):
xml/xmlhttprequest.h:

10:39 PM Changeset in webkit [17681] by bdash

9 edits
1 add in trunk/WebCore

2006-11-08 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\Gdk fixes.

platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::~ChromeClientGdk):
platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor): (WebCore::moveCursor):
platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
platform/gdk/PageGdk.cpp:
platform/gdk/ScreenClientGdk.h: Added. (WebCore::ScreenClientGdk::~ScreenClientGdk):
platform/gdk/ScreenGdk.cpp: (WebCore::ScreenClientGdk::depth): (WebCore::ScreenClientGdk::depthPerComponent): (WebCore::ScreenClientGdk::isMonochrome): (WebCore::ScreenClientGdk::rect): (WebCore::ScreenClientGdk::usableRect):
platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::historyURL): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable):
platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::client):
platform/network/gdk/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove):

9:58 PM Changeset in webkit [17680] by aroben

2 edits in trunk/WebCore

Build fix.

rendering/RenderObject.h: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):

9:22 PM Changeset in webkit [22502] by ggaren

3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Updated Windows to use the new platform abstraction for Screen.

WebCore.vcproj/WebCore.vcproj:
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize):
platform/win/ScreenWin.cpp: (WebCore::monitorInfoForWidget): (WebCore::deviceInfoForWidget): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

9:18 PM Changeset in webkit [17679] by brmorris

1 edit in S60/trunk/README.txt

Updating README.txt to point to new wiki location.

9:18 PM Changeset in webkit [17678] by ggaren

7 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Made Screen a good platform citizen by removing its reference to Page. This
made a class unnecessary, so all screen fuctions are stand-alone now.

bindings/js/kjs_window.cpp: Removed unnecessary subtractions when computing the screen's available dimensions.

7:55 PM Changeset in webkit [17677] by weinig

3 edits in trunk/WebCore

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
Cleanup RenderObject

rendering/RenderObject.cpp: (WebCore::RenderObject::operator delete): (WebCore::RenderObject::createObject): (WebCore::RenderObjectCounter::~RenderObjectCounter): (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::isDescendantOf): (WebCore::RenderObject::isRoot): (WebCore::RenderObject::addChild): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::removeChild): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::nextInPreOrder): (WebCore::RenderObject::nextInPreOrderAfterChildren): (WebCore::RenderObject::previousInPreOrder): (WebCore::RenderObject::isEditable): (WebCore::RenderObject::nextEditable): (WebCore::RenderObject::previousEditable): (WebCore::RenderObject::firstLeafChild): (WebCore::RenderObject::lastLeafChild): (WebCore::RenderObject::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::updateFirstLetter): (WebCore::RenderObject::offsetParent): (WebCore::RenderObject::scroll): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::markContainingBlocksForLayout): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::containingBlockWidth): (WebCore::RenderObject::containingBlockHeight): (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::addPDFURLRect): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::repaintObjectsBeforeLayout): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::information): (WebCore::RenderObject::dump): (WebCore::selectStartNode): (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::createAnonymousBlock): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::setStyleInternal): (WebCore::RenderObject::updateBackgroundImages): (WebCore::RenderObject::absolutePosition): (WebCore::RenderObject::caretRect): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight): (WebCore::RenderObject::tabWidth): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy): (WebCore::RenderObject::arenaDelete): (WebCore::RenderObject::hitTest): (WebCore::RenderObject::setInnerNode): (WebCore::RenderObject::nodeAtPoint): (WebCore::RenderObject::verticalPositionHint): (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::invalidateVerticalPositions): (WebCore::RenderObject::recalcMinMaxWidths): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::setInlineBoxWrapper): (WebCore::RenderObject::firstLineStyle): (WebCore::RenderObject::getPseudoStyle): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::collectDashboardRegions): (WebCore::RenderObject::avoidsFloats): (WebCore::RenderObject::findCounter): (WebCore::RenderObject::backslashAsCurrencySymbol): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::previousOffset): (WebCore::RenderObject::nextOffset): (WebCore::RenderObject::inlineBox):
rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::renderName): (WebCore::RenderObject::parent): (WebCore::RenderObject::previousSibling): (WebCore::RenderObject::nextSibling): (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::getOverflowClipRect): (WebCore::RenderObject::getClipRect): (WebCore::RenderObject::getBaselineOfFirstLineBox): (WebCore::RenderObject::setEdited): (WebCore::RenderObject::setStaticX): (WebCore::RenderObject::setStaticY): (WebCore::RenderObject::setPreviousSibling): (WebCore::RenderObject::setNextSibling): (WebCore::RenderObject::setParent): (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::isRenderView): (WebCore::RenderObject::childrenInline): (WebCore::RenderObject::setChildrenInline): (WebCore::RenderObject::isAnonymousBlock): (WebCore::RenderObject::isDragging): (WebCore::RenderObject::needsLayout): (WebCore::RenderObject::setMinMaxKnown): (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc): (WebCore::RenderObject::setPositioned): (WebCore::RenderObject::setRelPositioned): (WebCore::RenderObject::setFloating): (WebCore::RenderObject::setInline): (WebCore::RenderObject::setShouldPaintBackgroundOrBorder): (WebCore::RenderObject::setReplaced): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::calcWidth): (WebCore::RenderObject::updateFromElement): (WebCore::RenderObject::RepaintInfo::RepaintInfo): (WebCore::RenderObject::setOverrideSize): (WebCore::RenderObject::setPos): (WebCore::RenderObject::setWidth): (WebCore::RenderObject::setHeight): (WebCore::RenderObject::absolutePositionForContent): (WebCore::RenderObject::overflowHeight): (WebCore::RenderObject::overflowWidth): (WebCore::RenderObject::setOverflowHeight): (WebCore::RenderObject::setOverflowWidth): (WebCore::RenderObject::overflowLeft): (WebCore::RenderObject::overflowTop): (WebCore::RenderObject::overflowRect): (WebCore::RenderObject::stopAutoscroll): (WebCore::RenderObject::collapsedMarginTop): (WebCore::RenderObject::collapsedMarginBottom): (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin): (WebCore::RenderObject::): (WebCore::RenderObject::setTable): (WebCore::RenderObject::isFloatingOrPositioned): (WebCore::RenderObject::containsFloat): (WebCore::RenderObject::setSelectionState): (WebCore::RenderObject::SelectionInfo::SelectionInfo): (WebCore::RenderObject::lowestPosition): (WebCore::RenderObject::rightmostPosition): (WebCore::RenderObject::leftmostPosition): (WebCore::RenderObject::calcVerticalMargins): (WebCore::RenderObject::font):

6:21 PM Changeset in webkit [22501] by darin

4 edits in branches/WindowsMerge/WebCore

fix the build

bridge/win/FrameWin.h: Add a forward declaration of FormData.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Call resetMultipleFormSubmissionProtection instead of prepareForUserAction.

platform/win/TemporaryLinkStubs.cpp: Remove the parameter from the TextField constructor.

6:18 PM Changeset in webkit [17676] by zbujtas

2 edits in S60/trunk/WebCore

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by zalan.
merged from 3.1m 17675
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
http://bugs.webkit.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

6:07 PM Changeset in webkit [17675] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by zalan.
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
http://bugzilla.opendarwin.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

6:00 PM Changeset in webkit [22500] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebEditorClient.cpp: Added stubs for new methods from EditorClient.h. (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
WebEditorClient.h: Added new methods from EditorClient.h and cleaned up placement of *s.

6:00 PM Changeset in webkit [17674] by darin

30 edits
2 adds in trunk

LayoutTests:

Reviewed by Anders.

added test for option-tab

fast/events/option-tab.html: Added.
fast/events/option-tab-expected.txt: Added.

WebCore:

Reviewed by Anders.

added event parameters to focus-related functions so we can implement the "option-tab to all links" behavior without relying on a global "current event" -- also makes it work with DOM events

page/Frame.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
page/Frame.cpp: (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from PlatformKeyboardEvent to the DOM keyboard event class. (WebCore::Frame::tabsToLinks): Added event parameter. (WebCore::Frame::tabsToAllControls): Ditto. (WebCore::scanForForm): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (WebCore::Frame::hitTestResultAtPoint): Ditto.

bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
bridge/mac/FrameMac.mm: (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of a PlatformKeyboardEvent. (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent() and pass event into next/previousFocusNode. (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from the AppKit current event, if it's a keyboard event. Really just a hack that's needed to preserve some code we can remove once we deal with the last NSView- based form control. (WebCore::isKeyboardOptionTab): Added. (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the option (alt) key is down. (WebCore::FrameMac::tabsToAllControls): Ditto. (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just call resetMultipleFormSubmissionProtection() explicitly instead. (WebCore::FrameMac::mouseDown): Ditto.

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to prepareForUserAction() to call resetMultipleFormSubmissionProtection() explicitly instead.

page/FrameView.h:
page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Changed function to take an event parameter, and decide the direction based on the shift key modifier instead of a passed-in boolean.

dom/Document.h:
dom/Document.cpp: (WebCore::Document::nextFocusNode): Added event parameter. (WebCore::Document::previousFocusNode): Ditto.
dom/Node.h:
dom/Node.cpp: (WebCore::Node::isKeyboardFocusable): Ditto.
html/HTMLAnchorElement.h:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
html/HTMLGenericFormElement.h:
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
html/HTMLInputElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
html/HTMLSelectElement.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
html/HTMLTextAreaElement.h:
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Pass event to the advanceFocus function.

platform/TextField.h:
platform/mac/TextFieldMac.mm: Removed the non-search field code.

platform/mac/WebCoreTextField.h:
platform/mac/WebCoreTextField.mm: Removed the non-search field code. (-[WebCoreTextFieldController controlTextDidChange:]): Removed the call to FrameMac::handleKeyboardOptionTabInView, which is no longer needed since the default handler in HTMLInputElement takes care of option-tab.

platform/mac/SliderMac.mm: (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent() and pass event into tabsToAllControls. (Slider::focusPolicy): Ditto.

rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code. (WebCore::RenderLineEdit::updateFromElement): Ditto.

5:41 PM Changeset in webkit [22499] by sfalken

2 edits in branches/WindowsMerge/WebCore

5:33 PM Changeset in webkit [17673] by darin

2 edits in trunk/WebKitTools

Reviewed by Anders.

same change as below, only tested this time

DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links" mode off. I think we need to do this because WebPreferences saves things for us automatically. It would be good to turn that off for DumpRenderTree, but for now lets handle this like the other preferences (set it explicitly each time).

5:21 PM Changeset in webkit [17672] by darin

2 edits in trunk/WebKitTools

Reviewed by Anders.

DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on "tab to links" mode. No current tests depend on this, and there's a new test I want to land that depends on the default setting.

5:16 PM Changeset in webkit [17671] by beidson

2 edits in trunk/WebCore

Reviewed by Dave Harrison, Oliver, and Darin
(oh my! where was superkevin on this one?)

<rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)

More "free nil checking" we lost in the transition from ObjC to C++

loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto

4:51 PM Changeset in webkit [17670] by andersca

19 edits in trunk

WebCore:

Reviewed by Adam.

Move more code into editor.

WebCore.exp:
bridge/EditorClient.h:
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm:
bridge/mac/WebCoreFrameBridge.h:
dom/Document.cpp: (WebCore::Document::relinquishesEditingFocus): (WebCore::Document::acceptsEditingFocus): (WebCore::Document::didBeginEditing): (WebCore::Document::didEndEditing):
editing/Editor.cpp: (WebCore::Editor::indent): (WebCore::Editor::outdent):
editing/Editor.h:
page/Frame.cpp:
page/Frame.h:

WebKit:

Reviewed by Adam.

Move more code into editor.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
WebCoreSupport/WebFrameBridge.mm:
WebView/WebHTMLView.m: (-[NSArray indent:]): (-[NSArray outdent:]):
WebView/WebView.mm:
WebView/WebViewInternal.h:

4:41 PM Changeset in webkit [22498] by bdakin

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Add clause for new WebElementIsContentEditableKey to the Read
fucntion.

Interfaces/IWebView.idl:
WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):

2:58 PM Changeset in webkit [17669] by bdakin

9 edits in trunk

WebCore:

Reviewed by Adam.

Add ability to HitTestResult to ask if the inner non-shared node is
content editable.

WebCore.exp: Export HitTestResult::isContentEditable()
rendering/HitTestResult.cpp: (WebCore::HitTestResult::isContentEditable):
rendering/HitTestResult.h:

WebKit:

Reviewed by Adam.

Add WebElementIsContentEditableKey to the WebElementDictionary, and
use it!

DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Use new WebElementIsContentEditableKey.
Misc/WebElementDictionary.m: (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary _isContentEditable]): Call into HitTestResult::isContentEditable()
WebView/WebView.mm: Add new key.
WebView/WebViewPrivate.h: Add new key.

2:50 PM Changeset in webkit [17668] by andersca

2 edits in trunk/WebCore

Build fix.

WebCore.xcodeproj/project.pbxproj: Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.

2:32 PM Coding Style Guidelines edited by sam@webkit.org

(diff)

2:24 PM Changeset in webkit [17667] by thatcher

12 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
<rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection

Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.

bindings/objc/DOM.mm: (WebCore::kit): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):
bindings/objc/DOMPrivate.h:
dom/Range.cpp: (WebCore::Range::boundingBox): (WebCore::Range::addLineBoxRects):
dom/Range.h:
rendering/RenderContainer.cpp: (WebCore::RenderContainer::addLineBoxRects):
rendering/RenderContainer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects):
rendering/RenderObject.h:
rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
rendering/RenderText.h:

1:57 PM Changeset in webkit [22497] by adachan

6 edits in branches/WindowsMerge

1:57 PM Changeset in webkit [17666] by andersca

18 edits in trunk

WebCore:

Reviewed by Oliver.

Move methods from the bridge and frame into editor.

WebCore.exp:
bridge/EditorClient.h:
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm:
editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::Editor::toggleBold): (WebCore::Editor::toggleItalic): (WebCore::Editor::selectionStartHasStyle):
editing/Editor.h:
editing/JSEditor.cpp:
page/Frame.cpp:
page/Frame.h:

WebKit:

Reviewed by Oliver.

Call into the WebCore editor object directly.

MigrateHeaders.make:
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle):
WebView/WebFrame.mm: (core): (kit):
WebView/WebFrameInternal.h:
WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]): (-[NSArray _changeCSSColorUsingSelector:inRange:]): (-[NSArray underline:]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
WebView/WebView.mm: (-[WebView applyStyle:]):

1:30 PM Changeset in webkit [17665] by andersca

2 edits in trunk/WebKit

Reviewed by Oliver.

<rdar://problem/4825370>
REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app

WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Initialize the framework pointer to 0.

1:26 PM Changeset in webkit [22496] by lamadio

10 edits in branches/WindowsMerge

1:20 PM Changeset in webkit [17664] by adachan

2 edits in trunk/JavaScriptCore

2006-11-08 Ada Chan <adachan@apple.com>

Reviewed by darin.

Added a method to delete all the keys in a HashMap.

12:14 PM Changeset in webkit [17663] by ggaren

4 edits in trunk/WebCore

Reviewed by Beth.

Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
be able to dispatch user events even when off-screen, so we have to support
off-screen windows when handling mouse events.

platform/Screen.h:
platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint): Grab the best screen instead of the screen you're on, since you might be off-screen.
platform/mac/ScreenMac.mm: (WebCore::screenForWindow):

11:47 AM Changeset in webkit [22495] by andersca

5 edits
3 adds in branches/WindowsMerge/WebKitTools

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

Fix the build. Hook up a layoutTestController and implement dumpAsText, waitUntilDone and notifyDone.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): (main):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Added. (dumpAsTextCallback): (waitUntilDoneCallback): (notifyDoneCallback): (getClass): (createLayoutTestController):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Added.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didFinishLoadForFrame): (WaitUntilDoneDelegate::windowScriptObjectAvailable):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction):

11:13 AM Changeset in webkit [22494] by andersca

5 edits in branches/WindowsMerge

WebCoreWin:

2006-11-08 Anders Carlsson <acarlsson@apple.com>

Build fixes.

WebCore.vcproj/WebCore.vcproj:
platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

2006-11-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

More fiddling with midl to get our JSC API types recognized.

Interfaces/IWebFrameLoadDelegate.idl:

9:32 AM Changeset in webkit [17662] by darin

3 edits in trunk/WebCore

fix bug caused by last-minute change to my check-in last night that is causing layout tests to hang

dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn a null string into an empty string before calling completeURL.

2:02 AM Changeset in webkit [17661] by beidson

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Maciej

Added test to cover bug http://bugs.webkit.org/show_bug.cgi?id=11450
-Confirm there is no assert when nuking a frame with an active XMLHttpRequest load
-Confirm the correct state-change notifications for the request are dispatched

http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: Added.
http/tests/xmlhttprequest/frame-load-cancelled-abort.html: Added.
http/tests/xmlhttprequest/resources/endlessxml.php: Added.
http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added.

WebCore:

Reviewed by Maciej

If the request has already been aborted, bail out of didFinishLoading()
immediately. This prevents state change notifications that aren't
needed.

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):

1:55 AM Changeset in webkit [22493] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): Use m_frame instead of this, include the correct files.

1:51 AM Changeset in webkit [17660] by darin

2 edits in trunk/WebCore

another attempt to fix Qt build

loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.

1:48 AM Changeset in webkit [17659] by darin

3 edits in trunk/WebCore

Reviewed by Geoff.

stray bits of my FrameLoader patch that I left out by accident

loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class. (WebCore::FrameLoader::requestFrame): Use less DeprecatedString. (WebCore::FrameLoader::clear): Stop the redirection timer. (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the entire function in an if statement. Use less DeprecatedString. (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator. (WebCore::FrameLoader::scheduleRefresh): Ditto. (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class.
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto.

1:47 AM Changeset in webkit [22492] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

(I'm not doing this to get commit 11000)

loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): It's m_frame, not frame.

1:45 AM Changeset in webkit [17658] by darin

2 edits in trunk/LayoutTests

Reviewed by Geoff.

fast/forms/submit-nil-value-field-assert.html: Update test so it no longer relies on incorrect "submit form right away during JavaScript execution" behavior.

1:43 AM Changeset in webkit [22491] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

It's FrameLoader, not FrameWin.

loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin):

1:40 AM Changeset in webkit [22490] by andersca

4 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

A blind attempt at fixing the build.

bridge/win/FrameWin.cpp:
loader/win/FrameLoaderWin.cpp: (WebCore::FrameWin::partClearedInBegin):
platform/win/TemporaryLinkStubs.cpp: (FrameLoader::restoreDocumentState):

12:19 AM Changeset in webkit [17657] by bdakin

2 edits in trunk/LayoutTests

Reviewed by Geoff.

This test needs new results from my last check-in. I thought this
change was already in my tree, but I guess not. Whoops!

fast/dom/delete-contents-expected.txt:

Nov 7, 2006:

11:48 PM Changeset in webkit [17656] by bdakin

10 edits
25 adds in trunk

WebCore:

Reviewed by Hyatt.

Another go at fix for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

The fix from yesterday caused a layout test regression which
exposed an existing bug. The existing bug was that we allowed text
nodes to stay in the head tag, but other browsers move them to the
body. The previous fix also caused a performance regression, which
was seemingly easy to fix by moving the new clause in
HTMLParser::handleError() to be below the HTMLElement case.

html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to be the child of the document.
html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::childAllowed): Do not allow non- whitespace text nodes to be children of the head.
html/HTMLHeadElement.h:
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Error case for comment nodes.
page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Safety-net null check for the original crash.

Layout Tests:

Reviewed by Hyatt.

Test cases for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

And for the found-bug of moving text nodes within the head to the
body.

11:24 PM Changeset in webkit [17655] by darin

2 edits in trunk/WebCore

another attempt to fix Qt build

loader/icon/IconLoader.h: Added missing include.

11:09 PM Changeset in webkit [22489] by ggaren

5 edits
1 add
2 deletes in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Removed ScreenClient. It was highly unpopular, risking my midterm re-election.

None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.

Moved Screen back from page/ to platform/ because it's a platform
abstraction again.

Fixed bug where Screen would query the default screen instead of the screen
on which the active window was located. (The code is written in Klingon,
but that's cool.)

Implemented some missing screen functionality on Win.

I can't fully verify this code because I can't load files without crashing
in CFNetwork, but I exercised most of it with javascript: URLs and the
debugger reported reasonable values.

WebCore.vcproj/WebCore.vcproj:
platform/win/ScreenWin.cpp: Added. Merged over from opensource tree. (WebCore::getWindow): (WebCore::getMonitorInfo): (WebCore::getDeviceInfo): (WebCore::Screen::depth): (WebCore::Screen::depthPerComponent): (WebCore::Screen::isMonochrome): (WebCore::Screen::rect): (WebCore::Screen::usableRect):

WebKitWin:

Reviewed by Anders.

Removed ScreenClient. It was highly unpopular, risking my midterm re-election.

None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.

11:04 PM Changeset in webkit [17654] by ggaren

11 edits
1 add
5 deletes in trunk

WebCore:

Reviewed by Tim Hatcher.

Removed ScreenClient. It was highly unpopular, risking my midterm re-election.

None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.

Moved Screen back from page/ to platform/ because it's a platform
abstraction again.

Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
since the two were always used together.

Changed pixel depth queries to query the deepest screen. Darin mentioned
that it might have been a feature, not a bug, to use the main/menubar screen
regardless of the screen you were on. For scaling and flipping that's not
the case, but for querying pixel depth I think it is. You want to know
about the highest pixel depth your content may display on.

Tests still pass.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
page/Page.cpp: (WebCore::Page::Page):
page/Page.h:
page/Screen.cpp: Removed.
page/Screen.h: Removed.
page/ScreenClient.h: Removed.
platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint):
platform/mac/ScreenMac.mm: (WebCore::window): (WebCore::bestScreen): (WebCore::Screen::depth): (WebCore::Screen::depthPerComponent): (WebCore::Screen::isMonochrome): (WebCore::Screen::rect): (WebCore::Screen::usableRect): (WebCore::toUserSpace): (WebCore::toDeviceSpace):

WebKit:

Reviewed by Geoff.

udpated for changes to move from Frame/FrameMac to FrameLoader

DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
Plugins/WebNetscapePluginStream.mm:
Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::provisionalLoadStarted):
WebView/WebFrame.mm: (-[WebFrame _canCachePage]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame stopLoading]):

9:58 PM Changeset in webkit [17653] by darin

3 edits in trunk/WebCore

try to fix Qt build

CMakeLists.txt: Updated for some file changes.
WebCoreSources.bkl: Ditto.

9:57 PM Changeset in webkit [22488] by darin

10 edits
1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

moved loader code from Frame/FrameMac to FrameLoader

WebCore.vcproj/WebCore.vcproj:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::~FrameWin):
bridge/win/FrameWin.h:
loader/win/FrameLoaderWin.cpp: Added. (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::setTitle):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::markMisspellings): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (IconLoader::notifyIconChanged): (PolicyCheck::PolicyCheck): (PolicyCheck::clear): (PolicyCheck::call): (PolicyCheck::clearRequest): (FrameLoader::saveDocumentState): (FrameLoader::restoreDocumentState): (FrameLoader::partClearedInBegin): (FrameLoader::goBackOrForward): (FrameLoader::historyURL): (FrameLoader::canGoBackOrForward): (FrameLoader::getHistoryLength): (DocumentLoader::setupForReplaceByMIMEType): (ResourceLoader::cancel): (DocumentLoader::stopLoading): (DocumentLoader::setLoading): (DocumentLoader::updateLoading): (DocumentLoader::setFrame): (DocumentLoader::stopRecordingResponses): (DocumentLoader::isStopping): (DocumentLoader::setPrimaryLoadComplete): (DocumentLoader::finishedLoading): (DocumentLoader::URL): (DocumentLoader::isLoadingInAPISense): (DocumentLoader::frameLoader): (FrameLoader::overrideMediaType): (FrameLoader::redirectDataToPlugin): (FrameLoader::checkLoadCompleteForThisFrame): (FrameLoader::loadEmptyDocumentSynchronously): (FrameLoader::startLoading): (FrameLoader::referrer):
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::userAgent):

WebKitWin:

Reviewed by Geoff.

moved loader code from Frame/FrameMac to FrameLoader

WebFrame.cpp: (WebFrame::loadData): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::initWithWebFrameView): (WebFrame::loadDataSource): (WebFrame::didReceiveResponse): (WebFrame::didReceiveData): (WebFrame::didFinishLoading): (WebFrame::setTitle): (WebFrame::dispatchDidHandleOnloadEvents): (WebFrame::detachFrameLoader): (WebFrame::hasWebView): (WebFrame::hasFrameView): (WebFrame::hasBackForwardList): (WebFrame::resetBackForwardList): (WebFrame::provisionalItemIsTarget): (WebFrame::loadProvisionalItemFromPageCache): (WebFrame::invalidateCurrentItemPageCache): (WebFrame::privateBrowsingEnabled): (WebFrame::makeDocumentView): (WebFrame::makeRepresentation): (WebFrame::forceLayout): (WebFrame::forceLayoutForNonHTML): (WebFrame::updateHistoryForCommit): (WebFrame::updateHistoryForBackForwardNavigation): (WebFrame::updateHistoryForReload): (WebFrame::updateHistoryForStandardLoad): (WebFrame::updateHistoryForInternalLoad): (WebFrame::updateHistoryAfterClientRedirect): (WebFrame::setCopiesOnScroll): (WebFrame::tokenForLoadErrorReset): (WebFrame::resetAfterLoadError): (WebFrame::doNotResetAfterLoadError): (WebFrame::willCloseDocument): (WebFrame::detachedFromParent1): (WebFrame::detachedFromParent2): (WebFrame::detachedFromParent3): (WebFrame::detachedFromParent4): (WebFrame::loadedFromPageCache): (WebFrame::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrame::dispatchDidCancelClientRedirect): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidChangeLocationWithinPage): (WebFrame::dispatchWillClose): (WebFrame::dispatchDidStartProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidCommitLoad): (WebFrame::dispatchDidFinishLoad): (WebFrame::dispatchDidFirstLayout): (WebFrame::dispatchShow): (WebFrame::cancelPolicyCheck): (WebFrame::dispatchWillSubmitForm): (WebFrame::dispatchDidLoadMainResource): (WebFrame::clearLoadingFromPageCache): (WebFrame::isLoadingFromPageCache): (WebFrame::revertToProvisionalState): (WebFrame::clearUnarchivingState): (WebFrame::progressStarted): (WebFrame::progressCompleted): (WebFrame::setMainFrameDocumentReady): (WebFrame::willChangeTitle): (WebFrame::didChangeTitle): (WebFrame::finishedLoading): (WebFrame::finalSetupForReplace): (WebFrame::setDefersLoading): (WebFrame::isArchiveLoadPending): (WebFrame::cancelPendingArchiveLoad): (WebFrame::clearArchivedResources): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::generatedMIMETypeForURLScheme): (WebFrame::frameLoadCompleted): (WebFrame::restoreScrollPositionAndViewState): (WebFrame::provisionalLoadStarted): (WebFrame::shouldTreatURLAsSameAsCurrent): (WebFrame::addHistoryItemForFragmentScroll): (WebFrame::didFinishLoad): (WebFrame::prepareForDataSourceReplacement): (WebFrame::userAgent):
WebFrame.h:
WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

9:52 PM Changeset in webkit [17652] by darin

79 edits
1 copy
1 add in trunk

WebCore:

Reviewed by Geoff.

moved loader code from Frame/FrameMac to FrameLoader

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSXSLTProcessor.h:
bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty):
bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
bindings/js/kjs_window.cpp: (KJS::Screen::Screen): (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute): (KJS::Location::getValueProperty): (KJS::Location::put): (KJS::Location::toString): (KJS::LocationFunc::callAsFunction): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
bindings/objc/DOM.mm: (+[DOMNode _nodeWith:WebCore::]):
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::setView): (WebCore::FrameMac::setStatusBarText):
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge canProvideDocumentSource]): (-[WebCoreFrameBridge receivedData:textEncodingName:]):
css/cssparser.cpp: (WebCore::CSSParser::parseContent):
dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
dom/DOMImplementation.h:
dom/Document.cpp: (WebCore::Document::readyState): (WebCore::Document::updateTitle): (WebCore::Document::open): (WebCore::Document::close): (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer): (WebCore::Document::finishedParsing):
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLTokenizer::notifyFinished):
editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
html/HTMLDocument.cpp: (WebCore::HTMLDocument::lastModified):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::willRemove):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):
html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
html/HTMLPreElement.idl:
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::stopParsing): (WebCore::HTMLTokenizer::timerFired):
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter):
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
loader/DocLoader.cpp: (WebCore::DocLoader::setLoadInProgress):
loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::cancelAll): (WebCore::getString): (WebCore::isBackForwardLoadType): (WebCore::numRequests): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stop): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::cancelRedirection): (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoading): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::gotoAnchor): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::loadDone): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::checkEmitLoadEvent): (WebCore::FrameLoader::baseURL): (WebCore::FrameLoader::baseTarget): (WebCore::FrameLoader::completeURL): (WebCore::FrameLoader::scheduleRedirection): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::isScheduledLocationChangePending): (WebCore::FrameLoader::scheduleHistoryNavigation): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::shouldUsePlugin): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::clearRecordedFormValues): (WebCore::FrameLoader::recordFormValue): (WebCore::FrameLoader::parentCompleted): (WebCore::FrameLoader::outgoingReferrer): (WebCore::FrameLoader::lastModified): (WebCore::FrameLoader::opener): (WebCore::FrameLoader::setOpener): (WebCore::FrameLoader::openedByJavaScript): (WebCore::FrameLoader::setOpenedByJavaScript): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::didNotOpenURL): (WebCore::FrameLoader::resetMultipleFormSubmissionProtection): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::canCachePage): (WebCore::FrameLoader::updatePolicyBaseURL): (WebCore::FrameLoader::setPolicyBaseURL): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::isComplete): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::url): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::stopRedirectionTimer): (WebCore::FrameLoader::updateBaseURLForEmptyDocument): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::started): (WebCore::FrameLoader::containsPlugins): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canTarget): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::hasMainResourceLoader): (WebCore::FrameLoader::isLoadingSubresources): (WebCore::FrameLoader::isLoadingPlugIns): (WebCore::FrameLoader::isLoading): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::releaseMainResourceLoader): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::timeOfLastCompletedLoad): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::open): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::isHostedByObjectElement): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::isReplacing): (WebCore::FrameLoader::setReplacing): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::loadType): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::firstLayoutDone): (WebCore::FrameLoader::isQuickRedirectComing): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::setClient): (WebCore::FrameLoader::client): (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::createEmptyDocument): (WebCore::FrameLoader::tokenizerProcessedData): (WebCore::FrameLoader::didTellBridgeAboutLoad): (WebCore::FrameLoader::haveToldBridgeAboutLoad): (WebCore::FrameLoader::handledOnloadEvents): (WebCore::FrameLoader::frameDetached): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoaderClient::~FrameLoaderClient):
loader/FrameLoader.h: (WebCore::):
loader/FrameLoaderClient.h:
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): (WebCore::PluginTokenizer::writeRawData):
loader/ResourceLoader.h:
loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
loader/loader.cpp: (WebCore::Loader::didReceiveResponse):
loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setPrimaryLoadComplete):
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::objectContentType): (WebCore::nsArray): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFinishLoad):
loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): (WebCore::CheckCacheObjectStatus):
loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::cancel):
loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
loader/qt/FrameLoaderQt.cpp: Added. (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::originalRequestURL):
page/DOMWindow.cpp: (WebCore::DOMWindow::document):
page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::shouldDragAutoNode): (WebCore::Frame::prepareForUserAction): (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
page/Frame.h:
page/FramePrivate.h:
page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::mediaType):
page/FrameView.h:
page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restoreJavaScriptState):
platform/mac/CookieJar.mm: (WebCore::setCookies):
platform/mac/TextCodecMac.cpp:
platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
platform/qt/FrameQt.cpp:
platform/qt/FrameQt.h:
rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
rendering/RenderBlock.h:
rendering/RenderPartObject.cpp: (WebCore::isURLAllowed): (WebCore::RenderPartObject::updateWidget):
xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML):

WebKit:

Reviewed by Geoff.

udpated for changes to move from Frame/FrameMac to FrameLoader

DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
Plugins/WebNetscapePluginStream.mm:
Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::provisionalLoadStarted):
WebView/WebFrame.mm: (-[WebFrame _canCachePage]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame stopLoading]):

7:36 PM Coding Style Guidelines edited by Adam Roben

(diff)

7:05 PM Changeset in webkit [17651] by andersca

11 edits in trunk

WebCore:

Reviewed by Geoff.

Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::registerCommandForUndoOrRedo):
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]): (-[WebCoreFrameBridge selectionGranularity]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]): (-[WebCoreFrameBridge applyStyle:withUndoAction:]): (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
editing/SelectionController.cpp: (WebCore::SelectionController::setModifyBias): (WebCore::SelectionController::modify):
editing/SelectionController.h: (WebCore::SelectionController::):
editing/TextGranularity.h:

WebKit:

Reviewed by Geoff.

Use the WebCore editing enums.

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge undoNameForEditAction:]):
WebView/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]): (-[WebHTMLView _deleteSelection]): (-[WebHTMLView moveBackward:]): (-[WebHTMLView moveBackwardAndModifySelection:]): (-[WebHTMLView moveDown:]): (-[WebHTMLView moveDownAndModifySelection:]): (-[WebHTMLView moveForward:]): (-[WebHTMLView moveForwardAndModifySelection:]): (-[WebHTMLView moveLeft:]): (-[WebHTMLView moveLeftAndModifySelection:]): (-[WebHTMLView moveRight:]): (-[WebHTMLView moveRightAndModifySelection:]): (-[WebHTMLView moveToBeginningOfDocument:]): (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): (-[WebHTMLView moveToBeginningOfSentence:]): (-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]): (-[WebHTMLView moveToBeginningOfLine:]): (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]): (-[WebHTMLView moveToBeginningOfParagraph:]): (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): (-[WebHTMLView moveToEndOfDocument:]): (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): (-[WebHTMLView moveToEndOfSentence:]): (-[WebHTMLView moveToEndOfSentenceAndModifySelection:]): (-[WebHTMLView moveToEndOfLine:]): (-[WebHTMLView moveToEndOfLineAndModifySelection:]): (-[WebHTMLView moveToEndOfParagraph:]): (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): (-[WebHTMLView moveParagraphBackwardAndModifySelection:]): (-[WebHTMLView moveParagraphForwardAndModifySelection:]): (-[WebHTMLView moveUp:]): (-[WebHTMLView moveUpAndModifySelection:]): (-[WebHTMLView moveWordBackward:]): (-[WebHTMLView moveWordBackwardAndModifySelection:]): (-[WebHTMLView moveWordForward:]): (-[WebHTMLView moveWordForwardAndModifySelection:]): (-[WebHTMLView moveWordLeft:]): (-[WebHTMLView moveWordLeftAndModifySelection:]): (-[WebHTMLView moveWordRight:]): (-[WebHTMLView moveWordRightAndModifySelection:]): (-[WebHTMLView pageUp:]): (-[WebHTMLView pageDown:]): (-[WebHTMLView pageUpAndModifySelection:]): (-[WebHTMLView pageDownAndModifySelection:]): (-[WebHTMLView _expandSelectionToGranularity:]): (-[WebHTMLView selectParagraph:]): (-[WebHTMLView selectLine:]): (-[WebHTMLView selectSentence:]): (-[WebHTMLView selectWord:]): (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]): (-[WebHTMLView _toggleBold]): (-[WebHTMLView _toggleItalic]): (-[WebHTMLView pasteFont:]): (-[WebHTMLView changeFont:]): (-[WebHTMLView changeAttributes:]): (-[WebHTMLView _undoActionFromColorPanelWithSelector:]): (-[WebHTMLView changeColor:]): (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): (-[WebHTMLView alignCenter:]): (-[WebHTMLView alignJustified:]): (-[WebHTMLView alignLeft:]): (-[WebHTMLView alignRight:]): (-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]): (-[WebHTMLView deleteForward:]): (-[WebHTMLView deleteBackward:]): (-[WebHTMLView deleteWordForward:]): (-[WebHTMLView deleteWordBackward:]): (-[WebHTMLView deleteToBeginningOfLine:]): (-[WebHTMLView deleteToEndOfLine:]): (-[WebHTMLView deleteToBeginningOfParagraph:]): (-[WebHTMLView deleteToEndOfParagraph:]): (-[WebHTMLView subscript:]): (-[WebHTMLView superscript:]): (-[WebHTMLView unscript:]): (-[WebHTMLView underline:]): (-[WebHTMLView deleteToMark:]): (-[WebHTMLView toggleBaseWritingDirection:]): (-[WebHTMLView changeBaseWritingDirection:]): (-[WebHTMLView _canSmartCopyOrDelete]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
WebView/WebView.mm: (-[WebView setTypingStyle:]): (-[WebView applyStyle:]):

5:34 PM WikiStart edited by pewtermoose@gmail.com

Add link to Web Inspector (diff)

5:33 PM Web Inspector created by pewtermoose@gmail.com

5:18 PM Coding Style Guidelines edited by bdash@webkit.org

(diff)

5:13 PM Coding Style Guidelines edited by sam@webkit.org

Add ToC (diff)

5:12 PM Coding Style Guidelines edited by sam@webkit.org

(diff)

5:02 PM Nightly Builds edited by bdash@webkit.org

(diff)

5:01 PM WikiStart edited by bdash@webkit.org

Remove outdated link (diff)

4:52 PM Coding Style Guidelines edited by sam@webkit.org

Finish port of Coding Style Guidelines (diff)

4:52 PM Changeset in webkit [17650] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

Changed the check for "top level frame" to something much more valid

page/Frame.cpp: (WebCore::Frame::endIfNotLoading):

4:25 PM Coding Style Guidelines edited by sam@webkit.org

More Code Style Guidlines porting (diff)

4:21 PM Changeset in webkit [22487] by andersca

8 edits in branches/WindowsMerge

WebCoreWin:

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Let the Frame client know when the window object is available.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::partClearedInBegin):
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::unfocusWindow): (FrameWin::markMisspellings): (FrameWin::restoreDocumentState):

WebKitWin:

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Call IWebFrameLoadDelegate::windowScriptObject available when the
window script object is available.

Interfaces/IWebFrameLoadDelegate.idl: Get MIDL to understand the JSC API types.

WebFrame.cpp: (WebFrame::windowScriptObjectAvailable): Call into the delegate.

WebFrame.h:

4:06 PM Coding Style Guidelines created by sam@webkit.org

First wack at transfering Style Guildlines to the Wiki

3:52 PM Changeset in webkit [17649] by andersca

2 edits in trunk/JavaScriptCore

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Initialize cachedPrototype to 0.

3:42 PM Changeset in webkit [22486] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

platform/win/TemporaryLinkStubs.cpp: Remove no-longer-needed stub.

3:39 PM WikiStart edited by sam@webkit.org

(diff)

3:05 PM Applications using WebKit edited by bradley.morrison@nokia.com

added web browser for s60 (diff)

2:44 PM Changeset in webkit [17648] by harrison

4 edits in trunk/LayoutTests

Updated.

editing/pasteboard/4076267-2-expected.checksum:
editing/pasteboard/4076267-2-expected.png:
editing/pasteboard/4076267-2-expected.txt:

2:24 PM Changeset in webkit [17647] by bdakin

2 edits in trunk/WebCore

Reviewed by Hyatt (yesterday).

Here is part of my patch from yesterday that is safe to roll back
in. It will make the BuildBot happy.

rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Null-check m_innerNonSharedNode.

1:07 PM Changeset in webkit [17646] by darin

2 edits in trunk/WebCore

loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): Comment grammar fix.

1:05 PM Changeset in webkit [17645] by darin

6 edits
6 deletes in trunk

LayoutTests:

Rolled out change for <rdar://problem/4820814>.

Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.

WebCore:

Rolled out change for <rdar://problem/4820814>.

Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.

12:41 PM Changeset in webkit [17644] by darin

6 edits
1 delete in trunk/WebCore

Reviewed by Brady.

fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher crashes on launch in WebCore::ResourceLoader::start

No layout test, because this depends on cached icons, although there's
perhaps a way to write a test for it with some further ingenuity.

loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable to make explicit the fact that it can't be successfully copied. Remove notifyIconChanged function and put the contents in the caller. This eliminates the need for IconLoaderMac.mm. Added finishedLoading and clearLoadingState functions to share code. Removed m_url, since the resource handle already stores the URL. Renamed m_resourceLoader to m_handle to reflect the class's name change. Removed the 4096-byte inline buffer from m_data, since the malloc savings is not sufficient to offset the additional memory use. Removed m_httpStatusCode because we can instead cancel the load when we get a status code that reflects failure. Added m_loadIsInProgress boolean because we need to detect loads that complete during the ResourceHandle::create function call.

loader/icon/IconLoader.cpp: (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress. Don't initialize m_httpStatusCode. (WebCore::IconLoader::~IconLoader): Updated for name change. (WebCore::IconLoader::startLoading): Added code to use the m_loadIsInProgress flag to detect if the load completed while inside the ResourceHandle::create function. Removed code to set m_url. (WebCore::IconLoader::stopLoading): Call clearLoadingState to share more code. (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle and finish loading if the HTTP status code indicates failure. (WebCore::IconLoader::didReceiveData): Removed assertion that checks the ResourceHandle, since we can't do that any more. (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading so we can share code with the new didReceiveResponse code path. (WebCore::IconLoader::finishLoading): Moved code here from the didFinishLoading callback. Pass a URL when calling commitIconURLToIconDatabase. Call notifyIconChanged directly here instead of using a separate function. Call clearLoadingState to share more code with stopLoading. (WebCore::IconLoader::clearLoadingState): Added.

loader/mac/IconLoaderMac.mm: Removed.
WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.

11:32 AM Changeset in webkit [17643] by harrison

12 edits
1 delete in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)

editing/pasteboard/3976872-expected.txt:
editing/pasteboard/4076267-2-expected.txt:
editing/pasteboard/4076267-3-expected.txt:
editing/pasteboard/4076267-expected.txt:
editing/pasteboard/8145-1-expected.txt:
editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
editing/pasteboard/paste-match-style-001-expected.txt:
editing/pasteboard/paste-match-style-002-expected.txt:
editing/pasteboard/paste-text-019-expected.txt:
editing/pasteboard/pasting-tabs-expected.txt:

WebCore:

Reviewed by Darin.

<rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)

editing/pasteboard/3976872-expected.txt:
editing/pasteboard/4076267-2-expected.txt:
editing/pasteboard/4076267-3-expected.txt:
editing/pasteboard/4076267-expected.txt:
editing/pasteboard/8145-1-expected.txt:
editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
editing/pasteboard/paste-match-style-001-expected.txt:
editing/pasteboard/paste-match-style-002-expected.txt:
editing/pasteboard/paste-text-019-expected.txt:
editing/pasteboard/pasting-tabs-expected.txt: Updated because pasting text with no newlines does not use intermediate div.

editing/markup.cpp: (WebCore::fillContainerFromString): First parameter is now a Container so a fragment can be passed.

(WebCore::createFragmentFromText):
A string with no newlines gets added inline, rather than being put into a paragraph.

10:39 AM Changeset in webkit [17642] by ap

1 edit
4 adds in trunk/LayoutTests

2006-11-07 Mitz Pettel <mitz@webkit.org>

Reviewed by Beth.

Test for http://bugs.webkit.org/show_bug.cgi?id=11505
REGRESSION: Null pointer deref in HitTestResult::spellingToolTip() (assertion failure in Node::document)

The null check was added as part for the fix for <rdar://problem/4820814>,
however the test that was committed with the fix avoids the case of a null
m_innerNonSharedNode, which this test covers.

fast/css-generated-content/spellingToolTip-assert-expected.checksum: Added.
fast/css-generated-content/spellingToolTip-assert-expected.png: Added.
fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
fast/css-generated-content/spellingToolTip-assert.html: Added.

2:47 AM Changeset in webkit [17641] by bdash

2 edits in trunk/WebKitSite

2006-11-07 Mark Rowe <bdash@webkit.org>

Reviewed by Dave Hyatt.

projects/javascript/index.html: Update link to non-existent JavaScript Bugzilla component to the correct JavaScriptCore.

Context Navigation

Timeline

Nov 8, 2006:

Nov 7, 2006:

Download in other formats: