Context Navigation

← Previous Period
Next Period →

Timeline

Nov 9, 2006:

11:33 PM Changeset in webkit [22512] by oliver

4 edits
1 add in branches/WindowsMerge/WebCore

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Brady.

Added Windows side of MIME Type registry, and updated
objectContentType and ImageWin to make use of it

This fixes <rdar://problem/4791483>

WebCore.vcproj/WebCore.vcproj:
loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::objectContentType):
platform/win/ImageWin.cpp:
platform/win/MimeTypeRegistryWin.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::mimeTypeForExtension): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):

11:31 PM Changeset in webkit [17701] by oliver

14 edits
5 adds in trunk

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Brady.

Pulled MIME type handling out of WebFrameBridge and added
a general C++ class to store/query MIME info
Added an Obj-C bridge to provide WebKit with access to the
MimeTypeRegistry for non-Obj-C++ classes.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm:
bridge/mac/WebMimeTypeRegistryBridge.h: Added.
bridge/mac/WebMimeTypeRegistryBridge.mm: Added. (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
platform/Image.cpp: (WebCore::Image::supportsType):
platform/Image.h:
platform/MimeTypeRegistry.cpp: Added. (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes): (WebCore::initialiseMimeTypeRegistry): (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes): (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
platform/MimeTypeRegistry.h: Added.
platform/mac/ImageMac.mm:
platform/mac/MimeTypeRegistryMac.mm: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):

Updated to make use of MimeTypeRegistry/bridge

Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithArchive:]):
WebView/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]):
WebView/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): (-[WebHTMLView _documentFragmentWithPaths:]):

9:17 PM Changeset in webkit [17700] by mjs

28 edits in trunk/WebCore

Reviewed by Oliver.

rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size for you and use vsnprintf.

bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
css/cssparser.cpp: (WebCore::CSSParser::parseColorFromValue):
dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::handleError):
ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
ksvg2/svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::toString): (WebCore::SVGPathSegArcRel::toString):
ksvg2/svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::toString): (WebCore::SVGPathSegCurvetoCubicRel::toString):
ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString): (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
ksvg2/svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::toString): (WebCore::SVGPathSegLinetoRel::toString):
ksvg2/svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::toString): (WebCore::SVGPathSegLinetoHorizontalRel::toString):
ksvg2/svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::toString): (WebCore::SVGPathSegLinetoVerticalRel::toString):
ksvg2/svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::toString): (WebCore::SVGPathSegMovetoRel::toString):
ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange):
ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::closeRenderer):
loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setSynchronous):
platform/Color.cpp: (WebCore::Color::name):
platform/DeprecatedString.cpp: (WebCore::DeprecatedString::setNum): (WebCore::DeprecatedString::format):
platform/DeprecatedString.h:
platform/PlatformString.h:
platform/String.cpp: (WebCore::String::format): (WebCore::String::number):
platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::calcMinMaxWidth):

8:14 PM Changeset in webkit [22511] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

6:27 PM Changeset in webkit [22510] by oliver

2 edits in branches/WindowsMerge/WebKitWin

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

Fix crash on unknown protocol

WebFrame.cpp: (WebFrame::didFailWithError):

6:03 PM Changeset in webkit [22509] by lamadio

4 edits in branches/WindowsMerge

2006-11-09 Lou Amadio <lamadio@apple.com>

Reviewed by mjs
Correct the broken search implementations based on original webkit
<rdar://4827714>

4:30 PM Changeset in webkit [17699] by mjs

2 edits in trunk/WebCore

Reviewed by Anders.

fixed "Regression: Can't log into gmail.com"
fixed "iBench doesn't report results - tests run but no number is recorded"

platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): Removed extra ! character.

3:21 PM Changeset in webkit [17698] by beidson

3 edits in trunk/WebKit

Reviewed by Darin

<rdar://problem/4829080>
More loader re-factoring cleanup - WebFramePolicyListener was over-released

WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<>
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto (WebFrameLoaderClient::setUpPolicyListener): Ditto (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto

2:58 PM Changeset in webkit [17697] by bdakin

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in
WebCore::RenderBlock::skipWhitespace

Note that this will still crash on Debug builds because it will hit
an assertion failure in editing. (One of the reasons there is no
layout test along with this fix.) There is definitely some editing
wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
id=10144 for updates on the assertion failure bug.

rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::childRemoved): It is possible for a prevRootBox and its prevRootBox to share a lineBreakObj. So instead of just clearing the lineBreakObj of the prevRootBox, cycle through all prevRootBoxs with the same lineBreakObj.

2:30 PM Changeset in webkit [22508] by aroben

3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Put the OpenSource revision in the WebKit.dll version info.

2:06 PM Changeset in webkit [17696] by spadma

2 edits in S60/branches/3.1m/WebKit

2006-11-09 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
http://bugs.webkit.org/show_bug.cgi?id=11556

BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):

2:05 PM Changeset in webkit [17695] by spadma

2 edits in S60/trunk/WebKit

2006-11-09 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
http://bugs.webkit.org/show_bug.cgi?id=11556

BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):

1:48 PM Changeset in webkit [17694] by thatcher

1 edit in trunk/WebKit/WebCoreSupport/WebEditorClient.mm

Build fix.

1:40 PM Changeset in webkit [17693] by zbujtas

2 edits in S60/trunk/WebCore

2006-11-09 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414

kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):

1:37 PM Changeset in webkit [17692] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2006-11-09 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414

kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):

1:11 PM Changeset in webkit [22507] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Fix line-endings.

WebEditorClient.cpp:

12:54 PM Changeset in webkit [22506] by oliver

3 edits in branches/WindowsMerge/WebKitWin

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Anders.

Build fixes

WebEditorClient.cpp: (WebEditorClient::respondToChangedContents):
WebEditorClient.h:

12:51 PM Changeset in webkit [17691] by aroben

3 edits
1 copy
3 adds in trunk

LayoutTests:

Reviewed by Geoff.

New test to keep the mistake I made in r17680 from happening again.

fast/block/margin-collapse/negative-margins-expected.checksum: Added.
fast/block/margin-collapse/negative-margins-expected.png: Added.
fast/block/margin-collapse/negative-margins-expected.txt: Added.
fast/block/margin-collapse/negative-margins.html: Added.

WebCore:

Reviewed by Geoff.

Fix the change in behavior I caused in r17680 with my build fix.

rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):

11:48 AM Changeset in webkit [17690] by andersca

15 edits in trunk

WebCore:

Reviewed by Adam, Oliver.

Move more functions to Editor.

bridge/EditorClient.h:
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm:
bridge/mac/WebCoreFrameBridge.h:
editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): (WebCore::dispatchEditableContentChangedEvents): (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
editing/Editor.h:
editing/TypingCommand.cpp: (WebCore::TypingCommand::typingAddedToOpenCommand):
page/Frame.cpp:
page/Frame.h:

WebKit:

Reviewed by Adam, Oliver.

Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
instead of just passing the WebView.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame): (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::respondToChangedContents): (WebEditorClient::didEndEditing):
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):

11:00 AM Changeset in webkit [22505] by lamadio

3 edits in branches/WindowsMerge/WebCore

2006-11-08 Lou Amadio <lamadio@apple.com>

Reviewed by ggaren

Moved CookieJar to OpenSourceWin
Ported CookieJar to CFNetwork
Corrected an uninitialized variable which crashed on Vista in the Wininet code

WebCore.vcproj/WebCore.vcproj:
platform/network/win/CookieJarWin.cpp:

8:31 AM Changeset in webkit [17689] by darin

2 edits in trunk/WebCore

rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.

8:17 AM Changeset in webkit [17688] by aliceli1

2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
All existing layout tests pass

html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::deleteRow): check lastSection before deleting row

7:41 AM Changeset in webkit [17687] by darin

3 edits in trunk/WebCore

improved version of last night's build fix (should not do using namespace in a header)

rendering/RenderObject.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):

7:38 AM Changeset in webkit [17686] by spadma

2 edits in S60/branches/3.1m/WebKit

2006-11-08 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=11552

ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):

7:34 AM Changeset in webkit [17685] by spadma

2 edits in S60/trunk/WebKit

2006-11-08 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=11552

ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):

7:27 AM Changeset in webkit [17684] by spadma

2 edits in S60/branches/3.1m/WebKit

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
http://bugzilla.opendarwin.org/show_bug.cgi?id=11539

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

7:24 AM Changeset in webkit [17683] by spadma

2 edits in S60/trunk/WebKit

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
http://bugs.webkit.org/show_bug.cgi?id=11539

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

Nov 8, 2006:

11:31 PM Changeset in webkit [22504] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Make the same change here as made in r11013.

11:13 PM Changeset in webkit [22503] by mjs

7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

added ResourceError class and didFailWithError client method

plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFailLoadingWithError): (WebCore::PluginStreamWin::didFinishLoading):
plugins/win/PluginStreamWin.h:

WebKitWin:

Reviewed by Geoff.

added ResourceError class and didFailWithError client method

WebFrame.cpp: (WebFrame::didFinishLoading): (WebFrame::didFailWithError):
WebFrame.h:

10:49 PM Changeset in webkit [17682] by mjs

16 edits
3 adds in trunk

Reviewed by Geoff.

added ResourceError class and didFailWithError client method

WebCore.xcodeproj/project.pbxproj:
loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading):
loader/icon/IconLoader.h:
loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError):
loader/loader.h:
loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptCFReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adopt):
platform/network/ResourceError.cpp: Added.
platform/network/ResourceError.h: Added. (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
platform/network/ResourceHandle.cpp:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFailWithError):
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::cancel):
platform/network/mac/ResourceErrorMac.mm: Added. (-[NSError WebCore]):
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::reportError):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading):
xml/xmlhttprequest.h:

10:39 PM Changeset in webkit [17681] by bdash

9 edits
1 add in trunk/WebCore

2006-11-08 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\Gdk fixes.

platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::~ChromeClientGdk):
platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor): (WebCore::moveCursor):
platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
platform/gdk/PageGdk.cpp:
platform/gdk/ScreenClientGdk.h: Added. (WebCore::ScreenClientGdk::~ScreenClientGdk):
platform/gdk/ScreenGdk.cpp: (WebCore::ScreenClientGdk::depth): (WebCore::ScreenClientGdk::depthPerComponent): (WebCore::ScreenClientGdk::isMonochrome): (WebCore::ScreenClientGdk::rect): (WebCore::ScreenClientGdk::usableRect):
platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::historyURL): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable):
platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::client):
platform/network/gdk/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove):

9:58 PM Changeset in webkit [17680] by aroben

2 edits in trunk/WebCore

Build fix.

rendering/RenderObject.h: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):

9:22 PM Changeset in webkit [22502] by ggaren

3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Updated Windows to use the new platform abstraction for Screen.

WebCore.vcproj/WebCore.vcproj:
platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize):
platform/win/ScreenWin.cpp: (WebCore::monitorInfoForWidget): (WebCore::deviceInfoForWidget): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

9:18 PM Changeset in webkit [17679] by brmorris

1 edit in S60/trunk/README.txt

Updating README.txt to point to new wiki location.

9:18 PM Changeset in webkit [17678] by ggaren

7 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Made Screen a good platform citizen by removing its reference to Page. This
made a class unnecessary, so all screen fuctions are stand-alone now.

bindings/js/kjs_window.cpp: Removed unnecessary subtractions when computing the screen's available dimensions.

7:55 PM Changeset in webkit [17677] by weinig

3 edits in trunk/WebCore

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
Cleanup RenderObject

rendering/RenderObject.cpp: (WebCore::RenderObject::operator delete): (WebCore::RenderObject::createObject): (WebCore::RenderObjectCounter::~RenderObjectCounter): (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::isDescendantOf): (WebCore::RenderObject::isRoot): (WebCore::RenderObject::addChild): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::removeChild): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::nextInPreOrder): (WebCore::RenderObject::nextInPreOrderAfterChildren): (WebCore::RenderObject::previousInPreOrder): (WebCore::RenderObject::isEditable): (WebCore::RenderObject::nextEditable): (WebCore::RenderObject::previousEditable): (WebCore::RenderObject::firstLeafChild): (WebCore::RenderObject::lastLeafChild): (WebCore::RenderObject::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::updateFirstLetter): (WebCore::RenderObject::offsetParent): (WebCore::RenderObject::scroll): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::markContainingBlocksForLayout): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::containingBlockWidth): (WebCore::RenderObject::containingBlockHeight): (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::addPDFURLRect): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::repaintObjectsBeforeLayout): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::information): (WebCore::RenderObject::dump): (WebCore::selectStartNode): (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::createAnonymousBlock): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::setStyleInternal): (WebCore::RenderObject::updateBackgroundImages): (WebCore::RenderObject::absolutePosition): (WebCore::RenderObject::caretRect): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight): (WebCore::RenderObject::tabWidth): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy): (WebCore::RenderObject::arenaDelete): (WebCore::RenderObject::hitTest): (WebCore::RenderObject::setInnerNode): (WebCore::RenderObject::nodeAtPoint): (WebCore::RenderObject::verticalPositionHint): (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::invalidateVerticalPositions): (WebCore::RenderObject::recalcMinMaxWidths): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::setInlineBoxWrapper): (WebCore::RenderObject::firstLineStyle): (WebCore::RenderObject::getPseudoStyle): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::collectDashboardRegions): (WebCore::RenderObject::avoidsFloats): (WebCore::RenderObject::findCounter): (WebCore::RenderObject::backslashAsCurrencySymbol): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::previousOffset): (WebCore::RenderObject::nextOffset): (WebCore::RenderObject::inlineBox):
rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::renderName): (WebCore::RenderObject::parent): (WebCore::RenderObject::previousSibling): (WebCore::RenderObject::nextSibling): (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::getOverflowClipRect): (WebCore::RenderObject::getClipRect): (WebCore::RenderObject::getBaselineOfFirstLineBox): (WebCore::RenderObject::setEdited): (WebCore::RenderObject::setStaticX): (WebCore::RenderObject::setStaticY): (WebCore::RenderObject::setPreviousSibling): (WebCore::RenderObject::setNextSibling): (WebCore::RenderObject::setParent): (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::isRenderView): (WebCore::RenderObject::childrenInline): (WebCore::RenderObject::setChildrenInline): (WebCore::RenderObject::isAnonymousBlock): (WebCore::RenderObject::isDragging): (WebCore::RenderObject::needsLayout): (WebCore::RenderObject::setMinMaxKnown): (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc): (WebCore::RenderObject::setPositioned): (WebCore::RenderObject::setRelPositioned): (WebCore::RenderObject::setFloating): (WebCore::RenderObject::setInline): (WebCore::RenderObject::setShouldPaintBackgroundOrBorder): (WebCore::RenderObject::setReplaced): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::calcWidth): (WebCore::RenderObject::updateFromElement): (WebCore::RenderObject::RepaintInfo::RepaintInfo): (WebCore::RenderObject::setOverrideSize): (WebCore::RenderObject::setPos): (WebCore::RenderObject::setWidth): (WebCore::RenderObject::setHeight): (WebCore::RenderObject::absolutePositionForContent): (WebCore::RenderObject::overflowHeight): (WebCore::RenderObject::overflowWidth): (WebCore::RenderObject::setOverflowHeight): (WebCore::RenderObject::setOverflowWidth): (WebCore::RenderObject::overflowLeft): (WebCore::RenderObject::overflowTop): (WebCore::RenderObject::overflowRect): (WebCore::RenderObject::stopAutoscroll): (WebCore::RenderObject::collapsedMarginTop): (WebCore::RenderObject::collapsedMarginBottom): (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin): (WebCore::RenderObject::): (WebCore::RenderObject::setTable): (WebCore::RenderObject::isFloatingOrPositioned): (WebCore::RenderObject::containsFloat): (WebCore::RenderObject::setSelectionState): (WebCore::RenderObject::SelectionInfo::SelectionInfo): (WebCore::RenderObject::lowestPosition): (WebCore::RenderObject::rightmostPosition): (WebCore::RenderObject::leftmostPosition): (WebCore::RenderObject::calcVerticalMargins): (WebCore::RenderObject::font):

6:21 PM Changeset in webkit [22501] by darin

4 edits in branches/WindowsMerge/WebCore

fix the build

bridge/win/FrameWin.h: Add a forward declaration of FormData.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Call resetMultipleFormSubmissionProtection instead of prepareForUserAction.

platform/win/TemporaryLinkStubs.cpp: Remove the parameter from the TextField constructor.

6:18 PM Changeset in webkit [17676] by zbujtas

2 edits in S60/trunk/WebCore

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by zalan.
merged from 3.1m 17675
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
http://bugs.webkit.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

6:07 PM Changeset in webkit [17675] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by zalan.
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
http://bugzilla.opendarwin.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):

6:00 PM Changeset in webkit [22500] by aroben

3 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebEditorClient.cpp: Added stubs for new methods from EditorClient.h. (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
WebEditorClient.h: Added new methods from EditorClient.h and cleaned up placement of *s.

6:00 PM Changeset in webkit [17674] by darin

30 edits
2 adds in trunk

LayoutTests:

Reviewed by Anders.

added test for option-tab

fast/events/option-tab.html: Added.
fast/events/option-tab-expected.txt: Added.

WebCore:

Reviewed by Anders.

added event parameters to focus-related functions so we can implement the "option-tab to all links" behavior without relying on a global "current event" -- also makes it work with DOM events

page/Frame.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
page/Frame.cpp: (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from PlatformKeyboardEvent to the DOM keyboard event class. (WebCore::Frame::tabsToLinks): Added event parameter. (WebCore::Frame::tabsToAllControls): Ditto. (WebCore::scanForForm): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (WebCore::Frame::hitTestResultAtPoint): Ditto.

bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
bridge/mac/FrameMac.mm: (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of a PlatformKeyboardEvent. (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent() and pass event into next/previousFocusNode. (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from the AppKit current event, if it's a keyboard event. Really just a hack that's needed to preserve some code we can remove once we deal with the last NSView- based form control. (WebCore::isKeyboardOptionTab): Added. (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the option (alt) key is down. (WebCore::FrameMac::tabsToAllControls): Ditto. (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just call resetMultipleFormSubmissionProtection() explicitly instead. (WebCore::FrameMac::mouseDown): Ditto.

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to prepareForUserAction() to call resetMultipleFormSubmissionProtection() explicitly instead.

page/FrameView.h:
page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Changed function to take an event parameter, and decide the direction based on the shift key modifier instead of a passed-in boolean.

dom/Document.h:
dom/Document.cpp: (WebCore::Document::nextFocusNode): Added event parameter. (WebCore::Document::previousFocusNode): Ditto.
dom/Node.h:
dom/Node.cpp: (WebCore::Node::isKeyboardFocusable): Ditto.
html/HTMLAnchorElement.h:
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
html/HTMLGenericFormElement.h:
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
html/HTMLInputElement.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
html/HTMLSelectElement.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
html/HTMLTextAreaElement.h:
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Pass event to the advanceFocus function.

platform/TextField.h:
platform/mac/TextFieldMac.mm: Removed the non-search field code.

platform/mac/WebCoreTextField.h:
platform/mac/WebCoreTextField.mm: Removed the non-search field code. (-[WebCoreTextFieldController controlTextDidChange:]): Removed the call to FrameMac::handleKeyboardOptionTabInView, which is no longer needed since the default handler in HTMLInputElement takes care of option-tab.

platform/mac/SliderMac.mm: (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent() and pass event into tabsToAllControls. (Slider::focusPolicy): Ditto.

rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code. (WebCore::RenderLineEdit::updateFromElement): Ditto.

5:41 PM Changeset in webkit [22499] by sfalken

2 edits in branches/WindowsMerge/WebCore

5:33 PM Changeset in webkit [17673] by darin

2 edits in trunk/WebKitTools

Reviewed by Anders.

same change as below, only tested this time

DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links" mode off. I think we need to do this because WebPreferences saves things for us automatically. It would be good to turn that off for DumpRenderTree, but for now lets handle this like the other preferences (set it explicitly each time).

5:21 PM Changeset in webkit [17672] by darin

2 edits in trunk/WebKitTools

Reviewed by Anders.

DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on "tab to links" mode. No current tests depend on this, and there's a new test I want to land that depends on the default setting.

5:16 PM Changeset in webkit [17671] by beidson

2 edits in trunk/WebCore

Reviewed by Dave Harrison, Oliver, and Darin
(oh my! where was superkevin on this one?)

<rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)

More "free nil checking" we lost in the transition from ObjC to C++

loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto

4:51 PM Changeset in webkit [17670] by andersca

19 edits in trunk

WebCore:

Reviewed by Adam.

Move more code into editor.

WebCore.exp:
bridge/EditorClient.h:
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm:
bridge/mac/WebCoreFrameBridge.h:
dom/Document.cpp: (WebCore::Document::relinquishesEditingFocus): (WebCore::Document::acceptsEditingFocus): (WebCore::Document::didBeginEditing): (WebCore::Document::didEndEditing):
editing/Editor.cpp: (WebCore::Editor::indent): (WebCore::Editor::outdent):
editing/Editor.h:
page/Frame.cpp:
page/Frame.h:

WebKit:

Reviewed by Adam.

Move more code into editor.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
WebCoreSupport/WebFrameBridge.mm:
WebView/WebHTMLView.m: (-[NSArray indent:]): (-[NSArray outdent:]):
WebView/WebView.mm:
WebView/WebViewInternal.h:

4:41 PM Changeset in webkit [22498] by bdakin

3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Add clause for new WebElementIsContentEditableKey to the Read
fucntion.

Interfaces/IWebView.idl:
WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):

2:58 PM Changeset in webkit [17669] by bdakin

9 edits in trunk

WebCore:

Reviewed by Adam.

Add ability to HitTestResult to ask if the inner non-shared node is
content editable.

WebCore.exp: Export HitTestResult::isContentEditable()
rendering/HitTestResult.cpp: (WebCore::HitTestResult::isContentEditable):
rendering/HitTestResult.h:

WebKit:

Reviewed by Adam.

Add WebElementIsContentEditableKey to the WebElementDictionary, and
use it!

DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Use new WebElementIsContentEditableKey.
Misc/WebElementDictionary.m: (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary _isContentEditable]): Call into HitTestResult::isContentEditable()
WebView/WebView.mm: Add new key.
WebView/WebViewPrivate.h: Add new key.

2:50 PM Changeset in webkit [17668] by andersca

2 edits in trunk/WebCore

Build fix.

WebCore.xcodeproj/project.pbxproj: Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.

2:32 PM Coding Style Guidelines edited by sam@webkit.org

(diff)

2:24 PM Changeset in webkit [17667] by thatcher

12 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
<rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection

Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.

bindings/objc/DOM.mm: (WebCore::kit): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):
bindings/objc/DOMPrivate.h:
dom/Range.cpp: (WebCore::Range::boundingBox): (WebCore::Range::addLineBoxRects):
dom/Range.h:
rendering/RenderContainer.cpp: (WebCore::RenderContainer::addLineBoxRects):
rendering/RenderContainer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects):
rendering/RenderObject.h:
rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
rendering/RenderText.h:

1:57 PM Changeset in webkit [22497] by adachan

6 edits in branches/WindowsMerge

1:57 PM Changeset in webkit [17666] by andersca

18 edits in trunk

WebCore:

Reviewed by Oliver.

Move methods from the bridge and frame into editor.

WebCore.exp:
bridge/EditorClient.h:
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm:
editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::Editor::toggleBold): (WebCore::Editor::toggleItalic): (WebCore::Editor::selectionStartHasStyle):
editing/Editor.h:
editing/JSEditor.cpp:
page/Frame.cpp:
page/Frame.h:

WebKit:

Reviewed by Oliver.

Call into the WebCore editor object directly.

MigrateHeaders.make:
WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle):
WebView/WebFrame.mm: (core): (kit):
WebView/WebFrameInternal.h:
WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]): (-[NSArray _changeCSSColorUsingSelector:inRange:]): (-[NSArray underline:]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
WebView/WebView.mm: (-[WebView applyStyle:]):

1:30 PM Changeset in webkit [17665] by andersca

2 edits in trunk/WebKit

Reviewed by Oliver.

<rdar://problem/4825370>
REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app

WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Initialize the framework pointer to 0.

1:26 PM Changeset in webkit [22496] by lamadio

10 edits in branches/WindowsMerge

1:20 PM Changeset in webkit [17664] by adachan

2 edits in trunk/JavaScriptCore

2006-11-08 Ada Chan <adachan@apple.com>

Reviewed by darin.

Added a method to delete all the keys in a HashMap.

12:14 PM Changeset in webkit [17663] by ggaren

4 edits in trunk/WebCore

Reviewed by Beth.

Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
be able to dispatch user events even when off-screen, so we have to support
off-screen windows when handling mouse events.

platform/Screen.h:
platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint): Grab the best screen instead of the screen you're on, since you might be off-screen.
platform/mac/ScreenMac.mm: (WebCore::screenForWindow):

11:47 AM Changeset in webkit [22495] by andersca

5 edits
3 adds in branches/WindowsMerge/WebKitTools

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

Fix the build. Hook up a layoutTestController and implement dumpAsText, waitUntilDone and notifyDone.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): (main):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Added. (dumpAsTextCallback): (waitUntilDoneCallback): (notifyDoneCallback): (getClass): (createLayoutTestController):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Added.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didFinishLoadForFrame): (WaitUntilDoneDelegate::windowScriptObjectAvailable):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction):

11:13 AM Changeset in webkit [22494] by andersca

5 edits in branches/WindowsMerge

WebCoreWin:

2006-11-08 Anders Carlsson <acarlsson@apple.com>

Build fixes.

WebCore.vcproj/WebCore.vcproj:
platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

2006-11-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

More fiddling with midl to get our JSC API types recognized.

Interfaces/IWebFrameLoadDelegate.idl:

9:32 AM Changeset in webkit [17662] by darin

3 edits in trunk/WebCore

fix bug caused by last-minute change to my check-in last night that is causing layout tests to hang

dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn a null string into an empty string before calling completeURL.

2:02 AM Changeset in webkit [17661] by beidson

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Maciej

Added test to cover bug http://bugs.webkit.org/show_bug.cgi?id=11450
-Confirm there is no assert when nuking a frame with an active XMLHttpRequest load
-Confirm the correct state-change notifications for the request are dispatched

http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: Added.
http/tests/xmlhttprequest/frame-load-cancelled-abort.html: Added.
http/tests/xmlhttprequest/resources/endlessxml.php: Added.
http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added.

WebCore:

Reviewed by Maciej

If the request has already been aborted, bail out of didFinishLoading()
immediately. This prevents state change notifications that aren't
needed.

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):

1:55 AM Changeset in webkit [22493] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): Use m_frame instead of this, include the correct files.

1:51 AM Changeset in webkit [17660] by darin

2 edits in trunk/WebCore

another attempt to fix Qt build

loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.

1:48 AM Changeset in webkit [17659] by darin

3 edits in trunk/WebCore

Reviewed by Geoff.

stray bits of my FrameLoader patch that I left out by accident

loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class. (WebCore::FrameLoader::requestFrame): Use less DeprecatedString. (WebCore::FrameLoader::clear): Stop the redirection timer. (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the entire function in an if statement. Use less DeprecatedString. (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator. (WebCore::FrameLoader::scheduleRefresh): Ditto. (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class.
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto.

1:47 AM Changeset in webkit [22492] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

(I'm not doing this to get commit 11000)

loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): It's m_frame, not frame.

1:45 AM Changeset in webkit [17658] by darin

2 edits in trunk/LayoutTests

Reviewed by Geoff.

fast/forms/submit-nil-value-field-assert.html: Update test so it no longer relies on incorrect "submit form right away during JavaScript execution" behavior.

1:43 AM Changeset in webkit [22491] by andersca