⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 10, 2006:

7:11 PM Changeset in webkit [22521] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore
6:55 PM Changeset in webkit [17722] by bdash
  • 14 edits
    9 adds in trunk

2006-11-10 Zalan Bujtas <​zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added s60/symbian platform defines.
​http://bugs.webkit.org/show_bug.cgi?id=11540

  • wtf/Platform.h:

2006-11-10 Zalan Bujtas <​zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added basic types for symbian platform.
​http://bugs.webkit.org/show_bug.cgi?id=11540

  • config.h:
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator TPtrC):
  • platform/DeprecatedString.cpp: (WebCore::initializeHandleNodeBlock):
  • platform/DeprecatedString.h: char _internalBuffer has to be in front of the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with bitfields and breaks byte aligment
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/IntPoint.h:
  • platform/IntRect.h:
  • platform/IntSize.h:
  • platform/PlatformString.h: (WebCore::String::operator TPtrC): (WebCore::String::des):
  • platform/StringImpl.h:
  • platform/symbian/DeprecatedStringSymbian.cpp: Added. (WebCore::DeprecatedString::setBufferFromDes): (WebCore::DeprecatedString::fromDes): (WebCore::DeprecatedString::des): (WebCore::DeprecatedString::des8):
  • platform/symbian/FloatPointSymbian.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator TPoint):
  • platform/symbian/FloatRectSymbian.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator TRect): (WebCore::FloatRect::rect):
  • platform/symbian/IntPointSymbian.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator TPoint):
  • platform/symbian/IntRectSymbian.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator TRect): (WebCore::IntRect::Rect):
  • platform/symbian/IntSizeSymbian.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator TSize):
  • platform/symbian/StringImplSymbian.cpp: Added. (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::des):
  • platform/symbian/StringSymbian.cpp: Added. (WebCore::String::String):
6:33 PM Changeset in webkit [17721] by bdash
  • 6 edits in trunk

2006-11-10 Zack Rusin <​zack@kde.org>

Reviewed by Anders.

Adjust to the changes Brady made in the Qt code.

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
  • loader/qt/FrameLoaderClientQt.h:

2006-11-10 Zack Rusin <​zack@kde.org>

Reviewed by Anders.

Making the Qt code work after refactorings in WebCore.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
5:56 PM Changeset in webkit [17720] by justing
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself

  • editing/deleting/delete-link-1-expected.checksum: Added.
  • editing/deleting/delete-link-1-expected.png: Added.
  • editing/deleting/delete-link-1-expected.txt: Added.
  • editing/deleting/delete-link-1.html: Added.
  • editing/inserting/insert-before-link-1-expected.checksum: Added.
  • editing/inserting/insert-before-link-1-expected.png: Added.
  • editing/inserting/insert-before-link-1-expected.txt: Added.
  • editing/inserting/insert-before-link-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself


The removed anchor element needs to stick around temporarily, in the same way
that the typing style hangs off the caret until the user moves it. Also text
insertion around anchors didn't match TextEdit.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added. (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
  • editing/DeleteSelectionCommand.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Clear the removed anchor after any top level editing command that doesn't preserve the typing style (matches TextEdit).
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call setSelection with a message telling it to clear the typing style (and the saved anchor) here. Save/restore the saved anchor because of this.
  • editing/Editor.h: (WebCore::Editor::removedAnchor): Getter. (WebCore::Editor::setRemovedAnchor): Setter.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor if one exists.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Clear the removed anchor whenever we make a selection change that clears the typing style. (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
  • editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and made some changes to match TextEdit's behavior. First, insert content inside the anchor when the caret is after it, unless the caret is at the end of the document, or if the caret is before it and at the start of a paragraph.
5:33 PM Changeset in webkit [22520] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin
5:19 PM Changeset in webkit [17719] by thatcher
  • 1 edit
    9 copies in tags/Safari-521.30

New tag.

5:18 PM Changeset in webkit [17718] by thatcher
  • 6 edits in /

Versioning.

5:15 PM Changeset in webkit [17717] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Check for BHIDDEN in isVisible() also.

  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
4:51 PM Changeset in webkit [17716] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders

Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
4:20 PM Changeset in webkit [17715] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix.

4:11 PM Changeset in webkit [22519] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Enthousiastically review by Beth (with exclamation marks and everything!!!1!!one!)

No need for WebIconDatabase to keep its own reference to the
WebCore::IconDatabase


  • WebIconDatabase.cpp: (WebIconDatabase::WebIconDatabase): (WebIconDatabase::init): (WebIconDatabase::iconForURL): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL):
  • WebIconDatabase.h:
4:10 PM Changeset in webkit [17714] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

64-bit build fix. Generates a derived export file for 64-bit architectures.

4:01 PM Changeset in webkit [22518] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Implement findNextWordFromIndex using ICU.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::findSentenceBoundary):
  • platform/win/TextBoundariesWin.cpp: (WebCore::findNextWordFromIndex):
3:45 PM Changeset in webkit [17713] by aroben
  • 4 edits in trunk/WebCore

Rubberstamped by Anders.

Back out some accidentally-committed changes from r17711.

  • page/Frame.cpp: (WebCore::Frame::command): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
3:36 PM Changeset in webkit [17712] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Anders.


  • remove some unnecessary uses of WebDataProtocol
  • WebView/WebDataSource.mm: Remove the unneeded include.
  • WebView/WebView.mm: (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here. Any request that has one will be an applewebdata: request, which will pass the check anyway.
3:20 PM Changeset in webkit [17711] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Geoff.

Add more commands, make toggleBold and toggleItalic executable commands.

  • WebCore.exp:
  • editing/Editor.cpp: (WebCore::execCopy): (WebCore::execCut): (WebCore::execDelete): (WebCore::execForwardDelete): (WebCore::execPaste): (WebCore::execSelectAll): (WebCore::execToggleBold): (WebCore::execToggleItalic): (WebCore::enabled): (WebCore::canPaste): (WebCore::hasEditableSelection): (WebCore::hasEditableRangeSelection): (WebCore::hasRangeSelection): (WebCore::hasRichlyEditableSelection): (WebCore::CommandEntry::):
  • editing/Editor.h:

WebKit:

Reviewed by Geoff.

Update for changes to WebCore

  • WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]):
2:29 PM Changeset in webkit [17710] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-10 spaltis <​Stanislav.Paltis@nokia.com>

Reviewed by Sachin.
DESC: For the progressive download,if it's already set by music player, we should not set it here.
​http://bugs.webkit.org/show_bug.cgi?id=11568

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::HandleDMgrEventL):
1:53 PM Changeset in webkit [17709] by sfalken
  • 1 copy in tags/Safari-521.30b

New tag.

1:51 PM Changeset in webkit [22517] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-10 Steve Falkenburg <​sfalken@apple.com>

Bump version number for submission

  • VERSION:
  • WebKit.vcproj/VERSION:
1:35 PM Changeset in webkit [22516] by ggaren
  • 14 edits in branches/WindowsMerge/WebKitWin

Oops. Checked in too much. Rolling out the extra.

1:33 PM Changeset in webkit [22515] by ggaren
  • 15 edits in branches/WindowsMerge/WebKitWin

Fixed build -- you can't delete the shared icon database -- it's a singleton

1:12 PM Changeset in webkit [17708] by ggaren
  • 1 edit in trunk/WebCore/platform/MimeTypeRegistry.cpp

Fixed platform #ifs

1:07 PM Changeset in webkit [17707] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2006-11-10 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
​http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
1:00 PM Changeset in webkit [17706] by spadma
  • 4 edits in S60/trunk/WebKit

2006-11-10 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
​http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
11:45 AM Changeset in webkit [17705] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Maciej, Geoff.

Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.

  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::execMoveBackward): (WebCore::execMoveBackwardAndModifySelection): (WebCore::execMoveDown): (WebCore::execMoveDownAndModifySelection): (WebCore::execMoveForward): (WebCore::execMoveForwardAndModifySelection): (WebCore::execMoveLeft): (WebCore::execMoveLeftAndModifySelection): (WebCore::execMoveRight): (WebCore::execMoveRightAndModifySelection): (WebCore::execMoveToBeginningOfDocument): (WebCore::execMoveToBeginningOfDocumentAndModifySelection): (WebCore::execMoveToBeginningOfSentence): (WebCore::execMoveToBeginningOfSentenceAndModifySelection): (WebCore::execMoveToBeginningOfLine): (WebCore::execMoveToBeginningOfLineAndModifySelection): (WebCore::execMoveToBeginningOfParagraph): (WebCore::execMoveToBeginningOfParagraphAndModifySelection): (WebCore::execMoveToEndOfDocument): (WebCore::execMoveToEndOfDocumentAndModifySelection): (WebCore::execMoveToEndOfSentence): (WebCore::execMoveToEndOfSentenceAndModifySelection): (WebCore::execMoveToEndOfLine): (WebCore::execMoveToEndOfLineAndModifySelection): (WebCore::execMoveToEndOfParagraph): (WebCore::execMoveToEndOfParagraphAndModifySelection): (WebCore::execMoveParagraphBackwardAndModifySelection): (WebCore::execMoveParagraphForwardAndModifySelection): (WebCore::execMoveUp): (WebCore::execMoveUpAndModifySelection): (WebCore::execMoveWordBackward): (WebCore::execMoveWordBackwardAndModifySelection): (WebCore::execMoveWordForward): (WebCore::execMoveWordForwardAndModifySelection): (WebCore::execMoveWordLeft): (WebCore::execMoveWordLeftAndModifySelection): (WebCore::execMoveWordRight): (WebCore::execMoveWordRightAndModifySelection): (WebCore::enabledAnySelection): (WebCore::createCommandMap): (WebCore::CommandEntry::): (WebCore::Editor::execCommand):
  • editing/Editor.h:

WebKit:

Reviewed by Maciej, Geoff.

Call execCommand directly here instead of going through the bridge.


  • WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]):
11:31 AM Changeset in webkit [22514] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin

Keep windows build from breaking

  • WebFrame.cpp: (WebFrame::dispatchDidReceiveIcon):
  • WebFrame.h:
11:24 AM Changeset in webkit [17704] by beidson
  • 14 edits
    1 add
    4 deletes in trunk

WebCore:

Reviewed by Darin

Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
  • loader/FrameLoaderClient.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::~IconDatabase):
  • loader/icon/IconDatabase.h: (WebCore::IconDatabase::isPrivateBrowsingEnabled): (WebCore::IconDatabase::enabled):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::finishLoading):
  • loader/mac/FrameLoaderMac.mm:

WebKit:

Reviewed by Darin


Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase defaultIconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase isIconExpiredForIconURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (-[WebIconDatabase _convertToWebCoreFormat]): (webGetNSImage):
  • Misc/WebIconDatabaseInternal.h: Added.
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon):
  • WebCoreSupport/WebIconDatabaseBridge.h: Removed.
  • WebCoreSupport/WebIconDatabaseBridge.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
11:16 AM Changeset in webkit [17703] by andersca
  • 22 edits
    8 adds in trunk

WebCore:

Reviewed and landed by Anders.

Adjust platform Qt/KDE code to the recent loader
changes.

  • CMakeLists.txt:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createEmptyDocument):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/qt/DocumentLoaderQt.cpp: Added. (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
  • loader/qt/FrameLoaderClientQt.cpp: Added. (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::detachFrameLoader): (WebCore::FrameLoaderClientQt::hasWebView): (WebCore::FrameLoaderClientQt::hasFrameView): (WebCore::FrameLoaderClientQt::hasBackForwardList): (WebCore::FrameLoaderClientQt::resetBackForwardList): (WebCore::FrameLoaderClientQt::provisionalItemIsTarget): (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientQt::privateBrowsingEnabled): (WebCore::FrameLoaderClientQt::makeDocumentView): (WebCore::FrameLoaderClientQt::makeRepresentation): (WebCore::FrameLoaderClientQt::forceLayout): (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML): (WebCore::FrameLoaderClientQt::updateHistoryForCommit): (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientQt::updateHistoryForReload): (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientQt::setCopiesOnScroll): (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset): (WebCore::FrameLoaderClientQt::resetAfterLoadError): (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError): (WebCore::FrameLoaderClientQt::willCloseDocument): (WebCore::FrameLoaderClientQt::detachedFromParent1): (WebCore::FrameLoaderClientQt::detachedFromParent2): (WebCore::FrameLoaderClientQt::detachedFromParent3): (WebCore::FrameLoaderClientQt::detachedFromParent4): (WebCore::FrameLoaderClientQt::loadedFromPageCache): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout): (WebCore::FrameLoaderClientQt::dispatchShow): (WebCore::FrameLoaderClientQt::cancelPolicyCheck): (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache): (WebCore::FrameLoaderClientQt::isLoadingFromPageCache): (WebCore::FrameLoaderClientQt::revertToProvisionalState): (WebCore::FrameLoaderClientQt::clearUnarchivingState): (WebCore::FrameLoaderClientQt::progressStarted): (WebCore::FrameLoaderClientQt::progressCompleted): (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): (WebCore::FrameLoaderClientQt::willChangeTitle): (WebCore::FrameLoaderClientQt::didChangeTitle): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::finalSetupForReplace): (WebCore::FrameLoaderClientQt::setDefersLoading): (WebCore::FrameLoaderClientQt::isArchiveLoadPending): (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientQt::clearArchivedResources): (WebCore::FrameLoaderClientQt::canShowMIMEType): (WebCore::FrameLoaderClientQt::representationExistsForURLScheme): (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientQt::frameLoadCompleted): (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientQt::provisionalLoadStarted): (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientQt::didFinishLoad): (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::userAgent):
  • loader/qt/FrameLoaderClientQt.h: Added.
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
  • loader/qt/NavigationActionQt.cpp: Added. (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
  • loader/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::loadsBlocked):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::cancel):
  • platform/qt/ChromeClientQt.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::setWindowRect): (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::pageRect): (WebCore::ChromeClientQt::scaleFactor): (WebCore::ChromeClientQt::focus): (WebCore::ChromeClientQt::unfocus): (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::canRunModal): (WebCore::ChromeClientQt::runModal): (WebCore::ChromeClientQt::setToolbarsVisible): (WebCore::ChromeClientQt::toolbarsVisible): (WebCore::ChromeClientQt::setStatusbarVisible): (WebCore::ChromeClientQt::statusbarVisible): (WebCore::ChromeClientQt::setScrollbarsVisible): (WebCore::ChromeClientQt::scrollbarsVisible): (WebCore::ChromeClientQt::setMenubarVisible): (WebCore::ChromeClientQt::menubarVisible): (WebCore::ChromeClientQt::setResizable):
  • platform/qt/ChromeClientQt.h: Added.
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldBeginEditing): (WebCore::EditorClientQt::shouldEndEditing): (WebCore::EditorClientQt::shouldApplyStyle): (WebCore::EditorClientQt::didBeginEditing): (WebCore::EditorClientQt::respondToChangedContents): (WebCore::EditorClientQt::didEndEditing):
  • platform/qt/EditorClientQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::keyEvent):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/ImageQt.cpp:
  • platform/qt/MimeTypeRegistryQt.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
  • platform/qt/PageQt.cpp:
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
  • platform/qt/ScreenQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::TextField::TextField): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

WebKitQt:

Reviewed and landed by Anders.

Adjusting to the recent loader changes, making it compile
and work.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::closeUrl): (WebKitPart::initView):
12:42 AM Changeset in webkit [17702] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Mitz

​http://bugs.webkit.org/show_bug.cgi?id=11554
Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
in case the icon load fails after some data has been received.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB on error. Also, as a loader re-factoring sanity check, added an assertion (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon is already committed to the DB. Skip doing that step twice.
12:22 AM Changeset in webkit [22513] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-10 Oliver Hunt <​oliver@apple.com>

Build fix


sprintf -> format (from Maciej's earlier change to WebCore)

  • WebView.cpp: (osVersion): (WebView::userAgentForKURL):

Nov 9, 2006:

11:33 PM Changeset in webkit [22512] by oliver
  • 4 edits
    1 add in branches/WindowsMerge/WebCore

2006-11-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

Added Windows side of MIME Type registry, and updated
objectContentType and ImageWin to make use of it


This fixes <rdar://problem/4791483>

  • WebCore.vcproj/WebCore.vcproj:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::objectContentType):
  • platform/win/ImageWin.cpp:
  • platform/win/MimeTypeRegistryWin.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::mimeTypeForExtension): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):


11:31 PM Changeset in webkit [17701] by oliver
  • 14 edits
    5 adds in trunk

2006-11-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

Pulled MIME type handling out of WebFrameBridge and added
a general C++ class to store/query MIME info
Added an Obj-C bridge to provide WebKit with access to the
MimeTypeRegistry for non-Obj-C++ classes.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebMimeTypeRegistryBridge.h: Added.
  • bridge/mac/WebMimeTypeRegistryBridge.mm: Added. (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
  • platform/Image.cpp: (WebCore::Image::supportsType):
  • platform/Image.h:
  • platform/MimeTypeRegistry.cpp: Added. (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes): (WebCore::initialiseMimeTypeRegistry): (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes): (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
  • platform/MimeTypeRegistry.h: Added.
  • platform/mac/ImageMac.mm:
  • platform/mac/MimeTypeRegistryMac.mm: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):


Updated to make use of MimeTypeRegistry/bridge

  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithArchive:]):
  • WebView/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): (-[WebHTMLView _documentFragmentWithPaths:]):


9:17 PM Changeset in webkit [17700] by mjs
  • 28 edits in trunk/WebCore

Reviewed by Oliver.

  • rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size for you and use vsnprintf.
  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • css/cssparser.cpp: (WebCore::CSSParser::parseColorFromValue):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::handleError):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • ksvg2/svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::toString): (WebCore::SVGPathSegArcRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::toString): (WebCore::SVGPathSegCurvetoCubicRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString): (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
  • ksvg2/svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::toString): (WebCore::SVGPathSegLinetoRel::toString):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::toString): (WebCore::SVGPathSegLinetoHorizontalRel::toString):
  • ksvg2/svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::toString): (WebCore::SVGPathSegLinetoVerticalRel::toString):
  • ksvg2/svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::toString): (WebCore::SVGPathSegMovetoRel::toString):
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange):
  • ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::closeRenderer):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setSynchronous):
  • platform/Color.cpp: (WebCore::Color::name):
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::setNum): (WebCore::DeprecatedString::format):
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::format): (WebCore::String::number):
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
  • platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::calcMinMaxWidth):
8:14 PM Changeset in webkit [22511] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin
6:27 PM Changeset in webkit [22510] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.


Fix crash on unknown protocol


  • WebFrame.cpp: (WebFrame::didFailWithError):
6:03 PM Changeset in webkit [22509] by lamadio
  • 4 edits in branches/WindowsMerge

2006-11-09 Lou Amadio <​lamadio@apple.com>

Reviewed by mjs
Correct the broken search implementations based on original webkit
<rdar://4827714>

4:30 PM Changeset in webkit [17699] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • fixed "Regression: Can't log into gmail.com"
  • fixed "iBench doesn't report results - tests run but no number is recorded"


  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): Removed extra ! character.
3:21 PM Changeset in webkit [17698] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Darin

<rdar://problem/4829080>
More loader re-factoring cleanup - WebFramePolicyListener was over-released

  • WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<>
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto (WebFrameLoaderClient::setUpPolicyListener): Ditto (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto
2:58 PM Changeset in webkit [17697] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in
WebCore::RenderBlock::skipWhitespace

Note that this will still crash on Debug builds because it will hit
an assertion failure in editing. (One of the reasons there is no
layout test along with this fix.) There is definitely some editing
wackiness happening. See ​http://bugs.webkit.org/show_bug.cgi?
id=10144 for updates on the assertion failure bug.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::childRemoved): It is possible for a prevRootBox and its prevRootBox to share a lineBreakObj. So instead of just clearing the lineBreakObj of the prevRootBox, cycle through all prevRootBoxs with the same lineBreakObj.
2:30 PM Changeset in webkit [22508] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Put the OpenSource revision in the WebKit.dll version info.

2:06 PM Changeset in webkit [17696] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-09 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
​http://bugs.webkit.org/show_bug.cgi?id=11556

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):
2:05 PM Changeset in webkit [17695] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-09 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
​http://bugs.webkit.org/show_bug.cgi?id=11556

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):
1:48 PM Changeset in webkit [17694] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebEditorClient.mm

Build fix.

1:40 PM Changeset in webkit [17693] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-09 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
​http://bugs.webkit.org/show_bug.cgi?id=11414

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
1:37 PM Changeset in webkit [17692] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2006-11-09 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
​http://bugs.webkit.org/show_bug.cgi?id=11414

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
1:11 PM Changeset in webkit [22507] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Fix line-endings.

  • WebEditorClient.cpp:
12:54 PM Changeset in webkit [22506] by oliver
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-11-09 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.

Build fixes

  • WebEditorClient.cpp: (WebEditorClient::respondToChangedContents):
  • WebEditorClient.h:
12:51 PM Changeset in webkit [17691] by aroben
  • 3 edits
    1 copy
    3 adds in trunk

LayoutTests:

Reviewed by Geoff.

New test to keep the mistake I made in r17680 from happening again.

  • fast/block/margin-collapse/negative-margins-expected.checksum: Added.
  • fast/block/margin-collapse/negative-margins-expected.png: Added.
  • fast/block/margin-collapse/negative-margins-expected.txt: Added.
  • fast/block/margin-collapse/negative-margins.html: Added.

WebCore:

Reviewed by Geoff.

Fix the change in behavior I caused in r17680 with my build fix.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):
11:48 AM Changeset in webkit [17690] by andersca
  • 15 edits in trunk

WebCore:

Reviewed by Adam, Oliver.

Move more functions to Editor.

  • bridge/EditorClient.h:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): (WebCore::dispatchEditableContentChangedEvents): (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::typingAddedToOpenCommand):
  • page/Frame.cpp:
  • page/Frame.h:

WebKit:

Reviewed by Adam, Oliver.

Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
instead of just passing the WebView.


  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame): (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::respondToChangedContents): (WebEditorClient::didEndEditing):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
11:00 AM Changeset in webkit [22505] by lamadio
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-08 Lou Amadio <​lamadio@apple.com>

Reviewed by ggaren

Moved CookieJar to OpenSourceWin
Ported CookieJar to CFNetwork
Corrected an uninitialized variable which crashed on Vista in the Wininet code

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/win/CookieJarWin.cpp:
8:31 AM Changeset in webkit [17689] by darin
  • 2 edits in trunk/WebCore
  • rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
8:17 AM Changeset in webkit [17688] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
All existing layout tests pass

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::deleteRow): check lastSection before deleting row
7:41 AM Changeset in webkit [17687] by darin
  • 3 edits in trunk/WebCore
  • improved version of last night's build fix (should not do using namespace in a header)
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):
7:38 AM Changeset in webkit [17686] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
​http://bugs.webkit.org/show_bug.cgi?id=11552

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
7:34 AM Changeset in webkit [17685] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-08 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
​http://bugs.webkit.org/show_bug.cgi?id=11552

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
7:27 AM Changeset in webkit [17684] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-08 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11539

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
7:24 AM Changeset in webkit [17683] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-08 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
​http://bugs.webkit.org/show_bug.cgi?id=11539

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
Note: See TracTimeline for information about the timeline view.