⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 11, 2006:

8:59 PM Changeset in webkit [22526] by ggaren
  • 29 edits in branches/WindowsMerge

Reviewed by Maciej Stachowiak.

  • Fixed <rdar://problem/4831461> Crash in FrameLoader::~FrameLoader when navigating away from ebay.com
  • Changed WebKit clients to match new virtual ref/deref scheme in WebCore.
  • Removed WebEditorClient from the WebCore namespace because it's a WebKit class, not a WebCore class.
  • Standardized some header #includes to match Mac:
    • alphabetical
    • config.h, WebKitDLL.h, and class headers go together at the top
    • everything else comes after a line break
8:53 PM Changeset in webkit [17740] by ggaren
  • 17 edits
    1 add in trunk

WebCore:

Reviewed by Maciej Stachowiak.


  • Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h: Fixed up function prototypes for style.
  • loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose was to implement an alternative ownership model. (WebCore::FrameLoader::~FrameLoader): Removed empty destructor. (WebCore::FrameLoader::setClient): This function now takes ownership (WebCore::FrameLoader::client):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • page/ChromeClient.h:
  • platform/AbstractShared.h: Added. This is the virtual function-based refcounting complement to Shared. (WebCore::AbstractShared::~AbstractShared):

WebKit:

Reviewed by Maciej Stachowiak.


  • Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.


WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
but other platforms may choose to do other things.

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::ref): (WebChromeClient::deref): (WebChromeClient::refCount):
  • WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes. The ones in WebCore make clear what remains to be implemented. Replaced constructor with factory function to avoid leaks.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::create): (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
  • WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory function to avoid leaks. (WebFrameLoaderClient::ref): (WebFrameLoaderClient::deref): (WebFrameLoaderClient::refCount):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::create):
  • WebView/WebFrame.mm: (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
4:13 PM Changeset in webkit [17739] by staikos
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix uninitialized variable.

  • rendering/RenderStyle.h:
2:54 PM Changeset in webkit [22525] by andersca
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Remove conflict markers

2:50 PM Changeset in webkit [22524] by andersca
  • 7 edits in branches/WindowsMerge

WebCoreWin:

2006-11-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Rename keyPress to keyEvent, it's used for both key presses
and releases.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
  • bridge/win/FrameWin.h:

WebKitWin:

2006-11-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Clean up the event handling code.


  • WebEditorClient.cpp: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::shouldApplyStyle): Change these to return true. Eventually they will call the editing delegate.


  • WebView.cpp: (WebView::execCommand): Update to call the editor's execCommand.


(WebView::keyUp):
New function that forwards the event to FrameWin.


(editCommandForKey):
New function that given a key returns an edit command from a table. Eventually this table
should be moved into WebCore.


(WebView::handleEditingKeyboardEvent):
New function that handles editing events.


(WebView::keyDown):
If the frame is editable, call handleEditingKeyboardEvent.


(WebViewWndProc):

  • WebView.h:
1:34 PM Changeset in webkit [17738] by aroben
  • 1 edit in trunk/WebCore/ChangeLog

Grammar fix.

1:32 PM Changeset in webkit [17737] by aroben
  • 2 edits in trunk/WebCore

Reviewed/landed by Adam.

Complete cleanup of the CMakeLists.txt.
Now all files to be build are sorted in alphabetic order.

General style cleanup, remove all tabs etc.

  • CMakeLists.txt:
1:32 PM Changeset in webkit [17736] by ddkilzer
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Changed one last bugzilla.opendarwin.org URL to bugs.webkit.org.

1:28 PM Changeset in webkit [17735] by ddkilzer
  • 4 edits in trunk

Changed bugzilla.opendarwin.org URLs to bugs.webkit.org in ChangeLog files.

1:17 PM Changeset in webkit [22523] by aroben
  • 30 edits
    3 moves
    1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

Move graphics-related files to platform/graphics to stay in sync with
changes from OpenSource r17727.

Also, as discussed with Darin and Steve, we now copy all our headers to
a flat include/WebCore directory instead of copying the directory
structure of WebCore. This mirrors how Mac builds.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/cg/ColorCG.cpp: Removed.
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/cg/GraphicsContextPlatformPrivate.h: Removed.
  • platform/win/IconWin.cpp: Removed.
  • platform/win/ImageWin.cpp: Removed.

WebKitWin:

Reviewed by Geoff.

Update WebCore #includes to use a flat directory structure.

  • DOMCSSClasses.cpp:
  • DOMCSSClasses.h:
  • DOMCoreClasses.cpp:
  • DOMEventsClasses.cpp:
  • DOMHTMLClasses.cpp:
  • MarshallingHelpers.cpp:
  • WebChromeClient.cpp:
  • WebChromeClient.h:
  • WebDataSource.cpp:
  • WebEditorClient.cpp:
  • WebEditorClient.h:
  • WebElementPropertyBag.cpp:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebHTMLRepresentation.cpp:
  • WebHistory.cpp:
  • WebIconDatabase.cpp:
  • WebIconDatabase.h:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitDLL.cpp:
  • WebMutableURLRequest.cpp:
  • WebNotificationCenter.cpp:
  • WebPreferences.cpp:
  • WebURLResponse.cpp:
  • WebURLResponse.h:
  • WebView.cpp:
  • WebView.h:
11:10 AM Changeset in webkit [17734] by andersca
  • 2 edits in trunk/WebKitTools

Reviewed and landed by Anders.

Make DRT work again on Qt/Linux.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
10:36 AM Changeset in webkit [17733] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.


Added missing initializer to ResourceRequest -- fixes some loader crashes
due to assuming a request always has a non-null httpMethod.

  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
10:08 AM Changeset in webkit [17732] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed header guard

  • loader/FrameLoaderClient.h:
8:52 AM Changeset in webkit [22522] by darin
  • 2 edits in branches/WindowsMerge/WebCore
  • blind attempt to fix the build
  • platform/win/CursorWin.cpp: (WebCore::verticalTextCursor): Added. Just returns the pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.
8:48 AM Changeset in webkit [17731] by darin
  • 2 edits in trunk/WebCore
  • attempt to fix Qt build
  • platform/qt/CursorQt.cpp: (WebCore::verticalTextCursor): Added. Just returns pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.
7:49 AM Changeset in webkit [17730] by rwlbuis
  • 6 edits
    3 adds in trunk

Reviewed by hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements

Allow @import as part of a css rule.

7:31 AM Changeset in webkit [17729] by ap
  • 2 edits in trunk/WebCore

Attempt to fix Qt build.

  • CMakeLists.txt: PathQt.cpp is in graphics/qt now.
7:15 AM Changeset in webkit [17728] by ap
  • 9 edits
    3 adds in trunk/WebCore

2006-11-11 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)

[CSS 3] support for vertical-text, cell and context-menu cursors
​http://bugs.webkit.org/show_bug.cgi?id=11494

  • Resources/cellCursor.png: Added.
  • Resources/contextMenuCursor.png: Added.
  • Resources/verticalTextCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • manual-tests/cursor.html:
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor):
  • rendering/RenderStyle.h: (WebCore::):
6:31 AM Changeset in webkit [17727] by ap
  • 4 edits
    50 moves
    4 adds in trunk/WebCore

2006-11-11 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by aroben and ap, landed by ap.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11468

Group graphics related files in platform/graphics.
Move certain files from certain subdirectories
into platform/graphics/{win,mac,cg,gdk,qt}

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/AffineTransform.cpp: Removed.
  • platform/AffineTransform.h: Removed.
  • platform/Color.cpp: Removed.
  • platform/Color.h: Removed.
  • platform/FloatPoint.cpp: Removed.
  • platform/FloatPoint.h: Removed.
  • platform/FloatRect.cpp: Removed.
  • platform/FloatRect.h: Removed.
  • platform/FloatSize.cpp: Removed.
  • platform/FloatSize.h: Removed.
  • platform/Icon.h: Removed.
  • platform/Image.cpp: Removed.
  • platform/Image.h: Removed.
  • platform/ImageSource.h: Removed.
  • platform/IntPoint.h: Removed.
  • platform/IntRect.cpp: Removed.
  • platform/IntRect.h: Removed.
  • platform/IntSize.h: Removed.
  • platform/IntSizeHash.h: Removed.
  • platform/Path.cpp: Removed.
  • platform/Path.h: Removed.
  • platform/Pen.cpp: Removed.
  • platform/Pen.h: Removed.
  • platform/cairo/AffineTransformCairo.cpp: Removed.
  • platform/cairo/GraphicsContextCairo.cpp: Removed.
  • platform/cairo/ImageCairo.cpp: Removed.
  • platform/cairo/ImageSourceCairo.cpp: Removed.
  • platform/cairo/cairo/AUTHORS: Removed.
  • platform/cairo/cairo/COPYING: Removed.
  • platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
  • platform/cairo/cairo/COPYING-MPL-1.1: Removed.
  • platform/cairo/cairo/INSTALL: Removed.
  • platform/cairo/cairo/NEWS: Removed.
  • platform/cairo/cairo/README: Removed.
  • platform/cairo/cairo/TODO: Removed.
  • platform/cairo/cairo/src/Makefile.in: Removed.
  • platform/cairo/cairo/src/cairo-arc-private.h: Removed.
  • platform/cairo/cairo/src/cairo-arc.c: Removed.
  • platform/cairo/cairo/src/cairo-array.c: Removed.
  • platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
  • platform/cairo/cairo/src/cairo-atsui.h: Removed.
  • platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
  • platform/cairo/cairo/src/cairo-beos.h: Removed.
  • platform/cairo/cairo/src/cairo-cache-private.h: Removed.
  • platform/cairo/cairo/src/cairo-cache.c: Removed.
  • platform/cairo/cairo/src/cairo-clip-private.h: Removed.
  • platform/cairo/cairo/src/cairo-clip.c: Removed.
  • platform/cairo/cairo/src/cairo-color.c: Removed.
  • platform/cairo/cairo/src/cairo-debug.c: Removed.
  • platform/cairo/cairo/src/cairo-debug.h: Removed.
  • platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-directfb.h: Removed.
  • platform/cairo/cairo/src/cairo-features.h: Removed.
  • platform/cairo/cairo/src/cairo-features.h.in: Removed.
  • platform/cairo/cairo/src/cairo-fixed.c: Removed.
  • platform/cairo/cairo/src/cairo-font-options.c: Removed.
  • platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
  • platform/cairo/cairo/src/cairo-font-subset.c: Removed.
  • platform/cairo/cairo/src/cairo-font.c: Removed.
  • platform/cairo/cairo/src/cairo-ft-font.c: Removed.
  • platform/cairo/cairo/src/cairo-ft-private.h: Removed.
  • platform/cairo/cairo/src/cairo-ft.h: Removed.
  • platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-glitz.h: Removed.
  • platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
  • platform/cairo/cairo/src/cairo-gstate.c: Removed.
  • platform/cairo/cairo/src/cairo-hash-private.h: Removed.
  • platform/cairo/cairo/src/cairo-hash.c: Removed.
  • platform/cairo/cairo/src/cairo-hull.c: Removed.
  • platform/cairo/cairo/src/cairo-image-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-matrix.c: Removed.
  • platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
  • platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-output-stream.c: Removed.
  • platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
  • platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
  • platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
  • platform/cairo/cairo/src/cairo-path-data.c: Removed.
  • platform/cairo/cairo/src/cairo-path-fill.c: Removed.
  • platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
  • platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
  • platform/cairo/cairo/src/cairo-path.c: Removed.
  • platform/cairo/cairo/src/cairo-pattern.c: Removed.
  • platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-pdf.h: Removed.
  • platform/cairo/cairo/src/cairo-pen.c: Removed.
  • platform/cairo/cairo/src/cairo-platform.h: Removed.
  • platform/cairo/cairo/src/cairo-png.c: Removed.
  • platform/cairo/cairo/src/cairo-polygon.c: Removed.
  • platform/cairo/cairo/src/cairo-private.h: Removed.
  • platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-ps.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-quartz.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-quartz2.h: Removed.
  • platform/cairo/cairo/src/cairo-region.c: Removed.
  • platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
  • platform/cairo/cairo/src/cairo-slope.c: Removed.
  • platform/cairo/cairo/src/cairo-spline.c: Removed.
  • platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
  • platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
  • platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
  • platform/cairo/cairo/src/cairo-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-svg.h: Removed.
  • platform/cairo/cairo/src/cairo-traps.c: Removed.
  • platform/cairo/cairo/src/cairo-unicode.c: Removed.
  • platform/cairo/cairo/src/cairo-wideint.c: Removed.
  • platform/cairo/cairo/src/cairo-wideint.h: Removed.
  • platform/cairo/cairo/src/cairo-win32-font.c: Removed.
  • platform/cairo/cairo/src/cairo-win32-private.h: Removed.
  • platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-win32.h: Removed.
  • platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
  • platform/cairo/cairo/src/cairo-xcb.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
  • platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib.h: Removed.
  • platform/cairo/cairo/src/cairo.c: Removed.
  • platform/cairo/cairo/src/cairo.h: Removed.
  • platform/cairo/cairo/src/cairoint.h: Removed.
  • platform/cairo/cairo/src/test-fallback-surface.c: Removed.
  • platform/cairo/cairo/src/test-fallback-surface.h: Removed.
  • platform/cairo/cairo/src/test-meta-surface.c: Removed.
  • platform/cairo/cairo/src/test-meta-surface.h: Removed.
  • platform/cairo/cairo/src/test-paginated-surface.c: Removed.
  • platform/cairo/cairo/src/test-paginated-surface.h: Removed.
  • platform/cairo/pixman/AUTHORS: Removed.
  • platform/cairo/pixman/COPYING: Removed.
  • platform/cairo/pixman/README: Removed.
  • platform/cairo/pixman/src/Makefile.in: Removed.
  • platform/cairo/pixman/src/fbcompose.c: Removed.
  • platform/cairo/pixman/src/fbedge.c: Removed.
  • platform/cairo/pixman/src/fbedgeimp.h: Removed.
  • platform/cairo/pixman/src/fbmmx.c: Removed.
  • platform/cairo/pixman/src/fbmmx.h: Removed.
  • platform/cairo/pixman/src/fbpict.c: Removed.
  • platform/cairo/pixman/src/fbpict.h: Removed.
  • platform/cairo/pixman/src/fbtrap.c: Removed.
  • platform/cairo/pixman/src/icblt.c: Removed.
  • platform/cairo/pixman/src/icbltone.c: Removed.
  • platform/cairo/pixman/src/iccolor.c: Removed.
  • platform/cairo/pixman/src/icformat.c: Removed.
  • platform/cairo/pixman/src/icimage.c: Removed.
  • platform/cairo/pixman/src/icimage.h: Removed.
  • platform/cairo/pixman/src/icint.h: Removed.
  • platform/cairo/pixman/src/icpixels.c: Removed.
  • platform/cairo/pixman/src/icrect.c: Removed.
  • platform/cairo/pixman/src/icrop.h: Removed.
  • platform/cairo/pixman/src/icstipple.c: Removed.
  • platform/cairo/pixman/src/ictransform.c: Removed.
  • platform/cairo/pixman/src/ictrap.c: Removed.
  • platform/cairo/pixman/src/ictri.c: Removed.
  • platform/cairo/pixman/src/icutil.c: Removed.
  • platform/cairo/pixman/src/pixman-remap.h: Removed.
  • platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
  • platform/cairo/pixman/src/pixman.h: Removed.
  • platform/cairo/pixman/src/pixregion.c: Removed.
  • platform/cairo/pixman/src/pixregionint.h: Removed.
  • platform/cairo/pixman/src/renderedge.c: Removed.
  • platform/cairo/pixman/src/renderedge.h: Removed.
  • platform/cairo/pixman/src/slim_internal.h: Removed.
  • platform/cairo/rgb24-hacks.txt: Removed.
  • platform/cairo/scale-removal.txt: Removed.
  • platform/cg/AffineTransformCG.cpp: Removed.
  • platform/cg/FloatPointCG.cpp: Removed.
  • platform/cg/FloatRectCG.cpp: Removed.
  • platform/cg/FloatSizeCG.cpp: Removed.
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/cg/GraphicsContextPlatformPrivate.h: Removed.
  • platform/cg/ImageCG.cpp: Removed.
  • platform/cg/ImageSourceCG.cpp: Removed.
  • platform/cg/IntPointCG.cpp: Removed.
  • platform/cg/IntRectCG.cpp: Removed.
  • platform/cg/IntSizeCG.cpp: Removed.
  • platform/cg/PDFDocumentImage.cpp: Removed.
  • platform/cg/PDFDocumentImage.h: Removed.
  • platform/cg/PathCG.cpp: Removed.
  • platform/gdk/ImageGdk.cpp: Removed.
  • platform/mac/ColorMac.mm: Removed.
  • platform/mac/FloatPointMac.mm: Removed.
  • platform/mac/FloatRectMac.mm: Removed.
  • platform/mac/FloatSizeMac.mm: Removed.
  • platform/mac/GraphicsContextMac.mm:
  • platform/mac/IconMac.mm: Removed.
  • platform/mac/ImageMac.mm: Removed.
  • platform/mac/IntPointMac.mm: Removed.
  • platform/mac/IntRectMac.mm: Removed.
  • platform/mac/IntSizeMac.mm: Removed.
  • platform/qt/AffineTransformQt.cpp: Removed.
  • platform/qt/ColorQt.cpp: Removed.
  • platform/qt/FloatPointQt.cpp: Removed.
  • platform/qt/FloatRectQt.cpp: Removed.
  • platform/qt/IconQt.cpp: Removed.
  • platform/qt/ImageQt.cpp: Removed.
  • platform/qt/ImageSourceQt.cpp: Removed.
  • platform/qt/IntPointQt.cpp: Removed.
  • platform/qt/IntRectQt.cpp: Removed.
  • platform/qt/IntSizeQt.cpp: Removed.
  • platform/qt/PathQt.cpp: Removed.
  • platform/win/ImageWin.cpp: Removed.
  • platform/win/IntPointWin.cpp: Removed.
  • platform/win/IntRectWin.cpp: Removed.
  • platform/win/IntSizeWin.cpp: Removed.
5:10 AM Changeset in webkit [17726] by gdennis
  • 1 edit in trunk/WebCore/rendering/RenderText.cpp

Build fix.

4:34 AM Changeset in webkit [17725] by gdennis
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by hyatt.

A layout test was added when this bug was fixed, so none needed now.


Cleanup after:
REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
​http://bugs.webkit.org/show_bug.cgi?id=11570


  • rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Removed.
  • rendering/RenderText.cpp: (WebCore::isSpace): Added. (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
4:04 AM Changeset in webkit [17724] by gdennis
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by mitz.


REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
​http://bugs.webkit.org/show_bug.cgi?id=11570

  • rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Added.
  • rendering/RenderText.cpp: (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'

LayoutTests:

Reviewed by mitz.

REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
​http://bugs.webkit.org/show_bug.cgi?id=11570

  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.checksum: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps.html: Added.
12:50 AM Changeset in webkit [17723] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11508
Undisable some warnings for JSImmediate.h

Fix suggested by Don Gibson.

  • kjs/JSImmediate.h: Re-enable all MSVC warnings, move the remaining runtime checks to compile-time.

Nov 10, 2006:

7:11 PM Changeset in webkit [22521] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore
6:55 PM Changeset in webkit [17722] by bdash
  • 14 edits
    9 adds in trunk

2006-11-10 Zalan Bujtas <​zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added s60/symbian platform defines.
​http://bugs.webkit.org/show_bug.cgi?id=11540

  • wtf/Platform.h:

2006-11-10 Zalan Bujtas <​zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added basic types for symbian platform.
​http://bugs.webkit.org/show_bug.cgi?id=11540

  • config.h:
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator TPtrC):
  • platform/DeprecatedString.cpp: (WebCore::initializeHandleNodeBlock):
  • platform/DeprecatedString.h: char _internalBuffer has to be in front of the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with bitfields and breaks byte aligment
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/IntPoint.h:
  • platform/IntRect.h:
  • platform/IntSize.h:
  • platform/PlatformString.h: (WebCore::String::operator TPtrC): (WebCore::String::des):
  • platform/StringImpl.h:
  • platform/symbian/DeprecatedStringSymbian.cpp: Added. (WebCore::DeprecatedString::setBufferFromDes): (WebCore::DeprecatedString::fromDes): (WebCore::DeprecatedString::des): (WebCore::DeprecatedString::des8):
  • platform/symbian/FloatPointSymbian.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator TPoint):
  • platform/symbian/FloatRectSymbian.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator TRect): (WebCore::FloatRect::rect):
  • platform/symbian/IntPointSymbian.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator TPoint):
  • platform/symbian/IntRectSymbian.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator TRect): (WebCore::IntRect::Rect):
  • platform/symbian/IntSizeSymbian.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator TSize):
  • platform/symbian/StringImplSymbian.cpp: Added. (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::des):
  • platform/symbian/StringSymbian.cpp: Added. (WebCore::String::String):
6:33 PM Changeset in webkit [17721] by bdash
  • 6 edits in trunk

2006-11-10 Zack Rusin <​zack@kde.org>

Reviewed by Anders.

Adjust to the changes Brady made in the Qt code.

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
  • loader/qt/FrameLoaderClientQt.h:

2006-11-10 Zack Rusin <​zack@kde.org>

Reviewed by Anders.

Making the Qt code work after refactorings in WebCore.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
5:56 PM Changeset in webkit [17720] by justing
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself

  • editing/deleting/delete-link-1-expected.checksum: Added.
  • editing/deleting/delete-link-1-expected.png: Added.
  • editing/deleting/delete-link-1-expected.txt: Added.
  • editing/deleting/delete-link-1.html: Added.
  • editing/inserting/insert-before-link-1-expected.checksum: Added.
  • editing/inserting/insert-before-link-1-expected.png: Added.
  • editing/inserting/insert-before-link-1-expected.txt: Added.
  • editing/inserting/insert-before-link-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself


The removed anchor element needs to stick around temporarily, in the same way
that the typing style hangs off the caret until the user moves it. Also text
insertion around anchors didn't match TextEdit.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added. (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
  • editing/DeleteSelectionCommand.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Clear the removed anchor after any top level editing command that doesn't preserve the typing style (matches TextEdit).
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call setSelection with a message telling it to clear the typing style (and the saved anchor) here. Save/restore the saved anchor because of this.
  • editing/Editor.h: (WebCore::Editor::removedAnchor): Getter. (WebCore::Editor::setRemovedAnchor): Setter.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor if one exists.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Clear the removed anchor whenever we make a selection change that clears the typing style. (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
  • editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and made some changes to match TextEdit's behavior. First, insert content inside the anchor when the caret is after it, unless the caret is at the end of the document, or if the caret is before it and at the start of a paragraph.
5:33 PM Changeset in webkit [22520] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin
5:19 PM Changeset in webkit [17719] by thatcher
  • 1 edit
    9 copies in tags/Safari-521.30

New tag.

5:18 PM Changeset in webkit [17718] by thatcher
  • 6 edits in /

Versioning.

5:15 PM Changeset in webkit [17717] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Check for BHIDDEN in isVisible() also.

  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
4:51 PM Changeset in webkit [17716] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders

Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
4:20 PM Changeset in webkit [17715] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix.

4:11 PM Changeset in webkit [22519] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Enthousiastically review by Beth (with exclamation marks and everything!!!1!!one!)

No need for WebIconDatabase to keep its own reference to the
WebCore::IconDatabase


  • WebIconDatabase.cpp: (WebIconDatabase::WebIconDatabase): (WebIconDatabase::init): (WebIconDatabase::iconForURL): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL):
  • WebIconDatabase.h:
4:10 PM Changeset in webkit [17714] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

64-bit build fix. Generates a derived export file for 64-bit architectures.

4:01 PM Changeset in webkit [22518] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Oliver.

Implement findNextWordFromIndex using ICU.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::findSentenceBoundary):
  • platform/win/TextBoundariesWin.cpp: (WebCore::findNextWordFromIndex):
3:45 PM Changeset in webkit [17713] by aroben
  • 4 edits in trunk/WebCore

Rubberstamped by Anders.

Back out some accidentally-committed changes from r17711.

  • page/Frame.cpp: (WebCore::Frame::command): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
3:36 PM Changeset in webkit [17712] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Anders.


  • remove some unnecessary uses of WebDataProtocol
  • WebView/WebDataSource.mm: Remove the unneeded include.
  • WebView/WebView.mm: (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here. Any request that has one will be an applewebdata: request, which will pass the check anyway.
3:20 PM Changeset in webkit [17711] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Geoff.

Add more commands, make toggleBold and toggleItalic executable commands.

  • WebCore.exp:
  • editing/Editor.cpp: (WebCore::execCopy): (WebCore::execCut): (WebCore::execDelete): (WebCore::execForwardDelete): (WebCore::execPaste): (WebCore::execSelectAll): (WebCore::execToggleBold): (WebCore::execToggleItalic): (WebCore::enabled): (WebCore::canPaste): (WebCore::hasEditableSelection): (WebCore::hasEditableRangeSelection): (WebCore::hasRangeSelection): (WebCore::hasRichlyEditableSelection): (WebCore::CommandEntry::):
  • editing/Editor.h:

WebKit:

Reviewed by Geoff.

Update for changes to WebCore

  • WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]):
2:29 PM Changeset in webkit [17710] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-10 spaltis <​Stanislav.Paltis@nokia.com>

Reviewed by Sachin.
DESC: For the progressive download,if it's already set by music player, we should not set it here.
​http://bugs.webkit.org/show_bug.cgi?id=11568

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::HandleDMgrEventL):
1:53 PM Changeset in webkit [17709] by sfalken
  • 1 copy in tags/Safari-521.30b

New tag.

1:51 PM Changeset in webkit [22517] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-10 Steve Falkenburg <​sfalken@apple.com>

Bump version number for submission

  • VERSION:
  • WebKit.vcproj/VERSION:
1:35 PM Changeset in webkit [22516] by ggaren
  • 14 edits in branches/WindowsMerge/WebKitWin

Oops. Checked in too much. Rolling out the extra.

1:33 PM Changeset in webkit [22515] by ggaren
  • 15 edits in branches/WindowsMerge/WebKitWin

Fixed build -- you can't delete the shared icon database -- it's a singleton

1:12 PM Changeset in webkit [17708] by ggaren
  • 1 edit in trunk/WebCore/platform/MimeTypeRegistry.cpp

Fixed platform #ifs

1:07 PM Changeset in webkit [17707] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2006-11-10 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
​http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
1:00 PM Changeset in webkit [17706] by spadma
  • 4 edits in S60/trunk/WebKit

2006-11-10 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
​http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
11:45 AM Changeset in webkit [17705] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Maciej, Geoff.

Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.

  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::execMoveBackward): (WebCore::execMoveBackwardAndModifySelection): (WebCore::execMoveDown): (WebCore::execMoveDownAndModifySelection): (WebCore::execMoveForward): (WebCore::execMoveForwardAndModifySelection): (WebCore::execMoveLeft): (WebCore::execMoveLeftAndModifySelection): (WebCore::execMoveRight): (WebCore::execMoveRightAndModifySelection): (WebCore::execMoveToBeginningOfDocument): (WebCore::execMoveToBeginningOfDocumentAndModifySelection): (WebCore::execMoveToBeginningOfSentence): (WebCore::execMoveToBeginningOfSentenceAndModifySelection): (WebCore::execMoveToBeginningOfLine): (WebCore::execMoveToBeginningOfLineAndModifySelection): (WebCore::execMoveToBeginningOfParagraph): (WebCore::execMoveToBeginningOfParagraphAndModifySelection): (WebCore::execMoveToEndOfDocument): (WebCore::execMoveToEndOfDocumentAndModifySelection): (WebCore::execMoveToEndOfSentence): (WebCore::execMoveToEndOfSentenceAndModifySelection): (WebCore::execMoveToEndOfLine): (WebCore::execMoveToEndOfLineAndModifySelection): (WebCore::execMoveToEndOfParagraph): (WebCore::execMoveToEndOfParagraphAndModifySelection): (WebCore::execMoveParagraphBackwardAndModifySelection): (WebCore::execMoveParagraphForwardAndModifySelection): (WebCore::execMoveUp): (WebCore::execMoveUpAndModifySelection): (WebCore::execMoveWordBackward): (WebCore::execMoveWordBackwardAndModifySelection): (WebCore::execMoveWordForward): (WebCore::execMoveWordForwardAndModifySelection): (WebCore::execMoveWordLeft): (WebCore::execMoveWordLeftAndModifySelection): (WebCore::execMoveWordRight): (WebCore::execMoveWordRightAndModifySelection): (WebCore::enabledAnySelection): (WebCore::createCommandMap): (WebCore::CommandEntry::): (WebCore::Editor::execCommand):
  • editing/Editor.h:

WebKit:

Reviewed by Maciej, Geoff.

Call execCommand directly here instead of going through the bridge.


  • WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]):
11:31 AM Changeset in webkit [22514] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin

Keep windows build from breaking

  • WebFrame.cpp: (WebFrame::dispatchDidReceiveIcon):
  • WebFrame.h:
11:24 AM Changeset in webkit [17704] by beidson
  • 14 edits
    1 add
    4 deletes in trunk

WebCore:

Reviewed by Darin

Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
  • loader/FrameLoaderClient.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::~IconDatabase):
  • loader/icon/IconDatabase.h: (WebCore::IconDatabase::isPrivateBrowsingEnabled): (WebCore::IconDatabase::enabled):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::finishLoading):
  • loader/mac/FrameLoaderMac.mm:

WebKit:

Reviewed by Darin


Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase defaultIconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase isIconExpiredForIconURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (-[WebIconDatabase _convertToWebCoreFormat]): (webGetNSImage):
  • Misc/WebIconDatabaseInternal.h: Added.
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon):
  • WebCoreSupport/WebIconDatabaseBridge.h: Removed.
  • WebCoreSupport/WebIconDatabaseBridge.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
11:16 AM Changeset in webkit [17703] by andersca
  • 22 edits
    8 adds in trunk

WebCore:

Reviewed and landed by Anders.

Adjust platform Qt/KDE code to the recent loader
changes.

  • CMakeLists.txt:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createEmptyDocument):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/qt/DocumentLoaderQt.cpp: Added. (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
  • loader/qt/FrameLoaderClientQt.cpp: Added. (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::detachFrameLoader): (WebCore::FrameLoaderClientQt::hasWebView): (WebCore::FrameLoaderClientQt::hasFrameView): (WebCore::FrameLoaderClientQt::hasBackForwardList): (WebCore::FrameLoaderClientQt::resetBackForwardList): (WebCore::FrameLoaderClientQt::provisionalItemIsTarget): (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientQt::privateBrowsingEnabled): (WebCore::FrameLoaderClientQt::makeDocumentView): (WebCore::FrameLoaderClientQt::makeRepresentation): (WebCore::FrameLoaderClientQt::forceLayout): (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML): (WebCore::FrameLoaderClientQt::updateHistoryForCommit): (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientQt::updateHistoryForReload): (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientQt::setCopiesOnScroll): (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset): (WebCore::FrameLoaderClientQt::resetAfterLoadError): (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError): (WebCore::FrameLoaderClientQt::willCloseDocument): (WebCore::FrameLoaderClientQt::detachedFromParent1): (WebCore::FrameLoaderClientQt::detachedFromParent2): (WebCore::FrameLoaderClientQt::detachedFromParent3): (WebCore::FrameLoaderClientQt::detachedFromParent4): (WebCore::FrameLoaderClientQt::loadedFromPageCache): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout): (WebCore::FrameLoaderClientQt::dispatchShow): (WebCore::FrameLoaderClientQt::cancelPolicyCheck): (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache): (WebCore::FrameLoaderClientQt::isLoadingFromPageCache): (WebCore::FrameLoaderClientQt::revertToProvisionalState): (WebCore::FrameLoaderClientQt::clearUnarchivingState): (WebCore::FrameLoaderClientQt::progressStarted): (WebCore::FrameLoaderClientQt::progressCompleted): (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): (WebCore::FrameLoaderClientQt::willChangeTitle): (WebCore::FrameLoaderClientQt::didChangeTitle): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::finalSetupForReplace): (WebCore::FrameLoaderClientQt::setDefersLoading): (WebCore::FrameLoaderClientQt::isArchiveLoadPending): (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientQt::clearArchivedResources): (WebCore::FrameLoaderClientQt::canShowMIMEType): (WebCore::FrameLoaderClientQt::representationExistsForURLScheme): (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientQt::frameLoadCompleted): (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientQt::provisionalLoadStarted): (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientQt::didFinishLoad): (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::userAgent):
  • loader/qt/FrameLoaderClientQt.h: Added.
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
  • loader/qt/NavigationActionQt.cpp: Added. (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
  • loader/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::loadsBlocked):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::cancel):
  • platform/qt/ChromeClientQt.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::setWindowRect): (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::pageRect): (WebCore::ChromeClientQt::scaleFactor): (WebCore::ChromeClientQt::focus): (WebCore::ChromeClientQt::unfocus): (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::canRunModal): (WebCore::ChromeClientQt::runModal): (WebCore::ChromeClientQt::setToolbarsVisible): (WebCore::ChromeClientQt::toolbarsVisible): (WebCore::ChromeClientQt::setStatusbarVisible): (WebCore::ChromeClientQt::statusbarVisible): (WebCore::ChromeClientQt::setScrollbarsVisible): (WebCore::ChromeClientQt::scrollbarsVisible): (WebCore::ChromeClientQt::setMenubarVisible): (WebCore::ChromeClientQt::menubarVisible): (WebCore::ChromeClientQt::setResizable):
  • platform/qt/ChromeClientQt.h: Added.
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldBeginEditing): (WebCore::EditorClientQt::shouldEndEditing): (WebCore::EditorClientQt::shouldApplyStyle): (WebCore::EditorClientQt::didBeginEditing): (WebCore::EditorClientQt::respondToChangedContents): (WebCore::EditorClientQt::didEndEditing):
  • platform/qt/EditorClientQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::keyEvent):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/ImageQt.cpp:
  • platform/qt/MimeTypeRegistryQt.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
  • platform/qt/PageQt.cpp:
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
  • platform/qt/ScreenQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::TextField::TextField): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

WebKitQt:

Reviewed and landed by Anders.

Adjusting to the recent loader changes, making it compile
and work.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::closeUrl): (WebKitPart::initView):
12:42 AM Changeset in webkit [17702] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Mitz

​http://bugs.webkit.org/show_bug.cgi?id=11554
Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
in case the icon load fails after some data has been received.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB on error. Also, as a loader re-factoring sanity check, added an assertion (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon is already committed to the DB. Skip doing that step twice.
12:22 AM Changeset in webkit [22513] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-10 Oliver Hunt <​oliver@apple.com>

Build fix


sprintf -> format (from Maciej's earlier change to WebCore)

  • WebView.cpp: (osVersion): (WebView::userAgentForKURL):
Note: See TracTimeline for information about the timeline view.