⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 13, 2006:

11:59 PM Changeset in webkit [22537] by beidson
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared

  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared


  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::submitForm):
  • WebFrame.h:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::setFormData): (WebMutableURLRequest::formData):
  • WebMutableURLRequest.h:
7:54 PM Changeset in webkit [17755] by beidson
  • 16 edits in trunk/WebCore

Reviewed by Maciej

Made FormData Shared, and pass it around as such.

  • WebCore.xcodeproj/project.pbxproj: Reordered some items
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
  • platform/network/FormData.h: Made FormData shared
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest): (WebCore::nsURLRequest):
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
7:01 PM Changeset in webkit [22536] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Make sure to call valueChanged after hiding the popup so that change events will be delivered correctly.
6:45 PM Changeset in webkit [17754] by justing
  • 3 edits in trunk/LayoutTests/editing/selection

I accidently checked in old expected results in my previous checkin.

6:37 PM Changeset in webkit [17753] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/selection/drag-select-1-expected.checksum: Added.
  • editing/selection/drag-select-1-expected.png: Added.
  • editing/selection/drag-select-1-expected.txt: Added.
  • editing/selection/drag-select-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4828264>
In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (​http://www.cnet.com/)


The start of the selection is in an editable area, and the end is in an
input field inside that editable area. The code that should pull the end
of such a selection outside the input field didn't escape shadow nodes,
it would leave a dangling end, causing the crash in toRange.


  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Added an ASSERT and a fixup to prevent crashes like this in future Release builds.
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Let this function escape shadow nodes. We might eventually push this code down into next/previous{VisuallyDistinct}Canditate. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
6:09 PM Changeset in webkit [22535] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Various editing fixes.


  • WebView.cpp: (WebView::execCommand): Use the focused frame, not the main frame.


(WebView::focusedTarget):
Add FIXME comment.


(WebView::keyDown):
Return false for unknown keydown messages when not in editing mode.

5:27 PM Changeset in webkit [22534] by aroben
  • 1 edit in branches/WindowsMerge/WebCore/platform/network/win/CookieJarWin.cpp

Fix line endings.

5:21 PM Changeset in webkit [22533] by sfalken
  • 4 edits in branches/WindowsMerge

2006-11-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders, Lou.

Fix merge script

  • WebCore.vcproj/merge-opensource.sh: Don't copy cairo, pixman

2006-11-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders, Lou.


Bump version for submit
Copy CharacterSets directory for CF

  • WebKit.vcproj/VERSION: Bump version
  • WebKit.vcproj/WebKit.vcproj: Copy CharacterSets
3:56 PM Changeset in webkit [17752] by justing
  • 4 edits in trunk/WebCore

Reviewed by darin


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing):
  • editing/Editor.h: (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
3:37 PM Changeset in webkit [17751] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Oliver

  • editing/pasteboard/paste-unrendered-select-expected.checksum: Added.
  • editing/pasteboard/paste-unrendered-select-expected.png: Added.
  • editing/pasteboard/paste-unrendered-select-expected.txt: Added.
  • editing/pasteboard/paste-unrendered-select.html: Added.

WebCore:

Reviewed by Oliver


<rdar://problem/4820026>
copy/paste of news.google.com yields text from hidden select element options

We were adding descendants of unrendered select elements.

  • editing/markup.cpp: (WebCore::createMarkup): Don't traverse into nodes without renderers, unless they are grandfathered in by a rendered select element.
3:27 PM Changeset in webkit [22532] by ggaren
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Darin Adler, Anders Carlsson.


More window.open work.


  • Hooked up all of WebChromeClient that the App currently supports.
  • WebChromeClient.cpp: (WebChromeClient::scaleFactor): (WebChromeClient::focus): (WebChromeClient::unfocus): (WebChromeClient::createModalDialog): (WebChromeClient::show): (WebChromeClient::canRunModal): (WebChromeClient::runModal): (WebChromeClient::setToolbarsVisible): (WebChromeClient::toolbarsVisible): (WebChromeClient::setStatusbarVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible): (WebChromeClient::setResizable):
2:59 PM Changeset in webkit [17750] by thatcher
  • 4 edits in tags/Safari-421.30

Versioning

2:40 PM Changeset in webkit [17749] by thatcher
  • 1 copy in tags/Safari-421.30

New tag.

1:46 PM Changeset in webkit [17748] by thatcher
  • 4 edits in trunk/WebKitTools

Explicitly set Dwarf for projects that didn't specify the debugging format.

1:38 PM Changeset in webkit [17747] by thatcher
  • 4 edits in trunk

Switching to Dwarf for Debug and Production. Debuggign will work best with Xcode 2.4.1 or later.

9:42 AM Changeset in webkit [22531] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Fix line-endings and svn properties.

  • WebChromeClient.cpp:
  • WebChromeClient.h:
9:35 AM Changeset in webkit [22530] by aroben
  • 6 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • MarshallingHelpers.cpp:
  • WebChromeClient.cpp:
  • WebChromeClient.h:
  • WebEditorClient.h:
  • WebMutableURLRequest.h:

Nov 12, 2006:

11:13 PM Changeset in webkit [17746] by beidson
  • 3 edits in trunk/WebKit

Rubberstamped by Anders

Changed some #includes from <WebKit/foo.h> to "foo.h"

  • History/WebBackForwardList.m:
  • History/WebHistory.m:
6:57 PM Changeset in webkit [22529] by ggaren
  • 2 edits in branches/WindowsMerge/WebKitWin
  • WebChromeClient.cpp: Fixed up #include.
6:54 PM Changeset in webkit [22528] by ggaren
  • 12 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve Falkenberg.

Implemented window.open. Rough around the edges right now.

  • Converted WebMutableURLRequest to use a ResourceRequest as its backing store, to avoid yet another way of representing this data.
  • Changed WebMutableURLRequests's timeoutInterval to double, to match ResourceRequest and NSURLRequest.
  • Added BSTRToKURL and KURLToBSTR helper functions.
  • Added page accessor on WebView, and core(), for converting from WebView to page.
  • MarshallingHelpers.h: Removed unnecessary variable names from declarations.
3:49 PM Changeset in webkit [22527] by ggaren
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.


Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std
functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)
  • WebCore.vcproj/WebCore.vcproj:

WebKitWin:

Reviewed by Steven Falkenberg.


Fixed up work-arounds to MSVC warning silliness.


Replaced in-place disabling of "conditional expression is constant" warning
with project-wide setting. (We use do { } while(0); for macro scoping.)


Replaced in-place and project-wide disabling of "xxx was declared deprecated"
warning with project-wide setting only to disable Microsoft's made-up deprecation

warnings related to std
functions.
  • WebChromeClient.cpp: (WebChromeClient::setResizable):
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitDLL.h:
3:44 PM Changeset in webkit [17745] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.


Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std
functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)
8:47 AM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Added bug number for navigationController issue (diff)
8:45 AM Writing Layout Tests for DumpRenderTree created by mitz@webkit.org
Copied from Google cache of wiki.opendarwin.org with minimal …
7:18 AM Changeset in webkit [17744] by bdash
  • 7 edits in trunk/WebCore

2006-11-12 Simon Hausmann <​hausmann@kde.org>

Reviewed by Sam Weinig.

Fix Qt build. Missing AbstractShared implementation.
​http://bugs.webkit.org/show_bug.cgi?id=11581

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::ref): (WebCore::FrameLoaderClientQt::deref):
  • loader/qt/FrameLoaderClientQt.h:
  • platform/qt/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ref): (WebCore::ChromeClientQt::deref):
  • platform/qt/ChromeClientQt.h:
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::ref): (WebCore::EditorClientQt::deref):
  • platform/qt/EditorClientQt.h:
4:39 AM BuildingOnWindows edited by ap@webkit.org
added a few more needed cygwin packages (diff)
4:29 AM Changeset in webkit [17743] by bdash
  • 4 edits in trunk/WebCore

2006-11-13 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Fix some Linux/Gdk build issues noted by Alp Toker.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::loadPlatformResource):
4:19 AM BuildingOnWindows created by bdash@webkit.org
Rescue Building on Windows page from the old wiki
1:31 AM Changeset in webkit [17742] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Anders

Logging channel plumbing for future work

  • platform/Logging.cpp: (WebCore::):
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
12:47 AM Changeset in webkit [17741] by bdash
  • 16 edits
    1 delete in trunk

2006-11-12 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Linux/Gdk compilation fixes, and bakefile cleanups. Based on patches by
Alp Toker.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • page/PageState.cpp:
  • platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::ref): (WebCore::ChromeClientGdk::deref):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::~FrameGdk):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/KeyEventGdk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
  • platform/gdk/ScreenClientGdk.h: Removed.
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::canPaste): (FrameGdk::originalRequestURL): (TextField::TextField):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • webcore-base.bkl:

2006-11-12 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Clean up of JavaScriptCore bakefiles.

  • JavaScriptCoreSources.bkl:
  • jscore.bkl:

2006-11-12 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Clean up of GdkLauncher bakefile.

  • GdkLauncher/gdklauncher.bkl:
Note: See TracTimeline for information about the timeline view.