Context Navigation

← Previous Period
Next Period →

Timeline

Nov 14, 2006:

10:57 PM Changeset in webkit [17778] by bdash

4 edits
1 delete in trunk/WebKitSite

2006-11-14 Matt Lilek <pewtermoose@gmail.com>

Reviewed by Tim Hatcher.

Moved the web developer page to the wiki, adding link to the Drosera page.

.htaccess: Add permanent redirect to the new page on the wiki.
contact.html: Trac numbers are no longer one off.
nav.inc:
webdevelopers/index.html: Removed.
webdevelopers/webkit_version.html: Removed.
webdevelopers/webkit_version.js: Removed.
webdevelopers/webkit_version_xl.html: Removed.
webdevelopers/webkit_version_xl.js: Removed.

10:09 PM Changeset in webkit [17777] by bdakin

15 edits in trunk

WebCore:

Reviewed by Geoff.

Moving things off the bridge and onto clients.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::selectWordBeforeMenuEvent): (WebEditorClient::isEditable):
WebCoreSupport/WebFrameBridge.mm:
WebKit.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Geoff.

Move things off the bridge, and move sendContextMenuEvent() from
EventHandlerMac to EventHandler.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
bridge/EditorClient.h:
bridge/mac/WebCoreFrameBridge.h:
editing/Editor.cpp: (WebCore::Editor::selectWordBeforeMenuEvent): (WebCore::Editor::clientIsEditable):
editing/Editor.h:
page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
page/EventHandler.h:
page/mac/EventHandlerMac.mm:

9:42 PM Changeset in webkit [17776] by thatcher

13 edits in trunk

WebCore:

Reviewed by Harrison.

<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)

Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.

bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
page/FrameView.cpp: (WebCore::selectCursor):
page/Settings.h: (WebCore::Settings::):

WebKit:

Reviewed by Harrison.

<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)

Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.

DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]): (-[WebDefaultUIDelegate openNewWindowWithURL:element:]): (-[WebDefaultUIDelegate openLink:]):
English.lproj/Localizable.strings:
WebKit.exp:
WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]):
WebView/WebPreferencesPrivate.h:
WebView/WebUIDelegatePrivate.h:

9:28 PM WebKit Team edited by timothy@apple.com

(diff)

9:17 PM Changeset in webkit [17775] by oliver

2 edits in trunk/WebCore

2006-11-14 Mark Rowe <bdash@webkit.org>

Reviewed by Oliver.

Build fix

bindings/scripts/CodeGenerator.pm:

9:06 PM Changeset in webkit [17774] by andersca

4 edits in trunk

WebCore:

Turns out I wasn't forcing DWARF on the world at all,
it's now the default!

WebCore.xcodeproj/project.pbxproj:

WebKit:

Turns out I wasn't forcing DWARF on the world at all,
it's now the default!

WebKit.xcodeproj/project.pbxproj:

9:01 PM Changeset in webkit [17773] by andersca

4 edits in trunk

WebCore:

I must stop trying to force DWARF on the world.

WebCore.xcodeproj/project.pbxproj:

WebKit:

I must stop trying to force DWARF on the world.

WebKit.xcodeproj/project.pbxproj:

7:52 PM Changeset in webkit [17772] by justing

14 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4806874>
Missing background image after paste

Checking in new expected results for fixes:

editing/inserting/insert-3851164-fix-expected.checksum:
editing/inserting/insert-3851164-fix-expected.png:
editing/selection/drag-in-iframe-expected.checksum:
editing/selection/drag-in-iframe-expected.png:

Same, but also removing an outdated comment about a bug:

editing/pasteboard/paste-text-019-expected.checksum:
editing/pasteboard/paste-text-019-expected.png:
editing/pasteboard/paste-text-019-expected.txt:
editing/pasteboard/paste-text-019.html:

Added:

editing/pasteboard/4806874-expected.checksum: Added.
editing/pasteboard/4806874-expected.png: Added.
editing/pasteboard/4806874-expected.txt: Added.
editing/pasteboard/4806874.html: Added.

Equivalent render trees:

editing/inserting/insert-3907422-fix-expected.txt:
editing/pasteboard/paste-text-011-expected.txt:
editing/pasteboard/paste-text-015-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/4806874>
Missing background image after paste

editing/markup.cpp: (WebCore::createMarkup): If the body is fully selected, add a div with its CSS properties to the markup. Migrated a use of enclosingBlockFlowElement to enclosingBlock to fix an infinite loop when pasting <div><input></div>.

7:20 PM Changeset in webkit [17771] by andersca

2 edits in trunk/WebCore

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Add Undo/Redo to execCommand.

editing/Editor.cpp: (WebCore::execRedo): (WebCore::execUndo): (WebCore::canRedo): (WebCore::canUndo): (WebCore::CommandEntry::):

7:16 PM WikiStart edited by pewtermoose@gmail.com

forgot a page (diff)

7:15 PM WikiStart edited by pewtermoose@gmail.com

linking to the pages I added (diff)

7:12 PM WebDevelopers created by pewtermoose@gmail.com

Web developer oriented resources

7:12 PM DetectingWebKit created by pewtermoose@gmail.com

Moved this from the website

7:12 PM Drosera created by pewtermoose@gmail.com

Some rough Drosera documentation

7:00 PM WebKit Team edited by bdash@webkit.org

(diff)

6:59 PM WebKit Team edited by bdash@webkit.org

(diff)

6:52 PM WebKit Team edited by pewtermoose@gmail.com

(diff)

6:45 PM WebKit Team edited by pewtermoose@gmail.com

Clean up a few cobwebs (diff)

5:40 PM Changeset in webkit [22542] by darin

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Fixed reviewer name (Anders).

5:34 PM Changeset in webkit [22541] by darin

8 edits
3 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by NOBODY (OOPS!).

update for creation of EventHandler

WebCore.vcproj/WebCore.vcproj: Added EventHandler.cpp/h/Win.cpp.

bridge/win/FrameWin.h: Moved virtual functions lastEventIsMouseUp, tabsToLinks, and tabsToAllControls to EventHandler.
bridge/win/FrameWin.cpp: Ditto.

bridge/win/FrameViewWin.cpp: Moved passMousePressEventToSubframe and similar functions to EventHandler.

page/win/EventHandlerWin.cpp: Added. Code from FrameViewWin and FrameWin.

platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::handleMouseReleaseEvent): Call the setMousePressed function in its new home in EventHandler.

platform/win/TemporaryLinkStubs.cpp: Moved lastEventIsMouseUp stub to EventHandler.

WebKitWin:

Reviewed by Anders.

update for creation of EventHandler

WebView.cpp: (WebView::handleMouseEvent): Call methods now moved to EventHandler. (WebView::mouseWheel): Ditto. (WebView::elementAtPoint): Ditto.

5:29 PM Changeset in webkit [17770] by darin

43 edits
5 adds
1 delete in trunk

WebCore:

Reviewed by Anders.

created EventHandler class, moved event handling code from both Frame and FrameView in there

added ScrollTypes.h header so you can include the scroller-related enums without all of Scrollbar.h

page/EventHandler.cpp: Added.
page/EventHandler.h: Added.
page/mac/EventHandlerMac.mm: Added.

platform/ScrollBarMode.h: Removed.
platform/ScrollTypes.h: Added.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::imageFromRect):
bridge/mac/FrameViewMac.mm:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge _visiblePositionForPoint:]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
dom/Document.cpp: (WebCore::Document::hoveredNodeDetached):
dom/Element.h:
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):
editing/SelectionController.h: (WebCore::SelectionController::setCaretBlinkingSuspended): (WebCore::SelectionController::isCaretBlinkingSuspended):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus):
html/HTMLFrameElementBase.h:
html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::open):

page/Frame.cpp: (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::frameForWidget): (WebCore::Frame::eventHandler): (WebCore::Frame::setProhibitsScrolling): (WebCore::FramePrivate::FramePrivate):
page/Frame.h:
page/FramePrivate.h:
page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::addRepaintInfo): (WebCore::FrameView::layout): (WebCore::FrameView::scrollPointRecursively): (WebCore::FrameView::setContentsPos): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents): (WebCore::FrameView::windowClipRectForLayer): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
page/FrameView.h:
page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restore):
page/PageState.h:
platform/ScrollBar.h:
platform/ScrollView.h:
platform/mac/ClipboardMac.mm:
platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
platform/mac/SliderMac.mm: (-[WebCoreSlider becomeFirstResponder]): (-[WebCoreSlider nextKeyView]): (-[WebCoreSlider previousKeyView]): (-[WebCoreSlider canBecomeKeyView]): (Slider::focusPolicy):
platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]): (-[WebCoreTextFieldController setHasFocus:]): (-[WebCoreSearchField nextKeyView]): (-[WebCoreSearchField previousKeyView]): (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
platform/mac/WidgetMac.mm: (WebCore::Widget::hasFocus): (WebCore::Widget::clearFocus):
rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::setResizing):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::updateOverflowStatus):
rendering/RenderLayer.h:
rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll):
rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::destroy):
rendering/RenderObject.h: (WebCore::RenderObject::RepaintInfo::RepaintInfo):
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):

WebKit:

Reviewed by Anders.

update for creation of EventHandler

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary):
WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]): (-[WebHTMLView elementAtPoint:allowShadowContent:]):

5:21 PM Changeset in webkit [17769] by andersca

2 edits in trunk/WebKit

Fix build for real this time.

WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]):

5:07 PM Changeset in webkit [17768] by andersca

2 edits in trunk/WebKit

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Try fixing the build.

WebCoreSupport/WebEditorClient.mm: (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]):

5:07 PM Changeset in webkit [22540] by andersca

3 edits in branches/WindowsMerge/WebKitWin

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Build fix.

WebEditorClient.cpp: (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
WebEditorClient.h:

4:36 PM Changeset in webkit [17767] by andersca

19 edits
2 deletes in trunk

WebCore:

Reviewed by Darin.

Let the editor client handle undo/redo.

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
bridge/EditorClient.h:
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::canUndo): (WebCore::FrameMac::canRedo):
bridge/mac/WebCoreEditCommand.h: Removed.
bridge/mac/WebCoreEditCommand.mm: Removed.
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm:
editing/Editor.cpp: (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
editing/JSEditor.cpp:
loader/FrameLoader.cpp: (WebCore::FrameLoader::closeURL):
page/Frame.cpp:
page/Frame.h:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement):

WebKit:

Reviewed by Darin.

Move undo/redo handling into WebEditorClient.

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]): (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]): (undoNameForEditAction): (WebEditorClient::registerCommandForUndoOrRedo): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
WebCoreSupport/WebFrameBridge.mm:
WebKit.xcodeproj/project.pbxproj:

3:02 PM Web Inspector edited by pewtermoose@gmail.com

Add how to use with OmniWeb (diff)

2:33 PM Changeset in webkit [17766] by beidson

5 edits in trunk/WebCore

Reviewed and landed by Brady

Fix Qt/Linux build.

ChangeLog:
loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::add):
platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::submitForm):
platform/qt/FrameQtClient.h:

1:51 PM Changeset in webkit [17765] by thatcher

1 edit in trunk/WebKitSite/nav.inc

Fixing the site.

1:45 PM Changeset in webkit [17764] by sfalken

1 copy in tags/Safari-521.30.1b

New tag.

1:44 PM Changeset in webkit [17763] by bdash

3 edits in trunk/WebKitSite

2006-11-14 Mark Rowe <bdash@webkit.org>

Reviewed by Tim Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=9529
Bug 9529: Navigation HTML duplicated on webkit.org web site

blog/wp-content/themes/webkit/sidebar.php: Include navigation from nav.inc rather than duplicating it here.
nav.inc: Generate WordPress archive list if included from within WordPress.

11:56 AM Changeset in webkit [22539] by beidson

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders

Additional tweek to the FormData change

WebFrame.cpp: (WebFrame::loadDataSource):

11:52 AM Changeset in webkit [17762] by beidson

9 edits in trunk/WebCore

Reviewed by Anders

Cleanup of my patch last night and merging with aroben-style changes from this morning
(More ref-counted FormData stuff)

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
platform/network/ResourceHandle.h:
platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody):
platform/network/mac/FormDataStreamMac.h:
platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest):

11:44 AM Changeset in webkit [22538] by aroben

15 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Replace all instances of DebugBreak() with ASSERT_NOT_REACHED() so that
it will be compiled out for Release builds.

DOMCSSClasses.cpp:
DOMCoreClasses.cpp:
DOMHTMLClasses.cpp:
WebBackForwardList.cpp:
WebDataSource.cpp:
WebFrame.cpp:
WebHTMLRepresentation.cpp:
WebHistoryItem.cpp:
WebIconDatabase.cpp:
WebMutableURLRequest.cpp:
WebNotification.cpp:
WebPreferences.cpp:
WebScriptObject.cpp:
WebView.cpp:

10:57 AM Changeset in webkit [17761] by ap

3 edits
6 adds in trunk

2006-11-14 Rob Buis <buis@kde.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11575
Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer

Test: fast/css/css-imports.html

css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Fix the crash by testing for null pointer.

10:11 AM Changeset in webkit [17760] by ap

4 edits
1 add in trunk

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.

For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
WebView/WebHTMLViewInternal.h:

10:06 AM Changeset in webkit [17759] by aroben

5 edits in trunk/WebCore

2006-11-14 Darin Adler <Darin Adler>

Reviewed by Adam.

Fix up usages of FormData within CFNet loader code.

platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody):
platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the streamFormDatas HashMap. (WebCore::formCreate): (WebCore::formFinalize): Removed delete because the remove() will deref and delete if necessary. (WebCore::setHTTPBody): Changed parameter to PassRefPtr. (WebCore::httpBodyFromStream):
platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::getResourceRequest):

7:39 AM Changeset in webkit [17758] by spadma

4 edits in S60/trunk/WebKit

2006-11-10 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11569

BrowserCore/Renderers/src/TextRendererFactory.cpp:

7:25 AM Changeset in webkit [17757] by spadma

4 edits in S60/branches/3.1m/WebKit

2006-11-10 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11569

BrowserCore/Renderers/src/TextRendererFactory.cpp:

3:55 AM Changeset in webkit [17756] by bdash

2 edits in trunk/WebCore

2006-11-14 Greg Jackson <gjspanner@gmail.com>

Reviewed by Darin.

Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
rather than overriding it based on platform detection.

bindings/js/kjs_navigator.cpp:

2:13 AM BuildingGdk edited by alp@atoker.com

(diff)

2:11 AM BuildingGdk created by alp@atoker.com

Nov 13, 2006:

11:59 PM Changeset in webkit [22537] by beidson

9 edits in branches/WindowsMerge

WebCoreWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared

bridge/win/FrameWin.h:
loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared

WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::submitForm):
WebFrame.h:
WebMutableURLRequest.cpp: (WebMutableURLRequest::setFormData): (WebMutableURLRequest::formData):
WebMutableURLRequest.h:

7:54 PM Changeset in webkit [17755] by beidson

16 edits in trunk/WebCore

Reviewed by Maciej

Made FormData Shared, and pass it around as such.

WebCore.xcodeproj/project.pbxproj: Reordered some items
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
html/HTMLFormElement.h:
loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::FrameLoader::submitForm):
loader/FrameLoader.h:
loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadResourceSynchronously):
loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
platform/network/FormData.h: Made FormData shared
platform/network/ResourceHandle.h:
platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody):
platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest): (WebCore::nsURLRequest):

platform/network/mac/FormDataStreamMac.h:
platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):

7:01 PM Changeset in webkit [22536] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-11-13 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Make sure to call valueChanged after hiding the popup so that change events will be delivered correctly.

6:45 PM Changeset in webkit [17754] by justing

3 edits in trunk/LayoutTests/editing/selection

I accidently checked in old expected results in my previous checkin.

6:37 PM Changeset in webkit [17753] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

editing/selection/drag-select-1-expected.checksum: Added.
editing/selection/drag-select-1-expected.png: Added.
editing/selection/drag-select-1-expected.txt: Added.
editing/selection/drag-select-1.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4828264>
In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)

The start of the selection is in an editable area, and the end is in an
input field inside that editable area. The code that should pull the end
of such a selection outside the input field didn't escape shadow nodes,
it would leave a dangling end, causing the crash in toRange.

editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Added an ASSERT and a fixup to prevent crashes like this in future Release builds.
editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Let this function escape shadow nodes. We might eventually push this code down into next/previous{VisuallyDistinct}Canditate. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.

6:09 PM Changeset in webkit [22535] by andersca

2 edits in branches/WindowsMerge/WebKitWin

2006-11-13 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Various editing fixes.

WebView.cpp: (WebView::execCommand): Use the focused frame, not the main frame.

(WebView::focusedTarget):
Add FIXME comment.

(WebView::keyDown):
Return false for unknown keydown messages when not in editing mode.

5:27 PM Changeset in webkit [22534] by aroben

1 edit in branches/WindowsMerge/WebCore/platform/network/win/CookieJarWin.cpp

Fix line endings.

5:21 PM Changeset in webkit [22533] by sfalken

4 edits in branches/WindowsMerge

2006-11-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Anders, Lou.

Fix merge script

WebCore.vcproj/merge-opensource.sh: Don't copy cairo, pixman

2006-11-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Anders, Lou.

Bump version for submit
Copy CharacterSets directory for CF

WebKit.vcproj/VERSION: Bump version
WebKit.vcproj/WebKit.vcproj: Copy CharacterSets

3:56 PM Changeset in webkit [17752] by justing

4 edits in trunk/WebCore

Reviewed by darin

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
editing/Editor.cpp: (WebCore::Editor::appliedEditing):
editing/Editor.h: (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.

3:37 PM Changeset in webkit [17751] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Oliver

editing/pasteboard/paste-unrendered-select-expected.checksum: Added.
editing/pasteboard/paste-unrendered-select-expected.png: Added.
editing/pasteboard/paste-unrendered-select-expected.txt: Added.
editing/pasteboard/paste-unrendered-select.html: Added.

WebCore:

Reviewed by Oliver

<rdar://problem/4820026>
copy/paste of news.google.com yields text from hidden select element options

We were adding descendants of unrendered select elements.

editing/markup.cpp: (WebCore::createMarkup): Don't traverse into nodes without renderers, unless they are grandfathered in by a rendered select element.

3:27 PM Changeset in webkit [22532] by ggaren

2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Darin Adler, Anders Carlsson.

More window.open work.

Hooked up all of WebChromeClient that the App currently supports.

WebChromeClient.cpp: (WebChromeClient::scaleFactor): (WebChromeClient::focus): (WebChromeClient::unfocus): (WebChromeClient::createModalDialog): (WebChromeClient::show): (WebChromeClient::canRunModal): (WebChromeClient::runModal): (WebChromeClient::setToolbarsVisible): (WebChromeClient::toolbarsVisible): (WebChromeClient::setStatusbarVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible): (WebChromeClient::setResizable):

2:59 PM Changeset in webkit [17750] by thatcher