⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 17, 2006:

9:57 PM Changeset in webkit [17838] by andersca
  • 10 edits in trunk/WebCore

Reviewed by Geoff.

More conversions from DeprecatedValueList to Vector and HashSet.


  • css/CSSValueList.cpp: (WebCore::CSSValueList::~CSSValueList): (WebCore::CSSValueList::append): (WebCore::CSSValueList::cssText):
  • css/CSSValueList.h: (WebCore::CSSValueList::length): (WebCore::CSSValueList::item):
  • dom/Document.cpp: (WebCore::Document::attachNodeIterator): (WebCore::Document::notifyBeforeNodeRemoval):
  • dom/Document.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::notifyAttributeChange):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::notifyClientsToRepaint):
  • platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient):
  • platform/graphics/svg/SVGResource.h:
  • rendering/RenderBlock.h:
7:29 PM Changeset in webkit [22561] by andersca
  • 19 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Add #defines in config.h to prevent the min and max macros from being used.

  • bridge/win/FrameWin.cpp:
  • config.h:
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/win/PopupMenuWin.cpp:
  • plugins/win/PluginStreamWin.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Reviewed by Adam.

Make sure that all .cpp files and none of the headers include config.h.


  • MemoryStream.cpp:
  • WebBackForwardList.cpp:
  • WebBackForwardList.h:
  • WebElementPropertyBag.cpp:
  • WebHTMLRepresentation.cpp:
  • WebKitClassFactory.cpp:
  • WebKitDLL.cpp:
  • WebMutableURLRequest.cpp:
  • WebMutableURLRequest.h:
  • WebURLResponse.cpp:
  • WebURLResponse.h:
7:15 PM Changeset in webkit [17837] by andersca
  • 4 edits in trunk/JavaScriptCore

2006-11-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

Make sure that we always use std::min and std::max instead of macros.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/config.h:
  • wtf/Vector.h:
7:09 PM Changeset in webkit [22560] by kmccullo
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • Fixes Targetted Form Submission to now work. Radar: 4762693
  • ChangeLog:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
6:24 PM Changeset in webkit [17836] by thatcher
  • 1 edit in trunk/WebCore/editing/EditCommand.cpp

Fixing the assertion failure, forgot to remove an enable() call.

5:24 PM Changeset in webkit [17835] by thatcher
  • 1 edit
    8 copies in tags/Safari-521.31

New tag.

5:21 PM Changeset in webkit [17834] by thatcher
  • 6 edits in /

Versioning

5:06 PM Changeset in webkit [17833] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made

Disable the delete button controller when cloning nodes, Mail does this before saving a draft.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
  • editing/markup.cpp: (WebCore::createFragmentFromNodes):
5:04 PM Changeset in webkit [17832] by justing
  • 9 edits
    12 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation

Fixed:

  • editing/pasteboard/merge-end-blockquote-expected.checksum:
  • editing/pasteboard/merge-end-blockquote-expected.png:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-blockquote.html:


Added:

  • editing/pasteboard/paste-blockquote-1-expected.checksum: Added.
  • editing/pasteboard/paste-blockquote-1-expected.png: Added.
  • editing/pasteboard/paste-blockquote-1-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-1.html: Added.
  • editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
  • editing/pasteboard/paste-blockquote-2-expected.png: Added.
  • editing/pasteboard/paste-blockquote-2-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-2.html: Added.
  • editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
  • editing/pasteboard/paste-blockquote-3-expected.png: Added.
  • editing/pasteboard/paste-blockquote-3-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-3.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation

  • editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Added. Checks for the node that Mail wraps around an incoming fragment when it wants it to be pasted with quoting (no merging should be done). (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added this virtual method in order to adjust the nodes that ReplaceSelectionCommand tracks. (WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content inside a Mail Paste as Quotation node. Allow merging from Mail blockquotes. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into a Mail blockquote, we ignore the parts of the source document's default style that are overriden by styles from the Mail blockquote. This is necessary in order for text that's black (because black is the source document's default font color) to appear blue/green/whatever when it's pasted into a Mail blockquote. (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted Mail Paste as Quotation node into a normal Mail blockquote. This will prevent a copied blockquote that was inserted into the document using Paste as Quotation from triggering Paste as Quotation behavior when it's pasted. (WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
  • editing/ReplaceSelectionCommand.h:
  • editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine. (WebCore::removeEnclosingMailBlockquoteStyle): Added. (WebCore::startMarkup): When wrapping text nodes in style spans, leave out styles that Mail blockquotes contribute, so that Mail blockquote styles can be differentiated from styles that the user has applied. When creating markup for elements, do the same thing. (WebCore::createMarkup): Call the new subroutine.
4:22 PM Changeset in webkit [17831] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Forgoet the project change.

4:21 PM Changeset in webkit [17830] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.mm: (+[WebView initialize]): (-[WebView setPreferences:]):
4:04 PM Changeset in webkit [22559] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adele.

  • fix leak of Document ref count seen in updateCounterpartURLForRSS
  • WebScriptObject.h: Changed destructor to be virtual. Without this, when the COM object was released we wouldn't release the underlying WebCore::Node.
12:14 PM Changeset in webkit [17829] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11635
Bug 11635: Fix potential issue with non-xslt build

Fix the issue and do style guideline corrections.

11:47 AM Changeset in webkit [17828] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it

Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside

  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply): (WebCore::applyCommand):
  • editing/EditCommand.h:
11:42 AM Changeset in webkit [22558] by darin
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adele.

  • fix leak of WebView when you close a tab or window
  • Interfaces/IWebView.idl: Added a close function, like the close method we added to WebView on the Macintosh side.
  • WebView.h: Added close function.
  • WebView.cpp: (WebView::close): First cut at implementation of close.
11:23 AM Changeset in webkit [17827] by zimmermann
  • 13 edits
    5 adds in trunk

Reviewed by Mitz. Landed by Niko.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11617
Adapt to latest API changes, fixing Qt/Linux build.

11:21 AM Changeset in webkit [17826] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer

Replace an assert with a fixme that refers to this bug.


  • page/Frame.cpp: (WebCore::Frame::revealSelection):

Nov 16, 2006:

7:04 PM Changeset in webkit [22557] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve, Ada.

Added new WebMenuItemBaseApplicationTag to the WebMenuItemTag enum to
keep WebKit apps from conflicting with WebKit context menu identifiers.

  • Interfaces/IWebUIDelegate.idl:
6:11 PM Changeset in webkit [17825] by beidson
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Brady

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=11590
Bug 11590: REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render

  • fast/css/import-rule-regression-11590-expected.txt: Added.
  • fast/css/import-rule-regression-11590.html: Added.
  • fast/css/resources/imports.css: Added.
  • fast/css/resources/style.css: Added.

WebCore:

Reviewed and landed by Brady

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11590 -
REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
Fix the regression by setting m_loadCompleted correctly.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • dom/Node.h: (WebCore::Node::sheetLoaded):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
  • dom/ProcessingInstruction.h:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::sheetLoaded):
  • html/HTMLLinkElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::sheetLoaded):
  • html/HTMLStyleElement.h:
5:06 PM Changeset in webkit [17824] by harrison
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Beth.

<rdar://problem/4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message

The problem was triggered by the fact that the parent div was changing both
in position and in height. The renderer normally bifurcates its logic for
x-position changes vs height changes.

Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position.

Test added:

  • manual-tests/delete-into-nested-block.html


  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::positionNewFloats):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved):
  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintDuringLayoutIfMoved):
  • rendering/RenderObject.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
4:07 PM Changeset in webkit [22556] by adele
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adam.

Added theme for sider.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::sliderTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::determineSliderThumbState): (WebCore::RenderThemeWin::getClassicThemeData): (WebCore::RenderThemeWin::getThemeData): (WebCore::drawControl): (WebCore::RenderThemeWin::paintSliderTrack): (WebCore::RenderThemeWin::paintSliderThumb): (WebCore::RenderThemeWin::adjustSliderThumbSize):
  • rendering/RenderThemeWin.h:
4:03 PM Changeset in webkit [17823] by adele
  • 7 edits in trunk/WebCore

Reviewed by Adam.

Slider cleanup. Let the theme set the size of the slider thumb.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Let the theme set the size of the thumb.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize): Added.
  • rendering/RenderTheme.h: ditto.
  • rendering/RenderThemeMac.h: ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto.
3:34 PM Changeset in webkit [17822] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2006-11-15 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
​http://bugs.webkit.org/show_bug.cgi?id=110606

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):
3:27 PM Changeset in webkit [17821] by spadma
  • 3 edits in S60/trunk/WebKit

2006-11-15 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
​http://bugs.webkit.org/show_bug.cgi?id=110606

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):
3:24 PM Changeset in webkit [17820] by spadma
  • 7 edits in S60/trunk/WebKit

2006-11-16 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Fix copyright issues
​http://bugs.webkit.org/show_bug.cgi?id=11620

  • BrowserView/inc/WidgetExtension.h:
  • BrowserView/inc/WidgetPreferences.h:
  • BrowserView/inc/WidgetRenderer.h:
  • BrowserView/src/WidgetExtension.cpp:
  • BrowserView/src/WidgetPreferences.cpp:
  • BrowserView/src/WidgetRenderer.cpp: (TWidgetRenderer::TWidgetRenderer): (TWidgetRenderer::PrepareForTransitionL): (TWidgetRenderer::PerformTransitionL): (TWidgetRenderer::TransitionCb): (TWidgetRenderer::DrawFadeMaskL): (TWidgetRenderer::DrawTransition):
2:54 PM Changeset in webkit [17819] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-15 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Feeds Engine / Form element in feed article: If input box is selected the browser crashes.
​http://bugs.webkit.org/show_bug.cgi?id=11603

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::SetCursorPositionL):
1:22 PM Changeset in webkit [17818] by andersca
  • 19 edits in trunk/WebCore

Reviewed by Darin.

Use Vector instead of DeprecatedValueList in a few places.


  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLCollection::getNamedItems):
  • bindings/objc/DOM.mm:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::dashboardRegionsDictionary):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::diff):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::namedItems):
  • html/HTMLCollection.h:
  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack): (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
  • platform/graphics/svg/SVGResourceClipper.h:
  • platform/graphics/svg/cg/SVGResourceClipperCg.cpp: (WebCore::SVGResourceClipper::applyClip):
  • platform/network/FormData.h:
  • rendering/RenderPath.h:
  • rendering/SVGRenderTreeAsText.h: (WebCore::operator<<):
1:03 PM Changeset in webkit [17817] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Tim.

  • editing/markup.cpp: (WebCore::createMarkup): Add null-checks for the frame, it might not exist for all documents.
12:32 PM Changeset in webkit [17816] by ap
  • 23 edits
    2 adds
    1 delete in trunk

2006-11-16 Don Gibson <​dgibson77@gmail.com>

Reviewed and landed by ap.

​http://bugs.webkit.org/show_bug.cgi?id=11509:
Windows build bustage.

Also reorganizes WebCore.vcproj to add files whose absence wasn't
causing compile errors, but which should have been there, and to
make the include directory ordering (and contents) sane.
Also reorganizes TemporaryLinkStubs.cpp to put headers and
function groups in alphabetical order, and ensure that all functions
in the file call notImplemented().

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
  • bridge/win/ContextMenuClientWin.h: Added. (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
  • bridge/win/EditorClientWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin): (WebCore::FrameWin::keyPress):
  • bridge/win/FrameWin.h:
  • bridge/win/PageWin.cpp: Removed.
  • editing/EditCommand.h:
  • loader/FormState.h:
  • loader/FrameLoader.h:
  • page/EventHandler.cpp:
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
  • platform/graphics/win/ImageWin.cpp:
  • platform/network/ResourceError.cpp:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
  • platform/win/ScreenWin.cpp: (WebCore::monitorInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth):
  • platform/win/SoundWin.cpp: Added. (WebCore::systemBeep):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (WebCore::defaultLanguage): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::findNextSentenceFromIndex): (WebCore::findNextWordFromIndex): (WebCore::findSentenceBoundary): (WebCore::findWordBoundary): (WebCore::focusRingColor): (WebCore::historyContains): (WebCore::inputElementAltText): (WebCore::IsResponseURLEqualToURL): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::refreshPlugins): (WebCore::resetButtonDefaultLabel): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::ResponseURL): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::searchableIndexIntroduction): (WebCore::ServeSynchronousRequest): (WebCore::setFocusRingColorChangeFunction): (WebCore::submitButtonDefaultLabel): (WebCore::CachedResource::setPlatformResponse): (WebCore::CachedResource::setAllData): (WebCore::ChromeClientWin::setWindowRect): (WebCore::ChromeClientWin::windowRect): (WebCore::ChromeClientWin::pageRect): (WebCore::ChromeClientWin::scaleFactor): (WebCore::ChromeClientWin::focus): (WebCore::ChromeClientWin::unfocus): (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::ChromeClientWin::show): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::ChromeClientWin::setToolbarsVisible): (WebCore::ChromeClientWin::toolbarsVisible): (WebCore::ChromeClientWin::setStatusbarVisible): (WebCore::ChromeClientWin::statusbarVisible): (WebCore::ChromeClientWin::setScrollbarsVisible): (WebCore::ChromeClientWin::scrollbarsVisible): (WebCore::ChromeClientWin::setMenubarVisible): (WebCore::ChromeClientWin::menubarVisible): (WebCore::ChromeClientWin::setResizable): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuClientWin::addCustomContextMenuItems): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::tabsToLinks): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameView::updateBorder): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineWidth): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint): (WebCore::IconDatabase::isIconExpiredForIconURL): (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::Image::drawTiled): (WebCore::Image::getHBITMAP): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::PlatformMouseEvent::PlatformMouseEvent): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::clearRequest): (WebCore::PolicyCheck::call): (WebCore::RenderThemeWin::systemFont): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::ResourceLoader::cancel): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollPointRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::paint): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::themeChanged): (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild): (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::TextField::selectAll): (WebCore::TextField::addSearchResult): (WebCore::TextField::selectionStart): (WebCore::TextField::hasSelectedText): (WebCore::TextField::selectedText): (WebCore::TextField::setAutoSaveName): (WebCore::TextField::checksDescendantsForFocus): (WebCore::TextField::setSelection): (WebCore::TextField::setMaxResults): (WebCore::TextField::edited): (WebCore::TextField::focusPolicy): (WebCore::TextField::TextField): (WebCore::TextField::~TextField): (WebCore::TextField::setFont): (WebCore::TextField::setAlignment): (WebCore::TextField::setWritingDirection): (WebCore::TextField::maxLength): (WebCore::TextField::setMaxLength): (WebCore::TextField::text): (WebCore::TextField::setText): (WebCore::TextField::cursorPosition): (WebCore::TextField::setCursorPosition): (WebCore::TextField::setEdited): (WebCore::TextField::setReadOnly): (WebCore::TextField::setPlaceholderString): (WebCore::TextField::setColors): (WebCore::TextField::sizeForCharacterWidth): (WebCore::TextField::baselinePosition): (WebCore::TextField::setLiveSearch): (WebCore::Widget::enableFlushDrawing): (WebCore::Widget::isEnabled): (WebCore::Widget::focusPolicy): (WebCore::Widget::disableFlushDrawing): (WebCore::Widget::removeFromParent): (WebCore::Widget::lockDrawingFocus): (WebCore::Widget::unlockDrawingFocus): (WebCore::Widget::capturingMouse): (WebCore::Widget::setCapturingMouse): (WebCore::Widget::capturingTarget): (WebCore::Widget::capturingChild): (WebCore::Widget::setCapturingChild): (WebCore::Widget::convertChildToSelf): (WebCore::Widget::convertSelfToChild): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::setEnabled): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::clearFocus):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::receivedResponse): (WebFrame::receivedAllData):
  • COM/WebFrame.h:
  • COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick):
  • WebKit.vcproj/WebKit.vcproj:
11:58 AM Changeset in webkit [17815] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made

  • editing/markup.cpp: (WebCore::createMarkup): disable the delete button so it's elements are not serialized into the markup
11:52 AM Changeset in webkit [17814] by staikos
  • 3 edits in trunk/WebCore

Rubberstamped by Maciej.

Making the code valgrind clean.

11:49 AM Changeset in webkit [17813] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Tim.

<rdar://problem/4841123>
REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message


  • Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]): If the range passed in is null, return null. When this function was in the bridge, it would never get called with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
10:35 AM Changeset in webkit [17812] by thatcher
  • 1 edit in trunk/WebCore/editing/DeleteButtonController.h

Adding back a correct version of this assert.

9:59 AM Changeset in webkit [17811] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin and Tim.

<rdar://problem/4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page


  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): Add nil check of hitTest's result.innerNode().
9:52 AM Changeset in webkit [17810] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4836897> Deletion rectangle disappears when multiple list items are selected

Consider the container of the selection range for deletion before asking enclosingNodeOfType().

  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
9:09 AM Changeset in webkit [17809] by spadma
  • 6 edits in S60/branches/3.1m/WebKit

2006-11-16 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Modify Autoload Images and Objects setting to include enabling/disabling of flash.
​http://bugs.webkit.org/show_bug.cgi?id=11605

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
12:43 AM Changeset in webkit [17808] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by hyatt.

Removal of unused m_styleElement.

Note: See TracTimeline for information about the timeline view.