⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 18, 2006:

11:20 PM Changeset in webkit [22563] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:18 PM Changeset in webkit [17851] by sfalken
  • 1 copy in tags/Safari-521.31b

New tag.

6:44 PM Changeset in webkit [17850] by zimmermann
  • 59 edits
    41 copies
    61 adds
    6 deletes in trunk/WebCore

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11596

Split up KCanvasFilters & KCanvasFilterQuartz into several
new classes (SVGFEBlend, SVGFEComposite...) and move them
into platform/graphics/svg. This is still a temporary location,
as discussed with Darin; the whole platform/graphics/svg directory
will probably be moved into ksvg2/ in near future.

This commit removes the duplicated enumerations in the svg filter
classes and within kcanvas. ksvg2/ and platform/graphics/svg share
their enums now.

4:47 PM Changeset in webkit [17849] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.

Add tests for crash when garbage collecting node iterators and tree walkers
without a node filter.


  • fast/dom/node-filter-gc-expected.txt: Added.
  • fast/dom/node-filter-gc.html: Added.
3:45 PM Changeset in webkit [22562] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix from OpenSource r17841.

  • platform/win/CursorWin.cpp: New method stubs. (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
2:59 PM Changeset in webkit [17848] by rwlbuis
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

  • fast/css/target-fragment-match-expected.checksum: Added.
  • fast/css/target-fragment-match-expected.png: Added.
  • fast/css/target-fragment-match-expected.txt: Added.
  • fast/css/target-fragment-match.html: Added.

WebCore:

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

Make sure the page does a style recalculation and possible rendering
when navigating back from a page with an anchor to a page without
an anchor.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
12:58 PM Changeset in webkit [17847] by ap
  • 10 edits
    2 adds in trunk

2006-11-18 Don Gibson <dgibson77@gmail.com>

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=11634:
Fix segfault on startup for Windows build. Also fix segfault when
typing in a URL.
Clean up some of the style of the patch that landed in r17816.

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::~ChromeClientWin): (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
  • bridge/win/ContextMenuClientWin.h: (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
  • bridge/win/EditorClientWin.h: (WebCore::EditorClientWin::~EditorClientWin): (WebCore::EditorClientWin::ref): (WebCore::EditorClientWin::deref):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • bridge/win/FrameWin.h: (WebCore::Win):
  • loader/win/FrameLoaderClientWin.h: Added. (WebCore::FrameLoaderClientWin::~FrameLoaderClientWin): (WebCore::FrameLoaderClientWin::ref): (WebCore::FrameLoaderClientWin::deref):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::EditorClientWin::selectWordBeforeMenuEvent): (WebCore::EditorClientWin::isEditable): (WebCore::EditorClientWin::shouldBeginEditing): (WebCore::EditorClientWin::shouldEndEditing): (WebCore::EditorClientWin::shouldApplyStyle): (WebCore::EditorClientWin::didBeginEditing): (WebCore::EditorClientWin::respondToChangedContents): (WebCore::EditorClientWin::didEndEditing): (WebCore::EditorClientWin::registerCommandForUndo): (WebCore::EditorClientWin::registerCommandForRedo): (WebCore::EditorClientWin::clearUndoRedoOperations): (WebCore::EditorClientWin::canUndo): (WebCore::EditorClientWin::canRedo): (WebCore::EditorClientWin::undo): (WebCore::EditorClientWin::redo): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoaderClientWin::hasWebView): (WebCore::FrameLoaderClientWin::hasFrameView): (WebCore::FrameLoaderClientWin::hasBackForwardList): (WebCore::FrameLoaderClientWin::resetBackForwardList): (WebCore::FrameLoaderClientWin::provisionalItemIsTarget): (WebCore::FrameLoaderClientWin::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientWin::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientWin::privateBrowsingEnabled): (WebCore::FrameLoaderClientWin::makeDocumentView): (WebCore::FrameLoaderClientWin::makeRepresentation): (WebCore::FrameLoaderClientWin::forceLayout): (WebCore::FrameLoaderClientWin::forceLayoutForNonHTML): (WebCore::FrameLoaderClientWin::updateHistoryForCommit): (WebCore::FrameLoaderClientWin::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientWin::updateHistoryForReload): (WebCore::FrameLoaderClientWin::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientWin::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientWin::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientWin::setCopiesOnScroll): (WebCore::FrameLoaderClientWin::tokenForLoadErrorReset): (WebCore::FrameLoaderClientWin::resetAfterLoadError): (WebCore::FrameLoaderClientWin::doNotResetAfterLoadError): (WebCore::FrameLoaderClientWin::willCloseDocument): (WebCore::FrameLoaderClientWin::detachedFromParent1): (WebCore::FrameLoaderClientWin::detachedFromParent2): (WebCore::FrameLoaderClientWin::detachedFromParent3): (WebCore::FrameLoaderClientWin::detachedFromParent4): (WebCore::FrameLoaderClientWin::loadedFromPageCache): (WebCore::FrameLoaderClientWin::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientWin::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientWin::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientWin::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientWin::dispatchWillClose): (WebCore::FrameLoaderClientWin::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientWin::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientWin::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWin::dispatchDidFinishLoad): (WebCore::FrameLoaderClientWin::dispatchDidFirstLayout): (WebCore::FrameLoaderClientWin::dispatchShow): (WebCore::FrameLoaderClientWin::cancelPolicyCheck): (WebCore::FrameLoaderClientWin::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWin::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientWin::clearLoadingFromPageCache): (WebCore::FrameLoaderClientWin::isLoadingFromPageCache): (WebCore::FrameLoaderClientWin::revertToProvisionalState): (WebCore::FrameLoaderClientWin::clearUnarchivingState): (WebCore::FrameLoaderClientWin::progressStarted): (WebCore::FrameLoaderClientWin::progressCompleted): (WebCore::FrameLoaderClientWin::setMainFrameDocumentReady): (WebCore::FrameLoaderClientWin::willChangeTitle): (WebCore::FrameLoaderClientWin::didChangeTitle): (WebCore::FrameLoaderClientWin::finishedLoading): (WebCore::FrameLoaderClientWin::finalSetupForReplace): (WebCore::FrameLoaderClientWin::setDefersLoading): (WebCore::FrameLoaderClientWin::isArchiveLoadPending): (WebCore::FrameLoaderClientWin::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientWin::clearArchivedResources): (WebCore::FrameLoaderClientWin::canShowMIMEType): (WebCore::FrameLoaderClientWin::representationExistsForURLScheme): (WebCore::FrameLoaderClientWin::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientWin::frameLoadCompleted): (WebCore::FrameLoaderClientWin::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientWin::provisionalLoadStarted): (WebCore::FrameLoaderClientWin::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientWin::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientWin::didFinishLoad): (WebCore::FrameLoaderClientWin::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientWin::setTitle): (WebCore::FrameLoaderClientWin::userAgent):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::initWithName):
12:19 PM Changeset in webkit [17846] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2006-11-16 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas <zbujtas@gmail.com>.
Merged from 3.2 r17845
DESC: Image map using ID attribute cannot be activated
http://bugs.webkit.org/show_bug.cgi?id=11618

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):
12:17 PM Changeset in webkit [17845] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-16 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas <zbujtas@gmail.com>.
DESC: Image map using ID attribute cannot be activated
http://bugs.webkit.org/show_bug.cgi?id=11618

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):
11:29 AM Changeset in webkit [17844] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-16 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Fix for tabbed navigation
http://bugs.webkit.org/show_bug.cgi?id=11619

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):
11:25 AM Changeset in webkit [17843] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-16 shkeller <shaun.keller@nokia.com>

Reviewed by zalan.
DESC: render object of image type was wrongly typecast and move brace so changelog script works
http://bugs.webkit.org/show_bug.cgi?id=11608

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::getObjectInstance): (HTMLObjectElementImpl::isFocusable):
5:52 AM Changeset in webkit [17842] by ap
  • 5 edits in trunk

Reviewed by Rob (yay!).

http://bugs.webkit.org/show_bug.cgi?id=11640
XMLHttpRequest produces undefined:undefined HTTP authentication

WebCore:

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Treat undefined credentials as missing ones.

LayoutTests:

  • http/tests/xmlhttprequest/basic-auth-expected.txt:
  • http/tests/xmlhttprequest/basic-auth.html: Added tests for undefined.
3:24 AM Nightly Builds edited by mitz@webkit.org
Changed to talk about Safari extensions in general rather than about a … (diff)
3:01 AM Known incompatibilities between open-source WebKit and Safari edited by mitz@webkit.org
Deleted obsolete information. The context menu items are present and … (diff)
2:00 AM Changeset in webkit [17841] by ap
  • 9 edits
    3 adds in trunk/WebCore

2006-11-17 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=11638
[CSS 2.1+3] add support for alias, progress, no-drop and not-allowed cursor styles

  • Resources/aliasCursor.png: Added.
  • Resources/noDropCursor.png: Added.
  • Resources/progressCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • manual-tests/cursor.html:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::handCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
  • rendering/RenderStyle.h: (WebCore::):
1:30 AM Changeset in webkit [17840] by ap
  • 2 edits in trunk/WebKitSite

2006-11-18 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

Gender-neutrality fix.

  • coding/contributing.html:
1:29 AM Changeset in webkit [17839] by sfalken
  • 2 edits in trunk/WebCore

2006-11-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Properly adjust CFAbsoluteTime to time_t to fix date calculations.


Compare lastModified w/ MAX_TIME_T when setting last modified date
instead of comparing expiration against MAX_TIME_T.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment

Nov 17, 2006:

9:57 PM Changeset in webkit [17838] by andersca
  • 10 edits in trunk/WebCore

Reviewed by Geoff.

More conversions from DeprecatedValueList to Vector and HashSet.


  • css/CSSValueList.cpp: (WebCore::CSSValueList::~CSSValueList): (WebCore::CSSValueList::append): (WebCore::CSSValueList::cssText):
  • css/CSSValueList.h: (WebCore::CSSValueList::length): (WebCore::CSSValueList::item):
  • dom/Document.cpp: (WebCore::Document::attachNodeIterator): (WebCore::Document::notifyBeforeNodeRemoval):
  • dom/Document.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::notifyAttributeChange):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::notifyClientsToRepaint):
  • platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient):
  • platform/graphics/svg/SVGResource.h:
  • rendering/RenderBlock.h:
7:29 PM Changeset in webkit [22561] by andersca
  • 19 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Add #defines in config.h to prevent the min and max macros from being used.

  • bridge/win/FrameWin.cpp:
  • config.h:
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/win/PopupMenuWin.cpp:
  • plugins/win/PluginStreamWin.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Reviewed by Adam.

Make sure that all .cpp files and none of the headers include config.h.


  • MemoryStream.cpp:
  • WebBackForwardList.cpp:
  • WebBackForwardList.h:
  • WebElementPropertyBag.cpp:
  • WebHTMLRepresentation.cpp:
  • WebKitClassFactory.cpp:
  • WebKitDLL.cpp:
  • WebMutableURLRequest.cpp:
  • WebMutableURLRequest.h:
  • WebURLResponse.cpp:
  • WebURLResponse.h:
7:15 PM Changeset in webkit [17837] by andersca
  • 4 edits in trunk/JavaScriptCore

2006-11-17 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Make sure that we always use std::min and std::max instead of macros.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/config.h:
  • wtf/Vector.h:
7:09 PM Changeset in webkit [22560] by kmccullo
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • Fixes Targetted Form Submission to now work. Radar: 4762693
  • ChangeLog:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
6:24 PM Changeset in webkit [17836] by thatcher
  • 1 edit in trunk/WebCore/editing/EditCommand.cpp

Fixing the assertion failure, forgot to remove an enable() call.

5:24 PM Changeset in webkit [17835] by thatcher
  • 1 edit
    8 copies in tags/Safari-521.31

New tag.

5:21 PM Changeset in webkit [17834] by thatcher
  • 6 edits in /

Versioning

5:06 PM Changeset in webkit [17833] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made

Disable the delete button controller when cloning nodes, Mail does this before saving a draft.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
  • editing/markup.cpp: (WebCore::createFragmentFromNodes):
5:04 PM Changeset in webkit [17832] by justing
  • 9 edits
    12 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation

Fixed:

  • editing/pasteboard/merge-end-blockquote-expected.checksum:
  • editing/pasteboard/merge-end-blockquote-expected.png:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-blockquote.html:


Added:

  • editing/pasteboard/paste-blockquote-1-expected.checksum: Added.
  • editing/pasteboard/paste-blockquote-1-expected.png: Added.
  • editing/pasteboard/paste-blockquote-1-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-1.html: Added.
  • editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
  • editing/pasteboard/paste-blockquote-2-expected.png: Added.
  • editing/pasteboard/paste-blockquote-2-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-2.html: Added.
  • editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
  • editing/pasteboard/paste-blockquote-3-expected.png: Added.
  • editing/pasteboard/paste-blockquote-3-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-3.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation

  • editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Added. Checks for the node that Mail wraps around an incoming fragment when it wants it to be pasted with quoting (no merging should be done). (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added this virtual method in order to adjust the nodes that ReplaceSelectionCommand tracks. (WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content inside a Mail Paste as Quotation node. Allow merging from Mail blockquotes. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into a Mail blockquote, we ignore the parts of the source document's default style that are overriden by styles from the Mail blockquote. This is necessary in order for text that's black (because black is the source document's default font color) to appear blue/green/whatever when it's pasted into a Mail blockquote. (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted Mail Paste as Quotation node into a normal Mail blockquote. This will prevent a copied blockquote that was inserted into the document using Paste as Quotation from triggering Paste as Quotation behavior when it's pasted. (WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
  • editing/ReplaceSelectionCommand.h:
  • editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine. (WebCore::removeEnclosingMailBlockquoteStyle): Added. (WebCore::startMarkup): When wrapping text nodes in style spans, leave out styles that Mail blockquotes contribute, so that Mail blockquote styles can be differentiated from styles that the user has applied. When creating markup for elements, do the same thing. (WebCore::createMarkup): Call the new subroutine.
4:22 PM Changeset in webkit [17831] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Forgoet the project change.

4:21 PM Changeset in webkit [17830] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.mm: (+[WebView initialize]): (-[WebView setPreferences:]):
4:04 PM Changeset in webkit [22559] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adele.

  • fix leak of Document ref count seen in updateCounterpartURLForRSS
  • WebScriptObject.h: Changed destructor to be virtual. Without this, when the COM object was released we wouldn't release the underlying WebCore::Node.
12:14 PM Changeset in webkit [17829] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11635
Bug 11635: Fix potential issue with non-xslt build

Fix the issue and do style guideline corrections.

11:47 AM Changeset in webkit [17828] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Harrison.

<rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it

Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside

  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply): (WebCore::applyCommand):
  • editing/EditCommand.h:
11:42 AM Changeset in webkit [22558] by darin
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adele.

  • fix leak of WebView when you close a tab or window
  • Interfaces/IWebView.idl: Added a close function, like the close method we added to WebView on the Macintosh side.
  • WebView.h: Added close function.
  • WebView.cpp: (WebView::close): First cut at implementation of close.
11:23 AM Changeset in webkit [17827] by zimmermann
  • 13 edits
    5 adds in trunk

Reviewed by Mitz. Landed by Niko.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11617
Adapt to latest API changes, fixing Qt/Linux build.

11:21 AM Changeset in webkit [17826] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer

Replace an assert with a fixme that refers to this bug.


  • page/Frame.cpp: (WebCore::Frame::revealSelection):
Note: See TracTimeline for information about the timeline view.