⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 19, 2006:

10:51 PM TitleIndex edited by pewtermoose@gmail.com
removing spam (diff)
10:51 PM Writing Layout Tests for DumpRenderTree edited by pewtermoose@gmail.com
removing spam (diff)
10:48 PM TracInstall edited by pewtermoose@gmail.com
removing spam (diff)
10:48 PM TracGuide edited by pewtermoose@gmail.com
removing spam (diff)
5:27 PM Changeset in webkit [22564] by bdakin
  • 9 edits in branches/WindowsMerge

WebCore:

Reviewed by Adam.

Boomer part of context menu actions.

  • bridge/win/FrameWin.h: New spelling functions on Frame.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenu::hide):
  • platform/win/TemporaryLinkStubs.cpp: New stubs. (FrameWin::ignoreSpelling): (FrameWin::learnSpelling): (FrameLoader::reload):

WebKit:

Reviewed by Adam.

  • WebContextMenuClient.cpp: Stubs for the currently client- dependent menu actions. (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::lookUpInDictionary):
  • WebContextMenuClient.h:
  • WebEditorClient.cpp: (WebEditorClient::shouldInsertText): Remove comment markers since this is implemented now on the Mac.
  • WebEditorClient.h:
5:21 PM Changeset in webkit [17855] by bdakin
  • 24 edits
    1 add in trunk

WebCore:

Reviewed by Adam.

Implementation of actions for the new context menus.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h: Declaration of shouldInsertText.
  • bridge/mac/FrameMac.h: Two new spelling functions.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::ignoreSpelling): (WebCore::FrameMac::learnSpelling):
  • editing/Editor.cpp: (WebCore::Editor::shouldInsertText): Call into the client.
  • editing/Editor.h:
  • editing/EditorInsertAction.h: Added. (WebCore::): The WebCore equivalent of WebViewInsertAction. This is defined in its own header so that we can use it from Editor.h and EditorClient.h without having one of the above include the other.
  • page/ContextMenuClient.h: A few currently WebKit-implemented function needed for menu actions.
  • page/ContextMenuController.cpp: (WebCore::makeGoogleSearchURL): (WebCore::ContextMenuController::contextMenuActionSelected): The actions!
  • page/ContextMenuController.h:
  • page/Frame.h: New pure-virtual spelling functions.
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::controller): Get the controller from the menu.
  • platform/ContextMenu.h:
  • platform/mac/ContextMenuMac.mm: (-[MenuTarget forwardContextMenuAction:initWithContextMenuController:WebCore::]): Use the controller instead of the menu (-[MenuTarget WebCore::]): (-[MenuTarget setMenuController:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::show): (ContextMenu::hide):

WebKit:

Reviewed by Adam.

WebKit side of new context menu actions.

  • WebCoreSupport/WebContextMenuClient.h: These are for the currently-WebKit-dependent menu actions.
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::searchWithSpotlight): (WebContextMenuClient::lookUpInDictionary):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (core): These are to convert between WebViewInsertAction and EditorInsertAction. (kit): (WebEditorClient::shouldInsertText): Added implementation for shouldInsertText.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved _lookUpInDictionary to be within the implementation of WebHTMLView internal.
  • WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
  • WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu
2:22 PM Changeset in webkit [17854] by ap
  • 1 edit
    3 deletes in trunk/LayoutTests

Removed parts of an incorrectly committed test, to be re-added later.

  • dom/xhtml/level3/core/documentgetxmlencoding03-expected.png: Removed.
  • dom/xhtml/level3/core/documentgetxmlencoding03-expected.checksum: Removed.
  • dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Removed.
1:25 PM TracGuide edited by asas@asas.com
(diff)
1:25 PM TracInstall edited by asas@asas.com
(diff)
1:24 PM Writing Layout Tests for DumpRenderTree edited by asas@asas.com
(diff)
1:23 PM TitleIndex edited by asas@asas.com
(diff)
12:13 PM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Added GCController (diff)
10:39 AM Changeset in webkit [17853] by staikos
  • 13 edits in trunk

top level:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649

  • CMakeLists.txt: Fix Qt-only build without KDE cmake files

JavaScriptCore:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake Qt-only build without KDE CMake files

  • CMakeLists.txt:
  • pcre/CMakeLists.txt:

WebCore:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake files for Qt-only build without KDE cmake files.
Fix Qt/KDE build for the SVG support.
Fix Qt-only build in the resource handler.

  • CMakeLists.txt:
  • platform/graphics/svg/qt/SVGResourceFilterQt.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::deliverJobData):
  • platform/network/qt/ResourceHandleManager.h:
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/qt/CursorQt.cpp: (WebCore::noDropCursor): (WebCore::progressCursor): (WebCore::aliasCursor):

WebKitQt:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix Qt-only build

  • QtLauncher/CMakeLists.txt:
1:12 AM Changeset in webkit [17852] by ap
  • 2 edits
    4 adds
    1 delete in trunk

2006-11-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

WebCore:

  • manual-tests/delete-into-nested-block.html: Removed.

LayoutTests:

  • fast/repaint/delete-into-nested-block-expected.checksum: Added.
  • fast/repaint/delete-into-nested-block-expected.png: Added.
  • fast/repaint/delete-into-nested-block-expected.txt: Added.
  • fast/repaint/delete-into-nested-block.html: Added.

Nov 18, 2006:

11:20 PM Changeset in webkit [22563] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:18 PM Changeset in webkit [17851] by sfalken
  • 1 copy in tags/Safari-521.31b

New tag.

6:44 PM Changeset in webkit [17850] by zimmermann
  • 59 edits
    41 copies
    61 adds
    6 deletes in trunk/WebCore

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11596

Split up KCanvasFilters & KCanvasFilterQuartz into several
new classes (SVGFEBlend, SVGFEComposite...) and move them
into platform/graphics/svg. This is still a temporary location,
as discussed with Darin; the whole platform/graphics/svg directory
will probably be moved into ksvg2/ in near future.

This commit removes the duplicated enumerations in the svg filter
classes and within kcanvas. ksvg2/ and platform/graphics/svg share
their enums now.

4:47 PM Changeset in webkit [17849] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.

Add tests for crash when garbage collecting node iterators and tree walkers
without a node filter.


  • fast/dom/node-filter-gc-expected.txt: Added.
  • fast/dom/node-filter-gc.html: Added.
3:45 PM Changeset in webkit [22562] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix from OpenSource r17841.

  • platform/win/CursorWin.cpp: New method stubs. (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
2:59 PM Changeset in webkit [17848] by rwlbuis
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

  • fast/css/target-fragment-match-expected.checksum: Added.
  • fast/css/target-fragment-match-expected.png: Added.
  • fast/css/target-fragment-match-expected.txt: Added.
  • fast/css/target-fragment-match.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change

Make sure the page does a style recalculation and possible rendering
when navigating back from a page with an anchor to a page without
an anchor.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
12:58 PM Changeset in webkit [17847] by ap
  • 10 edits
    2 adds in trunk

2006-11-18 Don Gibson <​dgibson77@gmail.com>

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=11634:
Fix segfault on startup for Windows build. Also fix segfault when
typing in a URL.
Clean up some of the style of the patch that landed in r17816.

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::~ChromeClientWin): (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
  • bridge/win/ContextMenuClientWin.h: (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
  • bridge/win/EditorClientWin.h: (WebCore::EditorClientWin::~EditorClientWin): (WebCore::EditorClientWin::ref): (WebCore::EditorClientWin::deref):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • bridge/win/FrameWin.h: (WebCore::Win):
  • loader/win/FrameLoaderClientWin.h: Added. (WebCore::FrameLoaderClientWin::~FrameLoaderClientWin): (WebCore::FrameLoaderClientWin::ref): (WebCore::FrameLoaderClientWin::deref):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::EditorClientWin::selectWordBeforeMenuEvent): (WebCore::EditorClientWin::isEditable): (WebCore::EditorClientWin::shouldBeginEditing): (WebCore::EditorClientWin::shouldEndEditing): (WebCore::EditorClientWin::shouldApplyStyle): (WebCore::EditorClientWin::didBeginEditing): (WebCore::EditorClientWin::respondToChangedContents): (WebCore::EditorClientWin::didEndEditing): (WebCore::EditorClientWin::registerCommandForUndo): (WebCore::EditorClientWin::registerCommandForRedo): (WebCore::EditorClientWin::clearUndoRedoOperations): (WebCore::EditorClientWin::canUndo): (WebCore::EditorClientWin::canRedo): (WebCore::EditorClientWin::undo): (WebCore::EditorClientWin::redo): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoaderClientWin::hasWebView): (WebCore::FrameLoaderClientWin::hasFrameView): (WebCore::FrameLoaderClientWin::hasBackForwardList): (WebCore::FrameLoaderClientWin::resetBackForwardList): (WebCore::FrameLoaderClientWin::provisionalItemIsTarget): (WebCore::FrameLoaderClientWin::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientWin::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientWin::privateBrowsingEnabled): (WebCore::FrameLoaderClientWin::makeDocumentView): (WebCore::FrameLoaderClientWin::makeRepresentation): (WebCore::FrameLoaderClientWin::forceLayout): (WebCore::FrameLoaderClientWin::forceLayoutForNonHTML): (WebCore::FrameLoaderClientWin::updateHistoryForCommit): (WebCore::FrameLoaderClientWin::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientWin::updateHistoryForReload): (WebCore::FrameLoaderClientWin::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientWin::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientWin::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientWin::setCopiesOnScroll): (WebCore::FrameLoaderClientWin::tokenForLoadErrorReset): (WebCore::FrameLoaderClientWin::resetAfterLoadError): (WebCore::FrameLoaderClientWin::doNotResetAfterLoadError): (WebCore::FrameLoaderClientWin::willCloseDocument): (WebCore::FrameLoaderClientWin::detachedFromParent1): (WebCore::FrameLoaderClientWin::detachedFromParent2): (WebCore::FrameLoaderClientWin::detachedFromParent3): (WebCore::FrameLoaderClientWin::detachedFromParent4): (WebCore::FrameLoaderClientWin::loadedFromPageCache): (WebCore::FrameLoaderClientWin::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientWin::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientWin::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientWin::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientWin::dispatchWillClose): (WebCore::FrameLoaderClientWin::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientWin::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientWin::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWin::dispatchDidFinishLoad): (WebCore::FrameLoaderClientWin::dispatchDidFirstLayout): (WebCore::FrameLoaderClientWin::dispatchShow): (WebCore::FrameLoaderClientWin::cancelPolicyCheck): (WebCore::FrameLoaderClientWin::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWin::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientWin::clearLoadingFromPageCache): (WebCore::FrameLoaderClientWin::isLoadingFromPageCache): (WebCore::FrameLoaderClientWin::revertToProvisionalState): (WebCore::FrameLoaderClientWin::clearUnarchivingState): (WebCore::FrameLoaderClientWin::progressStarted): (WebCore::FrameLoaderClientWin::progressCompleted): (WebCore::FrameLoaderClientWin::setMainFrameDocumentReady): (WebCore::FrameLoaderClientWin::willChangeTitle): (WebCore::FrameLoaderClientWin::didChangeTitle): (WebCore::FrameLoaderClientWin::finishedLoading): (WebCore::FrameLoaderClientWin::finalSetupForReplace): (WebCore::FrameLoaderClientWin::setDefersLoading): (WebCore::FrameLoaderClientWin::isArchiveLoadPending): (WebCore::FrameLoaderClientWin::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientWin::clearArchivedResources): (WebCore::FrameLoaderClientWin::canShowMIMEType): (WebCore::FrameLoaderClientWin::representationExistsForURLScheme): (WebCore::FrameLoaderClientWin::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientWin::frameLoadCompleted): (WebCore::FrameLoaderClientWin::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientWin::provisionalLoadStarted): (WebCore::FrameLoaderClientWin::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientWin::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientWin::didFinishLoad): (WebCore::FrameLoaderClientWin::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientWin::setTitle): (WebCore::FrameLoaderClientWin::userAgent):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::initWithName):
12:19 PM Changeset in webkit [17846] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2006-11-16 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas <​zbujtas@gmail.com>.
Merged from 3.2 r17845
DESC: Image map using ID attribute cannot be activated
​http://bugs.webkit.org/show_bug.cgi?id=11618

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):
12:17 PM Changeset in webkit [17845] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-16 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas <​zbujtas@gmail.com>.
DESC: Image map using ID attribute cannot be activated
​http://bugs.webkit.org/show_bug.cgi?id=11618

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):
11:29 AM Changeset in webkit [17844] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-16 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix for tabbed navigation
​http://bugs.webkit.org/show_bug.cgi?id=11619

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):
11:25 AM Changeset in webkit [17843] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-16 shkeller <​shaun.keller@nokia.com>

Reviewed by zalan.
DESC: render object of image type was wrongly typecast and move brace so changelog script works
​http://bugs.webkit.org/show_bug.cgi?id=11608

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::getObjectInstance): (HTMLObjectElementImpl::isFocusable):
5:52 AM Changeset in webkit [17842] by ap
  • 5 edits in trunk

Reviewed by Rob (yay!).

​http://bugs.webkit.org/show_bug.cgi?id=11640
XMLHttpRequest produces undefined:undefined HTTP authentication

WebCore:

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Treat undefined credentials as missing ones.

LayoutTests:

  • http/tests/xmlhttprequest/basic-auth-expected.txt:
  • http/tests/xmlhttprequest/basic-auth.html: Added tests for undefined.
3:24 AM Nightly Builds edited by mitz@webkit.org
Changed to talk about Safari extensions in general rather than about a … (diff)
3:01 AM Known incompatibilities between open-source WebKit and Safari edited by mitz@webkit.org
Deleted obsolete information. The context menu items are present and … (diff)
2:00 AM Changeset in webkit [17841] by ap
  • 9 edits
    3 adds in trunk/WebCore

2006-11-17 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=11638
[CSS 2.1+3] add support for alias, progress, no-drop and not-allowed cursor styles

  • Resources/aliasCursor.png: Added.
  • Resources/noDropCursor.png: Added.
  • Resources/progressCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • manual-tests/cursor.html:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::handCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
  • rendering/RenderStyle.h: (WebCore::):
1:30 AM Changeset in webkit [17840] by ap
  • 2 edits in trunk/WebKitSite

2006-11-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Gender-neutrality fix.

  • coding/contributing.html:
1:29 AM Changeset in webkit [17839] by sfalken
  • 2 edits in trunk/WebCore

2006-11-18 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Properly adjust CFAbsoluteTime to time_t to fix date calculations.


Compare lastModified w/ MAX_TIME_T when setting last modified date
instead of comparing expiration against MAX_TIME_T.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment
Note: See TracTimeline for information about the timeline view.