⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 20, 2006:

11:23 PM Changeset in webkit [17866] by bdash
  • 1 edit in trunk/WebCore/loader/TextResourceDecoder.cpp

Build fix: silence warning about use before initialization.

3:27 PM Changeset in webkit [17865] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

  • loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding): Use CString instead of DeprecatedCString.


  • platform/CString.cpp: (WebCore::CString::find):
  • platform/CString.h: (WebCore::CString::data): Add find method, make data method inline.


  • platform/TextStream.cpp:
  • platform/TextStream.h: Remove DeprecatedCString functions.
2:35 PM Changeset in webkit [17864] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Use CString instead of DeprecatedCString.


  • html/FormDataList.cpp: (WebCore::FormDataList::appendString): (WebCore::fixLineBreaks): (WebCore::FormDataList::appendFile):
2:35 PM Changeset in webkit [17863] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-20 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Dependencies to SystemSW Internal headers; Browser HttpCacheStreamHandler.cpp
​http://bugs.webkit.org/show_bug.cgi?id=11657

  • ResourceLoader/CacheSrc/HttpCacheStreamHandler.cpp:
12:24 PM Changeset in webkit [17862] by ap
  • 10 edits in trunk

2006-11-20 W. Andy Carrel <​wac@google.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11501
REGRESSION: \u no longer escapes metacharacters in RegExps
​http://bugs.webkit.org/show_bug.cgi?id=11502
Serializing RegExps doesn't preserve Unicode escapes

JavaScriptCore:

  • kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): (Lexer::scanRegExp): Push \u parsing back down into the RegExp object rather than in the parser. This backs out r17354 in favor of a new fix that better matches the behavior of other browsers.
  • kjs/lexer.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::sanitizePattern): (KJS::isHexDigit): (KJS::convertHex): (KJS::convertUnicode):
  • kjs/regexp.h: Translate \u escaped unicode characters for the benefit of pcre.
  • kjs/ustring.cpp: (KJS::UString::append): Fix failure to increment length on the first UChar appended to a UString that was copy-on-write.
  • tests/mozilla/ecma_2/RegExp/properties-001.js: Adjust tests back to the uniform standards.

LayoutTests:

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/regexp-unicode-handling-expected.txt: Adjust these test results to passing as a result of other included changes in this revision.
11:58 AM Changeset in webkit [17861] by bdash
  • 8 edits in trunk

2006-11-20 Samuel Weinig <​sam@webkit.org>

Reviewed by Alexey.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ContextMenuClientWin.h:
  • bridge/win/EditorClientWin.h:
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::ContextMenuClientWin::lookUpInDictionary): (WebCore::EditorClientWin::shouldInsertText): (WebCore::FrameLoader::reload): (WebCore::FrameWin::ignoreSpelling): (WebCore::FrameWin::learnSpelling):

2006-11-20 Samuel Weinig <​sam@webkit.org>

Reviewed by Alexey.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build

  • WebKit.vcproj/WebKit.vcproj: don't include directories that no longer exist.
11:56 AM Changeset in webkit [17860] by ap
  • 9 edits in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=10736
XMLHttpRequest.responseXML should be null on error

WebCore:

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::wellFormed):
  • dom/XMLTokenizer.h: (WebCore::Tokenizer::wellFormed):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::implicitClose):
  • dom/Document.h: (WebCore::Document::wellFormed): Tell whether XMLTokenizer saw an error. Always true (success) for HTML.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Set the document to null if it's not well-formed.

LayoutTests:

  • http/tests/xmlhttprequest/zero-length-response-expected.txt:
  • http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated the results for the new behavior.
10:59 AM Changeset in webkit [17859] by ap
  • 16 edits
    5 adds in trunk

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=11633
Implement XMLDocument properties xmlEncoding, xmlVersion, xmlStandalone

WebCore:

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setXMLVersion): (WebCore::Document::setXMLStandalone):
  • dom/Document.h: (WebCore::Document::xmlEncoding): (WebCore::Document::xmlVersion): (WebCore::Document::xmlStandalone): (WebCore::Document::setXMLEncoding):
  • dom/Document.idl:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startDocument): (WebCore::startDocumentHandler): (WebCore::XMLTokenizer::initializeParserContext): Added support for these properties, getting them from an libxml2 context.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): HTMLDocument is the only kind of document that doesn't have xmlVersion default to "1.0".
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm: Added WK_ucfirst to properly uppercase xmlVersion and xmlStandalone.

LayoutTests:

  • dom/xhtml/level3/core/documentgetxmlencoding01-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlencoding03-expected.txt
  • dom/xhtml/level3/core/documentgetxmlstandalone04-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlversion01-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlversion02-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlversion03-expected.txt: These now pass.
  • dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Re-added a correct test.
  • fast/dom/Window/window-properties-expected.txt: Added these new properties.
  • http/tests/xmlhttprequest/xml-encoding-expected.txt: Added.
  • http/tests/xmlhttprequest/xml-encoding.html: Added.
  • http/tests/xmlhttprequest/resources/xml-encoding.xml: Added.
  • http/tests/xmlhttprequest/resources/post-echo-as-utf-8.cgi: Added. Test how xmlEncoding interacts with XMLHttpRequest.
8:12 AM Changeset in webkit [17858] by zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Rob.
Fix Qt/Linux build.

7:42 AM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
(diff)
5:14 AM Changeset in webkit [17857] by bdash
  • 1 add in trunk/WebCore/platform/graphics/svg/qt/SVGResourceFilterQt.cpp

Qt build fix after r17853: add missing SVGResourceFilterQt.cpp.

4:59 AM Changeset in webkit [17856] by bdash
  • 7 edits in trunk

2006-11-20 Samuel Weinig <​sam@webkit.org>

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build

  • kjs/config.h: define NOMINMAX instead of min/max as themselves.
  • wtf/Vector.h: put back hack to ensure that min/max are not defined as macros.

2006-11-20 Samuel Weinig <​sam@webkit.org>

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build

  • config.h: add #define NOMINMAX for windows build
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/win/TemporaryLinkStubs.cpp: add definitions for new cursors. (WebCore::aliasCursor): (WebCore::noDropCursor): (WebCore::progressCursor):
2:13 AM Changeset in webkit [22567] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Add the same include paths to the debug build.


  • WebCore.vcproj/WebCore.vcproj:
1:42 AM Changeset in webkit [22566] by andersca
  • 2 edits
    1 move in branches/WindowsMerge/WebCore

Fix build.


  • WebCore.vcproj/WebCore.vcproj:
  • kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Removed.
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
1:39 AM Changeset in webkit [22565] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Fix build.


  • WebEditorClient.cpp: (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText):
  • WebEditorClient.h:

Nov 19, 2006:

10:51 PM TitleIndex edited by pewtermoose@gmail.com
removing spam (diff)
10:51 PM Writing Layout Tests for DumpRenderTree edited by pewtermoose@gmail.com
removing spam (diff)
10:48 PM TracInstall edited by pewtermoose@gmail.com
removing spam (diff)
10:48 PM TracGuide edited by pewtermoose@gmail.com
removing spam (diff)
5:27 PM Changeset in webkit [22564] by bdakin
  • 9 edits in branches/WindowsMerge

WebCore:

Reviewed by Adam.

Boomer part of context menu actions.

  • bridge/win/FrameWin.h: New spelling functions on Frame.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenu::hide):
  • platform/win/TemporaryLinkStubs.cpp: New stubs. (FrameWin::ignoreSpelling): (FrameWin::learnSpelling): (FrameLoader::reload):

WebKit:

Reviewed by Adam.

  • WebContextMenuClient.cpp: Stubs for the currently client- dependent menu actions. (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::lookUpInDictionary):
  • WebContextMenuClient.h:
  • WebEditorClient.cpp: (WebEditorClient::shouldInsertText): Remove comment markers since this is implemented now on the Mac.
  • WebEditorClient.h:
5:21 PM Changeset in webkit [17855] by bdakin
  • 24 edits
    1 add in trunk

WebCore:

Reviewed by Adam.

Implementation of actions for the new context menus.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h: Declaration of shouldInsertText.
  • bridge/mac/FrameMac.h: Two new spelling functions.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::ignoreSpelling): (WebCore::FrameMac::learnSpelling):
  • editing/Editor.cpp: (WebCore::Editor::shouldInsertText): Call into the client.
  • editing/Editor.h:
  • editing/EditorInsertAction.h: Added. (WebCore::): The WebCore equivalent of WebViewInsertAction. This is defined in its own header so that we can use it from Editor.h and EditorClient.h without having one of the above include the other.
  • page/ContextMenuClient.h: A few currently WebKit-implemented function needed for menu actions.
  • page/ContextMenuController.cpp: (WebCore::makeGoogleSearchURL): (WebCore::ContextMenuController::contextMenuActionSelected): The actions!
  • page/ContextMenuController.h:
  • page/Frame.h: New pure-virtual spelling functions.
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::controller): Get the controller from the menu.
  • platform/ContextMenu.h:
  • platform/mac/ContextMenuMac.mm: (-[MenuTarget forwardContextMenuAction:initWithContextMenuController:WebCore::]): Use the controller instead of the menu (-[MenuTarget WebCore::]): (-[MenuTarget setMenuController:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::show): (ContextMenu::hide):

WebKit:

Reviewed by Adam.

WebKit side of new context menu actions.

  • WebCoreSupport/WebContextMenuClient.h: These are for the currently-WebKit-dependent menu actions.
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::searchWithSpotlight): (WebContextMenuClient::lookUpInDictionary):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (core): These are to convert between WebViewInsertAction and EditorInsertAction. (kit): (WebEditorClient::shouldInsertText): Added implementation for shouldInsertText.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved _lookUpInDictionary to be within the implementation of WebHTMLView internal.
  • WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
  • WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu
2:22 PM Changeset in webkit [17854] by ap
  • 1 edit
    3 deletes in trunk/LayoutTests

Removed parts of an incorrectly committed test, to be re-added later.

  • dom/xhtml/level3/core/documentgetxmlencoding03-expected.png: Removed.
  • dom/xhtml/level3/core/documentgetxmlencoding03-expected.checksum: Removed.
  • dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Removed.
1:25 PM TracGuide edited by asas@asas.com
(diff)
1:25 PM TracInstall edited by asas@asas.com
(diff)
1:24 PM Writing Layout Tests for DumpRenderTree edited by asas@asas.com
(diff)
1:23 PM TitleIndex edited by asas@asas.com
(diff)
12:13 PM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Added GCController (diff)
10:39 AM Changeset in webkit [17853] by staikos
  • 13 edits in trunk

top level:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649

  • CMakeLists.txt: Fix Qt-only build without KDE cmake files

JavaScriptCore:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake Qt-only build without KDE CMake files

  • CMakeLists.txt:
  • pcre/CMakeLists.txt:

WebCore:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake files for Qt-only build without KDE cmake files.
Fix Qt/KDE build for the SVG support.
Fix Qt-only build in the resource handler.

  • CMakeLists.txt:
  • platform/graphics/svg/qt/SVGResourceFilterQt.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::deliverJobData):
  • platform/network/qt/ResourceHandleManager.h:
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/qt/CursorQt.cpp: (WebCore::noDropCursor): (WebCore::progressCursor): (WebCore::aliasCursor):

WebKitQt:

Reviewed by Zack.

​http://bugs.webkit.org/show_bug.cgi?id=11649
Fix Qt-only build

  • QtLauncher/CMakeLists.txt:
1:12 AM Changeset in webkit [17852] by ap
  • 2 edits
    4 adds
    1 delete in trunk

2006-11-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

WebCore:

  • manual-tests/delete-into-nested-block.html: Removed.

LayoutTests:

  • fast/repaint/delete-into-nested-block-expected.checksum: Added.
  • fast/repaint/delete-into-nested-block-expected.png: Added.
  • fast/repaint/delete-into-nested-block-expected.txt: Added.
  • fast/repaint/delete-into-nested-block.html: Added.
Note: See TracTimeline for information about the timeline view.