⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 30, 2006:

11:28 PM Changeset in webkit [22604] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

11:22 PM Changeset in webkit [17960] by sfalken
  • 1 copy in tags/Safari-521.31.4

New tag.

10:35 PM Changeset in webkit [22603] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <sfalken@apple.com>

Fix build.
Link against new WTF.lib

  • WebKit.vcproj/WebKit.vcproj:
9:42 PM Changeset in webkit [17959] by sfalken
  • 4 edits
    2 adds in trunk/JavaScriptCore

2006-11-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.


Move WTF from JavaScriptCore project into a new WTF project.

8:23 PM Changeset in webkit [22602] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
8:15 PM Changeset in webkit [17958] by ggaren
  • 24 edits in trunk

WebCore:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

WebKit:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

  • WebView/WebHTMLView.m: (-[NSArray clearFocus]):
6:16 PM Changeset in webkit [17957] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-30 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Tabbed navigation fixes
http://bugs.webkit.org/show_bug.cgi?id=11725

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
5:53 PM Changeset in webkit [22601] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:47 PM Changeset in webkit [17956] by sfalken
  • 1 copy in tags/Safari-521.31.3

New tag.

4:57 PM Changeset in webkit [22600] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Lather, rinse, repeat.

  • platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
4:55 PM Changeset in webkit [17955] by sullivan
  • 15 edits in trunk

LayoutTests:

Reviewed by Justin

  • editing/execCommand/create-list-from-range-selection-expected.checksum:
  • editing/execCommand/create-list-from-range-selection-expected.png:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-from-range-selection.html: This test's results were broken by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs(), presumably by revealing a different bug. Justin is going to look into this; for now I've updated the result so that it won't appear to fail for others.


  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/create-list-with-hr.html: This test's results were improved by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs() -- it used to create an extra <div>, and now it does not.

WebCore:

Reviewed by Justin

With Darin, fixed a problem in the Range constructors found while implementing grammar checking.
That revealed another problem in the layout tests involving bad parameters passed to the Range
constructors.


With these fixes in place, one layout test (editing/execCommand/create-list-from-range-selection.html)
no longer works as intended. This is apparently due to yet another bug being flushed out somewhere.
I'm going to update the results for that test and file a separate radar about it, which Justin will
investigate.

  • dom/Position.h: removed equivalentRangeCompliantPosition(), which was declared but not implemented or called.


  • dom/Range.cpp: (WebCore::Range::Range): Call setStart and setEnd in the two Range constructors that take parameters, rather than just directly setting the instance variables. This makes Range perform the boundary checks and compensations that the DOM spec requires.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Use rangeCompliantEquivalent() on "editing-style" Positions before creating Ranges from them.


  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Assert that the boundary points of the range are valid.
4:18 PM Changeset in webkit [22599] by aroben
  • 3 edits
    1 delete in branches/WindowsMerge/WebCore

Build fix.

  • platform/graphics/cg/GraphicsContextCG.cpp: Removed. This file was un-forked a while ago.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::platformDescription):
  • platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
4:14 PM Changeset in webkit [17954] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Mitz.

Bug 10698: Scroll wheel causes inspector to shift up
http://bugs.webkit.org/show_bug.cgi?id=10698

Remove size attribute from the tree popup as a workaround for
http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options

4:11 PM Changeset in webkit [17953] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Tim H.

Move web inspector style markup to javascript to fix http://bugs.webkit.org/show_bug.cgi?id=6724
Bug 6724: Text copied from Web Inspector is different from actual text

4:03 PM Changeset in webkit [17952] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Removing the conflict marker.

3:50 PM Changeset in webkit [17951] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-30 sareen <shyam.sareen@nokia.com>

Reviewed by spadma <Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
http://bugs.webkit.org/show_bug.cgi?id=11728

  • ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):
3:45 PM Changeset in webkit [17950] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 sareen <shyam.sareen@nokia.com>

Reviewed by spadma <Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
http://bugs.webkit.org/show_bug.cgi?id=11728

  • ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):
2:48 PM Changeset in webkit [22598] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::createFilterEffect):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: (WebCore::SVGResourceMasker::applyMask):
2:29 PM Changeset in webkit [17949] by lamadio
  • 3 edits in trunk/WebCore

2006-11-30 Lou Amadio <lamadio@apple.com>

Reviewed by Dave Hyatt
Cleaned up generated files.

2:07 PM Changeset in webkit [17948] by aroben
  • 7 edits in trunk

WebCore:

Reviewed by Beth.

Store ContextMenu's NSMutableArray inside a RetainPtr so that we
will retain/release it correctly.

  • WebCore.exp:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Added a FIXME.
  • platform/ContextMenu.h:
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::getNSMenuItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription):

WebKit:

Reviewed by Beth.

Put code in place to use WebCore context menus when they are turned
on.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):
1:47 PM Changeset in webkit [17947] by zimmermann
  • 81 edits
    4 copies
    1 delete in trunk/WebCore

Reviewed by Eric. Rubber stamped by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=10383

This is the final patch after the long "die kcanvas" journey.

All old kcanvas code is gone now, and properly integrated within
WebCore (stuff like GraphicsContext changes etc.). It shares
the platform/ design concept: no subclassing, but instead
implementing parts of the classes/methods per-platform.

This commit removes the last pieces: KRenderingDevice & KRenderingDeviceContext.
This layer was just obsolete, given the powerful GraphicsContext API we have
since quite a while now. All the ugly pushContext/popContext stuff is gone now.

The naming issues Cg vs. CG will be fixed in one shot, when moving the whole
platform/graphics/svg directory down into ksvg2/graphics - as discussed with Darin.

1:13 PM Changeset in webkit [22597] by ggaren
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.


Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

  • loader/win/FrameLoaderWin.cpp: Removed custom implementation for detachFromParent, since FrameLoader has a cross-platform version now.

WebKitWin:

Reviewed by Beth Dakin.


Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

Copied *very nice* (NOT!) WebKit Mac idiom of calling
FrameLoader::detachFromParent when closing the WebView.
We need to do this so event listeners that retain the document
get destroyed, and so the unload event gets dispatched.

This is pretty silly. Instead, the document/frame/interpreter should
be responsible for cleaning up after itself.


  • WebView.cpp: (WebView::close):
1:10 PM Changeset in webkit [17946] by yongjzha
  • 2 edits in S60/trunk/WebKit
1:06 PM Changeset in webkit [17945] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Beth Dakin.


Fixed up garbage collection at window close time.

  • kjs/interpreter.cpp: (KJS::Interpreter::~Interpreter): Garbage collect here, since destroying the interpreter frees the global object and therefore creates a lot of garbage.

WebCore:

Reviewed by Beth Dakin.


Fixed up garbage collection at window close time.

  • bindings/js/kjs_proxy.cpp: Don't garbage collect in the KJSProxy destructor, since the global object hasn't been freed yet.
  • bindings/js/kjs_proxy.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Made this function cross- platform.
  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::setTitle): Moved this function to FrameLoaderMac, since it's Mac-only. (WebCore::FrameLoader::closeBridge):
  • page/Page.cpp: (WebCore::Page::~Page): Don't garbage collect in the Page destructor, since the Interpreter destructor will do it for us.
12:26 PM Changeset in webkit [17944] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: If values are null in setPreferenceForKey remove them from the map.
http://bugs.webkit.org/show_bug.cgi?id=11438

  • BrowserView/src/WidgetPreferences.cpp: (CWidgetPreferences::SetPreferenceL):
12:23 PM Changeset in webkit [17943] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: 3.1 & 3.2 Memory handling error in CHttpCacheEntry::Internalize(), BrowserCache.dll
http://bugs.webkit.org/show_bug.cgi?id=11724

  • ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::Internalize):
12:16 PM Changeset in webkit [17942] by spadma
  • 8 edits in S60/trunk

2006-11-30 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma.
DESC: Refresh timer in the browser is not cancelled
http://bugs.webkit.org/show_bug.cgi?id=11722

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::Complete):


12:06 PM Changeset in webkit [22596] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <sfalken@apple.com>

build WebKit.lib to proper directory

  • WebKit.vcproj/WebKit.vcproj:
11:24 AM Changeset in webkit [17941] by spadma
  • 5 edits in S60/trunk/WebKit

2006-11-30 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: [s60] Saved Pages: Some Images not saved with the page.
http://bugs.webkit.org/show_bug.cgi?id=11721

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):
11:23 AM Changeset in webkit [17940] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim's rubberstamp

Amazingly, DocumentLoader.h survived all this time without a header guard...

  • loader/DocumentLoader.h: Added header guard
10:48 AM Changeset in webkit [22595] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-30 Steve Falkenburg <sfalken@apple.com>

B&I build fix. Add missing header files to vcproj.

  • WebCore.vcproj/WebCore.vcproj:
9:37 AM Changeset in webkit [17939] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Brady and Eric.

XMLHttpRequest fails in a page loaded with WebFrame's loadHTMLString: or loadData:
http://bugs.webkit.org/show_bug.cgi?id=11723

Allow cross-domain XMLHTTPRequest for applewebdata URLs. No automated way to test,
tested in Safari's debug Snippet Editor.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
7:05 AM Changeset in webkit [17938] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-29 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC:
http://bugs.webkit.org/show_bug.cgi?id=11716
[S60] some Chinese characters displays as mess code on www.163.com

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotData):

Nov 29, 2006:

7:44 PM Changeset in webkit [22594] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: Remove unused function.
7:26 PM Changeset in webkit [17937] by andersca
  • 12 edits in trunk/WebCore

Reviewed by Brady.

Get rid of PlatformResponse, the platform specific response object is stored inside of
the ResourceResponse object now. This also gets rid of receivedResponse in ResourceHandleClient.


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::response):
  • loader/loader.cpp:
  • loader/loader.h:
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveResponse):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::nsURLResponse): (WebCore::ResourceResponse::cfURLResponse):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveResponse):
6:54 PM Changeset in webkit [17936] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by sullivan


<rdar://problem/4845371>
In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message

  • editing/deleting/4845371-expected.checksum: Added.
  • editing/deleting/4845371-expected.png: Added.
  • editing/deleting/4845371-expected.txt: Added.
  • editing/deleting/4845371.html: Added.

WebCore:

Reviewed by sullivan


<rdar://problem/4845371>
In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): The start/end were being inflated even when they were the start/end of a partially selected special element.
6:01 PM Changeset in webkit [17935] by bdash
  • 1 edit in trunk/WebKit/WebCoreSupport/WebChromeClient.mm

Build fix: ResourceRequestMac.h was removed in r17911.

5:55 PM Changeset in webkit [17934] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-29 shkeller <shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: QPen emulation in KWQ did not handle special
case for pen width zero.
http://bugs.webkit.org/show_bug.cgi?id=11714

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQPainter.cpp:
4:59 PM Changeset in webkit [17933] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Oliver.

Keep preferences separate from the rest of the client, making sure we are using expected preference values.
This lets the inspector work when plugins are disabled for the WebView.

  • WebInspector/WebInspector.m: (-[NSWindow window]):
4:10 PM Changeset in webkit [22593] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix fast/dom/xmlhttprequest-get layout test failure.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Initialize the status code to 0 for non-http responses.
3:01 PM Changeset in webkit [22592] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Anders.


Minor fix to my recent COM registration/Vista fix.
Ignore errors during registration. Vista locks off more of
HKCU\Software\Classes than I thought.

  • WebKitDLL.cpp:
2:42 PM Changeset in webkit [17932] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix fast/dom/xmlhttprequest-get layout test failure.


  • platform/network/mac/ResourceResponseMac.mm: Initialize the status code to 0 for non-http responses.
2:14 PM Changeset in webkit [17931] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.


Fixed http://bugs.webkit.org/show_bug.cgi?id=11712
REGRESSION: Crash when clicking JS link on crateandbarrel.com (window.open("http[...]"))


This was an accidental commit by Anders.

Chrome can't use the FrameView at window.open time, because it doesn't
exist yet.


  • page/Chrome.cpp: (WebCore::Chrome::pageRect):
1:58 PM Changeset in webkit [17930] by ggaren
  • 10 edits in trunk/WebCore

Reviewed by Mitz Pettel.


Fixed http://bugs.webkit.org/show_bug.cgi?id=11710
REGRESSION (r17906): Crash in WebCore::FrameMac

Added null checks for EditorClient, since it can be NULL when the page
has been destroyed. Removed external access to EditorClient, since it's
an implementation detail of the Editor.

No test case because this crash depends on window tear-down. Layout tests
pass.

11:31 AM Changeset in webkit [17929] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-28 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Zooming not working for auto-complete
http://bugs.webkit.org/show_bug.cgi?id=11702

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):


11:30 AM Changeset in webkit [17928] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-28 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Zooming not working for auto-complete
http://bugs.webkit.org/show_bug.cgi?id=11702

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):


11:26 AM Changeset in webkit [17927] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Can't upload an image to Blogger.com
http://bugs.webkit.org/show_bug.cgi?id=11715

  • BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::AddCookieL):
11:24 AM Changeset in webkit [17926] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Can't upload an image to Blogger.com
http://bugs.webkit.org/show_bug.cgi?id=11715

  • BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::AddCookieL):
10:47 AM Changeset in webkit [17925] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Tim.

Add back methods in WebCoreStatistics that are still used by Tiger Safari.


  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.m: (+[WebCoreStatistics emptyCache]): (+[WebCoreStatistics setCacheDisabled:]):
10:38 AM Changeset in webkit [17924] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: WEB browser crashes when attempting to view a local file
http://bugs.webkit.org/show_bug.cgi?id=11711

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::DownloadManagerContentL):
10:38 AM Changeset in webkit [17923] by andersca
  • 2 edits in trunk/WebCore

Fix build.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedResponse): Fix tyop.
10:37 AM Changeset in webkit [17922] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: WEB browser crashes when attempting to view a local file
http://bugs.webkit.org/show_bug.cgi?id=11711

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::DownloadManagerContentL):
10:35 AM Changeset in webkit [22591] by andersca
  • 5 edits
    2 deletes in branches/WindowsMerge/WebCore

Reviewed by Darin.

Have ResourceResponse hold on to the platform object and do lazy
initialization of the data members.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse):
  • platform/network/cf/ResourceRequestCFNet.h: Removed.
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
  • platform/network/cf/ResourceResponseCFNet.h: Removed.
  • platform/win/MimeTypeRegistryWin.cpp:
10:29 AM Changeset in webkit [17921] by andersca
  • 8 edits
    1 add
    1 delete in trunk/WebCore

Reviewed by Darin.

Have ResourceResponse hold on to the platform object and do lazy
initialization of the data members.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously):
  • platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::updatePlatformRequest): (WebCore::ResourceRequest::updateResourceRequest):
  • platform/network/ResourceResponse.cpp: Added. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpStatusText): (WebCore::ResourceResponse::setHTTPStatusText): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate): (WebCore::ResourceResponse::setLastModifiedDate): (WebCore::ResourceResponse::lastModifiedDate): (WebCore::ResourceResponse::updateResourceResponse):
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isMultipart):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/mac/ResourceResponseMac.h: Removed.
  • platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]):
9:57 AM Changeset in webkit [22590] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adele.

Give archive builds a separate set of CLSIDs so that they may be
installed/run alongside B&I builds and development builds.

  • Interfaces/WebKit.idl:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj: Don't register WebKit.dll if ARCHIVE_BUILD or BuildBot is defined.
Note: See TracTimeline for information about the timeline view.