Context Navigation

← Previous Period
Next Period →

Timeline

Dec 2, 2006:

6:48 AM Changeset in webkit [17987] by sullivan

2 edits in trunk/WebCore

Reviewed by Tim Omernick

Removed a couple of big chunks of duplicated code from the spelling and grammar stuff by merging
the find-next-instance functions with the mark-all-instances functions.

bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): added markAll parameter, and reworked loop so that if markAll parameter is true, this function loops through the entire range and marks each misspelling (WebCore::findFirstGrammarDetailInRange): extracted from findFirstBadGrammarInRange; loops through the potentially-multiple details in a given ungrammatical phrase (e.g., multiple grammar errors in one sentence). Has a markAll parameter akin to the one in findFirstMisspellingInRange. (WebCore::findFirstBadGrammarInRange): added markAll parameter like the one in findFirstMisspellingInRange, and extracted findFirstGrammarDetailInRange (WebCore::FrameMac::advanceToNextMisspelling): pass "false" for new markAll parameters (WebCore::markAllMisspellingsInRange): now just calls findFirstMisspellingInRange with markAll = true, thus removing a big hunk of duplicated code (WebCore::markAllBadGrammarInRange): now just calls findFirstBadGrammarInRange with markAll = true, thus removing a big hunk of duplicated code

6:02 AM Changeset in webkit [17986] by ap

3 edits
4 adds in trunk

2006-12-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=11672 REGRESSION (r17068): Repro crash due to painting without layout

Test: fast/dynamic/containing-block-change.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Changed the logic used to find absolutely positioned descendant's current containing block to match the changes made to containingBlock() in the fix for bug 9347.

5:41 AM Changeset in webkit [17985] by ap

3 edits in trunk/WebCore

2006-12-02 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11709
DeprecatedString::format is broken on Windows

Use _vscprintf on Windows to compute the length of the buffer that
vsnprintf would need.

platform/DeprecatedString.cpp: (WebCore::DeprecatedString::format):
platform/String.cpp: (WebCore::String::format):

Dec 1, 2006:

6:52 PM Changeset in webkit [22606] by bdakin

7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. Also some
adjustments to make ContextMenuItem class a wrapper for the
platformDescription. (In this case, a wrapper for LPMENUITEMINFO.)

WebCore.vcproj/WebCore.vcproj:
platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::insertItem):

WebKitWin:

Reviewed by Adam.

Changes to support sub-menus for WebCore ContextMenus.

Interfaces/IWebUIDelegate.idl: New tags.
WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): ContextMenu::menu () is now called parentMenu()

6:35 PM Changeset in webkit [17984] by bdakin

12 edits
1 add in trunk

WebCore:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. This also re-
architects the ContextMenuItem class so that it is more like
ContextMenu in that the class is now really just a wrapper for the
platformDescription

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Add place-holders for new tags for the sub-menu items. I will flesh these out in a separate check-in.
platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate): Call the above functions to add the appropriate sub-menus to editing context menus.
platform/ContextMenu.h:
platform/ContextMenuItem.h: (WebCore::): New tags in the ContextMenuAction enumeration. (WebCore::ContextMenuItem::parentMenu): (WebCore::ContextMenuItem::setType):
platform/PlatformMenuDescription.h: Added. This defines PlatformMenuDesciption. It needs to be its own header because we

have to include it from ContextMenu.h and ContextMenuItem.h

platform/mac/ContextMenuItemMac.mm: Lots of adjustments here to make this class basically just be a wrapper for NSMenuItem. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::getNSMenuItem): Now we only have to get the platformDescription of the ContextMenuItem and then set its target and action. (WebCore::ContextMenu::itemCount):

WebKit:

Reviewed by Adam.

Changes to support sub-menus in WebCore ContextMenus.

WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): ContextMenuItem::menu() is now called parentMenu()
WebView/WebUIDelegatePrivate.h: New not-yet-API tags.

4:36 PM Changeset in webkit [17983] by kmccullo

2 edits in trunk/WebCore

Reviewed by .

accidentally checked in with previous checkin

platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):

4:23 PM Changeset in webkit [17982] by kmccullo

5 edits in trunk/WebCore

Reviewed by Adam.

better solution to the ambiguous reference

platform/Widget.h: (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent):
platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
platform/win/PlatformScrollBar.h:
platform/win/TemporaryLinkStubs.cpp: (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):

3:40 PM Changeset in webkit [17981] by justing

58 edits in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

Removed unnecessary shouldChangeSelection calls;

editing/deleting/delete-at-start-or-end-expected.txt:
editing/deleting/delete-br-002-expected.txt:
editing/deleting/delete-br-004-expected.txt:
editing/deleting/delete-br-005-expected.txt:
editing/deleting/delete-br-006-expected.txt:
editing/deleting/delete-br-009-expected.txt:
editing/deleting/delete-br-010-expected.txt:
editing/deleting/delete-br-012-expected.txt:
editing/deleting/delete-hr-expected.txt:
editing/deleting/delete-tab-004-expected.txt:
editing/deleting/forward-delete-expected.txt:
editing/deleting/merge-into-empty-block-1-expected.txt:
editing/deleting/merge-into-empty-block-2-expected.txt:
editing/execCommand/format-block-expected.txt:
editing/execCommand/outdent-selection-expected.txt:
editing/inserting/editing-empty-divs-expected.txt:
editing/inserting/insert-3800346-fix-expected.txt:
editing/inserting/insert-br-004-expected.txt:
editing/inserting/insert-br-005-expected.txt:
editing/inserting/insert-br-006-expected.txt:
editing/inserting/insert-br-008-expected.txt:
editing/inserting/insert-div-006-expected.txt:
editing/inserting/insert-div-008-expected.txt:
editing/inserting/insert-div-010-expected.txt:
editing/inserting/insert-div-011-expected.txt:
editing/inserting/insert-div-013-expected.txt:
editing/inserting/insert-div-015-expected.txt:
editing/inserting/insert-div-019-expected.txt:
editing/inserting/insert-div-021-expected.txt:
editing/inserting/insert-paragraph-01-expected.txt:
editing/inserting/insert-paragraph-03-expected.txt:
editing/inserting/insert-tab-004-expected.txt:
editing/inserting/insert-text-with-newlines-expected.txt:
editing/inserting/line-break-expected.txt:
editing/pasteboard/3976872-expected.txt:
editing/pasteboard/paste-text-005-expected.txt:
editing/pasteboard/paste-text-006-expected.txt:
editing/pasteboard/paste-text-007-expected.txt:
editing/pasteboard/paste-text-010-expected.txt:
editing/pasteboard/paste-text-014-expected.txt:
editing/pasteboard/paste-text-016-expected.txt:
editing/pasteboard/quirks-mode-br-2-expected.txt:
editing/style/apple-style-editable-mix-expected.txt:
editing/style/block-style-001-expected.txt:
editing/style/block-style-002-expected.txt:
editing/style/block-style-003-expected.txt:
editing/style/block-style-006-expected.txt:
editing/style/create-block-for-style-005-expected.txt:
editing/style/create-block-for-style-006-expected.txt:
editing/style/create-block-for-style-008-expected.txt:
editing/style/relative-font-size-change-002-expected.txt:
editing/style/relative-font-size-change-003-expected.txt:
editing/style/relative-font-size-change-004-expected.txt:
editing/style/table-selection-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

No layout test for the bug fix, because there's no way to register a custom
editing delegate from a layout test. Layout tests are effected by the change
to avoid sending unnecessary shouldChangeSelections, however.

editing/Editor.cpp: (WebCore::Editor::appliedEditing): Don't bother sending shouldChangeSelection if the editing operation didn't change the selection. Still call setSelection though, because it does work in this case that's necessary, like clearing the typing style. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto.
editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Don't set the starting selection if the editing delegate returns NO from shouldDeleteRange. Notice we now call setStartingSelection in the case where the current selection was a range selection. This is fine because it's a no-op (the starting selection is already the current selection). (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

3:32 PM Changeset in webkit [17980] by sullivan

4 edits in trunk/WebCore

Reviewed by Darin

Move subrange helper function from spellchecking code to TextIterator

editing/TextIterator.h: added TextIterator::subrange
editing/TextIterator.cpp: (WebCore::CharacterIterator::advance): early return if count is <= 0; assert that it's not < 0 (WebCore::TextIterator::subrange): new function, moved from FrameMac.mmm

bridge/mac/FrameMac.mm: moved subrange() function to TextIterator (WebCore::FrameMac::advanceToNextMisspelling): use TextIterator::subrange (WebCore::markAllMisspellingsInRange): ditto (WebCore::markAllBadGrammarInRange): ditto

2:53 PM Changeset in webkit [17979] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-004 (unchanged from 10.4.7).

2:52 PM Changeset in webkit [17978] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-004 (unchanged from 10.4.7).

2:51 PM Changeset in webkit [17977] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-004/WebKit

Tag for WebKit for Security Update 2006-004 (unchanged from 10.4.7).

2:46 PM Changeset in webkit [17976] by darin

31 edits
1 delete in trunk

WebCore:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window

I couldn't think of an easy way to make a regression test for this, but maybe
I'll get an idea later about how to do it.

The main thing I did was add a concept of a DOM event having an "underlying event".
That allows the DOM activate event to contain inside it the original keyboard event
that triggered the form submission, and thus allows WebKit to see the modifier keys
from that original event. The code that uses the underlying event is in WebKit, but
the code to set it up is here in WebCore.

also do some clean-up to related event handling code

bindings/js/kjs_events.cpp: (KJS::DOMEvent::getValueProperty): Updated for the name change of cancelBubble.

dom/Event.h: Removed a useless comment. Fixed some whitespace and formatting. Renamed getCancelBubble to cancelBubble to match the DOM -- I suspect the old name predated the use of the m_ prefix on data members. Added the underlying event, and a getter and setter.
dom/Event.cpp: (WebCore::Event::setTarget): Updated to take a PassRefPtr. (WebCore::Event::setUnderlyingEvent): Added.

dom/EventTargetNode.h: Added an optional underlyingEvent parameter to dispatchUIEvent, one of the overloads of dispatchMouseEvent, and dispatchSimulatedMouseEvent. Added a new dispatchSimulatedClick function here that mostly replaces the click function in HTMLElement.
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Updated for the name change of cancelBubble. (WebCore::EventTargetNode::dispatchUIEvent): Added an underlying event parameter, which gets attached to the UIEvent object after it's created. (WebCore::EventTargetNode::dispatchMouseEvent): Tweaked formatting and parameter name for the version that creates a mouse event for a real platform mouse event. Added an underlying event parameter to the main version, and attached it to all three of the events that can be dispatched. (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Added an underlying event parameter, passed it along to dispatchMouseEvent. (WebCore::EventTargetNode::dispatchSimulatedClick): Moved this here from HTMLElement and renamed it from click. Added an underlyingEvent parameter, and passed that along in all three of the calls to dispatchSimulatedMouseEvent.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldClose): Updated call to setTarget that no longer needs a get().
ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.

html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLAnchorElement::accessKeyAction): Ditto.
html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): Ditto.
html/HTMLElement.h: Removed the parameters to click and made it non-virtual. We could move it down to the input and button elements, now that it's just a single function call, but it's also OK to just leave it here.
html/HTMLElement.cpp: (WebCore::HTMLElement::click): Removed the parameters and changed this to just call dispatchSimulatedClick. The real work is now in dispatchSimulatedClick. (WebCore::HTMLElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): Ditto. But unlike accessKeyAction callers, pass the event along as the underlying event.
html/HTMLInputElement.h:
html/HTMLInputElement.cpp: Removed override of virtual click function. The special cases for the file control and hidden input elements aren't needed. (WebCore::HTMLInputElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLInputElement::defaultEventHandler): Converted calls to click to calls to dispatchSimulatedClick, passing along the event as the underlying event.
html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick, passing the event along as the underlying event. Also changed the local variable for the element to a RefPtr since the code assumes it's still around after calling arbitrary JavaScript code.
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.

rendering/RenderFileUploadControl.h:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click): Removed unneeded ignored parameter to the click function, and also made it non-virtual.

loader/NavigationAction.h: Removed unneeded includes.
loader/NavigationAction.cpp: Moved all the code here from NavigationActionMac.mm, since none of it is Mac-specific any more.
loader/mac/NavigationActionMac.mm: Removed.
WebCore.xcodeproj/project.pbxproj: Updated for removed file.

ksvg2/svg/SVGAElement.cpp: Removed an unnecessary include.

loader/FrameLoader.cpp: Added a newly-needed incluude.
loader/mac/DocumentLoaderMac.mm: Ditto.
loader/mac/FrameLoaderMac.mm: Ditto.
rendering/RenderWidget.cpp: Ditto.

WebKit:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window

WebCoreSupport/WebFrameLoaderClient.mm: (findKeyStateEvent): Added. Helper that finds the mouse or keyboard event in a chain of events and their underlying events. (findMouseEvent): Added. Same, but specifically for mouse events. (WebFrameLoaderClient::actionDictionary): Rewrote to use the above functions. This means we use the modifiers from the underlying events rather than just the one from the event itself. So if the event is a DOM activate event, we can still see the modifiers from the original keyboard event that triggered it. Has no effect if the event is already the right type or if there is no underlying event.

WebView/WebFrame.mm: Added a newly-needed include.

WebKit.xcodeproj/project.pbxproj: Xcode wants what it wants.

2:44 PM Changeset in webkit [17975] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-004/WebCore

Tag for WebCore for Security Update 2006-004.

2:43 PM Changeset in webkit [17974] by thatcher

1 add in releases/Apple/Tiger/Security Update 2006-004

New tag for Security Update 2006-004

2:33 PM Changeset in webkit [17973] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-007/WebKit

Tag for WebKit for Security Update 2006-007.

2:31 PM Changeset in webkit [17972] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-007/WebCore

Tag for WebCore for Security Update 2006-007 (unchanged from 10.4.8).

2:30 PM Changeset in webkit [17971] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-007 (unchanged from 10.4.8).

2:29 PM Changeset in webkit [17970] by thatcher

1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-007 (unchanged from 10.4.8).

2:28 PM Changeset in webkit [17969] by thatcher

1 add in releases/Apple/Tiger/Security Update 2006-007

New tag for Security Update 2006-007

2:12 PM Changeset in webkit [17968] by sullivan

3 edits in trunk/WebCore

Reviewed by Darin

fixed <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient context passed to grammar checker

bridge/mac/FrameMac.mm: (WebCore::markAllMisspellingsInRange): new function, extracted from markMisspellings -- ignores grammar (WebCore::markAllBadGrammarInRange): new function, extracted from markMisspellings -- ignores spelling, and operates on appropriately-sized chunks of text (WebCore::FrameMac::markMisspellings): now calls markAllMisspellingsInRange and (optionally) markAllBadGrammarInRange rather than trying to interweave the spelling and grammar logic

1:31 PM Changeset in webkit [17967] by sullivan

1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

1:25 PM Changeset in webkit [17966] by sullivan

2 edits in trunk/WebCore

Reviewed by Darin

With these changes, grammar checking works correctly for the one-by-one case.
It still doesn't work correctly for the check-as-you-type case; I need to make these
same kinds of changes in markMisspellings, and refactor to share more code between
the two cases, but I wanted to get this working code in before modifying it further.

The major change here is that advanceToNextMisspelling used to look at small chunks of
text at a time, checking each one for both misspellings and questionable grammar. But
grammar checking needs at least paragraph-sized chunks of text to have enough context
to work correctly, so the old mechanism was causing many spurious complaints of bad
grammar (e.g., almost every word seemed to be at the start of a sentence so the checker
would complain about missing capitalization). So now the spell checker runs in the
specified range first. Then the grammar checker runs on the same range (stopping at the
next misspelling, if any), but expanded to paragraph-aligned boundaries.

bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): new function, extracted from advanceToNextMisspelling, and ignores grammar (WebCore::paragraphAlignedRangeForRange): new function, used by findNextBadGrammarInRange (WebCore::findFirstBadGrammarInRange): new function, extracted from advanceToNextMisspelling, and rewritten to use paragraph-aligned chunks, and ignores spelling (WebCore::subrange): new helper function, used by advanceToNextMisspelling (WebCore::FrameMac::advanceToNextMisspelling): now calls out to both findFirstMisspellingInRange and findFirstBadGrammarInRange separately instead of trying to interweave the spelling and grammar logic

1:21 PM Changeset in webkit [17965] by rwlbuis

14 edits in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11732:
Windows build bustage.

1:11 PM Changeset in webkit [17964] by yongjzha

4 edits in S60/branches/3.1m/WebKit

2006-11-30 yaharon <yael.aharon@nokia.com>

Reviewed by Yongjun <yongjun.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
http://bugzilla.opendarwin.org/show_bug.cgi?id=11727

BrowserControl/inc/BrCtl.h:
BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):

1:06 PM Changeset in webkit [17963] by yongjzha

4 edits in S60/trunk/WebKit

2006-11-30 yaharon <yael.aharon@nokia.com>

Reviewed by Yongjun <yongju.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
http://bugs.webkit.org/show_bug.cgi?id=11727

BrowserControl/inc/BrCtl.h: (CBrCtl::HttpLoaderEventToUi):
BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):

11:08 AM Changeset in webkit [22605] by sfalken