⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 4, 2006:

10:50 PM Changeset in webkit [18016] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix from last check-in. This line was badbad.

  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::~ContextMenu):
10:33 PM Changeset in webkit [18015] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

With the new changes to ContextMenuItems, WebCore context menus
stopped appearing at all. And then when I got them to appear, they
crashed. This fixes both of these problems.

  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::ContextMenuItem): keyEquivalent cannot be nil. This was causing Obj-C to throw an exception preventing the menus from popping up at all.
  • platform/mac/ContextMenuMac.mm: (+[WebCoreMenuTarget sharedMenuTarget]): Re-name our static MenuTarget so that it is more clear that it is a static and shared WebCoreMenuTarget. (WebCore::ContextMenu::ContextMenu): Initialize the WebCoreMenuTarget's controller in the ContextMenu constructor instead of in getNSMenuItem since the controller will only possibly change when a new ContextMenu has been created. (WebCore::ContextMenu::~ContextMenu): Set the target's controller to 0. (WebCore::getNSMenuItem): A lot of this work is being done other places now. Call new class method on WebCoreMenuTarget to get the shared target. (WebCore::ContextMenu::appendItem): We should not be releasing the menuItem here! This caused the crashes I saw. (WebCore::ContextMenu::insertItem): Same.
7:37 PM Changeset in webkit [18014] by andersca
  • 2 edits in trunk/WebCore

Fix the build.


  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::~SubresourceLoader): Add back the destructor.
7:17 PM Changeset in webkit [22613] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore.vcproj: Add SubresourceClient.h


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Get rid of the receivedResponse call.


(WebCore::didFinishLoading):
Get rid of the receivedAllData call, that's handled by the subresource loader now.

7:07 PM Changeset in webkit [18013] by andersca
  • 17 edits
    1 add in trunk/WebCore

Reviewed by Darin.


Change all ResourceHandleClients to be SubresourceLoaderClients instead. Also,
make SubresourceLoader a ResourceHandleClient. This is a first step towards turning ResourceHandle into a
standalone class which doesn't need to know about SubresourceLoader.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::setDefersLoading):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFailWithError): (WebCore::SubresourceLoader::receivedAllData):
  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::loaderAsResourceHandleClient): (WebCore::SubresourceLoader::handle):
  • loader/SubresourceLoaderClient.h: Added. (WebCore::SubresourceLoaderClient::~SubresourceLoaderClient): (WebCore::SubresourceLoaderClient::willSendRequest): (WebCore::SubresourceLoaderClient::didReceiveResponse): (WebCore::SubresourceLoaderClient::didReceiveData): (WebCore::SubresourceLoaderClient::didFinishLoading): (WebCore::SubresourceLoaderClient::didFailWithError): (WebCore::SubresourceLoaderClient::receivedAllData):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::stopLoading): (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading): (WebCore::IconLoader::clearLoadingState):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError): (WebCore::Loader::didReceiveResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests):
  • loader/loader.h:
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::loader):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::willSendRequest): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
5:36 PM Changeset in webkit [22612] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

  • WebCore.vcproj/WebCore.vcproj: Update for new UIEventWithKeyState.cpp file.
5:29 PM Changeset in webkit [18012] by darin
  • 12 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adele.

  • test the part of ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window that can easily be tested from the DOM -- this only checks that simulated mouse events from clicking on a link have the key state from the Enter key keyboard event, which is one part of the fix for the bug above
  • fast/events/simulated-key-state-expected.txt: Added.
  • fast/events/simulated-key-state.html: Added.

WebCore:

Reviewed by Adele.

This fixes command-return when the focus is on a link.
Despite the title of the bug, Mitz wanted me to fix both, and I will not
say no to him!

Test: fast/events/simulated-key-state.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Instead of always passing false for all the key state in simulated mouse events, pass the state from the first underlying event in the chain that has key state; in the case in the bug, the keyboard event will be the underlying event itself and we'll propagate the alt key modifier to the mouse event, resulting in the effect we want. It's nice that JavaScript also gets to see the proper modifiers in the mouse event.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Added code to pass in an underlying event to dispatchSimulatedClick. After looking at all the other callers, this seems to be the only one that needs to pass an event that is currently passing 0. Also removed the code that only simulated a click when the event has a PlatformKeyboardEvent -- no reason for that and it prevented me from writing a layout test for the fix.
  • dom/UIEventWithKeyState.h: Added findEventWithKeyState function that walks the underlyingEvent chain to find the first event that has key state. This already existed in WebKit, but I wanted to use it in dispatchSimulatedMouseEvent.
  • dom/UIEventWithKeyState.cpp: Added.
  • CMakeLists.txt: Added UIEventWithKeyState.cpp.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added UIEventWithKeyState.cpp.
  • WebCore.xcodeproj/project.pbxproj: Added UIEventWithKeyState.cpp.
  • WebCoreSources.bkl: Added UIEventWithKeyState.cpp.
  • WebCore.exp: Added findEventWithKeyState, used by WebKit.

WebKit:

Reviewed by Adele.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Changed to use the new findEventWithKeyState function in WebCore instead of a local function in this file.
4:49 PM Changeset in webkit [18011] by kmccullo
  • 11 edits in trunk/WebCore

Reviewed by Darin.

  • removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView):
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress):
  • config.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError):
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
  • page/Frame.cpp: (WebCore::Frame::setView):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::mouseDown):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
4:38 PM Changeset in webkit [22611] by kmccullo
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
  • config.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
4:37 PM Changeset in webkit [18010] by ggaren
  • 2 edits in trunk/WebKit

Rolled out the WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
part of my last checkin.


We have to turn on support for backward compatibility mode to avoid Dashboard
regressions in the short term.

  • WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]):
3:54 PM Changeset in webkit [18009] by ggaren
  • 15 edits in trunk

LayoutTests:

Reviewed by Darin Adler.


Removed Dashboard quirk from expected results. Now that we have a Dashboard
quirks mode, there's no reason to keep the old, bad behavior in the browser.

  • http/tests/xmlhttprequest/exceptions-expected.txt:
  • http/tests/xmlhttprequest/exceptions.html:

WebCore:

Reviewed by Darin Adler.


Added support for Dashboard backward compatibility mode.


  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke): Added support for old behavior of automatically clearing the stroke path buffer after a call to stroke().
  • html/HTMLCanvasElement.cpp: Added supoprt for old behavior of the canvas tag being self-closing. (WebCore::HTMLCanvasElement::endTagRequirement): (WebCore::HTMLCanvasElement::tagPriority):
  • html/HTMLCanvasElement.h:
  • html/HTMLParser.cpp: Ditto. (WebCore::HTMLParser::canvasCreateErrorCheck):
  • xml/xmlhttprequest.cpp: Added support for old behavior of silently ignoring a call to setRequestHeader() if it preceded a call to open() or followed a call to send(). (WebCore::XMLHttpRequest::setRequestHeader):

WebKit:

Reviewed by Darin Adler.


Added SPI for enabling Dashboard backward compatibility mode. For now,
we enable it unconditionally for Dashboard and Dashcode. Once they
implement specific support for the backward compatibility mode behavior,
we can change that.


Set the default WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
to YES in order to turn this code on.

  • WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]):
  • WebView/WebViewPrivate.h:
3:52 PM Changeset in webkit [22610] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::generalPasteboard): Got rid of s_generalPasteboard. Also removed definition of destructor.
3:43 PM Changeset in webkit [18008] by darin
  • 11 edits in trunk

WebCore:

Reviewed by Alice.

  • bridge/EditorClient.h: Removed "_web_" prefix from C++ userVisibleString member function. Alice will probably change this so it's not on the editor client any more later.
  • editing/Editor.h: Removed "_web_" prefix from C++ userVisibleString member function.
  • editing/Editor.cpp: Tweaked formatting a bit. Removed Mac-specific code from this file.
  • editing/mac/EditorMac.mm: (WebCore::Editor::newGeneralClipboard): Removed unnneded local variable. (WebCore::Editor::userVisibleString): Moved this function here.
  • platform/Pasteboard.h: Added some FIXMEs. Removed unneeded includes. Made Pasteboard noncopyable. Removed use of "protected" where we should be using "private". Removed s_generalPasteboard.
  • platform/mac/PasteboardMac.mm: Added some FIXMEs. Removed the s_generalPasteboard global. Removed the unused destructor. Updated call to userVisibleString for name change. Tweaked formatting.

WebKit:

Reviewed by Alice.

  • WebCoreSupport/WebEditorClient.h: Removed "_web_" prefix from C++ userVisibleString member function.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::userVisibleString): Ditto.
  • WebView/WebView.mm: (-[WebView selectedFrame]): Removed extra return statement.
3:34 PM Changeset in webkit [22609] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin, Geoff.

Get rid of ref() in ResourceHandle::start() and remove all uses of kill().


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceHandle::start):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::stop):

WebKitWin:

Reviewed by Darin, Geoff.

Don't use ResourceHandle::kill().

  • WebFrame.cpp: (WebFrame::stopMainResourceLoad):
3:31 PM Changeset in webkit [22608] by aliceli1
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
This bug was fixed by implementing EventHandler::handleDrag. The part of that
function after the drag hysteresis is exceeded remains unimplemented until
drag&drop is implemented.

  • page/win/EventHandlerWin.cpp: (WebCore::dragState): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):

WebKitWin:

Reviewed by Oliver.

Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
This bug was fixed by implementing EventHandler::handleDrag.

  • WebView.cpp: (WebView::WebView): Added a data member (WebView::handleMouseEvent): Create the mouse event telling it it activated the webview (WebViewWndProc): Call setMouseActivated upon receiving the relevent message
  • WebView.h: (WebView::setMouseActivated): Added this function so that the webview knows if it was brought to the foreground by a mouse event
3:30 PM Changeset in webkit [18007] by aliceli1
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

Moved some constants from EventHandlerMac.mm to EventHandler.cpp
Added some platform-specific data members and functions.

  • page/EventHandler.cpp:
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:
  • platform/PlatformMouseEvent.h: (WebCore::): (WebCore::PlatformMouseEvent::timestamp): (WebCore::PlatformMouseEvent::activatedWebView): (WebCore::PlatformMouseEvent::type):
3:26 PM Changeset in webkit [18006] by andersca
  • 8 edits in trunk/WebCore

Reviewed by Darin, Geoff.

Get rid of ResourceHandle::kill(), all it did was to balance out a ref() in ResourceHandle::start().
We use RefPtrs to ResourceHandle instead.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::~IconLoader): (WebCore::IconLoader::stopLoading): (WebCore::IconLoader::didReceiveResponse):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
  • loader/loader.h:
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::reportError):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::didFinishLoading):
3:14 PM Changeset in webkit [18005] by bdash
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix: set private attribute on ImageAnimationObserver.h so it is copied into the framework.

2:32 PM Changeset in webkit [18004] by oliver
  • 2 edits in trunk/WebCore

2006-12-04 Oliver Hunt <​oliver@apple.com>

Build fix for non-SVG builds

  • bindings/js/JSSVGPoint.cpp: (WebCore::JSSVGPointProtoFunc::callAsFunction):
2:31 PM Changeset in webkit [18003] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-28 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] browser fails to run the script when the page saved
​http://bugs.webkit.org/show_bug.cgi?id=11706

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::LoadSavedPageL):
2:00 PM Changeset in webkit [18002] by yongjzha
  • 7 edits in S60/trunk/WebKit

2006-12-04 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>.
DESC: [S60] PNIO-6TCGX3: document.referrer doesn't seem to have any value
​http://bugs.webkit.org/show_bug.cgi?id=11735

  • BrowserView/inc/WebKitLoader.h: (CWebKitLoader::ReferrerUrl):
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::SetPageUrlL): (CWebKitLoader::SetReferrerUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::IncomingReferrer):
  • ChangeLog:
  • ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::RefererUrl):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::ConstructL): (CUrlRequestInfo::SetRefererUrlL):
1:29 PM Changeset in webkit [18001] by darin
  • 2 edits in trunk/WebCore

Reviewed by Beth.

No test case added at the moment, but Beth said she'd investigate
adding one after the fact.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMousePressEventToScrollbar): Fix obvious-in-retrospect copy and paste error -- call passMouseDownEventToWidget instead of passWheelEventToWidget.
11:37 AM Changeset in webkit [18000] by ap
  • 12 edits
    5 adds in trunk

2006-12-04 Don Gibson <​dgibson77@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11738:
Make link clicking work again on Windows.

WebCore:

This re-implements a few functions that used to be part of FrameWin in
their new loader-based locations, and copies a few things from the Mac
and Qt event handling code that aren't strictly necessary but are
pretty simple.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h:
  • bridge/win/ContextMenuClientWin.h:
  • bridge/win/EditorClientWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::client):
  • bridge/win/FrameWin.h:
  • loader/win/DocumentLoaderWin.cpp: Added. (WebCore::DocumentLoader::setTitle):
  • loader/win/FrameLoaderClientWin.cpp: Added. (WebCore::FrameLoaderClientWin::userAgent):
  • loader/win/FrameLoaderClientWin.h:
  • loader/win/FrameLoaderWin.cpp: Added. (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::setTitle):
  • page/win/EventHandlerWin.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::EventHandler::tabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoaderClientWin::setTitle):

WebKit:

The WebKit changes are to ignore WM_MOUSEMOVED messages when the mouse
hasn't actually moved, which were preventing clicks from actually
getting dispatched in many cases. It's a peculiarity of Windows mouse
handling that we receive these at all.

  • COM/WebView.cpp: (WebView::WebView): (WebView::mouseMoved):
  • COM/WebView.h:
10:49 AM Changeset in webkit [17999] by ap
  • 4 edits in trunk/WebCore

2006-12-04 Don Gibson <​dgibson77@gmail.com>

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11748:
Windows build bustage.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/ContextMenuItem.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):
10:24 AM Changeset in webkit [17998] by sullivan
  • 2 edits
    1 move
    1 add in trunk/WebCore

Reviewed by Anders

Moved EditorMac.mm to its appropriate location

  • platform/mac/EditorMac.mm: Removed.
  • editing/mac/EditorMac.mm: Added
  • WebCore.xcodeproj/project.pbxproj: updated for this change
9:07 AM Changeset in webkit [17997] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Anders

  • fixed <rdar://problem/4857833> REGRESSION: When ctrl-clicking on a misspelled word, "Ignore Spelling" and "Learn Spelling" menu items not displayed in the contextual menu
  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): We were computing isSelectionMisspelled by calling WebCore, but then ignoring the result and always returning NO. D'oh!
7:14 AM Changeset in webkit [17996] by yongjzha
  • 6 edits in S60/trunk/WebKit

2006-12-01 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] Add platform scrollbars support, behind feature flag
​http://bugs.webkit.org/show_bug.cgi?id=11736

  • BrowserControl/inc/BrCtl.h: (MBrHistoryInterface::~MBrHistoryInterface): (NONSHARABLE_CLASS): (CBrCtl::WmlEngineInterface):
  • BrowserControl/inc/BrCtlScrollingProvider.h: (NONSHARABLE_CLASS):
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::DrawScrollbarBackground): (CBrCtl::MopSupplyObject): (CBrCtl::Draw): (CBrCtl::HandleResourceChange):
  • BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::NewL): (CBrCtlScrollingProvider::ConstructL): (CBrCtlScrollingProvider::~CBrCtlScrollingProvider): (CBrCtlScrollingProvider::UpdateVScrollBarL): (CBrCtlScrollingProvider::UpdateHScrollBarL): (CBrCtlScrollingProvider::NotifyLayoutChange): (CBrCtlScrollingProvider::VScrollBarWidth): (CBrCtlScrollingProvider::HScrollBarHeight): (CBrCtlScrollingProvider::VScrollBar): (CBrCtlScrollingProvider::HScrollBar): (CBrCtlScrollingProvider::ScrollBarCornerWindow): (CBrCtlScrollingProvider::SetScrollDisplayRect): (CBrCtlScrollingProvider::ResizeBrCtlView): (CBrCtlScrollingProvider::ShiftBrCtlView): (CBrCtlScrollingProvider::HandleScrollEventL): (CBrCtlScrollingProvider::SkinChangedL): (CBrCtlScrollingProvider::DrawBackground):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
  • ChangeLog:
1:21 AM Changeset in webkit [17995] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by dhyatt.

Patch by pmax.

​http://bugs.webkit.org/show_bug.cgi?id=3280
With LEGEND element, align=right value is not supported
​http://bugs.webkit.org/show_bug.cgi?id=11544
<legend> rendering doesn't take align into account

Allow aligning for legends in both RTL and LTR mode.

Dec 3, 2006:

4:16 PM Changeset in webkit [17994] by bdash
  • 2 edits in trunk/WebCore

2006-12-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11730
Bug 11730: Meta HTTP Refresh that contains a fraction / decimal get ignored.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse the refresh interval as a double rather than an integer.
8:29 AM Changeset in webkit [22607] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-12-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


<rdar://4853816> CFNetwork crash on Vista loading any SSL page

Change link order so secur32.dll is initialized prior to its
indirect use in code called by CoreGraphics DllMain.


To help avoid similar problems in the future, I reordered the
imported DLLs by level/dependency so things like CoreFoundation
is listed prior to CFNetwork and CoreGraphics.

  • WebKit.vcproj/WebKit.vcproj:
5:36 AM Changeset in webkit [17993] by zimmermann
  • 13 edits
    16 adds in trunk

Reviewed by Oliver.

Fix following bugs:
​http://bugs.webkit.org/show_bug.cgi?id=11734
​http://bugs.webkit.org/show_bug.cgi?id=11685

SVGPoint/SVGRect/SVGNumber were missing put() support.
SVGPoint.matrixTransform() was missing.

4:19 AM Changeset in webkit [17992] by zimmermann
  • 2 edits
    1 move in trunk/WebCore

Reviewed by Dave.
Another missing piece in the platform/graphics move.

4:02 AM Changeset in webkit [17991] by rwlbuis
  • 10 edits
    4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=11667
SVG: method .getTransformToElement(elt) in SVGLocatable not implemented

Implement getTransformToElement functionality. Introduce virtual
baseclass SVGLocatable to allow one implementation of the functionality.
Finally cleanup some code.

3:55 AM Changeset in webkit [17990] by zimmermann
  • 3 edits
    2 moves in trunk/WebCore

Reviewed by Rob.
Move some files around, which have been forgotton in the platform/graphics move.

3:39 AM Changeset in webkit [17989] by zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Mitz.
Fix non-svg build. (At least hope BuildBot doesn't moan anymore :-)

1:07 AM Changeset in webkit [17988] by ap
  • 4 edits in trunk/LayoutTests

Reviewed by Mitz.

This test used to be a pixel one, but without pixel results provided - converted to text.

  • http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:
  • http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
  • http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added a parameter to send() to make the test work in Firefox.
Note: See TracTimeline for information about the timeline view.