⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 7, 2006:

11:05 PM Changeset in webkit [18073] by ggaren
  • 3 edits
    6 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Tests for the change and blur events in input elements.

  • fast/events/onchange-passwordfield-expected.txt: Added.
  • fast/events/onchange-passwordfield.html: Added.
  • fast/events/onchange-searchfield-expected.txt: Added.
  • fast/events/onchange-searchfield.html: Added.
  • fast/events/onchange-textfield-expected.txt: Added.
  • fast/events/onchange-textfield.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4870551> 9A320: <input type="text"> no longer
dispatches onchange event in response to enter key


To match our old behavior and FF, we need to dispatch onchange in response to the
ENTER key. The strategy here is just to dispatch a blur event, since that's how
the search field always worked, and the DOM spec says onchange only fires
as a precursor to blur.

  • ChangeLog:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
7:53 PM Changeset in webkit [18072] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

Some small context menu-related fixes.

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Don't try to resize on a contextmenuEvent.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Only pass the event off to HTMLGenericFormElement if we haven't handled it.
7:22 PM Changeset in webkit [18071] by bdash
  • 5 edits in trunk/JavaScriptCore

2006-12-07 Kevin Fyure <​digdog@macports.org>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11545
Disable the testcases do not follow the ECMA-262v3 specification.


  • tests/mozilla/expected.html: Update Results.
  • tests/mozilla/js1_2/String/concat.js: 4 tests disabled. The result of concat Array object is not followinig ECMA 15.5.4.6
  • tests/mozilla/js1_2/function/Number.js: 1 test disabled. The result of Array object to Number object conversion is not following ECMA 9.3. And the test was duplicated in ecma/TypeConversion/9.3-1.js
  • tests/mozilla/js1_2/function/String.js: 2 tests disabled. The result of Object/Array object to String object conversion is not following ECMA 15.5.1.1 and ECMA 9.8
5:51 PM Changeset in webkit [18070] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-12-03 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: synthesize missing html node when comments start doc
​http://bugs.webkit.org/show_bug.cgi?id=11747

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
4:54 PM Changeset in webkit [18069] by andersca
  • 7 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4838778>
DashboardClient crashing in WebCore::SubresourceLoader::didFail.


  • http/tests/xmlhttprequest/abort-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/abort-crash.html: Added.
  • http/tests/xmlhttprequest/hello-world.cgi: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4838778>
Title: DashboardClient crashing in WebCore::SubresourceLoader::didFail


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::stopLoading):
  • loader/SubresourceLoader.h: Add stopLoading method which currently just clears the client. This isn't the ideal fix, since it doesn't actually stop the load.


  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): Add null-checks.


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): Call stopLoading.
4:28 PM Changeset in webkit [22636] by kmccullo
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by.

Fixed previous comment

  • ChangeLog:
4:26 PM Changeset in webkit [22635] by kmccullo
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

  • keyDown events must be followed by keyPressed events and before keyUp events.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
4:23 PM Changeset in webkit [18068] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Geof.

  • added the ability to set the auto repeating variable to force a keyPressed event from a keyDown event.
  • platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::setIsAutoRepeat):
4:14 PM Changeset in webkit [18067] by bdash
  • 1 edit
    5 adds in trunk/LayoutTests

2006-12-07 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=11771
Bug 11771: Add a test for resetting a textarea form control

  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea.html: Added.
4:10 PM Changeset in webkit [18066] by bdash
  • 2 edits in trunk/WebCore

2006-12-07 Don Gibson <​dgibson77@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11749
Don't call updateThumbProportion() unnecessarily.

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::setProportion):
3:50 PM Changeset in webkit [22634] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:44 PM Changeset in webkit [18065] by sfalken
  • 1 copy in tags/Safari-521.31.7b

New tag.

3:37 PM Changeset in webkit [18064] by bdash
  • 1 edit in tags/WebCore-521.31.2/WebCore/Info.plist

Versioning.

3:35 PM Changeset in webkit [18063] by bdash
  • 2 edits
    1 copy in tags/WebCore-521.31.2/WebCore

Merge fix from r18048

3:22 PM Changeset in webkit [18062] by bdash
  • 1 copy in tags/WebCore-521.31.2

New tag

3:21 PM Changeset in webkit [18061] by brmorris
  • 981 edits in S60/trunk/LayoutTests

2006-12-07 Bradley Morrison <​bradley.morrison@nokia.com>

Reviewed by Babu.


Updated expected layout test results to include color attribute.



2:10 PM Changeset in webkit [22633] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Two small fixes for bugs discovered while implementing the Snippet
Editor.

  • WebView.cpp: (registerWebViewWindowClass): Set the WebView's default cursor to be IDC_ARROW. (WebView::uiDelegate): Return E_FAIL if there's no UI delegate.
1:57 PM Changeset in webkit [22632] by sfalken
  • 5 edits in branches/WindowsMerge/WebKitWin

2006-12-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.


Add LPCTSTR_UI_STRING and LPCTSTR_UI_STRING_KEY.
Added caching to prevent re-converting strings unnecessarily.

  • WebKit.vcproj/WebKit.def: Export LPCTSTR localization function
  • WebKit.vcproj/WebKit_debug.def: Export LPCTSTR localization function
  • WebLocalizableStrings.cpp: (createWebKitBundle): Added using namespace so we don't need to qualify String (WebLocalizedLPCTSTR): Added
  • WebLocalizableStrings.h: Added LPCTSTR localization support
1:49 PM Changeset in webkit [18060] by sfalken
  • 2 edits in trunk/WebKitTools

2006-12-06 Steve Falkenburg <​sfalken@apple.com>

Support C strings for localization

  • Scripts/extract-localizable-strings:
12:47 PM Changeset in webkit [18059] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Brady.

Build fix for WebCore ContextMenus. It got broken by r18046.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):
11:57 AM Changeset in webkit [22631] by bdakin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady.

New link stub for load() function used by
ContextMenuItemTagOpenLink action.

  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load):

WebKitWin:

Reviewed by Brady.

Make some parameters const and const references.

  • WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
  • WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/TemporaryLinkStubs.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

11:49 AM Changeset in webkit [18058] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-05 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Toolbar tooltip not OK for RTL tooltip like Hebrew
​http://bugs.webkit.org/show_bug.cgi?id=11761

  • BrowserView/src/WebKitView.cpp: (CWebKitView::DrawToolTip):
11:49 AM Changeset in webkit [18057] by bdakin
  • 7 edits in trunk

WebCore:

Reviewed by Brady.

Fixes "Open in new Window" item in WebCore ContextMenus. It wasn't
doing anything before, and now it works! Also some formatting
changes, etc.

  • page/ContextMenuClient.h: Several of the parameters to several of the functions here should be const or const references. And now they are!
  • page/ContextMenuController.cpp: (WebCore::openNewWindow): Moved the open new window functionality into a helper function since it is used by several menu item tags. Now after calling chrome()->createWindow() we call chrome()->show() on the new window, and so it appears! (WebCore::ContextMenuController::contextMenuItemSelected): Call new openNewWindow function to do the right thing. Shift some formatting, use local variable for HitTestResult. Implement action for ContextMenuItemTagOpenLink.

WebKit:

Reviewed by Brady.

Make some parameters const and const references.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
11:41 AM Changeset in webkit [18056] by yongjzha
  • 2 edits in S60/trunk/WebCore

2006-12-07 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link
​http://bugs.webkit.org/show_bug.cgi?id=11776

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
11:39 AM Changeset in webkit [22630] by adachan
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

2006-12-07 Ada Chan <​adachan@apple.com>

Reviewed by Steve and Anders.

<rdar://4866288> Crash on boomer quit

  • don't close the themes on termination, since uxtheme should do that anyway.
1:49 AM Changeset in webkit [18055] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Fixed typos/misspellings.

Dec 6, 2006:

6:47 PM Changeset in webkit [18054] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by.

  • Removed a confilct marker
  • ChangeLog:
6:47 PM Changeset in webkit [22629] by adachan
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

2006-12-06 Ada Chan <​adachan@apple.com>

Reviewed by Maciej.

Fixed a couple of things while investigating <rdar://4866288> (note this doesn't fix the crash yet):

  • we forgot to initialize m_sliderTheme
  • we did the wrong null check when getting the slider theme.
6:46 PM Changeset in webkit [18053] by justing
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4818134>
Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

  • editing/selection/select-line-expected.txt: Added.
  • editing/selection/select-line.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4818134>
Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed RebalanceWhitespaceCommand.*.
  • editing/visible_units.cpp: (WebCore::startOfLine): There are VisiblePositions at offset 0 in blocks without RootInlineBoxes, like empty editable blocks and bordered blocks. (WebCore::endOfLine): Ditto.
6:40 PM Changeset in webkit [18052] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by.

  • Removed a confilct marker
  • ChangeLog:
6:24 PM Changeset in webkit [18051] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/htmlediting.cpp: (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape from editable content.
  • editing/markup.cpp: (WebCore::createMarkup): A null commonAncestorBlock will happen if commonAncestor is inside an inline editable root that doesn't contain any blocks. Removed an early return for this case: the code below the early return can and must handle it.
5:01 PM Changeset in webkit [18050] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/deleting/delete-mixed-editable-content-001-expected.txt:
  • editing/inserting/editable-inline-element-expected.checksum: Added.
  • editing/inserting/editable-inline-element-expected.txt: Added.
  • editing/inserting/editable-inline-element-expected.png: Added.
  • editing/inserting/editable-inline-element.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/htmlediting.cpp: (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape from editable content.
  • editing/markup.cpp: (WebCore::createMarkup): A null commonAncestorBlock will happen if commonAncestor is inside an inline editable root that doesn't contain any blocks. Removed an early return for this case: the code below the early return can and must handle it.
4:41 PM Changeset in webkit [18049] by beidson
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11675 and <rdar://4857669>
Now we need to explicitly set the data source when loading from a page cache

  • History/WebHistoryItem.mm: (-[WebHistoryItem _scheduleRelease]): Enhanced a logging message (+[WebHistoryItem _releasePageCache:]): Ditto (+[WebHistoryItem _releaseAllPendingPageCaches]): Ditto
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache): Reset the View's DataSource from the cache, effectively reopening it
  • WebView/WebHTMLView.m: (-[NSArray setDataSource:]): Properly Handle resetting the DataSource and "reopening" the view
4:22 PM Changeset in webkit [18048] by thatcher
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4843505> Fix cross-library ivar use for 64-bit Objective-C

Adds a new WebCore.LP64.exp file that gets appended to the normal export file.
This new file will have 64-bit only symbols we need to export.

  • WebCore.LP64.exp: Added.
  • WebCore.xcodeproj/project.pbxproj:
4:15 PM Changeset in webkit [22628] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Fix the build.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFail): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):

WebKitWin:

Fix the build.

  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::didFail):
  • WebFrame.h:
4:08 PM Changeset in webkit [18047] by andersca
  • 18 edits in trunk/WebCore

Reviewed by Maciej.


Change SubresourceLoader to use a ResourceHandle, and change ResourceHandle to use a NSURLConnection.


  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail):
  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): (WebCore::SubresourceLoader::didCancelAuthenticationChallenge): (WebCore::SubresourceLoader::willStopBufferingData): (WebCore::SubresourceLoader::willCacheResponse): (WebCore::SubresourceLoader::receivedCredential): (WebCore::SubresourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::SubresourceLoader::receivedCancellation):
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFail):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::didFail):
  • loader/loader.h:
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::resourceData):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::setDefersLoading): (WebCore::SubresourceLoader::resourceData): (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveData): (WebCore::ResourceHandleClient::didFail): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::willStopBufferingData): (WebCore::ResourceHandleClient::willCacheResponse): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::delegate): (WebCore::ResourceHandle::releaseDelegate): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::bufferedData): (-[WebCoreResourceHandleAsDelegate initWithHandle:]): (-[WebCoreResourceHandleAsDelegate detachHandle]): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFail):
  • xml/xmlhttprequest.h:
2:41 PM Changeset in webkit [22627] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Modify PluginStreamWin to use a SubresourceLoader instead of a ResourceHandle.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFail): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load):
2:33 PM Changeset in webkit [22626] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Build fixes.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::scheduleClose):
1:55 PM Changeset in webkit [18046] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Adam and Oliver

While working on ​http://bugs.webkit.org/show_bug.cgi?id=11675 I
decided to fix much of the null-deref problems that creeped in via
the loader refactoring. This isn't changing behavior, just reintroducing
the free nil checking we used to have with pure ObjC

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Explicitly check for null frames (-[NSArray mouseDown:]): Ditto (-[NSArray mouseDragged:]): Ditto (-[NSArray mouseUp:]): Ditto (-[NSArray performKeyEquivalent:]): Ditto (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto
1:54 PM Changeset in webkit [18045] by bdakin
  • 5 edits in trunk/WebCore

Reviewed by Adam.

There are two bugs with WebCore ContextMenus due to the static
ContextMenuItems. One bug is that we often crashed in
NSAutoreleasePool upon quitting the browser. The other bug is that
we were adding static NSMenuItems to multiple NSMenus, which is
disallowed. To fix these bugs, the MenuItems are no longer static.
This is in line with the current design in WebKit anyway. I made
some re-arrangements in the code because I also removed the macro
that was used to create the menu items since it was a bit
confusing.

  • platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate):
  • platform/ContextMenuItem.h:
  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::ContextMenuItem): Use the NSMenuItem global separator item if we have SeparatorType.
  • platform/mac/ContextMenuMac.mm: (WebCore::setMenuItemTarget): Change name of getNSMenuItem since that is no longer accurate. (WebCore::ContextMenu::appendItem): Above name change. (WebCore::ContextMenu::insertItem): Same.
1:46 PM Changeset in webkit [18044] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Geof.

  • Returned the semantic meaning of the mask to be the actual repeat count, and changed auto_repeat to correctly differnetiate between keypressed and keydown.
  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
1:01 PM Changeset in webkit [18043] by justing
  • 10 edits
    4 adds
    2 deletes in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4753545>
REGRESSION: Edited whitespace sequences are all nbsps (10636)

  • editing/inserting/edited-whitespace-1-expected.checksum: Added.
  • editing/inserting/edited-whitespace-1-expected.png: Added.
  • editing/inserting/edited-whitespace-1-expected.txt: Added.
  • editing/inserting/edited-whitespace-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4753545>
REGRESSION: Edited whitespace sequences are all nbsps (10636)

  • WebCore.xcodeproj/project.pbxproj: Removed RebalanceWhitespaceCommand.* from the project.
  • editing/CompositeEditCommand.cpp: (WebCore::isWhitespace): Moved from htmlediting. (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Moved the work that was once done in its own command here. (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Prevents whitespace around a position from collapsing when it's pushed apart during Paste. This function can eventually be deployed to eliminate the need for leading/trailing whitespace handling in InsertParagraphSeparator, InsertLineBreak, Delete, and BreakBlockquote. (WebCore::CompositeEditCommand::rebalanceWhitespace): Cleaned up.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Do rebalanceWhitespaceAt *before* saving the typing style, because whitespace rebalancing is no longer it's own command that claims to preserve the typing style.
  • editing/RebalanceWhitespaceCommand.cpp: Removed.
  • editing/RebalanceWhitespaceCommand.h: Removed.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Moved the code to prepare whitespace arond a position for being pushed aparat to its own method.
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Added. Returns a rebalanced string. Takes in whether or not the beginning of that string will be at the start of a paragraph, because a space at such a position must have be nbsp, even if that doesn't follow the nbsp/space pattern used. Similar stuff for the end of a paragraph.
  • editing/htmlediting.h:
  • editing/markup.cpp: (WebCore::fillContainerFromString): Call stringWithRelabacedWhitespace. Pass it the startOfParagraph/endOfParagraph bools.
12:39 PM Changeset in webkit [18042] by rwlbuis
  • 6 edits in trunk/WebKitSite

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=10254
A few grammar and spelling corrections on the WebKit website

Grammar and spelling corrections by Jonathan Johnsson.

12:01 PM Changeset in webkit [22625] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin
10:57 AM Changeset in webkit [22624] by sullivan
  • 3 edits in branches/WindowsMerge/WebCore

Try to keep the windows build happy with Frame -> Editor changes...

  • bridge/win/FrameWin.h: removed declarations of spelling and grammar functions
  • platform/win/TemporaryLinkStubs.cpp:
changed spelling and grammar functions from FrameWin
to Editor:: (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::Editor::advanceToNextMisspelling):
10:50 AM Changeset in webkit [18041] by sullivan
  • 14 edits in trunk

WebCore:

Reviewed by Beth

Moved spelling and grammar code from Frame to Editor

  • WebCore.exp: updated for these changes
  • page/Frame.h: removed declarations of spelling and grammar functions
  • bridge/mac/FrameMac.h: removed declarations of spelling and grammar functions
  • bridge/mac/FrameMac.mm: moved implementation of spelling and grammar functions from here (WebCore::FrameMac::respondToChangedSelection): updated for moved functions
  • editing/Editor.h: moved declarations of spelling and grammar functions to here
  • editing/mac/EditorMac.mm: moved implementation of spelling and grammar functions to here; changed only to make it compile (e.g. removing "editor()->" and adding "frame()->" where appropraite. (WebCore::findFirstMisspellingInRange): (WebCore::paragraphAlignedRangeForRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::core): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::markAllMisspellingsInRange): (WebCore::markAllBadGrammarInRange): (WebCore::Editor::markMisspellings):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): updated for moved functions
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): updated for moved functions

WebKit:

Reviewed by Beth

Updated to match Frame -> Editor changes in WebCore

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): guessesForUngrammaticalSelection() is now in Editor
  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionUngrammatical]): isSelectionUngrammatical() is now in Editor (-[WebHTMLView _isSelectionMisspelled]): isSelectionMisspelled() is now in Editor

(-[WebHTMLView checkSpelling:]):
advanceToNextMisspelling() is now in Editor
(-[WebHTMLView showGuessPanel:]):
ditto

Note: See TracTimeline for information about the timeline view.