⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 8, 2006:

11:54 PM Changeset in webkit [18099] by hyatt
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h

Fix mac bustage.

9:54 PM Changeset in webkit [18098] by hyatt
  • 42 edits
    13 adds
    5 deletes in trunk

JavaScriptCore:

Land the new ICU abstraction layer. Patch by Lars.

Reviewed by me

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Platform.h:
  • wtf/unicode/UnicodeCategory.h: Removed.
  • wtf/unicode/UnicodeDecomposition.h: Removed.
  • wtf/unicode/UnicodeDirection.h: Removed.
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::direction): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset):
  • wtf/unicode/qt4/UnicodeQt4.cpp: Removed.
  • wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset): (WTF::Unicode::direction): (WTF::Unicode::category):

WebCore:

Land the new ICU abstraction layer (WTF::Unicode). Patch
by Lars with a couple of fixes thrown in by me.

Reviewed by hyatt

  • ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
  • ForwardingHeaders/wtf/unicode/Unicode.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::ParseString::lower):
  • dom/Document.cpp: (WebCore::isValidNameStart): (WebCore::isValidNamePart):
  • editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::append):
  • html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
  • html/HTMLInputElement.cpp: (WebCore::numGraphemeClusters): (WebCore::numCharactersInGraphemeClusters):
  • html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
  • page/Frame.h:
  • platform/DeprecatedString.h: (WebCore::DeprecatedChar::isSpace): (WebCore::DeprecatedChar::lower): (WebCore::DeprecatedChar::upper):
  • platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks):
  • platform/FontCache.h:
  • platform/FontData.h:
  • platform/GlyphMap.cpp:
  • platform/GlyphMap.h:
  • platform/GlyphWidthMap.h:
  • platform/KURL.cpp: (WebCore::encodeHostname):
  • platform/StringHash.h: (WTF::):
  • platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::capitalize): (WebCore::StringImpl::toInt): (WebCore::equalIgnoringCase): (WebCore::StringImpl::find):
  • platform/StringImpl.h:
  • platform/TextBoundaries.h:
  • platform/TextBreakIterator.h: Added. (WebCore::):
  • platform/TextBreakIteratorICU.cpp: Added. (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
  • platform/TextCodec.h:
  • platform/TextCodecLatin1.cpp:
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::encode):
  • platform/TextEncoding.h:
  • platform/TextEncodingRegistry.cpp: (WebCore::buildTextEncodingNameMap): (WebCore::buildTextCodecMap):
  • platform/TextEncodingRegistry.h:
  • platform/UChar.h: Removed.
  • platform/graphics/GraphicsContext.h:
  • platform/qt/GlyphMapQt.cpp:
  • platform/qt/TextBreakIteratorQt.cpp: Added. (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
  • platform/qt/TextCodecQt.cpp: Added. (WebCore::getAtomicName): (WebCore::TextCodecQt::registerEncodingNames): (WebCore::newTextCodecQt): (WebCore::TextCodecQt::registerCodecs): (WebCore::TextCodecQt::TextCodecQt): (WebCore::TextCodecQt::~TextCodecQt): (WebCore::TextCodecQt::decode): (WebCore::TextCodecQt::encode):
  • platform/qt/TextCodecQt.h: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderText.cpp: (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): (WebCore::RenderText::widthFromCache):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::direction): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiContext::dir): (WebCore::BidiContext::basicDir): (WebCore::BidiRun::BidiRun):
  • rendering/break_lines.h:

WebKit:

Land new ICU abstraction layer. Patch by Lars.

Reviewed by me

  • ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
  • ForwardingHeaders/wtf/unicode/Unicode.h: Added.
  • WebKit.xcodeproj/project.pbxproj:
8:10 PM Changeset in webkit [18097] by aroben
  • 6 edits in trunk/WebCore

Rolling out r17865 because it caused a performance regression.

  • loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding):
  • platform/CString.cpp: (WebCore::CString::data):
  • platform/CString.h:
  • platform/TextStream.cpp: (WebCore::TextStream::operator<<):
  • platform/TextStream.h:
6:44 PM Changeset in webkit [22640] by kmccullo
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

  • createWebViewWithRequest now increases the ref count for the new window it returns. This is standard practice for COM, and fixes a crash.
  • WebFrame.cpp: (WebFrame::openURL):
5:27 PM Changeset in webkit [18096] by zack
  • 34 edits
    4 adds in trunk

Reviewed by Maciej.

Patch fixes compile of all Qt/KDE code after
the recent API changes.

5:25 PM Changeset in webkit [18095] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Remove stray conflict marker

5:13 PM Changeset in webkit [18094] by thatcher
  • 9 copies in tags/Safari-521.32

New tag.

5:07 PM Changeset in webkit [18093] by thatcher
  • 7 edits in /

Versioning

4:38 PM Changeset in webkit [18092] by thatcher
  • 2 edits in trunk/WebKit

Rolling out a change that broke Mail stationary.
<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load

  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]):
4:31 PM Changeset in webkit [18091] by staikos
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

Build Qt webkit on non-linux, and prefer it if $QTDIR is set

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
4:11 PM Changeset in webkit [22639] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

  • platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Fix use of min().
3:40 PM Changeset in webkit [18090] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=10188
Form elements added via appendChild() are not accessible via form.element

Make sure looking up form elements works when the form is not appended
to the document.

2:44 PM Changeset in webkit [18089] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=11765
REGRESSION: Clicking on a select with size other than 1 and no children results in a crash

Make sure returned value is -1 for selects without children.

2:37 PM Changeset in webkit [22638] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
2:34 PM Changeset in webkit [18088] by aroben
  • 2 edits in trunk

Fixed typo.

2:34 PM Changeset in webkit [18087] by aroben
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Anders.

This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.

  • kjs/config.h:
  • wtf/Vector.h:

WebCore:

Reviewed by Anders.

This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.

  • config.h:
1:21 PM Changeset in webkit [18086] by ap
  • 11 edits in trunk

2006-12-08 Don Gibson <​dgibson77@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11759:
Windows build bustage

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ContextMenuClientWin.h:
  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
  • platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::fileButtonChooseFileLabel): (WebCore::inputElementAltText): (WebCore::copyCursor): (WebCore::resetButtonDefaultLabel): (WebCore::ContextMenuClientWin::contextMenuItemSelected): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::FrameLoader::load): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::respondToChangedSelection):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::loadDataSource):
  • COM/WebFrame.h:
1:12 PM Changeset in webkit [18085] by weinig
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Testcases for ​http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.

  • fast/dom/XMLSerializer-doctype-expected.txt: Added.
  • fast/dom/XMLSerializer-doctype.html: Added.
  • fast/dom/XMLSerializer-doctype2-expected.txt: Added.
  • fast/dom/XMLSerializer-doctype2.html: Added.

WebCore:

Reviewed by Geoff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.

Test: fast/dom/XMLSerializer-doctype.html
Test: fast/dom/XMLSerializer-doctype2.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): set the document of the DocumentType node to the new document.
  • xml/XMLSerializer.cpp: Cleanup. (WebCore::XMLSerializer::serializeToString): now throws an exception for documentless nodes.
  • xml/XMLSerializer.h: cleanup
  • xml/XMLSerializer.idl: add exception
11:29 AM Changeset in webkit [18084] by justing
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4836287>
Cannot expand selection out of editable element when containing element is non-editable.

  • editing/selection/mixed-editability-6-expected.checksum: Added.
  • editing/selection/mixed-editability-6-expected.png: Added.
  • editing/selection/mixed-editability-6-expected.txt: Added.
  • editing/selection/mixed-editability-6.html: Added.
  • editing/selection/mixed-editability-7-expected.checksum: Added.
  • editing/selection/mixed-editability-7-expected.png: Added.
  • editing/selection/mixed-editability-7-expected.txt: Added.
  • editing/selection/mixed-editability-7.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4836287>
Cannot expand selection out of editable element when containing element is non-editable.

  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Restrict the selection endpoints to the same *highest* editable root. This bug only happened when creating selections based in an editable region and extending into a higher editable root, so this change doesn't expose any new kinds of deletions, but we should start thinking about how those deletions should behave.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Ditto.
10:53 AM Changeset in webkit [18083] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Add nil check.
10:46 AM Changeset in webkit [22637] by bdakin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>. Not doing
this breaks sub-menus on Boomer since the menu items are no longer
static.

  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):
10:42 AM Changeset in webkit [18082] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

Typo! Thanks Mitz!

10:37 AM Changeset in webkit [18081] by bdakin
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>

  • platform/ContextMenu.cpp: Because of the OwnPtr in ContextMenuItem, we have to separate the declaration of ContextMenuItems away from the calls to appendItem(). Not doing so causes a build failure because OwnPtr inherits from Noncopyable. (WebCore::createFontSubMenu): Same. (WebCore::createSpellingAndGrammarSubMenu): Same. (WebCore::createSpellingSubMenu): Same. (WebCore::createSpeechSubMenu): Same. (WebCore::createWritingDirectionSubMenu): Same. (WebCore::ContextMenu::populate): Same.
  • platform/ContextMenuItem.h: New member variable m_subMenu.
  • platform/mac/ContextMenuItemMac.mm: Take care of setting m_subMenu in addition to setting the submenu of the NSMenuItem when we have a sub-menu. (WebCore::menuToArray): (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setSubMenu): Same.
10:35 AM Changeset in webkit [18080] by ap
  • 2 edits in trunk/WebCore

2006-12-08 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11778
CString::data() should be documented as returning a null terminated char array

  • platform/CString.h: Add some basic documentation to CString.h
10:31 AM Changeset in webkit [18079] by ap
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11718
REGRESSION: When I mouse up after dragging a selection outside of a iframe, the iframe
continues to scroll automatically.

Test: manual-tests/autoscroll.html

  • manual-tests/autoscroll.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Assign to m_mousePressNode earlier, so that it is available in the superframe as well. Reset m_mouseDownWasInSubframe to false when starting to handle a mousedown - previously, its value was only defined if the event was passed down to a widget or a subframe.

(WebCore::EventHandler::stopAutoscrollTimer):
If the mouse down event was in a subframe, stop the subframe's timer.

10:25 AM Changeset in webkit [18078] by ap
  • 9 edits in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=6275
XMLHttpRequest.getResponseHeader should return a null string for non-existent headers

WebCore:

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Convert null getResponseHeader strings to JS null, rather than undefined.

LayoutTests:

  • http/tests/xmlhttprequest/methods-async-expected.txt:
  • http/tests/xmlhttprequest/methods-expected.txt:
  • http/tests/xmlhttprequest/methods-lower-case-expected.txt: Updated the results.
  • http/tests/xmlhttprequest/web-apps/008-expected.txt:
  • http/tests/xmlhttprequest/web-apps/008-test.asis:
  • http/tests/xmlhttprequest/web-apps/008.html: Changed to test both missing and empty headers, also test case insensitivity of header names. Please note that neither Firefox nor IE passes this test now - the former returns null in both cases, and the latter returns empty strings.
10:19 AM Changeset in webkit [18077] by ap
  • 5 edits
    7 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=9854
HTTP Refresh header with quotes is parsed incorrectly

Test: http/tests/misc/redirect-with-quotes.php

  • WebCore.xcodeproj/project.pbxproj: Added HTTPParsers.{h,cpp}. I intend to move Content-Type parsing here, as well.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Use the new implementation in HTTPHeaders.
  • platform/network/HTTPParsers.cpp: Added. (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
  • platform/network/HTTPParsers.h: Added. Merged and rewrote existing implementations for better Firefox compatibility.
10:03 AM Changeset in webkit [18076] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=11772
REGRESSION: XMLSerializer.serializeToString incorrect value for CDATA nodes

Test: fast/dom/serialize-cdata.html

  • editing/markup.cpp: (WebCore::startMarkup): Dump CDATA sections, too.
3:02 AM Changeset in webkit [18075] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by hyatt.

Deleted misplaced comment.

12:02 AM Changeset in webkit [18074] by rwlbuis
  • 11 edits
    4 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=6074
WebKit+SVG and FireFox disagree on invalid "transform" handling

Test for parsing failure on transform attribute and clear the transform
list upon failure to match FF behaviour.

Dec 7, 2006:

11:05 PM Changeset in webkit [18073] by ggaren
  • 3 edits
    6 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Tests for the change and blur events in input elements.

  • fast/events/onchange-passwordfield-expected.txt: Added.
  • fast/events/onchange-passwordfield.html: Added.
  • fast/events/onchange-searchfield-expected.txt: Added.
  • fast/events/onchange-searchfield.html: Added.
  • fast/events/onchange-textfield-expected.txt: Added.
  • fast/events/onchange-textfield.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4870551> 9A320: <input type="text"> no longer
dispatches onchange event in response to enter key


To match our old behavior and FF, we need to dispatch onchange in response to the
ENTER key. The strategy here is just to dispatch a blur event, since that's how
the search field always worked, and the DOM spec says onchange only fires
as a precursor to blur.

  • ChangeLog:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
7:53 PM Changeset in webkit [18072] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Oliver.

Some small context menu-related fixes.

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Don't try to resize on a contextmenuEvent.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Only pass the event off to HTMLGenericFormElement if we haven't handled it.
7:22 PM Changeset in webkit [18071] by bdash
  • 5 edits in trunk/JavaScriptCore

2006-12-07 Kevin Fyure <​digdog@macports.org>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11545
Disable the testcases do not follow the ECMA-262v3 specification.


  • tests/mozilla/expected.html: Update Results.
  • tests/mozilla/js1_2/String/concat.js: 4 tests disabled. The result of concat Array object is not followinig ECMA 15.5.4.6
  • tests/mozilla/js1_2/function/Number.js: 1 test disabled. The result of Array object to Number object conversion is not following ECMA 9.3. And the test was duplicated in ecma/TypeConversion/9.3-1.js
  • tests/mozilla/js1_2/function/String.js: 2 tests disabled. The result of Object/Array object to String object conversion is not following ECMA 15.5.1.1 and ECMA 9.8
5:51 PM Changeset in webkit [18070] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-12-03 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: synthesize missing html node when comments start doc
​http://bugs.webkit.org/show_bug.cgi?id=11747

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
4:54 PM Changeset in webkit [18069] by andersca
  • 7 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4838778>
DashboardClient crashing in WebCore::SubresourceLoader::didFail.


  • http/tests/xmlhttprequest/abort-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/abort-crash.html: Added.
  • http/tests/xmlhttprequest/hello-world.cgi: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4838778>
Title: DashboardClient crashing in WebCore::SubresourceLoader::didFail


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::stopLoading):
  • loader/SubresourceLoader.h: Add stopLoading method which currently just clears the client. This isn't the ideal fix, since it doesn't actually stop the load.


  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): Add null-checks.


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): Call stopLoading.
4:28 PM Changeset in webkit [22636] by kmccullo
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by.

Fixed previous comment

  • ChangeLog:
4:26 PM Changeset in webkit [22635] by kmccullo
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

  • keyDown events must be followed by keyPressed events and before keyUp events.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
4:23 PM Changeset in webkit [18068] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Geof.

  • added the ability to set the auto repeating variable to force a keyPressed event from a keyDown event.
  • platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::setIsAutoRepeat):
4:14 PM Changeset in webkit [18067] by bdash
  • 1 edit
    5 adds in trunk/LayoutTests

2006-12-07 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=11771
Bug 11771: Add a test for resetting a textarea form control

  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea.html: Added.
4:10 PM Changeset in webkit [18066] by bdash
  • 2 edits in trunk/WebCore

2006-12-07 Don Gibson <​dgibson77@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11749
Don't call updateThumbProportion() unnecessarily.

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::setProportion):
3:50 PM Changeset in webkit [22634] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:44 PM Changeset in webkit [18065] by sfalken
  • 1 copy in tags/Safari-521.31.7b

New tag.

3:37 PM Changeset in webkit [18064] by bdash
  • 1 edit in tags/WebCore-521.31.2/WebCore/Info.plist

Versioning.

3:35 PM Changeset in webkit [18063] by bdash
  • 2 edits
    1 copy in tags/WebCore-521.31.2/WebCore

Merge fix from r18048

3:22 PM Changeset in webkit [18062] by bdash
  • 1 copy in tags/WebCore-521.31.2

New tag

3:21 PM Changeset in webkit [18061] by brmorris
  • 981 edits in S60/trunk/LayoutTests

2006-12-07 Bradley Morrison <​bradley.morrison@nokia.com>

Reviewed by Babu.


Updated expected layout test results to include color attribute.



2:10 PM Changeset in webkit [22633] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Two small fixes for bugs discovered while implementing the Snippet
Editor.

  • WebView.cpp: (registerWebViewWindowClass): Set the WebView's default cursor to be IDC_ARROW. (WebView::uiDelegate): Return E_FAIL if there's no UI delegate.
1:57 PM Changeset in webkit [22632] by sfalken
  • 5 edits in branches/WindowsMerge/WebKitWin

2006-12-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.


Add LPCTSTR_UI_STRING and LPCTSTR_UI_STRING_KEY.
Added caching to prevent re-converting strings unnecessarily.

  • WebKit.vcproj/WebKit.def: Export LPCTSTR localization function
  • WebKit.vcproj/WebKit_debug.def: Export LPCTSTR localization function
  • WebLocalizableStrings.cpp: (createWebKitBundle): Added using namespace so we don't need to qualify String (WebLocalizedLPCTSTR): Added
  • WebLocalizableStrings.h: Added LPCTSTR localization support
1:49 PM Changeset in webkit [18060] by sfalken
  • 2 edits in trunk/WebKitTools

2006-12-06 Steve Falkenburg <​sfalken@apple.com>

Support C strings for localization

  • Scripts/extract-localizable-strings:
12:47 PM Changeset in webkit [18059] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Brady.

Build fix for WebCore ContextMenus. It got broken by r18046.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):
11:57 AM Changeset in webkit [22631] by bdakin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady.

New link stub for load() function used by
ContextMenuItemTagOpenLink action.

  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load):

WebKitWin:

Reviewed by Brady.

Make some parameters const and const references.

  • WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
  • WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/TemporaryLinkStubs.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

11:49 AM Changeset in webkit [18058] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-05 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Toolbar tooltip not OK for RTL tooltip like Hebrew
​http://bugs.webkit.org/show_bug.cgi?id=11761

  • BrowserView/src/WebKitView.cpp: (CWebKitView::DrawToolTip):
11:49 AM Changeset in webkit [18057] by bdakin
  • 7 edits in trunk

WebCore:

Reviewed by Brady.

Fixes "Open in new Window" item in WebCore ContextMenus. It wasn't
doing anything before, and now it works! Also some formatting
changes, etc.

  • page/ContextMenuClient.h: Several of the parameters to several of the functions here should be const or const references. And now they are!
  • page/ContextMenuController.cpp: (WebCore::openNewWindow): Moved the open new window functionality into a helper function since it is used by several menu item tags. Now after calling chrome()->createWindow() we call chrome()->show() on the new window, and so it appears! (WebCore::ContextMenuController::contextMenuItemSelected): Call new openNewWindow function to do the right thing. Shift some formatting, use local variable for HitTestResult. Implement action for ContextMenuItemTagOpenLink.

WebKit:

Reviewed by Brady.

Make some parameters const and const references.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
11:41 AM Changeset in webkit [18056] by yongjzha
  • 2 edits in S60/trunk/WebCore

2006-12-07 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link
​http://bugs.webkit.org/show_bug.cgi?id=11776

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
11:39 AM Changeset in webkit [22630] by adachan
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

2006-12-07 Ada Chan <​adachan@apple.com>

Reviewed by Steve and Anders.

<rdar://4866288> Crash on boomer quit

  • don't close the themes on termination, since uxtheme should do that anyway.
1:49 AM Changeset in webkit [18055] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Fixed typos/misspellings.

Note: See TracTimeline for information about the timeline view.