Timeline
Dec 9, 2006:
- 11:13 PM Changeset in webkit [18131] by
-
- 3 edits in trunk/WebCore
Remove unused/pointless code from FrameQtClient.
- 11:11 PM Changeset in webkit [18130] by
-
- 2 edits in trunk/WebCore
Build fix.
- xml/XPathParser.cpp: (WebCore::XPath::charCat): Use C++ unsigned instead of uint.
- 10:54 PM Changeset in webkit [18129] by
-
- 3 edits in trunk/WebCore
Reviewed by Zack.
Make it not crash, and make it set the title on Qt platform.
- 10:36 PM Changeset in webkit [18128] by
-
- 7 edits in trunk
Include DumpRenderTree in the Qt build and adjust it to the
recet platform/qt changes (by lars)
- 10:32 PM Changeset in webkit [22643] by
-
- 2 edits in branches/WindowsMerge/WebCore
WebCoreWin:
Reviewed by Hyatt.
Use num-cpus to determine the number of jobs make should run
concurrently.
- WebCore.vcproj/build-generated-files.sh:
- 9:54 PM Changeset in webkit [18127] by
-
- 2 edits in trunk
Correct the path to the libraries for QMake.
- 9:44 PM Changeset in webkit [18126] by
-
- 7 edits in trunk
Cleanup the FrameQtClient mess a little bit.
- 9:33 PM Changeset in webkit [18125] by
-
- 2 edits in trunk/WebCore
Accomodate the file changes in the project files (aka build)
- 9:12 PM Changeset in webkit [18124] by
-
- 10 edits4 adds2 deletes in trunk/WebCore
Implement a decent network loader using QHttp (from Lars)
- 8:58 PM Changeset in webkit [18123] by
-
- 4 edits in trunk
Fix qmake build re: bison issues - unify with Linux build
- 8:36 PM Changeset in webkit [18122] by
-
- 2 edits in trunk/WebKitTools
Repair QMake build on OS X.
- 8:25 PM Changeset in webkit [18121] by
-
- 5 edits in trunk
Small fixes for qmake shadow builds
- 7:57 PM Changeset in webkit [18120] by
-
- 2 edits in trunk/WebKitTools
Remove reference to Unity. Reviewed by Zack.
- 7:27 PM Changeset in webkit [18119] by
-
- 3 edits in trunk
Simon says : work with qmake shadow builds. Patch adds support
for it to the build scripts.
- 7:07 PM Changeset in webkit [22642] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Hyatt.
Fix: <rdar://problem/4860184> Can't select context menu items with the
right mouse button
- platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show):
- 6:52 PM Changeset in webkit [18118] by
-
- 2 edits in trunk/WebCore
Crazy notion: make the font setting on widgets work.
- 6:36 PM Changeset in webkit [18117] by
-
- 2 edits in trunk/WebCore
Stop complaining about the nil renderer (granted the whole
scrollcanvas implementation makes the baby jesus cry)
- 6:32 PM Changeset in webkit [18116] by
-
- 3 edits in trunk/WebCore
Fix some rounding issues
- 6:01 PM Changeset in webkit [18115] by
-
- 8 edits in trunk/WebCore
Fix build for Qt 4.1 and less (for Qtopia mainly). By George.
- 4:58 PM Changeset in webkit [18114] by
-
- 6 edits6 adds1 delete in trunk
CMake is too slow to make it the default build for us. This
patch adds QMake build which works, way, way better. Mostly
done by Simon Hausmann.
- 4:44 PM Changeset in webkit [18113] by
-
- 2 adds in trunk/WebCore/platform/graphics/qt
This is part of r 18111 commit - Use the Qt image
loading framework.
- 4:41 PM Changeset in webkit [18112] by
-
- 4 edits in trunk/WebCore
Compile after latest WebKit changes and don't depend on
deprecated methods in Qt.
- 4:37 PM Changeset in webkit [18111] by
-
- 4 edits in trunk/WebCore
Use the Qt image loading framework instead of the Mozilla
loaders
- 4:21 PM Changeset in webkit [18110] by
-
- 2 edits in trunk/WebCore
Remove an explicit ICU dependency (by lars)
- 4:19 PM Changeset in webkit [18109] by
-
- 4 edits in trunk
Fixing the kde build after the icu Qt changes.
- 4:01 PM Changeset in webkit [22641] by
-
- 6 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Darin.
- WebCore.vcproj/WebCore.vcproj:
- Changed include paths to reflect the now-flattened JSCore headers.
- Added missing files to project.
- Changed post-build step to also copy ForwardingHeaders.
- Removed unnecessary definition of WTF_PLATFORM_CF from project file (it's already defined in config.h).
- platform/win/TextBoundariesWin.cpp: Fixed up includes and renamed function calls. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
WebKitWin:
Reviewed by Darin.
Build fix.
- WebKit.vcproj/WebKit.vcproj: Added WebCore/ForwardingHeaders to the include path.
- WebView.cpp: Updated to reflect the newly-flattend JSCore headers.
- 3:53 PM Changeset in webkit [18108] by
-
- 31 edits in trunk
Reviewed by Darin.
Some updates in reaction to r18098.
- wtf/unicode/icu/UnicodeIcu.h: Use !! to convert UBool to bool in all cases. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::isUpper):
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
WebCore:
Reviewed by Darin.
Changed all ForwardingHeaders to use #include instead of #import.
- ForwardingHeaders/kjs/JSLock.h:
- ForwardingHeaders/kjs/SavedBuiltins.h:
- ForwardingHeaders/kjs/collector.h:
- ForwardingHeaders/kjs/dtoa.h:
- ForwardingHeaders/kjs/internal.h:
- ForwardingHeaders/kjs/interpreter.h:
- ForwardingHeaders/kjs/lookup.h:
- ForwardingHeaders/kjs/object.h:
- ForwardingHeaders/kjs/property_map.h:
- ForwardingHeaders/kjs/protect.h:
- ForwardingHeaders/wtf/AlwaysInline.h:
- ForwardingHeaders/wtf/Assertions.h:
- ForwardingHeaders/wtf/FastMalloc.h:
- ForwardingHeaders/wtf/GetPtr.h:
- ForwardingHeaders/wtf/HashCountedSet.h:
- ForwardingHeaders/wtf/HashMap.h:
- ForwardingHeaders/wtf/HashSet.h:
- ForwardingHeaders/wtf/HashTraits.h:
- ForwardingHeaders/wtf/MathExtras.h:
- ForwardingHeaders/wtf/Noncopyable.h:
- ForwardingHeaders/wtf/OwnArrayPtr.h:
- ForwardingHeaders/wtf/OwnPtr.h:
- ForwardingHeaders/wtf/PassRefPtr.h:
- ForwardingHeaders/wtf/Platform.h:
- ForwardingHeaders/wtf/RefPtr.h:
- ForwardingHeaders/wtf/Vector.h:
- 2:40 PM Changeset in webkit [18107] by
-
- 2 edits in trunk/JavaScriptCore
Patch by Lars Knoll, comment out ICU dependency on Qt platform (unused code).
Reviewed by Darin.
- 9:22 AM Changeset in webkit [18106] by
-
- 12 edits2 adds in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11625
Investigate possibility to share code between HTMLStyleElement and SVGStyleElement
Add a class shared by both HTMLStyleElement and SVGStyleElement that
encapsulates the common logic.
- 9:09 AM SVG TODO List - Short notes edited by
- (diff)
- 9:07 AM SVG TODO List - Short notes created by
- 8:15 AM WikiStart edited by
- (diff)
- 8:09 AM WikiStart edited by
- (diff)
- 5:30 AM WikiStart edited by
- (diff)
- 12:52 AM Changeset in webkit [18105] by
-
- 2 adds1 delete in trunk/WebKit/ForwardingHeaders/wtf
Fix WebKit forwarding headers for mac.
- 12:35 AM Changeset in webkit [18104] by
-
- 2 adds1 delete in trunk/WebCore/ForwardingHeaders/wtf
Update forwarding headers in WebCore to reflect wtf/unicode/icu dir structure.
- 12:34 AM Changeset in webkit [18103] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
Fix mac bustage (more still).
- 12:33 AM Changeset in webkit [18102] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
Fix mac bustage (maybe).
- 12:32 AM Changeset in webkit [18101] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
Fix mac bustage (maybe).
- 12:29 AM Changeset in webkit [18100] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
Fix mac bustage (maybe).
Dec 8, 2006:
- 11:54 PM Changeset in webkit [18099] by
-
- 1 edit in trunk/JavaScriptCore/wtf/unicode/Unicode.h
Fix mac bustage.
- 9:54 PM Changeset in webkit [18098] by
-
- 42 edits13 adds5 deletes in trunk
Land the new ICU abstraction layer. Patch by Lars.
Reviewed by me
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Platform.h:
- wtf/unicode/UnicodeCategory.h: Removed.
- wtf/unicode/UnicodeDecomposition.h: Removed.
- wtf/unicode/UnicodeDirection.h: Removed.
- wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::direction): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset):
- wtf/unicode/qt4/UnicodeQt4.cpp: Removed.
- wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset): (WTF::Unicode::direction): (WTF::Unicode::category):
WebCore:
Land the new ICU abstraction layer (WTF::Unicode). Patch
by Lars with a couple of fixes thrown in by me.
Reviewed by hyatt
- ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
- ForwardingHeaders/wtf/unicode/Unicode.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- css/cssparser.cpp: (WebCore::ParseString::lower):
- dom/Document.cpp: (WebCore::isValidNameStart): (WebCore::isValidNamePart):
- editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::append):
- html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
- html/HTMLInputElement.cpp: (WebCore::numGraphemeClusters): (WebCore::numCharactersInGraphemeClusters):
- html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
- page/Frame.h:
- platform/DeprecatedString.h: (WebCore::DeprecatedChar::isSpace): (WebCore::DeprecatedChar::lower): (WebCore::DeprecatedChar::upper):
- platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks):
- platform/FontCache.h:
- platform/FontData.h:
- platform/GlyphMap.cpp:
- platform/GlyphMap.h:
- platform/GlyphWidthMap.h:
- platform/KURL.cpp: (WebCore::encodeHostname):
- platform/StringHash.h: (WTF::):
- platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::capitalize): (WebCore::StringImpl::toInt): (WebCore::equalIgnoringCase): (WebCore::StringImpl::find):
- platform/StringImpl.h:
- platform/TextBoundaries.h:
- platform/TextBreakIterator.h: Added. (WebCore::):
- platform/TextBreakIteratorICU.cpp: Added. (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
- platform/TextCodec.h:
- platform/TextCodecLatin1.cpp:
- platform/TextEncoding.cpp: (WebCore::TextEncoding::encode):
- platform/TextEncoding.h:
- platform/TextEncodingRegistry.cpp: (WebCore::buildTextEncodingNameMap): (WebCore::buildTextCodecMap):
- platform/TextEncodingRegistry.h:
- platform/UChar.h: Removed.
- platform/graphics/GraphicsContext.h:
- platform/qt/GlyphMapQt.cpp:
- platform/qt/TextBreakIteratorQt.cpp: Added. (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
- platform/qt/TextCodecQt.cpp: Added. (WebCore::getAtomicName): (WebCore::TextCodecQt::registerEncodingNames): (WebCore::newTextCodecQt): (WebCore::TextCodecQt::registerCodecs): (WebCore::TextCodecQt::TextCodecQt): (WebCore::TextCodecQt::~TextCodecQt): (WebCore::TextCodecQt::decode): (WebCore::TextCodecQt::encode):
- platform/qt/TextCodecQt.h: Added.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderText.cpp: (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): (WebCore::RenderText::widthFromCache):
- rendering/RenderText.h:
- rendering/bidi.cpp: (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::direction): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
- rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiContext::dir): (WebCore::BidiContext::basicDir): (WebCore::BidiRun::BidiRun):
- rendering/break_lines.h:
WebKit:
Land new ICU abstraction layer. Patch by Lars.
Reviewed by me
- ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
- ForwardingHeaders/wtf/unicode/Unicode.h: Added.
- WebKit.xcodeproj/project.pbxproj:
- 8:10 PM Changeset in webkit [18097] by
-
- 6 edits in trunk/WebCore
Rolling out r17865 because it caused a performance regression.
- loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding):
- platform/CString.cpp: (WebCore::CString::data):
- platform/CString.h:
- platform/TextStream.cpp: (WebCore::TextStream::operator<<):
- platform/TextStream.h:
- 6:44 PM Changeset in webkit [22640] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Adam.
- createWebViewWithRequest now increases the ref count for the new window it returns. This is standard practice for COM, and fixes a crash.
- WebFrame.cpp: (WebFrame::openURL):
- 5:27 PM Changeset in webkit [18096] by
-
- 34 edits4 adds in trunk
Reviewed by Maciej.
Patch fixes compile of all Qt/KDE code after
the recent API changes.
- 5:25 PM Changeset in webkit [18095] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove stray conflict marker
- 5:13 PM Changeset in webkit [18094] by
-
- 9 copies in tags/Safari-521.32
New tag.
- 5:07 PM Changeset in webkit [18093] by
-
- 7 edits in /
Versioning
- 4:38 PM Changeset in webkit [18092] by
-
- 2 edits in trunk/WebKit
Rolling out a change that broke Mail stationary.
<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load
- WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]):
- 4:31 PM Changeset in webkit [18091] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Maciej.
Build Qt webkit on non-linux, and prefer it if $QTDIR is set
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 4:11 PM Changeset in webkit [22639] by
-
- 2 edits in branches/WindowsMerge/WebCore
Rubberstamped by Anders.
- platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Fix use of min().
- 3:40 PM Changeset in webkit [18090] by
-
- 3 edits2 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=10188
Form elements added via appendChild() are not accessible via form.element
Make sure looking up form elements works when the form is not appended
to the document.
- 2:44 PM Changeset in webkit [18089] by
-
- 3 edits2 adds in trunk
Reviewed by Adele.
http://bugs.webkit.org/show_bug.cgi?id=11765
REGRESSION: Clicking on a select with size other than 1 and no children results in a crash
Make sure returned value is -1 for selects without children.
- 2:37 PM Changeset in webkit [22638] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- 2:34 PM Changeset in webkit [18088] by
-
- 2 edits in trunk
Fixed typo.
- 2:34 PM Changeset in webkit [18087] by
-
- 5 edits in trunk
Reviewed by Anders.
This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.
- kjs/config.h:
- wtf/Vector.h:
WebCore:
Reviewed by Anders.
This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.
- config.h:
- 1:21 PM Changeset in webkit [18086] by
-
- 11 edits in trunk
2006-12-08 Don Gibson <dgibson77@gmail.com>
Reviewed and landed by Alexey.
http://bugs.webkit.org/show_bug.cgi?id=11759:
Windows build bustage
WebCore:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/ContextMenuClientWin.h:
- bridge/win/FrameWin.h:
- loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
- platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::fileButtonChooseFileLabel): (WebCore::inputElementAltText): (WebCore::copyCursor): (WebCore::resetButtonDefaultLabel): (WebCore::ContextMenuClientWin::contextMenuItemSelected): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::FrameLoader::load): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::respondToChangedSelection):
WebKit:
- COM/WebFrame.cpp: (WebFrame::loadDataSource):
- COM/WebFrame.h:
- 1:12 PM Changeset in webkit [18085] by
-
- 6 edits4 adds in trunk
LayoutTests:
Reviewed by Geoff.
Testcases for http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.
- fast/dom/XMLSerializer-doctype-expected.txt: Added.
- fast/dom/XMLSerializer-doctype.html: Added.
- fast/dom/XMLSerializer-doctype2-expected.txt: Added.
- fast/dom/XMLSerializer-doctype2.html: Added.
WebCore:
Reviewed by Geoff.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.
Test: fast/dom/XMLSerializer-doctype.html
Test: fast/dom/XMLSerializer-doctype2.html
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): set the document of the DocumentType node to the new document.
- xml/XMLSerializer.cpp: Cleanup. (WebCore::XMLSerializer::serializeToString): now throws an exception for documentless nodes.
- xml/XMLSerializer.h: cleanup
- xml/XMLSerializer.idl: add exception
- 11:29 AM Changeset in webkit [18084] by
-
- 4 edits8 adds in trunk
LayoutTests:
Reviewed by john
<rdar://problem/4836287>
Cannot expand selection out of editable element when containing element is non-editable.
- editing/selection/mixed-editability-6-expected.checksum: Added.
- editing/selection/mixed-editability-6-expected.png: Added.
- editing/selection/mixed-editability-6-expected.txt: Added.
- editing/selection/mixed-editability-6.html: Added.
- editing/selection/mixed-editability-7-expected.checksum: Added.
- editing/selection/mixed-editability-7-expected.png: Added.
- editing/selection/mixed-editability-7-expected.txt: Added.
- editing/selection/mixed-editability-7.html: Added.
WebCore:
Reviewed by john
<rdar://problem/4836287>
Cannot expand selection out of editable element when containing element is non-editable.
- editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Restrict the selection endpoints to the same *highest* editable root. This bug only happened when creating selections based in an editable region and extending into a higher editable root, so this change doesn't expose any new kinds of deletions, but we should start thinking about how those deletions should behave.
- editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Ditto.
- 10:53 AM Changeset in webkit [18083] by
-
- 2 edits in trunk/WebKit
Reviewed by Brady.
<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3
- WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Add nil check.
- 10:46 AM Changeset in webkit [22637] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Maciej.
Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>. Not doing
this breaks sub-menus on Boomer since the menu items are no longer
static.
- platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):
- 10:42 AM Changeset in webkit [18082] by
-
- 1 edit in trunk/WebCore/ChangeLog
Typo! Thanks Mitz!
- 10:37 AM Changeset in webkit [18081] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>
- platform/ContextMenu.cpp: Because of the OwnPtr in ContextMenuItem, we have to separate the declaration of ContextMenuItems away from the calls to appendItem(). Not doing so causes a build failure because OwnPtr inherits from Noncopyable. (WebCore::createFontSubMenu): Same. (WebCore::createSpellingAndGrammarSubMenu): Same. (WebCore::createSpellingSubMenu): Same. (WebCore::createSpeechSubMenu): Same. (WebCore::createWritingDirectionSubMenu): Same. (WebCore::ContextMenu::populate): Same.
- platform/ContextMenuItem.h: New member variable m_subMenu.
- platform/mac/ContextMenuItemMac.mm: Take care of setting m_subMenu in addition to setting the submenu of the NSMenuItem when we have a sub-menu. (WebCore::menuToArray): (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setSubMenu): Same.
- 10:35 AM Changeset in webkit [18080] by
-
- 2 edits in trunk/WebCore
2006-12-08 MorganL <morganl.webkit@yahoo.com>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11778
CString::data() should be documented as returning a null terminated char array
- platform/CString.h: Add some basic documentation to CString.h
- 10:31 AM Changeset in webkit [18079] by
-
- 2 edits1 add in trunk/WebCore
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=11718
REGRESSION: When I mouse up after dragging a selection outside of a iframe, the iframe
continues to scroll automatically.
Test: manual-tests/autoscroll.html
- manual-tests/autoscroll.html: Added.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Assign to m_mousePressNode earlier, so that it is available in the superframe as well. Reset m_mouseDownWasInSubframe to false when starting to handle a mousedown - previously, its value was only defined if the event was passed down to a widget or a subframe.
(WebCore::EventHandler::stopAutoscrollTimer):
If the mouse down event was in a subframe, stop the subframe's timer.
- 10:25 AM Changeset in webkit [18078] by
-
- 9 edits in trunk
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=6275
XMLHttpRequest.getResponseHeader should return a null string for non-existent headers
WebCore:
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Convert null getResponseHeader strings to JS null, rather than undefined.
LayoutTests:
- http/tests/xmlhttprequest/methods-async-expected.txt:
- http/tests/xmlhttprequest/methods-expected.txt:
- http/tests/xmlhttprequest/methods-lower-case-expected.txt: Updated the results.
- http/tests/xmlhttprequest/web-apps/008-expected.txt:
- http/tests/xmlhttprequest/web-apps/008-test.asis:
- http/tests/xmlhttprequest/web-apps/008.html: Changed to test both missing and empty headers, also test case insensitivity of header names. Please note that neither Firefox nor IE passes this test now - the former returns null in both cases, and the latter returns empty strings.
- 10:19 AM Changeset in webkit [18077] by
-
- 5 edits7 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=9854
HTTP Refresh header with quotes is parsed incorrectly
Test: http/tests/misc/redirect-with-quotes.php
- WebCore.xcodeproj/project.pbxproj: Added HTTPParsers.{h,cpp}. I intend to move Content-Type parsing here, as well.
- dom/Document.cpp: (WebCore::Document::processHttpEquiv):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Use the new implementation in HTTPHeaders.
- platform/network/HTTPParsers.cpp: Added. (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
- platform/network/HTTPParsers.h: Added. Merged and rewrote existing implementations for better Firefox compatibility.
- 10:03 AM Changeset in webkit [18076] by
-
- 3 edits2 adds in trunk
Reviewed by Tim H.
http://bugs.webkit.org/show_bug.cgi?id=11772
REGRESSION: XMLSerializer.serializeToString incorrect value for CDATA nodes
Test: fast/dom/serialize-cdata.html
- editing/markup.cpp: (WebCore::startMarkup): Dump CDATA sections, too.
- 3:02 AM Changeset in webkit [18075] by
-
- 2 edits in trunk/WebCore
Reviewed by hyatt.
Deleted misplaced comment.
- 12:02 AM Changeset in webkit [18074] by
-
- 11 edits4 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=6074
WebKit+SVG and FireFox disagree on invalid "transform" handling
Test for parsing failure on transform attribute and clear the transform
list upon failure to match FF behaviour.