⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 12, 2006:

11:02 PM Changeset in webkit [22659] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

B&I build fix

  • WebCore.vcproj/build-generated-files.sh:
6:48 PM Changeset in webkit [22658] by aliceli1
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

Fixed <rdar://problem/4853199> extra whitespace at beginning and end of pasted fragment into contenteditable region


  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):
6:41 PM Changeset in webkit [22657] by aroben
  • 5 edits in branches/WindowsMerge/WebCore
6:34 PM Changeset in webkit [18195] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Changed #import to #include to match the rest of our ForwardingHeaders.

  • ForwardingHeaders/wtf/StringExtras.h:
5:46 PM Changeset in webkit [18194] by zbujtas
  • 4 edits in S60/trunk/WebCore

2006-12-11 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage
​http://bugs.webkit.org/show_bug.cgi?id=11769

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):
5:41 PM Changeset in webkit [18193] by zbujtas
  • 4 edits in S60/branches/3.1m/WebCore

2006-12-12 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage
​http://bugs.webkit.org/show_bug.cgi?id=11769

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):
5:23 PM Changeset in webkit [22656] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:16 PM Changeset in webkit [18192] by sfalken
  • 1 copy in tags/Safari-521.32.0b

New tag.

4:48 PM Changeset in webkit [18191] by justing
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4757667>
GoogleDocs: Style menu does not open


  • editing/selection/rangeCount-expected.txt: Added.
  • editing/selection/rangeCount.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4757667>
GoogleDocs: Style menu does not open

  • bindings/js/kjs_window.cpp: (KJS::Selection::getValueProperty): Added rangeCount.
  • bindings/js/kjs_window.h: (KJS::Selection::):
  • editing/SelectionController.h: (WebCore::SelectionController::rangeCount): Added.
3:58 PM Changeset in webkit [18190] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • bindings/js/JSSVGMatrixCustom.cpp: added #ifdef SVG_SUPPORT
3:45 PM Changeset in webkit [18189] by andersca
  • 2 edits in trunk/WebCore

Suggested by Darin.

  • loader/ResourceLoader.cpp: Move down include of ResourceHandle.h.
3:30 PM Changeset in webkit [18188] by ggaren
  • 2 edits in trunk/WebCore/page

Fixing up svn properties on FocusController.*

2:19 PM Changeset in webkit [22655] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

Added FocusController to project.

  • WebCore.vcproj/WebCore.vcproj:
2:11 PM Changeset in webkit [18187] by ggaren
  • 7 edits
    2 adds in trunk/WebCore

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.


Factored focus control into a FocusController class. I inted to use this
class for handling window active state and the focused frame, as well.

Layout tests pass.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::view): (WebCore::Document::page): New helper function.
  • dom/Document.h: Moved setters before getters. (WebCore::Document::hoverNode): (WebCore::Document::activeNode):
  • dom/Node.cpp: (WebCore::Node::detach): Use the FocusController.
  • page/FocusController.cpp: Added. (WebCore::shouldFocus): renamed and refactored this helper function. (WebCore::shouldUnfocus): ditto.
  • page/FocusController.h: Added.
2:03 PM Changeset in webkit [18186] by andersca
  • 3 edits in trunk/WebCore

Rubber Stamped by Geoff.

  • platform/Base64.cpp:
  • platform/Base64.h: Put functions inside of the WebCore namespace.
1:50 PM Changeset in webkit [22654] by andersca
  • 6 edits in branches/WindowsMerge

WebCoreWin:

  • loader/win/ResourceLoaderWin.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadsBlocked): Update for changes to ResourceHandle.

WebKitWin:

  • WebFrame.cpp: (WebFrame::loadDataSource): Update for changes to ResourceHandle.
1:42 PM Changeset in webkit [18185] by andersca
  • 4 edits in trunk/WebCore

Try fixing the non-Mac builds.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
1:14 PM Changeset in webkit [18184] by andersca
  • 18 edits in trunk

WebCore:

Reviewed by Darin.

Turn ResourceLoader into a ResourceHandleClient and stop using NSURLConnection in the loader.

  • WebCore.exp: Add new methods needed by WebKit.


  • WebCore.xcodeproj/project.pbxproj: Make ResourceHandle.h a private header.


  • loader/FrameLoaderClient.h: Change the download method to take a ResourceHandle instead of an NSURLConnection.


  • loader/MainResourceLoader.h: Get rid of the proxy instance variable, that's handled by ResourceHandlw now.


  • loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::willCacheResponse): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation): (WebCore::ResourceLoader::handle):
  • loader/SubresourceLoader.h: Make ResourceLoader a ResourceHandleClient, moving the methods from SubresourceLoader.


  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): Use a ResourceHandle instead of an NSURLConnection.


  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail): Remove the WebCoreResourceLoaderAsDelegate class, use a ResourceHandle instead of an NSURLConnection.


  • loader/mac/SubresourceLoaderMac.mm: Remove ResourceHandleClient methods.


  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add an extra argument denoting whether this ResourceHandle can possibly be "converted" into one used for downloads.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseProxy): (WebCore::ResourceHandle::connection): New methods for creating a NSURLConnectionDelegateProxy which is used when creating a NSURLDownload from an existing connection.

WebKit:

Reviewed by Darin.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Get the handle and proxy from the ResourceHandle now that they aren't passed to us.
12:13 PM Changeset in webkit [18183] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-12-12 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):
12:09 PM Changeset in webkit [18182] by ap
  • 7 edits in trunk

Reviewed by Geoff. Based on a patch by Maks Orlovich.

​http://bugs.webkit.org/show_bug.cgi?id=6257
Throw errors on invalid expressions (KJS merge)

JavaScriptCore:

  • kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
  • kjs/regexp.h: (KJS::RegExp::flags): (KJS::RegExp::isValid): (KJS::RegExp::errorMessage): (KJS::RegExp::subPatterns): Remember and report RegExp construction failures. Renamed data members not to start with underscores.
  • kjs/regexp_object.cpp: (RegExpObjectImp::construct): Raise an exception if RegExp construction fails. (RegExpObjectImp::callAsFunction): Removed an obsolete comment.
  • tests/mozilla/ecma_3/RegExp/regress-119909.js: Reduced the number of nested parentheses to a value supported by PCRE.

LayoutTests:

  • fast/js/kde/RegExp-expected.txt: One more test passes.
11:50 AM SVG TODO List - Short notes edited by ojh16@student.canterbury.ac.nz
text+filter stuff (diff)
11:42 AM Changeset in webkit [18181] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::load):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Move the didTellBridgeAboutLoad call to SubresourceLoader in preparation for getting rid of the DocLoader parameter to ResourceHandle::create.
11:41 AM Changeset in webkit [22653] by darin
  • 2 edits in branches/WindowsMerge/WebCore
  • fix build
  • WebCore.vcproj/WebCore.vcproj: Added missing files, removed obsolete files.
11:32 AM Changeset in webkit [18180] by ggaren
  • 1 edit in trunk/LayoutTests/editing/undo/undo-iframe-location-change-expected.txt

Oops. Forgot to check in this file.

9:52 AM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
9:01 AM Changeset in webkit [18179] by spadma
  • 5 edits in S60/branches/3.1m/WebKit

2006-12-11 sareen <​shyam.sareen@nokia.com>

Reviewed Sachin Padma.
DESC: Saved Pages: Some Images not saved with the page.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11721

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):
4:09 AM Changeset in webkit [18178] by staikos
  • 3 edits in trunk/WebCore

Make the last checkin compile

3:19 AM Changeset in webkit [18177] by zimmermann
  • 55 edits
    1 add
    2 deletes in trunk

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11797

Remove SVGMatrix, replace it by AffineTransform usage everywhere.
Changed AffineTransform API to be able to be used within generation
(m11() -> a(), m12() -> b(), ...). Add some methods needed for SVG.

1:55 AM Changeset in webkit [18176] by staikos
  • 9 edits in trunk

Fix the Qt build

1:02 AM Changeset in webkit [18175] by ggaren
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Added some focus-related tests.

  • editing/undo/undo-iframe-location-change-expected.txt: Updated to reflect the fact that we now unfocus nodes when they're removed from the document.
  • fast/events/keypress-removed-node-expected.txt: Added.
  • fast/events/keypress-removed-node.html: Added.
  • fast/forms/focus2-expected.txt: Added.
  • fast/forms/focus2.html: Added.

WebCore:

Reviewed by Beth Dakin.


Moved focus control to the page level. Fixed a minor bug where a node
would retain keyboard focus even when removed from the document.


We should probably move this, along with hover and active, into a separate
FocusController. But I'm too tired right now.

  • dom/Document.cpp: Migrated code to Page (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::setFocusedNode): (WebCore::Document::focusedNode):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::detach): Clear ourselves from keyboard focus. This fixes the minor bug and was also necessary to prevent regressions caused by hanging on to a focused node after the document was replaced.
  • dom/Node.h: (WebCore::Node::inDetach):
  • page/Page.cpp: Migrated code from Document (WebCore::shouldAcquireEditingFocus): (WebCore::shouldRelinquishEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::widgetForNode): (WebCore::Page::setFocusedNode):
  • page/Page.h: (WebCore::Page::focusedNode):
12:45 AM Changeset in webkit [18174] by ggaren
  • 1 edit in trunk/WebCore/platform/Base64.cpp

build fix

12:28 AM Changeset in webkit [18173] by ap
  • 2 edits in trunk/LayoutTests

Added the new XHR EventTarget methods to test results.

  • fast/dom/Window/window-properties-expected.txt:

Dec 11, 2006:

11:59 PM Changeset in webkit [18172] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11053
XMLHttpRequest should be an EventTarget

Test: http/tests/xmlhttprequest/event-target.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::mark): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
  • bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener):
  • xml/xmlhttprequest.h: (WebCore::XMLHttpRequest::eventListeners): Implement EventTarget methods (except for NS variations, which Firefox doesn't have either).
11:28 PM Changeset in webkit [22652] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added missing files to project.
11:13 PM Changeset in webkit [22651] by sfalken
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

B&I build fix

11:13 PM Changeset in webkit [18171] by darin
  • 5 edits in trunk/WebCore

Reviewed by Geoff.

DocumentType objects were getting filed under the wrong document in the
DOM objects structure.

  • bindings/js/kjs_binding.h: Added a destructor for debugging purposes only.
  • bindings/js/kjs_binding.cpp: (KJS::wrapperSet): Added. Set of outstanding wrappers for debugging. (KJS::addWrapper): Added. (KJS::removeWrapper): Added. (KJS::removeWrappers): Added. (KJS::DOMObject::~DOMObject): Added. Asserts that there is no outstanding reference to this wrapper since it's being destroyed. (KJS::ScriptInterpreter::putDOMObject): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetDOMObject): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::putDOMNodeForDocument): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Added a call to REMOVE_WRAPPERS. (KJS::ScriptInterpreter::updateDOMNodeDocument): Added calls to REMOVE_WRAPPER and ADD_WRAPPER so the out-of-order transaction doesn't upset the assertions in the functions we're calling. Another solution would be to reorder the two, but I think that would create a race where another thread could garbage collect after the forget but before the put. (KJS::ScriptInterpreter::wasRunByUserGesture): Tweaked formatting.
  • dom/Document.cpp: (WebCore::Document::adoptNode): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
  • dom/Node.cpp: (WebCore::Node::setDocument): Added call to updateDOMNodeDocument here. (WebCore::Node::checkAddChild): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
10:47 PM Changeset in webkit [18170] by ap
  • 10 edits
    9 adds in trunk

​http://bugs.webkit.org/show_bug.cgi?id=9673
Add support for window.atob() and window.btoa()

Reviewed by Darin.

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Added Base64.{h,cpp}
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • platform/Base64.cpp: Added. (base64Encode): (base64Decode):
  • platform/Base64.h: Added.
  • ForwardingHeaders/wtf/StringExtras.h: Added.
  • platform/DeprecatedString.cpp: Use strncasecmp from StringExtras.

LayoutTests:

  • fast/dom/Window/atob-btoa-expected.txt: Added.
  • fast/dom/Window/atob-btoa.html: Added.
  • fast/dom/Window/btoa-pnglet-expected.checksum: Added.
  • fast/dom/Window/btoa-pnglet-expected.png: Added.
  • fast/dom/Window/btoa-pnglet-expected.txt: Added.
  • fast/dom/Window/btoa-pnglet.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
10:34 PM Changeset in webkit [22650] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-11 Steve Falkenburg <​sfalken@apple.com>

B&I build fix.
Remove platform/UChar.h from our vcproj, since it doesn't exist anymore.

  • WebCore.vcproj/WebCore.vcproj:
9:56 PM Changeset in webkit [18169] by darin
  • 8 edits
    10 moves in trunk

WebCore:

Reviewed by Brady.

  • did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
  • WebCore.xcodeproj/project.pbxproj: Updated project for file moves.
  • bridge/mac/FrameMac.h: Moved to page/mac.
  • bridge/mac/FrameMac.mm: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: Ditto.
  • bridge/mac/WebCoreFrameView.h: Ditto.
  • bridge/mac/WebCoreViewFactory.h: Ditto.
  • bridge/mac/WebCoreViewFactory.m: Ditto.
  • bridge/mac/WebDashboardRegion.h: Ditto.
  • bridge/mac/WebDashboardRegion.m: Ditto.
  • bridge/mac/WebCoreKeyboardAccess.h: Moved to page/mac, renamed WebCoreKeyboardUIMode.h, and made a C++ header.
  • page/EventHandler.h: Updated for change to WebCoreKeyboardAccess.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): Ditto. (WebCore::EventHandler::tabsToAllControls): Ditto. (WebCore::EventHandler::keyboardUIMode): Ditto.

WebKit:

Reviewed by Brady.

  • did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
  • WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto. (-[WebFrameBridge keyboardUIMode]): Ditto.
9:47 PM Changeset in webkit [18168] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady.

  • JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode update this (I think Hyatt is using an old Xcode).
9:03 PM Changeset in webkit [18167] by darin
  • 2 edits in trunk/LayoutTests
  • fast/frames/iframe-option-crash-expected.txt: Updated results for this test. My recent change to owner element lifetime management changed these results, but since the point of the test is simply to check if the page crashes, the new result is probably OK. Or there could be some problem, but if so we need some other investigation -- I couldn't see anything.
8:44 PM Changeset in webkit [22649] by bdakin
  • 6 edits in branches/WindowsMerge/WebKitWin

Boomer WebKit support for editing sub-menu actions for WebCore
context menus.

  • Interfaces/IWebUIDelegate.idl: Re-named some of the spelling sub-menu tags.
  • WebContextMenuClient.cpp: New functions for the speech sub-menu. (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebContextMenuClient.h:
  • WebEditorClient.cpp: New functions to toggle spelling/grammar checking. (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
  • WebEditorClient.h
8:27 PM Changeset in webkit [18166] by bdakin
  • 16 edits in trunk

WebCore:

Reviewed by Adam.

Primarily, this patch implements/hooks-up actions for the sub-menu
items in WebCore context menus. I fixed a few other things along
the way too:

-Made BUILDING_ON_TIGER ifdef work within C++ as well as

Obj-C

-Fixed bug where we would throw and Obj-C exception and

fail to pop up menus with more than one separator item.

-Re-named some of the spelling/grammar tags since Tiger and

Leopard share more of the actions than initially
anticipated.

  • WebCorePrefix.h: Make BUILDING_ON_TIGER available to C++
  • bridge/EditorClient.h: New functions to toggle spelling/grammar checking.
  • editing/Editor.cpp: (WebCore::Editor::toggleContinuousSpellChecking): Call into client. (WebCore::Editor::toggleGrammarChecking): Same. (WebCore::Editor::toggleBold): call execToggleBold() (WebCore::Editor::toggleUnderline): Create appropriate underline style and apply to selection. (WebCore::Editor::setBaseWritingDirection): Create appropriate writing direction and apply to selection.
  • editing/Editor.h:
  • editing/mac/EditorMac.mm: New functions to show spelling guesses, fonts, styles, and color panels.
  • page/ContextMenuClient.h: New functions for the speech sub-menu.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Fill in editing sub-menu actions.
  • platform/ContextMenu.cpp: (WebCore::separatorItem): Helper function to create a separator item. (WebCore::createFontSubMenu): Put very mac-specific things within a platform ifdef. (WebCore::createSpellingAndGrammarSubMenu): Re-named some of the spelling sub-menu tags. (WebCore::createSpellingSubMenu): Same. (WebCore::ContextMenu::populate): We can't share the separator item. When we do, menus with more than one separator throw and obj- c exception and fail to pop-up.
  • platform/ContextMenuItem.h: (WebCore::): Re-named some of the spelling sub-menu tags.

WebKit:

Reviewed by Adam.

WebKit support for editing sub-menu actions.

  • WebCoreSupport/WebContextMenuClient.h: New functions for the speech sub-menu.
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebCoreSupport/WebEditorClient.h: New functions to toggle spelling/grammar checking.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
  • WebView/WebUIDelegatePrivate.h: Re-named some of the spelling sub-menu tags.
8:20 PM S60CheckoutAndBuild edited by thisisbradley@gmail.com
s60webkit path changes (diff)
7:26 PM Changeset in webkit [22648] by aliceli1
  • 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work
And some cleanup of PlatformMouseEvent(Win)

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::handleDrag): Removed unnecessary check for mouse event type


  • platform/win/PasteboardWin.cpp:


(WebCore::PasteboardOwnerWndProc):
(WebCore::createGlobalData):
Added more overloaded implemtations and renamed from createHandle


(WebCore::markupToCF_HTML):
Changed to handle less-specific input and renamed from createCF_HTML


(WebCore::urlToMarkup):
(WebCore::Pasteboard::writeURL):
Added these.


(WebCore::replaceNBSP):
Moved out of Pasteboard class


(WebCore::Pasteboard::clear):
Renamed from clearTypes.


(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
Trivial cleanup of these.


  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Removed anything having to do with unnecessary m_type

WebKitWin:

Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work

  • Interfaces/IWebView.idl: Added copyURL.


  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h: Removed copyLinkToClipboard


  • WebView.cpp: (WebView::copy): (WebView::cut): (WebView::paste): Trivial cleanup of these


(WebView::copyURL):
Added this.


  • WebView.h: Added copyURL.
7:17 PM Changeset in webkit [18165] by aliceli1
  • 16 edits in trunk

WebCore:

Reviewed by Geoff, Adam.

Switch to use the Editor for copying URLs. Also some Pasteboard and PlatformMouseEvent cleanup.

All layout tests pass as they would without this patch.

  • WebCore.exp: added Editor::copyURL to be called from WebKit


  • editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): Pasteboard::clearTypes() changed to clear()

(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
Changed signature of writeSelection to take raw pointer instead of PassRefPtr

(WebCore::Editor::copyURL):

  • editing/Editor.h: Added copyURL.


  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Removed copyLinkToClipboard


  • platform/KURL.cpp: (WebCore::KURL::lastPathComponent):
  • platform/KURL.h: Added lastPathComponent.


  • platform/Pasteboard.h: Changed some function names. Moved some functions out of class to static.


  • platform/PlatformMouseEvent.h: (WebCore::): Removed MouseEventType enum, added NoButton to MouseButton without disturbing other button values.


  • platform/mac/PasteboardMac.mm: Added writeURL, and moved some things around


  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Add some calls necessary for Pasteboard::writeURL to work

WebKit:

Reviewed by Geoff, Adam.


switch to use the Editor for copying URLs

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyLinkToClipboard:]): Call down to the editor for this.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Add some calls necessary for Pasteboard::writeURL to work
5:26 PM Changeset in webkit [18164] by zimmermann
  • 50 edits in trunk/LayoutTests

Update SVG pixel tests - hasn't been done for a long time.
Mainly tiny text related positioning changes, all fine.

3:50 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
3:47 PM Changeset in webkit [22647] by darin
  • 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady.

  • WebCore.vcproj/WebCore.vcproj: Update for added files.
  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::createFrame): Changed to use HTMLFrameOwnerElement.
  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load): Changed to use HTMLFormElement.

WebKitWin:

Reviewed by Brady.

  • WebFrame.h:
  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Changed to use HTMLFrameOwnerElement. (WebFrame::createFrame): Ditto.
3:40 PM Changeset in webkit [18163] by darin
  • 43 edits
    2 adds in trunk

WebCore:

Reviewed by Brady.

  • CMakeLists.txt:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Updated for new source files.
  • WebCore.exp: Updated for changes to entry point names.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): Updated owner element type to HTMLFrameOwnerElement.
  • bridge/mac/WebCoreFrameBridge.h: Removed non-C++ case since we don't use that any more. Updated owner element type to HTMLFrameOwnerElement.
  • dom/Document.cpp: Added include so that the ownerElement function can compile (since it downcasts an HTMLFrameOwnerElement to an Element).
  • html/HTMLFrameElement.cpp: (WebCore::containingFrameSetElement): Moved this function in here; it doesn't need to be a member function. (WebCore::HTMLFrameElement::attach): Updated to call this.
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Inherit from HTMLFrameOwnerElement. Removed contentFrame, contentDocument, and containingFrameSetElement. Removed friend classes.
  • html/HTMLFrameOwnerElement.h: Added.
  • html/HTMLFrameOwnerElement.cpp: Added.
  • html/HTMLEmbedElement.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLObjectElement.cpp: Remove now-unneeded contentDocument functions.
  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Inherit from HTMLFrameOwnerElement.
  • loader/FormState.h:
  • loader/FormState.cpp: Use HTMLFormElement instead of just Element.
  • loader/FrameLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use HTMLFormElement. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::requestObject): Don't pass an element parameter to shouldUsePlugin, and remove now-unneeded type casts. (WebCore::FrameLoader::shouldUsePlugin): Removed unneeded element parameter. (WebCore::FrameLoader::handleFallbackContent): Use HTMLFrameOwnerElement. (WebCore::FrameLoader::updateBaseURLForEmptyDocument): Ditto. (WebCore::FrameLoader::isHostedByObjectElement): Ditto.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Use HTMLFormElement. (WebCore::FrameLoader::post): Ditto. (WebCore::FrameLoader::createFrame): Use HTMLFrameOwnerElement.
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/Frame.cpp: (WebCore::parentFromOwnerElement): Use HTMLFrameOwnerElement. (WebCore::Frame::Frame): Ditto. Also set m_contentFrame on the owner element. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::ownerRenderer): Ditto. (WebCore::Frame::disconnectOwnerElement): Clear m_contentFrame on the owner element before disconnecting it. (WebCore::FramePrivate::FramePrivate): Use HTMLFrameOwnerElement.
  • page/mac/EventHandlerMac.mm: Include HTMLFrameOwnerElement.h so that the code here will compile (no code changes needed).
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
  • rendering/RenderPart.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Use HTMLFrameOwnerElement.
  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Use HTMLFrameOwnerElement. (WebCore::RenderPartObject::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
  • other changes
  • platform/network/ResourceHandleInternal.h: Added Noncopyable and fixed indentation.

WebKit:

Reviewed by Brady.

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:WebCore::frameName:frameView:ownerElement:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:frameView:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Use HTMLFrameOwnerElement.
  • WebCoreSupport/WebFrameLoaderClient.mm: Include the relevant headers for the HTMLFormElement class.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode have its way.
  • WebView/WebFrame.mm: (-[WebFrame frameElement]): Update includes and types for the change in return type of ownerElement.
3:11 PM Changeset in webkit [18162] by hyatt
  • 2 edits in trunk/WebCore

Fix failing layout test. Remove WTF::Unicode::isSpace and just revert
the caller to the old behavior.

Reviewed by darin

  • platform/StringImpl.cpp: (WebCore::isSpace):
3:10 PM Changeset in webkit [18161] by hyatt
  • 3 edits in trunk/JavaScriptCore

Fix the failing layout test. Just remove Unicode::isSpace and
revert StringImpl to do the same thing it was doing before.

Reviewed by darin

  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
3:00 PM Changeset in webkit [22646] by lamadio
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-12-08 Lou Amadio <​lamadio@apple.com>

Reviewed by aroben,adachan
Implement Status Bar
<rdar://4601297> Status Bar feature
<rdar://4854036> subsequent windows have glass borders on vista
<rdar://4861165> Window cascade is off
<rdar://4804690> Window widgets clip highligh

2:51 PM Changeset in webkit [22645] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/page/win/EventHandlerWin.cpp

Fix build bustage.

2:06 PM Changeset in webkit [18160] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-11 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: remove the dependency on CAknSettingsCache
​http://bugs.webkit.org/show_bug.cgi?id=11806

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
1:54 PM Changeset in webkit [18159] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-11 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: add flag to remove the SDK dependency on AknSettingsCache
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11806

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
12:49 PM Changeset in webkit [22644] by bdakin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Build fix from Nick Zimmerman's last check-in.

  • WebCore.vcproj/WebCore.vcproj:
12:13 PM Changeset in webkit [18158] by ap
  • 4 edits in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=11807
Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::autoscrollTimerFired):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::mouseMoved): Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

(WebCore::EventHandler::lastEventIsMouseUp):
Check that the "new" event is newer than the "old" one - that's not always the case
when running in DRT, as [NSApp currentEvent] isn't updated by eventSender.

12:13 PM Changeset in webkit [18157] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-11 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11806

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
11:47 AM Changeset in webkit [18156] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-11 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus
​http://bugs.webkit.org/show_bug.cgi?id=11806

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
10:52 AM Changeset in webkit [18155] by zimmermann
  • 9 deletes in trunk/WebCore/bindings

I forgot to remove these in the previous commit, they were only emptied out.

10:03 AM Changeset in webkit [18154] by harrison
  • 3 edits in trunk/WebKit

Fix previous checkin where I committed the wrong file.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

  • WebView/WebFrame.mm: (-[WebFrame frameElement]): Add nil check.


  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Reverted to previous.
9:55 AM Changeset in webkit [18153] by zimmermann
  • 19 edits in trunk

Reviewed by Sam Weinig.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11801

Autogenerate POD types for ObjC/JS.

This removes the need for the hand-written JSSVG*, DOMSVG* wrappers
in bindings/js, bindings/objc. Makes it much easier to convert more
SVG types to POD types (ie. SVGMatrix* -> AffineTransform etc.)

8:48 AM Changeset in webkit [18152] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2006-12-08 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link
​http://bugs.webkit.org/show_bug.cgi?id=11776

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
8:42 AM Changeset in webkit [18151] by yongjzha
  • 4 edits in S60/trunk/WebKit

2006-12-08 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: TSW Id: PNIO-6TF99Y: "system error" is displayed for http status code 301
​http://bugs.webkit.org/show_bug.cgi?id=11787

  • BrowserView/inc/HttpLoaderEventToUiListener.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ReportHttpError):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::Complete):
  • ChangeLog:
8:24 AM Changeset in webkit [18150] by ap
  • 2 edits in trunk/LayoutTests

Reviewed by Mitz.

Make this test faster by eliminating timeouts (which didn't work anyway, now that
mouse dragging events are stored and replayed on mouse-up).

  • fast/text/atsui-rtl-override-selection.html:
Note: See TracTimeline for information about the timeline view.